[PATCH] grep: restore usage of --include/--exclude options

2024-02-02 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1706834135 18000 # Thu Feb 01 19:35:35 2024 -0500 # Node ID e9a040016017d5cd001119c4aff23d4ce343e572 # Parent 99869dcf3ba06679d73db591a87e739d035770be grep: restore usage of --include/--exclude options The refactor in 4a73df6eb67d

[PATCH] dispatch: properly import custom debugger

2023-10-03 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1696362635 14400 # Tue Oct 03 15:50:35 2023 -0400 # Node ID 1ace547f92f232363f54a6759f3005fc6cb21157 # Parent 752c5a5b73c687588ad0f52a7d9d3e0242709a06 dispatch: properly import custom debugger The __import__ command takes strings

[PATCH] histedit: fix diff colors

2023-03-15 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1666906442 14400 # Thu Oct 27 17:34:02 2022 -0400 # Node ID 28cad0a7eb26a3bb0edd4623d1ec1c9169eb49e2 # Parent dd42156b6441f6b8356100b4228fa16fbf95f669 histedit: fix diff colors The problem here is that indexing a bytestring gives

Re: [PATCH] histedit: fix diff colors

2022-10-27 Thread Jordi Gutiérrez Hermoso
On Thu, 2022-10-27 at 17:37 -0400, Jordi Gutiérrez Hermoso wrote: > On Tue, 2022-10-25 at 21:48 +0200, Joerg Sonnenberger wrote: > > Do we still need the "line and" part of the check? > > Good call, no longer necessary. Will fix in v2, along with a test. Wait, do we

Re: [PATCH] histedit: fix diff colors

2022-10-27 Thread Jordi Gutiérrez Hermoso
On Tue, 2022-10-25 at 21:48 +0200, Joerg Sonnenberger wrote: > Do we still need the "line and" part of the check? Good call, no longer necessary. Will fix in v2, along with a test. ___ Mercurial-devel mailing list

[PATCH] histedit: fix diff colors

2022-10-24 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 145456 14400 # Mon Oct 24 17:04:16 2022 -0400 # Node ID 5287d8898362935f06b482b236ca6ba948c6850d # Parent f68d285158b21d7d13c2a70c8db85e83a83ee392 histedit: fix diff colors I don't know what was up here, but seems like checking

[PATCH] help: properly document the default pattern

2021-12-27 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550269232 18000 # Fri Feb 15 17:20:32 2019 -0500 # Node ID e5b62cbab03e443841b23a333aac035ad3987fbf # Parent d3ec8201610485fa8bfda40771869ae67bfc6404 help: properly document the default pattern The default isn't to glob. It's

[PATCH] largefiles: properly pass kwargs into url.open

2021-02-04 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1612475986 18000 # Thu Feb 04 16:59:46 2021 -0500 # Node ID fee215d5eb63abf93c50de4355fbd46123f50cba # Parent 95b276283b671cd835a2a0918f4297eb2baab425 largefiles: properly pass kwargs into url.open The url.open function has

[PATCH 2 of 2] hgweb: fix error in docstring

2019-12-12 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 157616 18000 # Thu Dec 12 11:41:28 2019 -0500 # Node ID e89a23f05828dc81d5f9f51994544d89fe7a7c4f # Parent faab1971e30741d00b3d0a44548086e6203beca3 hgweb: fix error in docstring Despite the subtle semantic difference

[PATCH 1 of 2] crecord: rewrite help string to avoid mentioning "crecord"

2019-12-12 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1576168650 18000 # Thu Dec 12 11:37:30 2019 -0500 # Node ID faab1971e30741d00b3d0a44548086e6203beca3 # Parent 49fa0b31ee1d84c44eab951f36fb7386e3fced22 crecord: rewrite help string to avoid mentioning "crecord" Despite it

Re: [PATCH 1 of 2] crecord: repurpose "a" key to toggle all selections (BC)

2019-12-11 Thread Jordi Gutiérrez Hermoso
On Wed, 2019-12-11 at 10:41 +0100, Denis Laxalde wrote: Jordi Gutiérrez Hermoso a écrit : > > # HG changeset patch > > # User Jordi Gutiérrez Hermoso > > # Date 1576015329 18000 > > # Tue Dec 10 17:02:09 2019 -0500 > > # Node ID bd10bc4bdb994b875040c0c

[PATCH 2 of 2 V2] crecord: remove toggleamend

2019-12-11 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1576015629 18000 # Tue Dec 10 17:07:09 2019 -0500 # Node ID 80c8a53c2fcc2aeb510f60fee74ab25b68d59a15 # Parent 5b6b8f718cbfc70202537aa38f0179cb6f8275a8 crecord: remove toggleamend Previous commit removed its only calling site. diff

[PATCH 1 of 2 V2] crecord: repurpose "a" key to toggle all selections (BC)

2019-12-11 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1576015329 18000 # Tue Dec 10 17:02:09 2019 -0500 # Node ID 5b6b8f718cbfc70202537aa38f0179cb6f8275a8 # Parent ce088b38f92b6d480df2072dc45fb068443758dd crecord: repurpose "a" key to toggle all selections (BC) I really

[PATCH 1 of 2] crecord: repurpose "a" key to toggle all selections (BC)

2019-12-10 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1576015329 18000 # Tue Dec 10 17:02:09 2019 -0500 # Node ID bd10bc4bdb994b875040c0c58f1c341df66ddd46 # Parent ce088b38f92b6d480df2072dc45fb068443758dd crecord: repurpose "a" key to toggle all selections (BC) I really

[PATCH 2 of 2] crecord: remove toggleamend

2019-12-10 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1576015629 18000 # Tue Dec 10 17:07:09 2019 -0500 # Node ID fa825ca77328e397df683a91c8beeca7060bf726 # Parent bd10bc4bdb994b875040c0c58f1c341df66ddd46 crecord: remove toggleamend Previous commit removed its only calling site. diff

[PATCH 3 of 3] hgweb: add diffs to the json changeset template

2019-11-15 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1573851536 18000 # Fri Nov 15 15:58:56 2019 -0500 # Node ID df8d762ab0683fb2fe337952b906e2944f89aaa2 # Parent 6a9122d3cd3639ddacb8768c573ea9eaeb9a6a33 hgweb: add diffs to the json changeset template While it's possible to get

[PATCH 1 of 3] hgweb: add a status property to file list context

2019-11-15 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1573851721 18000 # Fri Nov 15 16:02:01 2019 -0500 # Node ID 66854dfbde7f2191ff3da155872ac15f1b8e6934 # Parent 303bf312d5edfab57ee03dd7f645b44d105b8bd3 hgweb: add a status property to file list context The web templates merely

[PATCH 2 of 3] hgweb: add files to the json changeset template

2019-11-15 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1573851385 18000 # Fri Nov 15 15:56:25 2019 -0500 # Node ID 6a9122d3cd3639ddacb8768c573ea9eaeb9a6a33 # Parent 66854dfbde7f2191ff3da155872ac15f1b8e6934 hgweb: add files to the json changeset template As far as I can tell, it's

[PATCH 3 of 3 V2] histedit: render a rolled up description using the proper roll colours

2019-11-14 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1572477597 14400 # Wed Oct 30 19:19:57 2019 -0400 # Node ID edc9a7a388b6f939c9464e426fee3de31d005ca7 # Parent b2db799c5a1d3a66961246f9c7598db3dc63c4de histedit: render a rolled up description using the proper roll colours Users

[PATCH 2 of 3 V2] histedit: define new colour pairs for roll action

2019-11-14 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1572478497 14400 # Wed Oct 30 19:34:57 2019 -0400 # Node ID b2db799c5a1d3a66961246f9c7598db3dc63c4de # Parent 0ad29bd65ab45822e2e2a6630860269832aca2fe histedit: define new colour pairs for roll action Red seems like a good colour

[PATCH 1 of 3 V2] histeditrule: split __bytes__ property into prefix and desc

2019-11-14 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1572478029 14400 # Wed Oct 30 19:27:09 2019 -0400 # Node ID 0ad29bd65ab45822e2e2a6630860269832aca2fe # Parent ab9b0a20b9e6b7f1f16f643486ff20a6d44ca2d5 histeditrule: split __bytes__ property into prefix and desc In order to be able

[PATCH 3 of 3] histedit: render a rolled up description using the proper roll colours

2019-11-07 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1572477597 14400 # Wed Oct 30 19:19:57 2019 -0400 # Node ID 4d0d2d692de029b4838d8fc12a48004749db9480 # Parent 47446180a5ee16af1c90bb20a8dca92fa9d5f794 histedit: render a rolled up description using the proper roll colours Users

[PATCH 1 of 3] histeditrule: split __str__ property into prefix and desc

2019-11-07 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1572478029 14400 # Wed Oct 30 19:27:09 2019 -0400 # Node ID 45aea2365bcb5f89d20bb1907d75175246da3d05 # Parent ab9b0a20b9e6b7f1f16f643486ff20a6d44ca2d5 histeditrule: split __str__ property into prefix and desc In order to be able

[PATCH 2 of 3] histedit: define new colour pairs for roll action

2019-11-07 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1572478497 14400 # Wed Oct 30 19:34:57 2019 -0400 # Node ID 47446180a5ee16af1c90bb20a8dca92fa9d5f794 # Parent 45aea2365bcb5f89d20bb1907d75175246da3d05 histedit: define new colour pairs for roll action Red seems like a good colour

D7146: [RFC] grep: add config option to grep PWD by default

2019-10-22 Thread Jordi Gutiérrez Hermoso
JordiGH added a comment. I will repeat my position as stated on IRC. I am against this change because, 1. it's inconsistent with shelve, commit, addremove, status, diff and all other operations that by default work on the entire repo 2. it's difficult to go from this proposed default

Re: [PATCH] grep: warn on censored revisions instead of erroring out

2019-10-22 Thread Jordi Gutiérrez Hermoso
On Tue, 2019-10-22 at 10:39 +0900, Yuya Nishihara wrote: > On Mon, 21 Oct 2019 16:10:58 -0400, Jordi Gutiérrez Hermoso wrote: > > # HG changeset patch > > # User Jordi Gutiérrez Hermoso > > # Date 1571688404 14400 > > # Mon Oct 21 16:06:

[PATCH 1 of 2 V2] grep: warn on censored revisions instead of erroring out

2019-10-22 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1571752600 14400 # Tue Oct 22 09:56:40 2019 -0400 # Node ID 386e0a956ae57a95d62330c95497d7460761f3fd # Parent d782cce137fd1d50cccfecf8ccb17a623fde8800 grep: warn on censored revisions instead of erroring out We need most

[PATCH 2 of 2 V2] censor: document that some commands simply ignore censored data

2019-10-22 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1571752908 14400 # Tue Oct 22 10:01:48 2019 -0400 # Node ID 2bf40680a6362c44c183f17572f24d6ec086a3c6 # Parent 386e0a956ae57a95d62330c95497d7460761f3fd censor: document that some commands simply ignore censored data I can't see

[PATCH] grep: warn on censored revisions instead of erroring out

2019-10-21 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1571688404 14400 # Mon Oct 21 16:06:44 2019 -0400 # Node ID 608193de8560218cc27032977bc380cb8dc0f3f8 # Parent d782cce137fd1d50cccfecf8ccb17a623fde8800 grep: warn on censored revisions instead of erroring out We need most

D7000: grep: enable all-files by default (BC)

2019-10-18 Thread Jordi Gutiérrez Hermoso
JordiGH added a comment. Wait, I found some problems, here is an amendment: # HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1571411921 14400 # Fri Oct 18 11:18:41 2019 -0400 # Node ID 60eb1feadbeebd2ddab16e0d1b4566dbf216333c # Parent

D7000: grep: enable all-files by default (BC)

2019-10-18 Thread Jordi Gutiérrez Hermoso
JordiGH added a comment. In D7000#103065 <https://phab.mercurial-scm.org/D7000#103065>, @khanchi97 wrote: > Sure :) How about something like this? # HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1571411921 14400 # Fri Oct 18 11:18:41 2

D7000: grep: enable all-files by default (BC)

2019-10-08 Thread Jordi Gutiérrez Hermoso
JordiGH added a comment. The docstring needs a significant update too. Would you like me to suggest something? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7000/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7000 To: khanchi97,

D7000: grep: enable all-files by default (BC)

2019-10-08 Thread Jordi Gutiérrez Hermoso
JordiGH added a comment. The docstring needs an update too. INLINE COMMENTS > commands.py:2742 > > By default, grep prints the most recent revision number for each > file in which it finds a match. To get it to print every revision No longer by default! Or perhaps at all.

Re: Interest in integrating hg-git into Mercurial

2019-08-01 Thread Jordi Gutiérrez Hermoso
On Thu, 2019-08-01 at 10:01 -0700, Gregory Szorc wrote: > Is there any interest in integrating hg-git (or hg-git > functionality) into the Mercurial distribution as an officially > supported extension? I know at least one person who was interested in using hg but was thwarted by hg-git and never

D6613: commit: improve the files field of changelog for merges (RFC)

2019-07-11 Thread Jordi Gutiérrez Hermoso
JordiGH added inline comments. INLINE COMMENTS > valentin.gatienbaron wrote in localrepo.py:2658 > It'd be trivial to change the code to check both parents, but I find what you > say surprising. Aren't there plenty of places in hg that do checks similar to > this one: > >

D6613: commit: improve the files field of changelog for merges (RFC)

2019-07-10 Thread Jordi Gutiérrez Hermoso
JordiGH added inline comments. INLINE COMMENTS > localrepo.py:2658 > del m[f] > +if p2.rev() != nullrev: > +@util.cachefunc Not all merges can be detected by checking for p2 being non-null; p1 being null but p2 being non-null is

Re: [PATCH] histedit: make actions toggleables

2019-05-13 Thread Jordi Gutiérrez Hermoso
On Sun, 2019-05-12 at 20:17 -0700, Feng Yu wrote: > To clarify, the change I propose is in the ncurses based _chistedit UI, which > does display the graph. > It does not change the behaviour of TUI version of _histedit.  "TUI" and "curses" mean the same thing, generally. Maybe we should call the

Re: [PATCH] histedit: Show file names in multiple line format

2019-05-02 Thread Jordi Gutiérrez Hermoso
On Thu, 2019-05-02 at 16:51 -0700, Martin von Zweigbergk wrote: > I've queued these mostly bases on Jordi's review. Thanks to both of you! Wait wait, I had stylistic complaints, but I couldn't get to them! Ah, well, I'll submit follow-ups. These patches are definite improvements.

Re: Changing the wdir() {rev} and {node} output

2019-04-29 Thread Jordi Gutiérrez Hermoso
On Wed, 2019-04-17 at 08:29 +0900, Yuya Nishihara wrote: > On Tue, 16 Apr 2019 10:14:53 -0400, Jordi Gutiérrez Hermoso wrote: > > While I think it might be okay to keep the iternal values, > >  > > https://www.mercurial-scm.org/repo/hg/file/967c098eed33/mercurial/node.py#l39

[PATCH] chistedit: use context manager to set verbose ui

2019-04-16 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1555434741 14400 # Tue Apr 16 13:12:21 2019 -0400 # Node ID f64bbdc70aaa1ca8c504c2d909f6012927a27cb8 # Parent a362b0b95e42c8f7d46d7e3a0eb4cc531fa5f2d6 chistedit: use context manager to set verbose ui I'm still not exactly sure why

Changing the wdir() {rev} and {node} output

2019-04-16 Thread Jordi Gutiérrez Hermoso
While I think it might be okay to keep the iternal values, https://www.mercurial-scm.org/repo/hg/file/967c098eed33/mercurial/node.py#l39 I think it's far too confusing to expose them in the user interface. A particular inconsistency I see is that we already have a way to show wdir(), for

Re: [PATCH 2 of 3] revset: implement copies and renames for checkstatus

2019-04-08 Thread Jordi Gutiérrez Hermoso
On Sun, 2019-04-07 at 09:55 +0900, Yuya Nishihara wrote: > On Fri, 05 Apr 2019 14:42:38 -0400, Jordi Gutiérrez Hermoso wrote: > > @@ -624,7 +627,18 @@ def checkstatus(repo, subset, pat, field > >  break > >  else: > >   

Re: [PATCH] chistedit: properly show verbose diffs

2019-04-08 Thread Jordi Gutiérrez Hermoso
On Sat, 2019-04-06 at 09:46 +0900, Yuya Nishihara wrote: > On Thu, 04 Apr 2019 10:47:49 -0400, Jordi Gutiérrez Hermoso wrote: > > diff --git a/hgext/histedit.py b/hgext/histedit.py > > --- a/hgext/histedit.py > > +++ b/hgext/histedit.py > > @@ -1230,8 +1230,9 @@ def a

Re: [PATCH 3 of 3] revset: two new revsets, copies and renames

2019-04-07 Thread Jordi Gutiérrez Hermoso
On Sun, 2019-04-07 at 09:48 +0900, Yuya Nishihara wrote: > So they are quite similar to -r 'file("set:copied()")', and we do include > renames in copies in general. Hm, but we don't have a renamed() fileset, do we? How do you find renames? > I think these predicates are useful, but it's

[PATCH 2 of 2 V2] chistedit: add basic colours to diff view

2019-04-05 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1554350103 14400 # Wed Apr 03 23:55:03 2019 -0400 # Node ID 93b81d9461e703176801fc425d9e9f75275abc02 # Parent ede500c898adaab1d78f5e048fe84774c9f01fea chistedit: add basic colours to diff view This isn't complete, and it would

[PATCH 1 of 2 V2] chistedit: use default curses colours

2019-04-05 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1554490485 14400 # Fri Apr 05 14:54:45 2019 -0400 # Node ID ede500c898adaab1d78f5e048fe84774c9f01fea # Parent a975821d0938615b8cb235f12cc6461a42dcfbd8 chistedit: use default curses colours Terminals will define default colours

[PATCH 1 of 3] revset: short docstring for checkstatus

2019-04-05 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1554489052 14400 # Fri Apr 05 14:30:52 2019 -0400 # Node ID 9fcb915a73b83547921aaa13584c88cb99c6aee7 # Parent a975821d0938615b8cb235f12cc6461a42dcfbd8 revset: short docstring for checkstatus This is where all the action happens

[PATCH 2 of 3] revset: implement copies and renames for checkstatus

2019-04-05 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1554489104 14400 # Fri Apr 05 14:31:44 2019 -0400 # Node ID 4baa10f1f44a8e427f49fa4f4d8d29552c2a1a65 # Parent 9fcb915a73b83547921aaa13584c88cb99c6aee7 revset: implement copies and renames for checkstatus Determining when a file

[PATCH 3 of 3] revset: two new revsets, copies and renames

2019-04-05 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1554489566 14400 # Fri Apr 05 14:39:26 2019 -0400 # Node ID cf6a3da4082569df7b5dd83ab61fcbedc70839f1 # Parent 4baa10f1f44a8e427f49fa4f4d8d29552c2a1a65 revset: two new revsets, copies and renames diff --git a/mercurial/revset.py b

[PATCH] chistedit: properly show verbose diffs

2019-04-04 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1554388915 14400 # Thu Apr 04 10:41:55 2019 -0400 # Node ID 704f79617827ab0c19a788715b797fcfe8557cea # Parent 4ee906aa7b60fb6b113e4dc187fbb5a8f42e557c chistedit: properly show verbose diffs I'm not sure if that ever worked and it's

Re: [PATCH] chistedit: add basic colours to diff view

2019-04-04 Thread Jordi Gutiérrez Hermoso
On Wed, 2019-04-03 at 23:56 -0400, Jordi Gutiérrez Hermoso wrote: > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1554350103 14400 > #  Wed Apr 03 23:55:03 2019 -0400 > # Node ID d0a4c3ae200ffdfc247f5e2f1897196512615087 > # Parent  4ee906aa7b60fb6b113e4d

[PATCH] chistedit: add basic colours to diff view

2019-04-03 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1554350103 14400 # Wed Apr 03 23:55:03 2019 -0400 # Node ID d0a4c3ae200ffdfc247f5e2f1897196512615087 # Parent 4ee906aa7b60fb6b113e4dc187fbb5a8f42e557c chistedit: add basic colours to diff view This isn't complete, and it would

[PATCH] chistedit: use default curses colours

2019-04-03 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1554347266 14400 # Wed Apr 03 23:07:46 2019 -0400 # Node ID 263cec9c08fc1b517847fe53f27b47978be127f4 # Parent 4ee906aa7b60fb6b113e4dc187fbb5a8f42e557c chistedit: use default curses colours Terminals will define default colours

D6178: crecord: new keys g & G to navigate to the top and bottom respectively

2019-04-02 Thread Jordi Gutiérrez Hermoso
JordiGH added inline comments. INLINE COMMENTS > crecord.py:1471 > + g : go to the first hunk line > + G : go to the last hunk line >f : fold / unfold item, hiding/revealing its children We should find a better way to phrase

[PATCH] chistedit: change in-progress message

2019-03-26 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1553615610 14400 # Tue Mar 26 11:53:30 2019 -0400 # Node ID 5184a81a2a3b85327e15806158101acd5a685d44 # Parent 00c1ee0f746a5f427e81e6d18e681f6a70a2639d chistedit: change in-progress message Saying "running histedit" is a

[PATCH] shelve: add --keep to list of allowables

2019-03-24 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1553472793 14400 # Sun Mar 24 20:13:13 2019 -0400 # Node ID 4b1cb76ab29461a0a4c5ff12bb364ea2bb5b1b89 # Parent 50d5e64ec561a8227ad32fe86c1811963e7664cd shelve: add --keep to list of allowables diff --git a/hgext/shelve.py b/hgext

[PATCH] phabricator: better error message when phabread fails to get a differential

2019-03-24 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Laurent Peuch # Date 1553469818 14400 # Sun Mar 24 19:23:38 2019 -0400 # Node ID a39d18493bf66aa29f7d0dc1c5a4164b84507e1b # Parent ba064f95175e6cb1467401a3a536d8c32229d4b1 phabricator: better error message when phabread fails to get a differential diff --git

[PATCH 2 of 3 V2] shelve: refactor _shelvecreatedcommit's match object into calling site

2019-03-22 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1553274206 14400 # Fri Mar 22 13:03:26 2019 -0400 # Node ID e61152452e42c8bd357618f389afca8492e05651 # Parent 773e8b313d28d85002c459ea69d3671e7a0bc05e shelve: refactor _shelvecreatedcommit's match object into calling site We might

[PATCH 1 of 3 V2] shelve: new keep option

2019-03-22 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1553268263 14400 # Fri Mar 22 11:24:23 2019 -0400 # Node ID 773e8b313d28d85002c459ea69d3671e7a0bc05e # Parent b1bc6e5f5249d0633db73be3c6853273485f3919 shelve: new keep option Does nothing yet. The docstring describes what

[PATCH 3 of 3 V2] shelve: do not update when keeping changes, just move the dirstate

2019-03-22 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1553268407 14400 # Fri Mar 22 11:26:47 2019 -0400 # Node ID 370831f0c08f4f635874d6abb0505825024f6b36 # Parent e61152452e42c8bd357618f389afca8492e05651 shelve: do not update when keeping changes, just move the dirstate

[PATCH 2 of 2] samplehgrcs: update the list of suggested extensions

2019-03-22 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1553272205 14400 # Fri Mar 22 12:30:05 2019 -0400 # Node ID 69a86f363473147d9befa7aedde1867075cda0b1 # Parent a4799c377f869cd6b0e7f5233d7bfed4c647cccb samplehgrcs: update the list of suggested extensions Back in the day

[PATCH 1 of 2] samplehgrcs: clarify which lines should be uncommented

2019-03-22 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1553272139 14400 # Fri Mar 22 12:28:59 2019 -0400 # Node ID a4799c377f869cd6b0e7f5233d7bfed4c647cccb # Parent b1bc6e5f5249d0633db73be3c6853273485f3919 samplehgrcs: clarify which lines should be uncommented The original wording has

[PATCH 1 of 3] shelve: new keep option

2019-03-22 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1553268263 14400 # Fri Mar 22 11:24:23 2019 -0400 # Node ID 773e8b313d28d85002c459ea69d3671e7a0bc05e # Parent b1bc6e5f5249d0633db73be3c6853273485f3919 shelve: new keep option Does nothing yet. The docstring describes what

[PATCH 2 of 3] shelve: do not update when keeping changes, just set the right parent

2019-03-22 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1553268335 14400 # Fri Mar 22 11:25:35 2019 -0400 # Node ID 6bff7f54a5f20e72e63edbceb2a34d86fb4c86f4 # Parent 773e8b313d28d85002c459ea69d3671e7a0bc05e shelve: do not update when keeping changes, just set the right parent

[PATCH 3 of 3] shelve: do not restore dirstate when keeping wdir changes

2019-03-22 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1553268407 14400 # Fri Mar 22 11:26:47 2019 -0400 # Node ID c0f2ceec4a2d06bb4950916db3bb91300cb091da # Parent 6bff7f54a5f20e72e63edbceb2a34d86fb4c86f4 shelve: do not restore dirstate when keeping wdir changes This completes

Re: [PATCH] chistedit: ensure a locale is set

2019-02-19 Thread Jordi Gutiérrez Hermoso
On Wed, 2019-02-20 at 11:22 +0900, Yuya Nishihara wrote: > Perhaps, we shouldn't do setlocale() until curses is actually used. Hm, that's a good point. Move it to _chisteditmain? That's the entry point, I think. Or maybe we should make our own wrapper curses module so it can be demandimported

Re: [PATCH 3 of 3 V2] color: change color of grep.rev label

2019-02-19 Thread Jordi Gutiérrez Hermoso
On Wed, 2019-02-20 at 11:49 +0900, Yuya Nishihara wrote: > I've marked this as "(BC)" since this is IMHO a significant change. > Blue on black is unreadable on my machine. It's kind of hard to predict what will be readable. Linux terminal emulators usually let you define "blue" to be whatever

Re: [PATCH] chistedit: ensure a locale is set

2019-02-19 Thread Jordi Gutiérrez Hermoso
On Tue, 2019-02-19 at 10:29 -0500, Augie Fackler wrote: > On Fri, Feb 15, 2019 at 02:59:37PM -0500, Jordi Gutiérrez Hermoso wrote: > > # HG changeset patch > > # User Jordi Gutiérrez Hermoso > > # Date 1550260567 18000 > > # Fri Feb 15 14:56:

[PATCH] negrev: return empty for wdir() and nullrev

2019-02-18 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550551420 18000 # Mon Feb 18 23:43:40 2019 -0500 # Node ID 379d5bef7d3601d43c5d7d4c4c39d7014bc71208 # Parent 37b33c34bf4f890857b5e8728febbc82a99368a5 negrev: return empty for wdir() and nullrev I considered just returning the same

[PATCH] test-sqlitestore: run sqlite3 with no init file

2019-02-18 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550533461 18000 # Mon Feb 18 18:44:21 2019 -0500 # Node ID 3cac2f5ea9314a7d45079e629e0570bebcb3b6bf # Parent 37b33c34bf4f890857b5e8728febbc82a99368a5 test-sqlitestore: run sqlite3 with no init file These tests were failing for me

[PATCH 3 of 3 V2] color: change color of grep.rev label

2019-02-18 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550263757 18000 # Fri Feb 15 15:49:17 2019 -0500 # Node ID 4b06afa25bb124da32fcaa56d2b81405b4163b61 # Parent 1ef5e748ebdeec679227f78179bd36bb9b3a1667 color: change color of grep.rev label GNU grep uses green for line numbers as we

[PATCH 1 of 3 V2] grep: give different labels to + and - symbols

2019-02-18 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550262244 18000 # Fri Feb 15 15:24:04 2019 -0500 # Node ID 14bb51f7e85c68b31a96ea6447f7439ac2d87e18 # Parent 37b33c34bf4f890857b5e8728febbc82a99368a5 grep: give different labels to + and - symbols I find it more useful to give

[PATCH 2 of 3 V2] color: give colours to the grep.inserted and grep.deleted labels

2019-02-18 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550263402 18000 # Fri Feb 15 15:43:22 2019 -0500 # Node ID 1ef5e748ebdeec679227f78179bd36bb9b3a1667 # Parent 14bb51f7e85c68b31a96ea6447f7439ac2d87e18 color: give colours to the grep.inserted and grep.deleted labels I find

Re: Mercurial docs improvements?

2019-02-18 Thread Jordi Gutiérrez Hermoso
On Mon, 2019-02-18 at 17:15 -0500, Ludovic Chabant wrote: > So as such, I don't think it's a good fit for a global, > repo-independent reference documentation. There's an important dogfooding component here. If we think that the hgweb docs are useless, then we should completely get rid of them

Re: Mercurial docs improvements?

2019-02-18 Thread Jordi Gutiérrez Hermoso
On Mon, 2019-02-18 at 12:48 -0500, Ludovic Chabant wrote: > > 1. Make doc/Makefile also generate one html and man page per command and >extension. > > - This would let us see the doc for, say, `hg status` over at > https://www.mercurial-scm.org/doc/hg-status.1.html As we discussed in IRC,

Re: [PATCH V2] templatekw: add a {negrev} keyword

2019-02-18 Thread Jordi Gutiérrez Hermoso
On Mon, 2019-02-18 at 22:29 +0900, Yuya Nishihara wrote: > The word "negative revision" isn't correct, Why do you think so? The full phrase is "negative revision number", isn't it? > > --- a/mercurial/templatekw.py > > +++ b/mercurial/templatekw.py > > @@ -777,6 +777,14 @@ def showrev(context,

[PATCH 1 of 3] grep: give different labels to + and - symbols

2019-02-15 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550262244 18000 # Fri Feb 15 15:24:04 2019 -0500 # Node ID b5464436e4acdd1893ee86e5aa03f1d69ce4c4c5 # Parent a22321f2b1ee18ea09a70fee9e524d2f0298 grep: give different labels to + and - symbols I find it more useful to give

[PATCH 2 of 3] color: give colours to the grep.inserted and grep.deleted labels

2019-02-15 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550263402 18000 # Fri Feb 15 15:43:22 2019 -0500 # Node ID 9e2f595cf719f2dd863485067517f4f6c05dee73 # Parent b5464436e4acdd1893ee86e5aa03f1d69ce4c4c5 color: give colours to the grep.inserted and grep.deleted labels I find

[PATCH 3 of 3] color: change color of grep.rev label

2019-02-15 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550263757 18000 # Fri Feb 15 15:49:17 2019 -0500 # Node ID 07f0f1082c85076b6e0d0cb215fb34893170c11c # Parent 9e2f595cf719f2dd863485067517f4f6c05dee73 color: change color of grep.rev label GNU grep uses green for line numbers as we

[PATCH V2] templatekw: add a {negrev} keyword

2019-02-15 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550259811 18000 # Fri Feb 15 14:43:31 2019 -0500 # Node ID 2aa9472715119f26f2e688dd9130f717113ec518 # Parent a22321f2b1ee18ea09a70fee9e524d2f0298 templatekw: add a {negrev} keyword Revision numbers are getting much maligned

[PATCH] chistedit: ensure a locale is set

2019-02-15 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550260567 18000 # Fri Feb 15 14:56:07 2019 -0500 # Node ID 611f94479e62c720f7f90f3a58137e97aa600fcb # Parent a22321f2b1ee18ea09a70fee9e524d2f0298 chistedit: ensure a locale is set My paternal surname was showing incorrectly

[PATCH] crecord: remove obsolete version check

2019-02-14 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550158907 18000 # Thu Feb 14 10:41:47 2019 -0500 # Node ID 9c5c236afcc631d0dfc6a3e1424e353f6c6c85bf # Parent 5d383d9636d0b81b416398913b32b8c715e98db5 crecord: remove obsolete version check An internal function shouldn't

[PATCH V2] fix: change the default fix pattern (issue6077)

2019-02-13 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550096863 18000 # Wed Feb 13 17:27:43 2019 -0500 # Node ID d8ba3b6466b220a5e04d07a5eccd3c1d45a2f501 # Parent 5d383d9636d0b81b416398913b32b8c715e98db5 fix: change the default fix pattern (issue6077) The matchutils functions don't

[PATCH] fix: change the default fix pattern (issue6077)

2019-02-13 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550096863 18000 # Wed Feb 13 17:27:43 2019 -0500 # Node ID c56534966c1641a50994a02c746e5b17cb00aa0e # Parent 5d383d9636d0b81b416398913b32b8c715e98db5 fix: change the default fix pattern (issue6077) The matchutils functions don't

[PATCH] chistedit: use magenta for current line as in crecord (issue6071)

2019-02-13 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550095104 18000 # Wed Feb 13 16:58:24 2019 -0500 # Node ID e31eb021571e1a6a63aab8090819184576236c58 # Parent 5d383d9636d0b81b416398913b32b8c715e98db5 chistedit: use magenta for current line as in crecord (issue6071

[PATCH] histedit: remove "chistedit" mention from interface

2019-02-13 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550091764 18000 # Wed Feb 13 16:02:44 2019 -0500 # Node ID 94ccf890584ee3bae9e543fade578e0f05281347 # Parent 5d383d9636d0b81b416398913b32b8c715e98db5 histedit: remove "chistedit" mention from interface "chisted"

D5949: debugpathcopies: fix typo in synpsis

2019-02-12 Thread Jordi Gutiérrez Hermoso
JordiGH added a comment. So, I haven't been here in a while. Do we still do V2s for this kind of thing? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5949 To: martinvonz, #hg-reviewers Cc: JordiGH, mercurial-devel

D5949: debugpathcopies: fix typo in synpsis

2019-02-12 Thread Jordi Gutiérrez Hermoso
JordiGH added a comment. > fix typo in synpsis > in synpsis > synpsis https://en.wikipedia.org/wiki/Muphry%27s_law REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5949 To: martinvonz, #hg-reviewers Cc: JordiGH, mercurial-devel

[PATCH] walkchangerevs: obey allfiles parameter when taking the slow path

2019-02-12 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550009431 18000 # Tue Feb 12 17:10:31 2019 -0500 # Node ID 06f76b4009c4802a48abc184984d0eebc7d7d91e # Parent 61415361e90684a8c7a031413e9182f51937c2e7 walkchangerevs: obey allfiles parameter when taking the slow path When

Re: [PATCH 1 of 5] changelog: introduce a 'tiprev' method

2018-01-18 Thread Jordi Gutiérrez Hermoso
On Wed, 2018-01-17 at 19:33 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1493857401 -7200 > #  Thu May 04 02:23:21 2017 +0200 > # Node ID e3bb410037a49980a8316e4e5a49ab23ea978047 > # Parent  0e369eca888fc80ee980fe8200c59dc7b0024dae > #

Re: [PATCH 2 of 2] templatekw: add a {negrev} keyword

2018-01-18 Thread Jordi Gutiérrez Hermoso
On Thu, 2018-01-18 at 21:05 +0900, Yuya Nishihara wrote: > On Wed, 17 Jan 2018 22:14:30 -0500, Jordi Gutiérrez Hermoso wrote: > > # HG changeset patch > > # User Jordi Gutiérrez Hermoso <jord...@octave.org> > > # Date 1516243120 18000 > > #  Wed Jan 17

Re: [PATCH 1 of 2] templatekw: add utility function numrevs

2018-01-18 Thread Jordi Gutiérrez Hermoso
On Thu, 2018-01-18 at 21:03 +0900, Yuya Nishihara wrote: > On Wed, 17 Jan 2018 22:14:29 -0500, Jordi Gutiérrez Hermoso wrote: > > # HG changeset patch > > # User Jordi Gutiérrez Hermoso <jord...@octave.org> > > # Date 1516242948 18000 > > #  Wed Jan 17

[PATCH 1 of 2] templatekw: add utility function numrevs

2018-01-17 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso <jord...@octave.org> # Date 1516242948 18000 # Wed Jan 17 21:35:48 2018 -0500 # Node ID 701f8a9defdc09bb63f2596e2fc426f2e78da313 # Parent 0e369eca888fc80ee980fe8200c59dc7b0024dae templatekw: add utility function numrevs len(repo)

[PATCH 2 of 2] templatekw: add a {negrev} keyword

2018-01-17 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso <jord...@octave.org> # Date 1516243120 18000 # Wed Jan 17 21:38:40 2018 -0500 # Node ID cbf1d676a938e78d40cd3504dd916f787bcb47ee # Parent 701f8a9defdc09bb63f2596e2fc426f2e78da313 templatekw: add a {negrev} keyword Revision n

[PATCH] test-convert-svn-move: sort svn checkout output

2018-01-17 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso <jord...@octave.org> # Date 1516245130 18000 # Wed Jan 17 22:12:10 2018 -0500 # Node ID 358f30e953d94c13d0dbf4c149130ab69f2c76bf # Parent 3a379eceab7886ae9a8f661c648c2759c69a9013 test-convert-svn-move: sort svn checkout output It tur

Re: Ideas and mentors for GSoC 2018.

2018-01-17 Thread Jordi Gutiérrez Hermoso
On Wed, 2018-01-17 at 01:01 +0530, Pulkit Goyal wrote: > Also, if you have sometime available during the summers and > interested to mentor a student in the program, it will be great. > Please let me know. I think GrepPlan might be feasible for a GSoC student. If you agree, I can probably mentor

[PATCH 3 of 3] svnsubrepo: check if subrepo is missing when checking dirty state (issue5657)

2018-01-16 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso <jord...@octave.org> # Date 1516110014 18000 # Tue Jan 16 08:40:14 2018 -0500 # Node ID 3a379eceab7886ae9a8f661c648c2759c69a9013 # Parent cebbb137db75c45e891a65a8dbc50631ed8cb83c svnsubrepo: check if subrepo is missing when checking

[PATCH 1 of 3] svnsubrepo: decorate dirty method with annotatesubrepoerror

2018-01-16 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso <jord...@octave.org> # Date 1515949528 18000 # Sun Jan 14 12:05:28 2018 -0500 # Node ID fde3cd2487e1f4d5867bf8c6e79139b6fe475779 # Parent 58fda95a0202fc6327d1f5d9df26f7ff16538d57 svnsubrepo: decorate dirty method with annotatesubrep

[PATCH] templates: reword 'back to filelog' link anchor text

2017-11-20 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso <jord...@octave.org> # Date 1511206254 18000 # Mon Nov 20 14:30:54 2017 -0500 # Node ID 9f2ad7bc901216d6340952f463ab06568fc82dfb # Parent 75013952d8d9608f73cd45f68405fbd6ec112bf2 templates: reword 'back to filelog' link ancho

Re: [PATCH evolve-ext] fold: disallow multiple revisions without --exact

2016-11-19 Thread Jordi Gutiérrez Hermoso
On Fri, 2016-11-04 at 16:58 -0700, Martin von Zweigbergk via Mercurial-devel wrote: > # HG changeset patch > # User Martin von Zweigbergk > # Date 1478303512 25200 > # Fri Nov 04 16:51:52 2016 -0700 > # Node ID bb80851fe9a6e14263f0076074108556377141f9 > # Parent

  1   2   >