D1720: debug: add newlines at the end of three locations that appear to need it

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7906354cbc68: debug: add newlines at the end of three locations that appear to need it (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercuria

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY A user was in #mercurial and had the following settings in their hgrc: [ui] editor = C:\home\npp\notepad++.exe -multiInst -nosession After shlexspli

D1809: tests: switch test from '--config ui.editor=~/foo' to HGEDITOR=~/foo

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The test is currently not testing anything, the '--config ui.editor=~/path' argument is apparently of lower priority than the HGEDITOR that run-tests.py is set

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

spectral updated this revision to Diff 4694. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1808?vs=4692&id=4694 REVISION DETAIL https://phab.mercurial-scm.org/D1808 AFFECTED FILES mercurial/debugcommands.py tests/test-install.t CHANGE DETAILS dif

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

spectral updated this revision to Diff 4695. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1808?vs=4694&id=4695 REVISION DETAIL https://phab.mercurial-scm.org/D1808 AFFECTED FILES mercurial/debugcommands.py tests/test-install.t CHANGE DETAILS dif

D1809: tests: switch test from '--config ui.editor=~/foo' to HGEDITOR=~/foo

This revision was automatically updated to reflect the committed changes. Closed by commit rHG711149d8e676: tests: switch test from '--config ui.editor=~/foo' to HGEDITOR=~/foo (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-sc

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

spectral updated this revision to Diff 4714. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1808?vs=4695&id=4714 REVISION DETAIL https://phab.mercurial-scm.org/D1808 AFFECTED FILES mercurial/debugcommands.py tests/test-install.t CHANGE DETAILS dif

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

spectral added inline comments. INLINE COMMENTS > krbullock wrote in debugcommands.py:1212 > In this patch, we end up printing something potentially different in the > "checking" line than in the "can't find editor" line. That seems wrong. I > think I'd rather we do the shlexsplit before writin

D1935: tests: update test to work with Git 2.16

spectral accepted this revision. spectral added a comment. I've also been seeing these failures, thanks! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1935 To: indygreg, #hg-reviewers, spectral Cc: spectral, mercurial-devel _

D2012: merge: use operation-provided labels (ex: dest/source) in several merge-tools

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Tools that did not use labels already, used only one, or used some label other than the exact strings of "local" or "other" were unmodified. Cases that used th

D2011: filemerge: support passing labels to external merge tools

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This adds $labellocal, $labelother, and $labelbase to the replacement set for merge-tools..args config variables, and to the environment as HG_MY_LABEL, HG_OTH

D2013: commit: allow --no-secret to override phases.new-commit setting

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, if the user had phases.new-commit=secret, there was no way on the command line to commit as draft. This lets the user specify --no-secret to request

D2016: split: preserve phase of commit that is being split

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY With this change, `hg split` will preserve the phase of the commit that is being split, ignoring the phases.new-commit setting. Previously, we would use whateve

D2014: amend: --no-secret overrides phases.new-commit and previous phase

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, commit --amend would keep the phase of the commit that's being amended, and commit --amend --secret would force it to secret. There was no mechanism

D2017: split: accept a --secret flag to force phase of new commits

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is for parity with the identically named option on the `hg commit` (including `hg commit --amend`) command. REPOSITORY rHG Mercurial REVISION DETAIL ht

D2015: tests: in test-split.t, save a "clean" copy of pre-split repo for later use

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2015 AFFECTED FILES tests/test-split.t CHANGE DETAILS diff --git a/tests/test-split.t b/tests/test-s

D2012: merge: use operation-provided labels (ex: dest/source) in several merge-tools

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa9802c9ecfb5: merge: use operation-provided labels (ex: dest/source) in several merge-tools (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mer

D2011: filemerge: support passing labels to external merge tools

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9037c29e9f53: filemerge: support passing labels to external merge tools (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2011

D2013: commit: allow --no-secret to override phases.new-commit setting

spectral added a comment. In https://phab.mercurial-scm.org/D2013#33867, @martinvonz wrote: > I wonder if we should instead have a --draft option for this. Reasons: > > - If we ever add a fourth phase (like Jun's proposed "archived" phase), then --no-secret doesn't clearly indicate "d

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

spectral marked an inline comment as done. spectral added a comment. Sorry, I forgot about this, can you take another look? I believe I addressed your most recent comment. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1808 To: spectral, #hg-reviewers, krbullo

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG04e81ae47066: debugcommands: print out the editor that was searched for (post shlexsplit) (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercu

D3559: narrow: only wrap dirstate functions once, instead of per-reposetup

spectral created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY chg will call reposetup multiple times, and we will end up double-wrapping (or worse) the dirstate functions; this can cause iss

D3562: tests: mark tests that fail when using chg as #require no-chg

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As far as I can tell, most of these failures are due to using $HGPORT, which it seems chg might be using itself? I don't know enough to debug these failures to

D3562: tests: mark tests that fail when using chg as #require no-chg

This revision was automatically updated to reflect the committed changes. Closed by commit rHG538e850ae737: tests: mark tests that fail when using chg as #require no-chg (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D

D3571: tests: test-parseindex.t works just fine with chg

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In https://phab.mercurial-scm.org/rHG538e850ae73745c55bbb7da1ee3659c21a315688 I annotated tests that failed with chg with "#require no-chg", but did not investig

D3571: tests: test-parseindex.t works just fine with chg

This revision was automatically updated to reflect the committed changes. Closed by commit rHGca890999d317: tests: test-parseindex.t works just fine with chg (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3571?vs=8720

D3577: crecord: fallback to text mode if diffs are too big for curses mode

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY crecord uses curses.newpad to create a region that we can then scroll around in by moving the main 'screen' as a veiwport into the (probably larger than the ac

D3577: crecord: fallback to text mode if diffs are too big for curses mode

This revision was automatically updated to reflect the committed changes. Closed by commit rHGdabc2237963c: crecord: fallback to text mode if diffs are too big for curses mode (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm

D3559: narrow: only wrap dirstate functions once, instead of per-reposetup

spectral updated this revision to Diff 8744. spectral edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3559?vs=8682&id=8744 REVISION DETAIL https://phab.mercurial-scm.org/D3559 AFFECTED FILES hgext/narrow/__init__.py

D3559: narrow: only wrap dirstate functions once, instead of per-reposetup

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1cba497491be: narrow: only wrap dirstate functions once, instead of per-reposetup (authored by spectral, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3559?vs=8744&id=8871#toc

D3643: localrepo: add docstring to _makedirstate to make it less likely to be removed

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3643 AFFECTED FILES mercurial/localrepo.py CHANGE DETAILS diff --git a/mercurial/localrepo.py b/merc

D3643: localrepo: add docstring to _makedirstate to make it less likely to be removed

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2b8cb0ab231c: localrepo: add docstring to _makedirstate to make it less likely to be removed (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.me

D3655: graph: add outputgraph() function, called by ascii() to printthe graph to the ui.

spectral accepted this revision. spectral added a comment. lgtm, and as long as there's no test differences seems fine. (I don't have ability to accept the patch, and this is from another Googler anyway, so this is just first-stage review). REPOSITORY rHG Mercurial REVISION DETAIL https

D3665: graph: improve graph output by using Unicode characters

spectral accepted this revision. spectral added a comment. lgtm, but yuja had asked for sean and others to look, and I don't have push access :) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3665 To: johnstiles, #hg-reviewers, spectral Cc: spectral, indygreg,

D3665: graph: improve graph output by using Unicode characters

spectral added a comment. In https://phab.mercurial-scm.org/D3665#58616, @smf wrote: > johnstiles (John Stiles) writes: > > > johnstiles added a comment. > > > > Hi there @indygreg and @yuja -- are you happy with the diff as it currently stands? Do you think this needs any ad

D3716: ui: add an unsafeoperation context manager that can block SIGINT

spectral added a comment. In https://phab.mercurial-scm.org/D3716#58934, @indygreg wrote: > I agree with @yuja that we should move this to `util.py` or one of its siblings and rename it to `uninterruptable` or some such. > > That being said, signal handlers are process global. And we

D2015: tests: in test-split.t, save a "clean" copy of pre-split repo for later use

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa0e185f10454: tests: in test-split.t, save a "clean" copy of pre-split repo for later use (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.merc

D3858: unlinkpath: make empty directory removal optional (issue5901) (issue5826)

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are known cases where performing operations such as rebase from a directory that is newly created can fail or at least lead to being in a directory handle

D3859: unlinkpath: make empty directory removal optional (issue5901) (issue5826)

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are known cases where performing operations such as rebase from a directory that is newly created can fail or at least lead to being in a directory handle

D3858: unlinkpath: make empty directory removal optional (issue5901) (issue5826)

spectral abandoned this revision. spectral added a comment. (Sorry for the double send) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3858 To: spectral, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing li

D3859: unlinkpath: make empty directory removal optional (issue5901) (issue5826)

spectral updated this revision to Diff 9351. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3859?vs=9350&id=9351 REVISION DETAIL https://phab.mercurial-scm.org/D3859 AFFECTED FILES mercurial/cmdutil.py mercurial/configitems.py mercurial/context.py

D3859: unlinkpath: make empty directory removal optional (issue5901) (issue5826)

spectral added inline comments. INLINE COMMENTS > test-removeemptydirs.t:125 > +error or no files listed > +#if linuxormacos > + $ isfile foo I'm rather uncertain about this, but there's no generic 'linux' in hghave at the moment; I'm testing on my mac now. REPOSITORY rHG Mercurial REVISIO

D3859: unlinkpath: make empty directory removal optional (issue5901) (issue5826)

spectral marked an inline comment as done. spectral added a comment. (Tests pass on my mac as well) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3859 To: spectral, #hg-reviewers Cc: mercurial-devel ___ Mercurial-deve

D3859: unlinkpath: make empty directory removal optional (issue5901) (issue5826)

This revision was automatically updated to reflect the committed changes. Closed by commit rHGda2a7d8354b2: unlinkpath: make empty directory removal optional (issue5901) (issue5826) (authored by spectral, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3859?vs=9351&id=93

D3927: removeemptydirs: add test for `hg split` inside a disappearing directory

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3927 AFFECTED FILES tests/test-removeemptydirs.t CHANGE DETAILS diff --git a/tests/test-removeemptyd

D3927: removeemptydirs: add test for `hg split` inside a disappearing directory

This revision was automatically updated to reflect the committed changes. Closed by commit rHGad2aa4e85047: removeemptydirs: add test for `hg split` inside a disappearing directory (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercuria

D3948: curses: use "text" interface if TERM=dumb

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3948 AFFECTED FILES mercurial/ui.py tests/test-commit-interactive-curses.t CHANGE DETAILS diff --g

D3948: curses: use "text" interface if TERM=dumb

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd79f3afb079e: curses: use "text" interface if TERM=dumb (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3948?vs=9600&id=9616

D4035: resolve: add option to warn/abort on -m with unresolved conflict markers

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When a user is dropped out of Mercurial to a terminal to resolve files, we emit messages like: conflicts while merging file1! (edit, then use 'hg resolve

D4035: resolve: add option to warn/abort on -m with unresolved conflict markers

spectral added a comment. In https://phab.mercurial-scm.org/D4035#62542, @pulkit wrote: > I like the idea here. @khanchi97 is already working on adding --confirm to `hg resolve`, how about having something like `hg resolve --mark --confirm` which asks you before marking each file as reso

D4035: resolve: add option to warn/abort on -m with unresolved conflict markers

This revision was automatically updated to reflect the committed changes. Closed by commit rHGbb54db4a4350: resolve: add option to warn/abort on -m with unresolved conflict markers (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercuria

D4035: resolve: add option to warn/abort on -m with unresolved conflict markers

spectral added a comment. In https://phab.mercurial-scm.org/D4035#62660, @pulkit wrote: > Also, even though this is experimental, can we document it somewhere? Sure, any advice for where would be a good place to do that? I would have thought `mercurial/help/config.txt`, but there

D4072: resolve: add commands.resolve.mark-check=abort to tweakdefaults

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4072 AFFECTED FILES mercurial/ui.py CHANGE DETAILS diff --git a/mercurial/ui.py b/mercurial/ui.py --

D4071: resolve: graduate resolve.mark-check from experimental, add docs

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Since this hasn't been in a release yet, I'm not bothering to add an alias for the experimental name of the config variable. REPOSITORY rHG Mercurial REVISION

D4071: resolve: graduate resolve.mark-check from experimental, add docs

spectral added inline comments. INLINE COMMENTS > pulkit wrote in config.txt:452 > I think here you mean 'none'? No, I didn't document the ``none`` case explicitly. This is saying that "even if it's going to abort, adding --all will bypass the error" (this is part of the hint when it aborts,

D4071: resolve: graduate resolve.mark-check from experimental, add docs

spectral marked an inline comment as done. spectral added inline comments. INLINE COMMENTS > pulkit wrote in config.txt:452 > Maybe rephrase to something like that if `--all` flag is passed, only warning > will be shown and error won't be raised. > (I am not good at english, so feel free to deci

D4071: resolve: graduate resolve.mark-check from experimental, add docs

spectral updated this revision to Diff 9866. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4071?vs=9833&id=9866 REVISION DETAIL https://phab.mercurial-scm.org/D4071 AFFECTED FILES mercurial/commands.py mercurial/configitems.py mercurial/help/conf

D4072: resolve: add commands.resolve.mark-check=abort to tweakdefaults

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe9740c07158d: resolve: add commands.resolve.mark-check=abort to tweakdefaults (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.or

D4071: resolve: graduate resolve.mark-check from experimental, add docs

This revision was automatically updated to reflect the committed changes. spectral marked an inline comment as done. Closed by commit rHG96d0795bd0bd: resolve: graduate resolve.mark-check from experimental, add docs (authored by spectral, committed by ). CHANGED PRIOR TO COMMIT https://phab.mer

D4121: resolve: correct behavior of mark-check=none to match docs

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4121 AFFECTED FILES mercurial/commands.py mercurial/configitems.py tests/test-resolve.t CHANGE DE

D4071: resolve: graduate resolve.mark-check from experimental, add docs

spectral marked an inline comment as done. spectral added inline comments. INLINE COMMENTS > martinvonz wrote in configitems.py:197 > Unrelated to this patch, but should the default be `'none`` as the > documentation says? It also looks like the code doesn't handle that value. https://phab.merc

D4121: resolve: correct behavior of mark-check=none to match docs

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7e75777e4a51: resolve: correct behavior of mark-check=none to match docs (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D412

D4130: match: add visitchildrenset complement to visitdir

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `visitdir(d)` lets a caller query whether the directory is part of the matcher. It can receive a response of 'all' (yes, and all children, you can stop calling

D4128: match: add tests for visitdir functionality

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are a few cases that we could have done better with some additional logic; I tried to annotate these when I noticed them, but may have missed some. The t

D4129: includematcher: separate "parents" from "dirs"

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY A future patch will make use of this separation so that we can make more intelligent decisions about what to investigate/load when the matcher is in use. Cu

D4131: dirstate: use visitchildrenset in traverse

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This speeds up `hg status` a fair amount when there is a very large directory and narrow is in use. Timing numbers according to command: hyperfine --w

D4128: match: add tests for visitdir functionality

spectral planned changes to this revision. spectral added a comment. Need to fix some lint errors REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4128 To: spectral, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel

D4129: includematcher: separate "parents" from "dirs"

spectral updated this revision to Diff 10016. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4129?vs=9998&id=10016 REVISION DETAIL https://phab.mercurial-scm.org/D4129 AFFECTED FILES mercurial/match.py CHANGE DETAILS diff --git a/mercurial/match.py

D4128: match: add tests for visitdir functionality

spectral updated this revision to Diff 10015. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4128?vs=9997&id=10015 REVISION DETAIL https://phab.mercurial-scm.org/D4128 AFFECTED FILES tests/test-match.py CHANGE DETAILS diff --git a/tests/test-match.p

D4130: match: add visitchildrenset complement to visitdir

spectral updated this revision to Diff 10017. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4130?vs=&id=10017 REVISION DETAIL https://phab.mercurial-scm.org/D4130 AFFECTED FILES mercurial/match.py tests/test-match.py CHANGE DETAILS diff --git

D4129: includematcher: separate "parents" from "dirs"

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5a7df82de142: includematcher: separate "parents" from "dirs" (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4129?vs=10016&i

D4128: match: add tests for visitdir functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rHG987d3a4b989f: match: add tests for visitdir functionality (authored by spectral, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4128?vs=10015&id=10073#toc REPOSITORY rHG Mer

D4130: match: add visitchildrenset complement to visitdir

This revision was automatically updated to reflect the committed changes. Closed by commit rHG081cc9a95b65: match: add visitchildrenset complement to visitdir (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4130?vs=100

D4131: dirstate: use visitchildrenset in traverse

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa3cabe9415e1: dirstate: use visitchildrenset in traverse (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4131?vs=10002&id=10

D4130: match: add visitchildrenset complement to visitdir

spectral added a comment. In https://phab.mercurial-scm.org/D4130#64345, @yuja wrote: > > +def testVisitchildrensetRootfilesin(self): > > +m = matchmod.match('x', '', patterns=['rootfilesin:dir/subdir']) > > +assert isinstance(m, matchmod.patternmatcher) > > +

D4131: dirstate: use visitchildrenset in traverse

spectral added a comment. In https://phab.mercurial-scm.org/D4131#64347, @yuja wrote: > Queued the series, thanks. > > > wadd = work.append > > while work: > > nd = work.pop() > > > > - if not match.visitdir(nd): +visitentries = match.visitchildrense

D4159: match: correct doc for _rootsdirsandparents after 5a7df82de142

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4159 AFFECTED FILES mercurial/match.py CHANGE DETAILS diff --git a/mercurial/match.py b/mercurial/ma

D4161: dirstate: add a comment on why we don't need to check if something is a dir/file

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4161 AFFECTED FILES mercurial/dirstate.py CHANGE DETAILS diff --git a/mercurial/dirstate.py b/mercur

D4160: match: add missing "return set()", add FIXME to test to doc a bug

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These were both brought up during the codereview of https://phab.mercurial-scm.org/D4130. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm

D4159: match: correct doc for _rootsdirsandparents after 5a7df82de142

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf356be1a7ba3: match: correct doc for _rootsdirsandparents after 5a7df82de142 (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/

D4160: match: add missing "return set()", add FIXME to test to doc a bug

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb9f94d67ea73: match: add missing "return set()", add FIXME to test to doc a bug (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.o

D4161: dirstate: add a comment on why we don't need to check if something is a dir/file

This revision was automatically updated to reflect the committed changes. Closed by commit rHG058497a2cc36: dirstate: add a comment on why we don't need to check if something is a dir/file (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.

D4156: narrow: add a --narrowspec flag to clone command

spectral accepted this revision. spectral added a comment. In https://phab.mercurial-scm.org/D4156#64662, @durin42 wrote: > I'm +1 on this, but I'd like someone else to chime in. @spectral how do you feel about this? It's at least somewhat related to functionality we've added via aliases

D4261: zsh_completion: rename _hg_style_opts to _hg_template_opts

spectral accepted this revision. spectral added a comment. (Like the description says, this hides --style in tab completion. I think this is an improvement). REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4261 To: av6, #hg-reviewers, spectral Cc: spectral, merc

D4264: zsh_completion: declare appropriate local parameters for ->string form

spectral accepted this revision. spectral added a comment. I don't understand this aspect super well, I admit I haven't read the docs you linked to, but I can see why this would be more correct :) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4264 To: av6, #hg

D4267: zsh_completion: update all options

spectral accepted this revision. spectral added inline comments. INLINE COMMENTS > zsh_completion:373 > # Common options > _hg_global_opts=( > +'(--repository -R)'{-R+,--repository=}'[repository root directory or > name of overlay bundle file]:repository:_files -/' I wonder how hard it wo

D4262: zsh_completion: drop -w, add -S to _arguments

spectral added a comment. In https://phab.mercurial-scm.org/D4262#65777, @av6 wrote: > Thanks, `‘` and `’`, for making it difficult to phabsend this. I had to > > diff --git a/contrib/phabricator.py b/contrib/phabricator.py > --- a/contrib/phabricator.py > +++ b/contrib/phabr

D4267: zsh_completion: update all options

spectral added inline comments. INLINE COMMENTS > av6 wrote in zsh_completion:1198 > You mean giving revisions without `-r`? No, `*` means that `-r` can be > specified multiple times (and each would require an argument). To see how > it's done for a command that has "optional" `-r` see _hg_cmd_

D4284: copies: correctly skip directories that have already been considered

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, `if dsrc in invalid` would never be true, since we added `dsrc + "/"` to invalid, not `dsrc` itself. Since it's much more common for individual file

D3896: copies: handle case when both merge cset are not descendant of merge base

spectral added a comment. Any updates on this? I'm poking at updating this function in core, and not too excited to have to also modify the copy in evolve that seems to have spawned :/ REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3896 To: pulkit, #hg-review

D4287: overlayworkingctx: fix exception in metadata-only inmemory merges (issue5960)

spectral created this revision. spectral added a reviewer: phillco. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If there was a metadata-only mutation, such as +x or -x on a file, we would create a cache entry with None for data, and this

D4287: overlayworkingctx: fix exception in metadata-only inmemory merges (issue5960)

spectral updated this revision to Diff 10365. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4287?vs=10364&id=10365 REVISION DETAIL https://phab.mercurial-scm.org/D4287 AFFECTED FILES mercurial/context.py tests/test-rebase-inmemory.t CHANGE DETAILS

D4287: overlayworkingctx: fix exception in metadata-only inmemory merges (issue5960)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG95bd19f60957: overlayworkingctx: fix exception in metadata-only inmemory merges (issue5960) (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mer

D4331: nodes: expand/comment the magic nodes so they are more easily searchable

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We just encountered `modified`, and it was quite annoying to search for these, even though I knew they existed. For those that don't know that they

D4331: nodes: expand/comment the magic nodes so they are more easily searchable

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb623c7b23695: nodes: expand/comment the magic nodes so they are more easily searchable (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercuria

D4351: match: improve includematcher.visitchildrenset to be much faster and cached

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This improves the speed of visitchildrenset considerably, especially when there are complicated matchers involved that may have many entries in _dirs or _paren

D4331: nodes: expand/comment the magic nodes so they are more easily searchable

spectral marked an inline comment as done. spectral added inline comments. INLINE COMMENTS > martinvonz wrote in node.py:32 > Isn't it `30303030...` in hex? I'd prefer to fix it by changing the actual > value to be what the comment says, though. Indeed, looks like yuya already fixed this for me

D4351: match: improve includematcher.visitchildrenset to be much faster and cached

spectral updated this revision to Diff 10534. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4351?vs=10501&id=10534 REVISION DETAIL https://phab.mercurial-scm.org/D4351 AFFECTED FILES mercurial/match.py CHANGE DETAILS diff --git a/mercurial/match.py

D4363: log: respect graphshorten on terminal nodes (collapsing o-~ to just o)

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Internally we have a custom template that's inspired by ones that we have seen in the community. Normally, this looks something like: o 0834ec17 spectral

D4363: log: respect graphshorten on terminal nodes (collapsing o-~ to just o)

spectral updated this revision to Diff 10539. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4363?vs=10538&id=10539 REVISION DETAIL https://phab.mercurial-scm.org/D4363 AFFECTED FILES mercurial/graphmod.py tests/test-logexchange.t tests/test-show-

<    1   2   3   4   5   6   7   >