D8564: fakemergerecord: get mergestate via context

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8564 AFFECTED FILES tests/fakemergerecord.py CHANGE DETAILS diff --git

D8562: shelve: get mergestate via context

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8562 AFFECTED FILES mercurial/shelve.py CHANGE DETAILS diff --git

D8561: hg: get mergestate via context

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8561 AFFECTED FILES mercurial/hg.py CHANGE DETAILS diff --git a/mercurial/hg.py

D8556: commands: get mergestate via context

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8556 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git

D8559: revset: get mergestate via context

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Happily, this resolves an import cycle! REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8559 AFFECTED FILES

D8560: templatekw: get mergestate via context

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Happily, this resolves an import cycle! REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8560 AFFECTED FILES

D8557: debugcommands: get mergestate via context

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8557 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS diff --git

D8558: fileset: get mergestate via context

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Happily, this resolves an import cycle! REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8558 AFFECTED FILES

D8555: cmdutil: get mergestate via context

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8555 AFFECTED FILES mercurial/cmdutil.py CHANGE DETAILS diff --git

D8553: histedit: use context to load mergestate instead of loading it directly

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8553 AFFECTED FILES hgext/histedit.py CHANGE DETAILS diff --git

D8551: context: implement mergestate() method

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This will let us have the mergestate storage be controlled by the context. In particular, for working contexts we should use the existing mergestate, but for

D8554: strip: get mergestate via context

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8554 AFFECTED FILES hgext/strip.py CHANGE DETAILS diff --git a/hgext/strip.py

D8552: fix: use context to fetch mergestate instead of loading it directly

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8552 AFFECTED FILES hgext/fix.py CHANGE DETAILS diff --git a/hgext/fix.py

D8353: debugcommands: create new debugantivirusrunning command

Herald added a subscriber: mercurial-patches. durin42 updated this revision to Diff 21426. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8353?vs=20929=21426 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8353/new/ REVISION

D8549: relnotes: add API change note per request in D8502

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8549 AFFECTED FILES relnotes/next CHANGE DETAILS diff --git a/relnotes/next

D8548: tests: add coverage for repo.changelog.children() in the git extension

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8548 AFFECTED FILES tests/test-git-interop.t CHANGE DETAILS diff --git

D8547: tests: add coverage for repo.changelog.findmissing() in test-git-interop.t

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This at least does a basic test of the method. It's not super-complete, but it's better than the nothing we'd otherwise have. REPOSITORY rHG Mercurial

D8515: filemerge: add a hacktastic version of internal:merge3 for merge diffs

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is a version of merge3 that always reports success, so that conflict markers get preserved without us having to implement conflict storage for in-memory

D8431: upgrade: support upgrade and downgrade from persistent nodemap

durin42 added inline comments. INLINE COMMENTS > requirements.txt:150 > +The `nodemap` index (mapping nodeid to local revision number) is persisted on > +disk. This provides speed benefit (if the associated native code is used. The > +persistent nodemap is only used for two revlogs: the

D8502: cleanup: avoid extra node/ctx conversions in logcmdutil.diffordiffstat

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I'm about to write some code that wants to pass a memctx to diffordiffstat, but this feels like a meritorious cleanup anyway, since the first thing this

D8504: diff: add experimental support for "merge diffs"

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Still TODO before this is "done" (so probably don't push this patch yet): - Test showing how conflicting edits behave (I suspect this is broken) - Test

D8503: diff: avoid going from contexts to nodes and back

durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This will allow us to pass in-memory contexts that may not have a valid node to the diffing logic. REPOSITORY rHG Mercurial BRANCH default REVISION

D8431: upgrade: support upgrade and downgrade from persistent nodemap

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. This requirement needs documentation in `mercurial/helptext/internals/requirements.txt`. I've taken the rest of the stack, but am blocking this patch on that change.

D8353: debugcommands: create new debugantivirusrunning command

durin42 added a comment. I don't think so, since it's base85-armored and my understanding is that really it's only supposed to trigger in isolation... REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8353/new/ REVISION DETAIL

D8409: nodemap: create files in the repository used in the test

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. Did some bisecting. Prior to this change, I see about 2% failures on a 36-core 72-thread xeon machine that's otherwise idle. With this change, I see about 25% fails (out of 100

D8424: manifest: fix missing `el` on an `elif` spotted by yuya

durin42 added a comment. durin42 abandoned this revision. Yep it got folded. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8424/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8424 To: durin42, #hg-reviewers, Alphare Cc: pulkit, Alphare,

D8448: rust-chg: modernize entry function

durin42 added inline comments. INLINE COMMENTS > main.rs:70 > +#[tokio::main] > +async fn run(umask: u32) -> io::Result { > let mut loc = Locator::prepare_from_env()?; With this series I get lots of `+ error[E0670]: `async fn` is not permitted in the 2015 edition` from

D8416: nodemap: move on disk file to version 1

durin42 added inline comments. INLINE COMMENTS > nodemap.py:270 > > # version 0 is experimental, no BC garantee, do no use outside of tests. > +ONDISK_VERSION = 1 I feel like this comment is outdated? please send a follow-up (even if it's for stable after the freeze) on this. REPOSITORY

D8424: manifest: fix missing `el` on an `elif` spotted by yuya

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This can be amended into 2db2e9e5 . REPOSITORY rHG Mercurial BRANCH default

D8375: manifest: leave a TODO where we may have more work for sha1 portability

Closed by commit rHGf0d88d20654b: manifest: leave a TODO where we may have more work for sha1 portability (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8373: manifest: add test for long hashes

Closed by commit rHG677e8fdd2c8b: manifest: add test for long hashes (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8373?vs=20976=21086 CHANGES SINCE LAST

D8372: manifest: remove a final 40-byte assumption from pure-python parser

Closed by commit rHG2db2e9e585b3: manifest: remove a final 40-byte assumption from pure-python parser (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8371: manifest: fix yet another 20-byte-hash assumption

Closed by commit rHG75f1197db884: manifest: fix yet another 20-byte-hash assumption (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8371?vs=21053=21084

D8370: manifest: fix another pure-parsing 20-byte assumption

Closed by commit rHG0415a566742a: manifest: fix another pure-parsing 20-byte assumption (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8370?vs=21052=21083

D8369: manifest: teach treemanifest about long hashes

Closed by commit rHG0e99b876966a: manifest: teach treemanifest about long hashes (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8369?vs=21051=21082 CHANGES

D8368: manifest: start removing 40-byte hash restrictions from C code

Closed by commit rHG0b0e72b5d551: manifest: start removing 40-byte hash restrictions from C code (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8367: manifest: remove a 20-byte-hash assumption from pure manifest parsing

Closed by commit rHGecbba7b2e444: manifest: remove a 20-byte-hash assumption from pure manifest parsing (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8375: manifest: leave a TODO where we may have more work for sha1 portability

durin42 updated this revision to Diff 21055. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8375?vs=20978=21055 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8375/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8375

D8372: manifest: remove a final 40-byte assumption from pure-python parser

durin42 updated this revision to Diff 21054. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8372?vs=20975=21054 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8372/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8372

D8371: manifest: fix yet another 20-byte-hash assumption

durin42 updated this revision to Diff 21053. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8371?vs=20974=21053 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8371/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8371

D8370: manifest: fix another pure-parsing 20-byte assumption

durin42 updated this revision to Diff 21052. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8370?vs=20973=21052 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8370/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8370

D8369: manifest: teach treemanifest about long hashes

durin42 updated this revision to Diff 21051. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8369?vs=20972=21051 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8369/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8369

D8367: manifest: remove a 20-byte-hash assumption from pure manifest parsing

durin42 updated this revision to Diff 21050. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8367?vs=20970=21050 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8367/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8367

D8369: manifest: teach treemanifest about long hashes

durin42 added a comment. In D8369#125460 , @Alphare wrote: > I feel like that warrants a small comment about hash compatibility just to ease-in new contributors or people who haven't followed that discussion. Added a comment, hopefully

D8374: fuzz: tell manifest fuzzer about longer node hashes

durin42 added a comment. In D8374#125469 , @Alphare wrote: > Looks to me like this is two changes in one, with the addition of null bytes. Or am I missing something? The input format for the corpus changed because of the ConsumeBool()

D8392: [RFC] mergestate: store about files resolved in favour of other

durin42 added a comment. durin42 accepted this revision as: durin42. durin42 added subscribers: martinvonz, durin42. I like it, but want to get @martinvonz to look too. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8392/new/ REVISION DETAIL

D8391: histedit: add test that an invalid editor doesn't bork client state

Closed by commit rHGbca57ad9e630: histedit: add test that an invalid editor doesnt bork client state (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8391: histedit: add test that an invalid editor doesn't bork client state

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We had a report of a situation like this borking a user at Google, but I can't reproduce it in a test. Let's at least backstop the issue with a test, so we

D8366: manifest: also declare treemanifest as implementing imanifestdict

Closed by commit rHG8c66a680f396: manifest: also declare treemanifest as implementing imanifestdict (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8365: manifest: introduce new exception to signal unavailability of fastdelta()

Closed by commit rHG948fac24bc39: manifest: introduce new exception to signal unavailability of fastdelta() (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8375: manifest: leave a TODO where we may have more work for sha1 portability

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8375 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git

D8372: manifest: remove a final 40-byte assumption from pure-python parser

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8372 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git

D8374: fuzz: tell manifest fuzzer about longer node hashes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8374 AFFECTED FILES contrib/fuzz/manifest.cc contrib/fuzz/manifest_corpus.py

D8371: manifest: fix yet another 20-byte-hash assumption

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8371 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git

D8373: manifest: add test for long hashes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8373 AFFECTED FILES tests/test-manifest.py CHANGE DETAILS diff --git

D8370: manifest: fix another pure-parsing 20-byte assumption

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8370 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git

D8369: manifest: teach treemanifest about long hashes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8369 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git

D8367: manifest: remove a 20-byte-hash assumption from pure manifest parsing

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is almost certainly slower, but it shouldn't be by much. We need to do this for the eventual hash transition, no matter what that looks like. REPOSITORY

D8368: manifest: start removing 40-byte hash restrictions from C code

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8368 AFFECTED FILES mercurial/cext/manifest.c CHANGE DETAILS diff --git

D8353: debugcommands: create new debugantivirusrunning command

durin42 added a comment. In D8353#124948 , @mharbison72 wrote: > Should it delete the file after writing it, or don't bother because the AV may have it locked? I figured just leave it since it's tiny, but maybe we should sleep for a

D8366: manifest: also declare treemanifest as implementing imanifestdict

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It always has been intended to be, but it had a mismatched flags() method until the previous change. REPOSITORY rHG Mercurial BRANCH default REVISION

D8365: manifest: introduce new exception to signal unavailability of fastdelta()

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I've spent some time reflecting on this, and I think this is the best we can do in this API contract for now. This opens the door to adding treemanifest's

D8353: debugcommands: create new debugantivirusrunning command

durin42 added a comment. In D8353#124864 , @indygreg wrote: > I do not understand what the intended side-effect of running this command is supposed to be. Well, if an AV engine isn't configured to ignore the user's clone, then this will

D8243: copies: stop recording buggy file merge when new file overwrite an old one

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. Per irc checkin, we expect changes on this before review. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8243/new/ REVISION DETAIL

D8353: debugcommands: create new debugantivirusrunning command

durin42 updated this revision to Diff 20929. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8353?vs=20928=20929 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8353/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8353

D8353: debugcommands: create new debugantivirusrunning command

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This writes the EICAR test file to .hg/cache, in an attempt to trigger an AV scanner's scanning engine. This should let us (in theory) detect some cases when a

D8333: tests: handle new error string from FreeBSD for dns entry not resolving

Closed by commit rHG4dacd0cef146: tests: handle new error string from FreeBSD for dns entry not resolving (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8333: tests: handle new error string from FreeBSD for dns entry not resolving

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8333 AFFECTED FILES tests/test-clonebundles.t CHANGE DETAILS diff --git

D8329: tests: update test-debugcommands.t stack trace checks for python3.9

Closed by commit rHGa7b7a67b79c1: tests: update test-debugcommands.t stack trace checks for python3.9 (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8328: tests: update test-archive.t expectations for python3.9 changes

Closed by commit rHG862025f108c7: tests: update test-archive.t expectations for python3.9 changes (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8327: setup: relax -Werror for declaration-after-statement on Python 3.9

Closed by commit rHG960770add699: setup: relax -Werror for declaration-after-statement on Python 3.9 (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8329: tests: update test-debugcommands.t stack trace checks for python3.9

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Python 3.9 prints a complete filepath in more cases, so we need to handle that in our test output. Since we don't really care *that* much about the specific

D8328: tests: update test-archive.t expectations for python3.9 changes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Sigh. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8328 AFFECTED FILES tests/test-archive.t CHANGE DETAILS

D8327: setup: relax -Werror for declaration-after-statement on Python 3.9

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It turns out Python 3.9 introduces such declarations in the headers, eg cpython/abstract.h:189:5: error: ISO C90 forbids mixed declarations and code

D8190: nodemap: test that concurrent process don't see the pending transaction

durin42 added a comment. I think I'm coming around on this. I've poked a few reviewers in private to look at the first three patches in this series to see how they feel, but if I don't hear back in a day or two I think I'll just push the whole stack... REPOSITORY rHG Mercurial CHANGES

D8190: nodemap: test that concurrent process don't see the pending transaction

durin42 added a comment. In D8190#124146 , @marmoute wrote: > In D8190#124141 , @martinvonz wrote: > >> > > This new patch works, but I don't like the idea of not testing two fully

D8190: nodemap: test that concurrent process don't see the pending transaction

durin42 added a comment. In D8190#124141 , @martinvonz wrote: > @durin42, what do you think? That's *inspired* and looks like an awesome solution to me. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7296: pycompat: kludge around pytype being confused by __new__

durin42 added a comment. durin42 planned changes to this revision. I'd like to get back to pytyping all the things, but I can't justify spending more time on it. If someone else wants to push things forward I'll gladly provide some mentorship. REPOSITORY rHG Mercurial CHANGES SINCE LAST

D8281: narrow: escape includepats/excludepats when sending over the wire

durin42 added a comment. In D8281#124058 , @marmoute wrote: > Since narrow is still experimental, I don't think we should try too hard for backward compatibility. We could introduce a new end-point for a new encoding and drop the old one in

D8189: testlib: add a small scrip to help process to synchronise using file

durin42 added a comment. In D8189#124124 , @marmoute wrote: > In D8189#124122 , @durin42 wrote: > >> I'm still -0 on this: I'd rather we found an approach that didn't require sleeping for so

D8189: testlib: add a small scrip to help process to synchronise using file

durin42 added a comment. I'm still -0 on this: I'd rather we found an approach that didn't require sleeping for so long. Perhaps a Python script would be a better fit here? (I won't block this landing, but I won't push it.) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D8302: hg: make _local() behave consistently on Python 3.8 (issue6287)

Closed by commit rHG6a8738dc4a01: hg: make _local() behave consistently on Python 3.8 (issue6287) (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8299: remotefilelog: add fake heads() method that allows viewing a file in hgweb

Closed by commit rHG9e63108123a4: remotefilelog: add fake heads() method that allows viewing a file in hgweb (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8301: phabricator: remove duplicated byteskwargs conversion

Closed by commit rHG3aab524a8480: phabricator: remove duplicated byteskwargs conversion (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8301?vs=20825=20828

D8298: tests: add test for remotefilelog interactions with hgweb

Closed by commit rHG5483e9c759e4: tests: add test for remotefilelog interactions with hgweb (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8298?vs=20816=20829

D8302: hg: make _local() behave consistently on Python 3.8 (issue6287)

durin42 updated this revision to Diff 20827. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8302?vs=20826=20827 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8302/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8302

D8302: hg: make _local() behave consistently on Python 3.8

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Python 3.8 makes os.path.isfile quietly eat "path invalid" errors and return False instead of allowing the exception to propagate. Given that this is a change

D8301: phabricator: remove duplicated byteskwargs conversion

durin42 created this revision. Herald added subscribers: mercurial-devel, Kwan. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Fixes things on Python 3. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8301 AFFECTED FILES

D8288: fix: mark -r as advanced

This revision is now accepted and ready to land. durin42 added a comment. durin42 accepted this revision. In D8288#123836 , @marmoute wrote: > For the record, I always use `hg fix` with `--rev`. So do I, but I also acknowledge that I've

D8299: remotefilelog: add fake heads() method that allows viewing a file in hgweb

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As best I can discern, this is not going to hurt anything, but it'll cause a couple of options to exist in the UI that are nonsensical. That seems fine, given

D8298: tests: add test for remotefilelog interactions with hgweb

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's not uncommon for hg users to rely on hgweb as a simple GUI and history browser (I do this all the time on Mercurial), but we lack any tests to ensure

D8286: fix: move handling of --all into getrevstofix() for consistency

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. LGTM but needs rebased? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8286/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8286

D8172: notify: optional mail threading based on obsmarker

durin42 added a comment. durin42 added subscribers: marmoute, durin42. @marmoute REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8172/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8172 To: joerg.sonnenberger, #hg-reviewers Cc: durin42,

D8189: testlib: add a small scrip to help process to synchronise using file

durin42 added a comment. In D8189#123280 , @marmoute wrote: > By using explicit wait on signal (through the fs) that each process reached the appropriate file. We avoid flackyness. There are already multiple use of this approach in the test

D8187: nodemap: make sure hooks have access to an up-to-date version

durin42 added a comment. In D8187#123306 , @marmoute wrote: > In D8187#123258 , @durin42 wrote: > >> No longer applies on top of @. > > I don't understand this feedback. There are about 15

D8189: testlib: add a small scrip to help process to synchronise using file

durin42 added a comment. This script feels extremely like a flaky test waiting to happen. Is there no alternative for this? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8189/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8189 To: marmoute,

D8187: nodemap: make sure hooks have access to an up-to-date version

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. No longer applies on top of @. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8187/new/ REVISION DETAIL

D8270: run-tests: restrict Rust thread pool to 3 threads during tests

durin42 added inline comments. durin42 accepted this revision as: durin42. INLINE COMMENTS > pulkit wrote in run-tests.py:2998 > Should we also take value of `-j` into account too? If `-j 1` is used, then > we should not do multi-threading here. I don't think so, since part of the goal is to

D8265: git: key off `git` in .hg/requires rather than separate file

Closed by commit rHG02c47b74366c: git: key off `git` in .hg/requires rather than separate file (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D8271: git: correctly handle p1() on dirstate when underlying git repo is empty

Closed by commit rHGeb061d272af4: git: correctly handle p1() on dirstate when underlying git repo is empty (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

<    1   2   3   4   5   6   7   8   9   10   >