D5400: tests: use $RUNTESTDIR instead of $TESTDIR in narrow-library.sh

pulkit added inline comments. INLINE COMMENTS > mharbison72 wrote in narrow-library.sh:5 > Unrelated, but shouldn't this be "$PYTHON" (with quotes)? I think it should be. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5400 To: pulkit, #hg-reviewers Cc:

D5400: tests: use $RUNTESTDIR instead of $TESTDIR in narrow-library.sh

This revision was automatically updated to reflect the committed changes. Closed by commit rHGbcf70058af90: tests: use $RUNTESTDIR instead of $TESTDIR in narrow-library.sh (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5400: tests: use $RUNTESTDIR instead of $TESTDIR in narrow-library.sh

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is done so that third party extensions can use narrow-library.sh in tests. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5400

D5354: py3: listify filter() to call len() on it

This revision was automatically updated to reflect the committed changes. Closed by commit rHGbda0cb4839fb: py3: listify filter() to call len() on it (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5354?vs=12674=12679

D5354: py3: listify filter() to call len() on it

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5354 AFFECTED FILES hgext/remotefilelog/repack.py CHANGE DETAILS diff --git

D5353: format-source: move the extension to core

pulkit abandoned this revision. pulkit added a comment. It was a volunteered effort and I find out that extension author has better plans after sending this. So abandoning. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5353 To: pulkit, #hg-reviewers Cc:

D5353: format-source: move the extension to core

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Format-source is an extension which helps in applying and merging code formatting (or other changes). It provides a 'format-source' command which will

D5348: narrowcommands: remove an unrequired `repo.narrowpats` call

This revision was automatically updated to reflect the committed changes. Closed by commit rHG773572e5cba2: narrowcommands: remove an unrequired `repo.narrowpats` call (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1694: debugcommands: replace opts.get('foo') by opts['foo']

pulkit added a comment. In https://phab.mercurial-scm.org/D1694#29072, @yuja wrote: > Sometimes we do the reverse change for ease of calling command function as a plain function. Just for record, today I hit the problem where some command is using `opts['']` instead of

D5348: narrowcommands: remove an unrequired `repo.narrowpats` call

pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We call that few lines above and do nothing significant in between which can change the

D5345: sparse-revlog: enabled by default

pulkit added a comment. Thanks for all the numbers and a detailed commit message \o/. Can you help finding answers to following extra questions? - What will be effect on existing repositories which don't convert to sparse revlog due to some reasons? - If enabled by default in 4.9,

D4892: narrow: drop the bundle2 capability since we have server capabilities (BC)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG381d3121e97a: narrow: drop the bundle2 capability since we have server capabilities (BC) (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5308: store: don't pass 'atomictemp=True' while appending to fncache

pulkit added a comment. Pasting Yuja's reply to that from mailing list: > In https://phab.mercurial-scm.org/D5308#78989, @pulkit wrote: > > > In https://phab.mercurial-scm.org/D5308#78985, @yuja wrote: > > > > > > - a/mercurial/store.py +++ b/mercurial/store.py @@ -486,7 +486,7

D5302: py3: use pycompat.xrange instead of xrange

This revision was automatically updated to reflect the committed changes. Closed by commit rHGba706e3082bd: py3: use pycompat.xrange instead of xrange (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5302?vs=12606=12614

D5308: store: don't pass 'atomictemp=True' while appending to fncache

pulkit added a comment. In https://phab.mercurial-scm.org/D5308#78985, @yuja wrote: > > - a/mercurial/store.py +++ b/mercurial/store.py @@ -486,7 +486,7 @@ if self.addls: > > 1. if we have just new entries, let's append them to the fncache tr.addbackup('fncache') > > - fp =

D5307: store: write fncache only once if there are both adds and removes

This revision was automatically updated to reflect the committed changes. Closed by commit rHGdf8ed31a8ad8: store: write fncache only once if there are both adds and removes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5308: store: don't pass 'atomictemp=True' while appending to fncache

pulkit created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Appending to an atomictemp file means that the entire file is copied first. Thanks to Yuya for suggesting. REPOSITORY rHG Mercurial REVISION DETAIL

D5307: store: write fncache only once if there are both adds and removes

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5307 AFFECTED FILES mercurial/store.py CHANGE DETAILS diff --git a/mercurial/store.py

D4892: narrow: drop the bundle2 capability since we have server capabilities (BC)

pulkit updated this revision to Diff 12608. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4892?vs=11711=12608 REVISION DETAIL https://phab.mercurial-scm.org/D4892 AFFECTED FILES hgext/narrow/narrowbundle2.py

D5296: store: don't read the whole fncache in memory

pulkit added a comment. Seeing the performance benefit it brings on our repo, I want to try other ways we can do this. Do we like having a conditional which checks the size of fncache and choose one of the approaches depending on how large it is? If size(fncache) < 50M, use the current

D5302: py3: use pycompat.xrange instead of xrange

pulkit updated this revision to Diff 12606. pulkit retitled this revision from "py3: alias xrange to range" to "py3: use pycompat.xrange instead of xrange". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5302?vs=12596=12606 REVISION DETAIL

D5302: py3: alias xrange to range

pulkit added inline comments. INLINE COMMENTS > durin42 wrote in test-remotefilelog-histpack.py:29 > why not just use pycompat.xrange directly instead of doing extra indirection? Forgot that was a thing. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5302 To:

D5305: py3: fix couple of division operator to do integer divison

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe0b485a76009: py3: fix couple of division operator to do integer divison (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5301: store: append to fncache if there are only new files to write

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0728d87a8631: store: append to fncache if there are only new files to write (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5304: py3: use dict.items() instead of dict.iteritems()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5d1550b9a533: py3: use dict.items() instead of dict.iteritems() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5303: py3: convert strings to bytes in tests/test-remotefilelog-histpack.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9446d5aa0f32: py3: convert strings to bytes in tests/test-remotefilelog-histpack.py (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5303?vs=12597=12602#toc

D5300: py3: replace str() with pycompat.bytestr() or ('%d' % int)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG001f27970b60: py3: replace str() with pycompat.bytestr() or (%d % int) (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5305: py3: fix couple of division operator to do integer divison

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5305 AFFECTED FILES hgext/remotefilelog/basepack.py hgext/remotefilelog/historypack.py CHANGE

D5304: py3: use dict.items() instead of dict.iteritems()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY dict.iteritems() does not exist on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5304 AFFECTED FILES

D5303: py3: convert strings to bytes in tests/test-remotefilelog-histpack.py

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5303 AFFECTED FILES tests/test-remotefilelog-histpack.py CHANGE DETAILS diff --git

D5302: py3: alias xrange to range

pulkit created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY xrange does not exists on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5302 AFFECTED FILES

D5301: store: append to fncache if there are only new files to write

pulkit created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, if we have to add a new entry to fncache, we write the whole fncache again which slows things down on large fncache which have

D5300: py3: replace str() with pycompat.bytestr() or ('%d' % int)

pulkit updated this revision to Diff 12594. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5300?vs=12591=12594 REVISION DETAIL https://phab.mercurial-scm.org/D5300 AFFECTED FILES hgext/fastannotate/formatter.py CHANGE DETAILS diff --git

D5300: py3: replace str() with pycompat.bytestr() or ('%d' % int)

pulkit added a comment. In https://phab.mercurial-scm.org/D5300#78881, @yuja wrote: > > - revenc = lambda x: wrev if x is None else str(x) + wrevpad > > - csetenc = lambda x: wnode if x is None else str(x) + ' ' + revenc = lambda x: wrev if x is None else ('%d' % x) +

D5296: store: don't read the whole fncache in memory

pulkit added a comment. In https://phab.mercurial-scm.org/D5296#78834, @yuja wrote: > > diff --git a/mercurial/store.py b/mercurial/store.py > > > > - a/mercurial/store.py +++ b/mercurial/store.py @@ -461,13 +461,13 @@ > > 1. skip nonexistent file self.entries = set() return

D5297: tests: add test for `--version` flag of perfchangegroupchangelog

This revision was automatically updated to reflect the committed changes. Closed by commit rHGcfaf3843491b: perf: rename version flag of perfchangegroupchangelog to cgversion (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5297?vs=12588=12593#toc

D5291: branchmap: build the revbranchcache._namesreverse() only when required

This revision was automatically updated to reflect the committed changes. Closed by commit rHG50a64c321c1e: branchmap: build the revbranchcache._namesreverse() only when required (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5300: py3: replace str() with pycompat.bytestr() or ('%d' % int)

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY After this patch, test-fastannotate-diffopts.t is about to pass. There are some extra newlines in the output. REPOSITORY rHG Mercurial REVISION DETAIL

D5298: perfchangegroupchangelog: rename version flag to cgversion

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The version flag conflicts with the global version flag and does not work. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5298

D5297: tests: add test for `--version` flag of perfchangegroupchangelog

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The --version flag for the perf command conflicts with the global version flag. The next patch will rename it to cgversion. REPOSITORY rHG Mercurial REVISION

D5291: branchmap: build the revbranchcache._namesreverse() only when required

pulkit updated this revision to Diff 12586. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5291?vs=12576=12586 REVISION DETAIL https://phab.mercurial-scm.org/D5291 AFFECTED FILES mercurial/branchmap.py

D5293: py3: whitelist three more passing test caught by buildbot

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0d8425311f2f: py3: whitelist three more passing test caught by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5296: store: don't read the whole fncache in memory

pulkit created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In large repositories with lot of files, the fncache grows more than 100 MB and reading that whole thing into memory slows things down. Let's not read

D5295: branchmap: define a hasbranch() to find whether a branch exists or not

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch introduces a branchmap.hasbranch() function to find whether a branch exists or not. I was going through profile of one of most used command

D5291: branchmap: build the revbranchcache._namesreverse() only when required

pulkit added a comment. In https://phab.mercurial-scm.org/D5291#78794, @yuja wrote: > > +if self._namesreverse is None: > > +self._namesreverse = dict((b, r) for r, b in enumerate(self._names)) > > > > if b in self._namesreverse: > > branchidx =

D5293: py3: whitelist three more passing test caught by buildbot

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The number of failing test is back to two digits. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5293 AFFECTED FILES

D5291: branchmap: build the revbranchcache._namesreverse() only when required

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY On big repositories with a lot of named branches and that also increasing over time, building of this dict can be expensive and shows up in profile. For our

D5287: py3: use node.hex(m.digest()) instead of m.hexdigest()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9fcf8084ada8: py3: use node.hex(m.digest()) instead of m.hexdigest() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5287: py3: use node.hex(m.digest()) instead of m.hexdigest()

pulkit added a comment. In https://phab.mercurial-scm.org/D5287#78759, @yuja wrote: > > diff --git a/hgext/remotefilelog/basepack.py b/hgext/remotefilelog/basepack.py > > > > - a/hgext/remotefilelog/basepack.py +++ b/hgext/remotefilelog/basepack.py @@ -10,6 +10,7 @@ > > > >

D5287: py3: use node.hex(m.digest()) instead of m.hexdigest()

pulkit updated this revision to Diff 12574. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5287?vs=12563=12574 REVISION DETAIL https://phab.mercurial-scm.org/D5287 AFFECTED FILES hgext/fastannotate/context.py hgext/largefiles/lfcommands.py

D5286: py3: use pycompat.byteskwargs() to covert keys of kwargs to bytes

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd6a13f6db69c: py3: use pycompat.byteskwargs() to covert keys of kwargs to bytes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5285: py3: use '%d' for integers instead of '%s'

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfeae4d1f5e01: py3: use %d for integers instead of %s (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5285?vs=12561=12568

D5284: py3: add 9 new passing tests caught by buildbot

This revision was automatically updated to reflect the committed changes. Closed by commit rHG02318e0810ac: py3: add 9 new passing tests caught by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5287: py3: use node.hex(m.digest()) instead of m.hexdigest()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY hashlib.sha1.hexdigest() returns str on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5287 AFFECTED FILES

D5286: py3: use pycompat.byteskwargs() to covert keys of kwargs to bytes

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5286 AFFECTED FILES hgext/fastannotate/context.py CHANGE DETAILS diff --git

D5285: py3: use '%d' for integers instead of '%s'

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5285 AFFECTED FILES hgext/remotefilelog/debugcommands.py CHANGE DETAILS diff --git

D5284: py3: add 9 new passing tests caught by buildbot

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5284 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist

D5264: store: raise ProgrammingError if unable to decode a storage path

This revision was automatically updated to reflect the committed changes. Closed by commit rHG66adfd58cb77: store: raise ProgrammingError if unable to decode a storage path (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5170: branchmap: pass changelog into revbranchcache.branchinfo()

pulkit abandoned this revision. pulkit added a comment. In https://phab.mercurial-scm.org/D5170#78533, @indygreg wrote: > I think this patch can be abandoned because of other work late in the 4.8 cycle? Yep! REPOSITORY rHG Mercurial REVISION DETAIL

D5263: py3: add b suffix to make sure file is opened in bytes mode

This revision was automatically updated to reflect the committed changes. Closed by commit rHGaa588bf40a08: py3: add b suffix to make sure file is opened in bytes mode (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5262: py3: don't use dict.iterkeys()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9769e0f6ffe0: py3: dont use dict.iterkeys() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5262?vs=12519=12525 REVISION

D5259: py3: fix keyword arguments handling in hgext/remotefilelog/

This revision was automatically updated to reflect the committed changes. Closed by commit rHG13d4ad8d7801: py3: fix keyword arguments handling in hgext/remotefilelog/ (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5261: py3: use node.hex(h.digest()) instead of h.hexdigest()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3fa4183e7803: py3: use node.hex(h.digest()) instead of h.hexdigest() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5260: py3: make second argument of fdopen() a str

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5e3b3f88c2e4: py3: make second argument of fdopen() a str (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5260?vs=12517=12523

D5264: store: raise ProgrammingError if unable to decode a storage path

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Right now, the function magically return False which is dangerous, so let's raise ProgrammingError. Suggested by Augie in

D5263: py3: add b suffix to make sure file is opened in bytes mode

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5263 AFFECTED FILES hgext/remotefilelog/basepack.py hgext/remotefilelog/basestore.py

D5262: py3: don't use dict.iterkeys()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY dict.iterkeys() is not present on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5262 AFFECTED FILES

D5261: py3: use node.hex(h.digest()) instead of h.hexdigest()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY hashlib.sha1.hexdigest() returns str on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5261 AFFECTED FILES

D5259: py3: fix keyword arguments handling in hgext/remotefilelog/

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Keys of kwargs on Python 3 should be strings. This patch fixes them by appending r'' prefixes, and using pycompat.byteskwargs() and pycompat.strkwargs().

D5260: py3: make second argument of fdopen() a str

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame as just r'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5260 AFFECTED FILES

D5039: py3: add __pycache__ to .hgignore

This revision was automatically updated to reflect the committed changes. Closed by commit rHGee9981bc8b44: py3: add __pycache__ to .hgignore (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5039?vs=12514=12515 REVISION

D3771: py3: make contrib/perf.py compatible to Python 3

pulkit abandoned this revision. pulkit added a comment. Not applicable anymore. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3771 To: pulkit, #hg-reviewers Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list

D4887: narrow: don't include the manifests while widening a narrow clone

pulkit abandoned this revision. pulkit added a comment. Abandoing this one and https://phab.mercurial-scm.org/D4886 as @martinvonz's better fix landed as https://phab.mercurial-scm.org/D4895. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4887 To: pulkit,

D4849: store: introduce a function to get tracked path from a fncache entry

pulkit abandoned this revision. pulkit added a comment. This was an incorrect implementation. A better implementation has been pushed as part of https://phab.mercurial-scm.org/D5139. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4849 To: pulkit,

D5173: py3: make debugindexstats output printing compatible

pulkit abandoned this revision. pulkit added a comment. I remember reading @yuja patches which took care of it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5173 To: pulkit, #hg-reviewers Cc: yuja, mercurial-devel

D5039: py3: add __pycache__ to .hgignore

pulkit updated this revision to Diff 12514. pulkit retitled this revision from "py3: add more py3 specific output to test" to "py3: add __pycache__ to .hgignore". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5039?vs=11973=12514 REVISION DETAIL

D5146: histedit: import chistedit curses UI from hg-experimental

pulkit accepted this revision. pulkit added a comment. Queueing this, many thanks for importing this in core. Can you add some documentation about the new config option to enable curses interface as followup? Also, how do you feel about histedit using curses interface if

D5138: narrow: only send includepats and excludepats if they are not empty

pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in narrowcommands.py:142-143 > should these also be changed? From these, do you mean the oldincludepats and oldexcludepats? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5138 To: pulkit, durin42,

D5190: shallowutil: introduce a helper function isenabled()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG6f0b6905ef6f: shallowutil: introduce a helper function isenabled() (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5190?vs=12337=12426#toc REPOSITORY

D5192: tests: remove lz4 as dependency while running tests

This revision was automatically updated to reflect the committed changes. Closed by commit rHG67e35dceab9b: tests: remove lz4 as dependency while running tests (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5193: remotefilelog: drop compat code for "getbundle_shallow" wireprotocol command

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2dd3a0201307: remotefilelog: drop compat code for getbundle_shallow wireprotocol command (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5191: remotefilelogserver: add a matcher argument to _walkstreamfiles()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1c34b31a6c9c: remotefilelogserver: add a matcher argument to _walkstreamfiles() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5189: remotefilelog: remove some BC code related to streamclone

This revision was automatically updated to reflect the committed changes. Closed by commit rHG525dcf5c1d41: remotefilelog: remove some BC code related to streamclone (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5119: exchange: pass includepats and excludepats as arguments to getbundle()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG440f5b65be57: exchange: pass includepats and excludepats as arguments to getbundle() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5139: store: introduce _matchtrackedpath() and use it to filter store files

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9aeb9e2d28a7: store: introduce _matchtrackedpath() and use it to filter store files (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5138: narrow: only send includepats and excludepats if they are not empty

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa2c4502e409b: narrow: only send includepats and excludepats if they are not empty (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5198: configitems: rename the config to prevent adding an alias in future

This revision was automatically updated to reflect the committed changes. Closed by commit rHG14b6afc6cb28: configitems: rename the config to prevent adding an alias in future (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5198: configitems: rename the config to prevent adding an alias in future

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Right now the config option looks like: [experimental.server] stream-narrow-clones= which does not match how config options are generally defined in

D5193: remotefilelog: drop compat code for "getbundle_shallow" wireprotocol command

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Doing some annotate on hgexperimental shows that getbundle_shallow used to exist in 2013 or before. We don't have any pre-2013 remotefilelog users except Fb

D5191: remotefilelogserver: add a matcher argument to _walkstreamfiles()

pulkit updated this revision to Diff 12341. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5191?vs=12338=12341 REVISION DETAIL https://phab.mercurial-scm.org/D5191 AFFECTED FILES hgext/remotefilelog/remotefilelogserver.py CHANGE DETAILS diff --git

D5192: tests: remove lz4 as dependency while running tests

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY One of the previous patch authored by Augie rips out the lz4 dependency and things should work without it. Now there are just 2-3 tests failing because of

D5190: shallowutil: introduce a helper function isenabled()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch introduces a inenabled() function which will check whether remotefilelog is enabled or not. The function is then also used at all the places where

D5191: remotefilelogserver: add a matcher argument to _walkstreamfiles()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Implementing narrow stream clones in core, I added an optional matcher argument. The function in remotefilelogserver.py does not know about that argument and

D5189: remotefilelog: remove some BC code related to streamclone

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Since remotefilelog is now moved to core and we have streamclone._walkstreamfiles() in core, we don't need to have the backward compatibility code. People

D5183: narrow: rework logic to check whether we need to widen and narrow

This revision was automatically updated to reflect the committed changes. Closed by commit rHG30a7d3b6b281: narrow: rework logic to check whether we need to widen and narrow (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5182: tests: show that adding an already included path still calls narrow_widen()

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd362a41ee5dd: tests: show that adding an already included path still calls narrow_widen() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5183: narrow: rework logic to check whether we need to widen and narrow

pulkit updated this revision to Diff 12325. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5183?vs=12321=12325 REVISION DETAIL https://phab.mercurial-scm.org/D5183 AFFECTED FILES hgext/narrow/narrowcommands.py

D5146: histedit: import chistedit curses UI from hg-experimental

pulkit added a comment. In https://phab.mercurial-scm.org/D5146#77493, @durin42 wrote: > In https://phab.mercurial-scm.org/D5146#77492, @pulkit wrote: > > > I remember using chistedit and finding that the `.hg/chisedit` file is not deleted after chistedit is completed. Looking at

D5146: histedit: import chistedit curses UI from hg-experimental

pulkit added a comment. I remember using chistedit and finding that the `.hg/chisedit` file is not deleted after chistedit is completed. Looking at code, I am unable to find code which deletes that file. Can you please have a look and delete that file after a successfull or aborted

D5183: narrow: rework logic to check whether we need to widen and narrow

pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in narrowcommands.py:429 > nit: s/extend/widen/? that seems like the natural opposite to (the verb) > "narrow" I am fine with anyone, you can fix this in flight or I can send an updated version too. REPOSITORY rHG Mercurial

<    7   8   9   10   11   12   13   14   15   16   >