durham added inline comments.
INLINE COMMENTS
> util.py:594
> +@contextlib.contextmanager
> +def acceptintervention(tr=None):
> +"""A context manager that closes the transaction on InterventionRequired
Technically this will apply to dsguard as well, so 'tr' isn't quite precise.
But I
martinvonz added inline comments.
INLINE COMMENTS
> lothiraldan wrote in util.py:599
> The initial check was slighty more precise (if tr is not None), any specific
> reason for the change?
We generally prefer "not X" over "is not None" when they're functionally
equivalent (and I do think they
lothiraldan added a comment.
LGTM apart from the condition change
INLINE COMMENTS
> util.py:599
> +"""
> +if not tr:
> +yield
The initial check was slighty more precise (if tr is not None), any specific
reason for the change?
REPOSITORY
rHG Mercurial
REVISION DETAIL
