gracinet abandoned this revision.
gracinet added a comment.
Given this conversation, and its outcome as materialised with latest versions
of https://phab.mercurial-scm.org/D5441 and
https://phab.mercurial-scm.org/D5442, we can now simply abandon this one.
REPOSITORY
rHG Mercurial
yuja added a comment.
> @yuja I'm not sure by what you consider exactly to be internals here. If
that's the `[5]` and [6]`, maybe a `parents(revision)` method on the index
would be better ? The obvious drawback would be to write more C code.
>
> Given that my ultimate goal here is
> @yuja I'm not sure by what you consider exactly to be internals here. If
> that's the `[5]` and [6]`, maybe a `parents(revision)` method on the index
> would be better ? The obvious drawback would be to write more C code.
>
> Given that my ultimate goal here is to delegate the whole
gracinet added a comment.
@yuja I'm not sure by what you consider exactly to be internals here. If
that's the `[5]` and [6]`, maybe a `parents(revision)` method on the index
would be better ? The obvious drawback would be to write more C code.
Given that my ultimate goal here is to
yuja added a comment.
> +def parentsfunc(index):
> +def parentrevs(rev):
> +try:
> +entry = index[rev]
> +except IndexError:
> +if rev == wdirrev:
> +raise error.WdirUnsupported
> +raise
> +
> +
> +def parentsfunc(index):
> +def parentrevs(rev):
> +try:
> +entry = index[rev]
> +except IndexError:
> +if rev == wdirrev:
> +raise error.WdirUnsupported
> +raise
> +
> +return entry[5], entry[6]
> +return
gracinet added a comment.
obviously, this one could be adapted for application before the rust-cpython
bindings, and extended for the `incrementalmissingancestors` as well
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5443
To: gracinet, indygreg,
gracinet created this revision.
Herald added a reviewer: indygreg.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Up to now, the pure Python lazyancestors had been taking the parents
function in its constructor, whereas Rust-backed variants
