D6238: branchcache: don't verify while creating a copy

2019-04-16 Thread yuja (Yuya Nishihara)
yuja added a comment. > def copy(self): > """return an deep copy of the branchcache object""" > > - self._verifyall() return type(self)( self._entries, self.tipnode, self.tiprev, self.filteredhash, self._closednodes) Looks good, but it's probably better to copy the verifica

Re: D6238: branchcache: don't verify while creating a copy

2019-04-16 Thread Yuya Nishihara
> def copy(self): > """return an deep copy of the branchcache object""" > -self._verifyall() > return type(self)( > self._entries, self.tipnode, self.tiprev, self.filteredhash, > self._closednodes) Looks good, but it's probably better to cop

D6238: branchcache: don't verify while creating a copy

2019-04-16 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb26455ffa7fa: branchcache: don't verify while creating a copy (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6238?vs=14756&id

D6238: branchcache: don't verify while creating a copy

2019-04-16 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The copy will not be mark as verified, so there is no need to verify nodes. Thanks to Yuya who spotted this while reviewing. REPOSITORY rHG Mercurial REVISION D