D7506: phabricator: add a "phabstatus" show view

2019-12-12 Thread spectral (Kyle Lippincott)
spectral added a comment. In D7506#111966 , @dlax wrote: > In D7506#111947 , @spectral wrote: > >> I don't think `from . import show` works generally. > > I did that because

D7506: phabricator: add a "phabstatus" show view

2019-12-11 Thread dlax (Denis Laxalde)
dlax added a comment. In D7506#111947 , @spectral wrote: > I don't think `from . import show` works generally. I did that because `test-check-module-imports.t` complained otherwise when using `from hgext import show`:

D7506: phabricator: add a "phabstatus" show view

2019-12-11 Thread spectral (Kyle Lippincott)
spectral added a comment. I don't think `from . import show` works generally. I received errors because I imported phabricator via a path (pointing directly at the .py file, something like `[extensions] phabricator = /home/spectral/src/hg/hgext/phabricator.py`), not by doing something like

D7506: phabricator: add a "phabstatus" show view

2019-12-11 Thread dlax (Denis Laxalde)
Closed by commit rHG70060915c3f2: phabricator: add a phabstatus show view (authored by dlax). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7506?vs=18589=18603 CHANGES SINCE LAST

D7506: phabricator: add a "phabstatus" show view

2019-12-10 Thread dlax (Denis Laxalde)
dlax updated this revision to Diff 18589. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7506?vs=18338=18589 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7506/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7506

D7506: phabricator: add a "phabstatus" show view

2019-12-10 Thread pulkit (Pulkit Goyal)
This revision now requires changes to proceed. pulkit added a comment. pulkit requested changes to this revision. `test-check-module-imports.t` says hi! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7506/new/ REVISION DETAIL

D7506: phabricator: add a "phabstatus" show view

2019-11-23 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In D7506#110351 , @dlax wrote: > The revisions shown by the "phabstatus" view is just a subset of that of "work" view (subset of revisions with a differential). Do you see more revisions in "phabstatus" than in

D7506: phabricator: add a "phabstatus" show view

2019-11-23 Thread dlax (Denis Laxalde)
dlax edited the summary of this revision. dlax updated this revision to Diff 18338. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7506?vs=18320=18338 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7506/new/ REVISION DETAIL

D7506: phabricator: add a "phabstatus" show view

2019-11-23 Thread dlax (Denis Laxalde)
dlax added a comment. dlax planned changes to this revision. In D7506#110321 , @mharbison72 wrote: > In D7506#110288 , @mharbison72 wrote: > >> I'm not sure why, but this version seems to also

D7506: phabricator: add a "phabstatus" show view

2019-11-22 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In D7506#110288 , @mharbison72 wrote: > I'm not sure why, but this version seems to also show obsolete revisions. I've got a bunch of `x` and `*` nodes in hg-committed right now. I didn't see that before,

D7506: phabricator: add a "phabstatus" show view

2019-11-22 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. I'm not sure why, but this version seems to also show obsolete revisions. I've got a bunch of `x` and `*` nodes in hg-committed right now. I didn't see that before, although that was on a different clone that I don't have access to now. REPOSITORY rHG

D7506: phabricator: add a "phabstatus" show view

2019-11-22 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In D7506#110249 , @dlax wrote: > In D7506#110225 , @mharbison72 wrote: > >> I'm also interested in coloring the status value, but I can tinker with that after it's

D7506: phabricator: add a "phabstatus" show view

2019-11-22 Thread dlax (Denis Laxalde)
dlax updated this revision to Diff 18320. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7506?vs=18315=18320 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7506/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7506

D7506: phabricator: add a "phabstatus" show view

2019-11-22 Thread dlax (Denis Laxalde)
dlax added a comment. dlax planned changes to this revision. In D7506#110225 , @mharbison72 wrote: > I like it. Thanks! > Any idea why the changeset isn't colored, unlike `hg show stack`? It might also be a little more readable if

D7506: phabricator: add a "phabstatus" show view

2019-11-22 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. I like it. Any idea why the changeset isn't colored, unlike `hg show stack`? It might also be a little more readable if the URI and status line were tabbed in, but maybe colored cset hashes would make that unnecessary? I'm also interested in coloring

D7506: phabricator: add a "phabstatus" show view

2019-11-22 Thread dlax (Denis Laxalde)
dlax updated this revision to Diff 18315. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7506?vs=18313=18315 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7506/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7506

D7506: phabricator: add a "phabstatus" show view

2019-11-22 Thread dlax (Denis Laxalde)
dlax created this revision. Herald added subscribers: mercurial-devel, Kwan, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We add a "phabstatus" show view (called as "hg show phabstatus") which renders a dag with underway revisions associated with a differential