D8029: uncopy: add new `hg uncopy` command

martinvonz added a comment. In D8029#119813 , @marmoute wrote: > I am still not convinced by the command name. > > In D8029#118464 , @martinvonz wrote: > >> In D8029#118463

D8029: uncopy: add new `hg uncopy` command

This revision now requires changes to proceed. marmoute added a comment. marmoute requested changes to this revision. I am still not convinced by the command name. In D8029#118464 , @martinvonz wrote: > In D8029#118463

D8029: uncopy: add new `hg uncopy` command

martinvonz updated this revision to Diff 19725. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8029?vs=19692&id=19725 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8029/new/ REVISION DETAIL https://phab.mercurial-scm.org/

D8029: uncopy: add new `hg uncopy` command

martinvonz added inline comments. INLINE COMMENTS > martinvonz wrote in commands.py:7502 > Oops, I just forgot about that, I think. I'll send a follow-up (I assume you > know that many of the patches you're reviewing now are already queued). Sorry, I forgot that this series was just accepted bu

D8029: uncopy: add new `hg uncopy` command

martinvonz added inline comments. INLINE COMMENTS > pulkit wrote in cmdutil.py:1698 > generally we refer to `repo[None]` as `wctx` right? I didn't do that because I had planned the next patch, where the same code is used for working copy and not, so `ctx` isn't necessarily the working copy. >

D8029: uncopy: add new `hg uncopy` command

pulkit added inline comments. INLINE COMMENTS > cmdutil.py:1698 > +def uncopy(ui, repo, pats, opts): > +ctx = repo[None] > + generally we refer to `repo[None]` as `wctx` right? > commands.py:7502 > +) > +def uncopy(ui, repo, *pats, **opts): > +"""unmark files as copied""" We should add

D8029: uncopy: add new `hg uncopy` command

martinvonz updated this revision to Diff 19692. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8029?vs=19669&id=19692 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8029/new/ REVISION DETAIL https://phab.mercurial-scm.org/

D8029: uncopy: add new `hg uncopy` command

durin42 added a comment. In D8029#118464 , @martinvonz wrote: > In D8029#118463 , @marmoute wrote: > >> Coudl we use a flag for to `hg copy` for that ? something like `hg copy --forget` > >

D8029: uncopy: add new `hg uncopy` command

martinvonz added a comment. In D8029#118463 , @marmoute wrote: > Coudl we use a flag for to `hg copy` for that ? something like `hg copy --forget` Why would you prefer that? Discoverability? An argument against it is that the command

D8029: uncopy: add new `hg uncopy` command

marmoute added a comment. Coudl we use a flag for to `hg copy` for that ? something like `hg copy --forget` REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8029/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8029 To: martinvonz, #hg-reviewers

D8029: uncopy: add new `hg uncopy` command

martinvonz updated this revision to Diff 19669. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8029?vs=19662&id=19669 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8029/new/ REVISION DETAIL https://phab.mercurial-scm.org/

D8029: uncopy: add new `hg uncopy` command

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY To unmark a file as copied, the user currently has to do this: hg forget hg add The new command simplifies that to: hg uncopy That'