D8353: debugcommands: create new debugantivirusrunning command

Closed by commit rHG87047efbc6a6: debugcommands: create new debugantivirusrunning command (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8353?vs=21426&id=21955

D8353: debugcommands: create new debugantivirusrunning command

pulkit added a comment. I will go ahead and push it before upcoming rc if I hear no objections. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8353/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8353 To: durin42, #hg-reviewers, marmoute Cc: kh

D8353: debugcommands: create new debugantivirusrunning command

khanchi97 added a comment. In D8353#129493 , @pulkit wrote: > In D8353#128839 , @marmoute wrote: > >> In D8353#128838 , @durin42 wrote: >> >>> Sa

D8353: debugcommands: create new debugantivirusrunning command

pulkit added a comment. In D8353#128839 , @marmoute wrote: > In D8353#128838 , @durin42 wrote: > >> Sadly I have no idea on that. > > Do we have a poor windows user that could serve an a gu

D8353: debugcommands: create new debugantivirusrunning command

marmoute added a comment. In D8353#128838 , @durin42 wrote: > Sadly I have no idea on that. Do we have a poor windows user that could serve an a guinea pig here ? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercur

D8353: debugcommands: create new debugantivirusrunning command

durin42 added a comment. Sadly I have no idea on that. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8353/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8353 To: durin42, #hg-reviewers, marmoute Cc: mercurial-patches, marmoute, mharbison72,

D8353: debugcommands: create new debugantivirusrunning command

marmoute added a comment. My main question here is : what does "AV engine would lose its lunch" translate in terms of the python runtime ? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8353/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8353

D8353: debugcommands: create new debugantivirusrunning command

durin42 added a comment. Best guess (given I've never hit an AV problem) is that the AV engine would lose its lunch on the EICAR file and alert the user. I figure if the AV engine isn't picking up on it after 2 seconds then it's probably also not a performance issue for us. REPOSITORY rHG

D8353: debugcommands: create new debugantivirusrunning command

marmoute added a comment. marmoute accepted this revision. Seems overall good. I have some fear over the `sleep` usage, butit does not seems to depends on test, and I don't know what antivirus looks like. INLINE COMMENTS > debugcommands.py:143 > +# Give an AV engine time to scan the file

D8353: debugcommands: create new debugantivirusrunning command

Herald added a subscriber: mercurial-patches. durin42 updated this revision to Diff 21426. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8353?vs=20929&id=21426 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8353/new/ REVISI

D8353: debugcommands: create new debugantivirusrunning command

This revision now requires changes to proceed. marmoute added a comment. marmoute requested changes to this revision. The approach seems good, but extra comment and cleanup would be nice. INLINE COMMENTS > debugcommands.py:139 > +) > +) > + As @mharbison72 pointed out, it

D8353: debugcommands: create new debugantivirusrunning command

durin42 added a comment. I don't think so, since it's base85-armored and my understanding is that really it's only supposed to trigger in isolation... REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8353/new/ REVISION DETAIL https://phab.mercurial-sc

D8353: debugcommands: create new debugantivirusrunning command

marmoute added inline comments. INLINE COMMENTS > debugcommands.py:135-138 > +util.b85decode( > +b'ST#=}P$fV?P+K%yP+C|uG$>GBDK|qyDK~v2MM* +b'E<)&Nm5l)EmTEQR4qnHOhq9iNGnJx' > +) I think it could be useful to have a clarification of this payl

D8353: debugcommands: create new debugantivirusrunning command

marmoute added a comment. Silly question, could make anti virus cough on the mercurial source itself? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8353/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8353 To: durin42, #hg-reviewers Cc: marmou

D8353: debugcommands: create new debugantivirusrunning command

mharbison72 added a comment. In D8353#124949 , @durin42 wrote: > In D8353#124948 , @mharbison72 wrote: > >> Should it delete the file after writing it, or don't bother because the AV may have it

D8353: debugcommands: create new debugantivirusrunning command

durin42 added a comment. In D8353#124948 , @mharbison72 wrote: > Should it delete the file after writing it, or don't bother because the AV may have it locked? I figured just leave it since it's tiny, but maybe we should sleep for a whil

D8353: debugcommands: create new debugantivirusrunning command

mharbison72 added a comment. Should it delete the file after writing it, or don't bother because the AV may have it locked? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8353/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8353 To: durin42, #

D8353: debugcommands: create new debugantivirusrunning command

durin42 added a comment. In D8353#124864 , @indygreg wrote: > I do not understand what the intended side-effect of running this command is supposed to be. Well, if an AV engine isn't configured to ignore the user's clone, then this will

D8353: debugcommands: create new debugantivirusrunning command

indygreg added a comment. I do not understand what the intended side-effect of running this command is supposed to be. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8353/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8353 To: durin42, #hg-re

D8353: debugcommands: create new debugantivirusrunning command

durin42 updated this revision to Diff 20929. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8353?vs=20928&id=20929 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8353/new/ REVISION DETAIL https://phab.mercurial-scm.org/D83

D8353: debugcommands: create new debugantivirusrunning command

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This writes the EICAR test file to .hg/cache, in an attempt to trigger an AV scanner's scanning engine. This should let us (in theory) detect some cases when a u