[Mesa-dev] [PATCH 1/3] drm_driver: Add a configuration function to the driver descriptor.

2011-10-12 Thread Thomas Hellstrom
Adds a possibility for the state tracker manager to query the target for a specific configuration. Signed-off-by: Thomas Hellstrom --- src/gallium/include/state_tracker/drm_driver.h| 47 - src/gallium/targets/dri-i915/target.c |2 +- src/gallium/targets/

[Mesa-dev] [PATCH 2/3] st/dri: Hook up throttling based on the drm driver_descriptor configuration

2011-10-12 Thread Thomas Hellstrom
Hooks up throttling if there is a configuration function present and it indicates that throttling is desired. Signed-off-by: Thomas Hellstrom --- .../state_trackers/dri/common/dri_drawable.c |4 ++- src/gallium/state_trackers/dri/common/dri_screen.h |1 + src/gallium/state_trackers

[Mesa-dev] [PATCH 3/3] dri-vmwgfx: Hook up a drm_descriptor configuration function

2011-10-12 Thread Thomas Hellstrom
Returns a configuration that makes the dri state-tracker-manager throttle. Also disable kernel-based throttling. Signed-off-by: Thomas Hellstrom --- src/gallium/targets/dri-vmwgfx/target.c | 20 ++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/src/gallium/ta

Re: [Mesa-dev] [PATCH 1/3] dri2: Implement a throttle dri extension.

2011-10-12 Thread Thomas Hellstrom
Thanks for reviewing, Michel. On 10/11/2011 05:29 PM, Michel Dänzer wrote: On Die, 2011-10-11 at 15:44 +0200, Thomas Hellstrom wrote: The X server has limited throttle support on the server side, but doing this in the client has some benefits: 1) X server throttling is per client. Client si

Re: [Mesa-dev] [PATCH 1/3] dri2: Implement a throttle dri extension.

2011-10-12 Thread Michel Dänzer
On Mit, 2011-10-12 at 11:35 +0200, Thomas Hellstrom wrote: > Thanks for reviewing, Michel. > On 10/11/2011 05:29 PM, Michel Dänzer wrote: > > On Die, 2011-10-11 at 15:44 +0200, Thomas Hellstrom wrote: > > > >> The X server has limited throttle support on the server side, > >> but doing this in

[Mesa-dev] [Bug 41715] New: Crash in update_vertex_textures at state_tracker/st_atom_texture.c:285

2011-10-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41715 Summary: Crash in update_vertex_textures at state_tracker/st_atom_texture.c:285 Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status:

[Mesa-dev] [PATCH] dri2: Implement a throttle dri extension v2

2011-10-12 Thread Thomas Hellstrom
The X server has limited throttle support on the server side, but doing this in the client has some benefits: 1) X server throttling is per client. Client side throttling can be done per drawable. 2) It's easier to control the throttling based on what client is run, for example using "driconf".

Re: [Mesa-dev] [PATCH 1/2] swrast: Fix fastpaths in glRead/WritePixels(GL_DEPTH_STENCIL)

2011-10-12 Thread Brian Paul
On 10/11/2011 09:57 PM, Eric Anholt wrote: On Mon, 10 Oct 2011 18:10:59 -0700, Chad Versace wrote: For glReadPixels, the user supplied pixels have format GL_UNSIGNED_INT_24_8. But, when the depthstencil buffer's format was MESA_FORMAT_S8_Z24, the fastpath read from the buffer without reorderin

Re: [Mesa-dev] [PATCH] gallium: add PIPE_BIND_BLENDABLE flag

2011-10-12 Thread Brian Paul
On 10/10/2011 01:53 PM, Christoph Bumiller wrote: This is required for d3d1x's CheckFormatSupport query. It also seems generally useful for state trackers, which could choose alternative rendering paths or formats if blending would come at a significant performance loss. --- src/gallium/docs/s

Re: [Mesa-dev] [PATCH] gallium: add PIPE_BIND_BLENDABLE flag

2011-10-12 Thread Christoph Bumiller
On 12.10.2011 16:12, Brian Paul wrote: > On 10/10/2011 01:53 PM, Christoph Bumiller wrote: >> This is required for d3d1x's CheckFormatSupport query. >> >> It also seems generally useful for state trackers, which could >> choose alternative rendering paths or formats if blending would >> come at a s

Re: [Mesa-dev] [PATCH 3/6] mesa: check attachment Type field in renderbuffer_exists()

2011-10-12 Thread Eric Anholt
On Mon, 10 Oct 2011 21:05:33 -0600, Brian Paul wrote: > From: Brian Paul > > Instead of the renderbuffer pointer. In the future, attaching a texture > may not mean the renderbuffer pointer gets set too. > Plus, remove some commented-out assertions. I'm curious where you're going with not havin

Re: [Mesa-dev] [PATCH 4/6] mesa: remove redundant buffer checks in copytexture_error_check()

2011-10-12 Thread Eric Anholt
On Mon, 10 Oct 2011 21:05:34 -0600, Brian Paul wrote: > From: Brian Paul > > There was already a call to _mesa_source_buffer_exists() earlier in > the function. Reviewed-by: Eric Anholt pgpCtpDmdjpXR.pgp Description: PGP signature ___ mesa-dev mail

Re: [Mesa-dev] [PATCH 6/6] s/format/baseFormat/ to be more explicit

2011-10-12 Thread Eric Anholt
On Mon, 10 Oct 2011 21:05:36 -0600, Brian Paul wrote: > From: Brian Paul This and 5/6 are also Reviewed-by: Eric Anholt pgpJglcbqFLVY.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.o

Re: [Mesa-dev] [PATCH] mesa: consolidate _mesa_source/dest_buffer_exists()

2011-10-12 Thread Eric Anholt
On Tue, 11 Oct 2011 18:41:33 -0600, Brian Paul wrote: > From: Brian Paul > > v2: add a 'reading' parameter to distinguish between reading and writing > to the renderbuffer (we don't want to check if _ColorReadBuffer is null > when we're about to draw). Eric found this mistake. Reviewed-by: Eri

Re: [Mesa-dev] [PATCH] i965 Gen6+: De-compact clip plane constants for old VS backend.

2011-10-12 Thread Eric Anholt
On Mon, 10 Oct 2011 15:13:13 -0700, Paul Berry wrote: > In commit 018ea68d8780ab5baeef0b8122b8410e5e55ae6d, when I > de-compacted clip planes on Gen6+, I updated both the old and new VS > back-ends to reflect the change in how clip planes are stored, but I > failed to change the code in gen6_vs_st

Re: [Mesa-dev] [PATCH 04/10] i965: Document the brw_instruction Message Descriptor structures.

2011-10-12 Thread Eric Anholt
On Mon, 10 Oct 2011 16:31:47 -0700, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke Reviewed-by: Eric Anholt pgpl8aUbGk0IZ.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/

Re: [Mesa-dev] [PATCH 06/10] i965: Factor out code for setting Message Descriptors.

2011-10-12 Thread Eric Anholt
On Mon, 10 Oct 2011 16:31:49 -0700, Kenneth Graunke wrote: > Every brw_set_???_message function had duplicated code, per-generation, > to set the Message Descriptor and Extended Message Descriptor bits > (SFID, message length, response length, header present, end of thread). > > However, these f

Re: [Mesa-dev] [PATCH 3/6] mesa: check attachment Type field in renderbuffer_exists()

2011-10-12 Thread Brian Paul
On 10/12/2011 10:20 AM, Eric Anholt wrote: On Mon, 10 Oct 2011 21:05:33 -0600, Brian Paul wrote: From: Brian Paul Instead of the renderbuffer pointer. In the future, attaching a texture may not mean the renderbuffer pointer gets set too. Plus, remove some commented-out assertions. I'm curio

Re: [Mesa-dev] [PATCH 1/3] mesa: move gl_texture_image::Data, RowStride, ImageOffsets to swrast

2011-10-12 Thread Eric Anholt
On Mon, 10 Oct 2011 20:27:44 -0600, Brian Paul wrote: > From: Brian Paul > > Only swrast and the drivers that fall back to swrast need these fields now. > This removes the last of the fields related to software rendering from > gl_texture_image. > + /* Allocate the swrast_texture_image::Image

Re: [Mesa-dev] [PATCH] mesa: take into account indices offset for bounds check

2011-10-12 Thread Eric Anholt
On Sat, 24 Sep 2011 13:08:43 +0400, Vadim Girlin wrote: > --- > src/mesa/main/api_validate.c |9 ++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c > index 1fcf5cd..9338f4c 100644 > --- a/src/mesa/main/api

Re: [Mesa-dev] [PATCH] gallium: add PIPE_BIND_BLENDABLE flag

2011-10-12 Thread Roland Scheidegger
Am 12.10.2011 16:31, schrieb Christoph Bumiller: >> So do we need to go in and add PIPE_BIND_BLENDABLE to all of our >> existing surface-create calls in the state tracker, etc? >> > > Well, that depends on whether we want to put blending fallbacks at the > state tracker level (OpenGL is probably t

Re: [Mesa-dev] [PATCH] gallium: add PIPE_BIND_BLENDABLE flag

2011-10-12 Thread Christoph Bumiller
On 12.10.2011 19:17, Roland Scheidegger wrote: > Am 12.10.2011 16:31, schrieb Christoph Bumiller: >>> So do we need to go in and add PIPE_BIND_BLENDABLE to all of our >>> existing surface-create calls in the state tracker, etc? >>> >> Well, that depends on whether we want to put blending fallbacks

Re: [Mesa-dev] [PATCH 1/3] mesa: move gl_texture_image::Data, RowStride, ImageOffsets to swrast

2011-10-12 Thread Brian Paul
On 10/12/2011 10:57 AM, Eric Anholt wrote: On Mon, 10 Oct 2011 20:27:44 -0600, Brian Paul wrote: From: Brian Paul Only swrast and the drivers that fall back to swrast need these fields now. This removes the last of the fields related to software rendering from gl_texture_image. + /* Alloc

Re: [Mesa-dev] [PATCH 01/10] i965: Use Ivybridge's "Legacy Data Port" for reads/writes.

2011-10-12 Thread Kenneth Graunke
On 10/11/2011 09:13 PM, Eric Anholt wrote: > On Mon, 10 Oct 2011 16:31:44 -0700, Kenneth Graunke > wrote: >> Using the constant cache for reads isn't going to work for scratch >> reads (variably-indexed arrays or register spills), as these aren't >> constant at all. >> >> Also, in the new VS back

Re: [Mesa-dev] [PATCH] gallium: add PIPE_BIND_BLENDABLE flag

2011-10-12 Thread Roland Scheidegger
Am 12.10.2011 19:35, schrieb Christoph Bumiller: > On 12.10.2011 19:17, Roland Scheidegger wrote: >> Am 12.10.2011 16:31, schrieb Christoph Bumiller: So do we need to go in and add PIPE_BIND_BLENDABLE to all of our existing surface-create calls in the state tracker, etc? >>> Well, th

Re: [Mesa-dev] Building with -fno-builtin-memcmp for improved performance

2011-10-12 Thread Jose Fonseca
I've changed the scons to always build with -fno-builtin-memcmp. Jose - Original Message - > On Tue, 2011-09-20 at 16:35 +0200, Roland Scheidegger wrote: > > Am 20.09.2011 16:15, schrieb Keith Whitwell: > > > On Tue, 2011-09-20 at 16:02 +0200, Roland Scheidegger wrote: > > >> Am 20.09.201

Re: [Mesa-dev] [PATCH] Add an autoconf option for mangling Mesa.

2011-10-12 Thread tom fogal
*ping* any review? Dan, I think you're probably the best to review this, if you have a minute. -tom tfo...@sci.utah.edu writes: > From: Tom Fogal > > In addition to setting up the flags correctly, this renames the > generated libraries to ensure they get 'Mangled' in the name. > This is very u

[Mesa-dev] Profiling video driver

2011-10-12 Thread Martin Stolpe
Hello, I'm using the Gallium R300 driver with the Xorg state tracker on my system. Everything is running very smoothly when I'm using OpenGL ES 2.0 composited mode of kwin. Running for example Notepad++ in wine on the other hand is painfully slow. I've tried to profile a Notepad++ session using

Re: [Mesa-dev] gl_NormalMatrix issue on Intel driver

2011-10-12 Thread tom fogal
Hi Ian, Kenneth, Ian Romanick writes: > On 10/10/2011 03:30 PM, tom fogal wrote: > > One of our programs which relies on shaders heavily is having > > issues, and I have tracked it down to unexpected values in > > gl_NormalMatrix within the fragment shader. > > I think we could make a more genera

[Mesa-dev] [PATCH v2] mesa: take into account indices offset for bounds check

2011-10-12 Thread Vadim Girlin
Signed-off-by: Vadim Girlin --- v2: using helper function src/mesa/main/api_validate.c | 21 ++--- 1 files changed, 18 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c index 1fcf5cd..432fd08 100644 --- a/src/mesa/main/api

Re: [Mesa-dev] [PATCH 1/3] mesa: move gl_texture_image::Data, RowStride, ImageOffsets to swrast

2011-10-12 Thread Eric Anholt
On Wed, 12 Oct 2011 11:44:10 -0600, Brian Paul wrote: > On 10/12/2011 10:57 AM, Eric Anholt wrote: > > On Mon, 10 Oct 2011 20:27:44 -0600, Brian Paul > > wrote: > >> From: Brian Paul > >> > >> Only swrast and the drivers that fall back to swrast need these fields now. > >> This removes the last

[Mesa-dev] [PATCH v3] mesa: take into account indices offset for bounds check

2011-10-12 Thread Vadim Girlin
Signed-off-by: Vadim Girlin --- Sorry, overlooked whitespace issues in v2 src/mesa/main/api_validate.c | 23 --- 1 files changed, 20 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c index 1fcf5cd..901f50f 100644 --- a/

[Mesa-dev] [PATCH] i965: setup address rounding enable bits

2011-10-12 Thread Yuanhan Liu
The patch(based on the reading of the emulator) came from while I was trying to fix the oglc pbo texImage.1PBODefaults fail. This case generates a texture with the width and height equal to window's width and height respectively, then try to texture it on the whole window. So, it's exactly one texe

Re: [Mesa-dev] Profiling video driver

2011-10-12 Thread Michel Dänzer
On Mit, 2011-10-12 at 22:54 +0200, Martin Stolpe wrote: > > I'm using the Gallium R300 driver with the Xorg state tracker on my system. > Everything is running very smoothly when I'm using OpenGL ES 2.0 composited > mode of kwin. Running for example Notepad++ in wine on the other hand is > pai