Re: [Mesa-dev] [PATCH] glsl: Fix handling of array dereferences of vectors in opt_dead_code_local

2013-02-08 Thread Eric Anholt
Ian Romanick writes: > On 02/08/2013 04:24 PM, Eric Anholt wrote: >> Ian Romanick writes: >> >>> From: Ian Romanick >>> + * modes. In the first mode, when \c want_availability_mask is \c true, >>> it is >>> + * assumed that any field of the vector may be written. This is used when >>> + * ad

Re: [Mesa-dev] [PATCH] glsl: Fix handling of array dereferences of vectors in opt_dead_code_local

2013-02-08 Thread Ian Romanick
On 02/08/2013 04:24 PM, Eric Anholt wrote: Ian Romanick writes: From: Ian Romanick Three parts to the fix: 1. If the array dereference is a constant index, figure out the real write mask. 2. If the array dereference not is a constant index, assume the assignment may generate any component.

Re: [Mesa-dev] [PATCH 1/8] mesa: fill in SRGB cases in _mesa_format_matches_format_and_type

2013-02-08 Thread Ian Romanick
On 02/08/2013 05:13 PM, Marek Olšák wrote: Hi Ian, 9 days have passed and I wouldn't like to delay this series any further. If it's okay with you, I will commit it in 2 days (or sooner). Gak. I completely missed your original message while I was traveling for FOSDEM... and it got lost in the

[Mesa-dev] [PATCH v2] configure.ac: Do not error out if librt is not available.

2013-02-08 Thread Vinson Lee
Some platforms, such as Mac OS X, do not have librt. Signed-off-by: Vinson Lee --- configure.ac | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 6735fdc..9b9a0ad 100644 --- a/configure.ac +++ b/configure.ac @@ -500,8 +500,7 @@ AC_CHECK_FUNC(

[Mesa-dev] [Bug 60527] New: [softpipe] fbo-stencil GL_DEPTH24_STENCIL8 clear regression

2013-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60527 Priority: medium Bug ID: 60527 Keywords: regression CC: mar...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] fbo-stencil GL_DEPTH24_STENCIL8 clear

Re: [Mesa-dev] [PATCH] intel: Do not expose OES_compressed_ETC1_RGB8_texture or ARB_texture_rgb10_a2ui pre-GEN4

2013-02-08 Thread Kenneth Graunke
On 02/08/2013 06:05 PM, Ian Romanick wrote: From: Ian Romanick Older hardware cannot do ARB_texture_rgb10_a2ui, and the translation code for OES_compressed_ETC1_RGB8_texture was never implemented in the i915 driver. NOTE: This is a candidate for all stable branches. Signed-off-by: Ian Romanic

Re: [Mesa-dev] [PATCH] intel: Do not expose OES_compressed_ETC1_RGB8_texture or ARB_texture_rgb10_a2ui pre-GEN4

2013-02-08 Thread Anuj Phogat
On Fri, Feb 8, 2013 at 6:05 PM, Ian Romanick wrote: > From: Ian Romanick > > Older hardware cannot do ARB_texture_rgb10_a2ui, and the translation > code for OES_compressed_ETC1_RGB8_texture was never implemented in the > i915 driver. > > NOTE: This is a candidate for all stable branches. > > Sign

[Mesa-dev] [PATCH] intel: Do not expose OES_compressed_ETC1_RGB8_texture or ARB_texture_rgb10_a2ui pre-GEN4

2013-02-08 Thread Ian Romanick
From: Ian Romanick Older hardware cannot do ARB_texture_rgb10_a2ui, and the translation code for OES_compressed_ETC1_RGB8_texture was never implemented in the i915 driver. NOTE: This is a candidate for all stable branches. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/intel/intel_exten

Re: [Mesa-dev] [PATCH 1/8] mesa: fill in SRGB cases in _mesa_format_matches_format_and_type

2013-02-08 Thread Marek Olšák
Hi Ian, 9 days have passed and I wouldn't like to delay this series any further. If it's okay with you, I will commit it in 2 days (or sooner). Marek On Thu, Jan 31, 2013 at 9:30 PM, Marek Olšák wrote: > Here's the branch: > > git://people.freedesktop.org/~mareko/mesa rgbx-and-texstore > > Plea

[Mesa-dev] [Bug 60524] New: [softpipe] piglit depthstencil-render-miplevels 146 s=z24_s8 regression

2013-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60524 Priority: medium Bug ID: 60524 Keywords: regression CC: mar...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] piglit depthstencil-render-miplevels 146

Re: [Mesa-dev] [PATCH] glsl: Fix handling of array dereferences of vectors in opt_dead_code_local

2013-02-08 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > Three parts to the fix: > > 1. If the array dereference is a constant index, figure out the real > write mask. > > 2. If the array dereference not is a constant index, assume the > assignment may generate any component. > > 3. If the array dereferenc

Re: [Mesa-dev] [PATCH] i965: Fix Vertex URB Read Length calculation in 3DSTATE_SF on Gen6.

2013-02-08 Thread Martin Steigerwald
Am Mittwoch, 6. Februar 2013 schrieb Daniel Vetter: > On Tue, Feb 05, 2013 at 10:40:28PM +0100, Martin Steigerwald wrote: > > Am Dienstag, 5. Februar 2013 schrieb Daniel Vetter: > > > On Sat, Feb 02, 2013 at 09:22:55PM +0100, Martin Steigerwald wrote: > > > > About these messages: Uhm, bingo: > > >

Re: [Mesa-dev] [PATCH 1/5] i965: Fix indentation of index buffer rebase code.

2013-02-08 Thread Kenneth Graunke
On 02/04/2013 07:31 PM, Eric Anholt wrote: --- src/mesa/drivers/dri/i965/brw_draw_upload.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) For the series: Reviewed-by: Kenneth Graunke ___ mesa-dev mailing list mesa-dev@

[Mesa-dev] [Bug 60518] glDrawElements segfault when compiled into display list

2013-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60518 --- Comment #1 from cor...@gmx.net --- Apitrace download link (attaching failed due to size): http://www.gamefront.com/files/22931297/vdrift.trace.gz -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 60518] New: glDrawElements segfault when compiled into display list

2013-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60518 Priority: medium Bug ID: 60518 Assignee: mesa-dev@lists.freedesktop.org Summary: glDrawElements segfault when compiled into display list Severity: normal Classification:

Re: [Mesa-dev] [PATCH] r600g: fix lockup when hyperz & alpha test are enabled together.

2013-02-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Please cherry-pick this to the 9.1 branch (cherry-picks for Mesa should be done with the -x parameter). Marek On Fri, Feb 8, 2013 at 10:02 PM, wrote: > From: Jerome Glisse > > Seems that alpha test being enabled confuse the GPU on the order in > which it should perfo

Re: [Mesa-dev] RFC: Considering changing Mesa's interpretation of when is the "flat" keyword is required.

2013-02-08 Thread Paul Berry
On 7 February 2013 17:33, Ian Romanick wrote: > On 02/07/2013 08:40 AM, Brian Paul wrote: > >> On 02/06/2013 03:10 PM, Paul Berry wrote: >> >>> Background: >>> >>> All of the GLSL specs from GLSL 1.30 (and GLSL ES 3.00) onward contain >>> language requiring certain integer variables to be declare

[Mesa-dev] [PATCH] r600g: fix lockup when hyperz & alpha test are enabled together.

2013-02-08 Thread j . glisse
From: Jerome Glisse Seems that alpha test being enabled confuse the GPU on the order in which it should perform the Z testing. So force the order programmed throught db shader control. Signed-off-by: Jerome Glisse --- src/gallium/drivers/r600/evergreen_state.c | 5 + src/gallium/drivers/r6

Re: [Mesa-dev] [PATCH 2/5] i965: Use _NEW_POLYGON in brw_wm_state, not _NEW_POLYGONSTIPPLE.

2013-02-08 Thread Ian Romanick
On 02/07/2013 11:31 PM, Kenneth Graunke wrote: _NEW_POLYGONSTIPPLE covers the polygon stipple /pattern/, but the enable flag is covered by _NEW_POLYGON. NOTE: This is a candidate for stable branches. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_wm_state.c | 4 +--- 1 fil

[Mesa-dev] Mesa 9.1 RC1 later today

2013-02-08 Thread Ian Romanick
I'm planning to make RC1 later this afternoon, and I'll make RC2 next Friday. If you have patches to cherry pick from master, please do so. I would have sent out notice sooner, but I was sick the first half of the week, and I'm still trying to catch up. :( If all goes well, RC2 will become th

Re: [Mesa-dev] [PATCH] intel: Ensure variable intel is used in i915 builds.

2013-02-08 Thread Ian Romanick
On 02/07/2013 10:58 PM, Vinson Lee wrote: Fixes unused pointer value defect reported by Coverity. Signed-off-by: Vinson Lee Reviewed-by: Ian Romanick --- src/mesa/drivers/dri/intel/intel_tex_copy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/

Re: [Mesa-dev] [PATCH 1/2] mesa: don't use format chooser code for glCompressedTexImage

2013-02-08 Thread Ian Romanick
On 02/08/2013 09:35 AM, Brian Paul wrote: On 02/07/2013 10:25 PM, Ian Romanick wrote: On 01/31/2013 06:02 PM, Brian Paul wrote: When glCompressedTexImage is called the internalFormat is a specific format for the incoming image and the the hardware format should be ^^^ the same (since we n

Re: [Mesa-dev] [PATCH 2/2] R600: Add a pattern for fma (fused multiply add)

2013-02-08 Thread Roland Scheidegger
Am 08.02.2013 12:12, schrieb Michel Dänzer: > On Don, 2013-02-07 at 17:23 -0500, Tom Stellard wrote: >> From: Tom Stellard >> >> NOTE: This is a candidate for the Mesa stable branches >> --- >> lib/Target/R600/R600Instructions.td |7 +++ >> 1 files changed, 7 insertions(+), 0 deletions(-

Re: [Mesa-dev] [PATCH V3 12/19] mesa: implement TexImage*Multisample

2013-02-08 Thread Chris Forbes
Oops -- there's still one TODO in here, for the interaction with ARB_internalformat_query. I'll fix that soon. On Fri, Feb 8, 2013 at 10:19 PM, Chris Forbes wrote: > V2: - fix formatting issues > - generate GL_OUT_OF_MEMORY if teximage cannot be allocated > - fix for state moving from tex

Re: [Mesa-dev] [PATCH 1/2] softpipe: clean up lod computation

2013-02-08 Thread Roland Scheidegger
Am 08.02.2013 16:22, schrieb Brian Paul: > On 02/06/2013 10:59 AM, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> This should handle the new lod_zero modifier more correctly. >> The runtime-conditional is a bit more complex however we now also do >> scalar lod computation when appropri

Re: [Mesa-dev] [PATCH 1/2] mesa: don't use format chooser code for glCompressedTexImage

2013-02-08 Thread Brian Paul
On 02/07/2013 10:25 PM, Ian Romanick wrote: On 01/31/2013 06:02 PM, Brian Paul wrote: When glCompressedTexImage is called the internalFormat is a specific format for the incoming image and the the hardware format should be ^^^ the same (since we never do format transcoding). So use the sim

Re: [Mesa-dev] [PATCH 2/2] llvmpipe: implement dual source blending

2013-02-08 Thread Roland Scheidegger
Forgot to mention, this passes the piglit arb_blend_func_extended tests. Oh and I forgot to remove the load_shader_output function in this patch (this was an attempt to factor out some more code but ultimately I reverted it as it made the code no bit simpler). Roland Am 08.02.2013 04:19, schrieb

Re: [Mesa-dev] [PATCH 1/2] llvmpipe: first steps of adding dual source blend support

2013-02-08 Thread Jose Fonseca
- Original Message - > From: Roland Scheidegger > > This adds support of the additional blending factors to the blend function > itself, and also enables testing of it in lp_test_blend (which passes). > Still need to add the glue code of linking fs shader outputs to blend inputs > in ll

Re: [Mesa-dev] [PATCH 2/2] llvmpipe: implement dual source blending

2013-02-08 Thread Brian Paul
On 02/07/2013 08:19 PM, srol...@vmware.com wrote: From: Roland Scheidegger link up the fs outputs and blend inputs, and make sure the second blend source is correctly loaded and converted (which is quite complex). There's a slight refactoring of the monster generate_unswizzled_blend() function w

Re: [Mesa-dev] [PATCH 1/2] softpipe: clean up lod computation

2013-02-08 Thread Brian Paul
On 02/06/2013 10:59 AM, srol...@vmware.com wrote: From: Roland Scheidegger This should handle the new lod_zero modifier more correctly. The runtime-conditional is a bit more complex however we now also do scalar lod computation when appropriate which should more than make up for it. The refactor

Re: [Mesa-dev] [PATCH 2/2] softpipe: fix using optimized filter function

2013-02-08 Thread Roland Scheidegger
Am 08.02.2013 15:32, schrieb Jose Fonseca: > Looks good. > > Should PIPE_TEXTURE_RECT be allowed too? Texture rectangles don't support repeat wrap, so testing for them wouldn't really help much. > > Jose > > - Original Message - >> From: Roland Scheidegger >> >> This optimized filter (

Re: [Mesa-dev] [PATCH 1/3] llvmpipe: refactoring of visibility counter handling

2013-02-08 Thread Brian Paul
On 02/07/2013 08:20 PM, srol...@vmware.com wrote: From: Roland Scheidegger There can be other per-thread data than just vis_counter, so pass a struct around instead (some of our non-public code uses this already and this difference is a major cause of merge pain). --- src/gallium/drivers/llvmp

Re: [Mesa-dev] [PATCH 2/2] R600: Add a pattern for fma (fused multiply add)

2013-02-08 Thread Tom Stellard
On Fri, Feb 08, 2013 at 12:12:26PM +0100, Michel Dänzer wrote: > On Don, 2013-02-07 at 17:23 -0500, Tom Stellard wrote: > > From: Tom Stellard > > > > NOTE: This is a candidate for the Mesa stable branches > > --- > > lib/Target/R600/R600Instructions.td |7 +++ > > 1 files changed, 7 in

Re: [Mesa-dev] [PATCH 2/2] softpipe: fix using optimized filter function

2013-02-08 Thread Jose Fonseca
Looks good. Should PIPE_TEXTURE_RECT be allowed too? Jose - Original Message - > From: Roland Scheidegger > > This optimized filter (when using repeat wrap modes, > linear min/mag/mip filters, pot textures) only applies to 2d textures, > but nothing prevented it from being used for oth

Re: [Mesa-dev] [PATCH] glsl: Ensure glsl_type constructors initialize gl_type.

2013-02-08 Thread Brian Paul
On 02/08/2013 12:02 AM, Vinson Lee wrote: Fixes uninitialized scalar field defects reported by Coverity. Signed-off-by: Vinson Lee --- src/glsl/glsl_types.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_types.cpp index 4a2c879..3b066d0 100644

Re: [Mesa-dev] [PATCH] intel: Ensure variable intel is used in i915 builds.

2013-02-08 Thread Brian Paul
On 02/07/2013 11:58 PM, Vinson Lee wrote: Fixes unused pointer value defect reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/intel/intel_tex_copy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/intel/intel_tex_copy.c b/src/me

Re: [Mesa-dev] [PATCH 2/2] st/mesa: accelerate glGetTexImage for all formats using a blit

2013-02-08 Thread Marek Olšák
On Fri, Feb 8, 2013 at 1:57 AM, Brian Paul wrote: > On 02/07/2013 01:13 PM, Marek Olšák wrote: >> >> This commit allows using glGetTexImage during rendering and still >> maintain interactive framerates. >> >> This improves performance of WarCraft 3 under Wine. The framerate is >> improved >> from

Re: [Mesa-dev] [PATCH 1/3] R600: fix PHI value adding in the structurizer

2013-02-08 Thread Christian König
Am 07.02.2013 04:00, schrieb Tom Stellard: Hi Christian, I'm still unable to get the glsl1-while-loop with continue test to pass on R600 with the new structurizer. For this test, the structurizer is producing strange code and I'm not sure if it is correct. I have attached the full before and a

Re: [Mesa-dev] [PATCH 1/2] gallium: add red-alpha texture formats and a couple of util functions

2013-02-08 Thread Marek Olšák
On Fri, Feb 8, 2013 at 1:56 AM, Brian Paul wrote: > On 02/07/2013 01:13 PM, Marek Olšák wrote: >> >> This is for glGetTexImage and it will be used for samplers only (which >> some >> drivers already implement by reading util_format_description). >> --- >> src/gallium/auxiliary/util/u_format.csv

Re: [Mesa-dev] [PATCH 2/2] R600: Add a pattern for fma (fused multiply add)

2013-02-08 Thread Michel Dänzer
On Don, 2013-02-07 at 17:23 -0500, Tom Stellard wrote: > From: Tom Stellard > > NOTE: This is a candidate for the Mesa stable branches > --- > lib/Target/R600/R600Instructions.td |7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/lib/Target/R600/R600Instruction

Re: [Mesa-dev] [PATCH] R600: Use MULADD_IEEE instruction for mad pattern

2013-02-08 Thread Michel Dänzer
On Don, 2013-02-07 at 20:17 +0100, Vincent Lejeune wrote: > > diff --git a/lib/Target/R600/SIInstructions.td > b/lib/Target/R600/SIInstructions.td > index 85bb73a..65788f8 100644 > --- a/lib/Target/R600/SIInstructions.td > +++ b/lib/Target/R600/SIInstructions.td > @@ -1360,7 +1360,7 @@ def : Pat

Re: [Mesa-dev] [PATCH] radeon: Remove dead STANDALONE_MMIO defines

2013-02-08 Thread Michel Dänzer
On Don, 2013-02-07 at 17:25 -0800, Matt Turner wrote: > These were, at some point in the past, used to request that Xorg's > compiler.h export a static inline xf86ReadMmio32 instead of a function > pointer. compiler.h only has this option for DEC Alpha. > > But Xorg's compiler.h isn't being inclu

Re: [Mesa-dev] [PATCH] configure.ac: Do not check for rt on Mac OS X.

2013-02-08 Thread Michel Dänzer
On Fre, 2013-02-08 at 08:11 +0100, Vinson Lee wrote: > There is no rt library on Mac OS X. > > Signed-off-by: Vinson Lee > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=58872 > --- > configure.ac | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git

[Mesa-dev] [PATCH V3 19/19] i965: enable ARB_texture_multisample on Gen6+

2013-02-08 Thread Chris Forbes
V2: Works on Ivy Bridge now too, so this can be 6+. Signed-off-by: Chris Forbes Reviewed-by: Paul Berry --- src/mesa/drivers/dri/intel/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/intel/intel_extensions.c b/src/mesa/drivers/dri/intel/intel_extensi

[Mesa-dev] [PATCH V3 18/19] i965/fs: add support for ir_txf_ms on Gen6+

2013-02-08 Thread Chris Forbes
On Gen6, lower this to `ld` with lod=0 and an extra sample_index parameter. On Gen7, use `ld2dms`. We don't support CMS yet for multisample textures, so we just hardcode MCS=0. This is ignored for IMS and UMS surfaces. Note: If we do end up emitting specialized shaders based on the MSAA layout, w

[Mesa-dev] [PATCH V3 17/19] i965/vs: add support for ir_txf_ms on Gen6+

2013-02-08 Thread Chris Forbes
On Gen6, lower this to `ld` with lod=0 and an extra sample_index parameter. On Gen7, use `ld2dms`. This takes an additional MCS parameter to support compressed multisample surfaces, but we're not enabling them for multisample textures for now, so it's always ignored and can be safely omitted. V2:

[Mesa-dev] [PATCH V3 16/19] i965: add a new virtual opcode: SHADER_OPCODE_TXF_MS

2013-02-08 Thread Chris Forbes
This is very similar to the TXF opcode, but lowers to `ld2dms` rather than `ld` on Gen7. Signed-off-by: Chris Forbes Reviewed-by: Paul Berry --- src/mesa/drivers/dri/i965/brw_defines.h | 1 + src/mesa/drivers/dri/i965/brw_fs.cpp| 1 + src/mesa/drivers/dri/i965/brw_fs_emit.cpp | 7

[Mesa-dev] [PATCH V3 15/19] i965: take the target into account for Gen7 MSAA modes

2013-02-08 Thread Chris Forbes
Gen7 has an erratum affecting the ld_mcs message, making it unsafe to use when the surface doesn't have an associated MCS. >From the Ivy Bridge PRM, Vol4 Part1 p77 ("MCS Enable"): "If this field is disabled and the sampling engine message is issued on this surface, the MCS surface may be

[Mesa-dev] [PATCH V3 14/19] i965: Support multisampling in surface_state for textures

2013-02-08 Thread Chris Forbes
The surface_state setup for renderbuffers already worked; only the texturing side needed work. BLORP does something similar, but does its own surface_state setup. On Gen6, we just need to set the correct sample count. On Gen7: - set the correct sample count - set the correct layout mode

[Mesa-dev] [PATCH V3 13/19] i965: add support for multisample textures

2013-02-08 Thread Chris Forbes
V2: - Fix for state moving from texobj to image - Rebased onto Paul's logical/physical cleanup - Fixed missing quantization of sample count - Fold in IMS renderbuffer wrapper fixes from later in the series - Use correct physical slice offset for UMS/CMS surfaces on Gen7 Signed-off-

[Mesa-dev] [PATCH V3 12/19] mesa: implement TexImage*Multisample

2013-02-08 Thread Chris Forbes
V2: - fix formatting issues - generate GL_OUT_OF_MEMORY if teximage cannot be allocated - fix for state moving from texobj to image V3: - remove ridiculous stencil hack - alter format check to not allow a base format of STENCIL_INDEX - allow width/height/depth to be zero, to deallo

[Mesa-dev] [PATCH V3 11/19] mesa: support multisample textures in framebuffer completeness check

2013-02-08 Thread Chris Forbes
- sample count must be the same on all attachments - fixedsamplepositions must be the same on all attachments (renderbuffers have fixedsamplepositions=true implicitly; only multisample textures can choose to have it false) V2: - fix wrapping to 80 columns, debug message, fix for state moving

[Mesa-dev] [PATCH V3 10/19] i965: expose sample positions

2013-02-08 Thread Chris Forbes
Moves the definition of the sample positions out of gen6_emit_3dstate_multisample, and unpacks them in gen6_get_sample_position. V2: Be consistent about `sample position` rather than `location`. Signed-off-by: Chris Forbes Reviewed-by: Paul Berry --- src/mesa/drivers/dri/i965/brw_context.c

[Mesa-dev] [PATCH V3 09/19] i965: add support for sample mask on Gen6+

2013-02-08 Thread Chris Forbes
Signed-off-by: Chris Forbes Reviewed-by: Eric Anholt Reviewed-by: Paul Berry --- src/mesa/drivers/dri/i965/brw_context.h| 2 +- src/mesa/drivers/dri/i965/gen6_blorp.cpp | 2 +- src/mesa/drivers/dri/i965/gen6_multisample_state.c | 19 +-- src/mesa/drivers/

[Mesa-dev] [PATCH V3 08/19] mesa: implement sample mask

2013-02-08 Thread Chris Forbes
V2: - fix multiline comment style - stop using ASSERT_OUTSIDE_BEGIN_END_AND_FLUSH since that doesn't exist anymore. V3: - check for the extension being enabled - tidier flagging of _NEW_MULTISAMPLE - fix weird indentation in get.c Signed-off-by: Chris Forbes --- src/mesa/main/

[Mesa-dev] [PATCH V3 07/19] mesa: implement GetMultisamplefv

2013-02-08 Thread Chris Forbes
Actual sample locations deferred to a driverfunc since only the driver really knows where they will be. V2: - pass the draw buffer to the driverfunc; don't fallback to pixel center if driverfunc is missing. - rename GetSampleLocation to GetSamplePosition - invert y sample position fo

[Mesa-dev] [PATCH V3 06/19] i965: expose new max sample counts

2013-02-08 Thread Chris Forbes
V2: For now, only expose a depth sample count of 1, since there are unresolved interactions with W-tiling for stencil textures and possibly also HiZ for depth textures. Signed-off-by: Chris Forbes Reviewed-by: Paul Berry --- src/mesa/drivers/dri/i965/brw_context.c | 12 ++-- 1 file chan

[Mesa-dev] [PATCH V3 05/19] mesa: add new max sample count state

2013-02-08 Thread Chris Forbes
- GL_MAX_COLOR_TEXTURE_SAMPLES - GL_MAX_DEPTH_TEXTURE_SAMPLES - GL_MAX_INTEGER_SAMPLES V2: initialize limits to 1 in _mesa_init_constants as suggested by Brian and Paul Signed-off-by: Chris Forbes Reviewed-by: Paul Berry --- src/mesa/main/context.c | 5 + src/mesa/main/get_hash_pa

[Mesa-dev] [PATCH V3 04/19] glsl: add support for ARB_texture_multisample

2013-02-08 Thread Chris Forbes
V2: - emit `sample` parameter properly for multisample texelFetch() - fix spurious whitespace change - introduce a new opcode ir_txf_ms rather than overloading the existing ir_txf further. This makes doing the right thing in the driver somewhat simpler. V3: - fix weird whitespa

[Mesa-dev] [PATCH V3 03/19] tests: add ARB_texture_multisample enums to table

2013-02-08 Thread Chris Forbes
Signed-off-by: Chris Forbes Reviewed-by: Eric Anholt Reviewed-by: Paul Berry --- src/mesa/main/tests/enum_strings.cpp | 21 + 1 file changed, 21 insertions(+) diff --git a/src/mesa/main/tests/enum_strings.cpp b/src/mesa/main/tests/enum_strings.cpp index 5d70007..1dae60f 10

[Mesa-dev] [PATCH V3 02/19] mesa: add texobj support for ARB_texture_multisample

2013-02-08 Thread Chris Forbes
Adds the new texture targets, and per-image state for GL_TEXTURE_SAMPLES and GL_TEXTURE_FIXED_SAMPLE_LOCATIONS. V2: - Allow multisample texture targets in glInvalidateTexSubImage too. This was already partly there, but I missed it the first time around since the interaction is defined

[Mesa-dev] [PATCH V3 01/19] glapi: add ARB_texture_multisample

2013-02-08 Thread Chris Forbes
Adds new enums, dispatch machinery, and stubs for the 4 new entrypoints. V2: - Drop placeholder - Align enum values - Remove explicit exec=mesa; it *is* the dispatch flavor we want, but it's also the default. I misunderstood how this worked before; after actually reading the ge

[Mesa-dev] [PATCH V3 00/19] ARB_texture_multisample support

2013-02-08 Thread Chris Forbes
This series adds the core mesa bits for ARB_texture_multisample, and support in the i965 driver on Gen6 and Gen7. I've tidied up all the things that were commented on in V2. Big changes: - First three patches were squashed together. The result adds the glapi bits, the dispatch_sanity twe

[Mesa-dev] [Bug 59187] [Steam] Black screen but audio song On TF2 (Intel HM 55/ Ironlake Mobile)

2013-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59187 seves985 changed: What|Removed |Added CC||seves...@gmail.com -- You are receiving this

Re: [Mesa-dev] [PATCH v2] configure.ac: Disable GLX if OpenGL is not enabled

2013-02-08 Thread Michel Dänzer
On Don, 2013-02-07 at 21:34 -0800, Ian Romanick wrote: > On 01/31/2013 08:50 AM, Michel Dänzer wrote: > > From: Michel Dänzer > > > > GLX uses mapi/glapi/libglapi.la, which is only built for OpenGL. > > > > NOTE: This is a candidate for the stable branches. > > > > Bugzilla: https://bugs.freedesk

Re: [Mesa-dev] [PATCH] mesa: Don't check (offset + size <= bufObj->Size) in BindBufferRange.

2013-02-08 Thread Ian Romanick
On 02/07/2013 07:01 PM, Ian Romanick wrote: On 02/07/2013 05:54 PM, Paul Berry wrote: In the documentation for BindBufferRange, OpenGL specs from 3.0 through 4.1 contain this language: "The error INVALID_VALUE is generated if size is less than or equal to zero or if offset + size is g

Re: [Mesa-dev] [PATCH] mesa: Don't check (offset + size <= bufObj->Size) in BindBufferRange.

2013-02-08 Thread Ian Romanick
On 02/07/2013 05:54 PM, Paul Berry wrote: In the documentation for BindBufferRange, OpenGL specs from 3.0 through 4.1 contain this language: "The error INVALID_VALUE is generated if size is less than or equal to zero or if offset + size is greater than the value of BUFFER_SIZE."