Re: [Mesa-dev] [PATCH V2] mesa: provide default implementation of QuerySamplesForFormat

2013-03-28 Thread Kenneth Graunke
On 03/28/2013 08:28 PM, Chris Forbes wrote: Previously at least i915 failed to provide an implementation, but exposed ARB_internalformat_query anyway, leading to crashes when QueryInternalformativ was called. Default implementation just returns 1 for everything, so is suitable for any driver whi

[Mesa-dev] [PATCH 2/2] draw/so: Fix bogus assert

2013-03-28 Thread Zack Rusin
We do support so with multiple primitives. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_so_emit_tmp.h |1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/draw/draw_so_emit_tmp.h b/src/gallium/auxiliary/draw/draw_so_emit_tmp.h index ec31c3f..4611cd0 10064

[Mesa-dev] [PATCH 1/2] draw/gs: Fix memory corruption with multiple primitives

2013-03-28 Thread Zack Rusin
We were flushing with incorrect number of primitives. TGSI exec can only work with a single primitive at a time. Plus the fetching with multiple primitives on llvm paths wasn't copying the last element. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_gs.c | 25 +++

[Mesa-dev] [PATCH V2] mesa: provide default implementation of QuerySamplesForFormat

2013-03-28 Thread Chris Forbes
Previously at least i915 failed to provide an implementation, but exposed ARB_internalformat_query anyway, leading to crashes when QueryInternalformativ was called. Default implementation just returns 1 for everything, so is suitable for any driver which does not support multisampling. V2: - Move

[Mesa-dev] [Bug 62883] draw/draw_gs.c:684:4: error: implicit declaration of function 'draw_get_option_use_llvm' [-Werror=implicit-function-declaration]

2013-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62883 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] mesa: remove platform checks around __builtin_ffs, __builtin_ffsll

2013-03-28 Thread Brian Paul
Use the __builtin_ffs, __builtin_ffsll functions whenever we have GCC, not just for specific platforms. Fixes Solaris build. Note: This is a candidate for the stable branches. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=62868 Signed-off-by: Brian Paul --- src/mesa/main/imports.h |

[Mesa-dev] [Bug 62883] draw/draw_gs.c:684:4: error: implicit declaration of function 'draw_get_option_use_llvm' [-Werror=implicit-function-declaration]

2013-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62883 --- Comment #2 from Vinson Lee --- Attachment 77174 fixes the build error. Tested-by: Vinson Lee -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list m

[Mesa-dev] [Bug 62883] draw/draw_gs.c:684:4: error: implicit declaration of function 'draw_get_option_use_llvm' [-Werror=implicit-function-declaration]

2013-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62883 --- Comment #1 from Brian Paul --- Created attachment 77174 --> https://bugs.freedesktop.org/attachment.cgi?id=77174&action=edit patch to test Can you try this patch? -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 62883] New: draw/draw_gs.c:684:4: error: implicit declaration of function 'draw_get_option_use_llvm' [-Werror=implicit-function-declaration]

2013-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62883 Priority: medium Bug ID: 62883 Keywords: regression CC: za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: draw/draw_gs.c:684:4: error: implicit declaration of

[Mesa-dev] [PATCH 3/3] i965: Enable ARB_texture_query_lod.

2013-03-28 Thread Matt Turner
v2: Support Ironlake as well. Reviewed-by: Kenneth Graunke --- docs/GL3.txt |2 +- src/mesa/drivers/dri/intel/intel_extensions.c |4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 640dec2..2c15a9b 1006

Re: [Mesa-dev] [PATCH v2 2/3] i965/fs: Generate LOD sampler message from ir_lod.

2013-03-28 Thread Matt Turner
On Thu, Mar 28, 2013 at 3:02 PM, Matt Turner wrote: > v2: Support Ironlake as well. > Reviewed-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_defines.h|2 ++ > src/mesa/drivers/dri/i965/brw_fs.cpp |4 +++- > src/mesa/drivers/dri/i965/brw_fs_emit.cpp |

[Mesa-dev] [PATCH v2 2/3] i965/fs: Generate LOD sampler message from ir_lod.

2013-03-28 Thread Matt Turner
v2: Support Ironlake as well. Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_defines.h|2 ++ src/mesa/drivers/dri/i965/brw_fs.cpp |4 +++- src/mesa/drivers/dri/i965/brw_fs_emit.cpp |4 src/mesa/drivers/dri/i965/brw_fs_visitor.cpp |6 ++

[Mesa-dev] [PATCH 5/5] st/mesa: don't expose ARB_color_buffer_float without driver support in GL core

2013-03-28 Thread Marek Olšák
--- src/mesa/state_tracker/st_extensions.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 11db9d3..2d8b9ef 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_tracker/st_

[Mesa-dev] [PATCH 4/5] mesa: allow drivers not to expose ARB_color_buffer_float in GL core profile

2013-03-28 Thread Marek Olšák
--- src/mesa/drivers/common/meta.c | 18 -- src/mesa/main/attrib.c |9 +++-- src/mesa/main/blend.c| 19 --- src/mesa/main/get.c |9 - src/mesa/main/get_hash_params.py |2 +- src/mesa/main/light.c

[Mesa-dev] [PATCH 3/5] mesa: move updating clamp control derived state out of mesa_update_state_locked

2013-03-28 Thread Marek Olšák
It has 2 dependencies: glClampColor and the framebuffer, we might just as well do the update where those two are changed. --- src/mesa/main/blend.c | 28 src/mesa/main/blend.h |6 ++ src/mesa/main/framebuffer.c |4 src/mesa/main/state.c

[Mesa-dev] [PATCH 2/5] mesa: don't set _ClampFragmentColor to TRUE if it has no effect

2013-03-28 Thread Marek Olšák
This should reduce shader recompilations with drivers that emulate fragment color clamping, because we want the clamping to be enabled only if there is a signed normalized or floating-point colorbuffer. --- src/mesa/main/blend.c |2 +- src/mesa/main/fbobject.c

[Mesa-dev] [PATCH 1/5] mesa: refactor clamping controls, get rid of _ClampReadColor

2013-03-28 Thread Marek Olšák
--- src/mesa/main/blend.c | 28 +++- src/mesa/main/blend.h |8 src/mesa/main/fbobject.c| 10 ++ src/mesa/main/framebuffer.c |1 + src/mesa/main/mtypes.h |4 +++- src/mesa/main/readpix.c |5 +++-- src/mesa/main/st

[Mesa-dev] [PATCH 0/5] ARB_color_buffer_float vs GL Core + refactoring

2013-03-28 Thread Marek Olšák
This patch series adds the ability to disable ARB_color_buffer_float in core GL contexts, because let's be honest, the clamping controls don't make much sense with core GL and must be emulated by most drivers anyway. There is also some cleanup in _mesa_update_state_locked and how clamping contr

[Mesa-dev] [RFC PATCH] i965/fs: Don't immediately schedule instructions that were just made available.

2013-03-28 Thread Matt Turner
This is not how the final patch would look. Rather, we'd remove the flatten the if (post_reg_alloc) block and remove the else clause. This patch just aims to prove that we're choosing instructions in a bad order. On Sandybridge GLB2.5 C24Z16_DXT1 1600x900 non-composited: x before + after +---

Re: [Mesa-dev] [PATCH] i965: Reduce code duplication in handling of depth, stencil, and HiZ.

2013-03-28 Thread Paul Berry
On 27 March 2013 20:43, Chad Versace wrote: > I like this patch. The final result feels cleaner than the present code. > Comments below. > > > On Tue, Mar 26, 2013 at 09:54:18PM -0700, Paul Berry wrote: > > This patch consolidates duplicate code in the brw_depthbuffer and > > gen7_depthbuffer sta

Re: [Mesa-dev] [PATCH 1/6] i965: Reword comment about the shared mathbox.

2013-03-28 Thread Eric Anholt
This series is: Reviewed-by: Eric Anholt pgpsUI6zUKGpw.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Fix INTEL_DEBUG=shader_time for fragment shaders with discards.

2013-03-28 Thread Eric Anholt
Kenneth Graunke writes: > "discard" instructions generate HALT instructions which jump to a final > HALT near the end of the shader. Previously, fs_generator created this > final jump target when it saw the first FS_OPCODE_FB_WRITE, causing it > to jump right before the FB write epilogue. This

[Mesa-dev] [PATCH 6/6] i965/fs: Use measured Gen7 instruction timings on Gen6.

2013-03-28 Thread Matt Turner
>From GLBenchmark 2.5: x before + after +--+ | x x + | | xx ++ x + | | xx ++ +

[Mesa-dev] [PATCH 5/6] i965/fs: Increase and document MAD latency on Gen7.

2013-03-28 Thread Matt Turner
58% of mad(8) generated in shader-db are reading registers from the same bank. --- .../dri/i965/brw_fs_schedule_instructions.cpp | 22 --- 1 files changed, 18 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_schedule_instructions.cpp b/src/mesa/d

[Mesa-dev] [PATCH 4/6] i965/fs: Add LRP instruction latency.

2013-03-28 Thread Matt Turner
Set its latency to what happens to be the default floating-point instruction latency. One day we may want to handle latency based on register bank information. --- .../dri/i965/brw_fs_schedule_instructions.cpp | 26 1 files changed, 26 insertions(+), 0 deletions(-) dif

[Mesa-dev] [PATCH 3/6] i965/fs: Add Haswell cycle timings

2013-03-28 Thread Matt Turner
--- .../dri/i965/brw_fs_schedule_instructions.cpp | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_schedule_instructions.cpp b/src/mesa/drivers/dri/i965/brw_fs_schedule_instructions.cpp index 72b3729..d2420cd 100644 --

[Mesa-dev] [PATCH 2/6] i965: Note that write-after-write dependencies are blocking.

2013-03-28 Thread Matt Turner
--- .../dri/i965/brw_fs_schedule_instructions.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_schedule_instructions.cpp b/src/mesa/drivers/dri/i965/brw_fs_schedule_instructions.cpp index aa9c0a6..72b3729 100644 --- a/src/mesa/dri

[Mesa-dev] [PATCH 1/6] i965: Reword comment about the shared mathbox.

2013-03-28 Thread Matt Turner
--- .../dri/i965/brw_fs_schedule_instructions.cpp |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_schedule_instructions.cpp b/src/mesa/drivers/dri/i965/brw_fs_schedule_instructions.cpp index c125928..aa9c0a6 100644 --- a/src/me

Re: [Mesa-dev] [PATCH] R600: Emit CF_ALU and use true kcache register.

2013-03-28 Thread Vadim Girlin
On 03/28/2013 09:47 PM, Vincent Lejeune wrote: > [snip] diff --git a/lib/Target/R600/R600RegisterInfo.td b/lib/Target/R600/R600RegisterInfo.td index ce5994c..3ee6623 100644 --- a/lib/Target/R600/R600RegisterInfo.td +++ b/lib/Target/R600/R600RegisterInfo.td @@ -43,6 +43,37 @@ foreach Index = 0-

Re: [Mesa-dev] [PATCH] r600g: fix range handling for tgsi input/output declarations

2013-03-28 Thread Vadim Girlin
On 03/28/2013 01:01 PM, � wrote: Am 27.03.2013 20:37, schrieb Vadim Girlin: Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_shader.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/dri

Re: [Mesa-dev] [PATCH] mesa: handle STATE_CURRENT_ATTRIB_MAYBE_VP_CLAMPED for parameter printing

2013-03-28 Thread Brian Paul
On Thu, Mar 28, 2013 at 11:18 AM, Marek Olšák wrote: > --- > src/mesa/program/prog_statevars.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/program/prog_statevars.c > b/src/mesa/program/prog_statevars.c > index 5a35079..ccc590d 100644 > --- a/src/mesa/program/prog_stat

Re: [Mesa-dev] [PATCH 0/4] Begin some ir_dereference_array-of-a-vector rework

2013-03-28 Thread Jordan Justen
Reviewed-by: Jordan Justen On Wed, Mar 27, 2013 at 9:30 AM, Ian Romanick wrote: > This is the first of three patch series that I'm going to send related > to reworking ir_dereference_array of vectors. The final series end with > ir_dereference_array of vectors being completely removed from the

[Mesa-dev] [PATCH] R600: Emit CF_ALU and use true kcache register.

2013-03-28 Thread Vincent Lejeune
--- lib/Target/R600/AMDGPU.h | 1 + lib/Target/R600/AMDGPUTargetMachine.cpp| 1 + lib/Target/R600/MCTargetDesc/R600MCCodeEmitter.cpp | 10 +- lib/Target/R600/R600EmitClauseMarkers.cpp | 250 + lib/Target/R600/R600Instructions.

Re: [Mesa-dev] [PATCH 3/3] update EXT_transform_feedback error detection

2013-03-28 Thread Brian Paul
These piglit patches should be posted to the piglit mailing list, not mesa-dev. Thanks. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/3] update EXT_transform_feedback error detection

2013-03-28 Thread gregory hainaut
program pipeline add new INVALID_OPERATION (spec chapter 13.2.2) Note: FGLRX don't report any of the expected errors... --- tests/all.tests|4 +- tests/spec/ext_transform_feedback/api-errors.c | 84 +++- 2 files changed, 85 insertions(+),

[Mesa-dev] [PATCH 2/3] add 3 news tests for arb_separate_shader_objects

2013-03-28 Thread gregory hainaut
* new test IsProgramPipeline: check the Pipeline object state creation. GenPipeline only reserved name. I also take the opportunity to test negative value on glGenProgramPipelines and glDeleteProgramPipelines. Note: FGLRX don't follow the spec besides crash on glGenProgramPipelines because of -1.

[Mesa-dev] [PATCH 1/3] piglit util: new functions piglit_program_pipeline_check_status/quiet

2013-03-28 Thread gregory hainaut
Equivalent to piglit_link_check_status/quiet but with program object pipeline --- tests/util/piglit-shader.c | 50 tests/util/piglit-shader.h |2 ++ 2 files changed, 52 insertions(+) diff --git a/tests/util/piglit-shader.c b/tests/util/piglit-sha

Re: [Mesa-dev] [Piglit] [RFC] ARB_separate_shader_objects test v2

2013-03-28 Thread gregory hainaut
On Tue, 26 Mar 2013 16:58:17 -0700 Jordan Justen wrote: > Tested with NVidia binary: > fail :: spec/ARB_separate_shader_objects/sso-GetProgramPipelineiv > fail :: spec/ARB_separate_shader_objects/sso-mix_pipeline_useprogram > crash :: spec/ARB_separate_shader_objects/sso-IsProgramPipeline > (resu

[Mesa-dev] [PATCH] mesa: handle STATE_CURRENT_ATTRIB_MAYBE_VP_CLAMPED for parameter printing

2013-03-28 Thread Marek Olšák
--- src/mesa/program/prog_statevars.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/program/prog_statevars.c b/src/mesa/program/prog_statevars.c index 5a35079..ccc590d 100644 --- a/src/mesa/program/prog_statevars.c +++ b/src/mesa/program/prog_statevars.c @@ -871,6 +871,9 @@ a

[Mesa-dev] Geometry shader update

2013-03-28 Thread Paul Berry
It's been about two months since I talked on the mailing list about my progress in implementing geometry shaders ( http://lists.freedesktop.org/archives/mesa-dev/2013-January/033725.html), so it seems like a good time to give an update. Also I have some happy progress to report :) In mid-February

[Mesa-dev] [Bug 47607] [advocacy] Make Anomaly Warzone Earth work with Mesa

2013-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47607 --- Comment #7 from Alexander Monakov --- Created attachment 77166 --> https://bugs.freedesktop.org/attachment.cgi?id=77166&action=edit LD_PRELOAD hack to renumber uniform locations in a dense manner To follow up to my previous comment, attach

[Mesa-dev] [Bug 62868] solaris build broken with missing ffsll

2013-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62868 --- Comment #1 from Alan Coopersmith --- For what it's worth Solaris 11 and later have ffsll(), but not older releases. The patch to use the gcc builtins when possible makes sense to me. -- You are receiving this mail because: You are the assig

[Mesa-dev] [Bug 62868] New: solaris build broken with missing ffsll

2013-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62868 Priority: medium Bug ID: 62868 Assignee: mesa-dev@lists.freedesktop.org Summary: solaris build broken with missing ffsll Severity: normal Classification: Unclassified OS: Sol

[Mesa-dev] [Bug 44618] Cross-compilation broken by glsl builtin_compiler

2013-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44618 --- Comment #20 from Pierre Ossman --- Created attachment 77156 --> https://bugs.freedesktop.org/attachment.cgi?id=77156&action=edit MesaLib-9.1.1-cross.patch Suggested fix. -- You are receiving this mail because: You are the assignee for th

[Mesa-dev] [Bug 44618] Cross-compilation broken by glsl builtin_compiler

2013-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44618 --- Comment #19 from Pierre Ossman --- This seems to be coming from deep inside libtool. I guess a separate libtool needs to be generated for the host CC/CXX. Unfortunately I don't see any easy way of doing that. However, there is a simpler appr

[Mesa-dev] [Bug 44618] Cross-compilation broken by glsl builtin_compiler

2013-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44618 Pierre Ossman changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

Re: [Mesa-dev] [PATCH] gallivm: cleanup the gs interface

2013-03-28 Thread Brian Paul
On 03/27/2013 05:31 AM, Zack Rusin wrote: Instead of void pointers use a base interface. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_llvm.c | 77 --- src/gallium/auxiliary/gallivm/lp_bld_tgsi.h | 25 src/gallium/auxiliary/galliv

Re: [Mesa-dev] [PATCH] r600g: fix range handling for tgsi input/output declarations

2013-03-28 Thread Christian König
Am 27.03.2013 20:37, schrieb Vadim Girlin: Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_shader.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 29f

[Mesa-dev] [PATCH] i965: Fix INTEL_DEBUG=shader_time for fragment shaders with discards.

2013-03-28 Thread Kenneth Graunke
"discard" instructions generate HALT instructions which jump to a final HALT near the end of the shader. Previously, fs_generator created this final jump target when it saw the first FS_OPCODE_FB_WRITE, causing it to jump right before the FB write epilogue. This is normally good. However, INTEL_

Re: [Mesa-dev] [PATCH] intel: provide a default QuerySamplesForFormat func

2013-03-28 Thread Kenneth Graunke
On 03/28/2013 12:26 AM, Chris Forbes wrote: We claim to support ARB_internalformat_query on everything, but only i965+ bothered to provide the hook -- so QueryInternalformativ() would just explode (fail the assert in debug; segfault otherwise) on earlier platforms. Signed-off-by: Chris Forbes -

Re: [Mesa-dev] i965: Improved shader_time accuracy, using send-from-GRF

2013-03-28 Thread Kenneth Graunke
On 03/19/2013 05:05 PM, Eric Anholt wrote: I've been experimenting with the simd16 replicated data message (non-gen7-specific fast clears), and was bothered that shader_time wasn't noting any time spent in our clear FS currently, so I wasn't totally sure which apps I should be looking at. Many a

[Mesa-dev] [PATCH] intel: provide a default QuerySamplesForFormat func

2013-03-28 Thread Chris Forbes
We claim to support ARB_internalformat_query on everything, but only i965+ bothered to provide the hook -- so QueryInternalformativ() would just explode (fail the assert in debug; segfault otherwise) on earlier platforms. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/intel/intel_context.c

Re: [Mesa-dev] [PATCH 5/8] i965/vs: Prepare split_virtual_grfs() for the presence of SENDs from GRFs.

2013-03-28 Thread Kenneth Graunke
On 03/19/2013 05:06 PM, Eric Anholt wrote: --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 49 +--- src/mesa/drivers/dri/i965/brw_vec4.h |1 + 2 files changed, 39 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/d

Re: [Mesa-dev] Haiku using the Wayland state_tracker?

2013-03-28 Thread Pekka Paalanen
On Wed, 27 Mar 2013 15:45:23 -0500 Alexander von Gluck IV wrote: > On 03/27/2013 2:37 am, Pekka Paalanen wrote: > > On Tue, 26 Mar 2013 16:47:15 -0500 > > Alexander von Gluck IV wrote: > > > >> I've been hitting several brick walls working on the Haiku GL stuff. > >> (mostly due to things being

[Mesa-dev] [PATCH] i965: Tidy shader time printing code by using printf's field widths.

2013-03-28 Thread Kenneth Graunke
We can use %-6s%-6s rather than manually counting characters, resulting in much more readable code. This necessitates a small secondary change: using "total fs16" and "" now causes the "" string to be padded out to 6 characters, resulting in too much whitespace. Splitting it into "total" and "fs1