[Mesa-dev] [PATCH V2 0/8] ARB_texture_storage_multisample support

2013-03-29 Thread Chris Forbes
This series adds support for the ARB_texture_storage_multisample extension. Only minor changes from V1: * Added missing error cases in TexStorage*Multisample. Thanks Eric for pointing out that this was a bit lacking. * Dropped spurious special case for TEXTURE_MAX_LEVELS. This wasn't in the

[Mesa-dev] [PATCH V2 1/8] mesa: extract _mesa_is_legal_tex_storage_format helper

2013-03-29 Thread Chris Forbes
This is about to be used in teximagemultisample() when immutable=true. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/main/texstorage.c | 37 - src/mesa/main/texstorage.h | 3 +++ 2 files changed, 23 insertions(+), 17 deletions(-) diff --git

[Mesa-dev] [PATCH V2 2/8] mesa: add support for immutable textures to teximagemultisample()

2013-03-29 Thread Chris Forbes
The new entrypoints will come later, but this adds the actual logic for supporting immutable multisample textures: - The immutability flag is set as desired. - Attempting to modify an immutable multisample texture produces INVALID_OPERATION. Note: The extension spec does not mention adding

[Mesa-dev] [PATCH V2 3/8] glapi: add definition of ARB_texture_storage_multisample

2013-03-29 Thread Chris Forbes
Adds XML for the extension, dispatch_sanity enabling, and the two new entrypoints. These are both implemented by calling the shared teximagemultisample() with immutable=GL_TRUE. Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Eric Anholt e...@anholt.net ---

[Mesa-dev] [PATCH V2 4/8] mesa: add enable bit for ARB_texture_storage_multisample

2013-03-29 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Eric Anholt e...@anholt.net --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index e90a296..004fc8e 100644 ---

[Mesa-dev] [PATCH V2 5/8] mesa: improve reported function name in Tex*Multisample

2013-03-29 Thread Chris Forbes
Now that there are 4 variants, just pass the function name into teximagemultisample rather than reconstructing it. Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Eric Anholt e...@anholt.net --- src/mesa/main/teximage.c | 30 ++ 1 file changed, 14

[Mesa-dev] [PATCH V2 6/8] mesa: allow multisample texture targets in [Get]TexParameter*

2013-03-29 Thread Chris Forbes
ARB_texture_storage_multisample allows texture parameters to be queried for TEXTURE_2D_MULTISAMPLE and TEXTURE_2D_MULTISAMPLE_ARRAY targets. Some parameters may also be set, with the following exceptions: - TEXTURE_BASE_LEVEL may not be set to a nonzero value; generates INVALID_OPERATION -

[Mesa-dev] [PATCH V2 7/8] i965: enable ARB_texture_storage_multisample on Gen6+

2013-03-29 Thread Chris Forbes
This can be enabled everywhere that ARB_texture_multisample is supported -- ARB_texture_storage is supported on everything. Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Eric Anholt e...@anholt.net --- src/mesa/drivers/dri/intel/intel_extensions.c | 1 + 1 file changed, 1

[Mesa-dev] [PATCH V2 8/8] docs: mark ARB_texture_storage_multisample done

2013-03-29 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Eric Anholt e...@anholt.net --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 640dec2..898d921 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -151,7 +151,7 @@

Re: [Mesa-dev] mesa : ARB_texture_gather implementation - WIP[PATCH1/1] but need advice !

2013-03-29 Thread Chris Forbes
I've got this working now (in the simplest cases) on Ivybridge. If anyone is curious, the (messy) git trees are at http://github.com/chrisforbes/mesa.git arb_texture_gather http://github.com/chrisforbes/piglit.git texture_gather Nowhere near ready for review, but it's a start. Remaining things

Re: [Mesa-dev] [PATCH] r600g: fix range handling for tgsi input/output declarations

2013-03-29 Thread Christian König
Am 28.03.2013 20:34, schrieb Vadim Girlin: On 03/28/2013 01:01 PM, � wrote: Am 27.03.2013 20:37, schrieb Vadim Girlin: Signed-off-by: Vadim Girlin vadimgir...@gmail.com --- src/gallium/drivers/r600/r600_shader.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-)

Re: [Mesa-dev] [PATCH 2/2] draw/so: Fix bogus assert

2013-03-29 Thread Jose Fonseca
- Original Message - We do support so with multiple primitives. Signed-off-by: Zack Rusin za...@vmware.com --- src/gallium/auxiliary/draw/draw_so_emit_tmp.h |1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/draw/draw_so_emit_tmp.h

Re: [Mesa-dev] [PATCH] gallivm: cleanup the gs interface

2013-03-29 Thread Jose Fonseca
Thanks for the cleanup. Reviewed-by: Jose Fonseca jfons...@vmware.com Jose - Original Message - Instead of void pointers use a base interface. Signed-off-by: Zack Rusin za...@vmware.com --- src/gallium/auxiliary/draw/draw_llvm.c | 77 ---

Re: [Mesa-dev] [PATCH] docs: add a new page documenting known application issues

2013-03-29 Thread Jose Fonseca
Looks good to me Brian. Just a couple of comments. - Original Message - Let's try to update this when we find other broken applications... docs/ is growing a lot of stuff, with disparate target audiences. Maybe we could establish some sort of directory hierachary there:

Re: [Mesa-dev] [PATCH] r600g: fix range handling for tgsi input/output declarations

2013-03-29 Thread Christoph Bumiller
On 29.03.2013 10:56, Christian König wrote: Am 28.03.2013 20:34, schrieb Vadim Girlin: On 03/28/2013 01:01 PM, � wrote: Am 27.03.2013 20:37, schrieb Vadim Girlin: Signed-off-by: Vadim Girlin vadimgir...@gmail.com --- src/gallium/drivers/r600/r600_shader.c | 19 +++ 1 file

Re: [Mesa-dev] [PATCH 1/6] radeon/llvm: remove uneeded inclusion

2013-03-29 Thread Mike Lothian
Hi This include is also in src/gallium/state_trackers/clover/llvm/invocation.cpp diff -Naur a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp --- a/src/gallium/state_trackers/clover/llvm/invocation.cpp 2013-03-29 11:15:52.851581526

[Mesa-dev] [PATCH] gallium: add PIPE_CAP_QUERY_PIPELINE_STATISTICS

2013-03-29 Thread Christoph Bumiller
--- src/gallium/docs/source/screen.rst |2 ++ src/gallium/drivers/freedreno/freedreno_screen.c |1 + src/gallium/drivers/i915/i915_screen.c |1 + src/gallium/drivers/llvmpipe/lp_screen.c |2 ++ src/gallium/drivers/nv30/nv30_screen.c |1

Re: [Mesa-dev] [PATCH 1/6] radeon/llvm: remove uneeded inclusion

2013-03-29 Thread Mike Lothian
Sorry that patch doesn't fix the build diff -Naur a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp --- a/src/gallium/state_trackers/clover/llvm/invocation.cpp 2013-03-29 12:14:25.514504748 + +++

[Mesa-dev] [PATCH] gallium/hud: add support for PIPE_QUERY_PIPELINE_STATISTICS

2013-03-29 Thread Christoph Bumiller
Also, renamed pixels-rendered to samples-passed because the occlusion counter increments even if colour and depth writes are disabled, or (on some implementations) for killed that passed the depth test when early_fragment_tests has been set for the PS. --- src/gallium/auxiliary/hud/hud_context.c

[Mesa-dev] [PATCH] gallium/docs: fix definition of PIPE_QUERY_SO_STATISTICS

2013-03-29 Thread Christoph Bumiller
--- src/gallium/docs/source/context.rst |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/docs/source/context.rst b/src/gallium/docs/source/context.rst index 9e57930..2cc1848 100644 --- a/src/gallium/docs/source/context.rst +++

Re: [Mesa-dev] [PATCH] docs: add a new page documenting known application issues

2013-03-29 Thread Brian Paul
On 03/29/2013 04:50 AM, Jose Fonseca wrote: Looks good to me Brian. Just a couple of comments. - Original Message - Let's try to update this when we find other broken applications... docs/ is growing a lot of stuff, with disparate target audiences. Maybe we could establish some

Re: [Mesa-dev] [PATCH] gallium: add PIPE_CAP_QUERY_PIPELINE_STATISTICS

2013-03-29 Thread Marek Olšák
Reviewed-by: Marek Olšák mar...@gmail.com Marek On Fri, Mar 29, 2013 at 1:05 PM, Christoph Bumiller e0425...@student.tuwien.ac.at wrote: --- src/gallium/docs/source/screen.rst |2 ++ src/gallium/drivers/freedreno/freedreno_screen.c |1 +

Re: [Mesa-dev] [PATCH] gallium/docs: fix definition of PIPE_QUERY_SO_STATISTICS

2013-03-29 Thread Marek Olšák
Reviewed-by: Marek Olšák mar...@gmail.com Marek On Fri, Mar 29, 2013 at 2:33 PM, Christoph Bumiller e0425...@student.tuwien.ac.at wrote: --- src/gallium/docs/source/context.rst |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH V2 0/8] ARB_texture_storage_multisample support

2013-03-29 Thread Brian Paul
On 03/29/2013 02:30 AM, Chris Forbes wrote: This series adds support for the ARB_texture_storage_multisample extension. Only minor changes from V1: * Added missing error cases in TexStorage*Multisample. Thanks Eric for pointing out that this was a bit lacking. * Dropped spurious special

Re: [Mesa-dev] [PATCH 1/5] mesa: refactor clamping controls, get rid of _ClampReadColor

2013-03-29 Thread Brian Paul
On 03/28/2013 03:24 PM, Marek Olšák wrote: --- src/mesa/main/blend.c | 28 +++- src/mesa/main/blend.h |8 src/mesa/main/fbobject.c| 10 ++ src/mesa/main/framebuffer.c |1 + src/mesa/main/mtypes.h |4 +++-

Re: [Mesa-dev] [PATCH 3/5] mesa: move updating clamp control derived state out of mesa_update_state_locked

2013-03-29 Thread Brian Paul
On 03/28/2013 03:24 PM, Marek Olšák wrote: It has 2 dependencies: glClampColor and the framebuffer, we might just as well do the update where those two are changed. --- src/mesa/main/blend.c | 28 src/mesa/main/blend.h |6 ++

Re: [Mesa-dev] [PATCH 5/5] st/mesa: don't expose ARB_color_buffer_float without driver support in GL core

2013-03-29 Thread Brian Paul
On 03/28/2013 03:24 PM, Marek Olšák wrote: --- src/mesa/state_tracker/st_extensions.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 11db9d3..2d8b9ef 100644 ---

[Mesa-dev] [PATCH 1/2] gallivm: consolidate code for float-to-half and float-to-packed conversion.

2013-03-29 Thread sroland
From: Roland Scheidegger srol...@vmware.com This replaces the existing float-to-half implementation. There are definitely a couple of differences - the old implementation had unspecified(?) rounding behavior, and could at least in theory construct Inf values out of NaNs. NaNs and Infs should now

[Mesa-dev] [PATCH 2/2] gallivm: bring back optimized but incorrect float to smallfloat optimizations

2013-03-29 Thread sroland
From: Roland Scheidegger srol...@vmware.com Conceptually the same as previously done in float_to_half. Should cut down number of instructions from 14 to 10 or so, but will promote some NaNs to Infs, so it's disabled. It gets a bit tricky though handling all the cases correctly... Passes basic

[Mesa-dev] [PATCH] i965: Fix an inconsistency the VUE map with gl_ClipVertex on gen4/5.

2013-03-29 Thread Eric Anholt
We are intentionally not allocating a slot for gl_ClipVertex. But by leaving the bit set in the slots_valid, the fragment shader's computation of where varyings are in urb entry coming out of the SF would be off by one. Fixes rendering in Freespace 2 SCP. Bugzilla:

Re: [Mesa-dev] [PATCH 5/5] st/mesa: don't expose ARB_color_buffer_float without driver support in GL core

2013-03-29 Thread Marek Olšák
On Fri, Mar 29, 2013 at 4:21 PM, Brian Paul bri...@vmware.com wrote: On 03/28/2013 03:24 PM, Marek Olšák wrote: --- src/mesa/state_tracker/st_**extensions.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/state_tracker/st_**extensions.c

Re: [Mesa-dev] [PATCH] i965: Fix an inconsistency the VUE map with gl_ClipVertex on gen4/5.

2013-03-29 Thread Paul Berry
On 29 March 2013 10:20, Eric Anholt e...@anholt.net wrote: We are intentionally not allocating a slot for gl_ClipVertex. But by leaving the bit set in the slots_valid, the fragment shader's computation of where varyings are in urb entry coming out of the SF would be off by one. Fixes

Re: [Mesa-dev] [PATCH] intel: Remove a never-taken debug print path.

2013-03-29 Thread Kenneth Graunke
On 03/29/2013 10:40 AM, Eric Anholt wrote: Alessandro Pignotti noted when I added this code in commit 0e723b135bfd59868c92c3ae243f1adaedaec3a5 that it's in the else block for if (busy), so this debug print couldn't happen. --- src/mesa/drivers/dri/intel/intel_buffer_objects.c |5 - 1

Re: [Mesa-dev] [PATCH] docs: add a new page documenting known application issues

2013-03-29 Thread Kenneth Graunke
On 03/29/2013 07:30 AM, Brian Paul wrote: On 03/29/2013 04:50 AM, Jose Fonseca wrote: Looks good to me Brian. Just a couple of comments. - Original Message - Let's try to update this when we find other broken applications... docs/ is growing a lot of stuff, with disparate target

Re: [Mesa-dev] [PATCH] i965: Fix an inconsistency the VUE map with gl_ClipVertex on gen4/5.

2013-03-29 Thread Kenneth Graunke
On 03/29/2013 10:20 AM, Eric Anholt wrote: We are intentionally not allocating a slot for gl_ClipVertex. But by leaving the bit set in the slots_valid, the fragment shader's computation of where varyings are in urb entry coming out of the SF would be off by one. Fixes rendering in Freespace 2

[Mesa-dev] [PATCH] glsl: Fix array indexing when constant folding built-in functions.

2013-03-29 Thread Paul Berry
Mesa constant-folds built-in functions by using a miniature GLSL interpreter (see ir_function_signature::constant_expression_evaluate_expression_list()). This interpreter had a bug in its handling of array indexing, which caused expressions like m[i][j] (where m is a matrix) to be handled

Re: [Mesa-dev] [PATCH 2/4] glsl: Replace constant-index vector array accesses with swizzles

2013-03-29 Thread Paul Berry
On 27 March 2013 09:30, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Search and replace: ][0] - ].x ][1] - ].y ][2] - ].z ][3] - ].w Fixes piglit tests inverse-mat[234].{vert,frag}. These tests call the inverse function with

Re: [Mesa-dev] [PATCH V2] mesa: provide default implementation of QuerySamplesForFormat

2013-03-29 Thread Chris Forbes
A slightly modified version of this (drop the target parameter) should be a candidate for the 9.1 branch. On Fri, Mar 29, 2013 at 5:23 PM, Kenneth Graunke kenn...@whitecape.org wrote: On 03/28/2013 08:28 PM, Chris Forbes wrote: Previously at least i915 failed to provide an implementation, but

[Mesa-dev] [PATCH 1/3] draw/so: Fix bogus assert

2013-03-29 Thread Zack Rusin
We do support so with multiple primitives. Signed-off-by: Zack Rusin za...@vmware.com --- src/gallium/auxiliary/draw/draw_so_emit_tmp.h |1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/draw/draw_so_emit_tmp.h b/src/gallium/auxiliary/draw/draw_so_emit_tmp.h index

[Mesa-dev] [PATCH 2/3] draw: Implement support for primitive id

2013-03-29 Thread Zack Rusin
We were largely ignoring primitive id. Signed-off-by: Zack Rusin za...@vmware.com --- src/gallium/auxiliary/draw/draw_gs.c| 20 +++- src/gallium/auxiliary/draw/draw_gs.h|1 + src/gallium/auxiliary/draw/draw_llvm.c | 15 +--

[Mesa-dev] [PATCH 3/3] draw/so: maintain an exact number of written vertices

2013-03-29 Thread Zack Rusin
It's quite helpful during the rendering when we know exactly the count of the vertices available in the buffer. Signed-off-by: Zack Rusin za...@vmware.com --- src/gallium/auxiliary/draw/draw_context.h|1 + src/gallium/auxiliary/draw/draw_pt.c | 18 +++---

[Mesa-dev] [PATCH] i965/fs: Don't immediately schedule instructions that were just made available.

2013-03-29 Thread Matt Turner
The original goal of pre-register allocation scheduling was to reduce live ranges so we'd use fewer registers and hopefully fit into 16-wide. In shader-db, this change causes us to lose 30 16-wide programs, but we gain 29... so it's a toss-up. At least by choosing instructions in a better order

[Mesa-dev] [PATCH] drirc: set always_have_depth_buffer for Topogon

2013-03-29 Thread Brian Paul
--- src/mesa/drivers/dri/common/drirc |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc index a13941f..556d1b5 100644 --- a/src/mesa/drivers/dri/common/drirc +++ b/src/mesa/drivers/dri/common/drirc

Re: [Mesa-dev] [PATCH] docs: add a new page documenting known application issues

2013-03-29 Thread Brian Paul
On 03/29/2013 12:49 PM, Kenneth Graunke wrote: On 03/29/2013 07:30 AM, Brian Paul wrote: On 03/29/2013 04:50 AM, Jose Fonseca wrote: BTW, do users need to manually configure this, or will it be automatically set based on process name? Manually. Though the DRI conf tool can be used to set

[Mesa-dev] [Bug 62919] New: piglit getteximage-targets S3TC 2D_ARRAY regression

2013-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62919 Priority: medium Bug ID: 62919 Keywords: regression CC: mar...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: piglit getteximage-targets S3TC 2D_ARRAY regression

[Mesa-dev] [PATCH] ACTIVE_UNIFORM_MAX_LENGTH should include 3 extra characters for arrays.

2013-03-29 Thread Haixia Shi
If the active uniform is an array, then the length of the uniform name should include the three extra characters for the [0] suffix, which is required by the GL 4.2 spec to be appended to the uniform name in glGetActiveUniform(). This avoids the situation where the output buffer does not have

[Mesa-dev] [Bug 62920] New: [softpipe] getteximage-targets S3TC CUBE_ARRAY

2013-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62920 Priority: medium Bug ID: 62920 Keywords: regression CC: mar...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] getteximage-targets S3TC CUBE_ARRAY

[Mesa-dev] [PATCH] r600g: Add a Cayman specific version of UMAD

2013-03-29 Thread Martin Andersson
I found an issue with the shader compiler for Cayman when I looked into why the ext_transform_feedback/order test case caused a GPU stall. It turned out the stall was an infinite loop that was the result of broken calculation in the shader function. The issue is that Cayman uses the tgsi_umad

[Mesa-dev] [PATCH] r600g: Add a Cayman specific version of UMAD

2013-03-29 Thread Martin Andersson
The tgsi_umad function does not work for Cayman since it does not populate the y, z and w slots for UMUL that Cayman requires. --- src/gallium/drivers/r600/r600_shader.c | 47 +- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [Bug 62919] piglit getteximage-targets S3TC 2D_ARRAY regression

2013-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62919 --- Comment #1 from Marek Olšák mar...@gmail.com --- The commit turned off the decompression with a blit for software rasterizers, so we're hitting a code path we never used for years. I think this uncovers an existing old bug instead of

[Mesa-dev] [Bug 62920] [softpipe] piglit getteximage-targets S3TC CUBE_ARRAY regression

2013-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62920 Vinson Lee v...@freedesktop.org changed: What|Removed |Added Summary|[softpipe] |[softpipe] piglit

[Mesa-dev] [Bug 62921] New: [llvmpipe] piglit arb_color_buffer_float-drawpixels GL_RGBA16F regression

2013-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62921 Priority: medium Bug ID: 62921 Keywords: regression CC: srol...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] piglit arb_color_buffer_float-drawpixels

[Mesa-dev] [Bug 62922] New: [softpipe] piglit arb_seamless_cubemap regression

2013-03-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62922 Priority: medium Bug ID: 62922 Keywords: regression CC: jfons...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] piglit arb_seamless_cubemap regression