[Mesa-dev] [PATCH] glx/dri: fix assorted compiler warnings/errors

2013-11-07 Thread Brian Paul
From: Brian Paul To fix fall-out from recent commits. --- .../state_trackers/dri/common/dri_context.h|1 + src/glx/dri2.h |2 ++ src/glx/glxclient.h|2 +- src/glx/query_renderer.c |

Re: [Mesa-dev] Fwd: Bug#728053: [PATCH] mesa: FTBFS: invalid alignment assumptions

2013-11-07 Thread Thorsten Glaser
Matt Turner dixit: >[sarcasm]How well does NV84 video decoding work on m68k these days >anyway?[/sarcasm] Dunno, but people do use PCI ATI Radeon cards on Ataris (not yet with Linux for lack of a driver for the PCI bridge, but can’t be long now that they already wrote one for the USB host control

[Mesa-dev] [Bug 71363] line rendering with --with-osmesa-bits=32

2013-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71363 --- Comment #5 from Brian Paul --- Created attachment 88866 --> https://bugs.freedesktop.org/attachment.cgi?id=88866&action=edit osmesa patch to test Can you try this patch? -- You are receiving this mail because: You are the assignee for th

Re: [Mesa-dev] [PATCH 05/10] mesa/dri: Add basic plumbing for GLX_ARB_robustness reset notification strategy

2013-11-07 Thread Kenneth Graunke
On 10/29/2013 06:07 PM, Ian Romanick wrote: > From: Ian Romanick > > No drivers advertise the DRI2 extension yet, so no driver should ever > see a value other than false for notify_reset. > > The changes in nouveau use tabs because nouveau seems to have it's own > indentation rules. > > Signed-

Re: [Mesa-dev] [PATCH] mesa: Add API debug logging to TexStorage

2013-11-07 Thread Brian Paul
On 11/05/2013 02:25 PM, Courtney Goeltzenleuchter wrote: Give glTexStorage* equivalent debug logging to glTexImage*. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/texstorage.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/t

Re: [Mesa-dev] [PATCH 06/10] mesa/dri: Move context flag validation down into the drivers

2013-11-07 Thread Kenneth Graunke
On 10/29/2013 06:07 PM, Ian Romanick wrote: > From: Ian Romanick > > Soon some drivers will support a different set of flags than other > drivers. If some flags have to be filtered in the driver, we might as > well filter all of them in the driver. I'm not sure that I agree, but I don't disagre

[Mesa-dev] [Bug 71363] line rendering with --with-osmesa-bits=32

2013-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71363 --- Comment #4 from Brian Paul --- I'm guessing it's a fragment Z interpolation issue. Can you provide some info about: * does the test use GL_DEPTH_TEST? * Any calls to glDepthRange()? * What are the vertex Z values (zeros?) * Using glPolygonOf

[Mesa-dev] [PATCH] i965: Delete #define's and use local variables inside function

2013-11-07 Thread Anuj Phogat
X_f, Y_f, Xp_f, Yp_f variables are used just inside translate_dst_to_src().So, they can be defined just as local variables. Signed-off-by: Anuj Phogat --- I think I missed this change during the review of my single sample scaled blit patches. src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 13 ++

Re: [Mesa-dev] [PATCH demos 2/3] Perf: Add test to measure texture upload

2013-11-07 Thread Brian Paul
On 11/07/2013 02:16 PM, Courtney Goeltzenleuchter wrote: Needed test to measure texture upload speed under a variety of modes (mipmap, source format, internal format, size, etc.) This new test has an interactive run mode like the other Mesa Perf tests but also includes command line options to mak

Re: [Mesa-dev] [PATCH demos 3/3] Perf: teximage_enh Add command line options

2013-11-07 Thread Brian Paul
On 11/07/2013 02:16 PM, Courtney Goeltzenleuchter wrote: texture_enh allows the user to specify source, internal formats and mipmap or not. This provides a quick way to get feedback on texture upload related performance tuning. Texture image data is initialized and aligned to 64 byte bounary. Use

Re: [Mesa-dev] [PATCH demos 1/3] Perf: Add command line capabilities to perf framework

2013-11-07 Thread Brian Paul
On 11/07/2013 02:16 PM, Courtney Goeltzenleuchter wrote: These were entirely interactive. Adding ability to pass in command line arguments allows future tests to include automated test capabilities. Signed-off-by: Courtney Goeltzenleuchter --- src/perf/copytex.c | 2 +- src/perf/dra

[Mesa-dev] [PATCH 1/3] util: set all unused cbufs to NULL in util_copy_framebuffer_state()

2013-11-07 Thread Brian Paul
This helps fix an issue in the svga driver, and is just safer all-around. --- src/gallium/auxiliary/util/u_framebuffer.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_framebuffer.c b/src/gallium/auxiliary/util/u_framebuffer.c index 7803ec6..

[Mesa-dev] [PATCH 3/3] svga: improve loops over color buffers

2013-11-07 Thread Brian Paul
Only loop over the actual number of color buffers supported, not PIPE_MAX_COLOR_BUFS. --- src/gallium/drivers/svga/svga_context.c |3 ++- src/gallium/drivers/svga/svga_pipe_misc.c |5 +++-- src/gallium/drivers/svga/svga_screen.c| 10 ++ src/gallium/d

[Mesa-dev] [PATCH 2/3] svga: document magic number of 8 render targets per batch

2013-11-07 Thread Brian Paul
Grab the comments from commit message b84b7f19dfdc0 to explain what the code is doing. --- src/gallium/drivers/svga/svga_state_framebuffer.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_state_framebuffer.c b/src/gallium/drivers

[Mesa-dev] [PATCH] i965/fs: Don't perform CSE on inst HW_REG dests (unless it's null)

2013-11-07 Thread Matt Turner
Commit b16b3c87 began performing CSE on CMP instructions with null destinations. I relaxed the restrictions a bit too much, thereby allowing CSE to be performed on instructions with, for instance, an explicit accumulator destination. This broke the arb_gpu_shader5/fs-imulExtended shader tests beca

Re: [Mesa-dev] [PATCH 15/18] docs: Import extension spec for GLX_MESA_query_renderer

2013-11-07 Thread Ian Romanick
On 11/07/2013 01:22 PM, Dave Airlie wrote: > On Sat, Oct 12, 2013 at 8:10 AM, Ian Romanick wrote: >> From: Ian Romanick >> >> The enumerated values are currently allocated from Intel's range. > > Some highlevel comments below, > > >> +GLX renderer attribute number description >

Re: [Mesa-dev] [PATCH 08/18] i965: Wire up initial support for DRI_RENDERER_QUERY extension

2013-11-07 Thread Ian Romanick
On 11/07/2013 01:33 PM, Daniel Vetter wrote: > On Sat, Oct 12, 2013 at 12:10 AM, Ian Romanick wrote: >> + /* Once a batch uses more than 75% of the maximum mappable size, we >> + * assume that there's some fragmentation, and we start doing extra >> + * flushing, etc. That's the b

[Mesa-dev] [PATCH 0/3] More radeon/llvm memory leak fixes

2013-11-07 Thread Aaron Watry
With the 3 attached patches and my previous series of 6 from yesterday, I can now launch glxgears on Evergreen without any definite memory leaks according to: valgrind --leak-check=full glxgears I've run this through piglit/tests/quick.tests without any regressions. I don't have commit access, so

[Mesa-dev] [PATCH 1/3] r600/llvm: initialize radeon_llvm_binary

2013-11-07 Thread Aaron Watry
use memset to initialize to 0's... otherwise code_size and config_size could be uninitialized when read later in this method. It's also hard to do NULL checks on uninitialized pointers. --- src/gallium/drivers/r600/r600_llvm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drive

[Mesa-dev] [PATCH 3/3] radeon/llvm: Free elf_buffer after use

2013-11-07 Thread Aaron Watry
Prevents a memory leak. --- src/gallium/drivers/radeon/radeon_llvm_emit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c b/src/gallium/drivers/radeon/radeon_llvm_emit.c index d2e5642..e35c212 100644 --- a/src/gallium/drivers/radeon/radeon_llvm

[Mesa-dev] [PATCH 2/3] r600/llvm: Free binary.code/binary.config in r600_llvm_compile

2013-11-07 Thread Aaron Watry
radeon_llvm_compile allocates memory for binary.code, binary.config, or neither depending on what's being done. We need to make sure to free that memory after it's no longer needed. --- src/gallium/drivers/r600/r600_llvm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/dr

Re: [Mesa-dev] DEFAULT_SOFTWARE_DEPTH_BITS=31

2013-11-07 Thread burlen
On 11/07/2013 08:45 AM, burlen wrote: On 11/07/2013 08:14 AM, Brian Paul wrote: On 11/07/2013 09:09 AM, burlen wrote: On 11/07/2013 06:42 AM, Brian Paul wrote: On 11/06/2013 04:59 PM, burlen wrote: On 11/06/2013 12:58 PM, Brian Paul wrote: On 11/06/2013 12:34 PM, burlen wrote: When I build o

Re: [Mesa-dev] [PATCH 3/5] glsl: Apply the transformation "(a && a) -> a" in opt_algebraic.

2013-11-07 Thread Eric Anholt
Chris Forbes writes: > Does this affect anything in shader-db? Nope, the shader-db-affecting patches had it cited. pgpOd0euvJ9qG.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mail

[Mesa-dev] [Bug 71363] line rendering with --with-osmesa-bits=32

2013-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71363 --- Comment #3 from burlen --- Created attachment 88862 --> https://bugs.freedesktop.org/attachment.cgi?id=88862&action=edit diff -- You are receiving this mail because: You are the assignee for the bug. __

[Mesa-dev] [Bug 71363] line rendering with --with-osmesa-bits=32

2013-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71363 burlen changed: What|Removed |Added Attachment #88859|0 |1 is obsolete|

[Mesa-dev] [Bug 71363] New: line rendering with --with-osmesa-bits=32

2013-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71363 Priority: medium Bug ID: 71363 Assignee: mesa-dev@lists.freedesktop.org Summary: line rendering with --with-osmesa-bits=32 Severity: normal Classification: Unclassified OS: L

[Mesa-dev] [Bug 71363] line rendering with --with-osmesa-bits=32

2013-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71363 --- Comment #1 from burlen --- Created attachment 88860 --> https://bugs.freedesktop.org/attachment.cgi?id=88860&action=edit correct baseline image -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH] glsl: Enable dFdx, dFdy, and fwidth by default in GLSL ES 3.00.

2013-11-07 Thread Matt Turner
On Thu, Nov 7, 2013 at 2:39 PM, Kenneth Graunke wrote: > Previously, we only exposed them in desktop GL or with: > >#extension GL_OES_standard_derivatives : enable > > GLSL ES 3.00 includes these without an extension, so we need to expose > them by default. > > Note that the above #extension l

Re: [Mesa-dev] [PATCH 15/18] docs: Import extension spec for GLX_MESA_query_renderer

2013-11-07 Thread Stéphane Marchesin
On Thu, Nov 7, 2013 at 1:22 PM, Dave Airlie wrote: > On Sat, Oct 12, 2013 at 8:10 AM, Ian Romanick wrote: > > From: Ian Romanick > > > > The enumerated values are currently allocated from Intel's range. > > Some highlevel comments below, > > > > +GLX renderer attribute number de

Re: [Mesa-dev] [PATCH V2 10/15] i965: flag new indirect buffer in brw_try_draw_prims

2013-11-07 Thread Paul Berry
On 7 November 2013 14:46, Chris Forbes wrote: > The current plan I think is just to drop the extra state in brw, and > just reference the indirect bo directly when we need it [see Eric's > comment on 09/15] > Ah, ok, that makes sense. Thanks. > > On Fri, Nov 8, 2013 at 11:41 AM, Paul Berry >

Re: [Mesa-dev] [PATCH V2 10/15] i965: flag new indirect buffer in brw_try_draw_prims

2013-11-07 Thread Chris Forbes
The current plan I think is just to drop the extra state in brw, and just reference the indirect bo directly when we need it [see Eric's comment on 09/15] On Fri, Nov 8, 2013 at 11:41 AM, Paul Berry wrote: > On 6 November 2013 23:06, Chris Forbes wrote: >> >> Signed-off-by: Chris Forbes >> ---

Re: [Mesa-dev] [PATCH V2 10/15] i965: flag new indirect buffer in brw_try_draw_prims

2013-11-07 Thread Paul Berry
On 6 November 2013 23:06, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > src/mesa/drivers/dri/i965/brw_draw.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_draw.c > b/src/mesa/drivers/dri/i965/brw_draw.c > index e6c3508

[Mesa-dev] [PATCH 3/3 v2] Implement choosing the device to use with DRI_PRIME

2013-11-07 Thread Axel Davy
I forgot to test the capabilities to know if we can use render-nodes. Being able to do that was the goal of patch 1. I send a better patch 3. Axel Davy (1): Implement choosing the device to use with DRI_PRIME src/egl/drivers/dri2/platform_wayland.c | 180 ++-- 1 fi

[Mesa-dev] [PATCH 3/3 v2] Implement choosing the device to use with DRI_PRIME

2013-11-07 Thread Axel Davy
two formats are supported: DRI_PRIME="1" will tell Mesa to choose an other card than the compositor card if possible, while setting DRI_PRIME to the id_path_tag of a device (like "pci-_02_00_0") tells Mesa to take the device with this id_path_tag. Signed-off-by: Axel Davy --- src/egl/drivers

[Mesa-dev] [PATCH] glsl: Enable dFdx, dFdy, and fwidth by default in GLSL ES 3.00.

2013-11-07 Thread Kenneth Graunke
Previously, we only exposed them in desktop GL or with: #extension GL_OES_standard_derivatives : enable GLSL ES 3.00 includes these without an extension, so we need to expose them by default. Note that the above #extension line results in an error or desktop GL, so we don't need to worry abou

[Mesa-dev] [Bug 71359] varray.c:324:7: error: non-void function 'update_array_format' should return a value [-Wreturn-type]

2013-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71359 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 3/5] glsl: Apply the transformation "(a && a) -> a" in opt_algebraic.

2013-11-07 Thread Chris Forbes
Does this affect anything in shader-db? On Fri, Nov 8, 2013 at 10:58 AM, Eric Anholt wrote: > --- > src/glsl/opt_algebraic.cpp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp > index 3da27e5..ea3c386 100644 > ---

Re: [Mesa-dev] [PATCH 0/2v2] i965: Extend fast texture upload

2013-11-07 Thread Courtney Goeltzenleuchter
Re-posted patches with updated commit messages. Thanks, Courtney On Thu, Nov 7, 2013 at 2:34 PM, Matt Turner wrote: > On Thu, Nov 7, 2013 at 1:22 PM, Courtney Goeltzenleuchter > wrote: > > This series builds on work from Frank Henigman to optimize the > > process of uploading a texture to the

[Mesa-dev] [PATCH 2/2 v3] i965: Enhance tiled_memcpy to support all levels

2013-11-07 Thread Courtney Goeltzenleuchter
Support all levels of a supported texture format. Using 1024x1024, RGBA source, mipmap <> internal-format Before (MB/sec) XRGB (MB/sec) mipmap (MB/sec) GL_RGBA 628.15 627.15 615.90 GL_RGB

[Mesa-dev] [PATCH 1/2 v3] i965: add XRGB to tiled_memcpy

2013-11-07 Thread Courtney Goeltzenleuchter
MESA_FORMAT_XRGB is equivalent to MESA_FORMAT_ARGB in terms of storage on the device, so okay to use this optimized copy routine. This series builds on work from Frank Henigman to optimize the process of uploading a texture to the GPU. This series adds support for MESA_XRGB_ and full m

[Mesa-dev] [PATCH 5/5] glsl: Apply the transformation "1/rsq(x) == sqrt(x)" in opt_algebraic.

2013-11-07 Thread Eric Anholt
The comment was stale, because the lowering in question wasn't happening in lower_instructions.cpp. Presumably if the lowering ever moves there, we can plumb the lowering mask through to opt_algebraic. total instructions in shared programs: 1618696 -> 1616810 (-0.12%) instructions in affected pro

[Mesa-dev] [PATCH 2/5] glsl: Apply the transformation "(a || a) -> a" in opt_algebraic.

2013-11-07 Thread Eric Anholt
total instructions in shared programs: 1732385 -> 1732373 (-0.00%) instructions in affected programs: 416 -> 404 (-2.88%) GAINED:0 LOST: 0 (That's 4 already-short fragment shaders in dota2) --- src/glsl/opt_algebraic.cpp | 4 +++

[Mesa-dev] [PATCH 3/5] glsl: Apply the transformation "(a && a) -> a" in opt_algebraic.

2013-11-07 Thread Eric Anholt
--- src/glsl/opt_algebraic.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index 3da27e5..ea3c386 100644 --- a/src/glsl/opt_algebraic.cpp +++ b/src/glsl/opt_algebraic.cpp @@ -357,7 +357,6 @@ ir_algebraic_visitor::ha

[Mesa-dev] [PATCH 1/5] glsl: Move the CSE equality functions to the ir class.

2013-11-07 Thread Eric Anholt
I want to reuse them in opt_algebraic. --- src/glsl/Makefile.sources | 1 + src/glsl/ir.h | 22 ++ src/glsl/ir_equals.cpp| 196 ++ src/glsl/opt_cse.cpp | 178 + 4 files changed, 220 inse

[Mesa-dev] [PATCH 4/5] glsl: Apply the transformation "(a ^^ a) -> false" in opt_algebraic.

2013-11-07 Thread Eric Anholt
--- src/glsl/opt_algebraic.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index ea3c386..448f27e 100644 --- a/src/glsl/opt_algebraic.cpp +++ b/src/glsl/opt_algebraic.cpp @@ -377,7 +377,6 @@ ir_algebraic_visitor::ha

[Mesa-dev] [Bug 71359] New: varray.c:324:7: error: non-void function 'update_array_format' should return a value [-Wreturn-type]

2013-11-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71359 Priority: medium Bug ID: 71359 Keywords: regression CC: chr...@ijw.co.nz, e...@anholt.net Assignee: mesa-dev@lists.freedesktop.org Summary: varray.c:324:7: error: non-void functi

Re: [Mesa-dev] [PATCH 00/18] Implement GLX_MESA_query_renderer

2013-11-07 Thread Kenneth Graunke
I'd like to hear Eric's opinion on patch 8's memory limit. I sent comments on patches 6, 8, 10, and 15. With those fixes, patches 1-11 and 13-15 would get: Reviewed-by: Kenneth Graunke I don't plan to review patches 12 or 16-18 (unit tests). ___ mesa-

Re: [Mesa-dev] [PATCH 0/2v2] i965: Extend fast texture upload

2013-11-07 Thread Matt Turner
On Thu, Nov 7, 2013 at 1:22 PM, Courtney Goeltzenleuchter wrote: > This series builds on work from Frank Henigman to optimize the > process of uploading a texture to the GPU. This series adds support for > MESA_XRGB_ and full miptrees where were found to be common activities > in the Smokin' G

Re: [Mesa-dev] [PATCH 08/18] i965: Wire up initial support for DRI_RENDERER_QUERY extension

2013-11-07 Thread Daniel Vetter
On Sat, Oct 12, 2013 at 12:10 AM, Ian Romanick wrote: > + /* Once a batch uses more than 75% of the maximum mappable size, we > + * assume that there's some fragmentation, and we start doing extra > + * flushing, etc. That's the big cliff apps will care about. > + * > +

Re: [Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

2013-11-07 Thread Courtney Goeltzenleuchter
Hi Matt, I posted results in my cover letter email: [PATCH 0/2v2] i965: Extend fast texture upload Please let me know if you want more details. Courtney On Thu, Nov 7, 2013 at 2:28 PM, Matt Turner wrote: > I saw the perf demo patches and expected to see results from them in > this patch. Any

Re: [Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

2013-11-07 Thread Matt Turner
On Thu, Nov 7, 2013 at 1:28 PM, Matt Turner wrote: > I saw the perf demo patches and expected to see results from them in > this patch. Any results to share? Oh, I see they're in the cover letter. They should really be in the commit messages, for a variety of reasons.

Re: [Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

2013-11-07 Thread Matt Turner
I saw the perf demo patches and expected to see results from them in this patch. Any results to share? On Thu, Nov 7, 2013 at 1:22 PM, Courtney Goeltzenleuchter wrote: > Support all levels of a supported texture format. > > Signed-off-by: Courtney Goeltzenleuchter > --- > src/mesa/drivers/dri/i

Re: [Mesa-dev] [PATCH 08/18] i965: Wire up initial support for DRI_RENDERER_QUERY extension

2013-11-07 Thread Kenneth Graunke
On 10/11/2013 03:10 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/dri/i965/intel_screen.c | 81 > > 1 file changed, 81 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/intel_screen.c > b/src/mesa

Re: [Mesa-dev] [PATCH 15/18] docs: Import extension spec for GLX_MESA_query_renderer

2013-11-07 Thread Dave Airlie
On Sat, Oct 12, 2013 at 8:10 AM, Ian Romanick wrote: > From: Ian Romanick > > The enumerated values are currently allocated from Intel's range. Some highlevel comments below, > +GLX renderer attribute number description > + of values > +

[Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

2013-11-07 Thread Courtney Goeltzenleuchter
Support all levels of a supported texture format. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 0/2v2] i965: Extend fast texture upload

2013-11-07 Thread Courtney Goeltzenleuchter
This series builds on work from Frank Henigman to optimize the process of uploading a texture to the GPU. This series adds support for MESA_XRGB_ and full miptrees where were found to be common activities in the Smokin' Guns game. The issue was found while profiling the app but that part is not

[Mesa-dev] [PATCH 1/2] i965: add XRGB to tiled_memcpy

2013-11-07 Thread Courtney Goeltzenleuchter
MESA_FORMAT_XRGB is equivalent to MESA_FORMAT_ARGB in terms of storage on the device, so okay to use this optimized copy routine. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

Re: [Mesa-dev] [PATCH 15/18] docs: Import extension spec for GLX_MESA_query_renderer

2013-11-07 Thread Kenneth Graunke
On 10/11/2013 03:10 PM, Ian Romanick wrote: > From: Ian Romanick > > The enumerated values are currently allocated from Intel's range. > > Signed-off-by: Ian Romanick > --- > docs/MESA_query_renderer.spec | 381 > ++ > 1 file changed, 381 insertions(+)

[Mesa-dev] [PATCH demos 2/3] Perf: Add test to measure texture upload

2013-11-07 Thread Courtney Goeltzenleuchter
Needed test to measure texture upload speed under a variety of modes (mipmap, source format, internal format, size, etc.) This new test has an interactive run mode like the other Mesa Perf tests but also includes command line options to make it automatable. Fix up code formatting. Signed-off-by: C

[Mesa-dev] [PATCH demos 3/3] Perf: teximage_enh Add command line options

2013-11-07 Thread Courtney Goeltzenleuchter
texture_enh allows the user to specify source, internal formats and mipmap or not. This provides a quick way to get feedback on texture upload related performance tuning. Texture image data is initialized and aligned to 64 byte bounary. Uses Mesa demos Perf library to do the measurements. Signed-o

[Mesa-dev] [PATCH demos 1/3] Perf: Add command line capabilities to perf framework

2013-11-07 Thread Courtney Goeltzenleuchter
These were entirely interactive. Adding ability to pass in command line arguments allows future tests to include automated test capabilities. Signed-off-by: Courtney Goeltzenleuchter --- src/perf/copytex.c | 2 +- src/perf/drawoverhead.c | 2 +- src/perf/fbobind.c | 2 +- s

[Mesa-dev] [PATCH demos 0/3] Customizable texture upload benchmark

2013-11-07 Thread Courtney Goeltzenleuchter
This patch series adds a new benchmark test designed to measure texture upload speed with configurable parameters. Can run interactively, similar to teximage test or can use command line arguments to specify size of texture, mipmap or not, source pixel format and internal pixel format. The first p

Re: [Mesa-dev] [PATCH 2/2] i965: Add an implementation of intel_miptree_map using streaming loads.

2013-11-07 Thread Chad Versace
On 11/07/2013 10:55 AM, Matt Turner wrote: Improves performance of RoboHornet's 2D Canvas toDataURL benchmark [http://www.robohornet.org/#e=canvastodataurl] by approximately 5x on Baytrail on ChromiumOS. --- v2: Added benchmark results Remove unnecessary _mesa_align_free in error case R

Re: [Mesa-dev] [PATCH 10/18] glx: Add GLX_MESA_query_renderer

2013-11-07 Thread Ian Romanick
On 11/07/2013 10:59 AM, Kenneth Graunke wrote: > On 10/11/2013 03:10 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> THESE ARE JUST PLACEHOLDER VALUES. DO NOT SHIP!!! > > YOU SHOULD PROBABLY GET REAL VALUES BEFORE YOU SHIP THIS! > > Or just delete the comment if you already have :) Ah, yes

Re: [Mesa-dev] [PATCH] i965: Fix 'SIMD16 only' dispatch of fragment shader in case of sample shading

2013-11-07 Thread Eric Anholt
Anuj Phogat writes: > This patch make changes to correctly set up the Dispatch GRF Start > Register in case of 'SIMD16 only' FS dispatch. > > This fixes an issue of incorrect rendering on dolphin emulator with > GL_SAMPLE_SHADING enabled. > > Signed-off-by: Anuj Phogat Reviewed-by: Eric Anholt

Re: [Mesa-dev] [PATCH 0/7] ARB_vertex_type_10f_11f_11f_rev for i965

2013-11-07 Thread Eric Anholt
Chris Forbes writes: > Ever since this had appeared as part of GL4.4 I'd been curious > about whether this extension was going to Just Work, or be a > workaround-party like ARB_vertex_type_2_10_10_10_rev. > > Today my curiousity got the better of me, and it turns out it > just works. > > Tested a

Re: [Mesa-dev] [PATCH V2 07/15] mesa: add is_indirect to _mesa_prim

2013-11-07 Thread Paul Berry
On 6 November 2013 23:06, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > src/mesa/vbo/vbo.h| 3 ++- > src/mesa/vbo/vbo_exec_array.c | 5 + > 2 files changed, 7 insertions(+), 1 deletion(-) > It looks to me like you forgot to update the code in the following functions

Re: [Mesa-dev] [PATCH 2/7] mesa: add varray support for UNSIGNED_INT_10F_11F_11F_REV type

2013-11-07 Thread Eric Anholt
Chris Forbes writes: > Signed-off-by: Chris Forbes > --- > src/mesa/main/varray.c | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c > index dee476a..5af4c8c 100644 > --- a/src/mesa/main/varray.c > +++ b/sr

Re: [Mesa-dev] [PATCH V2 14/15] vbo: map indirect buffer and extract params if doing sw primitive restart

2013-11-07 Thread Brian Paul
On 11/07/2013 11:29 AM, Eric Anholt wrote: Brian Paul writes: On 11/07/2013 10:23 AM, Eric Anholt wrote: Chris Forbes writes: V2: Check for mapping failure (thanks Brian) Signed-off-by: Chris Forbes --- src/mesa/vbo/vbo_primitive_restart.c | 33 + 1 f

Re: [Mesa-dev] [PATCH 10/18] glx: Add GLX_MESA_query_renderer

2013-11-07 Thread Kenneth Graunke
On 10/11/2013 03:10 PM, Ian Romanick wrote: > From: Ian Romanick > > THESE ARE JUST PLACEHOLDER VALUES. DO NOT SHIP!!! YOU SHOULD PROBABLY GET REAL VALUES BEFORE YOU SHIP THIS! Or just delete the comment if you already have :) > Signed-off-by: Ian Romanick > --- > include/GL/glx.h | 27

[Mesa-dev] [PATCH 2/2] i965: Add an implementation of intel_miptree_map using streaming loads.

2013-11-07 Thread Matt Turner
Improves performance of RoboHornet's 2D Canvas toDataURL benchmark [http://www.robohornet.org/#e=canvastodataurl] by approximately 5x on Baytrail on ChromiumOS. --- v2: Added benchmark results Remove unnecessary _mesa_align_free in error case Rename stride to width_bytes and make const

Re: [Mesa-dev] [PATCH V2 14/15] vbo: map indirect buffer and extract params if doing sw primitive restart

2013-11-07 Thread Chris Forbes
Maybe it would be better to remove the const from the indirect parameter back in 1/15. This was added in v2 of Christoph's original patches in response to a suggestion from Brian; but if everyone ends up casting it away, then it's not useful. -- Chris On Fri, Nov 8, 2013 at 7:29 AM, Eric Anholt

Re: [Mesa-dev] [PATCH 06/18] dri: Add function to implement queries common to all Mesa drivers

2013-11-07 Thread Kenneth Graunke
On 10/11/2013 03:10 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/dri/common/utils.c | 62 > + > src/mesa/drivers/dri/common/utils.h | 3 ++ > 2 files changed, 65 insertions(+) > > diff --git a/src/me

Re: [Mesa-dev] [PATCH V2 09/15] i965: add state atom for indirect buffer

2013-11-07 Thread Chris Forbes
OK -- that's much simpler, thanks. On Fri, Nov 8, 2013 at 7:11 AM, Eric Anholt wrote: > Chris Forbes writes: > >> Signed-off-by: Chris Forbes >> --- >> src/mesa/drivers/dri/i965/brw_context.h | 10 + >> src/mesa/drivers/dri/i965/brw_draw_upload.c | 32 >>

Re: [Mesa-dev] [PATCH 0/7] ARB_vertex_type_10f_11f_11f_rev for i965

2013-11-07 Thread Chris Forbes
Oops -- had pushed tests to my piglit branch but not sent them to the list. On Fri, Nov 8, 2013 at 6:25 AM, Eric Anholt wrote: > Chris Forbes writes: > >> Ever since this had appeared as part of GL4.4 I'd been curious >> about whether this extension was going to Just Work, or be a >> workaround-

Re: [Mesa-dev] [PATCH V2 14/15] vbo: map indirect buffer and extract params if doing sw primitive restart

2013-11-07 Thread Eric Anholt
Brian Paul writes: > On 11/07/2013 10:23 AM, Eric Anholt wrote: >> Chris Forbes writes: >> >>> V2: Check for mapping failure (thanks Brian) >>> >>> Signed-off-by: Chris Forbes >>> --- >>> src/mesa/vbo/vbo_primitive_restart.c | 33 >>> + >>> 1 file changed, 33

Re: [Mesa-dev] [PATCH V2 09/15] i965: add state atom for indirect buffer

2013-11-07 Thread Eric Anholt
Chris Forbes writes: > Signed-off-by: Chris Forbes > --- > src/mesa/drivers/dri/i965/brw_context.h | 10 + > src/mesa/drivers/dri/i965/brw_draw_upload.c | 32 > > src/mesa/drivers/dri/i965/brw_state.h| 1 + > src/mesa/drivers/dri/i965/brw_sta

Re: [Mesa-dev] [PATCH V2 05/15] mesa: Add validation helpers for new indirect draws

2013-11-07 Thread Paul Berry
On 6 November 2013 23:06, Chris Forbes wrote: > Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. > > Signed-off-by: Chris Forbes > --- > src/mesa/main/api_validate.c | 163 > +++ > src/mesa/main/api_validate.h | 26 +++ > 2

Re: [Mesa-dev] [PATCH V2 05/15] mesa: Add validation helpers for new indirect draws

2013-11-07 Thread Eric Anholt
Chris Forbes writes: > Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. > > Signed-off-by: Chris Forbes > --- > src/mesa/main/api_validate.c | 163 > +++ > src/mesa/main/api_validate.h | 26 +++ > 2 files changed, 189 inser

Re: [Mesa-dev] Contributing to Mesa Demos?

2013-11-07 Thread Courtney Goeltzenleuchter
Hi Eric, Include performance tests? In my quick look I didn't see anything that looked appropriate to performance regression testing. The Perf folder under Mesa demos seemed the closest that I could find. Thanks, Courtney On Thu, Nov 7, 2013 at 10:20 AM, Eric Anholt wrote: > Courtney Goeltzen

Re: [Mesa-dev] [PATCH V2 14/15] vbo: map indirect buffer and extract params if doing sw primitive restart

2013-11-07 Thread Brian Paul
On 11/07/2013 10:23 AM, Eric Anholt wrote: Chris Forbes writes: V2: Check for mapping failure (thanks Brian) Signed-off-by: Chris Forbes --- src/mesa/vbo/vbo_primitive_restart.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/mesa/vbo/vbo_primiti

Re: [Mesa-dev] [PATCH V2 04/15] mesa: Add binding point for indirect buffer

2013-11-07 Thread Eric Anholt
Brian Paul writes: > On 11/07/2013 12:06 AM, Chris Forbes wrote: >> Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. >> >> Signed-off-by: Chris Forbes >> --- >> src/mesa/main/bufferobj.c| 14 ++ >> src/mesa/main/get.c | 4 >> s

Re: [Mesa-dev] Contributing to Mesa Demos?

2013-11-07 Thread Paul Berry
On 7 November 2013 09:20, Eric Anholt wrote: > Courtney Goeltzenleuchter writes: > > > What's the process of contributing a test to the Mesa demos repository? > > Tests should be made automated and put in piglit, instead of in the Mesa > demos repository. > Also Piglit has its own mailing list

Re: [Mesa-dev] [PATCH 0/7] ARB_vertex_type_10f_11f_11f_rev for i965

2013-11-07 Thread Eric Anholt
Chris Forbes writes: > Ever since this had appeared as part of GL4.4 I'd been curious > about whether this extension was going to Just Work, or be a > workaround-party like ARB_vertex_type_2_10_10_10_rev. > > Today my curiousity got the better of me, and it turns out it > just works. > > Tested a

Re: [Mesa-dev] Contributing to Mesa Demos?

2013-11-07 Thread Matt Turner
On Thu, Nov 7, 2013 at 9:01 AM, Courtney Goeltzenleuchter wrote: > What's the process of contributing a test to the Mesa demos repository? Send patches to this list with a [PATCH demos] prefix. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org ht

Re: [Mesa-dev] [PATCH V2 14/15] vbo: map indirect buffer and extract params if doing sw primitive restart

2013-11-07 Thread Eric Anholt
Chris Forbes writes: > V2: Check for mapping failure (thanks Brian) > > Signed-off-by: Chris Forbes > --- > src/mesa/vbo/vbo_primitive_restart.c | 33 + > 1 file changed, 33 insertions(+) > > diff --git a/src/mesa/vbo/vbo_primitive_restart.c > b/src/mesa/vbo/vbo

Re: [Mesa-dev] Contributing to Mesa Demos?

2013-11-07 Thread Eric Anholt
Courtney Goeltzenleuchter writes: > What's the process of contributing a test to the Mesa demos repository? Tests should be made automated and put in piglit, instead of in the Mesa demos repository. pgpt0EWtwH3M0.pgp Description: PGP signature ___ me

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-07 Thread Tapani
Hi; On 11/06/2013 07:35 PM, Erik Faye-Lund wrote: Sorry for the late reply. On Fri, Nov 1, 2013 at 4:14 PM, Tapani wrote: On 11/01/2013 03:31 PM, Erik Faye-Lund wrote: That won't help for programs that maintain their own (explicit) shader-cache, which was the intention of introducing binar

Re: [Mesa-dev] [PATCH] configure.ac: Drop no-out-of-tree notice.

2013-11-07 Thread Eric Anholt
Matt Turner writes: > We do support out of tree builds now. This series is: Reviewed-by: Eric Anholt pgpi1Kk4N3O2m.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

[Mesa-dev] Contributing to Mesa Demos?

2013-11-07 Thread Courtney Goeltzenleuchter
What's the process of contributing a test to the Mesa demos repository? Thanks, Courtney -- Courtney Goeltzenleuchter LunarG ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] DEFAULT_SOFTWARE_DEPTH_BITS=31

2013-11-07 Thread burlen
On 11/07/2013 08:14 AM, Brian Paul wrote: On 11/07/2013 09:09 AM, burlen wrote: On 11/07/2013 06:42 AM, Brian Paul wrote: On 11/06/2013 04:59 PM, burlen wrote: On 11/06/2013 12:58 PM, Brian Paul wrote: On 11/06/2013 12:34 PM, burlen wrote: When I build osmesa with --with-osmesa-bits=32 I noti

[Mesa-dev] [PATCH 3/3] Implement choosing the device to use with DRI_PRIME

2013-11-07 Thread Axel Davy
two formats are supported: DRI_PRIME="1" will tell Mesa to choose an other card than the compositor card if possible, while setting DRI_PRIME to the id_path_tag of a device (like "pci-_02_00_0") tells Mesa to take the device with this id_path_tag. If it isn't able to find the desired card ( no

[Mesa-dev] [PATCH 1/3] Move the code to open the graphic device. Support for render-nodes.

2013-11-07 Thread Axel Davy
This patch moves the code to open the graphic device in the Wayland backend, removes the authentication request when we are on a render-node, and has a few fixes. Signed-off-by: Axel Davy --- src/egl/drivers/dri2/egl_dri2.h | 1 + src/egl/drivers/dri2/platform_wayland.c | 93 +++

[Mesa-dev] [PATCH 0/3] Implement DRI_PRIME support for Wayland

2013-11-07 Thread Axel Davy
These patches enable using DRI_PRIME to use a different card than the compositor card (with render-nodes). At the time of writing, Mesa Wayland egl backend doesn't support render-nodes, because it uses the dri2 backend, which require using GEM names (render-nodes aren't allowed to use GEM names).

[Mesa-dev] [PATCH] Fix FTBFS on GNU/Hurd due to missing PIPE_OS_HURD detection.

2013-11-07 Thread Fabio Pedretti
From: Cyril Brulebois Thanks to Pino Toscano. Patch from Debian package. --- src/gallium/auxiliary/os/os_thread.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/os/os_thread.h b/src/gallium/auxiliary/os/os_thread.h index e153ab4..4528abb

[Mesa-dev] [PATCH 2/3] Create untiled buffers in get_back_bo when needed.

2013-11-07 Thread Axel Davy
We must send to the compositor buffer it is able to read. Since tiling modes are different on graphic cards, we have to disable tiling when creating the buffers if we render with a different graphic card than the compositor. Signed-off-by: Axel Davy --- src/egl/drivers/dri2/platform_wayland.c |

Re: [Mesa-dev] DEFAULT_SOFTWARE_DEPTH_BITS=31

2013-11-07 Thread Brian Paul
On 11/07/2013 09:09 AM, burlen wrote: On 11/07/2013 06:42 AM, Brian Paul wrote: On 11/06/2013 04:59 PM, burlen wrote: On 11/06/2013 12:58 PM, Brian Paul wrote: On 11/06/2013 12:34 PM, burlen wrote: When I build osmesa with --with-osmesa-bits=32 I notice that I get 31 bits by way of the compil

Re: [Mesa-dev] DEFAULT_SOFTWARE_DEPTH_BITS=31

2013-11-07 Thread burlen
On 11/07/2013 06:42 AM, Brian Paul wrote: On 11/06/2013 04:59 PM, burlen wrote: On 11/06/2013 12:58 PM, Brian Paul wrote: On 11/06/2013 12:34 PM, burlen wrote: When I build osmesa with --with-osmesa-bits=32 I notice that I get 31 bits by way of the compile line define -DDEFAULT_SOFTWARE_DEPTH

Re: [Mesa-dev] [PATCH V2 14/15] vbo: map indirect buffer and extract params if doing sw primitive restart

2013-11-07 Thread Brian Paul
On 11/07/2013 12:06 AM, Chris Forbes wrote: V2: Check for mapping failure (thanks Brian) Signed-off-by: Chris Forbes --- src/mesa/vbo/vbo_primitive_restart.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/mesa/vbo/vbo_primitive_restart.c b/src/mes

Re: [Mesa-dev] [PATCH V2 04/15] mesa: Add binding point for indirect buffer

2013-11-07 Thread Brian Paul
On 11/07/2013 12:06 AM, Chris Forbes wrote: Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. Signed-off-by: Chris Forbes --- src/mesa/main/bufferobj.c| 14 ++ src/mesa/main/get.c | 4 src/mesa/main/get_hash_params.py | 2 ++

  1   2   >