Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Marek Olšák
On Tue, Jan 7, 2014 at 7:14 PM, Lauri Kasanen c...@gmx.com wrote: These will be used later on for optimizing the VRAM placement. No measurable overhead (glxgears, torcs). v2: Get accurate stats by taking dirty_masks into account Why don't you just set the statistics once per CS in

[Mesa-dev] [Bug 73392] New: GLX context memory leak if context was bound to drawable on thread exit

2014-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73392 Priority: medium Bug ID: 73392 Assignee: mesa-dev@lists.freedesktop.org Summary: GLX context memory leak if context was bound to drawable on thread exit Severity: normal

[Mesa-dev] [Bug 73371] EGL_NOK_texture_from_pixmap is advertised but not properly set.

2014-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73371 --- Comment #5 from Tapani Pälli lem...@gmail.com --- (In reply to comment #4) but it is wrong - it IS inverted. without the extension at all the default assumption is to assume inversion. it all worked fine until we added support for this

[Mesa-dev] [Bug 73371] EGL_NOK_texture_from_pixmap is advertised but not properly set.

2014-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73371 --- Comment #6 from Carsten Haitzler ras...@rasterman.com --- indeed. and thus why we noticed... as we had it right without the extension assuming the default of inversion... :) once we actually ASKED for it... it told us the wrong thing. fyi we

[Mesa-dev] [Bug 73371] EGL_NOK_texture_from_pixmap is advertised but not properly set.

2014-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73371 --- Comment #4 from Carsten Haitzler ras...@rasterman.com --- but it is wrong - it IS inverted. without the extension at all the default assumption is to assume inversion. it all worked fine until we added support for this extension and then

Re: [Mesa-dev] [PATCH] ilo: build pipe-loader driver]

2014-01-08 Thread Steven Newbury
On Fri, 2014-01-03 at 13:14 +0800, Chia-I Wu wrote: On Thu, Jan 2, 2014 at 10:39 PM, Steven Newbury st...@snewbury.org.uk wrote: Forgot to add signed-off-by... In trying to get gallium-nine working with the ilo Gallium driver I noticed there's no ilo pipe-loader driver being built.

[Mesa-dev] [Bug 73371] EGL_NOK_texture_from_pixmap is advertised but not properly set.

2014-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73371 Tapani Pälli lem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED

[Mesa-dev] [PATCH 2/2] dri: set yInverted default to GL_TRUE

2014-01-08 Thread Tapani Pälli
yInverted is used by EGL_NOK_texture_from_pixmap to indicate that window system rendering is y-inverted compared to OpenGL texture representation. This extension is only known to be used with X11 window system where sane default is GL_TRUE. Bugzilla:

[Mesa-dev] [PATCH 1/2] egl_dri2: call dri2_add_configs_for_visuals after extensions set

2014-01-08 Thread Tapani Pälli
dri2_add_config makes decisions based on NOK_texture_from_pixmap so it needs to be enabled before calling dri2_add_configs_for_visuals. Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/egl/drivers/dri2/platform_x11.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-)

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Lauri Kasanen
On Wed, 8 Jan 2014 12:03:12 +0100 Marek Olšák mar...@gmail.com wrote: On Tue, Jan 7, 2014 at 7:14 PM, Lauri Kasanen c...@gmx.com wrote: These will be used later on for optimizing the VRAM placement. No measurable overhead (glxgears, torcs). v2: Get accurate stats by taking dirty_masks

Re: [Mesa-dev] [PATCH 3/4] MSVC2013: Work around internal compiler error

2014-01-08 Thread Thomas Sondergaard
On 08-01-2014 00:11, Brian Paul wrote: On 01/07/2014 03:30 PM, Ian Romanick wrote: On 01/07/2014 02:22 PM, Thomas Sondergaard wrote: On 2014-01-07 23:05, Ian Romanick wrote: On 01/07/2014 12:31 PM, Thomas Sondergaard wrote: This small rearrangement avoids MSVC 2013 ICE. Also, this should be

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Marek Olšák
On Wed, Jan 8, 2014 at 2:56 PM, Lauri Kasanen c...@gmx.com wrote: On Wed, 8 Jan 2014 12:03:12 +0100 Marek Olšák mar...@gmail.com wrote: On Tue, Jan 7, 2014 at 7:14 PM, Lauri Kasanen c...@gmx.com wrote: These will be used later on for optimizing the VRAM placement. No measurable overhead

Re: [Mesa-dev] [PATCH 3/4] MSVC2013: Work around internal compiler error

2014-01-08 Thread Brian Paul
On 01/08/2014 01:16 AM, Thomas Sondergaard wrote: On 08-01-2014 00:11, Brian Paul wrote: On 01/07/2014 03:30 PM, Ian Romanick wrote: On 01/07/2014 02:22 PM, Thomas Sondergaard wrote: On 2014-01-07 23:05, Ian Romanick wrote: On 01/07/2014 12:31 PM, Thomas Sondergaard wrote: This small

Re: [Mesa-dev] [PATCH 2/7] mesa: Store gl_shader_stage enum in gl_shader objects.

2014-01-08 Thread Paul Berry
On 7 January 2014 15:25, Kenneth Graunke kenn...@whitecape.org wrote: On 01/07/2014 02:13 PM, Paul Berry wrote: This reduces confusion since gl_shader::Type is sometimes GL_SHADER_PROGRAM_MESA but is more frequently GL_SHADER_{VERTEX,GEOMETRY,FRAGMENT}. It also has the advantage that

Re: [Mesa-dev] [PATCH 1/7] mesa: Clean up nomenclature for pipeline stages.

2014-01-08 Thread Paul Berry
On 7 January 2014 15:06, Brian Paul bri...@vmware.com wrote: On 01/07/2014 03:13 PM, Paul Berry wrote: diff --git a/src/glsl/glsl_parser_extras.h b/src/glsl/glsl_parser_extras.h index 0e281ae..ecf832f 100644 --- a/src/glsl/glsl_parser_extras.h +++ b/src/glsl/glsl_parser_extras.h @@ -165,7

Re: [Mesa-dev] [PATCH 2/3] i965/gen6/blorp: Set need_workaround_flush at top of blorp (v2)

2014-01-08 Thread Paul Berry
On 7 January 2014 16:58, Chad Versace chad.vers...@linux.intel.com wrote: Unconditionally set brw-need_workaround_flush at the top of gen6 blorp state emission. The art of emitting workaround flushes on Sandybridge is mysterious and not fully understood. Ken and I believe that

Re: [Mesa-dev] [PATCH] ilo: build pipe-loader driver]

2014-01-08 Thread Chia-I Wu
On Wed, Jan 8, 2014 at 8:23 PM, Steven Newbury st...@snewbury.org.uk wrote: On Fri, 2014-01-03 at 13:14 +0800, Chia-I Wu wrote: On Thu, Jan 2, 2014 at 10:39 PM, Steven Newbury st...@snewbury.org.uk wrote: Forgot to add signed-off-by... In trying to get gallium-nine working with the ilo

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Lauri Kasanen
On Wed, 8 Jan 2014 15:54:04 +0100 Marek Olšák mar...@gmail.com wrote: On Wed, 8 Jan 2014 12:03:12 +0100 Marek Olšák mar...@gmail.com wrote: Why don't you just set the statistics once per CS in radeon_drm_cs_flush? I don't see a value in doing it in every function that sets the

[Mesa-dev] [PATCH 1/7] mesa: handle GL_NONE draw buffers correctly in glClear

2014-01-08 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/mesa/main/clear.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/clear.c b/src/mesa/main/clear.c index f0b525f..fd5bb35 100644 --- a/src/mesa/main/clear.c +++ b/src/mesa/main/clear.c @@ -179,7 +179,11 @@

[Mesa-dev] [PATCH 2/7] st/mesa: bind NULL colorbuffers as specified by glDrawBuffers

2014-01-08 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com An example why it is required: Let's say there's a fragment shader writing to gl_FragData[0..1]. The user calls: glDrawBuffers(2, {GL_NONE, GL_COLOR_ATTACHMENT0}); That means gl_FragData[0] is unused and gl_FragData[1] is written to

[Mesa-dev] [PATCH 4/7] radeonsi: handle NULL colorbuffers correctly

2014-01-08 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/radeonsi/si_state.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 3666a11..ba73401 100644 ---

[Mesa-dev] [PATCH 7/7] r600g: fix glClearBuffer by handling PIPE_CLEAR_COLORi flags correctly

2014-01-08 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com also restructure the code --- src/gallium/drivers/r600/r600_blit.c | 69 1 file changed, 31 insertions(+), 38 deletions(-) diff --git a/src/gallium/drivers/r600/r600_blit.c b/src/gallium/drivers/r600/r600_blit.c index

[Mesa-dev] [PATCH 3/7] gallium/util: easy fixes for NULL colorbuffers

2014-01-08 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/auxiliary/util/u_clear.h | 4 src/gallium/auxiliary/util/u_framebuffer.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/src/gallium/auxiliary/util/u_clear.h b/src/gallium/auxiliary/util/u_clear.h index 75047c1..db0b9b3

[Mesa-dev] [PATCH 6/7] r600g: handle NULL colorbuffers correctly on R600-R700

2014-01-08 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/r600/r600_state.c | 120 -- 1 file changed, 55 insertions(+), 65 deletions(-) diff --git a/src/gallium/drivers/r600/r600_state.c b/src/gallium/drivers/r600/r600_state.c index f4ceb4a..a0d527b 100644

[Mesa-dev] [PATCH 5/7] r600g: handle NULL colorbuffers correctly on Evergreen

2014-01-08 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/r600/evergreen_state.c | 59 ++ src/gallium/drivers/r600/r600_blit.c | 23 ++-- 2 files changed, 54 insertions(+), 28 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_state.c

[Mesa-dev] [PATCH 1/2] demos/pixeltest: Remove Line struct.

2014-01-08 Thread jfonseca
From: José Fonseca jfons...@vmware.com Not really used/necessary. --- src/demos/pixeltest.c | 113 +++--- 1 file changed, 52 insertions(+), 61 deletions(-) diff --git a/src/demos/pixeltest.c b/src/demos/pixeltest.c index e9b95b8..0898290 100644 ---

[Mesa-dev] [PATCH 2/2] demos/pixeltest: Adapt the example for points too.

2014-01-08 Thread jfonseca
From: José Fonseca jfons...@vmware.com This example is very useful to understand the rasterization of lines. And with this change, points too. Adding a key / command-line option to switch modes is left for a future opportunity though. --- src/demos/pixeltest.c | 109

[Mesa-dev] [PATCH] llvmpipe: Honour pipe_rasterizer::point_quad_rasterization.

2014-01-08 Thread jfonseca
From: José Fonseca jfons...@vmware.com Commit eda21d2a3010d9fc5a68b55a843c5e44b2abf8dd fixed the rasterization of points for Direct3D but ended up breaking the rasterization of OpenGL non-sprite points, in particular conform's pntrast.c test. The only way to get both working is to properly

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Lauri Kasanen
On Wed, 8 Jan 2014 15:56:33 +0200 Lauri Kasanen c...@gmx.com wrote: On Wed, 8 Jan 2014 12:03:12 +0100 Marek Olšák mar...@gmail.com wrote: Also, last_cpu_time will be wrong anyway, because the driver may call the buffer_map function only once per buffer, e.g. at buffer creation. It's not a

Re: [Mesa-dev] [PATCH] llvmpipe: Honour pipe_rasterizer::point_quad_rasterization.

2014-01-08 Thread Erik Faye-Lund
On Wed, Jan 8, 2014 at 6:27 PM, jfons...@vmware.com wrote: } - + + if (0) { + debug_printf( bbox: (%i, %i) - (%i, %i)\n, + bbox.x0, bbox.y0, + bbox.x1, bbox.y1); + } + if (!u_rect_test_intersection(setup-draw_regions[viewport_index],

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Marek Olšák
On Wed, Jan 8, 2014 at 6:21 PM, Lauri Kasanen c...@gmx.com wrote: On Wed, 8 Jan 2014 15:54:04 +0100 Marek Olšák mar...@gmail.com wrote: On Wed, 8 Jan 2014 12:03:12 +0100 Marek Olšák mar...@gmail.com wrote: Why don't you just set the statistics once per CS in radeon_drm_cs_flush? I don't

Re: [Mesa-dev] [PATCH 2/2] demos/pixeltest: Adapt the example for points too.

2014-01-08 Thread Erik Faye-Lund
On Wed, Jan 8, 2014 at 6:30 PM, jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com This example is very useful to understand the rasterization of lines. And with this change, points too. Adding a key / command-line option to switch modes is left for a future opportunity

Re: [Mesa-dev] [PATCH 2/2] demos/pixeltest: Adapt the example for points too.

2014-01-08 Thread Jose Fonseca
- Original Message - On Wed, Jan 8, 2014 at 6:30 PM, jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com This example is very useful to understand the rasterization of lines. And with this change, points too. Adding a key / command-line option to switch modes

Re: [Mesa-dev] [PATCH] llvmpipe: Honour pipe_rasterizer::point_quad_rasterization.

2014-01-08 Thread Roland Scheidegger
Am 08.01.2014 18:27, schrieb jfons...@vmware.com: From: José Fonseca jfons...@vmware.com Commit eda21d2a3010d9fc5a68b55a843c5e44b2abf8dd fixed the rasterization of points for Direct3D but ended up breaking the rasterization of OpenGL non-sprite points, in particular conform's pntrast.c test.

Re: [Mesa-dev] [PATCH] llvmpipe: Honour pipe_rasterizer::point_quad_rasterization.

2014-01-08 Thread Jose Fonseca
- Original Message - On Wed, Jan 8, 2014 at 6:27 PM, jfons...@vmware.com wrote: } - + + if (0) { + debug_printf( bbox: (%i, %i) - (%i, %i)\n, + bbox.x0, bbox.y0, + bbox.x1, bbox.y1); + } + if

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Marek Olšák
On Wed, Jan 8, 2014 at 6:38 PM, Lauri Kasanen c...@gmx.com wrote: On Wed, 8 Jan 2014 15:56:33 +0200 Lauri Kasanen c...@gmx.com wrote: On Wed, 8 Jan 2014 12:03:12 +0100 Marek Olšák mar...@gmail.com wrote: Also, last_cpu_time will be wrong anyway, because the driver may call the buffer_map

Re: [Mesa-dev] [PATCH] llvmpipe: Honour pipe_rasterizer::point_quad_rasterization.

2014-01-08 Thread Jose Fonseca
- Original Message - Am 08.01.2014 18:27, schrieb jfons...@vmware.com: From: José Fonseca jfons...@vmware.com Commit eda21d2a3010d9fc5a68b55a843c5e44b2abf8dd fixed the rasterization of points for Direct3D but ended up breaking the rasterization of OpenGL non-sprite points, in

Re: [Mesa-dev] [PATCH] llvmpipe: Honour pipe_rasterizer::point_quad_rasterization.

2014-01-08 Thread Roland Scheidegger
Am 08.01.2014 19:12, schrieb Jose Fonseca: - Original Message - Am 08.01.2014 18:27, schrieb jfons...@vmware.com: From: José Fonseca jfons...@vmware.com Commit eda21d2a3010d9fc5a68b55a843c5e44b2abf8dd fixed the rasterization of points for Direct3D but ended up breaking the

Re: [Mesa-dev] [PATCH] llvmpipe: Honour pipe_rasterizer::point_quad_rasterization.

2014-01-08 Thread Marek Olšák
On Wed, Jan 8, 2014 at 7:31 PM, Roland Scheidegger srol...@vmware.com wrote: Am 08.01.2014 19:12, schrieb Jose Fonseca: - Original Message - Am 08.01.2014 18:27, schrieb jfons...@vmware.com: From: José Fonseca jfons...@vmware.com Commit eda21d2a3010d9fc5a68b55a843c5e44b2abf8dd

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Lauri Kasanen
On Wed, 8 Jan 2014 19:03:53 +0100 Marek Olšák mar...@gmail.com wrote: On Wed, Jan 8, 2014 at 6:21 PM, Lauri Kasanen c...@gmx.com wrote: On Wed, 8 Jan 2014 15:54:04 +0100 Marek Olšák mar...@gmail.com wrote: It's not accurate at all, it's actually pretty random. The stats should not be

Re: [Mesa-dev] [PATCH 2/2] demos/pixeltest: Adapt the example for points too.

2014-01-08 Thread Brian Paul
On 01/08/2014 10:30 AM, jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com This example is very useful to understand the rasterization of lines. And with this change, points too. Adding a key / command-line option to switch modes is left for a future opportunity though. For

Re: [Mesa-dev] [PATCH 1/7] mesa: handle GL_NONE draw buffers correctly in glClear

2014-01-08 Thread Brian Paul
On 01/08/2014 10:23 AM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com --- src/mesa/main/clear.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/clear.c b/src/mesa/main/clear.c index f0b525f..fd5bb35 100644 --- a/src/mesa/main/clear.c +++

[Mesa-dev] [PATCH 2/5] mesa: Index into ctx-Const.Program[] rather than using ad-hoc code.

2014-01-08 Thread Paul Berry
--- src/mesa/program/program.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c index df4d75f..3c19e8c 100644 --- a/src/mesa/program/program.c +++ b/src/mesa/program/program.c @@ -896,21 +896,8 @@

[Mesa-dev] [PATCH 4/5] main: Change init_program_limits() to use gl_shader_stage.

2014-01-08 Thread Paul Berry
This allows the caller to execute it in a loop rather than hand-rolling a separate call for each stage. --- src/mesa/main/context.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index cfebbd2..0b8fb94

[Mesa-dev] [PATCH 3/5] glsl: Index into ctx-Const.Program[] rather than using ad-hoc code.

2014-01-08 Thread Paul Berry
--- src/glsl/ast_to_hir.cpp| 13 + src/glsl/link_atomics.cpp | 16 ++-- src/glsl/link_varyings.cpp | 32 ++-- src/glsl/linker.cpp| 43 --- 4 files changed, 17 insertions(+), 87 deletions(-)

[Mesa-dev] [PATCH 5/5] mesa: Use functions to convert gl_shader_stage to PROGRAM enum or pipe target.

2014-01-08 Thread Paul Berry
Suggested-by: Brian Paul bri...@vmware.com --- src/mesa/program/ir_to_mesa.cpp| 17 + src/mesa/program/program.h | 18 ++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 40 +++--- 3 files changed, 39 insertions(+), 36

Re: [Mesa-dev] [PATCH 2/7] st/mesa: bind NULL colorbuffers as specified by glDrawBuffers

2014-01-08 Thread Brian Paul
On 01/08/2014 10:23 AM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com An example why it is required: Let's say there's a fragment shader writing to gl_FragData[0..1]. The user calls: glDrawBuffers(2, {GL_NONE, GL_COLOR_ATTACHMENT0}); That means gl_FragData[0] is

Re: [Mesa-dev] [PATCH 3/7] gallium/util: easy fixes for NULL colorbuffers

2014-01-08 Thread Brian Paul
On 01/08/2014 10:23 AM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com --- src/gallium/auxiliary/util/u_clear.h | 4 src/gallium/auxiliary/util/u_framebuffer.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/src/gallium/auxiliary/util/u_clear.h

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Marek Olšák
On Wed, Jan 8, 2014 at 7:54 PM, Lauri Kasanen c...@gmx.com wrote: On Wed, 8 Jan 2014 19:03:53 +0100 Marek Olšák mar...@gmail.com wrote: On Wed, Jan 8, 2014 at 6:21 PM, Lauri Kasanen c...@gmx.com wrote: On Wed, 8 Jan 2014 15:54:04 +0100 Marek Olšák mar...@gmail.com wrote: It's not

Re: [Mesa-dev] [PATCH 1/5] mesa: replace ctx-Const.{Vertex, Fragment, Geomtery}Program with an array.

2014-01-08 Thread Brian Paul
On 01/08/2014 12:20 PM, Paul Berry wrote: These are replaced with ctx-Const.Program[MESA_SHADER_{VERTEX,FRAGMENT,GEOMETRY}]. In patches to follow, this will allow us to replace a lot of ad-hoc logic with a variable index into the array. With the exception of the changes to mtypes.h, this patch

Re: [Mesa-dev] [PATCH 2/7] st/mesa: bind NULL colorbuffers as specified by glDrawBuffers

2014-01-08 Thread Marek Olšák
On Wed, Jan 8, 2014 at 8:21 PM, Brian Paul bri...@vmware.com wrote: On 01/08/2014 10:23 AM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com An example why it is required: Let's say there's a fragment shader writing to gl_FragData[0..1]. The user calls: glDrawBuffers(2,

Re: [Mesa-dev] [PATCH] llvmpipe: Honour pipe_rasterizer::point_quad_rasterization.

2014-01-08 Thread Roland Scheidegger
Am 08.01.2014 19:48, schrieb Marek Olšák: On Wed, Jan 8, 2014 at 7:31 PM, Roland Scheidegger srol...@vmware.com wrote: Am 08.01.2014 19:12, schrieb Jose Fonseca: - Original Message - Am 08.01.2014 18:27, schrieb jfons...@vmware.com: From: José Fonseca jfons...@vmware.com Commit

Re: [Mesa-dev] [PATCH 2/7] st/mesa: bind NULL colorbuffers as specified by glDrawBuffers

2014-01-08 Thread Brian Paul
On 01/08/2014 12:51 PM, Marek Olšák wrote: On Wed, Jan 8, 2014 at 8:21 PM, Brian Paul bri...@vmware.com wrote: On 01/08/2014 10:23 AM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com An example why it is required: Let's say there's a fragment shader writing to

Re: [Mesa-dev] [PATCH 5/5] mesa: Use functions to convert gl_shader_stage to PROGRAM enum or pipe target.

2014-01-08 Thread Emil Velikov
On 08/01/14 19:20, Paul Berry wrote: Suggested-by: Brian Paul bri...@vmware.com --- src/mesa/program/ir_to_mesa.cpp| 17 + src/mesa/program/program.h | 18 ++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 40 +++---

[Mesa-dev] [PATCH 3/5] glsl: Add parameter to .equals() to ignore an IR type.

2014-01-08 Thread Matt Turner
Only implemented for ir_swizzles currently, but perhaps will be useful for other IR types in the future. --- src/glsl/ir.h | 14 +-- src/glsl/ir_equals.cpp | 63 +++--- 2 files changed, 41 insertions(+), 36 deletions(-) diff --git

[Mesa-dev] [PATCH 5/5] i965: Enable AOS optimizations for the geometry shader.

2014-01-08 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index da34e3d..3da328a 100644 --- a/src/mesa/drivers/dri/i965/brw_context.c +++

[Mesa-dev] [PATCH 2/5] mesa: rename PreferDP4 to OptimizeForAOS.

2014-01-08 Thread Matt Turner
This flag was really just a proxy for determining whether the backend was vector (AOS) or scalar (SOA). It will be used to apply a future optimization only for vector backends. --- src/glsl/glsl_parser_extras.cpp | 2 +- src/mesa/drivers/dri/i965/brw_context.c | 2 +-

[Mesa-dev] [PATCH 4/5] glsl: Vectorize multiple scalar assignments

2014-01-08 Thread Matt Turner
Reduces vertex shader instruction counts in DOTA2 by 6.42%, L4D2 by 4.61%, and CS:GO by 5.71%. total instructions in shared programs: 1500153 - 1498191 (-0.13%) instructions in affected programs: 59919 - 57957 (-3.27%) --- src/glsl/Makefile.sources | 1 +

[Mesa-dev] [PATCH 1/5] i965: Extend dead control flow to remove useless ELSE.

2014-01-08 Thread Matt Turner
total instructions in shared programs: 1500212 - 1500153 (-0.00%) instructions in affected programs: 1 - 17718 (-0.33%) --- src/mesa/drivers/dri/i965/brw_dead_control_flow.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [Bug 70410] egl-static/Makefile: linking fails with llvm = 3.4

2014-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70410 Alexander Tsoy alexan...@tsoy.me changed: What|Removed |Added CC||alexan...@tsoy.me --

[Mesa-dev] [Bug 70410] egl-static/Makefile: linking fails with llvm = 3.4

2014-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70410 --- Comment #8 from Armin K kre...@email.com --- llvm-config now has this parameter: --system-libs System Libraries needed to link against LLVM components. And on my system it outputs: -lz -lpthread -lffi -lcurses -ldl -lm This should

Re: [Mesa-dev] [PATCH 1/5] i965: Extend dead control flow to remove useless ELSE.

2014-01-08 Thread Kenneth Graunke
On 01/08/2014 12:43 PM, Matt Turner wrote: total instructions in shared programs: 1500212 - 1500153 (-0.00%) instructions in affected programs: 1 - 17718 (-0.33%) --- src/mesa/drivers/dri/i965/brw_dead_control_flow.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[Mesa-dev] [PATCH 1/3] i965: Add masks for more SURFACE_STATE fields

2014-01-08 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_defines.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dri/i965/brw_defines.h index 0fc24a7..358a404 100644 ---

[Mesa-dev] [PATCH 2/3] i965: Improve dumping of Gen7 SURFACE_STATE

2014-01-08 Thread Chris Forbes
Previously this was missing many interesting fields. Having them decoded makes debugging views much easier. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_state_dump.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 3/3] i965/Gen7: Only emit cube face enables for cubes.

2014-01-08 Thread Chris Forbes
This is not observed to actually fix anything, but the PRM says this field must be zero for other surface types. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/5] mesa: replace ctx-Const.{Vertex, Fragment, Geomtery}Program with an array.

2014-01-08 Thread Kenneth Graunke
On 01/08/2014 11:20 AM, Paul Berry wrote: These are replaced with ctx-Const.Program[MESA_SHADER_{VERTEX,FRAGMENT,GEOMETRY}]. In patches to follow, this will allow us to replace a lot of ad-hoc logic with a variable index into the array. With the exception of the changes to mtypes.h, this

Re: [Mesa-dev] [PATCH 1/5] i965: Extend dead control flow to remove useless ELSE.

2014-01-08 Thread Matt Turner
On Wed, Jan 8, 2014 at 1:00 PM, Kenneth Graunke kenn...@whitecape.org wrote: On 01/08/2014 12:43 PM, Matt Turner wrote: total instructions in shared programs: 1500212 - 1500153 (-0.00%) instructions in affected programs: 1 - 17718 (-0.33%) ---

Re: [Mesa-dev] [PATCH] llvmpipe: Honour pipe_rasterizer::point_quad_rasterization.

2014-01-08 Thread Marek Olšák
We have this edge rule state for points. It has 4 bits called Left, Right, Top, Bottom. 1 means in, 0 means out. It probably determines what happens if a primitive edge intersects a pixel or something like that. We set Left=0, Right=1, Top=0, Bottom=1. We also have this state: ROUND_MODE

Re: [Mesa-dev] [PATCH 3/3] i965/Gen7: Only emit cube face enables for cubes.

2014-01-08 Thread Jordan Justen
Series Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On Wed, Jan 8, 2014 at 1:11 PM, Chris Forbes chr...@ijw.co.nz wrote: This is not observed to actually fix anything, but the PRM says this field must be zero for other surface types. Signed-off-by: Chris Forbes chr...@ijw.co.nz ---

Re: [Mesa-dev] [PATCH 2/5] mesa: rename PreferDP4 to OptimizeForAOS.

2014-01-08 Thread Brian Paul
On 01/08/2014 01:43 PM, Matt Turner wrote: This flag was really just a proxy for determining whether the backend was vector (AOS) or scalar (SOA). It will be used to apply a future optimization only for vector backends. --- src/glsl/glsl_parser_extras.cpp | 2 +-

[Mesa-dev] [Bug 70410] egl-static/Makefile: linking fails with llvm = 3.4

2014-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70410 --- Comment #9 from Krzysztof A. Sobiecki sob...@gmail.com --- (In reply to comment #8) llvm-config now has this parameter: --system-libs System Libraries needed to link against LLVM components. And on my system it outputs: -lz

[Mesa-dev] [Bug 70410] egl-static/Makefile: linking fails with llvm = 3.4

2014-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70410 --- Comment #10 from Armin K kre...@email.com --- Same here, but I use llvm-3.4 release. You could easily strip the new line using sed or whatever. -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 70410] egl-static/Makefile: linking fails with llvm = 3.4

2014-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70410 --- Comment #11 from Armin K kre...@email.com --- llvm-config --ldflags -L/usr/lib -lz -lpthread -lffi -lcurses -ldl -lm There's also this command which doesn't add new line, at least not here. -- You are receiving this mail because: You are

[Mesa-dev] [Bug 70410] egl-static/Makefile: linking fails with llvm = 3.4

2014-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70410 --- Comment #12 from Armin K kre...@email.com --- Oh, I'm sorry for multiple posts. Seems that I've downgraded to llvm-3.4 but I was using 3.5 snapshot and that's why --ldflags works for me as it is - there's no --system-libs option. You could

Re: [Mesa-dev] [PATCH 03/10] i965: Create a helper function for emitting PIPE_CONTROL flushes.

2014-01-08 Thread Chris Forbes
+ OUT_BATCH(0); + ADVANCE_BATCH(); + } else { + BEGIN_BATCH(4); + OUT_BATCH(_3DSTATE_PIPE_CONTROL | flags | (4 - 2)); If the PRM is to believed, then ILK has two of its flag bits in dw1 [Stall at scoreboard, and the nonfunctional depth cache flush inhibit]; it looks as

[Mesa-dev] [PATCH] mesa: check bits per channel for GL_RGBA_SIGNED_COMPONENTS_EXT query

2014-01-08 Thread Brian Paul
If a channel has zero bits it's not signed. v2: also check for luminance and intensity format bits. Bruce Merry's proposed piglit test hits the luminance case. Bugzilla: http://bugs.freedesktop.org/show_bug.cgi?id=73096 Cc: 10.0 mesa-sta...@lists.freedesktop.org --- src/mesa/main/get.c | 37

[Mesa-dev] [PATCH] mesa: add missing SNORM formats in _mesa_base_fbo_format()

2014-01-08 Thread Brian Paul
We weren't handling the LUMINANCE_SNORM, LUMINANCE_ALPHA_SNORM and INTENSITY_SNORM cases. Note that adding these cases here does not require a driver to support rendering to these surface types. If the driver can't do it we'll report an incomplete framebuffer. NVIDIA doesn't support

[Mesa-dev] [PATCH] mesa: remove dead geom shader code

2014-01-08 Thread Brian Paul
I doubt the swrast-based drivers will ever support GS. Signed-off-by: Brian Paul bri...@vmware.com --- src/mesa/main/extensions.c |4 1 file changed, 4 deletions(-) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index efda548..89d4793 100644 ---

[Mesa-dev] [Bug 70410] egl-static/Makefile: linking fails with llvm = 3.4

2014-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70410 --- Comment #13 from Krzysztof A. Sobiecki sob...@gmail.com --- Created attachment 91725 -- https://bugs.freedesktop.org/attachment.cgi?id=91725action=edit Another patch, with newline hack llvm-config --ldflags: -L/usr/lib/llvm-3.5/lib Needed

Re: [Mesa-dev] [PATCH] mesa: remove dead geom shader code

2014-01-08 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: check bits per channel for GL_RGBA_SIGNED_COMPONENTS_EXT query

2014-01-08 Thread Matt Turner
On Wed, Jan 8, 2014 at 4:37 PM, Brian Paul bri...@vmware.com wrote: If a channel has zero bits it's not signed. v2: also check for luminance and intensity format bits. Bruce Merry's proposed piglit test hits the luminance case. Bugzilla: http://bugs.freedesktop.org/show_bug.cgi?id=73096

[Mesa-dev] [Bug 70410] egl-static/Makefile: linking fails with llvm = 3.4

2014-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70410 Krzysztof A. Sobiecki sob...@gmail.com changed: What|Removed |Added CC||sob...@gmail.com

Re: [Mesa-dev] [PATCH 4/7] radeonsi: handle NULL colorbuffers correctly

2014-01-08 Thread Michel Dänzer
On Mit, 2014-01-08 at 18:23 +0100, Marek Olšák wrote: diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 3666a11..ba73401 100644 --- a/src/gallium/drivers/radeonsi/si_state.c +++ b/src/gallium/drivers/radeonsi/si_state.c [...] @@ -2136,16

Re: [Mesa-dev] [PATCH 2/7] i965: Don't call the blitter on addresses it can't handle.

2014-01-08 Thread Eric Anholt
Ian Romanick i...@freedesktop.org writes: On 12/23/2013 04:08 PM, Eric Anholt wrote: Noticed by tex3d-maxsize on my next commit to check that our addresses don't overflow. Should this also go to stable branches? I'm a little wary of picking this back because of some cases where we assert