[Mesa-dev] [Bug 75503] DispatchSanity_test.GL31_CORE regression

2014-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75503 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] i965: Don't try to dump shader source for fixed-function FS programs.

2014-02-25 Thread Eric Anholt
Kenneth Graunke writes: > sh->Source is NULL and this will segfault. > > Fixes MESA_GLSL=dump with "The Swapper". Reviewed-by: Eric Anholt pgp_aeDPJO0A4.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://l

Re: [Mesa-dev] [PATCH 2/4] i965/vec4: Handle ir_triop_lrp on Gen4-5 as well.

2014-02-25 Thread Eric Anholt
Kenneth Graunke writes: > On 02/25/2014 09:38 AM, Eric Anholt wrote: >> Matt Turner writes: >> >>> On Mon, Feb 24, 2014 at 10:15 AM, Eric Anholt wrote: I think we would do better by emitting ADD(y_minus_x, y, negate(x)) MAC(dst, x, y_minus_x, a) >>> >>> MAC only takes two argume

[Mesa-dev] [Bug 75226] Dark rendering of War for the Overworld

2014-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75226 --- Comment #14 from Chia-I Wu --- (In reply to comment #12) > Created attachment 94581 [details] [review] > Use linear formats for TFP textures > > After restarting the compositor with the sRGB patches applied, I realized > that we need this ch

[Mesa-dev] [PATCH] i965: Don't try to dump shader source for fixed-function FS programs.

2014-02-25 Thread Kenneth Graunke
sh->Source is NULL and this will segfault. Fixes MESA_GLSL=dump with "The Swapper". Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_shader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH v3 2/2] R600/SI: Optimize SI_KILL for constant operands

2014-02-25 Thread Michel Dänzer
From: Michel Dänzer If the SI_KILL operand is constant, we can either clear the exec mask if the operand is negative, or do nothing otherwise. Signed-off-by: Michel Dänzer --- v3: * Use VSrc_32 for the SI_KILL operand. * Drop unused Depth parameter from SILowerControlFlowPass::Kill(). * Use lo

Re: [Mesa-dev] [PATCH v2 2/2] R600/SI: Optimize SI_KILL for constant operands

2014-02-25 Thread Michel Dänzer
On Die, 2014-02-25 at 11:51 -0500, Tom Stellard wrote: > On Tue, Feb 25, 2014 at 07:36:47PM +0900, Michel Dänzer wrote: > > From: Michel Dänzer > > > > If the SI_KILL operand is constant, we can either clear the exec mask if > > the operand is negative, or do nothing otherwise. > > > > Signed-of

Re: [Mesa-dev] [PATCH 2/7] r600g, radeonsi: use current domain for deciding when to do blit-based transfer

2014-02-25 Thread Michel Dänzer
On Die, 2014-02-25 at 15:58 +0100, Marek Olšák wrote: > Okay, I'll drop the patch. It's not too important anyway. Okay, the rest of the series looks good to me. -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast |Mesa a

Re: [Mesa-dev] Mesa (master): clover: Fix build with LLVM 3.5

2014-02-25 Thread Michel Dänzer
On Die, 2014-02-25 at 13:33 -0800, Tom Stellard wrote: > > diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp > b/src/gallium/state_trackers/clover/llvm/invocation.cpp > index e826669..cdf32b6 100644 > --- a/src/gallium/state_trackers/clover/llvm/invocation.cpp > +++ b/src/gallium

[Mesa-dev] [PATCH 2/2] i965: Fix build warning of unused variable

2014-02-25 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp index acdc9c7..22a4a07 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp_bli

[Mesa-dev] [PATCH 1/2] glsl: Fix build warning of unhandled case in switch

2014-02-25 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/glsl/ast_to_hir.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index f06baeb..8af 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -2221,6 +2221,11 @@ validate_explicit_loca

Re: [Mesa-dev] [PATCH V2 3/4] glsl: Link error if fs defines conflicting qualifiers for gl_FragCoord

2014-02-25 Thread Anuj Phogat
On Tue, Feb 25, 2014 at 5:02 PM, Anuj Phogat wrote: > On Tue, Feb 25, 2014 at 9:14 AM, Ian Romanick wrote: >> On 02/24/2014 05:34 PM, Anuj Phogat wrote: >>> GLSL 1.50 spec says: >>> "If gl_FragCoord is redeclared in any fragment shader in a program, >>> it must be redeclared in all the f

Re: [Mesa-dev] [PATCH 2/4] i965/vec4: Handle ir_triop_lrp on Gen4-5 as well.

2014-02-25 Thread Kenneth Graunke
On 02/25/2014 09:38 AM, Eric Anholt wrote: > Matt Turner writes: > >> On Mon, Feb 24, 2014 at 10:15 AM, Eric Anholt wrote: >>> I think we would do better by emitting >>> ADD(y_minus_x, y, negate(x)) >>> MAC(dst, x, y_minus_x, a) >> >> MAC only takes two arguments, so >> - if you meant MAD, ther

Re: [Mesa-dev] [PATCH V2 3/4] glsl: Link error if fs defines conflicting qualifiers for gl_FragCoord

2014-02-25 Thread Anuj Phogat
On Tue, Feb 25, 2014 at 9:14 AM, Ian Romanick wrote: > On 02/24/2014 05:34 PM, Anuj Phogat wrote: >> GLSL 1.50 spec says: >> "If gl_FragCoord is redeclared in any fragment shader in a program, >> it must be redeclared in all the fragment shaders in that >> program that have a static

Re: [Mesa-dev] [PATCH 4/4] glsl: Delete LRP_TO_ARITH lowering pass flag.

2014-02-25 Thread Kenneth Graunke
On 02/24/2014 09:55 AM, Ian Romanick wrote: > On 02/23/2014 07:19 PM, Kenneth Graunke wrote: >> Tt's kind of a trap---calling do_common_optimization() after >> lower_instructions() may cause opt_algebraic() to reintroduce >> ir_triop_lrp expressions that were lowered, effectively defeating the >> p

Re: [Mesa-dev] [PATCH] R600: Verify all instructions in the AsmPrinter on debug builds

2014-02-25 Thread Tom Stellard
I think I'll just drop the bug report url entirely. All R600 bugs so far have been reported to bugs.freedesktop.org, and I'm not sure bugs filed at llvm.org/bugs will get the same level of attention. -Tom On Tue, Feb 25, 2014 at 02:35:32PM -0800, Eric Christopher wrote: > Yep. Pretty sure. > >

Re: [Mesa-dev] [PATCH V2 1/4] glsl: Compile error if fs defines conflicting qualifiers for gl_FragCoord

2014-02-25 Thread Ian Romanick
On 02/25/2014 01:39 PM, Anuj Phogat wrote: On Tue, Feb 25, 2014 at 7:43 AM, Ian Romanick wrote: On 02/24/2014 05:34 PM, Anuj Phogat wrote: GLSL 1.50 spec says: "If gl_FragCoord is redeclared in any fragment shader in a program, it must be redeclared in all the fragment shaders in th

Re: [Mesa-dev] [PATCH V2 2/4] glsl: Compile error if fs uses gl_FragCoord before first redeclaration

2014-02-25 Thread Ian Romanick
On 02/25/2014 01:15 PM, Anuj Phogat wrote: On Tue, Feb 25, 2014 at 7:47 AM, Ian Romanick wrote: On 02/24/2014 05:34 PM, Anuj Phogat wrote: Section 4.3.8.1, page 39 of GLSL 1.50 spec says: "Within any shader, the first redeclarations of gl_FragCoord must appear before any use of gl_F

Re: [Mesa-dev] [PATCH] R600: Verify all instructions in the AsmPrinter on debug builds

2014-02-25 Thread Eric Christopher
Yep. Pretty sure. -eric On Tue, Feb 25, 2014 at 2:30 PM, Matt Arsenault wrote: > On 02/25/2014 02:01 PM, Eric Christopher wrote: >> >> Also it probably shouldn't reference an external bug reporter. >> >> -eric > > > There's a build configure bug report URL you could use (which is where I > assum

[Mesa-dev] Piglit - GL/GLSL tests - GSoC 2014

2014-02-25 Thread Chirag Agrawal
Hey! I am Chirag. I am currently part of a dual degree program (5yr) at Birla Institute of Technology & Science, Pilani - Goa Campus, India. I am in my 4th year as a candidate for a master's degree in Mathematics and a bachelor's degree in Computer Science. My programming expertise includes profi

Re: [Mesa-dev] Accidental Mesa revert

2014-02-25 Thread Timothy Arceri
Thanks for the tip. On Wednesday, 26 February 2014 9:46 AM, Marek Olšák wrote: I recommend always using "git pull --rebase --stat" to avoid unnecessary merges. Marek On Tue, Feb 25, 2014 at 11:26 PM, Timothy Arceri wrote: > Hi Tom, > > I managed to accidentally revert your commit: > http

Re: [Mesa-dev] [PATCH] R600: Verify all instructions in the AsmPrinter on debug builds

2014-02-25 Thread Eric Christopher
Also it probably shouldn't reference an external bug reporter. -eric On Tue, Feb 25, 2014 at 1:54 PM, Tom Stellard wrote: > On Tue, Feb 25, 2014 at 01:47:17PM -0800, Matt Arsenault wrote: >> On 02/25/2014 01:42 PM, Tom Stellard wrote: >> > +errs() << "Please file a bug a bugs.freedesktop.org

Re: [Mesa-dev] [PATCH] R600: Verify all instructions in the AsmPrinter on debug builds

2014-02-25 Thread Matt Arsenault
On 02/25/2014 02:01 PM, Eric Christopher wrote: Also it probably shouldn't reference an external bug reporter. -eric There's a build configure bug report URL you could use (which is where I assume the llvm.org/bugs link comes from in the output from a crash) On Tue, Feb 25, 2014 at 1:54 PM,

Re: [Mesa-dev] [PATCH] R600: Verify all instructions in the AsmPrinter on debug builds

2014-02-25 Thread Matt Arsenault
On 02/25/2014 01:42 PM, Tom Stellard wrote: +errs() << "Please file a bug a bugs.freedesktop.org\n"; Typo, s/a/at/ ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: fix make check for ARB_buffer_storage

2014-02-25 Thread Ian Romanick
Vinson already beat you to the identical patch: f094866. On 02/25/2014 02:20 PM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/main/tests/dispatch_sanity.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_s

Re: [Mesa-dev] Accidental Mesa revert

2014-02-25 Thread Marek Olšák
I recommend always using "git pull --rebase --stat" to avoid unnecessary merges. Marek On Tue, Feb 25, 2014 at 11:26 PM, Timothy Arceri wrote: > Hi Tom, > > I managed to accidentally revert your commit: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=fcd499730b225ec5a35902893c059086ba11b590 >

Re: [Mesa-dev] Accidental Mesa revert

2014-02-25 Thread Tom Stellard
On Tue, Feb 25, 2014 at 02:26:34PM -0800, Timothy Arceri wrote: > Hi Tom, > > I managed to accidentally revert your commit: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=fcd499730b225ec5a35902893c059086ba11b590 > > I managed to commit the same change: > http://cgit.freedesktop.org/mesa/mes

Re: [Mesa-dev] [PATCH] mesa: fix make check for ARB_buffer_storage

2014-02-25 Thread Marek Olšák
It's actually an extension, so it should be available with any version. I don't know. This is the first time I'm modifying the test. Marek On Tue, Feb 25, 2014 at 11:34 PM, Ilia Mirkin wrote: > Seems oddly reminiscent of > http://cgit.freedesktop.org/mesa/mesa/commit/?id=f094866d93b772cc91844e01

Re: [Mesa-dev] [PATCH] mesa: fix make check for ARB_buffer_storage

2014-02-25 Thread Ilia Mirkin
Seems oddly reminiscent of http://cgit.freedesktop.org/mesa/mesa/commit/?id=f094866d93b772cc91844e012ad07ce4a78fda5d (although that change had 43 instead of 11 -- i guess that's the gl version?) On Tue, Feb 25, 2014 at 5:20 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/main/test

[Mesa-dev] Accidental Mesa revert

2014-02-25 Thread Timothy Arceri
Hi Tom, I managed to accidentally revert your commit: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fcd499730b225ec5a35902893c059086ba11b590 I managed to commit the same change: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1b79582f322d4a89dd6d197c8d4962c788ae7f25 Then panicked and revert

[Mesa-dev] [PATCH] mesa: fix make check for ARB_buffer_storage

2014-02-25 Thread Marek Olšák
From: Marek Olšák --- src/mesa/main/tests/dispatch_sanity.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp index 117a570..dbcd4ab 100644 --- a/src/mesa/main/tests/dispatch_sanity.cpp +++ b/src/mesa/main/

Re: [Mesa-dev] [PATCH] R600: Verify all instructions in the AsmPrinter on debug builds

2014-02-25 Thread Tom Stellard
On Tue, Feb 25, 2014 at 01:47:17PM -0800, Matt Arsenault wrote: > On 02/25/2014 01:42 PM, Tom Stellard wrote: > > +errs() << "Please file a bug a bugs.freedesktop.org\n"; > Typo, s/a/at/ > Thanks, I will fix this before I commit. -Tom > ___ > llvm

[Mesa-dev] [PATCH] R600/SI: Expand all v16[if]32 operations

2014-02-25 Thread Tom Stellard
--- lib/Target/R600/SIISelLowering.cpp | 2 +- test/CodeGen/R600/add.ll | 40 ++ 2 files changed, 41 insertions(+), 1 deletion(-) diff --git a/lib/Target/R600/SIISelLowering.cpp b/lib/Target/R600/SIISelLowering.cpp index ffa42b8..3b7043a 100644 ---

[Mesa-dev] [PATCH] R600: Verify all instructions in the AsmPrinter on debug builds

2014-02-25 Thread Tom Stellard
Make a call to R600's implementation of verifyInstruction() to check that instructions are only using legal operands. --- lib/Target/R600/AMDGPUMCInstLower.cpp | 8 1 file changed, 8 insertions(+) diff --git a/lib/Target/R600/AMDGPUMCInstLower.cpp b/lib/Target/R600/AMDGPUMCInstLower.cpp

Re: [Mesa-dev] [PATCH V2 1/4] glsl: Compile error if fs defines conflicting qualifiers for gl_FragCoord

2014-02-25 Thread Anuj Phogat
On Tue, Feb 25, 2014 at 7:43 AM, Ian Romanick wrote: > On 02/24/2014 05:34 PM, Anuj Phogat wrote: >> GLSL 1.50 spec says: >> "If gl_FragCoord is redeclared in any fragment shader in a program, >> it must be redeclared in all the fragment shaders in that >> program that have a static

[Mesa-dev] [PATCH] util/u_format: don't crash in util_format_translate if we can't do translation

2014-02-25 Thread sroland
From: Roland Scheidegger Some formats can't be handled - in particular cannot handle ints/uints formats, which lack the pack_rgba_float/unpack_rgba_float functions. Instead of trying to call these (and crash) return an error (I'm not sure yet if we should try to translate such formats too here mi

Re: [Mesa-dev] [PATCH V2 2/4] glsl: Compile error if fs uses gl_FragCoord before first redeclaration

2014-02-25 Thread Anuj Phogat
On Tue, Feb 25, 2014 at 7:47 AM, Ian Romanick wrote: > > On 02/24/2014 05:34 PM, Anuj Phogat wrote: >> >> Section 4.3.8.1, page 39 of GLSL 1.50 spec says: >>"Within any shader, the first redeclarations of gl_FragCoord >> must appear before any use of gl_FragCoord." >> >> GLSL compiler shou

[Mesa-dev] [Bug 75505] [clover] Build failure with clang 3.4 and libc++

2014-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75505 Francisco Jerez changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] mesa: Add GL_ARB_buffer_storage to dispatch_sanity.cpp.

2014-02-25 Thread Ian Romanick
On 02/25/2014 12:22 PM, Vinson Lee wrote: Fixes 'make check' failure introduced with commit 119ffa7307d62e7310ce3902fded662ee4021c92. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75503 Signed-off-by: Vinson Lee Reviewed-by: Ian Romanick --- src/mesa/main/tests/dispatch_sanity.c

[Mesa-dev] [PATCH] mesa: Add GL_ARB_buffer_storage to dispatch_sanity.cpp.

2014-02-25 Thread Vinson Lee
Fixes 'make check' failure introduced with commit 119ffa7307d62e7310ce3902fded662ee4021c92. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75503 Signed-off-by: Vinson Lee --- src/mesa/main/tests/dispatch_sanity.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/test

[Mesa-dev] [PATCH 2/2] i965: Convert VUE map generation checks to if rather than switch.

2014-02-25 Thread Kenneth Graunke
There are currently only two VUE map layouts: one for Gen4-5, and one for everything else. We keep having to add new "case N+1" labels for every new hardware generation, and so far it's always been the same. This patch makes it so we only have to do work in the case where something actually chang

[Mesa-dev] [PATCH 1/2] i965: Only emit VS state pipe control workaround on IVB and BYT.

2014-02-25 Thread Kenneth Graunke
According to the BSpec's 3D workarounds page, this is unnecessary on shipping Haswell hardware, and was never necessary on Broadwell. It unfortunately doesn't say anything about Baytrail. The workaround database confirms those results for Ivybridge, Haswell, and Broadwell. Baytrail is less clear

[Mesa-dev] [Bug 75505] [clover] Build failure with clang 3.4 and libc++

2014-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75505 --- Comment #1 from Jean-Sébastien Pédron --- I found out a difference between GCC's "functional" header and libc++'s one: - in GCC, all "operator()" methods are const: operator()(...) const - in libc++, they aren't: operator() (_Ar

[Mesa-dev] [PATCH] glsl: add switch case for MESA_SHADER_COMPUTE

2014-02-25 Thread Brian Paul
To fix warning about unhandled enum value. --- src/glsl/ast_to_hir.cpp |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index f06baeb..8f6e901 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -2221,6 +2221,9 @@ validat

Re: [Mesa-dev] [PATCH] st/mesa: add comment to explain _min(), _maxf(), etc. functions

2014-02-25 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Feb 25, 2014 at 5:54 PM, Brian Paul wrote: > --- > src/mesa/state_tracker/st_extensions.c |6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/mesa/state_tracker/st_extensions.c > b/src/mesa/state_tracker/st_extensions.c > index 47b975b.

Re: [Mesa-dev] [PATCH] libgl-xlib: add -Isrc/gallium/winsys flag

2014-02-25 Thread Emil Velikov
On 25/02/14 16:59, Brian Paul wrote: > So that sw/xlib/xlib_sw_winsys.h can be found. Fixes a build break. > --- That one is my fault, sorry for that Brian. Reviewed-by: Emil Velikov > src/gallium/targets/libgl-xlib/Makefile.am |1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/ga

[Mesa-dev] [Bug 75505] New: [clover] Build failure with clang 3.4 and libc++

2014-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75505 Priority: medium Bug ID: 75505 Assignee: mesa-dev@lists.freedesktop.org Summary: [clover] Build failure with clang 3.4 and libc++ Severity: normal Classification: Unclassified

Re: [Mesa-dev] [RFC PATCH] i965/gs: add snb support

2014-02-25 Thread Fabian Bieler
On 2014-02-24 20:59, Paul Berry wrote: On 24 February 2014 00:36, Ilia Mirkin mailto:imir...@alum.mit.edu>> wrote: Before you read any further, this is nowhere close to working. However it's in a state where I think most of the structure is there, albeit with a lot of XXX com

Re: [Mesa-dev] [PATCH 2/4] i965/vec4: Handle ir_triop_lrp on Gen4-5 as well.

2014-02-25 Thread Eric Anholt
Matt Turner writes: > On Mon, Feb 24, 2014 at 10:15 AM, Eric Anholt wrote: >> I think we would do better by emitting >> ADD(y_minus_x, y, negate(x)) >> MAC(dst, x, y_minus_x, a) > > MAC only takes two arguments, so > - if you meant MAD, there's no MAD on platforms that don't have LRP > - if yo

[Mesa-dev] [Bug 75503] New: DispatchSanity_test.GL31_CORE regression

2014-02-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75503 Priority: medium Bug ID: 75503 Keywords: regression CC: fred...@kde.org, mar...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: DispatchSanity_test.GL31_CORE regressi

Re: [Mesa-dev] [PATCH 21/25] gallium/r300/r600/radeonsi: handle query_renderer caps

2014-02-25 Thread Ian Romanick
On 02/21/2014 07:04 PM, Emil Velikov wrote: Signed-off-by: Emil Velikov --- src/gallium/drivers/r300/r300_screen.c | 12 src/gallium/drivers/r600/r600_pipe.c | 12 src/gallium/drivers/radeonsi/si_pipe.c | 12 3 files changed, 36 insertions(+) diff -

Re: [Mesa-dev] [PATCH V2 3/4] glsl: Link error if fs defines conflicting qualifiers for gl_FragCoord

2014-02-25 Thread Ian Romanick
On 02/24/2014 05:34 PM, Anuj Phogat wrote: > GLSL 1.50 spec says: > "If gl_FragCoord is redeclared in any fragment shader in a program, > it must be redeclared in all the fragment shaders in that > program that have a static use gl_FragCoord. All redeclarations of > gl_FragCoord

[Mesa-dev] [PATCH] libgl-xlib: add -Isrc/gallium/winsys flag

2014-02-25 Thread Brian Paul
So that sw/xlib/xlib_sw_winsys.h can be found. Fixes a build break. --- src/gallium/targets/libgl-xlib/Makefile.am |1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/targets/libgl-xlib/Makefile.am b/src/gallium/targets/libgl-xlib/Makefile.am index ecbf262..3753e8a 100644 --- a/sr

[Mesa-dev] [PATCH] st/mesa: add comment to explain _min(), _maxf(), etc. functions

2014-02-25 Thread Brian Paul
--- src/mesa/state_tracker/st_extensions.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 47b975b..727fb1a 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_tracker/st_extens

Re: [Mesa-dev] [PATCH v2 2/2] R600/SI: Optimize SI_KILL for constant operands

2014-02-25 Thread Tom Stellard
On Tue, Feb 25, 2014 at 07:36:47PM +0900, Michel Dänzer wrote: > From: Michel Dänzer > > If the SI_KILL operand is constant, we can either clear the exec mask if > the operand is negative, or do nothing otherwise. > > Signed-off-by: Michel Dänzer > --- > > v2: > * Use just 'SI' as the lit test

Re: [Mesa-dev] [PATCH v2 1/2] R600/SI: Allow SI_KILL for geometry shaders

2014-02-25 Thread Tom Stellard
On Tue, Feb 25, 2014 at 07:36:46PM +0900, Michel Dänzer wrote: > From: Michel Dänzer > > Signed-off-by: Michel Dänzer Reviewed-by: Tom Stellard > --- > > v2: > * Bail in SILowerControlFlowPass::SkipIfDead() for geometry shaders, as > the backend can't ensure M0 contains the proper value fo

Re: [Mesa-dev] [PATCH V2 2/4] glsl: Compile error if fs uses gl_FragCoord before first redeclaration

2014-02-25 Thread Ian Romanick
On 02/24/2014 05:34 PM, Anuj Phogat wrote: Section 4.3.8.1, page 39 of GLSL 1.50 spec says: "Within any shader, the first redeclarations of gl_FragCoord must appear before any use of gl_FragCoord." GLSL compiler should generate an error in following case: vec4 p = gl_FragCoord; layout(or

Re: [Mesa-dev] [PATCH V2 1/4] glsl: Compile error if fs defines conflicting qualifiers for gl_FragCoord

2014-02-25 Thread Ian Romanick
On 02/24/2014 05:34 PM, Anuj Phogat wrote: > GLSL 1.50 spec says: > "If gl_FragCoord is redeclared in any fragment shader in a program, > it must be redeclared in all the fragment shaders in that > program that have a static use gl_FragCoord. All redeclarations of > gl_FragCoord

Re: [Mesa-dev] [PATCH 2/7] r600g, radeonsi: use current domain for deciding when to do blit-based transfer

2014-02-25 Thread Marek Olšák
Okay, I'll drop the patch. It's not too important anyway. Marek On Tue, Feb 25, 2014 at 3:54 AM, Michel Dänzer wrote: > On Die, 2014-02-25 at 00:48 +0100, Marek Olšák wrote: >> >> diff --git a/src/gallium/drivers/radeon/r600_texture.c >> b/src/gallium/drivers/radeon/r600_texture.c >> index 35ad

[Mesa-dev] [PATCH 3/8] mesa: Prevent negative indexing on noise2, noise3 and noise4

2014-02-25 Thread Juha-Pekka Heikkila
% operator could return negative value which would cause indexing before perm table. Change %256 to &0xff Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/prog_noise.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/mesa/progr

[Mesa-dev] [PATCH 8/8] mesa: In emit_texenv() type mismatch was forced with typecast

2014-02-25 Thread Juha-Pekka Heikkila
Type mismatch caused random memory to be copied when casted memory area was smaller than expected type. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/ff_fragment_shader.cpp | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/ff_fragment_shad

[Mesa-dev] [PATCH 4/8] mesa: Add missing null check in _mesa_parse_arb_program()

2014-02-25 Thread Juha-Pekka Heikkila
Add missing null check in program_parse.tab.c through program_parse.y Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/program_parse.y | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/program/program_parse.y b/src/mesa/program/program_parse.y index 6dde69d..cfc2cfe 100644

[Mesa-dev] [PATCH 7/8] mesa: add extra null checks in vbo_rebase_prims()

2014-02-25 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/vbo/vbo_rebase.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_rebase.c b/src/mesa/vbo/vbo_rebase.c index c700621..dd754e2 100644 --- a/src/mesa/vbo/vbo_rebase.c +++ b/src/mesa/vbo

[Mesa-dev] [PATCH 5/8] mesa: remove redundant running of check_symbol_table()

2014-02-25 Thread Juha-Pekka Heikkila
Nested for loops running through tables against which they finally do an assert were ran also with optimized builds. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/symbol_table.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/program/symbol_table.c b/

[Mesa-dev] [PATCH 6/8] mesa: add missing null checks in _tnl_register_fastpath()

2014-02-25 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/tnl/t_vertex.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/mesa/tnl/t_vertex.c b/src/mesa/tnl/t_vertex.c index b3deac0..b3e70d3 100644 --- a/src/mesa/tnl/t_vertex.c +++ b/src/mesa/tnl/t_vertex.c @@ -83,1

[Mesa-dev] [PATCH 1/8] glx: remove unused __glXClientInfo()

2014-02-25 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glx/glxcmds.c | 13 - 1 file changed, 13 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 38a5262..584d248 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -1388,19 +1388,6 @@ glXQueryServerString(Display * dpy,

[Mesa-dev] [PATCH 0/8] Klocwork related patches again.

2014-02-25 Thread Juha-Pekka Heikkila
The previous set fixed based on Chia-I's and Ian's comments. Hope I did not miss any issue. Patch number eight fixes issue earlier tried in "glsl: Fix memcpy size in ir_constant", this fix the one particular place where the wrong typecast was used. I dropped "mesa: add null checks for callocs in s

[Mesa-dev] [PATCH 2/8] glx: add extra null check in getFBConfigs

2014-02-25 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glx/glxext.c | 4 1 file changed, 4 insertions(+) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 4a195bd..0838cd1 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -677,6 +677,10 @@ static GLboolean psc->serverGLXexts = __g

[Mesa-dev] The X.Org Foundation is an accepted for the GSoC 2014!

2014-02-25 Thread Martin Peres
Hey, open source graphics enthusiasts, Yesterday, Google announced that the X.Org foundation is an accepted organization for the GSoC 2014! If you are a potential mentor and would have a project you would like a student to work on, you can propose a project in the summer of code ideas wiki p

Re: [Mesa-dev] [PATCH 09/25] dri/radeon: create radeon{Vendor, GetRenderer}String helpers

2014-02-25 Thread Marek Olšák
Oh, I get it now. Sorry for the noise. Marek On Tue, Feb 25, 2014 at 1:27 PM, Emil Velikov wrote: > On 24/02/14 20:06, Marek Olšák wrote: >> On Sat, Feb 22, 2014 at 4:03 AM, Emil Velikov >> wrote: >>> To be used by the upcomming GLX_MESA_query_renderer implementation. >>> >>> Signed-off-by: Em

Re: [Mesa-dev] [PATCH 09/25] dri/radeon: create radeon{Vendor, GetRenderer}String helpers

2014-02-25 Thread Emil Velikov
On 24/02/14 20:06, Marek Olšák wrote: > On Sat, Feb 22, 2014 at 4:03 AM, Emil Velikov > wrote: >> To be used by the upcomming GLX_MESA_query_renderer implementation. >> >> Signed-off-by: Emil Velikov >> --- >> .../drivers/dri/radeon/radeon_common_context.c | 50 >> +- >>

Re: [Mesa-dev] [PATCH 3/3] dri3: Add GLX_EXT_buffer_age support

2014-02-25 Thread Adel Gadllah
Am 24.02.2014 19:37, schrieb Eric Anholt: Adel Gadllah writes: --- src/glx/dri2_glx.c | 1 + src/glx/dri3_glx.c | 18 ++ src/glx/dri3_priv.h | 2 ++ src/glx/glx_pbuffer.c | 8 src/glx/glxclient.h | 1 + src/glx/glxextensions.c | 1 + sr

[Mesa-dev] [PATCH v2 2/2] R600/SI: Optimize SI_KILL for constant operands

2014-02-25 Thread Michel Dänzer
From: Michel Dänzer If the SI_KILL operand is constant, we can either clear the exec mask if the operand is negative, or do nothing otherwise. Signed-off-by: Michel Dänzer --- v2: * Use just 'SI' as the lit test prefix. lib/Target/R600/SIInstructions.td | 4 ++-- lib/Target/R600/SILowe

[Mesa-dev] [PATCH v2 1/2] R600/SI: Allow SI_KILL for geometry shaders

2014-02-25 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- v2: * Bail in SILowerControlFlowPass::SkipIfDead() for geometry shaders, as the backend can't ensure M0 contains the proper value for S_SENDMSG by itself. * Use just 'SI' as the lit test prefix. lib/Target/R600/SILowerControlFlow.cpp |

Re: [Mesa-dev] [PATCH 3/4] configure: error out when building xa only with swrast

2014-02-25 Thread Matt Turner
On Mon, Feb 24, 2014 at 3:05 PM, Emil Velikov wrote: > Building to provide accelration using swrast does not make > sense. > > Note: update your build script to explicitly mention svga > in the gallium drivers list, if you are building the vmwgfx > xa library. > > Signed-off-by: Emil Velikov > --