Re: [Mesa-dev] [PATCH v2 12/23] glsl: Validate vertex emission in geometry shaders.

2014-06-19 Thread Iago Toral
On Wed, 2014-06-18 at 13:38 -0700, Ian Romanick wrote: > On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: (...) > > + /* From the ARB_gpu_shader5 spec: > > + * > > + * "Multiple vertex streams are supported only if the output > > primitive > > + *type is declared to b

[Mesa-dev] [PATCH 00/23] Megadrivers galore

2014-06-19 Thread Thomas Helland
I'll give it another whirl tonight, if I can find the time. 19. juni 2014 23:25 skrev "Emil Velikov" følgende: > On 19/06/14 21:35, Thomas Helland wrote: > > Hi, > > > > I tried pulling down your git-branch, and test it out. > > (I'm running Intel graphics on Ivy-Bridge, Arch Linux). > > Using my

Re: [Mesa-dev] [PATCH v2 11/23] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-19 Thread Iago Toral
On Thu, 2014-06-19 at 15:18 -0700, Ian Romanick wrote: > On 06/19/2014 03:37 AM, Iago Toral wrote: > > After having a quick look at ir_to_mesa.cpp and st_glsl_to_tgsi.cpp I > > have some comments and questions about this: > > > > On Wed, 2014-06-18 at 13:31 -0700, Ian Romanick wrote: > >> This pat

Re: [Mesa-dev] [PATCH 01/19] i965: Pass brw into next_offset().

2014-06-19 Thread Kenneth Graunke
On Thursday, June 19, 2014 05:15:06 PM Matt Turner wrote: > This series (my branch has some small updates) passes piglit runs on > BDW and Haswell, with assertions enabled in Mesa. > > Objections to me pushing it? Yeah - let me test it on older platforms first. Assuming that passes, pushing thi

[Mesa-dev] [Bug 54372] GLX_INTEL_swap_event crashes driver when swapping window buffers

2014-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54372 --- Comment #23 from danm...@gmail.com --- Hi, it has been a week since my last ping message and your git repository still doesn't have either of these bug fixes in it. What's the schedule? -- You are receiving this mail because: You are the QA

Re: [Mesa-dev] [PATCH v3 3/3] Add a new capabilities for drivers that can't share buffers

2014-06-19 Thread Giovanni Campagna
2014-06-19 16:16 GMT+02:00 Axel Davy : > On 15/06/2014 07:49, Giovanni Campagna wrote : > >> From: Giovanni Campagna >> >> The kms-dri swrast driver cannot share buffers using the GEM, >> so it must tell the loader to disable extensions relying on >> that, without disabling the image DRI extension

Re: [Mesa-dev] [PATCH 01/19] i965: Pass brw into next_offset().

2014-06-19 Thread Matt Turner
This series (my branch has some small updates) passes piglit runs on BDW and Haswell, with assertions enabled in Mesa. Objections to me pushing it? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mes

Re: [Mesa-dev] [PATCH] glsl: Fix glcpp to properly lex entire "preprocessing numbers"

2014-06-19 Thread Anuj Phogat
On Thu, Jun 12, 2014 at 5:18 PM, Anuj Phogat wrote: > On Thu, Jun 12, 2014 at 3:13 PM, Carl Worth wrote: >> >> The preprocessor defines a notions of a "preprocessing number" that >> starts with either a digit or a decimal point, and continues with zero >> or more of digits, decimal points, identi

Re: [Mesa-dev] [PATCH v2 22/23] mesa: Init Geom.UsesEndPrimitive in shader programs.

2014-06-19 Thread Ian Romanick
On 06/18/2014 11:30 PM, Iago Toral wrote: > On Wed, 2014-06-18 at 13:48 -0700, Ian Romanick wrote: >> I think this patch and 23 should be moved first in the series... the can >> certainly land before the other patches in the series. > > Right. I'll push these two tomorrow if nobody says otherwise

Re: [Mesa-dev] [PATCH v3] i965: Enable vertex streams up to MAX_VERTEX_STREAMS.

2014-06-19 Thread Ian Romanick
Reviewed-by: Ian Romanick On 06/19/2014 05:32 AM, Iago Toral Quiroga wrote: > --- > > I guess this was an implicit reviewed-by with this change, but anyway... :) > > src/mesa/drivers/dri/i965/brw_context.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH v2 11/23] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-19 Thread Ian Romanick
On 06/19/2014 03:37 AM, Iago Toral wrote: > After having a quick look at ir_to_mesa.cpp and st_glsl_to_tgsi.cpp I > have some comments and questions about this: > > On Wed, 2014-06-18 at 13:31 -0700, Ian Romanick wrote: >> This patch should be split into several patches: >> >> 1. Modify ir_emit_ve

[Mesa-dev] [Bug 80254] pipe_loader_sw.c:90: undefined reference to `dri_create_sw_winsys'

2014-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80254 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 80254] pipe_loader_sw.c:90: undefined reference to `dri_create_sw_winsys'

2014-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80254 --- Comment #2 from Emil Velikov --- Sigh linking order is the best. Curious why it fails rather "selectively". Just double-checking the fix and will push that shortly. -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 80254] pipe_loader_sw.c:90: undefined reference to `dri_create_sw_winsys'

2014-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80254 --- Comment #1 from Vinson Lee --- d22b39e4db7d1c54461de97ff4dcb79178be1a84 is the first bad commit commit d22b39e4db7d1c54461de97ff4dcb79178be1a84 Author: Emil Velikov Date: Mon Jun 9 23:37:19 2014 +0100 targets: use GALLIUM_PIPE_LOADER_

[Mesa-dev] [PATCH] glapi: Do not use backtrace on DragonFly.

2014-06-19 Thread Vinson Lee
execinfo.h is not available on DragonFly. Fixes this build error. CC glapi_gentable.lo glapi_gentable.c:44:22: fatal error: execinfo.h: No such file or directory Signed-off-by: Vinson Lee --- src/mapi/glapi/gen/gl_gentable.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH 00/23] Megadrivers galore

2014-06-19 Thread Emil Velikov
On 19/06/14 21:35, Thomas Helland wrote: > Hi, > > I tried pulling down your git-branch, and test it out. > (I'm running Intel graphics on Ivy-Bridge, Arch Linux). > Using my old autogen-line failed. > (It never reached the point where it says to > go ahead and type make to build the stuffs) > Th

[Mesa-dev] [Bug 80254] New: pipe_loader_sw.c:90: undefined reference to `dri_create_sw_winsys'

2014-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80254 Priority: medium Bug ID: 80254 Keywords: regression CC: emil.l.veli...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: pipe_loader_sw.c:90: undefined reference to

Re: [Mesa-dev] [PATCH v2 11/23] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-19 Thread Kenneth Graunke
On Thursday, June 19, 2014 12:37:43 PM Iago Toral wrote: > After having a quick look at ir_to_mesa.cpp and st_glsl_to_tgsi.cpp I > have some comments and questions about this: > > On Wed, 2014-06-18 at 13:31 -0700, Ian Romanick wrote: > > This patch should be split into several patches: > > > > 1

[Mesa-dev] [PATCH 00/23] Megadrivers galore

2014-06-19 Thread Thomas Helland
Hi, I tried pulling down your git-branch, and test it out. (I'm running Intel graphics on Ivy-Bridge, Arch Linux). Using my old autogen-line failed. (It never reached the point where it says to go ahead and type make to build the stuffs) ./autogen.sh --prefix=/usr --sysconfdir=/etc --with-dri-dri

Re: [Mesa-dev] [PATCH v3 3/3] Add a new capabilities for drivers that can't share buffers

2014-06-19 Thread Axel Davy
On 19/06/2014 15:56, Giovanni Campagna wrote : 2014-06-19 16:16 GMT+02:00 Axel Davy : On 15/06/2014 07:49, Giovanni Campagna wrote : From: Giovanni Campagna The kms-dri swrast driver cannot share buffers using the GEM, so it must tell the loader to disable extensions relying on that, without

[Mesa-dev] [PATCH v2] nouveau: dup fd before passing it to device

2014-06-19 Thread Ilia Mirkin
nouveau screens are reused for the same device node. However in the scenario where we create screen 1, screen 2, and then delete screen 1, the surrounding code might also close the original device node. To protect against this, dup the fd and use the dup'd fd in the nouveau_device. Also tell the no

[Mesa-dev] [PATCH] scons: avoid building any piece of i915

2014-06-19 Thread Emil Velikov
Leftover from commit c21fca8bf24. Signed-off-by: Emil Velikov --- src/gallium/SConscript| 11 --- src/gallium/drivers/i915/SConscript | 12 src/gallium/winsys/i915/sw/SConscript | 12 3 files changed, 35 deletions(-) delete mode 100644 src/gal

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Bruno Jimenez
On Thu, 2014-06-19 at 13:39 -0400, Jan Vesely wrote: > On Thu, 2014-06-19 at 18:22 +0200, Bruno Jimenez wrote: > > On Thu, 2014-06-19 at 11:58 -0400, Jan Vesely wrote: > > > On Thu, 2014-06-19 at 08:27 -0700, Tom Stellard wrote: > > > > On Thu, Jun 19, 2014 at 10:21:32AM -0400, Jan Vesely wrote: >

[Mesa-dev] [PATCH 11/12] r600g/compute: Handle failures in compute_memory_pool_finalize

2014-06-19 Thread Bruno Jiménez
From: Jan Vesely Signed-off-by: Jan Vesely CC: Bruno Jimenez --- src/gallium/drivers/r600/evergreen_compute.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/evergreen_compute.c b/src/gallium/drivers/r600/evergreen_compute.c index c0dd0f3..5c11

[Mesa-dev] [PATCH 10/12] r600g/compute: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Bruno Jiménez
From: Jan Vesely The important part is the change of the condition to <= 0. Otherwise the loop gets stuck never actually growing the pool. The change in the aux-need calculation guarantees max 2 iterations, and avoids wasting memory in case a smaller item can't fit into a relatively larger pool.

[Mesa-dev] [PATCH 12/12] r600g/compute: Defer the creation of the temporary resource

2014-06-19 Thread Bruno Jiménez
For the first use of a buffer, we will only need the temporary resource in the case that a user wants to write/map to this buffer. But in the cases where the user creates a buffer to act as an output of a kernel, then we were creating an unneeded resource, because it will contain garbage, and woul

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Jan Vesely
On Thu, 2014-06-19 at 18:22 +0200, Bruno Jimenez wrote: > On Thu, 2014-06-19 at 11:58 -0400, Jan Vesely wrote: > > On Thu, 2014-06-19 at 08:27 -0700, Tom Stellard wrote: > > > On Thu, Jun 19, 2014 at 10:21:32AM -0400, Jan Vesely wrote: > > > > The important part is the change of the condition to <=

Re: [Mesa-dev] Broadcom VC4 project

2014-06-19 Thread Roland Scheidegger
Am 19.06.2014 09:54, schrieb Eric Anholt: > Dave Airlie writes: > >>> >>> I'm working toward building a Mesa driver for Broadcom VC4 (aka >>> Raspberry Pi). At the moment I'm still bringing up the DRM side of >>> things, but I hope to be doing bits of userspace in the next few days. >>> Current

Re: [Mesa-dev] [PATCH v2 11/23] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-19 Thread Ilia Mirkin
On Thu, Jun 19, 2014 at 6:37 AM, Iago Toral wrote: > Regarding st_glsl_to_tgsi.cpp, I think I can use some guidance since I > am not familiar with gallium. Seeing what is being done for other IR > types, I think I need to do something like: > > st_src_reg stream_src = ir->stream->accept(this); > >

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Bruno Jimenez
On Thu, 2014-06-19 at 11:58 -0400, Jan Vesely wrote: > On Thu, 2014-06-19 at 08:27 -0700, Tom Stellard wrote: > > On Thu, Jun 19, 2014 at 10:21:32AM -0400, Jan Vesely wrote: > > > The important part is the change of the condition to <= 0. Otherwise the > > > loop > > > gets stuck never actually gr

[Mesa-dev] [Bug 80243] Mesa and libclc build failure after llvm >= llvm-3.5svn r211259

2014-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80243 --- Comment #1 from Tom Stellard --- Can you send this patch to mesa-dev@lists.freedesktop.org ? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mes

[Mesa-dev] [Bug 80243] New: Mesa and libclc build failure after llvm >= llvm-3.5svn r211259

2014-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80243 Priority: medium Bug ID: 80243 Assignee: mesa-dev@lists.freedesktop.org Summary: Mesa and libclc build failure after llvm >= llvm-3.5svn r211259 Severity: normal Classifi

Re: [Mesa-dev] [PATCH 2/2] r600: Handle failures in compute_memory_pool_finalize

2014-06-19 Thread Jan Vesely
On Thu, 2014-06-19 at 08:34 -0700, Tom Stellard wrote: > On Thu, Jun 19, 2014 at 11:22:28AM -0400, Jan Vesely wrote: > > On Thu, 2014-06-19 at 17:12 +0200, Bruno Jimenez wrote: > > > Hi, > > > > > > To which failure are you refering? Could you please send me a > > > test/program that I can try to

Re: [Mesa-dev] Request for next steps on GL_shader_atomic_counters

2014-06-19 Thread Matt Turner
On Thu, Jun 19, 2014 at 7:30 AM, Aditya Avinash wrote: > Hi, > I have started writing code for GL_shader_atomic_counters[1]. How do I > proceed to the next steps? Mesa already supports GL_ARB_shader_atomic_counters... ___ mesa-dev mailing list mesa-dev@

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Jan Vesely
On Thu, 2014-06-19 at 08:27 -0700, Tom Stellard wrote: > On Thu, Jun 19, 2014 at 10:21:32AM -0400, Jan Vesely wrote: > > The important part is the change of the condition to <= 0. Otherwise the > > loop > > gets stuck never actually growing the pool. > > > > The change in the aux-need calculation

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Jan Vesely
On Thu, 2014-06-19 at 17:27 +0200, Bruno Jimenez wrote: > Hi, > > Thanks for catching this bug! > > Reviewed-by: Bruno Jiménez > > Also, could you please send me a copy of the tests? This got triggered by one of the gegl test. You'll need the attached patches to run gegl git[0] on mesa/clover/

Re: [Mesa-dev] [PATCH 2/2] r600: Handle failures in compute_memory_pool_finalize

2014-06-19 Thread Tom Stellard
On Thu, Jun 19, 2014 at 11:22:28AM -0400, Jan Vesely wrote: > On Thu, 2014-06-19 at 17:12 +0200, Bruno Jimenez wrote: > > Hi, > > > > To which failure are you refering? Could you please send me a > > test/program that I can try to track this down? > > well, the compute_memory_finalize_pending() f

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Bruno Jimenez
Hi, Thanks for catching this bug! Reviewed-by: Bruno Jiménez Also, could you please send me a copy of the tests? On Thu, 2014-06-19 at 10:21 -0400, Jan Vesely wrote: > The important part is the change of the condition to <= 0. Otherwise the loop > gets stuck never actually growing the pool. >

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Tom Stellard
On Thu, Jun 19, 2014 at 10:21:32AM -0400, Jan Vesely wrote: > The important part is the change of the condition to <= 0. Otherwise the loop > gets stuck never actually growing the pool. > > The change in the aux-need calculation guarantees max 2 iterations, and > avoids wasting memory in case a sm

Re: [Mesa-dev] [PATCH 2/2] r600: Handle failures in compute_memory_pool_finalize

2014-06-19 Thread Jan Vesely
On Thu, 2014-06-19 at 17:12 +0200, Bruno Jimenez wrote: > Hi, > > To which failure are you refering? Could you please send me a > test/program that I can try to track this down? well, the compute_memory_finalize_pending() function can possibly return -1 so it's prudent to check for it. as for th

[Mesa-dev] [PATCH 2/2] r600: Handle failures in compute_memory_pool_finalize

2014-06-19 Thread Jan Vesely
Signed-off-by: Jan Vesely CC: Bruno Jimenez --- The failure now hits assertion compute_memory_pool.c:408, instead of u_inlines.h:275:pipe_buffer_map_range: Assertion `offset < buffer->width0' src/gallium/drivers/r600/evergreen_compute.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletio

[Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Jan Vesely
The important part is the change of the condition to <= 0. Otherwise the loop gets stuck never actually growing the pool. The change in the aux-need calculation guarantees max 2 iterations, and avoids wasting memory in case a smaller item can't fit into a relatively larger pool. Signed-off-by: Ja

Re: [Mesa-dev] [PATCH v2] glsl: handle a switch where default is in the middle of cases

2014-06-19 Thread Roland Scheidegger
Am 19.06.2014 15:11, schrieb Tapani Pälli: > This fixes following tests in es3conform: > >shaders.switch.default_not_last_dynamic_vertex >shaders.switch.default_not_last_dynamic_fragment > > and makes following tests in Piglit pass: > >glsl-1.30/execution/switch/fs-default-notlast-fa

Re: [Mesa-dev] [PATCH 2/2] r600: Handle failures in compute_memory_pool_finalize

2014-06-19 Thread Bruno Jimenez
Hi, To which failure are you refering? Could you please send me a test/program that I can try to track this down? Thanks! Bruno On Thu, 2014-06-19 at 10:21 -0400, Jan Vesely wrote: > Signed-off-by: Jan Vesely > CC: Bruno Jimenez > --- > > The failure now hits assertion compute_memory_pool.c:4

[Mesa-dev] [Bug 77493] lp_test_arit fails with llvm >= llvm-3.5svn r206094

2014-06-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77493 Roland Scheidegger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] Request for next steps on GL_shader_atomic_counters

2014-06-19 Thread Aditya Avinash
Hi, I have started writing code for GL_shader_atomic_counters[1]. How do I proceed to the next steps? Thank you! [1] https://github.com/adityaatluri/shader_atomic_counters/blob/master/atomic_counters.h -- Regards, *Aditya Atluri,* *USA.* ___ mesa-de

Re: [Mesa-dev] [PATCH 08/11] GLX/DRI3: Add GPU offloading support.

2014-06-19 Thread Axel Davy
I've just noted I forgot to update the blitImage flags on this patch, when I use 1 as flush_flag argument it should be replaced by __BLIT_FLAG_FLUSH. Axel Davy On 18/06/2014 23:27, Axel Davy wrote : The differences with DRI2 GPU offloading are: . There's no logic for GPU offloading needed in t

Re: [Mesa-dev] [PATCH] GLX: Add an env var to enable the support of GLX extensions needing both client and server support, in case of client support and direct rendering.

2014-06-19 Thread Axel Davy
On 19/06/2014 01:55, Kenneth Graunke wrote : That would make the common case that most people want (GLX_ARB_create_context for direct rendered 3.2+ core profile stuff) work out of the box, without the need for environment variables. It's technically out of spec, but for X on Wayland, I think i

Re: [Mesa-dev] [PATCH v3 3/3] Add a new capabilities for drivers that can't share buffers

2014-06-19 Thread Axel Davy
On 15/06/2014 07:49, Giovanni Campagna wrote : From: Giovanni Campagna The kms-dri swrast driver cannot share buffers using the GEM, so it must tell the loader to disable extensions relying on that, without disabling the image DRI extension altogheter (which would prevent the loader from workin

Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-06-19 Thread Emil Velikov
On 15/06/14 12:49, Giovanni Campagna wrote: > Hello all, > > This is the third attempt at swrast/llvmpipe support for DRM > drivers that don't have userspace support (qxl, cirrus, simpledrm, etc.) > > I hope I addressed all of Emil's comments. > Thanks for keeping up with my nit-picking Giovanni

Re: [Mesa-dev] [PATCH] radeon/llvm: Adapt to AMDGPU.rsq intrinsic change in LLVM 3.5

2014-06-19 Thread Tom Stellard
On Thu, Jun 19, 2014 at 03:53:42PM +0900, Michel Dänzer wrote: > From: Michel Dänzer > I just pushed this patch to fix the regressions. We can update the other intrinsics in a follow on patch. We also need to change RSQ to use llvm.AMDGPU.rsq.clamped once http://lists.cs.uiuc.edu/pipermail/llv

[Mesa-dev] [PATCH v2] glsl: handle a switch where default is in the middle of cases

2014-06-19 Thread Tapani Pälli
This fixes following tests in es3conform: shaders.switch.default_not_last_dynamic_vertex shaders.switch.default_not_last_dynamic_fragment and makes following tests in Piglit pass: glsl-1.30/execution/switch/fs-default-notlast-fallthrough glsl-1.30/execution/switch/fs-default_notlast

[Mesa-dev] [PATCH v3] i965: Enable vertex streams up to MAX_VERTEX_STREAMS.

2014-06-19 Thread Iago Toral Quiroga
--- I guess this was an implicit reviewed-by with this change, but anyway... :) src/mesa/drivers/dri/i965/brw_context.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index cfb0be0..e168b6d 100644 --- a/s

[Mesa-dev] [PATCH 01/11] i965: check malloc return value in intel_resolve_map_set()

2014-06-19 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/dri/i965/intel_resolve_map.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_resolve_map.c b/src/mesa/drivers/dri/i965/intel_resolve_map.c index a37afa6..5ed7fd3 100644 --- a/src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH 10/11] mesa/main: In register_surface() verify gl_texture_object was found

2014-06-19 Thread Juha-Pekka Heikkila
Verify _mesa_lookup_texture() returned valid pointer before using it. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/vdpau.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/main/vdpau.c b/src/mesa/main/vdpau.c index f1b3ece..975b812 100644 --- a/src/mesa/main/vdpau.c +++

[Mesa-dev] [PATCH 11/11] glx: Added missing null check in GetDrawableAttribute()

2014-06-19 Thread Juha-Pekka Heikkila
For GLX_BACK_BUFFER_AGE_EXT query added extra null check. Signed-off-by: Juha-Pekka Heikkila --- src/glx/glx_pbuffer.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/glx/glx_pbuffer.c b/src/glx/glx_pbuffer.c index 8f48093..322f241 100644 --- a/src/glx/glx_pbu

[Mesa-dev] [PATCH 05/11] i965/fs: Check variable_storage return value in fs_visitor::visit

2014-06-19 Thread Juha-Pekka Heikkila
check variable_storage() found the requested fs_reg. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp index 63

[Mesa-dev] [PATCH 04/11] i965: Handle miptree creation failure in intel_alloc_texture_storage()

2014-06-19 Thread Juha-Pekka Heikkila
Check intel_miptree_create() return value before using it as a pointer. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/dri/i965/intel_tex.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_tex.c b/src/mesa/drivers/dri/i965/intel_tex.c index f18ca45

[Mesa-dev] [PATCH 03/11] i965: Check calloc return value in gather_statistics_results()

2014-06-19 Thread Juha-Pekka Heikkila
Check calloc return value and report on error, also later skip results handling if there was no memory to store results to. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/dri/i965/brw_performance_monitor.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mes

[Mesa-dev] [PATCH 08/11] glsl: Check calloc return value in link_intrastage_shaders()

2014-06-19 Thread Juha-Pekka Heikkila
Check calloc return value while adding build-in functions. Signed-off-by: Juha-Pekka Heikkila --- src/glsl/linker.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 247c828..1fc0213 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.

[Mesa-dev] [PATCH 06/11] glsl: check _mesa_hash_table_create return value in link_uniform_blocks

2014-06-19 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glsl/link_uniform_blocks.cpp | 6 ++ src/glsl/linker.cpp | 2 ++ 2 files changed, 8 insertions(+) diff --git a/src/glsl/link_uniform_blocks.cpp b/src/glsl/link_uniform_blocks.cpp index 1a0e643..53a18c93 100644 --- a/src/glsl/link_unifor

[Mesa-dev] [PATCH 09/11] mesa/main: Verify calloc return value in register_surface()

2014-06-19 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/vdpau.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/vdpau.c b/src/mesa/main/vdpau.c index d974593..f1b3ece 100644 --- a/src/mesa/main/vdpau.c +++ b/src/mesa/main/vdpau.c @@ -132,6 +132,11 @@ register_surface(struct gl

[Mesa-dev] [PATCH 07/11] glsl: Add missing null check in push_back()

2014-06-19 Thread Juha-Pekka Heikkila
Report memory error on realloc failure and don't leak any memory. Signed-off-by: Juha-Pekka Heikkila --- src/glsl/link_atomics.cpp | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/glsl/link_atomics.cpp b/src/glsl/link_atomics.cpp index d92cdb1..fbe4e73 10064

[Mesa-dev] [PATCH 02/11] i965: Avoid null access in intelMakeCurrent()

2014-06-19 Thread Juha-Pekka Heikkila
separate two null checks connected with && to their own if branches. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/dri/i965/brw_context.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 00/11] Klocwork related set again

2014-06-19 Thread Juha-Pekka Heikkila
Rebased and fixed on comments again, thank you Ian earlier for commenting. For "i965: check malloc return value in intel_resolve_map_set()" I did set *tail to null and was running tests but I did not see any unexpected crashes. >From Piglit quick set there did though raise two cases where stderr

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-19 Thread Emil Velikov
On 17/06/14 19:24, Emil Velikov wrote: > On 12/06/14 20:56, Emil Velikov wrote: >> Hi all, >> >> These patches add support for building (grouping) the various targets per >> API, meaning that only one library will be created for e.g. vdpau >> (libvdpau_gallium) with individual ones (libvdpau_r600)

Re: [Mesa-dev] [PATCH 00/23] Megadrivers galore

2014-06-19 Thread Emil Velikov
On 19/06/14 11:54, Jakob Bornecrantz wrote: > On Tue, Jun 17, 2014 at 8:38 PM, Emil Velikov > wrote: >> Hi all, >> >> As a follow up to the static/shared pipe-drivers series here is the final >> series (if anyone is interested I may take a look at egl + opencl) of >> refactoring the gallium dri t

Re: [Mesa-dev] [PATCH 1/5] clover: Don't use llvm's global context

2014-06-19 Thread Francisco Jerez
Tom Stellard writes: > An LLVMContext should only be accessed by a single and using the global > context was causing crashes in multi-threaded environments. Now we use > a separate context for each compile. For this patch: Reviewed-by: Francisco Jerez > --- > src/gallium/state_trackers/clove

Re: [Mesa-dev] [PATCH 4/5] gallium: Add PIPE_SHADER_CAP_DOUBLES

2014-06-19 Thread Francisco Jerez
Tom Stellard writes: > This is for reporting whether or not double precision floating-point > operations are supported. Reviewed-by: Francisco Jerez > --- > src/gallium/auxiliary/gallivm/lp_bld_limits.h | 2 ++ > src/gallium/auxiliary/tgsi/tgsi_exec.h| 2 ++ > src/gallium/docs/source/

Re: [Mesa-dev] [PATCH v2 11/23] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-19 Thread Iago Toral
Samuel has reminded me that Ilia has already done some changes to Gallium in order to check a piglit test for multi-stream support there, so adding to the CC. On Thu, 2014-06-19 at 12:37 +0200, Iago Toral wrote: > After having a quick look at ir_to_mesa.cpp and st_glsl_to_tgsi.cpp I > have some co

Re: [Mesa-dev] [PATCH 00/23] Megadrivers galore

2014-06-19 Thread Jakob Bornecrantz
Thanks again, and fair enough. :) Cheers, Jakob. On Thu, Jun 19, 2014 at 1:22 PM, Marek Olšák wrote: > Yes, that's correct. However, it's better to duplicate the same code > twice than ten times. > > Marek > > On Thu, Jun 19, 2014 at 1:12 PM, Jakob Bornecrantz > wrote: >> On Thu, Jun 19, 2014

Re: [Mesa-dev] [PATCH 01/11] gallium: Add __DRIimageDriverExtension support to gallium

2014-06-19 Thread Axel Davy
On 19/06/2014 01:20, Ilia Mirkin wrote : +static __DRIbuffer * +dri2_allocate_buffer(__DRIscreen *sPriv, + unsigned attachment, unsigned format, + int width, int height) +{ + struct dri_screen *screen = dri_screen(sPriv); + struct dri2_buffer *buffer; +

Re: [Mesa-dev] [PATCH 00/23] Megadrivers galore

2014-06-19 Thread Marek Olšák
Yes, that's correct. However, it's better to duplicate the same code twice than ten times. Marek On Thu, Jun 19, 2014 at 1:12 PM, Jakob Bornecrantz wrote: > On Thu, Jun 19, 2014 at 1:08 PM, Marek Olšák wrote: >> Hi Jakob, >> >> libdricore was nuked quite some time ago. What classic drivers now

Re: [Mesa-dev] [PATCH 00/23] Megadrivers galore

2014-06-19 Thread Jakob Bornecrantz
On Thu, Jun 19, 2014 at 1:08 PM, Marek Olšák wrote: > Hi Jakob, > > libdricore was nuked quite some time ago. What classic drivers now use > is all drivers in mesa_dri_drivers.so and the _dri.so files are > hardlinks to that file. Ah, thanks for the info. Wouldn't that mean that mesa core code li

Re: [Mesa-dev] [PATCH 00/23] Megadrivers galore

2014-06-19 Thread Marek Olšák
Hi Jakob, libdricore was nuked quite some time ago. What classic drivers now use is all drivers in mesa_dri_drivers.so and the _dri.so files are hardlinks to that file. Marek On Thu, Jun 19, 2014 at 12:54 PM, Jakob Bornecrantz wrote: > On Tue, Jun 17, 2014 at 8:38 PM, Emil Velikov > wrote: >>

[Mesa-dev] [PATCH] glsl: handle a switch where default is in the middle of cases

2014-06-19 Thread Tapani Pälli
This fixes following tests in es3conform: shaders.switch.default_not_last_dynamic_vertex shaders.switch.default_not_last_dynamic_fragment and makes following tests in Piglit pass: glsl-1.30/execution/switch/fs-default-notlast-fallthrough glsl-1.30/execution/switch/fs-default_notlast

Re: [Mesa-dev] [PATCH 00/23] Megadrivers galore

2014-06-19 Thread Jakob Bornecrantz
On Tue, Jun 17, 2014 at 8:38 PM, Emil Velikov wrote: > Hi all, > > As a follow up to the static/shared pipe-drivers series here is the final > series (if anyone is interested I may take a look at egl + opencl) of > refactoring the gallium dri targets into a single library/provider. > > In a nutshe

Re: [Mesa-dev] [PATCH v2 11/23] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-19 Thread Iago Toral
After having a quick look at ir_to_mesa.cpp and st_glsl_to_tgsi.cpp I have some comments and questions about this: On Wed, 2014-06-18 at 13:31 -0700, Ian Romanick wrote: > This patch should be split into several patches: > > 1. Modify ir_emit_vertex to have a stream. This patch also needs to upd

Re: [Mesa-dev] [PATCH] gallivm: set mcpu when initializing llvm execution engine

2014-06-19 Thread Jose Fonseca
Looks good. Thanks Roland. Jose From: srol...@vmware.com Sent: 19 June 2014 02:28 To: Jose Fonseca; mesa-dev@lists.freedesktop.org Cc: Roland Scheidegger Subject: [PATCH] gallivm: set mcpu when initializing llvm execution engine From: Roland Scheidegger

Re: [Mesa-dev] [PATCH] radeon/llvm: Adapt to AMDGPU.rsq intrinsic change in LLVM 3.5

2014-06-19 Thread Matt Arsenault
On Jun 18, 2014, at 11:53 PM, Michel Dänzer wrote: > From: Michel Dänzer > > Signed-off-by: Michel Dänzer > --- > src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c > b/src/galli

Re: [Mesa-dev] [PATCH] i965: Save meta blit programs in the context.

2014-06-19 Thread Eric Anholt
Kenneth Graunke writes: > When the last context in a share group is destroyed, the hash table > containing all of the shader programs (ctx->Shared->ShaderObjects) is > destroyed, throwing away all of the shader programs. Reviewed-by: Eric Anholt pgpBNgFcIH1rb.pgp Description: PGP signature __

Re: [Mesa-dev] [PATCH 11/11] clover: Use PIPE_TRANSFER_MAP_DIRECTLY when writing/reading buffers

2014-06-19 Thread Bruno Jimenez
On Thu, 2014-06-19 at 10:23 +0900, Michel Dänzer wrote: > On 19.06.2014 00:02, Bruno Jiménez wrote: > > Note: This is just a proof of concept. > > --- > > src/gallium/state_trackers/clover/api/transfer.cpp | 4 ++-- > > src/gallium/state_trackers/clover/core/object.hpp | 4 > > src/gallium

[Mesa-dev] [PATCH] nouveau: dup fd before passing it to device

2014-06-19 Thread Ilia Mirkin
nouveau screens are reused for the same device node. However in the scenario where we create screen 1, screen 2, and then delete screen 1, the surrounding code might also close the original device node. To protect against this, dup the fd and use the dup'd fd in the nouveau_device. Also tell the no

Re: [Mesa-dev] [PATCH v2 01/23] glsl: Add parsing support for multi-stream output in geometry shaders.

2014-06-19 Thread Iago Toral
On Wed, 2014-06-18 at 11:16 -0700, Ian Romanick wrote: (...) > > Please replace this comment with the following spec quotation: > > /* Section 4.3.8.2 (Output Layout Qualifiers) of the OpenGL 4.00 I think you meant the GLSL spec. > * spec says: > * > *

Re: [Mesa-dev] Broadcom VC4 project

2014-06-19 Thread Eric Anholt
Marek Olšák writes: > We already have transfer_inline_write. Looks like that's only used from finalize, currently? But if the idea's already present, that's promising. pgpLOuHqVEH2j.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@l

Re: [Mesa-dev] Broadcom VC4 project

2014-06-19 Thread Eric Anholt
Dave Airlie writes: >> >> I'm working toward building a Mesa driver for Broadcom VC4 (aka >> Raspberry Pi). At the moment I'm still bringing up the DRM side of >> things, but I hope to be doing bits of userspace in the next few days. >> Current status is I have a skeleton DRM KMS driver that's g

Re: [Mesa-dev] [PATCH v2 09/23] glsl: Store info about geometry shaders that emit vertices to non-zero streams.

2014-06-19 Thread Chris Forbes
(but maybe in a separate patch) On Thu, Jun 19, 2014 at 7:53 PM, Chris Forbes wrote: > Sounds good to me. > > On Thu, Jun 19, 2014 at 7:23 PM, Iago Toral wrote: >> On Wed, 2014-06-18 at 13:05 -0700, Ian Romanick wrote: >>> On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: >>> > On Intel hardware

Re: [Mesa-dev] [PATCH v2 09/23] glsl: Store info about geometry shaders that emit vertices to non-zero streams.

2014-06-19 Thread Chris Forbes
Sounds good to me. On Thu, Jun 19, 2014 at 7:23 PM, Iago Toral wrote: > On Wed, 2014-06-18 at 13:05 -0700, Ian Romanick wrote: >> On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: >> > On Intel hardware when a geometry shader outputs GL_POINTS primitives we >> > only need to emit vertex control b

Re: [Mesa-dev] [PATCH v2 11/23] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-19 Thread Iago Toral
On Wed, 2014-06-18 at 13:31 -0700, Ian Romanick wrote: > This patch should be split into several patches: > > 1. Modify ir_emit_vertex to have a stream. This patch also needs to update > ir_to_mesa.cpp and st_glsl_to_tgsi.cpp. > > 2. Modify ir_end_primitive to have a stream. This patch also nee

Re: [Mesa-dev] [PATCH v2 09/23] glsl: Store info about geometry shaders that emit vertices to non-zero streams.

2014-06-19 Thread Iago Toral
On Wed, 2014-06-18 at 13:05 -0700, Ian Romanick wrote: > On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: > > On Intel hardware when a geometry shader outputs GL_POINTS primitives we > > only need to emit vertex control bits if it emits vertices to non-zero > > streams, so use a flag to track this

[Mesa-dev] [PATCH] i965: Save meta blit programs in the context.

2014-06-19 Thread Kenneth Graunke
When the last context in a share group is destroyed, the hash table containing all of the shader programs (ctx->Shared->ShaderObjects) is destroyed, throwing away all of the shader programs. Using a static variable to store program IDs ends up holding on to them after this, so we think we still ha