[Mesa-dev] [PATCH 2/2] nvc0: add a memory barrier when there are persistent UBOs

Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/nvc0_context.c | 22 +++- src/gallium/drivers/nouveau/nvc0/nvc0_context.h | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 5 + src/gallium/drivers/nouveau/nvc0/nvc0_vbo.c | 27 +

[Mesa-dev] [PATCH 1/2] nv50: do an explicit flush on draw when there are persistent buffers

Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nv50/nv50_context.c | 22 ++- src/gallium/drivers/nouveau/nv50/nv50_context.h | 1 + src/gallium/drivers/nouveau/nv50/nv50_vbo.c | 29 - 3 files changed, 50 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH] nv50: disable dedicated ubo upload method

The hardware allows multiple simultaneous renders with the same memory-backed constbufs but with each invocation having different values. However in order for that to work, the data has to be streamed in via the right constbuf slot. We weren't doing that for UBOs. Signed-off-by: Ilia Mirkin Cc: "

Re: [Mesa-dev] [PATCH 1/4] i965/vec4: Add basic common subexpression elimination.

On Monday, June 30, 2014 12:06:56 PM Matt Turner wrote: > On Mon, Jun 30, 2014 at 11:49 AM, Ian Romanick wrote: > > On 06/25/2014 02:12 PM, Matt Turner wrote: > >> From: Kenneth Graunke > >> > >> [mattst88]: Modified to perform CSE on instructions with > >> > >> the same writemask.

Re: [Mesa-dev] [PATCH] meta: Call glObjectLabel before linking.

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] meta: Call glObjectLabel before linking.

i965 precompiles shaders at link time, and prints a disassembly if INTEL_DEBUG=vs,gs,fs, including the shader name. However, blit shaders were showing up as "unnamed" since we hadn't set a name prior to linking. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/common/meta.c | 2 +- 1 file ch

Re: [Mesa-dev] [PATCH 5/5] meta: Add a meta implementation of GL_ARB_clear_texture

On 06/13/2014 05:59 PM, Neil Roberts wrote: > Adds an implementation of the ClearTexSubImage driver entry point that tries > to set up an FBO to render to the texture and then calls glClear with a > scissor to perform the actual clear. If an FBO can't be created for the > texture then it will fall

Re: [Mesa-dev] [PATCH 2/5] mesa/main: Add generic bits of ARB_clear_texture implementation

On 06/13/2014 05:59 PM, Neil Roberts wrote: > This adds the driver entry point for glClearTexSubImage and fills in the > _mesa_ClearTexImage and _mesa_ClearTexSubImage functions that call it. > --- > src/mesa/main/dd.h | 14 +++ > src/mesa/main/teximage.c | 241 > ++

Re: [Mesa-dev] [PATCH 3/5] Add a place to enable extensions that are common to all DRI drivers

On 06/13/2014 05:59 PM, Neil Roberts wrote: > This adds a function called _mesa_init_driver_extensions that is called by all > DRI-based drivers. The intention is that any extensions that are implemented > directly by _mesa_init_driver_functions without any driver-specific > entrypoints will be ena

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Courtney Goeltzenleuchter changed: What|Removed |Added Depends on||79373 -- You are receiving

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Courtney Goeltzenleuchter changed: What|Removed |Added Depends on||80500 -- You are receiving

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Courtney Goeltzenleuchter changed: What|Removed |Added Depends on||79948 -- You are receiving

Re: [Mesa-dev] [PATCH] i965: Extend compute-to-mrf pass to understand blocks of MOVs

On Fri, Jun 27, 2014 at 12:00 PM, Kristian Høgsberg wrote: > From: Kristian Høgsberg With your email address fixed, Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-d

Re: [Mesa-dev] [PATCH 07/13] i965: Make a brw_conditional_mod enum.

On Mon, Jun 30, 2014 at 2:40 PM, Matt Turner wrote: > diff --git a/src/mesa/drivers/dri/i965/gen8_instruction.c > b/src/mesa/drivers/dri/i965/gen8_instruction.c > index c9cbab6..47955e1 100644 > --- a/src/mesa/drivers/dri/i965/gen8_instruction.c > +++ b/src/mesa/drivers/dri/i965/gen8_instruction.

Re: [Mesa-dev] [PATCH] configure.ac: (trivial) Fixing a typo

On 30/06/14 22:05, Alexandre Demers wrote: > Signed-off-by: Alexandre Demers Reviewed-by: Emil Velikov and pushed to master. > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index faf1485..98efa43 100644 > --- a/configu

Re: [Mesa-dev] [PATCH 01/13] i965: Use immediate storage in brw_reg for visitor regs.

On Mon, Jun 30, 2014 at 2:46 PM, Chris Forbes wrote: > On Tue, Jul 1, 2014 at 9:40 AM, Matt Turner wrote: >> >> /** Fixed brw_reg. */ >> @@ -452,7 +452,7 @@ fs_reg::equals(const fs_reg &r) const >> memcmp(&fixed_hw_reg, &r.fixed_hw_reg, >>sizeof(fixed_hw_reg)) ==

Re: [Mesa-dev] [PATCH 01/13] i965: Use immediate storage in brw_reg for visitor regs.

On Tue, Jul 1, 2014 at 9:40 AM, Matt Turner wrote: > > /** Fixed brw_reg. */ > @@ -452,7 +452,7 @@ fs_reg::equals(const fs_reg &r) const > memcmp(&fixed_hw_reg, &r.fixed_hw_reg, >sizeof(fixed_hw_reg)) == 0 && > stride == r.stride && > - imm.u

[Mesa-dev] [PATCH 10/13] i965/cfg: Make cfg_t usable from C.

--- src/mesa/drivers/dri/i965/brw_cfg.h | 10 -- src/mesa/drivers/dri/i965/brw_fs_live_variables.h | 2 +- src/mesa/drivers/dri/i965/brw_shader.h| 2 +- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_cfg.h b/src/mes

[Mesa-dev] [PATCH 04/13] i965: Move is_zero/one/null/accumulator into backend_reg.

--- src/mesa/drivers/dri/i965/brw_fs.cpp | 36 src/mesa/drivers/dri/i965/brw_fs.h | 4 --- src/mesa/drivers/dri/i965/brw_shader.cpp | 37 + src/mesa/drivers/dri/i965/brw_shader.h | 7 + src/mesa/drivers/dri/i965/brw_vec4.cpp | 47

[Mesa-dev] [PATCH 02/13] i965: Drop imm union from visitor register classes.

--- src/mesa/drivers/dri/i965/brw_fs.h | 7 --- src/mesa/drivers/dri/i965/brw_vec4.h | 7 --- 2 files changed, 14 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h index 961c56c..c32b0a6 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.h +++

[Mesa-dev] [PATCH 12/13] i965: Rename intel_asm_printer -> intel_asm_annotation.

The #ifndef include guards already said the right thing :) --- src/mesa/drivers/dri/i965/Makefile.sources | 2 +- src/mesa/drivers/dri/i965/brw_eu.h | 2 +- src/mesa/drivers/dri/i965/brw_eu_compact.c | 2 +- src/mesa/drivers/dri/i965/brw_fs.h | 2 +- src

[Mesa-dev] [PATCH 07/13] i965: Make a brw_conditional_mod enum.

--- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp| 2 +- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 7 +++--- src/mesa/drivers/dri/i965/brw_defines.h| 26 -- src/mesa/drivers/dri/i965/brw_eu.c | 2 +- src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH 13/13] i965: Move assembly annotation functions to intel_asm_annotation.c.

It's C. Compile it as such. --- src/mesa/drivers/dri/i965/brw_shader.cpp | 55 -- src/mesa/drivers/dri/i965/brw_shader.h | 6 --- src/mesa/drivers/dri/i965/intel_asm_annotation.c | 58 src/mesa/drivers/dri/i965/intel_asm_annotation.h

[Mesa-dev] [PATCH 06/13] i965: Move common fields into backend_instruction.

--- src/mesa/drivers/dri/i965/brw_fs.h | 12 src/mesa/drivers/dri/i965/brw_shader.h | 13 + src/mesa/drivers/dri/i965/brw_vec4.h | 13 - 3 files changed, 13 insertions(+), 25 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/driver

[Mesa-dev] [PATCH 11/13] i965: Make backend_instruction usable from C.

With a hack to place an exec_node in the struct in C to be at the same location as the inherited exec_node in C++. --- src/mesa/drivers/dri/i965/brw_shader.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_shader.h b/src/mesa/drivers/d

[Mesa-dev] [PATCH 08/13] i965: Make a brw_predicate enum.

--- src/mesa/drivers/dri/i965/brw_defines.h| 38 ++ src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs.h | 2 +- src/mesa/drivers/dri/i965/brw_shader.h | 2 +- src/mesa/drivers/dri/i965/brw_vec4.h

[Mesa-dev] [PATCH 09/13] i965: Repack backend_instruction struct.

--- src/mesa/drivers/dri/i965/brw_shader.h | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_shader.h b/src/mesa/drivers/dri/i965/brw_shader.h index 3205b67..558d052 100644 --- a/src/mesa/drivers/dri/i965/brw_shader.h +++ b/src/mesa/dri

[Mesa-dev] [PATCH 05/13] i965: Use enum brw_reg_type for register types.

--- src/mesa/drivers/dri/i965/brw_blorp.h| 3 ++- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs.h | 4 ++-- src/mesa/drivers/dri/i965/brw_reg.h | 8 src/mesa/drivers/dri/i965/brw_shader.cpp | 2 +- src/mesa/drivers/dri/i965/brw_shader.h

[Mesa-dev] [PATCH 01/13] i965: Use immediate storage in brw_reg for visitor regs.

--- src/mesa/drivers/dri/i965/brw_fs.cpp | 26 -- .../drivers/dri/i965/brw_fs_copy_propagation.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 6 ++--- src/mesa/drivers/dri/i965/brw_vec4.cpp | 24 +--- .../drivers

[Mesa-dev] [PATCH 03/13] i965: Make a common backend_reg class.

--- src/mesa/drivers/dri/i965/brw_fs.h | 24 +--- src/mesa/drivers/dri/i965/brw_shader.h | 32 ++ src/mesa/drivers/dri/i965/brw_vec4.h | 20 ++ .../drivers/dri/i965/brw_vec4_reg_allocate.cpp | 2 +- 4 files

[Mesa-dev] [Bug 80615] Files in bellagio directory [omx tracker] don't respect installation folder

https://bugs.freedesktop.org/show_bug.cgi?id=80615 --- Comment #5 from Emil Velikov --- AFAICS the whole thing is quite inconsistent. (In reply to comment #3) > That's something I hadn't noticed. However, it still bugs me. Why would this > component deal with its installation path differently fr

[Mesa-dev] [Bug 80615] Files in bellagio directory [omx tracker] don't respect installation folder

https://bugs.freedesktop.org/show_bug.cgi?id=80615 --- Comment #4 from Alexandre Demers --- Emil, I just sent a patch on mesa-dev, but maybe I should have included you in CC though. See http://lists.freedesktop.org/archives/mesa-dev/2014-June/062477.html -- You are receiving this mail because:

[Mesa-dev] [PATCH] configure.ac: fix omx default installation folder

Making default OMX installation folder follows the same pattern as other state trackers / libs. Fixes bug 80615. Signed-off-by: Alexandre Demers --- configure.ac | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/configure.ac b/configure.ac index 98efa43..a684390 100

[Mesa-dev] [PATCH] configure.ac: (trivial) Fixing a typo

Signed-off-by: Alexandre Demers --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index faf1485..98efa43 100644 --- a/configure.ac +++ b/configure.ac @@ -1603,7 +1603,7 @@ fi AC_ARG_WITH([egl-driver-dir], [AS_HELP_STRING([--wi

Re: [Mesa-dev] [PATCH 23/23] i965/disasm: Fix INTEL_DEBUG=fs on Broadwell for ARB_fp applications.

On Sat, Jun 28, 2014 at 09:34:02PM -0700, Kenneth Graunke wrote: > Apparently INTEL_DEBUG=fs has crashed on Broadwell for anything using > ARB_fragment_program since commit 9cee3ff5. We need to NULL-check the > right field. > > Signed-off-by: Kenneth Graunke > Cc: "10.2" Reviewed-by: Kristian

Re: [Mesa-dev] [PATCH 22/23] i965/disasm: Delete gen8_disasm.c.

On Sat, Jun 28, 2014 at 09:34:01PM -0700, Kenneth Graunke wrote: > The functionality has been merged into brw_disasm.c; use that instead. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/Makefile.sources |1 - > src/mesa/drivers/dri/i965/gen8_disasm.c | 1026 > ---

Re: [Mesa-dev] [PATCH 21/23] i965/disasm: Stop using gen8_disassemble in favor of brw_disassemble.

On Sat, Jun 28, 2014 at 09:34:00PM -0700, Kenneth Graunke wrote: > At this point, brw_disassemble can do everything gen8_disassemble can > do - and, thanks to the new brw_inst API, it supports all generations. Reviewed-by: Kristian Høgsberg > Signed-off-by: Kenneth Graunke > --- > src/mesa/dri

Re: [Mesa-dev] [PATCH 20/23] i965/disasm: Improve render target write message disassembly.

On Sat, Jun 28, 2014 at 09:33:59PM -0700, Kenneth Graunke wrote: > Previously, we decoded render target write messages as: > >render ( RT write, 0, 16, 12, 0) mlen 8 rlen 0 > > which made you remember (or look up) what the numbers meant: > > 1. The binding table index > 2. The raw message co

Re: [Mesa-dev] [PATCH 1/4] i965/vec4: Add basic common subexpression elimination.

On Mon, Jun 30, 2014 at 11:49 AM, Ian Romanick wrote: > On 06/25/2014 02:12 PM, Matt Turner wrote: >> From: Kenneth Graunke >> >> [mattst88]: Modified to perform CSE on instructions with >> the same writemask. Offered no improvement before. >> >> total instructions in shared programs:

Re: [Mesa-dev] [PATCH 2/4] i965/vec4: Improve CSE performance by expiring some available expressions.

On Mon, Jun 30, 2014 at 11:49 AM, Ian Romanick wrote: > On 06/25/2014 02:12 PM, Matt Turner wrote: >> Port of commit 5daf867f to the vec4 code. >> --- >> src/mesa/drivers/dri/i965/brw_vec4_cse.cpp | 20 >> 1 file changed, 20 insertions(+) >> >> diff --git a/src/mesa/drivers/d

Re: [Mesa-dev] [PATCH 18/23] i965/disasm: Fix typo in RT UNORM write message.

On Sat, Jun 28, 2014 at 09:33:57PM -0700, Kenneth Graunke wrote: > The name of this message is "Render Target UNORM Write" (Sandybridge > PRM, Volume 4 Part 1, Page 210). Drop the bogus 'c'. > > Signed-off-by: Kenneth Graunke Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/b

Re: [Mesa-dev] [PATCH 19/23] i965/disasm: Rename msg_target to SFID.

On Sat, Jun 28, 2014 at 09:33:58PM -0700, Kenneth Graunke wrote: > We haven't used the name "message target" in a while - there are a lot > of things called "target", and it gets confusing. SFID ("Shared > Function ID") is the term commonly used in the modern documentation. > > Signed-off-by: Ken

Re: [Mesa-dev] [PATCH 17/23] i965/disasm: Use Gen6+ SFID case labels.

On Sat, Jun 28, 2014 at 09:33:56PM -0700, Kenneth Graunke wrote: > Most developers will recognize the Gen6+ SFID names more quickly than > the Gen4-5 ones. Given that they're the same values, just use the new > names. > > Signed-off-by: Kenneth Graunke Reviewed-by: Kristian Høgsberg > --- >

Re: [Mesa-dev] [PATCH 16/23] i965/disasm: "Handle" Gen8+ HF/DF immediate cases.

On Sat, Jun 28, 2014 at 09:33:55PM -0700, Kenneth Graunke wrote: > We should print something properly, but I'm not sure how to properly > print an HF, and we don't have any DFs today to test with. > > This is at least better than the current Gen8 disassembler, which would > simply assert fail. >

Re: [Mesa-dev] [PATCH 2/4] i965/vec4: Improve CSE performance by expiring some available expressions.

On 06/25/2014 02:12 PM, Matt Turner wrote: > Port of commit 5daf867f to the vec4 code. > --- > src/mesa/drivers/dri/i965/brw_vec4_cse.cpp | 20 > 1 file changed, 20 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4_cse.cpp > b/src/mesa/drivers/dri/i965/brw_ve

Re: [Mesa-dev] [PATCH 1/4] i965/vec4: Add basic common subexpression elimination.

On 06/25/2014 02:12 PM, Matt Turner wrote: > From: Kenneth Graunke > > [mattst88]: Modified to perform CSE on instructions with > the same writemask. Offered no improvement before. > > total instructions in shared programs: 1995633 -> 1995185 (-0.02%) > instructions in affected progr

Re: [Mesa-dev] [PATCH 2/3] i965: Use unreachable() instead of unconditional assert().

On 06/30/2014 11:20 AM, Philipp Klaus Krause wrote: > On 30.06.2014 20:03, Matt Turner wrote: >> On Mon, Jun 30, 2014 at 10:37 AM, Ian Romanick wrote: >>> In the cases where a return (with a value) is removed, I'm afraid static >>> analysis tools will start to complain. I'll be surprised if Klocw

Re: [Mesa-dev] [PATCH 2/3] i965: Use unreachable() instead of unconditional assert().

On Mon, Jun 30, 2014 at 11:20 AM, Philipp Klaus Krause wrote: > On 30.06.2014 20:03, Matt Turner wrote: >> On Mon, Jun 30, 2014 at 10:37 AM, Ian Romanick wrote: >>> In the cases where a return (with a value) is removed, I'm afraid static >>> analysis tools will start to complain. I'll be surpris

Re: [Mesa-dev] [PATCH 2/3] i965: Use unreachable() instead of unconditional assert().

On 06/30/2014 11:03 AM, Matt Turner wrote: > On Mon, Jun 30, 2014 at 10:37 AM, Ian Romanick wrote: >> In the cases where a return (with a value) is removed, I'm afraid static >> analysis tools will start to complain. I'll be surprised if Klocwork >> understands (or trusts) GCC __builtin_unreachab

Re: [Mesa-dev] [PATCH 4/5] texstore: Add a generic implementation of GL_ARB_clear_texture

On Fri, Jun 13, 2014 at 5:59 PM, Neil Roberts wrote: > Adds an implmentation of the ClearTexSubImage driver entry point that just > maps the texture and writes the values in. This should work as a reliable > fallback on any driver. > --- > src/mesa/drivers/common/driverfuncs.c | 2 + > src/mesa

Re: [Mesa-dev] [PATCH 01/16] glsl: Add typed foreach_in_list/_reverse macros.

Patches 1 through 10, 12, 13, and 16 are Reviewed-by: Ian Romanick Patches 14 and 15 are Acked-by: Ian Romanick We're still discussing patch 11 on IRC. :) On 06/25/2014 11:51 AM, Matt Turner wrote: > --- > src/glsl/list.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a

Re: [Mesa-dev] [PATCH 2/5] mesa/main: Add generic bits of ARB_clear_texture implementation

On Fri, Jun 13, 2014 at 5:59 PM, Neil Roberts wrote: > This adds the driver entry point for glClearTexSubImage and fills in the > _mesa_ClearTexImage and _mesa_ClearTexSubImage functions that call it. > --- > src/mesa/main/dd.h | 14 +++ > src/mesa/main/teximage.c | 241 >

Re: [Mesa-dev] [PATCH 2/3] i965: Use unreachable() instead of unconditional assert().

On 30.06.2014 20:03, Matt Turner wrote: > On Mon, Jun 30, 2014 at 10:37 AM, Ian Romanick wrote: >> In the cases where a return (with a value) is removed, I'm afraid static >> analysis tools will start to complain. I'll be surprised if Klocwork >> understands (or trusts) GCC __builtin_unreachable

Re: [Mesa-dev] [PATCH 12/23] i965/disasm: Actually disassemble Gen7+ URB opcodes.

On Monday, June 30, 2014 10:20:13 AM Kristian Høgsberg wrote: > On Sat, Jun 28, 2014 at 09:33:51PM -0700, Kenneth Graunke wrote: > > I never bothered implementing the disassembler for Gen7+ URB opcodes, so > > we were just disassembling them as Ironlake/Sandybridge ones. This > > looked pretty bad

Re: [Mesa-dev] [PATCH 2/3] i965: Use unreachable() instead of unconditional assert().

On Mon, Jun 30, 2014 at 10:37 AM, Ian Romanick wrote: > In the cases where a return (with a value) is removed, I'm afraid static > analysis tools will start to complain. I'll be surprised if Klocwork > understands (or trusts) GCC __builtin_unreachable decorations. Good catch. I didn't think abou

Re: [Mesa-dev] [PATCH 3/4] i965/fs: Mark predicated PLN instructions with dependency hints.

On Mon, Jun 30, 2014 at 10:29 AM, Ian Romanick wrote: > On 06/29/2014 11:18 PM, Matt Turner wrote: >> To implement the unlit_centroid_workaround, previously we emitted >> >>(+f0) pln(8) g20<1>F g16.4<0,1,0>F g4<8,8,1>F { align1 1Q }; >>(-f0) pln(8) g20<1>F g16.4<0,1,0>F g2<8,8,1>F { align1

Re: [Mesa-dev] [PATCH 3/3] i965/vec4: Remove useless conditionals.

On Mon, Jun 30, 2014 at 10:32 AM, Ian Romanick wrote: > On 06/30/2014 10:11 AM, Matt Turner wrote: >> Setting a couple of bits is the same cost or less as conditionally >> setting a couple of bits. >> --- >> src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 9 +++-- >> 1 file changed, 3 inse

Re: [Mesa-dev] [PATCH v2 4/9] gallium: add a cap for max vertex streams

On Sat, Jun 28, 2014 at 8:44 AM, Roland Scheidegger wrote: > 3-4 look alright to me. Does this count as a R-b? Looks like the core changes have landed, so I'm going to be looking to push all this out ~tomorrow. > I wonder if the cap name is actually "correct" > or if it should have some STREAM_O

Re: [Mesa-dev] [PATCH 15/23] i965/disasm: Cut piles of duplicate swizzle printing.

On Sat, Jun 28, 2014 at 09:33:54PM -0700, Kenneth Graunke wrote: > Making a helper function saves us from cut and pasting this four times. Very nice, Reviewed-by: Kristian Høgsberg > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_disasm.c | 115 > ---

Re: [Mesa-dev] [PATCH 14/23] i965/disasm: Properly decode negate source modifiers on Broadwell.

On Sat, Jun 28, 2014 at 09:33:53PM -0700, Kenneth Graunke wrote: > This is a port of Abdiel's 6f9f916b9b042a294813ab0542390846a38739da > to brw_disasm.c. Reviewed-by: Kristian Høgsberg > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_disasm.c | 53 > +

Re: [Mesa-dev] [PATCH 1/3] mesa: Make unreachable macro take a string argument.

Patches 1 & 3 are Reviewed-by: Ian Romanick On 06/30/2014 10:27 AM, Matt Turner wrote: > To aid in debugging. > --- > src/glsl/opt_vectorize.cpp| 3 +-- > src/mesa/drivers/common/meta.c| 3 +-- > src/mesa/drivers/dri/i965/brw_blorp_c

Re: [Mesa-dev] [PATCH 13/23] i965/disasm: Improve disassembly of atomic messages on Haswell+.

On Sat, Jun 28, 2014 at 09:33:52PM -0700, Kenneth Graunke wrote: > This backports the atomic message disassembly support from > gen8_disasm.c, which additionally offers support for decoding atomic > surface read/write messages, and showing SIMD modes and other details. > > Signed-off-by: Kenneth G

Re: [Mesa-dev] [PATCH 1/3] i965: Mark fields in the live interval classes protected.

Patches 1 & 2 are Reviewed-by: Ian Romanick On 06/30/2014 10:11 AM, Matt Turner wrote: > cfg, for instance, is a pointer to a local variable in > calculate_live_intervals, certainly not valid after that function has > returned. > --- > src/mesa/drivers/dri/i965/brw_fs_live_variables.h | 22 >

Re: [Mesa-dev] [PATCH 3/3] i965/vec4: Remove useless conditionals.

On 06/30/2014 10:11 AM, Matt Turner wrote: > Setting a couple of bits is the same cost or less as conditionally > setting a couple of bits. > --- > src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/drivers/d

Re: [Mesa-dev] [PATCH 3/4] i965/fs: Mark predicated PLN instructions with dependency hints.

On 06/29/2014 11:18 PM, Matt Turner wrote: > To implement the unlit_centroid_workaround, previously we emitted > >(+f0) pln(8) g20<1>F g16.4<0,1,0>F g4<8,8,1>F { align1 1Q }; >(-f0) pln(8) g20<1>F g16.4<0,1,0>F g2<8,8,1>F { align1 1Q }; > > where the flag register contains the channel ena

[Mesa-dev] [PATCH 3/3] i965/fs: Mark case unreachable to silence warning.

--- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp index 06ae4a1..90528ed 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp +++ b/src/mesa/driver

[Mesa-dev] [PATCH 1/3] mesa: Make unreachable macro take a string argument.

To aid in debugging. --- src/glsl/opt_vectorize.cpp| 3 +-- src/mesa/drivers/common/meta.c| 3 +-- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 4 +--- src/mesa/drivers/dri/i965/brw_reg.h | 3 +--

Re: [Mesa-dev] [PATCH 12/23] i965/disasm: Actually disassemble Gen7+ URB opcodes.

On Sat, Jun 28, 2014 at 09:33:51PM -0700, Kenneth Graunke wrote: > I never bothered implementing the disassembler for Gen7+ URB opcodes, so > we were just disassembling them as Ironlake/Sandybridge ones. This > looked pretty bad when running Paul's GS EndPrimitive tests, as the > "write OWord" mes

Re: [Mesa-dev] [PATCH 11/23] i965/disasm: Decode Broadwell's invm/rsqrtm math functions.

On Sat, Jun 28, 2014 at 09:33:50PM -0700, Kenneth Graunke wrote: > We don't use these yet, but we may as well disassemble them. > > Signed-off-by: Kenneth Graunke Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_disasm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [Mesa-dev] [PATCH 09/23] i965/disasm: Properly disassemble all32h/any32h align1 predicates.

On Sat, Jun 28, 2014 at 09:33:48PM -0700, Kenneth Graunke wrote: > While we're adding things, use symbolic constants rather than magic > numbers. > > Signed-off-by: Kenneth Graunke Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_disasm.c | 24 +--- > 1

[Mesa-dev] [PATCH] glapi: Mark old ATI_envmap_bumpmap functions as "skip"

From: Ian Romanick There's still a slot for them in the dispatch table, but Mesa won't put anything in that slot anymore. Signed-off-by: Ian Romanick --- Fixes the build. :) This should get squashed in with Jason's v3 patch. src/mapi/glapi/gen/gl_API.xml | 8 1 file changed, 4 inser

Re: [Mesa-dev] [PATCH 10/23] i965/disasm: Properly disassemble the "atomic" ThreadCtrl value.

On Sat, Jun 28, 2014 at 09:33:49PM -0700, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_disasm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Double checked the spec, looks right. Reviewed-by: Kristian Høgsberg > diff --git a/src

Re: [Mesa-dev] [PATCH 08/23] i965: Add #defines for any32h/all32h predication.

On Sat, Jun 28, 2014 at 09:33:47PM -0700, Kenneth Graunke wrote: > These have existed since Ivybridge. We don't use them today, but the > Gen8+ disassembler supports them, and I'd like to use symbolic names > rather than magic numbers. Reviewed-by: Kristian Høgsberg > Signed-off-by: Kenneth Gra

[Mesa-dev] [PATCH 2/3] i965/fs: Pass cfg to calculate_live_intervals().

We've often created the CFG immediately before, so use it when available. --- src/mesa/drivers/dri/i965/brw_fs.h| 2 +- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 3 +-- src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp | 2 +- src/mesa/drivers/d

[Mesa-dev] [PATCH 1/3] i965: Mark fields in the live interval classes protected.

cfg, for instance, is a pointer to a local variable in calculate_live_intervals, certainly not valid after that function has returned. --- src/mesa/drivers/dri/i965/brw_fs_live_variables.h | 22 -- .../drivers/dri/i965/brw_vec4_live_variables.h | 13 +++-- 2 files

[Mesa-dev] [PATCH 3/3] i965/vec4: Remove useless conditionals.

Setting a couple of bits is the same cost or less as conditionally setting a couple of bits. --- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_generator.cpp b/src/mesa/drivers/dri/i9

Re: [Mesa-dev] [PATCH] Remove the ATI_envmap_bumpmap extension

On 06/27/2014 06:42 PM, Jason Ekstrand wrote: > On Fri, Jun 27, 2014 at 5:59 PM, Ian Romanick > wrote: > On 06/27/2014 03:19 PM, Jason Ekstrand wrote: > > diff --git a/src/mapi/glapi/gen/gl_API.xml > b/src/mapi/glapi/gen/gl_API.xml > > index 0a486f0..7b

Re: [Mesa-dev] [PATCH 07/23] i965/disasm: Mark ELSE as having UIP on Gen8+.

On Sat, Jun 28, 2014 at 09:33:46PM -0700, Kenneth Graunke wrote: > This makes brw_disasm.c able to disassemble ELSE instructions correctly > on Broadwell. (gen8_disasm.c already handles this correctly.) > > Signed-off-by: Kenneth Graunke Looks correct, the spec agrees. Reviewed-by: Kristian Hø

Re: [Mesa-dev] [PATCH 05/23] i965/disasm: Improve disassembly of jump targets on Gen6+.

On Sat, Jun 28, 2014 at 09:33:44PM -0700, Kenneth Graunke wrote: > Previously, flow control instructions generated output like: > > (+f0) if(8) 12 8 null 0x000c0008UD { align16 WE_normal 1Q }; > > which included a dissasembly of the register fields, even though those > are meaningless fo

Re: [Mesa-dev] [PATCH 06/23] i965/disasm: Properly disassemble jump targets on Gen4-5.

On Sat, Jun 28, 2014 at 09:33:45PM -0700, Kenneth Graunke wrote: > Previously, our dissasembly for flow control instructions looked like: > > 0x0040: else(8) ip 65540D { align16 switch }; > > It didn't print InstCount properly for ELSE/ENDIF, and didn't even > attempt to

Re: [Mesa-dev] [PATCH 04/23] i965/disasm: Add support for new Gen8+ register types.

On Sat, Jun 28, 2014 at 09:33:43PM -0700, Kenneth Graunke wrote: > While we're at it, use proper names rather than magic numbers for the > existing fields. > > Signed-off-by: Kenneth Graunke That's a lot less magic. Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_disasm.

Re: [Mesa-dev] [PATCH 01/23] i965/disasm: Eliminate opcode pointer.

On Sat, Jun 28, 2014 at 09:33:40PM -0700, Kenneth Graunke wrote: > opcode is just a pointer to opcode_descs; we may as well use that > directly. > > Signed-off-by: Kenneth Graunke Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_disasm.c | 15 +++ > 1 file chan

Re: [Mesa-dev] [PATCH 02/23] i965/disasm: Create an "opcode" temporary.

On Sat, Jun 28, 2014 at 09:33:41PM -0700, Kenneth Graunke wrote: > This saves typing brw_inst_opcode(brw, inst) everywhere. Reviewed-by: Kristian Høgsberg > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_disasm.c | 61 > +- > 1 file cha

Re: [Mesa-dev] [PATCH 3/4] i965/fs: Mark predicated PLN instructions with dependency hints.

On Sun, Jun 29, 2014 at 11:18:16PM -0700, Matt Turner wrote: > To implement the unlit_centroid_workaround, previously we emitted > >(+f0) pln(8) g20<1>F g16.4<0,1,0>F g4<8,8,1>F { align1 1Q }; >(-f0) pln(8) g20<1>F g16.4<0,1,0>F g2<8,8,1>F { align1 1Q }; > > where the flag register contai

Re: [Mesa-dev] [PATCH 2/4] i965/fs: Predicate PLN instructions used in unlit centroid WA.

On Sun, Jun 29, 2014 at 11:18:15PM -0700, Matt Turner wrote: > Maybe lets us skip some PLN instructions if whole subspans are disabled? Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 20 ++-- > 1 file changed, 14 insertions(+), 6 deletions(-) > >

Re: [Mesa-dev] [PATCH 1/4] i965/fs: Add no_dd_{clear, check} fields to fs_inst.

On Sun, Jun 29, 2014 at 11:18:14PM -0700, Matt Turner wrote: > And plumb them through. Also make the assert in the generator look like > the vec4 one. > --- > src/mesa/drivers/dri/i965/brw_fs.h | 2 ++ > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 14 -- > 2 files cha

Re: [Mesa-dev] [PATCH 4/4] i965/fs: Disable unlit_centroid_workaround on Haswell.

On Mon, Jun 30, 2014 at 12:31 AM, Kenneth Graunke wrote: > On Sunday, June 29, 2014 11:18:17 PM Matt Turner wrote: > >> Although the HSW PRM shows it, the BSpec lists this workaround as being > >> for Ivybridge only. > >> > >> total instructions in shared programs: 1994951 -> 1993675 (-0.06%) > >>

Re: [Mesa-dev] [PATCH 0/6] Enable Pixman for Mesa

On Mon, Jun 30, 2014 at 3:18 AM, Juha-Pekka Heikkila < juhapekka.heikk...@gmail.com> wrote: > On 25.06.2014 23:47, Matt Turner wrote: > > On Wed, Jun 25, 2014 at 5:38 AM, Juha-Pekka Heikkila > > wrote: > >> This is my old set which enable using Pixman on Mesa for some texture > >> conversion fast

Re: [Mesa-dev] [PATCH 2/4] gallium: add cap to show that fs can accept layer/viewport inputs

Looks like it'll be a while before someone can look at my r600 patch which makes layer/viewport available in the fragment shader. Roland, would you be OK with a version of this patch which adds a new CAP for viewport/layer support in FS? (To be enabled only on nv50/nvc0 for now.) The cap can later

[Mesa-dev] [PATCH] mesa: Fix regression introduced by commit "mesa: fix packing of float texels to GL_SHORT/GL_BYTE".

This commit "mesa: fix packing of float texels to GL_SHORT/GL_BYTE" replaced *_TO_BYTE to *_TO_BYTE_TEX because *_TO_FLOAT_TEX are used to unpack the texels to floats. In this case *_TO_FLOATZ in function extract_float_rgba also should be replaced to *_TO_FLOAT_TEX. Underline that these macros a

[Mesa-dev] [Bug 80069] rendering problems: black areas in KDE desktop. [mesa 10.2.1 (not with 10.1.4)]

https://bugs.freedesktop.org/show_bug.cgi?id=80069 CarlEitsger <4607vrfcr84spd21...@weg-werf-email.de> changed: What|Removed |Added Status|NEW |RESO

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 80069, which changed state. Bug 80069 Summary: rendering problems: black areas in KDE desktop. [mesa 10.2.1 (not with 10.1.4)] https://bugs.freedesktop.org/show_bug.cgi?id=80069 What|Removed

Re: [Mesa-dev] [PATCH 0/6] Enable Pixman for Mesa

On 25.06.2014 23:47, Matt Turner wrote: > On Wed, Jun 25, 2014 at 5:38 AM, Juha-Pekka Heikkila > wrote: >> This is my old set which enable using Pixman on Mesa for some texture >> conversion fast paths. As is this passes Piglit quick set on my IVB. > > Pixman doesn't actually have fast paths for

[Mesa-dev] [PATCH 2/2] i965: Workaround for hardware bug in multi-stream transform feedback.

There is a hardware bug that breaks TF recording in multi-stream mode when emitting vertices to a stream that does not have any varyings to record. If that happens, and the vertex is the last vertex emitted by the geometry shader, varying data is not recorded for any stream and primitive queries (t

[Mesa-dev] [PATCH 1/2] i965: Disable unused transform feedback buffers.

If we are not recording any varying data to a particular transform feedback buffer, disable it. --- src/mesa/drivers/dri/i965/gen7_sol_state.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_sol_state.c b/src/mesa/drivers/dri/i965/gen7_so

[Mesa-dev] [PATCH 0/2] Workaround for hardware bug in multi-stream transform feedback.

These are two patches implementing a work around for the possible hardware bug I introduced in another e-mail. I think the first patch is valid in any case, the second one implements the actual workaround but it requires the first patch for it to work. We will also write a couple of piglit tests t

Re: [Mesa-dev] OpenGL on Wayland

On Friday, June 27, 2014 08:08:21 PM Kalrish Bäakjen wrote: > Hello, > > I am working on a project that uses EGL and defers drawing to render > modules. To maintain compatibility with Wayland and avoid being tied to X, > I have chosen OpenGL ES 3. As it is difficult for me to find information > abo

Re: [Mesa-dev] [PATCH 4/4] i965/fs: Disable unlit_centroid_workaround on Haswell.

On Sunday, June 29, 2014 11:18:17 PM Matt Turner wrote: > Although the HSW PRM shows it, the BSpec lists this workaround as being > for Ivybridge only. > > total instructions in shared programs: 1994951 -> 1993675 (-0.06%) > instructions in affected programs: 27325 -> 26049 (-4.67%) > --- > sr

Re: [Mesa-dev] [PATCH] i965/fs: Let sat-prop ignore live ranges if producer already has sat.

On Sunday, June 29, 2014 11:18:33 PM Matt Turner wrote: > This sequence (where both x and w are used afterwards) wasn't handled. > >mul.sat x, y, z >... >mov.sat w, x > > We assumed that if x was used after the mov.sat, that we couldn't > propagate the saturate modifier, but in fact x w