[Mesa-dev] [PATCH] gallivm: Fix build with LLVM = 3.6 r215967.

2014-08-20 Thread Vinson Lee
This LLVM 3.6 commit changed EngineBuilder constructor. commit 3f4ed32b4398eaf4fe0080d8001ba01e6c2f43c8 Author: Rafael Espindola rafael.espind...@gmail.com Date: Tue Aug 19 04:04:25 2014 + Make it explicit that ExecutionEngine takes ownership of the modules. git-svn-id:

[Mesa-dev] [PATCH] gallivm: Fix build against LLVM SVN = r215967

2014-08-20 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp

[Mesa-dev] [PATCH] st/clover: Fix build against LLVM SVN = r215967

2014-08-20 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp

Re: [Mesa-dev] [PATCH] gallivm: Fix build with LLVM = 3.6 r215967.

2014-08-20 Thread Michel Dänzer
On 20.08.2014 15:17, Vinson Lee wrote: This LLVM 3.6 commit changed EngineBuilder constructor. commit 3f4ed32b4398eaf4fe0080d8001ba01e6c2f43c8 Author: Rafael Espindola rafael.espind...@gmail.com Date: Tue Aug 19 04:04:25 2014 + Make it explicit that ExecutionEngine takes

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Francisco Jerez
Connor Abbott cwabbo...@gmail.com writes: On Tue, Aug 19, 2014 at 11:40 AM, Francisco Jerez curroje...@riseup.net wrote: Tom Stellard t...@stellard.net writes: On Tue, Aug 19, 2014 at 11:04:59AM -0400, Connor Abbott wrote: On Mon, Aug 18, 2014 at 8:52 PM, Michel Dänzer mic...@daenzer.net

[Mesa-dev] [PATCHv3 07/16] glsl: protect anonymous struct id with a mutex

2014-08-20 Thread Chia-I Wu
There may be two contexts compiling shaders at the same time, and we want the anonymous struct id to be globally unique. Signed-off-by: Chia-I Wu o...@lunarg.com Reviewed-by: Brian Paul bri...@vmware.com Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/glsl_parser_extras.cpp | 10

[Mesa-dev] [PATCHv3 03/16] util: initialize locale_t with a static object

2014-08-20 Thread Chia-I Wu
_mesa_strtod and _mesa_strtof may be called from multiple threads. They need to be thread-safe. Signed-off-by: Chia-I Wu o...@lunarg.com Reviewed-by: Brian Paul bri...@vmware.com Reviewed-by: Ian Romanick ian.d.roman...@intel.com v2: platform checks are now done in configure.ac ---

[Mesa-dev] [PATCHv3 11/16] mesa: add infrastructure for threaded shader compilation

2014-08-20 Thread Chia-I Wu
Add _mesa_enable_glsl_threadpool to enable the thread pool for a context, and add ctx-Const.DeferCompileShader and ctx-Const.DeferLinkProgram to fine-control what gets threaded. Setting DeferCompileShader to true will make _mesa_glsl_compile_shader be executed in a worker thread. The function is

[Mesa-dev] [PATCHv3 05/16] util: add a generic thread pool data structure

2014-08-20 Thread Chia-I Wu
It can be used to implement, for example, threaded glCompileShader and glLinkProgram. Two basic tests are included to verify the basic functions, and to give us some confidence about its thread-safety. v2: allow tasks to complete other tasks Signed-off-by: Chia-I Wu o...@lunarg.com Reviewed-by:

[Mesa-dev] [PATCHv3 02/16] configure: check for xlocale.h and strtof

2014-08-20 Thread Chia-I Wu
With the assumptions that xlocale.h implies newlocale and strtof_l. SCons is updated to define HAVE_XLOCALE_H on linux and darwin. Signed-off-by: Chia-I Wu o...@lunarg.com --- configure.ac| 3 +++ scons/gallium.py| 4 src/util/strtod.cpp | 12 3 files changed, 11

[Mesa-dev] [PATCHv3 10/16] mesa: protect the debug state with a mutex

2014-08-20 Thread Chia-I Wu
We are about to change mesa to spawn threads for deferred glCompileShader and glLinkProgram, and we need to make sure those threads can send compiler warnings/errors to the debug output safely. Signed-off-by: Chia-I Wu o...@lunarg.com Reviewed-by: Brian Paul bri...@vmware.com Reviewed-by: Ian

[Mesa-dev] [PATCHv3 16/16] i965: enable threaded precompile

2014-08-20 Thread Chia-I Wu
Inherit gl_shader_program and add save/restore functions to save precompile results in the shader programs. When DeferLinkProgram is set, we will save the precompile results instead of uploading them immediately because we may be on a different thread. A few other modifications are also needed.

[Mesa-dev] [PATCHv3 04/16] util: move simple_list.h from core to util

2014-08-20 Thread Chia-I Wu
It belongs to util, and we will need it from within util. Signed-off-by: Chia-I Wu o...@lunarg.com --- src/mesa/drivers/dri/i915/i830_texblend.c | 2 +- src/mesa/drivers/dri/i915/intel_syncobj.c | 2 +- src/mesa/drivers/dri/r200/r200_cmdbuf.c| 2 +-

[Mesa-dev] [PATCHv3 08/16] glsl: protect glsl_type with a mutex

2014-08-20 Thread Chia-I Wu
glsl_type has several static hash tables and a static ralloc context. They need to be protected by a mutex as they are not thread-safe. Signed-off-by: Chia-I Wu o...@lunarg.com Reviewed-by: Brian Paul bri...@vmware.com Reviewed-by: Ian Romanick ian.d.roman...@intel.com ---

[Mesa-dev] [PATCHv3 12/16] i965: add drirc option multithread_glsl_compiler

2014-08-20 Thread Chia-I Wu
Setting it to a non-zero value N will cause shader compilation to be deferred to a thread pool. When N is greater than 1, it indicates the maximum number of threads in the pool. When N is 1, the number of threads is up to the driver (two for i965). Signed-off-by: Chia-I Wu o...@lunarg.com

[Mesa-dev] [PATCHv3 14/16] i965: refactor do_gs_prog

2014-08-20 Thread Chia-I Wu
Split do_gs_prog into brw_gs_init_compile brw_gs_do_compile brw_gs_upload_compile brw_gs_clear_complile Signed-off-by: Chia-I Wu o...@lunarg.com Acked-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/brw_vec4_gs.c | 161 1 file

[Mesa-dev] [PATCHv3 15/16] i965: refactor do_wm_prog

2014-08-20 Thread Chia-I Wu
Split do_wm_prog into brw_wm_init_compile brw_wm_do_compile brw_wm_upload_compile brw_wm_clear_complile Add struct brw_wm_compile to be passed around them. Signed-off-by: Chia-I Wu o...@lunarg.com Acked-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/brw_wm.c |

[Mesa-dev] [PATCHv3 09/16] glsl: integrate with the singleton thread pool

2014-08-20 Thread Chia-I Wu
The singleton thread pool will be used by contexts to queue compilation tasks. We need to control its lieftime from the compiler. Signed-off-by: Chia-I Wu o...@lunarg.com --- src/glsl/glsl_parser_extras.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/glsl_parser_extras.cpp

[Mesa-dev] [PATCHv3 01/16] util: add _mesa_strtod and _mesa_strtof

2014-08-20 Thread Chia-I Wu
Both core mesa and glsl have their own wrappers for strtof_l. Merge and move them to util/. They are compiled with a C++ compiler so that we can make them thread-safe in a following commit. Signed-off-by: Chia-I Wu o...@lunarg.com --- src/glsl/Makefile.sources| 3 +-

[Mesa-dev] [PATCHv3 00/16] multithread shader compiler

2014-08-20 Thread Chia-I Wu
Hi, This is v3 of the series. It should have all the changes I promised to fix. There are some new or splitted patches because _mesa_strtof, simple_list, and thread pool are now moved to src/util/. To summarize, Patch 1-3 merge mesa and glsl strtof wrappers and moves them to src/util/. They go

[Mesa-dev] [PATCHv3 06/16] util: allow the thread pool to be used as a singleton

2014-08-20 Thread Chia-I Wu
To have a real control over the number of driver threads, we almost never want more than a single thread pool. Signed-off-by: Chia-I Wu o...@lunarg.com Reviewed-by: Brian Paul bri...@vmware.com Reviewed-by: Ian Romanick ian.d.roman...@intel.com v2: split glsl changes to another commit ---

[Mesa-dev] [PATCHv3 13/16] i965: refactor do_vs_prog

2014-08-20 Thread Chia-I Wu
Split do_vs_prog into brw_vs_init_compile brw_vs_do_compile brw_vs_upload_compile brw_vs_clear_complile Signed-off-by: Chia-I Wu o...@lunarg.com Acked-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/brw_vec4.h | 6 ++ src/mesa/drivers/dri/i965/brw_vs.c | 121

[Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- No piglit regressions on nvc0 except for gl-3.0-render-integer, which appears to now fail even without this commit, despite the fact that I'm fairly sure it used to work fine. Same failure with llvmpipe... It's most likely that I've missed some

[Mesa-dev] [PATCH 1/2] mesa: force height of 1D textures to be 1 in texture views

2014-08-20 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/mesa/main/textureview.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/textureview.c b/src/mesa/main/textureview.c index b3521e2..6e86a9a 100644 --- a/src/mesa/main/textureview.c +++ b/src/mesa/main/textureview.c @@

Re: [Mesa-dev] [PATCH] st/clover: Fix build against LLVM SVN = r215967

2014-08-20 Thread Francisco Jerez
Michel Dänzer mic...@daenzer.net writes: From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 4 1 file changed, 4 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] st/clover: Fix build against LLVM SVN = r215967

2014-08-20 Thread Michel Dänzer
On 20.08.2014 15:48, Francisco Jerez wrote: Michel Dänzer mic...@daenzer.net writes: From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 4 1 file changed, 4 insertions(+) diff

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Christian König
I think we can fix this by introducing new structured variants of the branch instruction in a way that doesn't alter the fundamental structure of the IR. E.g. an if branch could look like: ifbr i1 cond, label iftrue, label iffalse, label join Where both branches are guaranteed to converge at

Re: [Mesa-dev] Clamp/saturate optimizations v3

2014-08-20 Thread Abdiel Janulgue
On 20.08.2014 05:40, Matt Turner wrote: Patches 2-4, (5-9 already reviewed), 10, 13-16, (17 already reviewed) are Reviewed-by: Matt Turner matts...@gmail.com I've requested a change come before patch 1, and then rebased patch 1 should be an easy R-b. I'll need to take a closer look

Re: [Mesa-dev] [PATCH] st/clover: Fix build against LLVM SVN = r215967

2014-08-20 Thread Francisco Jerez
Michel Dänzer mic...@daenzer.net writes: On 20.08.2014 15:48, Francisco Jerez wrote: Michel Dänzer mic...@daenzer.net writes: From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 4

[Mesa-dev] [PATCH V4 1/3] mesa: implement GL_MAX_VERTEX_ATTRIB_STRIDE

2014-08-20 Thread Timothy Arceri
V2: moved test for the VertexAttrib*Pointer() functions to update_array(), and made constant available for drivers to set Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- Although 4.4 is a while away GL_MAX_VERTEX_ATTRIB_STRIDE is used in the ARB_direct_state_access spec so it seemed

[Mesa-dev] [PATCH V4 3/3] docs: mark GL_MAX_VERTEX_ATTRIB_STRIDE as done

2014-08-20 Thread Timothy Arceri
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 76412c3..af26214 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -172,7 +172,7 @@ GL 4.3, GLSL 4.30: GL 4.4, GLSL 4.40: -

[Mesa-dev] [PATCH V4 2/3] gallium: add cap for MAX_VERTEX_ATTRIB_STRIDE

2014-08-20 Thread Timothy Arceri
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- Note: I have only compile tested this patch with ilo. src/gallium/docs/source/screen.rst | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 3 +++ src/gallium/drivers/i915/i915_screen.c | 3 +++

Re: [Mesa-dev] [PATCH 00/37] Geometry shader support in Sandy Bridge

2014-08-20 Thread Iago Toral
El 2014-08-16 09:11, Jordan Justen escribió: On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga ito...@igalia.com wrote: Hi, this series brings support for geometry shaders in Sandy Bridge (gen6) and is combined work from Samuel and myself. A few notes: 1.- Some patches have been based on

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Michel Dänzer
On 20.08.2014 00:04, Connor Abbott wrote: On Mon, Aug 18, 2014 at 8:52 PM, Michel Dänzer mic...@daenzer.net wrote: On 19.08.2014 01:28, Connor Abbott wrote: On Mon, Aug 18, 2014 at 4:32 AM, Michel Dänzer mic...@daenzer.net wrote: On 16.08.2014 09:12, Connor Abbott wrote: I know what you might

Re: [Mesa-dev] [PATCH] pipe-loader: Fix memory leak v2

2014-08-20 Thread Emil Velikov
On 20 August 2014 00:49, Tom Stellard thomas.stell...@amd.com wrote: CC: 10.2 mesa-sta...@lists.freedesktop.org v2: - Change driver_name to char* I knew there was a reason as to why I put a comment in there. Thanks for tracking it down Tom. Reviewed-by: Emil Velikov emil.l.veli...@gmail.com

Re: [Mesa-dev] [PATCH 00/37] Geometry shader support in Sandy Bridge

2014-08-20 Thread Samuel Iglesias Gonsálvez
On Wed, 2014-08-20 at 11:16 +0200, Iago Toral wrote: El 2014-08-16 09:11, Jordan Justen escribió: On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga ito...@igalia.com wrote: Hi, this series brings support for geometry shaders in Sandy Bridge (gen6) and is combined work from

Re: [Mesa-dev] [PATCH 37/37] i965/gen6: enable OpenGL 3.2

2014-08-20 Thread Samuel Iglesias Gonsálvez
On Thu, 2014-08-14 at 08:46 -0700, Matt Turner wrote: On Thu, Aug 14, 2014 at 4:12 AM, Iago Toral Quiroga ito...@igalia.com wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com --- I'd squash the last two patches

[Mesa-dev] EGL_KHR_vg_parent_image extenstion

2014-08-20 Thread Peter Hanzel
Hello. I want to use EGL_KHR_vg_parent_image extension. I did grep on Mesa source code but found nothing. Then I looked on google and found this: http://lists.freedesktop.org/archives/mesa-dev/2010-September/002900.html Then I looked at mesa cgit and it looks like this was not merged. So mesa

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Connor Abbott
On Tue, Aug 19, 2014 at 11:33 PM, Francisco Jerez curroje...@riseup.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Tue, Aug 19, 2014 at 11:40 AM, Francisco Jerez curroje...@riseup.net wrote: Tom Stellard t...@stellard.net writes: On Tue, Aug 19, 2014 at 11:04:59AM -0400, Connor

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Connor Abbott
On Wed, Aug 20, 2014 at 2:41 AM, Michel Dänzer mic...@daenzer.net wrote: On 20.08.2014 00:04, Connor Abbott wrote: On Mon, Aug 18, 2014 at 8:52 PM, Michel Dänzer mic...@daenzer.net wrote: On 19.08.2014 01:28, Connor Abbott wrote: On Mon, Aug 18, 2014 at 4:32 AM, Michel Dänzer

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Christian König
Am 20.08.2014 um 14:33 schrieb Connor Abbott: On Tue, Aug 19, 2014 at 11:57 PM, Christian König deathsim...@vodafone.de wrote: I think we can fix this by introducing new structured variants of the branch instruction in a way that doesn't alter the fundamental structure of the IR. E.g. an if

Re: [Mesa-dev] EGL_KHR_vg_parent_image extenstion

2014-08-20 Thread Emil Velikov
On 20/08/14 12:42, Peter Hanzel wrote: Hello. I want to use EGL_KHR_vg_parent_image extension. I did grep on Mesa source code but found nothing. Then I looked on google and found this: http://lists.freedesktop.org/archives/mesa-dev/2010-September/002900.html Then I looked at mesa cgit

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Francisco Jerez
Connor Abbott cwabbo...@gmail.com writes: On Tue, Aug 19, 2014 at 11:33 PM, Francisco Jerez curroje...@riseup.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Tue, Aug 19, 2014 at 11:40 AM, Francisco Jerez curroje...@riseup.net wrote: Tom Stellard t...@stellard.net writes: On

Re: [Mesa-dev] [PATCH 3/3] clover: unsure compat::string is \0 terminated

2014-08-20 Thread Francisco Jerez
EdB e...@sigluy.net writes: Each time you call c_str() it will grow up, may be you could check if the string is already \0 terminated before adding it. Nope, that's not how it works. Every time c_str() is called the size of the underlying array is forced to at least size-of-the-actual-string

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Olivier Galibert
And don't forget that explicit vec4 becomes immensely amusing once you add fp64/double to the problem. OG. On Wed, Aug 20, 2014 at 4:01 PM, Francisco Jerez curroje...@riseup.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Tue, Aug 19, 2014 at 11:33 PM, Francisco Jerez

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Connor Abbott
On Wed, Aug 20, 2014 at 5:57 AM, Christian König deathsim...@vodafone.de wrote: Am 20.08.2014 um 14:33 schrieb Connor Abbott: On Tue, Aug 19, 2014 at 11:57 PM, Christian König deathsim...@vodafone.de wrote: I think we can fix this by introducing new structured variants of the branch

Re: [Mesa-dev] [PATCH 0/2] kms-swrast: PRIME and missing defines

2014-08-20 Thread Emil Velikov
On 15/08/14 22:32, Andreas Pokorny wrote: Hi, This adds support for dma_buf fds to kms_swrast. This is especially interesting for drm capable drivers like qxl or udl. The former recently gained prime support. The second part adds a few defines that werent set anywhere else, but are

Re: [Mesa-dev] [PATCH 2/2] kms-swrast: defines missing to build kms-swrast

2014-08-20 Thread Emil Velikov
I have pushed a similar patch (commit 16873a6e62e) a couple of days before your post. Afaics it should already cover this case ? -Emil On 15/08/14 22:32, Andreas Pokorny wrote: --- src/gallium/state_trackers/dri/Makefile.am | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 1/2] kms-swrast: Support Prime fd handling

2014-08-20 Thread Emil Velikov
On 15/08/14 22:32, Andreas Pokorny wrote: Allows using prime fds as display target and from display target. Test for PRIME capability after initializing kms_swrast screen. Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com --- src/gallium/state_trackers/dri/dri2.c |

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Didn't look at it that closely, but I'm pretty surprised this really works. One things ARB_texture_view can do is cast cube maps (and cube map arrays) to 2d arrays and vice versa (also 1d/2d to the respective array type), and we cannot express that in sampler views (yet) (we can't express it in

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Connor Abbott
On Wed, Aug 20, 2014 at 7:01 AM, Francisco Jerez curroje...@riseup.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Tue, Aug 19, 2014 at 11:33 PM, Francisco Jerez curroje...@riseup.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Tue, Aug 19, 2014 at 11:40 AM, Francisco Jerez

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Ilia Mirkin
Hm, it's not tested. And you're right, that would (most likely) mess up, since it would only have the pipe_resource's target. Any suggestions on how to fix it? Should the target be added to pipe_sampler_view? On Wed, Aug 20, 2014 at 11:25 AM, Roland Scheidegger srol...@vmware.com wrote: Didn't

[Mesa-dev] [PATCH] r600g: Fix flat/smooth shade state toggle

2014-08-20 Thread Glenn Kennard
If only the flat/smooth shade state changed between two calls the prior code would miss updating the hardware state. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=81967 Signed-off-by: Glenn Kennard glenn.kenn...@gmail.com --- Tested on radeon 6670, no piglit regressions

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Ilia Mirkin
On Wed, Aug 20, 2014 at 11:47 AM, Jose Fonseca jfons...@vmware.com wrote: On 20/08/14 16:31, Ilia Mirkin wrote: Hm, it's not tested. And you're right, that would (most likely) mess up, since it would only have the pipe_resource's target. Any suggestions on how to fix it? Should the target be

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 17:47, schrieb Jose Fonseca: On 20/08/14 16:31, Ilia Mirkin wrote: Hm, it's not tested. And you're right, that would (most likely) mess up, since it would only have the pipe_resource's target. Any suggestions on how to fix it? Should the target be added to pipe_sampler_view?

Re: [Mesa-dev] Mesa: tag mesa-10.2.6: Mesa 10.2.6 release

2014-08-20 Thread Brian Paul
On 08/19/2014 04:18 PM, Carl Worth wrote: Module: Mesa Branch: refs/tags/mesa-10.2.6 Tag:1d329590143b4236e8c706b80b6551502f5cb780 URL:

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Jose Fonseca
On 20/08/14 17:02, Roland Scheidegger wrote: Am 20.08.2014 17:47, schrieb Jose Fonseca: On 20/08/14 16:31, Ilia Mirkin wrote: Hm, it's not tested. And you're right, that would (most likely) mess up, since it would only have the pipe_resource's target. Any suggestions on how to fix it? Should

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 17:55, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 11:47 AM, Jose Fonseca jfons...@vmware.com wrote: On 20/08/14 16:31, Ilia Mirkin wrote: Hm, it's not tested. And you're right, that would (most likely) mess up, since it would only have the pipe_resource's target. Any

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Jose Fonseca
On 20/08/14 17:14, Roland Scheidegger wrote: Am 20.08.2014 17:55, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 11:47 AM, Jose Fonseca jfons...@vmware.com wrote: On 20/08/14 16:31, Ilia Mirkin wrote: Hm, it's not tested. And you're right, that would (most likely) mess up, since it would only

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Ilia Mirkin
On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca jfons...@vmware.com wrote: On 20/08/14 17:14, Roland Scheidegger wrote: Am 20.08.2014 17:55, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 11:47 AM, Jose Fonseca jfons...@vmware.com wrote: On 20/08/14 16:31, Ilia Mirkin wrote: Hm, it's not

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 18:12, schrieb Jose Fonseca: On 20/08/14 17:02, Roland Scheidegger wrote: Am 20.08.2014 17:47, schrieb Jose Fonseca: On 20/08/14 16:31, Ilia Mirkin wrote: Hm, it's not tested. And you're right, that would (most likely) mess up, since it would only have the pipe_resource's

Re: [Mesa-dev] [PATCHv3 11/16] mesa: add infrastructure for threaded shader compilation

2014-08-20 Thread Fredrik Höglund
On Wednesday 20 August 2014, Chia-I Wu wrote: Add _mesa_enable_glsl_threadpool to enable the thread pool for a context, and add ctx-Const.DeferCompileShader and ctx-Const.DeferLinkProgram to fine-control what gets threaded. Setting DeferCompileShader to true will make

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Jose Fonseca
On 20/08/14 17:33, Ilia Mirkin wrote: On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca jfons...@vmware.com wrote: On 20/08/14 17:14, Roland Scheidegger wrote: Am 20.08.2014 17:55, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 11:47 AM, Jose Fonseca jfons...@vmware.com wrote: On 20/08/14

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 18:33, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca jfons...@vmware.com wrote: On 20/08/14 17:14, Roland Scheidegger wrote: Am 20.08.2014 17:55, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 11:47 AM, Jose Fonseca jfons...@vmware.com wrote: On 20/08/14

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Connor Abbott
On Wed, Aug 20, 2014 at 12:11 PM, Francisco Jerez curroje...@riseup.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Wed, Aug 20, 2014 at 7:01 AM, Francisco Jerez curroje...@riseup.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Tue, Aug 19, 2014 at 11:33 PM, Francisco Jerez

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Kenneth Graunke
On Wednesday, August 20, 2014 06:41:08 PM Michel Dänzer wrote: On 20.08.2014 00:04, Connor Abbott wrote: On Mon, Aug 18, 2014 at 8:52 PM, Michel Dänzer mic...@daenzer.net wrote: On 19.08.2014 01:28, Connor Abbott wrote: On Mon, Aug 18, 2014 at 4:32 AM, Michel Dänzer mic...@daenzer.net

Re: [Mesa-dev] [PATCH] r600g: Fix flat/smooth shade state toggle

2014-08-20 Thread Marek Olšák
Generally, only states which need a full shader compilation must be in the shader key. Flatshade is not one of them, because it only causes register updates, so this is not a proper solution. Or I am missing something? Marek On Wed, Aug 20, 2014 at 5:34 PM, Glenn Kennard

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 20:13, schrieb Kenneth Graunke: On Wednesday, August 20, 2014 06:41:08 PM Michel Dänzer wrote: On 20.08.2014 00:04, Connor Abbott wrote: On Mon, Aug 18, 2014 at 8:52 PM, Michel Dänzer mic...@daenzer.net wrote: On 19.08.2014 01:28, Connor Abbott wrote: On Mon, Aug 18, 2014 at

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Matt Turner
On Wed, Aug 20, 2014 at 11:28 AM, Roland Scheidegger srol...@vmware.com wrote: Am 20.08.2014 20:13, schrieb Kenneth Graunke: For example, Debian was stuck on Mesa 9.2.2 for 4 months (2013-12-08 to 2014-03-22), and I was told this was because of LLVM versioning changes in the other drivers

Re: [Mesa-dev] [PATCH] r600g: Fix flat/smooth shade state toggle

2014-08-20 Thread Glenn Kennard
On Wed, 20 Aug 2014 20:16:50 +0200, Marek Olšák mar...@gmail.com wrote: Generally, only states which need a full shader compilation must be in the shader key. Flatshade is not one of them, because it only causes register updates, so this is not a proper solution. Or I am missing something?

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Matt Turner
On Wed, Aug 20, 2014 at 11:13 AM, Kenneth Graunke kenn...@whitecape.org wrote: Gentoo has also had trouble updating for similar reasons; Matt (the Gentoo Mesa package mantainer) can probably comment more. Yes, at one point we were stuck two releases behind current Mesa (and this is Gentoo!)

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Tom Stellard
On Wed, Aug 20, 2014 at 11:13:13AM -0700, Kenneth Graunke wrote: On Wednesday, August 20, 2014 06:41:08 PM Michel Dänzer wrote: On 20.08.2014 00:04, Connor Abbott wrote: On Mon, Aug 18, 2014 at 8:52 PM, Michel Dänzer mic...@daenzer.net wrote: On 19.08.2014 01:28, Connor Abbott wrote:

Re: [Mesa-dev] [PATCHv3 01/16] util: add _mesa_strtod and _mesa_strtof

2014-08-20 Thread Kenneth Graunke
On Wednesday, August 20, 2014 02:40:22 PM Chia-I Wu wrote: Both core mesa and glsl have their own wrappers for strtof_l. Merge and move them to util/. They are compiled with a C++ compiler so that we can make them thread-safe in a following commit. Signed-off-by: Chia-I Wu o...@lunarg.com

Re: [Mesa-dev] [PATCH] r600g: Fix flat/smooth shade state toggle

2014-08-20 Thread Marek Olšák
The flag is only used to set S_028644_FLAT_SHADE on all r600g chips. I don't see it being used by the shader code generation. Marek On Wed, Aug 20, 2014 at 8:50 PM, Glenn Kennard glenn.kenn...@gmail.com wrote: On Wed, 20 Aug 2014 20:16:50 +0200, Marek Olšák mar...@gmail.com wrote: Generally,

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Tom Stellard
On Tue, Aug 19, 2014 at 05:19:15PM -0700, Connor Abbott wrote: On Tue, Aug 19, 2014 at 3:57 PM, Tom Stellard t...@stellard.net wrote: On Tue, Aug 19, 2014 at 01:37:56PM -0700, Connor Abbott wrote: On Tue, Aug 19, 2014 at 11:40 AM, Francisco Jerez curroje...@riseup.net wrote: Tom

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Stéphane Marchesin
On Wed, Aug 20, 2014 at 11:56 AM, Matt Turner matts...@gmail.com wrote: On Wed, Aug 20, 2014 at 11:13 AM, Kenneth Graunke kenn...@whitecape.org wrote: Gentoo has also had trouble updating for similar reasons; Matt (the Gentoo Mesa package mantainer) can probably comment more. Yes, at one

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Connor Abbott
On Wed, Aug 20, 2014 at 12:17 PM, Tom Stellard t...@stellard.net wrote: On Tue, Aug 19, 2014 at 05:19:15PM -0700, Connor Abbott wrote: On Tue, Aug 19, 2014 at 3:57 PM, Tom Stellard t...@stellard.net wrote: On Tue, Aug 19, 2014 at 01:37:56PM -0700, Connor Abbott wrote: On Tue, Aug 19, 2014 at

Re: [Mesa-dev] [PATCH 03/19] glx/drisw: add support for DRI2rendererQueryExtension

2014-08-20 Thread Emil Velikov
On 20/08/14 19:32, Jon TURNEY wrote: On 18/08/2014 13:08, Emil Velikov wrote: On 18/08/14 12:47, Jon TURNEY wrote: On 14/08/2014 23:18, Emil Velikov wrote: The extension is used by GLX_MESA_query_renderer, which can be provided for by hardware and software drivers. v2: Use designated

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Henri Verbeet
On 20 August 2014 20:13, Kenneth Graunke kenn...@whitecape.org wrote: I've also heard stories from friends of mine who use radeonsi that they couldn't get new GL features or compiler fixes unless they upgrade both Mesa /and/ LLVM, and that LLVM was usually either not released or not available

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Matt Turner
On Wed, Aug 20, 2014 at 12:16 PM, Stéphane Marchesin stephane.marche...@gmail.com wrote: On Wed, Aug 20, 2014 at 11:56 AM, Matt Turner matts...@gmail.com wrote: Having multiple versions installed in parallel breaks down pretty easily. Where do the headers go? Where do all the executables go? Do

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Tom Stellard
On Wed, Aug 20, 2014 at 11:56:32AM -0700, Matt Turner wrote: On Wed, Aug 20, 2014 at 11:13 AM, Kenneth Graunke kenn...@whitecape.org wrote: Gentoo has also had trouble updating for similar reasons; Matt (the Gentoo Mesa package mantainer) can probably comment more. Yes, at one point we

Re: [Mesa-dev] [PATCH] r600g: Fix flat/smooth shade state toggle

2014-08-20 Thread Glenn Kennard
On Wed, 20 Aug 2014 21:04:34 +0200, Marek Olšák mar...@gmail.com wrote: The flag is only used to set S_028644_FLAT_SHADE on all r600g chips. I don't see it being used by the shader code generation. Marek Ah, i see. Will respin patch with an alternate solution that won't require shader

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Tom Stellard
On Wed, Aug 20, 2014 at 12:26:15PM -0700, Connor Abbott wrote: On Wed, Aug 20, 2014 at 12:17 PM, Tom Stellard t...@stellard.net wrote: On Tue, Aug 19, 2014 at 05:19:15PM -0700, Connor Abbott wrote: On Tue, Aug 19, 2014 at 3:57 PM, Tom Stellard t...@stellard.net wrote: On Tue, Aug 19, 2014

[Mesa-dev] [PATCH 3/4] dri/radeon: cleanup the radeon_context vtbl

2014-08-20 Thread Emil Velikov
Remove the set-but-unused, and set-but-empty vtable entries. Most likely a leftover from the dri1 days. Cc: Marek Olšák marek.ol...@amd.com Cc: Michel Dänzer michel.daen...@amd.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/mesa/drivers/dri/r200/r200_context.c | 24

[Mesa-dev] [PATCH v2] r600g: Fix flat/smooth shade state toggle

2014-08-20 Thread Glenn Kennard
If only the flat/smooth shade state changed between two render calls the prior code would miss updating the hardware state. Also add check for sprite coord, potentially same type of issue otherwise for it. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=81967 Signed-off-by: Glenn Kennard

[Mesa-dev] [PATCH 4/4] dri/radeon: nuke the remaining references to sarea

2014-08-20 Thread Emil Velikov
It was an 'interesting' feature which I'm clad we not longer use as of dri2. Cc: Marek Olšák marek.ol...@amd.com Cc: Michel Dänzer michel.daen...@amd.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/mesa/drivers/dri/r200/r200_ioctl.c | 7 ---

[Mesa-dev] [PATCH 1/4] dri/radeon: drop obsolete radeon_{dri, macros}.h headers

2014-08-20 Thread Emil Velikov
Both have been unused for at least a couple of years. For example the last user of radeon_macros.h was removed with commit 8c11f0a88300f7bc3f05a12789c781ba0f4b3cc6 Author: Eric Anholt e...@anholt.net Date: Fri Oct 14 13:27:02 2011 -0700 radeon: Drop the legacy BO manager code. Cc: Marek

[Mesa-dev] [PATCH 2/4] include: move sarea.h next to it's only user

2014-08-20 Thread Emil Velikov
The header is used by DRI1 drivers, which we've removed a while back. Now only the dri1 loader in libGL is using it, so let's move it in src/glx, and prefix it accordingly. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- include/GL/internal/sarea.h | 92

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 20:45, schrieb Matt Turner: On Wed, Aug 20, 2014 at 11:28 AM, Roland Scheidegger srol...@vmware.com wrote: Am 20.08.2014 20:13, schrieb Kenneth Graunke: For example, Debian was stuck on Mesa 9.2.2 for 4 months (2013-12-08 to 2014-03-22), and I was told this was because of LLVM

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 18:48, schrieb Roland Scheidegger: Am 20.08.2014 18:33, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca jfons...@vmware.com wrote: On 20/08/14 17:14, Roland Scheidegger wrote: Am 20.08.2014 17:55, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 11:47 AM, Jose

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Ilia Mirkin
On Wed, Aug 20, 2014 at 4:12 PM, Roland Scheidegger srol...@vmware.com wrote: Am 20.08.2014 18:48, schrieb Roland Scheidegger: Am 20.08.2014 18:33, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca jfons...@vmware.com wrote: On 20/08/14 17:14, Roland Scheidegger wrote: Am

[Mesa-dev] [Bug 79629] [Dri3 bisected] piglit glx_GLX_ARB_create_context_current_with_no_framebuffer fail

2014-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79629 --- Comment #7 from dog paul.a.parent...@intel.com --- DRI3 is still being developed/stabilized and its interaction with fences poorly specified. Mesa does not yet utilize the explicit fences implied in the spec. Chris will disable DRI3 by

[Mesa-dev] [Bug 79629] [Dri3 bisected] piglit glx_GLX_ARB_create_context_current_with_no_framebuffer fail

2014-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79629 dog paul.a.parent...@intel.com changed: What|Removed |Added Depends on||81551 -- You are

Re: [Mesa-dev] [PATCH 17/20] i965: Preserve CFG when deleting dead control flow.

2014-08-20 Thread Matt Turner
On Tue, Aug 19, 2014 at 12:36 PM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Tue, Aug 19, 2014 at 12:03:01PM -0700, Matt Turner wrote: By the way, I committed the first 6 patches of the series (the one touching the generators had started to rot). I think other than 16 and 17, the

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 22:27, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 4:12 PM, Roland Scheidegger srol...@vmware.com wrote: Am 20.08.2014 18:48, schrieb Roland Scheidegger: Am 20.08.2014 18:33, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca jfons...@vmware.com wrote: On

[Mesa-dev] [Bug 79629] [Dri3 bisected] piglit glx_GLX_ARB_create_context_current_with_no_framebuffer fail

2014-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79629 Bastien Nocera bugzi...@hadess.net changed: What|Removed |Added CC||bugzi...@hadess.net

[Mesa-dev] [Bug 76188] EGL_EXT_image_dma_buf_import fd ownership is incorrect

2014-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76188 --- Comment #8 from Matt Turner matts...@gmail.com --- (In reply to comment #7) I see little risk in cherry-picking the fix to stable branches. The fix is isolated and only *removes* code. I do see risk in not cherry-picking the fix. If an

Re: [Mesa-dev] [PATCH 1/4] dri/radeon: drop obsolete radeon_{dri, macros}.h headers

2014-08-20 Thread Marek Olšák
Sorry, I don't know much about these drivers to be able to review this. Marek On Wed, Aug 20, 2014 at 9:54 PM, Emil Velikov emil.l.veli...@gmail.com wrote: Both have been unused for at least a couple of years. For example the last user of radeon_macros.h was removed with commit

Re: [Mesa-dev] [PATCH 1/4] dri/radeon: drop obsolete radeon_{dri, macros}.h headers

2014-08-20 Thread Emil Velikov
No problems Marek. Your name popped up at the top of the list based on your recent bugfixes in the area. I believe that Michel and/or Alex will have some (unfortunate) recollection about these drivers :) -Emil On 20/08/14 23:05, Marek Olšák wrote: Sorry, I don't know much about these drivers

[Mesa-dev] [Bug 82881] New: test_vec4_register_coalesce regression

2014-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82881 Priority: medium Bug ID: 82881 Keywords: regression CC: matts...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: test_vec4_register_coalesce regression

  1   2   >