[Mesa-dev] [PATCH 07/11] mesa/main: Check allocations success in _mesa_one_time_init_extension_overrides()

2014-09-08 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/extensions.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 553c01e..43f0e8d 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -609,6 +609,15

[Mesa-dev] [PATCH 11/11] egl: extra null checks for get_xcb_screen() return values

2014-09-08 Thread Juha-Pekka Heikkila
verify get_xcb_screen() returned pointer before using it. Signed-off-by: Juha-Pekka Heikkila --- src/egl/drivers/dri2/platform_x11.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl/drivers/dri2/pla

[Mesa-dev] [PATCH 09/11] meta: Avoid null access on setup_glsl_msaa_blit_shader()

2014-09-08 Thread Juha-Pekka Heikkila
On default fallback path there was null access on src_rb Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/common/meta_blit.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common/meta_blit.c

[Mesa-dev] [PATCH 02/11] mesa: add null checks in symbol_table.c

2014-09-08 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/symbol_table.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/mesa/program/symbol_table.c b/src/mesa/program/symbol_table.c index 9462978..5b22745 100644 --- a/src/mesa/program/symbol_table.c +++ b/sr

[Mesa-dev] [PATCH 10/11] meta: Fix error paths in meta_copy_image.c

2014-09-08 Thread Juha-Pekka Heikkila
If _mesa_get_tex_image() return NULL there is already error set in context. Other error pats free allocated texture. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/common/meta_copy_image.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/drivers/common/meta_copy_ima

[Mesa-dev] [PATCH 05/11] loader: Check dlsym() did not fail in libudev_get_device_name_for_fd()

2014-09-08 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/loader/loader.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/loader/loader.c b/src/loader/loader.c index bdd3906..94c993a 100644 --- a/src/loader/loader.c +++ b/src/loader/loader.c @@ -594,6 +594,9 @@ libudev_get_device_name_for_fd(int fd)

[Mesa-dev] [PATCH 00/11] Klocwork set again.

2014-09-08 Thread Juha-Pekka Heikkila
Klocwork set again, rebased and added with fixes for meta and egl. /Juha-Pekka Juha-Pekka Heikkila (11): glsl: add missing null check in tfeedback_decl::init() mesa: add null checks in symbol_table.c i965: Avoid null access in intelMakeCurrent() glsl: Check calloc return value in link_int

[Mesa-dev] [PATCH 03/11] i965: Avoid null access in intelMakeCurrent()

2014-09-08 Thread Juha-Pekka Heikkila
separate two null checks connected with && to their own if branches. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/dri/i965/brw_context.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 01/11] glsl: add missing null check in tfeedback_decl::init()

2014-09-08 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glsl/link_varyings.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 54ceae1..a738e2f 100644 --- a/src/glsl/link_varyings.cpp +++ b/src/glsl/link_varyings.cpp @@ -318,6 +318,11 @@ t

[Mesa-dev] [PATCH 06/11] glsl: Check realloc return value in ir_function::matching_signature()

2014-09-08 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glsl/ir_function.cpp | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/glsl/ir_function.cpp b/src/glsl/ir_function.cpp index 98bec45..2b2643c 100644 --- a/src/glsl/ir_function.cpp +++ b/src/glsl/ir_function.cpp @@ -24,6

[Mesa-dev] [PATCH 04/11] glsl: Check calloc return value in link_intrastage_shaders()

2014-09-08 Thread Juha-Pekka Heikkila
Check calloc return value while adding build-in functions. Signed-off-by: Juha-Pekka Heikkila --- src/glsl/linker.cpp | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 57be493..abc1035 100644 --- a/src/glsl/linker

[Mesa-dev] [PATCH 08/11] i965: Add extra null check in intel_bufferobj_alloc()

2014-09-08 Thread Juha-Pekka Heikkila
Check calloc returned requested memory. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/dri/i965/intel_buffer_objects.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_buffer_objects.c b/src/mesa/drivers/dri/i965/intel_buffer_objects.c index 96dacd

[Mesa-dev] [Bug 83195] destroy GL context on stall recovery

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83195 --- Comment #3 from Stanisław Halik --- Just to be extra-clear: Talking about GPU reset procedure. The one where dmesg prints register state. Is that enough context or is further info needed? -sh -- You are receiving this mail because: You

Re: [Mesa-dev] [PATCH] glsl: allow precision qualifier on sampler arrays

2014-09-08 Thread Tapani Pälli
On 09/09/2014 09:10 AM, Tapani Pälli wrote: > Hi Frank; > > Kalyan sent me a similar fix mentioning that it is related to this test > case: > https://www.khronos.org/registry/webgl/sdk/tests/conformance/limits/gl-min-textures.html > > If your patch is related, please mention in the commit message.

Re: [Mesa-dev] [PATCH] glsl: allow precision qualifier on sampler arrays

2014-09-08 Thread Tapani Pälli
Hi Frank; Kalyan sent me a similar fix mentioning that it is related to this test case: https://www.khronos.org/registry/webgl/sdk/tests/conformance/limits/gl-min-textures.html If your patch is related, please mention in the commit message. It helps to track possible regression in the future. Wi

[Mesa-dev] [PATCH] r600g, radeonsi: Set RADEON_GEM_NO_CPU_ACCESS flag for tiled BOs

2014-09-08 Thread Michel Dänzer
From: Michel Dänzer This lets the kernel know that such BOs can be pinned outside of the CPU accessible part of VRAM. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeon/r600_buffer_common.c | 1 + src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 12 +--- src/gallium/winsys/r

[Mesa-dev] [Bug 83636] [LLVM 3.5] Mesa32 build failure with LLVM 3.5.

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83636 Vladimir Ysikov changed: What|Removed |Added CC||granti...@gmail.com -- You are receiv

Re: [Mesa-dev] [PATCH v2] r600g: Implement GL_ARB_sample_shading

2014-09-08 Thread Dieter Nützel
Am 05.09.2014 00:14, schrieb Glenn Kennard: Also fixes two sided lighting which was broken at least on pre-evergreen by commit b1eb00. Maybe there is a (Mesa-demos) test case around? Signed-off-by: Glenn Kennard --- Changes since patch v1: Factor out and set sample positions also for pre-eve

Re: [Mesa-dev] [PATCH 1/2] configure: enable the gallium loader only when needed

2014-09-08 Thread Matt Turner
On Mon, Sep 8, 2014 at 6:21 PM, Matt Turner wrote: > On Mon, Sep 8, 2014 at 4:56 PM, Ausmus, James wrote: >> Thanks Emil - works great! >> >> Tested-by: James Ausmus > > You know, if you care about image size, you shouldn't be building > Gallium at all. Neither of the two Intel drivers use it.

Re: [Mesa-dev] [PATCH 1/2] configure: enable the gallium loader only when needed

2014-09-08 Thread Matt Turner
On Mon, Sep 8, 2014 at 4:56 PM, Ausmus, James wrote: > Thanks Emil - works great! > > Tested-by: James Ausmus You know, if you care about image size, you shouldn't be building Gallium at all. Neither of the two Intel drivers use it. ___ mesa-dev mailin

Re: [Mesa-dev] [PATCH] drm/radeon: Add RADEON_GEM_CPU_ACCESS BO creation flag

2014-09-08 Thread Michel Dänzer
On 09.09.2014 09:47, Michel Dänzer wrote: > On 09.09.2014 02:36, Alex Deucher wrote: >> >> Updated version with comments integrated. > > [...] > >> @@ -314,10 +314,12 @@ int radeon_bo_pin_restricted(struct radeon_bo >> *bo, u32 domain, u64 max_offset, >> unsigned lpfn = 0; >> >>

[Mesa-dev] [PATCH v3 3/3] nv50,nvc0: enable ARB_texture_view

2014-09-08 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- Erm... oops, that will obviously modify 10.4.html relnotes, not 10.3. But no one looks at these nouveau changes anyways... docs/GL3.txt | 2 +- docs/relnotes/10.3.html| 1 + src/gallium/drivers/nouveau/nv50

[Mesa-dev] [PATCH v3 2/3] mesa/st: add ARB_texture_view support

2014-09-08 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- Roland, it was unclear to me whether you were happy with this change or not. v2 -> v3: no change src/mesa/state_tracker/st_atom_texture.c | 30 src/mesa/state_tracker/st_cb_fbo.c | 10 ++ src/mesa/state_tracker/st_cb_texture.c | 62 +

[Mesa-dev] [PATCH v3 1/3] gallium: add a texture target to sampler view and a CAP to use it

2014-09-08 Thread Ilia Mirkin
This allows a sampler view to have a different texture target than the underlying resource. This will be used to implement the type casting between 2d arrays and cube maps as specified in ARB_texture_view. Signed-off-by: Ilia Mirkin Reviewed-by: Roland Scheidegger --- Roland thought this change

Re: [Mesa-dev] [PATCH] drm/radeon: Add RADEON_GEM_CPU_ACCESS BO creation flag

2014-09-08 Thread Michel Dänzer
On 09.09.2014 02:36, Alex Deucher wrote: Updated version with comments integrated. [...] @@ -314,10 +314,12 @@ int radeon_bo_pin_restricted(struct radeon_bo *bo, u32 domain, u64 max_offset, unsigned lpfn = 0; /* force to pin into visible video ram */ -

Re: [Mesa-dev] [PATCH 1/2] configure: enable the gallium loader only when needed

2014-09-08 Thread Ausmus, James
Thanks Emil - works great! Tested-by: James Ausmus On Mon, Sep 8, 2014 at 3:52 PM, Emil Velikov wrote: > With the gallium megadrivers we've converted most ST to optionally > use either statically linked in or shared pipe-drivers. > > The hardcoded switch forgot to conditionally enable the buil

Re: [Mesa-dev] [PATCH 3/3] meta: Avoid shader recompilation for msaa color resolve blit

2014-09-08 Thread Anuj Phogat
On Sat, Sep 6, 2014 at 4:49 PM, Dave Airlie wrote: > coverity reported a use before NULL check for src_rb in the below code, > > maybe it was there already, but it noticed it now you changed it, > > we check src_rb->NumSamples then later src_rb is checked. Could you take a > look. > Yes, the issu

[Mesa-dev] [Bug 83636] New: [LLVM 3.5] Mesa32 build failure with LLVM 3.5.

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83636 Priority: medium Bug ID: 83636 Assignee: mesa-dev@lists.freedesktop.org Summary: [LLVM 3.5] Mesa32 build failure with LLVM 3.5. Severity: normal Classification: Unclassified

[Mesa-dev] [PATCH 2/2] automake: remove obsolete NEED_GALLIUM_LOADER

2014-09-08 Thread Emil Velikov
Superseded by HAVE_LOADER_GALLIUM. The latter has a *DRM* brethren making the whose easier on which one to keep. Signed-off-by: Emil Velikov --- configure.ac | 1 - src/gallium/Makefile.am | 2 +- src/gallium/auxiliary/Makefile.am

[Mesa-dev] [PATCH 1/2] configure: enable the gallium loader only when needed

2014-09-08 Thread Emil Velikov
With the gallium megadrivers we've converted most ST to optionally use either statically linked in or shared pipe-drivers. The hardcoded switch forgot to conditionally enable the build of the shared pipe-drivers which resulted in them being constantly build. Cc: "10.3" Cc: James Ausmus Reported

[Mesa-dev] [Bug 83631] /usr/include/GL/glxext.h:480:143: error: 'GLintptr' has not been declared

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83631 --- Comment #2 from Orion Poplawski --- /usr/include/GL/glext.h:#define GL_GLEXT_VERSION 20140810 But we're including "GL/glx.h" which includes "GL/glxext.h", not "GL/glext.h". Too many x's floating around here. # grep '^typedef .* GLintptr;'

[Mesa-dev] [Bug 83631] /usr/include/GL/glxext.h:480:143: error: 'GLintptr' has not been declared

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83631 --- Comment #1 from Brian Paul --- Which version of glext.h (look for "GL_GLEXT_VERSION")? In version 20140810 it's defined on line 469: typedef ptrdiff_t GLintptr; -- You are receiving this mail because: You are the assignee for the bug. ___

Re: [Mesa-dev] XDC2014: Call for paper

2014-09-08 Thread Martin Peres
Le 02/05/2014 00:52, Martin Peres a écrit : Hello, I have the pleasure to announce that the X.org Developer Conference 2014 will be held in Bordeaux, France from October 8th to October 10th. The venue is located in the campus of the University of Bordeaux 1, in the computer science research lab

Re: [Mesa-dev] [PATCH] ir_to_mesa: Stop converting uniform booleans.

2014-09-08 Thread Matt Turner
On Mon, Sep 8, 2014 at 2:28 PM, Kenneth Graunke wrote: > Excess conversions considered harmful. > > Recently Matt reworked the boolean uniform handling to use the value of > UniformBooleanTrue, rather than integer 1, when uploading uniforms: > > mesa: Upload boolean uniforms using UniformBoole

Re: [Mesa-dev] [Mesa-stable] [PATCH] Suppress any "libGL:..." warnings when LIBGL_DEBUG == "quiet"

2014-09-08 Thread Courtney Goeltzenleuchter
Looks good to me. Matches what ErrorMessageF is doing. Reviewed-by: Courtney Goeltzenleuchter On Tue, Aug 26, 2014 at 2:47 PM, Johannes Obermayr wrote: > From: Stefan Dirsch > > Let's handle LIBGL_DEBUG env. variable in Mesa in a consistent way. > > Fixes: https://bugzilla.novell.com/show_bug

[Mesa-dev] [PATCH] ir_to_mesa: Stop converting uniform booleans.

2014-09-08 Thread Kenneth Graunke
Excess conversions considered harmful. Recently Matt reworked the boolean uniform handling to use the value of UniformBooleanTrue, rather than integer 1, when uploading uniforms: mesa: Upload boolean uniforms using UniformBooleanTrue. glsl: Use UniformBooleanTrue value for uniform initial

[Mesa-dev] [Bug 83631] New: /usr/include/GL/glxext.h:480:143: error: 'GLintptr' has not been declared

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83631 Priority: medium Bug ID: 83631 Assignee: mesa-dev@lists.freedesktop.org Summary: /usr/include/GL/glxext.h:480:143: error: 'GLintptr' has not been declared Severity: normal

Re: [Mesa-dev] [PATCH] r600g, radeonsi: add debug option which forces DMA for copy_region and blit

2014-09-08 Thread Axel Davy
Le 08/09/2014 21:11, Grigori Goronzy a écrit : On 08.09.2014 21:07, Axel Davy wrote: On 08/09/2014 20:21, Grigori Goronzy wrote : On 08.09.2014 14:50, Axel Davy wrote: Hi, When reading si_dma.c code, it looks like the requested width of the copy is ignored except for PIPE_BUFFER. Perhaps that

[Mesa-dev] [PATCH v2 0/5] Fix handling of LnAn and RnGn formats for big-endian

2014-09-08 Thread Christian Zigotzky
Hi, Thanks to Richard for these patches. Well done! Are these patches in the latest Mesa version? Rgds, Christian On 07/22/2014 03:51 AM, Richard Sandiford wrote: >> MESA_FORMAT_LnAn_* puts the luminance in the low part of the integer and >> the alpha in the high part. The same goes for MES

Re: [Mesa-dev] [PATCH] Add support for NV_depth_buffer_float v2.

2014-09-08 Thread Chris Forbes
Given that this was an unintentional relaxation in the 4.2 spec (and so there is no non-NV way to invoke this behavior), I don't think we want the line in the 4.2 block of GL3.txt. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.free

[Mesa-dev] [Bug 83570] Glyphy demo throws unhandled Integer division by zero exception

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83570 --- Comment #11 from Roland Scheidegger --- (In reply to comment #10) > Could be totally borked, but this is what I have at the moment: > >if (type.floating) { > return LLVMBuildFDiv(builder, a, b, ""); >} >else { > //The

Re: [Mesa-dev] [PATCH 11/20] i965/fs: Make count_to_loop_end() use basic blocks.

2014-09-08 Thread Matt Turner
On Tue, Sep 2, 2014 at 9:34 PM, Matt Turner wrote: > When the instructions aren't in a flat list, this wouldn't have worked. > Also, this should be faster. > --- > src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 28 > +++ > 1 file changed, 13 insertions(+), 15 deletions(-

[Mesa-dev] [PATCH 2/5] i965/fs: Walk instructions in reverse in saturate propagation.

2014-09-08 Thread Matt Turner
When we find a mov.sat, we search backwards. We might as well search everything else backwards as well and potentially look at fewer instructions. This change enables the next patch. --- src/mesa/drivers/dri/i965/brw_fs_saturate_propagation.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 delet

[Mesa-dev] [PATCH 4/5] i965/fs: Don't invalidate live intervals in saturate propagation.

2014-09-08 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs_saturate_propagation.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_saturate_propagation.cpp b/src/mesa/drivers/dri/i965/brw_fs_saturate_propagation.cpp index 6f7fb6c..347a78e 100644 --- a/src/mesa/dr

[Mesa-dev] [PATCH 3/5] i965/fs: Ignore mov.sat instructions in interference check in sat prop.

2014-09-08 Thread Matt Turner
When an instruction's result was consumed by multiple mov.sat instructions, we would decide that we couldn't move the saturate modifier because something else was using the result, even though it was just another mov.sat! total instructions in shared programs: 4275598 -> 4274842 (-0.02%) instructi

[Mesa-dev] [PATCH 1/5] i965/fs: Extend predicated break pass to predicate WHILE.

2014-09-08 Thread Matt Turner
Helps a handful of programs in Serious Sam 3 that use do-while loops. instructions in affected programs: 16114 -> 16075 (-0.24%) --- This patch depends on the save-cfg series. .../dri/i965/brw_fs_peephole_predicated_break.cpp | 37 ++ 1 file changed, 37 insertions(+) di

[Mesa-dev] [PATCH 5/5] glsl: Recognize open-coded pow(x, y).

2014-09-08 Thread Matt Turner
pow(x, y) is equivalent to exp(log(x) * y). instructions in affected programs: 578 -> 458 (-20.76%) --- src/glsl/opt_algebraic.cpp | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index 447618f..0cdb8ec 100644 --- a/sr

Re: [Mesa-dev] [PATCH] Add support for NV_depth_buffer_float v2.

2014-09-08 Thread Marek Olšák
Do we have a piglit to confirm unclamped Z values really work with current hardware drivers? Marek On Mon, Sep 8, 2014 at 6:39 PM, Mathias Fröhlich wrote: > > Hi, > > On Monday, September 08, 2014 13:16:27 Roland Scheidegger wrote: >> > Add support for the unclamped versions of glDepthRange >> >

Re: [Mesa-dev] [PATCH] r600g, radeonsi: add debug option which forces DMA for copy_region and blit

2014-09-08 Thread Grigori Goronzy
On 08.09.2014 21:07, Axel Davy wrote: > On 08/09/2014 20:21, Grigori Goronzy wrote : >> On 08.09.2014 14:50, Axel Davy wrote: >>> Hi, >>> >>> When reading si_dma.c code, it looks like the requested width of the >>> copy is ignored except for PIPE_BUFFER. >>> Perhaps that explains the bugs observed

Re: [Mesa-dev] [PATCH] r600g, radeonsi: add debug option which forces DMA for copy_region and blit

2014-09-08 Thread Axel Davy
On 08/09/2014 20:21, Grigori Goronzy wrote : On 08.09.2014 14:50, Axel Davy wrote: Hi, When reading si_dma.c code, it looks like the requested width of the copy is ignored except for PIPE_BUFFER. Perhaps that explains the bugs observed ? It isn't ignored. Partial DMA copies (i.e. operations t

Re: [Mesa-dev] [PATCH] r600g, radeonsi: add debug option which forces DMA for copy_region and blit

2014-09-08 Thread Grigori Goronzy
On 08.09.2014 14:50, Axel Davy wrote: > Hi, > > When reading si_dma.c code, it looks like the requested width of the > copy is ignored except for PIPE_BUFFER. > Perhaps that explains the bugs observed ? > It isn't ignored. Partial DMA copies (i.e. operations that do not copy whole lines) are simp

[Mesa-dev] [PATCH 1/2] meta: Implement ext_framebuffer_multisample_blit_scaled extension

2014-09-08 Thread Anuj Phogat
Extension enables doing a multisample buffer resolve and buffer scaling using a single glBlitFrameBuffer() call. Currently, we have this extension implemented in BLORP which is only used by SNB and IVB. This patch implements the extension in meta path which makes it available to Broadwell. Impleme

[Mesa-dev] [PATCH 2/2] i965: Enable EXT_framebuffer_multisample_blit_scaled for gen8

2014-09-08 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_extensions.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 046d2a1..10fe10e 100644 --- a/src/mesa/drivers/dri/i

Re: [Mesa-dev] [PATCH] Add support for NV_depth_buffer_float v2.

2014-09-08 Thread Emil Velikov
Hi Mathias On 08/09/14 17:39, Mathias Fröhlich wrote: > > Hi, > > On Monday, September 08, 2014 13:16:27 Roland Scheidegger wrote: >>> Add support for the unclamped versions of glDepthRange >>> and relatives. Also starting with OpenGL 4.2 the traditional >>> functions for this should no longer cl

Re: [Mesa-dev] [PATCH 3/3] gallivm: (trivial) don't try to use rcp when the division 1/x is integer

2014-09-08 Thread Jose Fonseca
Series looks good to me too. Jose From: srol...@vmware.com Sent: 08 September 2014 12:56 To: Jose Fonseca; mesa-dev@lists.freedesktop.org Cc: Roland Scheidegger Subject: [PATCH 3/3] gallivm: (trivial) don't try to use rcp when the division 1/x is integer

[Mesa-dev] [PATCH v2] r600: Use DMA transfers in r600_copy_global_buffer

2014-09-08 Thread Niels Ole Salscheider
v2: Do not demote items that are already in the pool Signed-off-by: Niels Ole Salscheider --- src/gallium/drivers/r600/evergreen_compute.h | 1 + src/gallium/drivers/r600/r600_blit.c | 59 2 files changed, 43 insertions(+), 17 deletions(-) diff --git a/src/

Re: [Mesa-dev] [PATCH 06/20] i965: Preserve the CFG in instruction scheduling.

2014-09-08 Thread Matt Turner
On Mon, Sep 8, 2014 at 5:43 AM, Pohjolainen, Topi wrote: > On Tue, Sep 02, 2014 at 09:34:17PM -0700, Matt Turner wrote: >> --- >> .../drivers/dri/i965/brw_schedule_instructions.cpp | 74 >> -- >> 1 file changed, 42 insertions(+), 32 deletions(-) >> >> diff --git a/src/mesa/dr

Re: [Mesa-dev] [PATCH] drm/radeon: Add RADEON_GEM_CPU_ACCESS BO creation flag

2014-09-08 Thread Alex Deucher
On Thu, Aug 28, 2014 at 9:46 PM, Michel Dänzer wrote: > On 29.08.2014 00:01, Alex Deucher wrote: >> On Thu, Aug 28, 2014 at 4:57 AM, Christian König >> wrote: >>> Am 28.08.2014 um 08:56 schrieb Michel Dänzer: >>> From: Michel Dänzer This flag is a hint that userspace expects the B

[Mesa-dev] [Bug 83570] Glyphy demo throws unhandled Integer division by zero exception

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83570 --- Comment #10 from rcond...@hotmail.com --- Could be totally borked, but this is what I have at the moment: if (type.floating) { return LLVMBuildFDiv(builder, a, b, ""); } else { //The spec says divide by zero is undefined,

Re: [Mesa-dev] [PATCH] Add support for NV_depth_buffer_float v2.

2014-09-08 Thread Mathias Fröhlich
Hi, On Monday, September 08, 2014 13:16:27 Roland Scheidegger wrote: > > Add support for the unclamped versions of glDepthRange > > and relatives. Also starting with OpenGL 4.2 the traditional > > functions for this should no longer clamp the values to [0, 1]. > This looks wrong to me (the NV_dep

Re: [Mesa-dev] [PATCH] r600: Use DMA transfers in r600_copy_global_buffer

2014-09-08 Thread Niels Ole Salscheider
On Monday 08 September 2014, 15:19:15, Bruno Jimenez wrote: > Hi, > > I'm not sure if this will work. Imagine this case: > > We have an item in the pool, and we want to use > r600_resource_copy_region with it, for example because we want to demote > it. This will call r600_copy_global_buffer, an

[Mesa-dev] [Bug 83567] Mesa 10.2.6 does not compile with llvm 3.5

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83567 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] Linking fails when not writing gl_Position.

2014-09-08 Thread Kenneth Graunke
On Monday, September 08, 2014 11:10:42 AM Tapani Pälli wrote: > From: Kalyan Kondapally > > According to GLSL-ES Spec(i.e. 1.0, 3.0), gl_Position value is undefined > after the vertex processing stage if we don't write gl_Position. However, > GLSL 1.10 Spec mentions that writing to gl_Position is

[Mesa-dev] [Bug 83573] [swrast] piglit fs-op-not-bool-using-if regression

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83573 Kenneth Graunke changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@l

[Mesa-dev] [Bug 83573] [swrast] piglit fs-op-not-bool-using-if regression

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83573 --- Comment #2 from Ilia Mirkin --- On quick inspection that's happening in _mesa_propagate_uniforms_to_driver_storage The format gets set to uniform_bool_float which in turn goes through ((float *) dst)[c] = (float) *isrc; -- You are receiv

[Mesa-dev] [Bug 83573] [swrast] piglit fs-op-not-bool-using-if regression

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83573 Kenneth Graunke changed: What|Removed |Added CC||bri...@vmware.com, |

[Mesa-dev] [Bug 83570] Glyphy demo throws unhandled Integer division by zero exception

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83570 --- Comment #9 from Roland Scheidegger --- (In reply to comment #8) > for the llvm version I was going to return bld->undef. I figure I might as > well change tgsi_exec.c version to 0x for consistency...but I don't > have strong feelings

Re: [Mesa-dev] [Mesa-stable] [PATCH] Suppress any "libGL:..." warnings when LIBGL_DEBUG == "quiet"

2014-09-08 Thread Emil Velikov
Gents, Can anyone review this trivial patch ? Stefan, Johannes Why do I need to register in order to view the bugreport ? Afaict it is not a security issue, so I believe the bug should be publicly accessible. -Emil On 26/08/14 21:47, Johannes Obermayr wrote: > From: Stefan Dirsch > > Let's ha

Re: [Mesa-dev] [PATCH] mesa/st: don't advertise NV_vdpau_interop if it doesn't work.

2014-09-08 Thread Ilia Mirkin
On Mon, Sep 8, 2014 at 9:50 AM, Christian König wrote: > From: Christian König > > As long as we don't have a workaround for frame based > decoding in VDPAU we should not advertise NV_vdpau_interop. > > v2: fix commit message, check if get_video_param is present > > Signed-off-by: Christian König

Re: [Mesa-dev] [PATCH 3/3] gallivm: (trivial) don't try to use rcp when the division 1/x is integer

2014-09-08 Thread Brian Paul
On 09/08/2014 05:56 AM, srol...@vmware.com wrote: From: Roland Scheidegger This would just crash. Noticed by accident while checking int divisions by zero with a quickly hacked piglit test. --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH] mesa/st: don't advertise NV_vdpau_interop if it doesn't work.

2014-09-08 Thread Christian König
From: Christian König As long as we don't have a workaround for frame based decoding in VDPAU we should not advertise NV_vdpau_interop. v2: fix commit message, check if get_video_param is present Signed-off-by: Christian König Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/state_tracker/s

Re: [Mesa-dev] [PATCH] pipe-loader: Include unistd.h in pipe_loader_drm.c for close function.

2014-09-08 Thread Brian Paul
On 09/06/2014 05:00 PM, Vinson Lee wrote: This patch fixes a build error on DragonFly. CC libpipe_loader_la-pipe_loader_drm.lo pipe_loader_drm.c: In function 'pipe_loader_drm_probe': pipe_loader_drm.c:207:10: error: implicit declaration of function 'close' [-Werror=implicit-function-de

Re: [Mesa-dev] [PATCH 11/20] i965/fs: Make count_to_loop_end() use basic blocks.

2014-09-08 Thread Pohjolainen, Topi
On Tue, Sep 02, 2014 at 09:34:22PM -0700, Matt Turner wrote: > When the instructions aren't in a flat list, this wouldn't have worked. > Also, this should be faster. > --- > src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 28 > +++ > 1 file changed, 13 insertions(+), 15 de

Re: [Mesa-dev] [PATCH] r600: Use DMA transfers in r600_copy_global_buffer

2014-09-08 Thread Bruno Jimenez
Hi, I'm not sure if this will work. Imagine this case: We have an item in the pool, and we want to use r600_resource_copy_region with it, for example because we want to demote it. This will call r600_copy_global_buffer, and with your patch it will call r600_compute_global_demote_or_alloc, which

[Mesa-dev] [Bug 83570] Glyphy demo throws unhandled Integer division by zero exception

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83570 --- Comment #8 from rcond...@hotmail.com --- for the llvm version I was going to return bld->undef. I figure I might as well change tgsi_exec.c version to 0x for consistency...but I don't have strong feelings either way. -- You are recei

Re: [Mesa-dev] [PATCH 10/20] i965/vec4: Don't use instruction list after calculating the cfg.

2014-09-08 Thread Pohjolainen, Topi
On Tue, Sep 02, 2014 at 09:34:21PM -0700, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_shader.cpp| 2 +- > src/mesa/drivers/dri/i965/brw_vec4.cpp | 14 +++--- > src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 3 ++- > src/mesa/driver

Re: [Mesa-dev] [PATCH 08/20] i965: Remove now unneeded calls to calculate_cfg().

2014-09-08 Thread Pohjolainen, Topi
On Tue, Sep 02, 2014 at 09:34:19PM -0700, Matt Turner wrote: > Now that nothing invalidates the CFG, we can calculate_cfg() immediately > after emit_fb_writes()/emit_thread_end() and never again. Reviewed-by: Topi Pohjolainen ___ mesa-dev mailing list m

Re: [Mesa-dev] [PATCH 09/20] i965/fs: Don't use instruction list after calculating the cfg.

2014-09-08 Thread Pohjolainen, Topi
On Tue, Sep 02, 2014 at 09:34:20PM -0700, Matt Turner wrote: > The only trick is changing a break into a return true in register > coalescing, since the macro is actually a double loop, and break will do > something different than you expect. (Wish I'd realized that earlier!) I didn't double check

Re: [Mesa-dev] [PATCH 07/20] i965: Remove cfg-invalidating parameter from invalidate_live_intervals.

2014-09-08 Thread Pohjolainen, Topi
On Tue, Sep 02, 2014 at 09:34:18PM -0700, Matt Turner wrote: > Everything has been converted to preserve the CFG. > --- Reviewed-by: Topi Pohjolainen ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/

[Mesa-dev] [Bug 83463] [swrast] piglit glsl-vs-clamp-1 regression

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83463 Abdiel Janulgue changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |xynop...@gmail.com |

Re: [Mesa-dev] [PATCH] r600g, radeonsi: add debug option which forces DMA for copy_region and blit

2014-09-08 Thread Axel Davy
Hi, When reading si_dma.c code, it looks like the requested width of the copy is ignored except for PIPE_BUFFER. Perhaps that explains the bugs observed ? Axel Davy On 06/09/2014 19:14, Andy Furniss wrote : Marek Olšák wrote: From: Marek Olšák --- Turn this on, run piglit, and pray for m

Re: [Mesa-dev] [PATCH 06/20] i965: Preserve the CFG in instruction scheduling.

2014-09-08 Thread Pohjolainen, Topi
On Tue, Sep 02, 2014 at 09:34:17PM -0700, Matt Turner wrote: > --- > .../drivers/dri/i965/brw_schedule_instructions.cpp | 74 > -- > 1 file changed, 42 insertions(+), 32 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp > b/src/mesa/driver

[Mesa-dev] [Bug 83570] Glyphy demo throws unhandled Integer division by zero exception

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83570 --- Comment #7 from Roland Scheidegger --- (In reply to comment #6) > (In reply to comment #5) > > Actually, I think it would be a good idea if you could return 0x > > instead of 0. This is typically what GPUs will do, since the d3d10 doc

[Mesa-dev] [Bug 83570] Glyphy demo throws unhandled Integer division by zero exception

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83570 --- Comment #6 from Roland Scheidegger --- (In reply to comment #5) > Actually, I think it would be a good idea if you could return 0x > instead of 0. This is typically what GPUs will do, since the d3d10 docs > claim this is required, bot

[Mesa-dev] [Bug 83570] Glyphy demo throws unhandled Integer division by zero exception

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83570 --- Comment #5 from Roland Scheidegger --- Actually, I think it would be a good idea if you could return 0x instead of 0. This is typically what GPUs will do, since the d3d10 docs claim this is required, both for div and mod - http://msdn

[Mesa-dev] [PATCH 2/3] docs: (trivial) mark softpipe, llvmpipe as done for GL_ARB_base_instance

2014-09-08 Thread sroland
From: Roland Scheidegger Forgot to add it when I fixed up the start instance handling in (llvm) draw. --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index f5d5e72..f02ad67 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -138,7 +13

[Mesa-dev] [PATCH 3/3] gallivm: (trivial) don't try to use rcp when the division 1/x is integer

2014-09-08 Thread sroland
From: Roland Scheidegger This would just crash. Noticed by accident while checking int divisions by zero with a quickly hacked piglit test. --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_ari

[Mesa-dev] [PATCH 1/3] gallivm: (trivial) fix min / max variable names

2014-09-08 Thread sroland
From: Roland Scheidegger Calling the variable min when it's really max and vice versa seems a bit confusing. --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit.c b/src/gal

[Mesa-dev] [Bug 83570] Glyphy demo throws unhandled Integer division by zero exception

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83570 --- Comment #4 from Roland Scheidegger --- Ok, I just was thinking it is probably something along these lines, and could reproduce this with some hacked up piglit test doing integer division by zero. Though I got a SIGFPE instead, I guess that's

[Mesa-dev] [Bug 81174] Gallium: GL_LINE_LOOP broken with more than 512 points

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81174 --- Comment #15 from Florian Link --- In addition to the above bug, I found that the stippling pattern is reset when the intermediate buffer is commited. Thus, GL_LINE_STRIP and GL_LINE_LOOP stipple patterns jump at the same places where the GL_L

Re: [Mesa-dev] [PATCH] Add support for NV_depth_buffer_float.

2014-09-08 Thread Roland Scheidegger
Am 06.09.2014 19:17, schrieb Mathias Froehlich: > > Hi, > > Please review: > > Add support for the unclamped versions of glDepthRange > and relatives. Also starting with OpenGL 4.2 the traditional > functions for this should no longer clamp the values to [0, 1]. This looks wrong to me (the NV_de

[Mesa-dev] [Bug 83596] reuse_framebuffer_texture_attachment does not set Layered field

2014-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83596 --- Comment #1 from Michel Dänzer --- Please submit the patch directly to the mesa-dev mailing list. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list

[Mesa-dev] [PATCH] Linking fails when not writing gl_Position.

2014-09-08 Thread Tapani Pälli
From: Kalyan Kondapally According to GLSL-ES Spec(i.e. 1.0, 3.0), gl_Position value is undefined after the vertex processing stage if we don't write gl_Position. However, GLSL 1.10 Spec mentions that writing to gl_Position is mandatory. In case of GLSL-ES, it's not an error and atleast the linkin