Re: [Mesa-dev] [PATCH 11/23] mesa: refactor GetAttribLocation

2015-03-16 Thread Tapani Pälli
On 03/17/2015 12:30 AM, Ilia Mirkin wrote: On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: Use program_resource_location to fetch location. Signed-off-by: Tapani Pälli --- src/mesa/main/shader_query.cpp | 33 ++--- 1 file changed, 10 insertions(+), 23 dele

[Mesa-dev] [Bug 88806] nir/nir_constant_expressions.c:2754:15: error: controlling expression type 'unsigned int' not compatible with any generic association type

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88806 Vinson Lee changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #7 from Vinson Lee --- mes

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #9 from Ilia Mirkin --- (In reply to Dan Sebald from comment #8) > I cloned the piglit repository and will see if I can write a program. It > shouldn't be difficult once I figure out the source tree organization, but > it might take

Re: [Mesa-dev] [PATCH 16/18] i965/cs: Support CS program precompile

2015-03-16 Thread Kristian Høgsberg
On Mon, Mar 16, 2015 at 11:20 PM, Kristian Høgsberg wrote: > On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen > wrote: >> Signed-off-by: Jordan Justen >> --- >> src/mesa/drivers/dri/i965/brw_context.h | 6 ++ >> src/mesa/drivers/dri/i965/brw_cs.cpp | 26 ++ >> sr

Re: [Mesa-dev] [PATCH 2/2] main: Cosmetic updates to GetBufferPointerv.

2015-03-16 Thread Fredrik Höglund
For both patches: Reviewed-by: Fredrik Höglund On Tuesday 17 March 2015, Laura Ekstrand wrote: > v3: Review from Fredrik Hoglund >-Split cosmetic refactor of GetBufferPointerv out into a separate commit > --- > src/mesa/main/bufferobj.c | 9 + > 1 file changed, 5 insertions(+), 4 de

Re: [Mesa-dev] [PATCH 16/18] i965/cs: Support CS program precompile

2015-03-16 Thread Kristian Høgsberg
On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_context.h | 6 ++ > src/mesa/drivers/dri/i965/brw_cs.cpp | 26 ++ > src/mesa/drivers/dri/i965/brw_shader.cpp | 4 > src/mesa/drivers/

[Mesa-dev] [PATCH] SConstruct: Fix PEP 8 issues.

2015-03-16 Thread Vinson Lee
Signed-off-by: Vinson Lee --- SConstruct | 66 -- 1 file changed, 34 insertions(+), 32 deletions(-) diff --git a/SConstruct b/SConstruct index ef71ab6..f9d3d4c 100644 --- a/SConstruct +++ b/SConstruct @@ -1,7 +1,7 @@ ##

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #8 from Dan Sebald --- I cloned the piglit repository and will see if I can write a program. It shouldn't be difficult once I figure out the source tree organization, but it might take me a couple days. I see the transition happenin

Re: [Mesa-dev] [PATCH 15/18] i965/cs: Emit compute shader code and upload programs

2015-03-16 Thread Kristian Høgsberg
On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_context.h | 1 + > src/mesa/drivers/dri/i965/brw_cs.cpp | 216 > +++ > src/mesa/drivers/dri/i965/brw_state_upload.c | 3 + > 3 file

Re: [Mesa-dev] [PATCH 13/18] i965/fs: Support compute programs in fs_visitor

2015-03-16 Thread Kristian Høgsberg
On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 82 > +++- > src/mesa/drivers/dri/i965/brw_fs.h | 10 > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 23 >

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Emit better b2f of an expression on GEN4 and GEN5

2015-03-16 Thread Tapani Pälli
On 03/17/2015 07:42 AM, Tapani Pälli wrote: On 03/16/2015 06:37 PM, Matt Turner wrote: On Mon, Mar 16, 2015 at 4:54 AM, Tapani Pälli wrote: Is there some particular Piglit test case that hits this path and is it possible with gen>5 (by removing gen check)? I've tried this with handicrafted

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Emit better b2f of an expression on GEN4 and GEN5

2015-03-16 Thread Tapani Pälli
On 03/16/2015 06:37 PM, Matt Turner wrote: On Mon, Mar 16, 2015 at 4:54 AM, Tapani Pälli wrote: Is there some particular Piglit test case that hits this path and is it possible with gen>5 (by removing gen check)? I've tried this with handicrafted shader_test and also shader-db and cannot hit

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 --- Comment #7 from Ilia Mirkin --- Would you be able to supply a short program that reproduces the issue that could be added to the piglit test suite? (http://cgit.freedesktop.org/piglit) There are two tests in there that make use of glPixelZoom

Re: [Mesa-dev] [PATCH 14/18] i965/fs: Don't assign high regs for CS termination send

2015-03-16 Thread Jordan Justen
On 2015-03-16 13:49:29, Kenneth Graunke wrote: > On Saturday, March 14, 2015 09:54:24 PM Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > --- > > src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/mesa/dri

Re: [Mesa-dev] [PATCH 2/2] main: Change the type argument of use_shader_program() to gl_shader_stage.

2015-03-16 Thread Kristian Høgsberg
On Wed, Mar 11, 2015 at 3:43 PM, Jordan Justen wrote: > From: Paul Berry > > This allows it to be called from a loop. > > Reviewed-by: Jordan Justen Reviewed-by: Kristian Høgsberg > --- > src/mesa/main/shaderapi.c | 23 +++ > 1 file changed, 11 insertions(+), 12 deletions

[Mesa-dev] [Bug 89586] Drivers/DRI/swrast

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89586 Dan Sebald changed: What|Removed |Added CC||daniel.seb...@ieee.org -- You are receivin

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86326 --- Comment #10 from Ronie Salgado --- Created attachment 114367 --> https://bugs.freedesktop.org/attachment.cgi?id=114367&action=edit Radeon patch for the other patches It seems that the radeon driver depends in some of the llvm intrinsics. P

Re: [Mesa-dev] [PATCH v2 3/4] i965/state: Create separate dirty state bits for each pipeline

2015-03-16 Thread Kristian Høgsberg
On Wed, Mar 11, 2015 at 11:53 AM, Jordan Justen wrote: > When uploading state for a pipeline, we will save changed state for > the other pipelines. > > Signed-off-by: Jordan Justen In reviewing this again, I realize I'm not completely comfortable with how this is done. The overall approach is gr

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86326 Ronie Salgado changed: What|Removed |Added Attachment #114363|0 |1 is obsolete|

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86326 --- Comment #8 from Ronie Salgado --- Created attachment 114365 --> https://bugs.freedesktop.org/attachment.cgi?id=114365&action=edit Clang patch Clang patch to be able to use the new/old builtin functions. -- You are receiving this mail bec

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86326 Ronie Salgado changed: What|Removed |Added Attachment #114337|0 |1 is obsolete|

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86326 Ronie Salgado changed: What|Removed |Added Attachment #114336|0 |1 is obsolete|

Re: [Mesa-dev] [PATCH 2/2] i965/nir: Re-emit instructions instead of doing mov-to-flag when possible

2015-03-16 Thread Jason Ekstrand
On Mon, Mar 16, 2015 at 9:21 PM, Jason Ekstrand wrote: > Because of the way that NIR does conditionals, we get them in any old SSA > value. The actual boolean value used in the select or if is x != 0. > Previously, we handled this by emitting a mov.nz to move the value to the > flag register. Ho

[Mesa-dev] [PATCH 1/2] i965/nir: Factor out code to convert a nir_src to a flag register

2015-03-16 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.h | 1 + src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 16 ++-- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h index 08c2b89..105973e 100644 --- a/src/mesa

[Mesa-dev] [PATCH 2/2] i965/nir: Re-emit instructions instead of doing mov-to-flag when possible

2015-03-16 Thread Jason Ekstrand
Because of the way that NIR does conditionals, we get them in any old SSA value. The actual boolean value used in the select or if is x != 0. Previously, we handled this by emitting a mov.nz to move the value to the flag register. However, this almost always adds at least one if not two instructi

Re: [Mesa-dev] [PATCH 1/2] docs/GL3: don't list r300

2015-03-16 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Feel free to also nuke nv30. On Mon, Mar 16, 2015 at 6:37 PM, Matt Turner wrote: > On Mon, Mar 16, 2015 at 3:28 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> r300g already supports everything it can. There's no point in listing >> the driver here. >> --- > > FWIW,

Re: [Mesa-dev] [PATCH 1/3] nir/peephole_select: Rename are_all_move_to_phi and use a switch

2015-03-16 Thread Connor Abbott
On Mon, Mar 16, 2015 at 10:08 PM, Jason Ekstrand wrote: > On Mon, Mar 16, 2015 at 6:52 PM, Connor Abbott wrote: >> On Mon, Mar 16, 2015 at 9:23 PM, Jason Ekstrand wrote: >>> --- >>> src/glsl/nir/nir_opt_peephole_select.c | 54 >>> +++--- >>> 1 file changed, 30 inser

[Mesa-dev] [Bug 89433] GCC 4.2 does not support -Wvla

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89433 Jonathan Gray changed: What|Removed |Added Attachment #114016|0 |1 is obsolete|

Re: [Mesa-dev] [PATCH 1/3] nir/peephole_select: Rename are_all_move_to_phi and use a switch

2015-03-16 Thread Jason Ekstrand
On Mon, Mar 16, 2015 at 6:52 PM, Connor Abbott wrote: > On Mon, Mar 16, 2015 at 9:23 PM, Jason Ekstrand wrote: >> --- >> src/glsl/nir/nir_opt_peephole_select.c | 54 >> +++--- >> 1 file changed, 30 insertions(+), 24 deletions(-) >> >> diff --git a/src/glsl/nir/nir_op

Re: [Mesa-dev] [PATCH 1/3] nir/peephole_select: Rename are_all_move_to_phi and use a switch

2015-03-16 Thread Connor Abbott
On Mon, Mar 16, 2015 at 9:23 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir_opt_peephole_select.c | 54 > +++--- > 1 file changed, 30 insertions(+), 24 deletions(-) > > diff --git a/src/glsl/nir/nir_opt_peephole_select.c > b/src/glsl/nir/nir_opt_peephole_select.c

Re: [Mesa-dev] [PATCH] gallium/util: Define ffsll on OpenBSD.

2015-03-16 Thread Jonathan Gray
On Mon, Mar 16, 2015 at 08:37:28PM +, Emil Velikov wrote: > On 26/02/15 13:49, Jose Fonseca wrote: > > On 26/02/15 13:42, Jose Fonseca wrote: > >> On 26/02/15 03:55, Jonathan Gray wrote: > >>> On Wed, Feb 25, 2015 at 07:09:26PM -0800, Matt Turner wrote: > On Wed, Feb 25, 2015 at 7:03 PM, J

[Mesa-dev] [PATCH 2/3] nir/peephole_select: Copy instructions into the block before the if

2015-03-16 Thread Jason Ekstrand
Previously we tried to do poor-man's copy propagation as we created the select instructions. Instead, this commit just moves the instructions from the blocks inside the if into the block before. Copy propagation will take care of making sure we don't have any extra mov's in there for us. --- src

[Mesa-dev] [PATCH 1/3] nir/peephole_select: Rename are_all_move_to_phi and use a switch

2015-03-16 Thread Jason Ekstrand
--- src/glsl/nir/nir_opt_peephole_select.c | 54 +++--- 1 file changed, 30 insertions(+), 24 deletions(-) diff --git a/src/glsl/nir/nir_opt_peephole_select.c b/src/glsl/nir/nir_opt_peephole_select.c index ab08f28..8064f40 100644 --- a/src/glsl/nir/nir_opt_peephole_sel

[Mesa-dev] [PATCH 3/3] nir/peephole_select: Allow uniform/input loads and load_const

2015-03-16 Thread Jason Ekstrand
Shader-db results on HSW: total instructions in shared programs: 4174156 -> 4157291 (-0.40%) instructions in affected programs: 145397 -> 128532 (-11.60%) helped:383 HURT: 0 GAINED:20 LOST:

Re: [Mesa-dev] [PATCH] util: port _mesa_strto[df] to C

2015-03-16 Thread Erik Faye-Lund
On Tue, Mar 17, 2015 at 12:32 AM, Ian Romanick wrote: > On 03/15/2015 12:05 PM, Erik Faye-Lund wrote: >> _mesa_strtod and _mesa_strtof are only used from the GLSL compiler, > > It's also used in the ARB_vertex_program / ARB_fragment_program > assembler in src/prog. Oh, right. Thanks for pointing

Re: [Mesa-dev] Statically linking libstdc++ and libgcc

2015-03-16 Thread Ian Romanick
On 03/13/2015 02:32 PM, Emil Velikov wrote: > * Allow people to static link against libgcc/libstdc++. > > Imho this should be option, disabled by default provided at configure > time. This way builders/distributions can op-in if they choose to do so. I'm very strongly opposed to this. We alread

Re: [Mesa-dev] [PATCH] util: port _mesa_strto[df] to C

2015-03-16 Thread Ian Romanick
On 03/15/2015 12:05 PM, Erik Faye-Lund wrote: > _mesa_strtod and _mesa_strtof are only used from the GLSL compiler, It's also used in the ARB_vertex_program / ARB_fragment_program assembler in src/prog. > so the locale doesn't need to be initialized before the first context > gets initialized. So

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Force promotion of src0 immediates.

2015-03-16 Thread Kenneth Graunke
On Monday, March 16, 2015 03:16:32 PM Matt Turner wrote: > On Mon, Mar 16, 2015 at 2:44 PM, Kenneth Graunke > wrote: > > On Monday, March 16, 2015 07:54:45 AM Tapani Pälli wrote: > >> My first attempt to fix the bug 89569 was to add check in combine > >> constants but for some reason I did not ge

[Mesa-dev] [PATCH 2/2] main: Cosmetic updates to GetBufferPointerv.

2015-03-16 Thread Laura Ekstrand
v3: Review from Fredrik Hoglund -Split cosmetic refactor of GetBufferPointerv out into a separate commit --- src/mesa/main/bufferobj.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 2811604..49d6d32 100644

[Mesa-dev] [PATCH 1/2] main: Add entry point for GetNamedBufferPointerv.

2015-03-16 Thread Laura Ekstrand
v3: Review from Fredrik Hoglund -Split cosmetic refactor of GetBufferPointerv out into a separate commit --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++ src/mesa/main/bufferobj.c | 20 src/mesa/main/bufferobj.h | 4

Re: [Mesa-dev] [PATCH 2/4] util: Change hash_table to use quadratic probing

2015-03-16 Thread Eric Anholt
Thomas Helland writes: > This should give better cache locality, less memory consumption, > and should also be faster since we avoid a modulo operation. > Also change table size to be power of two. > This gives better performance as we can do bitmasking instead of > modulo operations for fitting

Re: [Mesa-dev] [PATCH 15/23] mesa: refactor GetActiveUniformsiv, use _mesa_program_resource_prop

2015-03-16 Thread Ilia Mirkin
On Fri, Mar 13, 2015 at 4:38 AM, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > src/mesa/main/uniform_query.cpp | 107 > ++-- > 1 file changed, 38 insertions(+), 69 deletions(-) > > diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/unifo

Re: [Mesa-dev] [PATCH 1/2] docs/GL3: don't list r300

2015-03-16 Thread Matt Turner
On Mon, Mar 16, 2015 at 3:28 PM, Marek Olšák wrote: > From: Marek Olšák > > r300g already supports everything it can. There's no point in listing > the driver here. > --- FWIW, I always thought it was weird to list non-GL3 capable (not really even GL2 capable, right?!) hardware here, so this see

Re: [Mesa-dev] [PATCH 13/23] mesa: refactor GetFragDataIndex

2015-03-16 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > Use _mesa_program_resource_location_index to fetch index. > > Signed-off-by: Tapani Pälli > --- > src/mesa/main/shader_query.cpp | 25 ++--- > 1 file changed, 2 insertions(+), 23 deletions(-) >

Re: [Mesa-dev] [PATCH 12/23] mesa: refactor GetFragDataLocation

2015-03-16 Thread Ilia Mirkin
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > Use program_resource_location to fetch location. > > Signed-off-by: Tapani Pälli > --- > src/mesa/main/shader_query.cpp | 28 ++-- > 1 file changed, 6 insertions(+), 22 deletions(-) > > diff --git a/src/mesa/main/shad

Re: [Mesa-dev] [PATCH 11/23] mesa: refactor GetAttribLocation

2015-03-16 Thread Ilia Mirkin
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > Use program_resource_location to fetch location. > > Signed-off-by: Tapani Pälli > --- > src/mesa/main/shader_query.cpp | 33 ++--- > 1 file changed, 10 insertions(+), 23 deletions(-) > > diff --git a/src/mesa/mai

[Mesa-dev] [PATCH 2/2] docs/GL3: don't list swrast

2015-03-16 Thread Marek Olšák
From: Marek Olšák Let's face it: This driver is unlikely to get more love. --- docs/GL3.txt | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 1ca4502..bd17743 100644 --- a/docs/GL3.txt +++ b/docs/GL3

[Mesa-dev] [PATCH 1/2] docs/GL3: don't list r300

2015-03-16 Thread Marek Olšák
From: Marek Olšák r300g already supports everything it can. There's no point in listing the driver here. --- docs/GL3.txt | 56 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 5d59341..1ca4

Re: [Mesa-dev] [PATCH 10/23] mesa: refactor GetActiveAttrib

2015-03-16 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin One minor note -- not sure if it makes sense to call the _mesa_program_resource_prop helpers, but it is nicely generic. However you already have the ir_variable *var, so might as well use it? Your call. On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > Instead of i

[Mesa-dev] [Bug 89599] symbol 'x86_64_entry_start' is already defined

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89599 Bug ID: 89599 Summary: symbol 'x86_64_entry_start' is already defined Product: Mesa Version: 10.5 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Sev

Re: [Mesa-dev] [PATCH 09/23] mesa: enable GL_ARB_program_interface_query extension

2015-03-16 Thread Ilia Mirkin
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > (and mark it as DONE in docs/GL3.txt) And add to relnotes? > > Signed-off-by: Tapani Pälli > --- > docs/GL3.txt | 4 ++-- > src/mesa/main/extensions.c | 1 + > src/mesa/main/mtypes.h | 1 + > 3 files changed, 4 insertions

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Force promotion of src0 immediates.

2015-03-16 Thread Matt Turner
On Mon, Mar 16, 2015 at 2:44 PM, Kenneth Graunke wrote: > On Monday, March 16, 2015 07:54:45 AM Tapani Pälli wrote: >> My first attempt to fix the bug 89569 was to add check in combine >> constants but for some reason I did not get it to work. One reason is >> that inst->sources cannot be trusted

Re: [Mesa-dev] [PATCH] util: port _mesa_strto[df] to C

2015-03-16 Thread Erik Faye-Lund
On Mon, Mar 16, 2015 at 10:13 PM, Emil Velikov wrote: > On 15/03/15 19:05, Erik Faye-Lund wrote: >> _mesa_strtod and _mesa_strtof are only used from the GLSL compiler, >> so the locale doesn't need to be initialized before the first context >> gets initialized. So let's use explicit initialization

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Force promotion of src0 immediates.

2015-03-16 Thread Kenneth Graunke
On Monday, March 16, 2015 07:54:45 AM Tapani Pälli wrote: > My first attempt to fix the bug 89569 was to add check in combine > constants but for some reason I did not get it to work. One reason is > that inst->sources cannot be trusted I certainly hope we can trust it. If it's wrong, we need t

Re: [Mesa-dev] [PATCH] i965/skl: Send a message header when doing constant loads SIMD4x2

2015-03-16 Thread Anuj Phogat
This patch fixes the misrendering in etqw-demo. https://bugs.freedesktop.org/show_bug.cgi?id=89039 Tested-by: Anuj Phogat On Fri, Mar 13, 2015 at 9:29 AM, Neil Roberts wrote: > Commit 0ac4c272755c7 made it add a header for the send message when > using SIMD4x2 on Skylake because without this it

Re: [Mesa-dev] [PATCH] util: port _mesa_strto[df] to C

2015-03-16 Thread Emil Velikov
On 15/03/15 19:05, Erik Faye-Lund wrote: > _mesa_strtod and _mesa_strtof are only used from the GLSL compiler, > so the locale doesn't need to be initialized before the first context > gets initialized. So let's use explicit initialization from the > one-time init code instead of depending on a C++

[Mesa-dev] [Bug 88534] include/c11/threads_posix.h PTHREAD_MUTEX_RECURSIVE_NP not defined

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88534 Emil Velikov changed: What|Removed |Added Resolution|MOVED |FIXED --- Comment #2 from Emil Velikov -

[Mesa-dev] [Bug 89530] FTBFS in loader: missing fstat

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89530 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] glx: Handle out-of-sequence swap completion events correctly. (v2)

2015-03-16 Thread Emil Velikov
On 12/03/15 19:34, Mario Kleiner wrote: > The code for emitting INTEL_swap_events swap completion > events needs to translate from 32-Bit sbc on the wire to > 64-Bit sbc for the events and handle wraparound accordingly. > > It assumed that events would be sent by the server in the > order their co

Re: [Mesa-dev] [PATCH 14/18] i965/fs: Don't assign high regs for CS termination send

2015-03-16 Thread Kenneth Graunke
On Saturday, March 14, 2015 09:54:24 PM Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp > b/src/mesa/drivers/d

Re: [Mesa-dev] [PATCH] i965: Mark paths in linear <-> tiled functions as unreachable().

2015-03-16 Thread Jason Ekstrand
LGTM On Mon, Mar 16, 2015 at 10:25 AM, Matt Turner wrote: > textdata bss dec hex filename > 9663 0 0966325bf intel_tiled_memcpy.o before > 8215 0 082152017 intel_tiled_memcpy.o after > --- > src/mesa/drivers/dri/i965/intel_tiled_memcpy.

Re: [Mesa-dev] [PATCH 08/18] i965/cs: Mark g0 as used by CS_OPCODE_CS_TERMINATE

2015-03-16 Thread Kenneth Graunke
On Saturday, March 14, 2015 09:54:18 PM Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp > b/src/mesa/drivers/dri/i965/brw_

Re: [Mesa-dev] [PATCH] util: port _mesa_strto[df] to C

2015-03-16 Thread Matt Turner
On Sun, Mar 15, 2015 at 12:05 PM, Erik Faye-Lund wrote: > _mesa_strtod and _mesa_strtof are only used from the GLSL compiler, > so the locale doesn't need to be initialized before the first context > gets initialized. So let's use explicit initialization from the > one-time init code instead of de

Re: [Mesa-dev] [PATCH] gallium/util: Define ffsll on OpenBSD.

2015-03-16 Thread Emil Velikov
On 26/02/15 13:49, Jose Fonseca wrote: > On 26/02/15 13:42, Jose Fonseca wrote: >> On 26/02/15 03:55, Jonathan Gray wrote: >>> On Wed, Feb 25, 2015 at 07:09:26PM -0800, Matt Turner wrote: On Wed, Feb 25, 2015 at 7:03 PM, Jonathan Gray wrote: > On Wed, Feb 25, 2015 at 06:53:14PM -0800, Mat

Re: [Mesa-dev] [PATCH 1/6] c11: add c11 compatibility wrapper around stdlib.h

2015-03-16 Thread Emil Velikov
On 06/03/15 18:26, Brian Paul wrote: > On Fri, Mar 6, 2015 at 9:32 AM, Emil Velikov > wrote: > > Used for aligned_alloc and other C11 functions missing from the header. > > Signed-off-by: Emil Velikov > > --- >

Re: [Mesa-dev] [PATCH 23/23] main: Cosmetic changes to GetBufferSubData.

2015-03-16 Thread Fredrik Höglund
This patch is: Reviewed-by: Fredrik Höglund On Thursday 12 February 2015, Laura Ekstrand wrote: > --- > src/mesa/main/bufferobj.c | 2 +- > src/mesa/main/bufferobj.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferob

Re: [Mesa-dev] [PATCH 21/23] main: Add entry point for GetNamedBufferPointerv.

2015-03-16 Thread Fredrik Höglund
On Thursday 12 February 2015, Laura Ekstrand wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++ > src/mesa/main/bufferobj.c | 27 > +++--- > src/mesa/main/bufferobj.h | 4 > src/mesa/main/tests/dispatch_sa

Re: [Mesa-dev] [PATCH 22/23] main: Add entry point for glGetNamedBufferSubData.

2015-03-16 Thread Fredrik Höglund
Having a gl prefix in the commit message is inconsistent with the other patches in this series. Aside from that, and a comment below, this patch is: Reviewed-by: Fredrik Höglund On Thursday 12 February 2015, Laura Ekstrand wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 7

Re: [Mesa-dev] [PATCH 20/23] main: Add entry points for GetBufferParameteri[64]v.

2015-03-16 Thread Fredrik Höglund
The commit message should say NamedBufferParameter. With that fixed, this patch is: Reviewed-by: Fredrik Höglund On Thursday 12 February 2015, Laura Ekstrand wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 12 > src/mesa/main/bufferobj.c | 39 > ++

Re: [Mesa-dev] [PATCH 1/3] auxiliary/os: fix the android build - s/drm_munmap/os_munmap/

2015-03-16 Thread Emil Velikov
On 16/03/15 17:19, Brian Paul wrote: > On 03/16/2015 09:00 AM, Emil Velikov wrote: >> Squash this silly typo introduced with commit >> c63eb5dd5ec(auxiliary/os: get >> the mmap/munmap wrappers working with android) >> >> Cc: "10.4 10.5" >> Signed-off-by: Emil Velikov >> --- >> src/gallium/auxil

Re: [Mesa-dev] [PATCH 17/23] main: Refactor FlushMappedBufferRange.

2015-03-16 Thread Fredrik Höglund
This patch is: Reviewed-by: Fredrik Höglund On Thursday 12 February 2015, Laura Ekstrand wrote: > v2:-Remove "_mesa" from in front of static software fallback. >-Split out the refactor from the addition of the DSA entry points. > --- > src/mesa/main/bufferobj.c | 60 > +

Re: [Mesa-dev] [PATCH 19/23] main: Refactor GetBufferParameteri[64]v.

2015-03-16 Thread Fredrik Höglund
This patch is: Reviewed-by: Fredrik Höglund On Thursday 12 February 2015, Laura Ekstrand wrote: > v2: Split into a refactor commit and an entry point commit. > --- > src/mesa/main/bufferobj.c | 119 > ++ > 1 file changed, 45 insertions(+), 74 deletio

Re: [Mesa-dev] [PATCH 18/23] main: Add entry point for FlushMappedNamedBufferRange.

2015-03-16 Thread Fredrik Höglund
This patch is: Reviewed-by: Fredrik Höglund On Thursday 12 February 2015, Laura Ekstrand wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++ > src/mesa/main/bufferobj.c | 16 > src/mesa/main/bufferobj.h | 4

Re: [Mesa-dev] [PATCH 16/23] main: Add entry point for UnmapNamedBuffer.

2015-03-16 Thread Fredrik Höglund
On Thursday 12 February 2015, Laura Ekstrand wrote: > v2: review from Ian Romanick >- Restore VBO_DEBUG and BOUNDS_CHECK >- Remove _mesa from static software fallback unmap_buffer. > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 5 +++ > src/mesa/main/bufferobj.c

Re: [Mesa-dev] [PATCH 15/23] main: Add entry points for MapNamedBuffer[Range].

2015-03-16 Thread Fredrik Höglund
On Thursday 12 February 2015, Laura Ekstrand wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 14 + > src/mesa/main/bufferobj.c | 42 > ++ > src/mesa/main/bufferobj.h | 14 +++-- > src/mesa/main/tests/dis

Re: [Mesa-dev] [PATCH 14/23] main: Refactor MapBuffer[Range].

2015-03-16 Thread Fredrik Höglund
Aside from some nitpicks below, this patch is: Reviewed-by: Fredrik Höglund On Thursday 12 February 2015, Laura Ekstrand wrote: > v2: review from Jason Ekstrand >- Split refactor from addition of DSA entry points. > review from Ian Romanick >- Remove "_mesa" from static software fall

Re: [Mesa-dev] [PATCH 13/23] main: Minor whitespace fixes in ClearNamedBuffer[Sub]Data.

2015-03-16 Thread Fredrik Höglund
This patch is: Reviewed-by: Fredrik Höglund On Thursday 12 February 2015, Laura Ekstrand wrote: > --- > src/mesa/main/bufferobj.c | 4 ++-- > src/mesa/main/bufferobj.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/buffer

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Emit better b2f of an expression on GEN4 and GEN5

2015-03-16 Thread Ian Romanick
On 03/16/2015 10:06 AM, Matt Turner wrote: > On Wed, Mar 11, 2015 at 1:44 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> On platforms that do not natively generate 0u and ~0u for Boolean >> results, b2f expressions that look like >> >>f = b2f(expr cmp 0) >> >> will generate better code b

Re: [Mesa-dev] [PATCH] i965: Set nr_params to the number of uniform components in the VS/GS path.

2015-03-16 Thread Francisco Jerez
Kenneth Graunke writes: > On Thursday, January 22, 2015 06:32:21 PM Francisco Jerez wrote: >> Both do_vs_prog and do_gs_prog initialize brw_stage_prog_data::nr_params to >> the number of uniform *vectors* required by the shader rather than the number >> of uniform components, contradicting the co

Re: [Mesa-dev] [PATCH] i965: Set nr_params to the number of uniform components in the VS/GS path.

2015-03-16 Thread Kenneth Graunke
On Thursday, January 22, 2015 06:32:21 PM Francisco Jerez wrote: > Both do_vs_prog and do_gs_prog initialize brw_stage_prog_data::nr_params to > the number of uniform *vectors* required by the shader rather than the number > of uniform components, contradicting the comment. This is inconsistent wi

Re: [Mesa-dev] [PATCH] i965/skl: Fix the maximum thread count format for the PS

2015-03-16 Thread Kenneth Graunke
On Friday, February 27, 2015 07:20:37 PM Neil Roberts wrote: > According to the bspec for some reason the format of the maximum > number of threads field has changed from U8-2 to U8-1 for the PS. > > I've run this through Piglit and it doesn't cause any regressions. > --- > src/mesa/drivers/dri/i

Re: [Mesa-dev] [PATCH 08/23] mesa: implementation of glGetProgramResourceiv

2015-03-16 Thread Ilia Mirkin
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > Patch adds required helper functions to shaderapi.h and > the actual implementation. > > The property query functionality can be tested with tests for > following functions that are refactored by later patches: > >GetActiveAtomicCounterBuf

Re: [Mesa-dev] [PATCH] i965: Mark paths in linear <-> tiled functions as unreachable().

2015-03-16 Thread Carl Worth
On Mon, Mar 16 2015, Matt Turner wrote: > textdata bss dec hex filename > 9663 0 0966325bf intel_tiled_memcpy.o before > 8215 0 082152017 intel_tiled_memcpy.o after Reviewed-by: Carl Worth -Carl pgp1BOJRVmNZE.pgp Description: PGP sig

Re: [Mesa-dev] [PATCH 07/23] mesa: glGetProgramResourceLocationIndex

2015-03-16 Thread Ilia Mirkin
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > Patch adds required helper functions to shaderapi.h and > the actual implementation. > > The added functionality can be tested by tests for following > functions that are refactored by later patches: > >GetFragDataIndex > > Signed-off-by:

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Emit better b2f of an expression on GEN4 and GEN5

2015-03-16 Thread Ian Romanick
On 03/16/2015 09:37 AM, Matt Turner wrote: > On Mon, Mar 16, 2015 at 4:54 AM, Tapani Pälli wrote: >> Is there some particular Piglit test case that hits this path and is it >> possible with gen>5 (by removing gen check)? I've tried this with >> handicrafted shader_test and also shader-db and canno

[Mesa-dev] [PATCH] i965: Mark paths in linear <-> tiled functions as unreachable().

2015-03-16 Thread Matt Turner
textdata bss dec hex filename 9663 0 0966325bf intel_tiled_memcpy.o before 8215 0 082152017 intel_tiled_memcpy.o after --- src/mesa/drivers/dri/i965/intel_tiled_memcpy.c | 16 1 file changed, 16 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 2/3] st/dri: remove unused include from the automake/scons build

2015-03-16 Thread Brian Paul
On 03/16/2015 09:00 AM, Emil Velikov wrote: st/dri/common hasn't been around for a while. Signed-off-by: Emil Velikov --- src/gallium/state_trackers/dri/Makefile.am | 1 - src/gallium/state_trackers/dri/SConscript | 1 - 2 files changed, 2 deletions(-) diff --git a/src/gallium/state_track

Re: [Mesa-dev] [PATCH 1/3] auxiliary/os: fix the android build - s/drm_munmap/os_munmap/

2015-03-16 Thread Brian Paul
On 03/16/2015 09:00 AM, Emil Velikov wrote: Squash this silly typo introduced with commit c63eb5dd5ec(auxiliary/os: get the mmap/munmap wrappers working with android) Cc: "10.4 10.5" Signed-off-by: Emil Velikov --- src/gallium/auxiliary/os/os_mman.h | 4 ++-- 1 file changed, 2 insertions(+)

Re: [Mesa-dev] [PATCH 05/23] mesa: glGetProgramResourceName

2015-03-16 Thread Ilia Mirkin
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > Patch adds required helper functions to shaderapi.h and > the actual implementation. > > Name generation copied from '_mesa_get_uniform_name' which can > be removed later by refactoring functions to use resource list. > > The added functionali

Re: [Mesa-dev] [PATCH 06/23] mesa: glGetProgramResourceLocation

2015-03-16 Thread Ilia Mirkin
On Fri, Mar 13, 2015 at 4:37 AM, Tapani Pälli wrote: > Patch adds required helper functions to shaderapi.h and > the actual implementation. > > corresponding Piglit test: >arb_program_interface_query-resource-location > > The added functionality can be tested by tests for following > functions

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Emit better b2f of an expression on GEN4 and GEN5

2015-03-16 Thread Matt Turner
On Wed, Mar 11, 2015 at 1:44 PM, Ian Romanick wrote: > From: Ian Romanick > > On platforms that do not natively generate 0u and ~0u for Boolean > results, b2f expressions that look like > >f = b2f(expr cmp 0) > > will generate better code by pretending the expression is > > f = ir_triop_s

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Emit better b2f of an expression on GEN4 and GEN5

2015-03-16 Thread Matt Turner
On Mon, Mar 16, 2015 at 4:54 AM, Tapani Pälli wrote: > Is there some particular Piglit test case that hits this path and is it > possible with gen>5 (by removing gen check)? I've tried this with > handicrafted shader_test and also shader-db and cannot hit the conditions > for changes to happen. Wo

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-16 Thread Laura Ekstrand
That was basically my background (mechanical engineering + lots of OpenGL) when I started six months ago, but I have found the lack of mentoring to be a large roadblock. At that time, I wrote tests, but there were few people willing to review them and give timely feedback. I was advised to go ahe

Re: [Mesa-dev] [PATCH] gallivm: abort properly when running out of buffer space in lp_disassembly

2015-03-16 Thread Jose Fonseca
On 13/03/15 22:46, srol...@vmware.com wrote: From: Roland Scheidegger Before this actually ran into an infinite loop printing out "invalid"... --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxil

Re: [Mesa-dev] [PATCH 1/1] Fix runtime error with uClibc

2015-03-16 Thread Emil Velikov
Hi Bernd, On 15/03/15 11:27, Bernd Kuhls wrote: > Patch inspired by > https://www.winehq.org/pipermail/wine-bugs/2011-September/288987.html > http://git.alpinelinux.org/cgit/aports/tree/main/wine/uclibc-fmaxf-fminf.patch?id=c9b491b6099eec02a835ffd05539b5c783c6c43a > > Starting an app using mesa3d

Re: [Mesa-dev] [PATCH 1/3] auxiliary/os: fix the android build - s/drm_munmap/os_munmap/

2015-03-16 Thread Emil Velikov
On 16/03/15 15:00, Emil Velikov wrote: > Squash this silly typo introduced with commit c63eb5dd5ec(auxiliary/os: get > the mmap/munmap wrappers working with android) > A couple of bits: - More is needed than this patch to get master (and the stable branches) building properly. Those will be comi

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2015-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 88781, which changed state. Bug 88781 Summary: Unity3D based games exhibit problems with texture scaling in menus on high resolutions https://bugs.freedesktop.org/show_bug.cgi?id=88781 What|Removed

Re: [Mesa-dev] [PATCH] egl: don't fill client apis string forever.

2015-03-16 Thread Matt Turner
On Sun, Mar 15, 2015 at 10:22 PM, Dave Airlie wrote: > We never reset the string on eglTerminate, so it grows > for ever on multiple eglInitialise. > > Signed-off-by: Dave Airlie > --- > src/egl/main/eglapi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/egl/main/eglapi.c b/src/eg

[Mesa-dev] [PATCH 2/3] st/dri: remove unused include from the automake/scons build

2015-03-16 Thread Emil Velikov
st/dri/common hasn't been around for a while. Signed-off-by: Emil Velikov --- src/gallium/state_trackers/dri/Makefile.am | 1 - src/gallium/state_trackers/dri/SConscript | 1 - 2 files changed, 2 deletions(-) diff --git a/src/gallium/state_trackers/dri/Makefile.am b/src/gallium/state_trackers

[Mesa-dev] [PATCH 1/3] auxiliary/os: fix the android build - s/drm_munmap/os_munmap/

2015-03-16 Thread Emil Velikov
Squash this silly typo introduced with commit c63eb5dd5ec(auxiliary/os: get the mmap/munmap wrappers working with android) Cc: "10.4 10.5" Signed-off-by: Emil Velikov --- src/gallium/auxiliary/os/os_mman.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxil

  1   2   >