Re: [Mesa-dev] [PATCH 02/20] mesa: Use bool instead of GLboolean

2015-04-30 Thread Pohjolainen, Topi
On Wed, Apr 29, 2015 at 04:25:53PM -0700, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick Reviewed-by: Topi Pohjolainen > --- > src/mesa/main/version.c | 56 > - > 1 file changed, 28 insertions(+), 28 deletions(-) > >

Re: [Mesa-dev] [PATCH 02/20] mesa: Use bool instead of GLboolean

2015-04-30 Thread Matt Turner
On Thu, Apr 30, 2015 at 12:00 AM, Pohjolainen, Topi wrote: > On Wed, Apr 29, 2015 at 04:25:53PM -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick > > Reviewed-by: Topi Pohjolainen So you know, the first 12 have already gotten at least one review, and the first

Re: [Mesa-dev] [PATCH 02/20] mesa: Use bool instead of GLboolean

2015-04-30 Thread Pohjolainen, Topi
On Thu, Apr 30, 2015 at 12:04:39AM -0700, Matt Turner wrote: > On Thu, Apr 30, 2015 at 12:00 AM, Pohjolainen, Topi > wrote: > > On Wed, Apr 29, 2015 at 04:25:53PM -0700, Ian Romanick wrote: > >> From: Ian Romanick > >> > >> Signed-off-by: Ian Romanick > > > > Reviewed-by: Topi Pohjolainen > >

Re: [Mesa-dev] [PATCH 15/20] glsl/es3.1: Allow textureGather and textureGatherOffset in GLSL ES 3.10

2015-04-30 Thread Tapani Pälli
Patches 1 .. 15 (with the 2 little changes proposed) Reviewed-by: Tapani Pälli I went through built-in functions in the 3.1 spec and checked that the packing functions, integer mix, textureGather variants, bitField operations, ldexp and frexp are listed there. I've also cross-checked agains

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-30 Thread Tapani Pälli
On 04/29/2015 11:57 PM, Rogovin, Kevin wrote: Hi, I'd just go read the ES 3.1 spec and see if there are any differences in this area. I checked the spec, and it appears to me to have the same behavior as GL_ARB_framebuffer_no_attachments. I've just gone through it and can't spot any dif

[Mesa-dev] [Bug 90249] Fails to build egl_dri2 on osx

2015-04-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90249 Bug ID: 90249 Summary: Fails to build egl_dri2 on osx Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority:

Re: [Mesa-dev] [PATCH] i965/skl: Force the exec size to 8 when initing header for SIMD4x2

2015-04-30 Thread Tapani Pälli
This fixes 574 failing ES3 conformance tests, nice. Could someone with more backend knowledge please review this? Tested-by: Tapani Pälli On 04/24/2015 08:05 AM, Neil Roberts wrote: On Gen9+ there needs to be a header when sampling using SIMD4x2. The header is set up by copying from the g0 re

Re: [Mesa-dev] [PATCH v5] i965/aa: fixing anti-aliasing bug for thinnest width lines - GEN6

2015-04-30 Thread Predut, Marius
Thanks guys for review !. > -Original Message- > From: Kenneth Graunke [mailto:kenn...@whitecape.org] > Sent: Wednesday, April 29, 2015 1:11 AM > To: Matt Turner > Cc: Predut, Marius; mesa-dev@lists.freedesktop.org; Ian Romanick; Eric Anholt > Subject: Re: [Mesa-dev] [PATCH v5] i965/aa: fi

Re: [Mesa-dev] [PATCH 03/20] SQUASH! whitespace fixes after previous commit

2015-04-30 Thread Erik Faye-Lund
On Thu, Apr 30, 2015 at 1:25 AM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick The title on this one doesn't seem quite right ("after previous" should probably be "before next"), but that probably doesn't matter because it will get squashed anyway... _

[Mesa-dev] [Bug 90213] glDrawPixels with GL_COLOR_INDEX never returns.

2015-04-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90213 Iago Toral changed: What|Removed |Added CC||ito...@igalia.com, |

Re: [Mesa-dev] [PATCH v2] glsl: properly setting var->data.binding if explicit_binding is true

2015-04-30 Thread Alejandro Piñeiro
On 30/04/15 03:15, Timothy Arceri wrote: > On Tue, 2015-04-28 at 10:07 +0200, Alejandro Piñeiro wrote: >> There was a typo on commit c0cd5b, doing it when explicit_binding >> was false. This prevented to use any binding point different to 0. >> >> Cc: 10.4, 10.5 >> Bugzilla: https://bugs.freedes

[Mesa-dev] [PATCH] glsl: remove element_type() helper

2015-04-30 Thread Timothy Arceri
We now have is_array() and without_array() that make the code much clearer and remove the need for this. For all remaining calls to this we already knew that the type was an array so it wasn't adding any value. --- src/glsl/ast_array_index.cpp | 2 +- src/glsl/ast_function.cpp| 8 ++

Re: [Mesa-dev] [PATCH] glsl: mark special built-in inputs referenced by vertex stage

2015-04-30 Thread Jose Fonseca
On 30/04/15 07:27, Tapani Pälli wrote: Refactoring done on active attribute queries did not take in to account special built-in inputs for the vertex stage. This commit sets them referenced by vertex stage so that they get enumerated properly. Fixes Piglit test 'get-active-attrib-returns-all-inp

Re: [Mesa-dev] [PATCH 15/21] i965: Define consistent interface to predicate an instruction.

2015-04-30 Thread Francisco Jerez
Matt Turner writes: > On Tue, Apr 28, 2015 at 10:08 AM, Francisco Jerez > wrote: >> --- >> src/mesa/drivers/dri/i965/brw_ir_fs.h| 22 ++ >> src/mesa/drivers/dri/i965/brw_ir_svec4.h | 26 ++ >> src/mesa/drivers/dri/i965/brw_ir_vec4.h | 22 +++

Re: [Mesa-dev] [PATCH 4/7] i965: Perform basic optimizations on the FIND_LIVE_CHANNEL opcode.

2015-04-30 Thread Francisco Jerez
Matt Turner writes: > On Fri, Feb 20, 2015 at 11:49 AM, Francisco Jerez > wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp | 49 >> ++ >> src/mesa/drivers/dri/i965/brw_fs.h | 1 + >> src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 1 + >> src/mesa

Re: [Mesa-dev] [PATCH 00/20] Begin enabling OpenGL ES 3.1

2015-04-30 Thread Mike Lothian
Isn't that override to change the GL version rather than the GLES version? On Thu, 30 Apr 2015 00:26 Ian Romanick wrote: > There's still a fair amount functionality left to be implemented before > GLES 3.1 can actually be enabled. Compute shaders and SSBOs are the > biggest things left to finis

Re: [Mesa-dev] [PATCH 4/7] i965: Perform basic optimizations on the FIND_LIVE_CHANNEL opcode.

2015-04-30 Thread Kenneth Graunke
On Thursday, April 30, 2015 04:59:49 PM Francisco Jerez wrote: > Matt Turner writes: > > > On Fri, Feb 20, 2015 at 11:49 AM, Francisco Jerez > > wrote: > >> --- > >> src/mesa/drivers/dri/i965/brw_fs.cpp | 49 > >> ++ > >> src/mesa/drivers/dri/i965/brw_fs.h

Re: [Mesa-dev] [PATCH 17/20] glapi/es3.1: Add support for GLES versions > 3.0

2015-04-30 Thread Jordan Justen
On 2015-04-29 16:26:08, Ian Romanick wrote: > From: Ian Romanick > > Make the checks in the Python script and the generated code more generic > to support arbitrary GLES versions >= 2.0. > > The updated dispatch_sanity.cpp test discovered this problem. Without > this, the next patch would erron

[Mesa-dev] [PATCH v2] i965/fs: Strip trailing constant zeroes in sample messages

2015-04-30 Thread Neil Roberts
If a send message is emitted with a message length that is less than required for the message then the remaining parameters default to zero. We can take advantage of this to save a register when a shader passes constant zeroes as the final coordinates to the sample function. I think this might be

Re: [Mesa-dev] [PATCH v2] i965/fs: Strip trailing constant zeroes in sample messages

2015-04-30 Thread Matt Turner
On Thu, Apr 30, 2015 at 10:27 AM, Neil Roberts wrote: > If a send message is emitted with a message length that is less than > required for the message then the remaining parameters default to > zero. We can take advantage of this to save a register when a shader > passes constant zeroes as the fi

Re: [Mesa-dev] [PATCH] glsl: mark special built-in inputs referenced by vertex stage

2015-04-30 Thread Mark Janes
Tested-by: Mark Janes Tapani Pälli writes: > Refactoring done on active attribute queries did not take in to > account special built-in inputs for the vertex stage. This commit > sets them referenced by vertex stage so that they get enumerated > properly. > > Fixes Piglit test 'get-active-attri

[Mesa-dev] [Bug 90213] glDrawPixels with GL_COLOR_INDEX never returns.

2015-04-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90213 --- Comment #3 from Jason Ekstrand --- (In reply to Iago Toral from comment #2) > Hi Mark, Juha: > > Some "special" formats, like GL_COLOR_INDEX, MESA_FORMAT_YCBCR or > byte-swapped scenarios need special handling before we can call > _mesa_form

Re: [Mesa-dev] [PATCH] i965/skl: Force the exec size to 8 when initing header for SIMD4x2

2015-04-30 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 15/20] glsl/es3.1: Allow textureGather and textureGatherOffset in GLSL ES 3.10

2015-04-30 Thread Chris Forbes
> /* Only ARB_texture_gather but not GLSL 4.0 or ARB_gpu_shader5. > * used for relaxation of const offset requirements. > */ > static bool > -texture_gather_only(const _mesa_glsl_parse_state *state) > +texture_gather_only_or_es31(const _mesa_glsl_parse_state *state) > { > return !state->

Re: [Mesa-dev] [PATCH 15/20] glsl/es3.1: Allow textureGather and textureGatherOffset in GLSL ES 3.10

2015-04-30 Thread Ilia Mirkin
On Thu, Apr 30, 2015 at 5:56 PM, Chris Forbes wrote: >> /* Only ARB_texture_gather but not GLSL 4.0 or ARB_gpu_shader5. >> * used for relaxation of const offset requirements. >> */ >> static bool >> -texture_gather_only(const _mesa_glsl_parse_state *state) >> +texture_gather_only_or_es31(con

Re: [Mesa-dev] [PATCH 15/20] glsl/es3.1: Allow textureGather and textureGatherOffset in GLSL ES 3.10

2015-04-30 Thread Chris Forbes
Nevermind, pre-coffee. On re-reading the GLSL ES 3.1 spec, the offset is required to be constant wherever texture offsets are used. On Fri, May 1, 2015 at 10:03 AM, Ilia Mirkin wrote: > On Thu, Apr 30, 2015 at 5:56 PM, Chris Forbes wrote: >>> /* Only ARB_texture_gather but not GLSL 4.0 or ARB_g

Re: [Mesa-dev] [PATCH] glsl: remove element_type() helper

2015-04-30 Thread Timothy Arceri
I've made two small changes to this locally see below. On Thu, 2015-04-30 at 21:31 +1000, Timothy Arceri wrote: > We now have is_array() and without_array() that make the > code much clearer and remove the need for this. > > For all remaining calls to this we already knew that > the type was an a

[Mesa-dev] [PATCH] gallium/ttn: add missing SNE

2015-04-30 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c index 59aaf67..f1f7ef3 100644 --- a/src/gallium/auxiliary/nir/tgsi_to_nir.c

[Mesa-dev] [PATCH] util/list: add list_first/last_entry

2015-04-30 Thread Rob Clark
From: Rob Clark I need an easier way to get at head/tail in ir3. Signed-off-by: Rob Clark --- Applies on top of Jason's move-u_double_list-to-util patches src/util/list.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/util/list.h b/src/util/list.h index 50bad4a..7ec2622 100644

Re: [Mesa-dev] [PATCH 11/13] nir/nir: Use a linked list instead of a has set for use/def sets

2015-04-30 Thread Connor Abbott
On Tue, Apr 28, 2015 at 12:03 AM, Jason Ekstrand wrote: > This commit switches us from the current setup of using hash sets for > use/def sets to using linked lists. Doing so should save us quite a bit of > memory because we aren't carrying around 3 hash sets per register and 2 per > SSA value.

Re: [Mesa-dev] [PATCH 11/21] i965/fs: Define scalarizing VEC4 pseudo-IR.

2015-04-30 Thread Mark Janes
Francisco Jerez writes: > This is not a real IR in the sense of a long-lived representation of > the program. An SVEC4 instruction, defined as an opcode operating on > 4-vectors of FS registers, is broken up into its scalar components > (each an fs_inst) as soon as it's emitted. The svec4_inst

Re: [Mesa-dev] [PATCH 11/13] nir/nir: Use a linked list instead of a has set for use/def sets

2015-04-30 Thread Jason Ekstrand
On Apr 30, 2015 7:37 PM, "Connor Abbott" wrote: > > On Tue, Apr 28, 2015 at 12:03 AM, Jason Ekstrand wrote: > > This commit switches us from the current setup of using hash sets for > > use/def sets to using linked lists. Doing so should save us quite a bit of > > memory because we aren't carryi

Re: [Mesa-dev] [PATCH 11/13] nir/nir: Use a linked list instead of a has set for use/def sets

2015-04-30 Thread Connor Abbott
>> > typedef struct nir_src { >> > union { >> > + nir_instr *parent_instr; >> > + struct nir_if *parent_if; >> > + }; >> > + >> > + struct list_head use_link; >> >> So I was thinking about this, and I realized that putting the list >> link here would mean that having SSA-only sou

Re: [Mesa-dev] [PATCH 20/23] i965: Plumb compiler debug logging through a function pointer in brw_compiler

2015-04-30 Thread Chris Forbes
Looks like everything prior to this patch has landed; Ken's two patches for the printf-like debug plumbing, and the remaining patches from this series are: Reviewed-by: Chris Forbes On Sun, Apr 19, 2015 at 9:02 AM, Jason Ekstrand wrote: > On Sat, Apr 18, 2015 at 1:55 PM, Kenneth Graunke > wr