Re: [Mesa-dev] [PATCH 01/12] nv50/ir: optimize the use of std::tr1::unordered_set

2015-05-18 Thread Chih-Wei Huang
2015-05-18 1:46 GMT+08:00 Chih-Wei Huang : > 2015-05-16 2:46 GMT+08:00 Ilia Mirkin : >> Please elaborate why this is necessary. I have, in the past, had >> requests to move to the C++11 std::unordered_set -- would that work >> for you? I'd be happy with a #if c++11 is available, use >> std::unorder

Re: [Mesa-dev] [PATCH 27/74] glsl: Lower shader storage buffer object writes to ir_ssbo_store

2015-05-18 Thread Iago Toral
On Mon, 2015-05-18 at 15:58 -0700, Jordan Justen wrote: > On 2015-05-14 07:06:30, Iago Toral Quiroga wrote: > > Extend the existing lower_ubo_reference pass to also detect SSBO writes > > and lower them to ir_ssbo_store nodes. > > --- > > src/glsl/lower_ubo_reference.cpp | 412 > > +++

Re: [Mesa-dev] [PATCH 00/74] ARB_shader_storage_buffer_object (mesa, i965)

2015-05-18 Thread Iago Toral
On Mon, 2015-05-18 at 15:49 -0700, Jordan Justen wrote: > On 2015-05-14 07:06:03, Iago Toral Quiroga wrote: > > Because SSBOs are very similar to UBOs the implementation attempts to > > reuse the code we already have for UBOs wherever we can. There is a lot > > of code in the GLSL compiler to deal

[Mesa-dev] [PATCH] mesa/main: validate name syntax for array variables only

2015-05-18 Thread Samuel Iglesias Gonsalvez
From ARB_program_interface_query: "Note that if an interface enumerates a single active resource list entry for an array variable (e.g., "a[0]"), a identifying any array element other than the first (e.g., "a[1]") is not considered to match." It doesn't apply to arrays of interface blocks bu

[Mesa-dev] [Bug 90397] ARB_program_interface_query: glGetProgramResourceiv() returns wrong value for GL_REFERENCED_BY_*_SHADER prop for GL_UNIFORM for members of an interface block with an instance na

2015-05-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90397 --- Comment #10 from Samuel Iglesias --- (In reply to Tapani Pälli from comment #9) > Thanks for the test. I do agree with the patch, UBO arrays should be treated > differently. > > Reviewed-by: Tapani Pälli > > (I'm resolving this bug as the

[Mesa-dev] [Bug 90397] ARB_program_interface_query: glGetProgramResourceiv() returns wrong value for GL_REFERENCED_BY_*_SHADER prop for GL_UNIFORM for members of an interface block with an instance na

2015-05-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90397 Tapani Pälli changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v3)

2015-05-18 Thread Jason Ekstrand
On Mon, May 18, 2015 at 10:34 AM, Francisco Jerez wrote: > Francisco Jerez writes: [...] Snip >>> ### SIMD16 Instruction Splitting ### >>> >>> SIMD16 instruction splitting is an unfortunate fact of our hardware. >>> There are a variety of times we have to do it including dua

Re: [Mesa-dev] [PATCH 00/15] Make ARB_direct_state_access exclusive to core profile

2015-05-18 Thread Dave Airlie
On 19 May 2015 at 11:02, Ian Romanick wrote: > On 05/18/2015 05:35 PM, Ian Romanick wrote: >> On 05/18/2015 02:34 PM, Dave Airlie wrote: >>> On 19 May 2015 at 07:28, Ian Romanick wrote: With the patches already on the piglit list, the only change is gettextureimage-formats, gettextureim

Re: [Mesa-dev] [PATCH] mesa/driver/haiku: Drop Mesa swrast renderer

2015-05-18 Thread Alexander von Gluck IV
On , Emil Velikov wrote: Hi Alexander, On 17 May 2015 at 13:49, Alexander von Gluck IV wrote: This just created extra upkeep and the push to move extern C's into mesa code would mean a large number of extern's in core Mesa driver interfaces. The Haiku Gallium renderers are mostly insulated vi

Re: [Mesa-dev] [PATCH 00/15] Make ARB_direct_state_access exclusive to core profile

2015-05-18 Thread Ian Romanick
On 05/18/2015 05:35 PM, Ian Romanick wrote: > On 05/18/2015 02:34 PM, Dave Airlie wrote: >> On 19 May 2015 at 07:28, Ian Romanick wrote: >>> With the patches already on the piglit list, the only change is >>> gettextureimage-formats, gettextureimage-formats init-by-rendering, and >>> gettextureima

Re: [Mesa-dev] [PATCH] Fix symbol 'x86_64_entry_start' is already defined when building with LLVM/clang

2015-05-18 Thread Tomasz Gajc
Hello, my patch is based on that LLVM bug. Mesa with that patch was tested only with clang by me, and I haven't found any issues when running my system with mesa with that patch applied. Wysłano z Samsung Grand Neo Orange Polska ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 00/15] Make ARB_direct_state_access exclusive to core profile

2015-05-18 Thread Ian Romanick
On 05/18/2015 02:34 PM, Dave Airlie wrote: > On 19 May 2015 at 07:28, Ian Romanick wrote: >> With the patches already on the piglit list, the only change is >> gettextureimage-formats, gettextureimage-formats init-by-rendering, and >> gettextureimage-luminance change from pass to skip. > > This m

Re: [Mesa-dev] Mesa (master): 57 new commits

2015-05-18 Thread Ian Romanick
On 05/15/2015 04:05 PM, Fredrik Höglund wrote: > On Friday 15 May 2015, Ian Romanick wrote: >> On 05/15/2015 12:10 PM, Fredrik Höglund wrote: >>> On Friday 15 May 2015, Ian Romanick wrote: On 05/15/2015 05:26 AM, Fredrik Höglund wrote: I'm also going to say that I'm quite pissed that this

Re: [Mesa-dev] [PATCH 27/74] glsl: Lower shader storage buffer object writes to ir_ssbo_store

2015-05-18 Thread Jordan Justen
On 2015-05-14 07:06:30, Iago Toral Quiroga wrote: > Extend the existing lower_ubo_reference pass to also detect SSBO writes > and lower them to ir_ssbo_store nodes. > --- > src/glsl/lower_ubo_reference.cpp | 412 > +++ > 1 file changed, 336 insertions(+), 76 de

Re: [Mesa-dev] [PATCH 00/74] ARB_shader_storage_buffer_object (mesa, i965)

2015-05-18 Thread Jordan Justen
On 2015-05-14 07:06:03, Iago Toral Quiroga wrote: > Because SSBOs are very similar to UBOs the implementation attempts to > reuse the code we already have for UBOs wherever we can. There is a lot > of code in the GLSL compiler to deal with UBOs, so we do not want to > exactly duplicate that. An "is

Re: [Mesa-dev] Mesa 10.6 release plan

2015-05-18 Thread Jason Ekstrand
On Sun, May 17, 2015 at 2:44 PM, Kenneth Graunke wrote: > On Sunday, May 17, 2015 09:34:30 AM Emil Velikov wrote: >> On 16/05/15 17:11, Jason Ekstrand wrote: >> > There was some discussion on IRC today about what the official date >> > is. A bunch of Intel people have been working under the assum

Re: [Mesa-dev] [RFC PATCH] nir: Transform 4*x into x << 2 during late optimizations.

2015-05-18 Thread Jason Ekstrand
On Mon, May 18, 2015 at 3:28 PM, Kenneth Graunke wrote: > On Monday, May 18, 2015 11:26:05 AM Matt Turner wrote: >> On Fri, May 8, 2015 at 3:36 AM, Kenneth Graunke >> wrote: >> > According to Glenn, shifts on R600 have 5x the throughput as multiplies. >> > >> > Intel GPUs have strange integer mu

Re: [Mesa-dev] [RFC PATCH] nir: Transform 4*x into x << 2 during late optimizations.

2015-05-18 Thread Kenneth Graunke
On Monday, May 18, 2015 11:26:05 AM Matt Turner wrote: > On Fri, May 8, 2015 at 3:36 AM, Kenneth Graunke wrote: > > According to Glenn, shifts on R600 have 5x the throughput as multiplies. > > > > Intel GPUs have strange integer multiplication restrictions - on most > > hardware, MUL actually only

[Mesa-dev] [PATCH] i965/disasm: Skip swizzle disassembly when using 3-src repctrl.

2015-05-18 Thread Matt Turner
... since it's always .x, and also always print the subreg offset when using repctrl. --- src/mesa/drivers/dri/i965/brw_disasm.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c b/src/mesa/drivers/dri/i965/brw_disasm

[Mesa-dev] [PATCH] nir: Remove sRGB colorspace conversion round-trip.

2015-05-18 Thread Matt Turner
Some shaders in Civilization V and Beyond Earth do pow(pow(x, 2.2), 0.454545) which is converting to and from sRGB colorspace. A more general rule that replaces pow(pow(a, b), c) with pow(a, b * c) actually regresses two shaders in Sun Temple in which the result of the inner pow is used twice

Re: [Mesa-dev] [PATCH 00/15] Make ARB_direct_state_access exclusive to core profile

2015-05-18 Thread Dave Airlie
On 19 May 2015 at 07:28, Ian Romanick wrote: > With the patches already on the piglit list, the only change is > gettextureimage-formats, gettextureimage-formats init-by-rendering, and > gettextureimage-luminance change from pass to skip. > This might be a naive question, with dummy false core on

[Mesa-dev] [PATCH 09/15] Revert "mesa: Add ARB_direct_state_access checks in renderbuffer functions"

2015-05-18 Thread Ian Romanick
From: Ian Romanick This reverts commit cb49940766b581c6656473d89c221653c69fa0f9. Cc: "10.6" --- src/mesa/main/fbobject.c | 21 - 1 file changed, 21 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 1859c27..de8af46 100644 --- a/src/mesa/ma

[Mesa-dev] [PATCH 00/15] Make ARB_direct_state_access exclusive to core profile

2015-05-18 Thread Ian Romanick
With the patches already on the piglit list, the only change is gettextureimage-formats, gettextureimage-formats init-by-rendering, and gettextureimage-luminance change from pass to skip. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://li

[Mesa-dev] [PATCH 01/15] Revert "st/mesa: Enable ARB_direct_state_access"

2015-05-18 Thread Ian Romanick
From: Ian Romanick This reverts commit 357bf80caade9e0be20dcc88ec38884e34abc986. Cc: "10.6" --- src/mesa/state_tracker/st_extensions.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 23a4588..b1057f

[Mesa-dev] [PATCH 12/15] Revert "mesa: Add ARB_direct_state_access checks in XFB functions"

2015-05-18 Thread Ian Romanick
From: Ian Romanick This reverts commit 7d212765a470972f4712e42caf6406b257220369. Cc: "10.6" --- src/mesa/main/transformfeedback.c | 42 --- 1 file changed, 42 deletions(-) diff --git a/src/mesa/main/transformfeedback.c b/src/mesa/main/transformfeedback.c i

[Mesa-dev] [PATCH 07/15] Revert "mesa: Add ARB_direct_state_access checks in VAO functions"

2015-05-18 Thread Ian Romanick
From: Ian Romanick This reverts commit 36b05793372b86b914d9b95d0188f5f387e01d68. Cc: "10.6" --- src/mesa/main/arrayobj.c | 22 - src/mesa/main/varray.c | 64 2 files changed, 86 deletions(-) diff --git a/src/mesa/main/arrayobj

[Mesa-dev] [PATCH 10/15] Revert "mesa: Add ARB_direct_state_access checks in FBO functions"

2015-05-18 Thread Ian Romanick
From: Ian Romanick This reverts commit 6ad0b7e07a0445e9e0f368e079c4f7b8a6757bb3. Cc: "10.6" --- src/mesa/main/blit.c | 7 - src/mesa/main/buffers.c | 21 --- src/mesa/main/clear.c| 32 --- src/mesa/main/fbobject.c | 67 -

[Mesa-dev] [PATCH 11/15] Revert "mesa: Add ARB_direct_state_access checks in buffer object functions"

2015-05-18 Thread Ian Romanick
From: Ian Romanick This reverts commit 339ed0984d4f54fca91235a1df2ce3a850f6123f. Cc: "10.6" --- src/mesa/main/bufferobj.c | 105 -- 1 file changed, 105 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 660bc94..66

[Mesa-dev] [PATCH 02/15] Revert "i965: Enable ARB_direct_state_access"

2015-05-18 Thread Ian Romanick
From: Ian Romanick This reverts commit a57feba0a35de35728269aeb26b039e4f2393d69. Cc: "10.6" --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 18b

[Mesa-dev] [PATCH 15/15] mesa: Enable ARB_direct_state_access by default for core profile

2015-05-18 Thread Ian Romanick
From: Ian Romanick And core profile only. Signed-off-by: Ian Romanick Cc: "10.6" --- src/mesa/main/extensions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index f7ce064..f9bf503 100644 --- a/src/mesa/main/extensi

[Mesa-dev] [PATCH 13/15] Revert "mesa: Make GL_TEXTURE_CUBE_MAP valid in FramebufferTextureLayer"

2015-05-18 Thread Ian Romanick
From: Ian Romanick This reverts commit 03420eac0c53280beae5f72783e52950fd1e3fba. Cc: "10.6" --- src/mesa/main/fbobject.c | 36 +--- 1 file changed, 5 insertions(+), 31 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 5b8c52a..

[Mesa-dev] [PATCH 05/15] Revert "mesa: Add ARB_direct_state_access checks in program pipeline functions"

2015-05-18 Thread Ian Romanick
From: Ian Romanick This reverts commit bebf3c6ab314bde05ac5a3b4d3e63fd36243c58e. Cc: "10.6" --- src/mesa/main/pipelineobj.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c index a33cdd1..0fefa7d 100644 --- a/src/mesa/main/pipel

[Mesa-dev] [PATCH 03/15] Revert "i915: Enable ARB_direct_state_access"

2015-05-18 Thread Ian Romanick
From: Ian Romanick This reverts commit 121030eed8fc41789d2f4f7517bbc0dd6199667b. Cc: "10.6" --- src/mesa/drivers/dri/i915/intel_extensions.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i915/intel_extensions.c b/src/mesa/drivers/dri/i915/intel_extensions.c index 590

[Mesa-dev] [PATCH 14/15] Revert "mesa: Add an extension flag for ARB_direct_state_access"

2015-05-18 Thread Ian Romanick
From: Ian Romanick This reverts commit 30dcaaec356cc117d7227c6680620cd50ff534e7. Cc: "10.6" --- src/mesa/main/extensions.c | 2 +- src/mesa/main/mtypes.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index c8241

[Mesa-dev] [PATCH 04/15] Revert "mesa: Add ARB_direct_state_access checks in query object functions"

2015-05-18 Thread Ian Romanick
From: Ian Romanick This reverts commit d3368e0c9e27ced6059eb2ecdf2aa999a00e90b0. Cc: "10.6" --- src/mesa/main/queryobj.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index 2784b4c..5ff1b95 100644 --- a/src/mesa/main/queryobj.c ++

[Mesa-dev] [PATCH 06/15] Revert "mesa: Add ARB_direct_state_access checks in sampler object functions"

2015-05-18 Thread Ian Romanick
From: Ian Romanick This reverts commit 9e7149c8986348bf9567f049444783ef52775f4e. Cc: "10.6" --- src/mesa/main/samplerobj.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index 60711a5..a3aacc6 100644 --- a/src/mesa/main/sampler

[Mesa-dev] [PATCH 08/15] Revert "mesa: Add ARB_direct_state_access checks in texture functions"

2015-05-18 Thread Ian Romanick
From: Ian Romanick This reverts commit 8940957238e8584ce27295791cee4cc3d6f7cf1e. Cc: "10.6" --- src/mesa/main/genmipmap.c | 7 src/mesa/main/texgetimage.c | 14 src/mesa/main/teximage.c| 74 --- src/mesa/main/texobj.c | 14

Re: [Mesa-dev] Problem with ___glapi_noop_table

2015-05-18 Thread Shervin Sharifi
Hi Brian, Thanks for your response. I downloaded version 10.5.5 sources from ftp://ftp.freedesktop.org/pub/mesa/. I just unzipped the files and put them in a folder. I have previously built llvm3.4 before (I've used it with previous versions of mesa). Here is the command line I'm using in ming

Re: [Mesa-dev] [PATCH 3/6] i965/fs: Add set_sechalf() method.

2015-05-18 Thread Francisco Jerez
Matt Turner writes: > On Fri, May 15, 2015 at 2:46 PM, Francisco Jerez > wrote: >> Matt Turner writes: >> >>> Used in the next commit. >>> --- >>> src/mesa/drivers/dri/i965/brw_ir_fs.h | 10 ++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/src/mesa/drivers/dri/i965/brw_ir_

[Mesa-dev] [PATCH] i965: Use padding requirement cube map array type

2015-05-18 Thread Ben Widawsky
"The value of j is still equal to q for mip level alignment and QPitch calculation. For cube surfaces, an additional two rows of padding are required at the bottom of the surface... This is due to the potential rotation of cache line orientation from memory to cache." " Cube map array applies as

Re: [Mesa-dev] [PATCH 3/6] i965/fs: Add set_sechalf() method.

2015-05-18 Thread Matt Turner
On Fri, May 15, 2015 at 2:46 PM, Francisco Jerez wrote: > Matt Turner writes: > >> Used in the next commit. >> --- >> src/mesa/drivers/dri/i965/brw_ir_fs.h | 10 ++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/src/mesa/drivers/dri/i965/brw_ir_fs.h >> b/src/mesa/drivers/dri/i96

Re: [Mesa-dev] [PATCH 6/8] [v2] i965: Add Gen9 surface state decoding

2015-05-18 Thread Pohjolainen, Topi
On Mon, May 18, 2015 at 10:39:58AM -0700, Ben Widawsky wrote: > On Mon, May 18, 2015 at 11:02:32AM +0300, Pohjolainen, Topi wrote: > > On Fri, May 15, 2015 at 10:06:22PM -0700, Ben Widawsky wrote: > > > Gen9 surface state is very similar to the previous generation. The > > > important > > > change

Re: [Mesa-dev] [RFC PATCH] nir: Transform 4*x into x << 2 during late optimizations.

2015-05-18 Thread Matt Turner
On Fri, May 8, 2015 at 3:36 AM, Kenneth Graunke wrote: > According to Glenn, shifts on R600 have 5x the throughput as multiplies. > > Intel GPUs have strange integer multiplication restrictions - on most > hardware, MUL actually only does a 32-bit x 16-bit multiply. This > means the arguments are

Re: [Mesa-dev] [PATCH 2/8] [v4] i965: Add all surface types to the batch decode

2015-05-18 Thread Kenneth Graunke
On Monday, May 18, 2015 10:51:31 AM Ben Widawsky wrote: > It's true that not all surfaces apply for every gen, but for the most part > this > is what we want. (The unfortunate case is when we use a valid surface, but not > for the specific GEN). > > This was automated with a vim macro. > > v2: S

[Mesa-dev] [PATCH 2/8] [v4] i965: Add all surface types to the batch decode

2015-05-18 Thread Ben Widawsky
It's true that not all surfaces apply for every gen, but for the most part this is what we want. (The unfortunate case is when we use a valid surface, but not for the specific GEN). This was automated with a vim macro. v2: Shortened common forms such as R8G8B8A8->RGBA8. Note that this makes some

Re: [Mesa-dev] [PATCH 7/8] [v3] i965: Add renderbuffer surface indexes to debug

2015-05-18 Thread Ben Widawsky
On Mon, May 18, 2015 at 11:26:47AM +0300, Pohjolainen, Topi wrote: > On Fri, May 15, 2015 at 10:06:23PM -0700, Ben Widawsky wrote: > > This patch is optional in the series. It does make the output much cleaner, > > but > > there is some risk. > > What is the risk, I couldn't figure it out myself.

Re: [Mesa-dev] [PATCH 6/8] [v2] i965: Add Gen9 surface state decoding

2015-05-18 Thread Ben Widawsky
On Mon, May 18, 2015 at 11:02:32AM +0300, Pohjolainen, Topi wrote: > On Fri, May 15, 2015 at 10:06:22PM -0700, Ben Widawsky wrote: > > Gen9 surface state is very similar to the previous generation. The important > > changes here are aux mode, and the way clear colors work. > > > > NOTE: There are

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v3)

2015-05-18 Thread Francisco Jerez
Francisco Jerez writes: > Jason Ekstrand writes: > >> On May 15, 2015 2:40 PM, "Francisco Jerez" wrote: >>> >>> Jason Ekstrand writes: >>> >>> > On Fri, May 15, 2015 at 9:51 AM, Francisco Jerez >> wrote: >>> >> Jason Ekstrand writes: >>> >> >>> >>> I haven't said much about this series up un

Re: [Mesa-dev] [PATCH] gallium: remove TGSI_SAT_MINUS_PLUS_ONE

2015-05-18 Thread Roland Scheidegger
On 05/17/2015 04:49 PM, Marek Olšák wrote: From: Marek Olšák It's a remnant of some old NV extension. Unused. I also have a patch that removes predicates if anyone is interested. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c| 16 +-- src/gallium/auxiliary/gallivm/lp_bld_tgsi_s

Re: [Mesa-dev] [PATCH] cso: add context cleanup code from st/mesa

2015-05-18 Thread Marek Olšák
I think Signed-off-by is only required for kernel patches. Marek On Mon, May 18, 2015 at 3:39 PM, Tobias Klausmann wrote: > Reviewed-by: Tobias Klausmann > > On 18.05.2015 11:29, Marek Olšák wrote: >> >> From: Marek Olšák >> >> This fixes a crash in nouveau which can't handle >> set_constant_b

[Mesa-dev] [Bug 90438] glxinfo should have a quiet mode

2015-05-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90438 --- Comment #4 from Bryan Quigley --- > 2. I think 'quiet' isn't quite the right term. How about 'brief' using -B > as the flag (since -b is already taken)? That works. 1&3. Thanks! -- You are receiving this mail because: You are the QA Con

Re: [Mesa-dev] [PATCH] cso: add context cleanup code from st/mesa

2015-05-18 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Mon, May 18, 2015 at 5:29 AM, Marek Olšák wrote: > From: Marek Olšák > > This fixes a crash in nouveau which can't handle > set_constant_buffer(PIPE_SHADER_TESS_*). > --- > src/gallium/auxiliary/cso_cache/cso_context.c | 7 +++ > src/mesa/state_tracker/st_contex

Re: [Mesa-dev] [PATCH] cso: add context cleanup code from st/mesa

2015-05-18 Thread Tobias Klausmann
Reviewed-by: Tobias Klausmann On 18.05.2015 11:29, Marek Olšák wrote: From: Marek Olšák This fixes a crash in nouveau which can't handle set_constant_buffer(PIPE_SHADER_TESS_*). where is the S-o-b ? ;-) --- src/gallium/auxiliary/cso_cache/cso_context.c | 7 +++ src/mesa/state_track

Re: [Mesa-dev] [PATCH 1/2] nv50: add a header file for nv50_query

2015-05-18 Thread Samuel Pitoiset
On 05/18/2015 03:34 PM, Tobias Klausmann wrote: On 18.05.2015 10:43, Samuel Pitoiset wrote: Thanks for the review. Can I get your R-b for the other patches of the series. :-) Oh silly me, it was meant to be a R-b for patch 1+2 on both series, sorry :) No worries. :-) On 05/17/2015

Re: [Mesa-dev] [PATCH] cso: add context cleanup code from st/mesa

2015-05-18 Thread Samuel Pitoiset
On 05/18/2015 02:08 PM, Marek Olšák wrote: Technically speaking, nothing needs to be destroyed. It's the responsibility of the driver to clean up after itself. The answer is no, because the compute shader isn't used by cso_context and st/mesa. Sounds good to me. Thanks for your answer Marek.

Re: [Mesa-dev] [PATCH 1/2] nv50: add a header file for nv50_query

2015-05-18 Thread Tobias Klausmann
On 18.05.2015 10:43, Samuel Pitoiset wrote: Thanks for the review. Can I get your R-b for the other patches of the series. :-) Oh silly me, it was meant to be a R-b for patch 1+2 on both series, sorry :) On 05/17/2015 06:46 PM, Tobias Klausmann wrote: Reviewed-by: Tobias Klausmann On 1

Re: [Mesa-dev] [PATCH] cso: add context cleanup code from st/mesa

2015-05-18 Thread Marek Olšák
Technically speaking, nothing needs to be destroyed. It's the responsibility of the driver to clean up after itself. The answer is no, because the compute shader isn't used by cso_context and st/mesa. Marek On Mon, May 18, 2015 at 1:15 PM, Samuel Pitoiset wrote: > > > On 05/18/2015 11:29 AM, Ma

Re: [Mesa-dev] [PATCH] mesa/driver/haiku: Drop Mesa swrast renderer

2015-05-18 Thread Emil Velikov
Hi Alexander, On 17 May 2015 at 13:49, Alexander von Gluck IV wrote: > This just created extra upkeep and the push to move extern > C's into mesa code would mean a large number of extern's > in core Mesa driver interfaces. The Haiku Gallium renderers > are mostly insulated via the C-based Haiku s

Re: [Mesa-dev] [PATCH] cso: add context cleanup code from st/mesa

2015-05-18 Thread Samuel Pitoiset
On 05/18/2015 11:29 AM, Marek Olšák wrote: From: Marek Olšák This fixes a crash in nouveau which can't handle set_constant_buffer(PIPE_SHADER_TESS_*). --- src/gallium/auxiliary/cso_cache/cso_context.c | 7 +++ src/mesa/state_tracker/st_context.c | 6 -- 2 files changed,

[Mesa-dev] [Bug 90397] ARB_program_interface_query: glGetProgramResourceiv() returns wrong value for GL_REFERENCED_BY_*_SHADER prop for GL_UNIFORM for members of an interface block with an instance na

2015-05-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90397 --- Comment #8 from Samuel Iglesias --- (In reply to Tapani Pälli from comment #7) > (In reply to Samuel Iglesias from comment #6) > > (In reply to Tapani Pälli from comment #5) > > > (In reply to Samuel Iglesias from comment #4) > > > > I unders

[Mesa-dev] [Bug 90397] ARB_program_interface_query: glGetProgramResourceiv() returns wrong value for GL_REFERENCED_BY_*_SHADER prop for GL_UNIFORM for members of an interface block with an instance na

2015-05-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90397 --- Comment #7 from Tapani Pälli --- (In reply to Samuel Iglesias from comment #6) > (In reply to Tapani Pälli from comment #5) > > (In reply to Samuel Iglesias from comment #4) > > > I understand that this is referring to uniform/buffer variable

[Mesa-dev] [Bug 90397] ARB_program_interface_query: glGetProgramResourceiv() returns wrong value for GL_REFERENCED_BY_*_SHADER prop for GL_UNIFORM for members of an interface block with an instance na

2015-05-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90397 --- Comment #6 from Samuel Iglesias --- (In reply to Tapani Pälli from comment #5) > (In reply to Samuel Iglesias from comment #4) > > I understand that this is referring to uniform/buffer variables but not > > uniform/shader-storage blocks, but

[Mesa-dev] [PATCH] cso: add context cleanup code from st/mesa

2015-05-18 Thread Marek Olšák
From: Marek Olšák This fixes a crash in nouveau which can't handle set_constant_buffer(PIPE_SHADER_TESS_*). --- src/gallium/auxiliary/cso_cache/cso_context.c | 7 +++ src/mesa/state_tracker/st_context.c | 6 -- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/

[Mesa-dev] [Bug 90397] ARB_program_interface_query: glGetProgramResourceiv() returns wrong value for GL_REFERENCED_BY_*_SHADER prop for GL_UNIFORM for members of an interface block with an instance na

2015-05-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90397 --- Comment #5 from Tapani Pälli --- (In reply to Samuel Iglesias from comment #4) > I understand that this is referring to uniform/buffer variables but not > uniform/shader-storage blocks, but I might be wrong. > > I would like to have your opi

Re: [Mesa-dev] [Nouveau] [PATCH] nvc0: fix context destruction for partly implemented tesselation

2015-05-18 Thread Marek Olšák
We should fix st/mesa and move the code to cso_destroy_context, where it belongs. Marek On Mon, May 18, 2015 at 3:49 AM, Ilia Mirkin wrote: > Hm, oops. But I guess my tess patchset will take care of this. I guess > it's a side-effect of adding to the gallium enums. > > Marek, you ended up pushin

Re: [Mesa-dev] [PATCH 1/8] i965: Add string for surface format to table

2015-05-18 Thread Kenneth Graunke
On Friday, May 15, 2015 10:06:17 PM Ben Widawsky wrote: > Recommended-by: Kenneth Graunke > Signed-off-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/brw_surface_formats.c | 436 > > 1 file changed, 219 insertions(+), 217 deletions(-) Acked-by: Kenneth Graunke I

Re: [Mesa-dev] [PATCH 1/2] nv50: add a header file for nv50_query

2015-05-18 Thread Samuel Pitoiset
Thanks for the review. Can I get your R-b for the other patches of the series. :-) On 05/17/2015 06:46 PM, Tobias Klausmann wrote: Reviewed-by: Tobias Klausmann On 17.05.2015 18:19, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/Makefile.sources|

Re: [Mesa-dev] [PATCH 2/8] [v3] i965: Add all surface types to the batch decode

2015-05-18 Thread Kenneth Graunke
On Friday, May 15, 2015 10:06:18 PM Ben Widawsky wrote: > It's true that not all surfaces apply for every gen, but for the most part > this > is what we want. (The unfortunate case is when we use an valid surface, but > not > for the specific GEN). > > This was automated with a vim macro. > > v

Re: [Mesa-dev] [PATCH 3/8] [v2] i965: Add viewport extents (gen8) to batch decode

2015-05-18 Thread Kenneth Graunke
On Friday, May 15, 2015 10:06:19 PM Ben Widawsky wrote: > 0x7da0: 0xc1da740e: SF_CLIP VP: guardband xmin = -27.306667 > 0x7da4: 0x41da740e: SF_CLIP VP: guardband xmax = 27.306667 > 0x7da4: 0x41da740e: SF_CLIP VP: guardband ymin = -23.405714 > 0x7da8: 0xc1bb3ee7:

Re: [Mesa-dev] [RFC 01/16] glsl: Add tracking for GLSL precision qualifiers

2015-05-18 Thread Pohjolainen, Topi
On Mon, May 18, 2015 at 11:19:13AM +0300, Petri Latvala wrote: > On 05/15/2015 12:39 PM, Topi Pohjolainen wrote: > >diff --git a/src/glsl/glsl_types.h b/src/glsl/glsl_types.h > >index 5645dcd..25c4d30 100644 > >--- a/src/glsl/glsl_types.h > >+++ b/src/glsl/glsl_types.h > >@@ -100,6 +100,13 @@ enum

Re: [Mesa-dev] [PATCH 2/8] [v3] i965: Add all surface types to the batch decode

2015-05-18 Thread Pohjolainen, Topi
On Fri, May 15, 2015 at 10:06:18PM -0700, Ben Widawsky wrote: > It's true that not all surfaces apply for every gen, but for the most part > this > is what we want. (The unfortunate case is when we use an valid surface, but > not > for the specific GEN). > > This was automated with a vim macro.

Re: [Mesa-dev] [PATCH 7/8] [v3] i965: Add renderbuffer surface indexes to debug

2015-05-18 Thread Pohjolainen, Topi
On Fri, May 15, 2015 at 10:06:23PM -0700, Ben Widawsky wrote: > This patch is optional in the series. It does make the output much cleaner, > but > there is some risk. What is the risk, I couldn't figure it out myself. To me the patch make sense and it would have been useful for me before in more

Re: [Mesa-dev] [RFC 01/16] glsl: Add tracking for GLSL precision qualifiers

2015-05-18 Thread Petri Latvala
On 05/15/2015 12:39 PM, Topi Pohjolainen wrote: diff --git a/src/glsl/glsl_types.h b/src/glsl/glsl_types.h index 5645dcd..25c4d30 100644 --- a/src/glsl/glsl_types.h +++ b/src/glsl/glsl_types.h @@ -100,6 +100,13 @@ enum glsl_matrix_layout { GLSL_MATRIX_LAYOUT_ROW_MAJOR }; +enum { + GL

Re: [Mesa-dev] [PATCH 5/7] i965: Add Gen9 surface state decoding

2015-05-18 Thread Pohjolainen, Topi
On Fri, May 15, 2015 at 08:26:33PM -0700, Ben Widawsky wrote: > On Fri, May 15, 2015 at 08:22:29PM -0700, Ben Widawsky wrote: > > On Fri, Apr 24, 2015 at 09:05:44PM +0300, Pohjolainen, Topi wrote: > > > On Thu, Apr 23, 2015 at 04:50:02PM -0700, Ben Widawsky wrote: > > > > Gen9 surface state is very

Re: [Mesa-dev] [PATCH 6/8] [v2] i965: Add Gen9 surface state decoding

2015-05-18 Thread Pohjolainen, Topi
On Fri, May 15, 2015 at 10:06:22PM -0700, Ben Widawsky wrote: > Gen9 surface state is very similar to the previous generation. The important > changes here are aux mode, and the way clear colors work. > > NOTE: There are some things intentionally left out of this decoding. > > v2: Redo the string

[Mesa-dev] [Bug 90497] link: /usr/lib64/dri/i965_dri.so: undefined symbol: _glapi_set_nop_handler

2015-05-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90497 Igor Gnatenko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---