Re: [Mesa-dev] [PATCH] egl/x11: Remove duplicate call to dri2_x11_add_configs_for_visuals

2015-06-15 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez sigles...@igalia.com Sam On 13/06/15 09:33, Boyan Ding wrote: The call to dri2_x11_add_configs_for_visuals (previously dri2_add_configs_for_visuals) was moved downwards in commit f8c5b8a1, but appeared again in its original position after its rename in

[Mesa-dev] [PATCH v3 5/6] mesa/es3.1: enable GL_ARB_compute_shader for GLES 3.1

2015-06-15 Thread Marta Lofstedt
From: Marta Lofstedt marta.lofst...@intel.com v3 : only expose GL_ARB_compute_shader enums for gles 3.1 and GL core. Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 20 ++-- 2 files

[Mesa-dev] [PATCH v3 2/6] mesa/es3.1: enable GL_ARB_shader_atomic_counters for GLES 3.1

2015-06-15 Thread Marta Lofstedt
From: Marta Lofstedt marta.lofst...@intel.com v3 : only expose ARB_shader_atomic_counters enums for gles 3.1 and GL core. Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 22 +- 2

[Mesa-dev] [PATCH v3 4/6] mesa/es3.1: enable GL_ARB_texture_gather for GLES 3.1

2015-06-15 Thread Marta Lofstedt
From: Marta Lofstedt marta.lofst...@intel.com v3 : only expose GL_ARB_texture_gather enums for gles 3.1 and GL core. Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 10 +- 2 files changed, 11

[Mesa-dev] [PATCH v3 6/6] mesa/es3.1: enable GL_ARB_explicit_uniform_location for GLES 3.1

2015-06-15 Thread Marta Lofstedt
From: Marta Lofstedt marta.lofst...@intel.com v3 : only expose GL_ARB_explicit_uniform_location enums for gles 3.1 and GL core. Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 4 +++- 2 files changed, 9

[Mesa-dev] [PATCH v3 1/6] mesa/es3.1: enable GL_ARB_shader_image_load_store for gles3.1

2015-06-15 Thread Marta Lofstedt
From: Marta Lofstedt marta.lofst...@intel.com v3: only expose enums from GL_ARB_shader_image_load_store for gles 3.1 and GL core Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 16 +--- 2

[Mesa-dev] [PATCH v3 3/6] mesa/es3.1: enable GL_ARB_texture_multisample for GLES 3.1

2015-06-15 Thread Marta Lofstedt
From: Marta Lofstedt marta.lofst...@intel.com v3 : only expose GL_ARB_texture_multisample enums for gles 3.1 and Gl core. Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 18 +- 2 files

[Mesa-dev] [PATCH v3 0/6] Continue enabling OpenGL ES 3.1

2015-06-15 Thread Marta Lofstedt
This is the V3 versions of my previous patch-set. Also, please note that Tapani's patch that was originally part of this patch-set was merged: git@83624c141d3 Marta Lofstedt (6): mesa/es3.1: enable GL_ARB_shader_image_load_store for gles3.1 mesa/es3.1: enable GL_ARB_shader_atomic_counters for

Re: [Mesa-dev] [PATCH] glsl/es31:Allow GL_ARB_TEXTURE_MULTISAMPLE in GLSL ES 3.10

2015-06-15 Thread Lofstedt, Marta
-Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Ilia Mirkin Sent: Tuesday, May 12, 2015 5:00 PM To: Marta Lofstedt Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] glsl/es31:Allow GL_ARB_TEXTURE_MULTISAMPLE in GLSL

[Mesa-dev] [PATCH v3] mesa/es3.1: Pass sample count check for multisampled textures

2015-06-15 Thread Marta Lofstedt
From: Marta Lofstedt marta.lofst...@intel.com v3 : Removed space in comment. Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/multisample.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/multisample.c b/src/mesa/main/multisample.c

[Mesa-dev] [PATCH] Revert glsl: remove restriction on unsized arrays in GLSL ES 3.10

2015-06-15 Thread Timothy Arceri
This reverts commit adee54f8269c5e9f4fde91d19f0e465afc8f14d8. Further down in the GLSL ES 3.10 spec it say: If an array is declared as the last member of a shader storage block and the size is not specified at compile-time, it is sized at run-time. In all other cases, arrays are sized only at

Re: [Mesa-dev] [PATCH v2 36/82] glsl: add support for unsized arrays in shader storage blocks

2015-06-15 Thread Timothy Arceri
On Wed, 2015-06-03 at 09:01 +0200, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com They only can be defined in the last position of the shader storage blocks. When an unsized array is used in different shaders, it might be converted in different sized

[Mesa-dev] [PATCH v2] glsl/es31:Allow GL_ARB_TEXTURE_MULTISAMPLE in GLSL ES 3.10

2015-06-15 Thread Marta Lofstedt
From: Marta Lofstedt marta.lofst...@intel.com Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/glsl/builtin_functions.cpp | 3 +-- src/glsl/builtin_types.cpp | 2 +- src/glsl/glsl_lexer.ll | 13 +++-- src/glsl/glsl_parser_extras.h | 7 ++- 4 files

Re: [Mesa-dev] [PATCH 2/7] mesa/es3.1: enable GL_ARB_shader_image_load_store for gles3.1

2015-06-15 Thread Lofstedt, Marta
-Original Message- From: Ian Romanick [mailto:i...@freedesktop.org] Sent: Tuesday, June 9, 2015 6:08 PM To: Lofstedt, Marta; mesa-dev@lists.freedesktop.org Cc: sa...@lapland.gov Subject: Re: [Mesa-dev] [PATCH 2/7] mesa/es3.1: enable GL_ARB_shader_image_load_store for gles3.1 On

[Mesa-dev] [PATCHv2 4/9] drisw/glx: use XShm if possible

2015-06-15 Thread Marc-André Lureau
Implements putImageShm from DRIswrastLoaderExtension. If XShm extension is not available, or fails, it will fallback on regular XPutImage(). Tested on Linux only with 16bpp and 32bpp visual. --- src/glx/drisw_glx.c | 165 +++ src/glx/drisw_priv.h

[Mesa-dev] [PATCHv2 1/9] dri: add putImageShm and getImageShm to swrastLoader

2015-06-15 Thread Marc-André Lureau
Add new APIa to put and get an image using shared memory. Instead of only passing the data pointer, 3 arguments are given: the shmid, the data offset and the shmaddr. Bump interface version. --- include/GL/internal/dri_interface.h | 18 +- 1 file changed, 17 insertions(+), 1

[Mesa-dev] [PATCHv2 7/9] drisw: learn to query shmid handle type

2015-06-15 Thread Marc-André Lureau
--- src/gallium/include/state_tracker/drisw_api.h | 1 + src/gallium/include/state_tracker/sw_winsys.h | 3 +-- src/gallium/include/state_tracker/winsys_handle.h | 1 + src/gallium/winsys/sw/dri/dri_sw_winsys.c | 10 +- 4 files changed, 12 insertions(+), 3 deletions(-)

[Mesa-dev] [PATCHv2 2/9] drisw: use putImageShm if available

2015-06-15 Thread Marc-André Lureau
If the DRIswrastLoaderExtension implements putImageShm, bind it to drisw_loader_funcs. --- src/gallium/include/state_tracker/drisw_api.h | 3 +++ src/gallium/state_trackers/dri/drisw.c| 37 +-- 2 files changed, 32 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCHv2 5/9] gallium: move winsys_handle to its own header

2015-06-15 Thread Marc-André Lureau
The structure is shared in drm driver and sw_winsys headers, moving it to a common place to have a common definition. --- src/gallium/include/state_tracker/drm_driver.h| 32 +- src/gallium/include/state_tracker/winsys_handle.h | 41 +++ 2 files changed, 42

Re: [Mesa-dev] [PATCHv2 1/9] dri: add putImageShm and getImageShm to swrastLoader

2015-06-15 Thread Boyan Ding
On 06/15/2015 09:34 PM, Marc-André Lureau wrote: Add new APIa to put and get an image using shared memory. Instead of only passing the data pointer, 3 arguments are given: the shmid, the data offset and the shmaddr. Bump interface version. --- include/GL/internal/dri_interface.h | 18

[Mesa-dev] [PATCHv2 8/9] drisw: use getImageShm() if available

2015-06-15 Thread Marc-André Lureau
--- src/gallium/state_trackers/dri/drisw.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/drisw.c b/src/gallium/state_trackers/dri/drisw.c index 75c8e85e..2ebb112 100644 --- a/src/gallium/state_trackers/dri/drisw.c +++

[Mesa-dev] [PATCHv2 0/9] drisw/glx: use XShm if possible

2015-06-15 Thread Marc-André Lureau
Hi, XPutImage/XGetImage requires to copy the images around, and the request may be split over several chunks. Using XShm should improve performance. In particular, the performances are bad when using gnome-shell with Spice and playing video. Chunking the update confuses the video detection

[Mesa-dev] [PATCHv2 9/9] drisw/glx: implement getImageShm

2015-06-15 Thread Marc-André Lureau
--- src/glx/drisw_glx.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/glx/drisw_glx.c b/src/glx/drisw_glx.c index f27e1f4..d80c396 100644 --- a/src/glx/drisw_glx.c +++ b/src/glx/drisw_glx.c @@ -305,6 +305,32 @@ swrastGetImage(__DRIdrawable * read,

[Mesa-dev] [PATCHv2 3/9] drisw: use shared memory when possible

2015-06-15 Thread Marc-André Lureau
If drisw_loader_funcs implements put_image_shm, allocates display target data with shared memory and display with put_image_shm(). --- src/gallium/winsys/sw/dri/dri_sw_winsys.c | 72 +-- 1 file changed, 60 insertions(+), 12 deletions(-) diff --git

Re: [Mesa-dev] [PATCH V3 14/22] i965/gen9: Set vertical and horizontal surface alignments

2015-06-15 Thread Pohjolainen, Topi
On Tue, Jun 09, 2015 at 02:30:02PM -0700, Anuj Phogat wrote: On Tue, Jun 2, 2015 at 2:51 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Patch sets the alignments for texture and renderbuffer surfaces. V3: Make changes inside horizontal_alignment() and vertical_alignment() (Topi)

Re: [Mesa-dev] [PATCH 4/6] mesa: generalize sso stage interleaving check

2015-06-15 Thread Brian Paul
On 06/14/2015 12:22 PM, Marek Olšák wrote: From: Chris Forbes chr...@ijw.co.nz For tessellation. v2: cleanup by Marek Olšák --- src/mesa/main/pipelineobj.c | 55 +++-- 1 file changed, 38 insertions(+), 17 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] configure.ac: rename LLVM_VERSION_PATCH to avoid conflict with llvm-config.h

2015-06-15 Thread Tom Stellard
On Sat, Jun 13, 2015 at 08:16:23PM +0200, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Reviewed-by: Tom Stellard thomas.stell...@amd.com --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 34d1ac9..e6d947e

[Mesa-dev] [PATCHv2 6/9] gallium: rename DRM_API_HANDLE_TYPE* WINSYS_HANDLE_TYPE*

2015-06-15 Thread Marc-André Lureau
The DRM prefix seems unnecessary as other kind of handle could be used. --- src/gallium/auxiliary/vl/vl_winsys_dri.c | 2 +- src/gallium/drivers/freedreno/freedreno_screen.c | 12 ++-- src/gallium/drivers/nouveau/nouveau_screen.c | 12 ++--

Re: [Mesa-dev] [PATCH v2 36/82] glsl: add support for unsized arrays in shader storage blocks

2015-06-15 Thread Samuel Iglesias Gonsálvez
On 15/06/15 13:25, Timothy Arceri wrote: On Wed, 2015-06-03 at 09:01 +0200, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com They only can be defined in the last position of the shader storage blocks. When an unsized array is used in different shaders, it

Re: [Mesa-dev] [PATCH] Revert glsl: remove restriction on unsized arrays in GLSL ES 3.10

2015-06-15 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez sigles...@igalia.com Sam On 15/06/15 13:06, Timothy Arceri wrote: This reverts commit adee54f8269c5e9f4fde91d19f0e465afc8f14d8. Further down in the GLSL ES 3.10 spec it say: If an array is declared as the last member of a shader storage block and

Re: [Mesa-dev] [PATCH] Revert glsl: remove restriction on unsized arrays in GLSL ES 3.10

2015-06-15 Thread Samuel Iglesias Gonsálvez
On 15/06/15 16:29, Samuel Iglesias Gonsálvez wrote: Reviewed-by: Samuel Iglesias Gonsálvez sigles...@igalia.com Sam On 15/06/15 13:06, Timothy Arceri wrote: This reverts commit adee54f8269c5e9f4fde91d19f0e465afc8f14d8. Further down in the GLSL ES 3.10 spec it say: If an array is

Re: [Mesa-dev] [PATCHv2 1/9] dri: add putImageShm and getImageShm to swrastLoader

2015-06-15 Thread Boyan Ding
On 06/15/2015 10:09 PM, Boyan Ding wrote: On 06/15/2015 09:34 PM, Marc-André Lureau wrote: Add new APIa to put and get an image using shared memory. Instead of only passing the data pointer, 3 arguments are given: the shmid, the data offset and the shmaddr. Bump interface version. ---

Re: [Mesa-dev] [PATCH 0.5/3] mesa: Handle integer formats in need_rgb_to_luminance_conversion()

2015-06-15 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga ito...@igalia.com On Thu, 2015-06-11 at 09:58 -0700, Anuj Phogat wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/main/readpix.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/readpix.c

Re: [Mesa-dev] [PATCH 1/3] mesa: Use helper function need_rgb_to_luminance_conversion()

2015-06-15 Thread Iago Toral
Oh, I missed that we had that helper function available for this... With the patch that adds the integer formats to the helper function this is: Reviewed-by: Iago Toral Quiroga ito...@igalia.com On Wed, 2015-06-10 at 16:54 -0700, Anuj Phogat wrote: Signed-off-by: Anuj Phogat

Re: [Mesa-dev] [PATCHv2 1/9] dri: add putImageShm and getImageShm to swrastLoader

2015-06-15 Thread Marc-André Lureau
Hi On Mon, Jun 15, 2015 at 4:51 PM, Boyan Ding boyan.j.d...@gmail.com wrote: Sorry I was in a rush when replying this. After reading the rest of the patches I saw you checked if the functions added are really implemented. But I do think we should change the version of swrastLoader in

[Mesa-dev] [PATCH] egl/x11: Set version of swrastLoader to 2

2015-06-15 Thread Boyan Ding
which it actually implements instead of the newest version defined in dri_interface.h Cc: 10.5 10.6 mesa-sta...@lists.freedesktop.org Signed-off-by: Boyan Ding boyan.j.d...@gmail.com --- src/egl/drivers/dri2/platform_x11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [Bug 89819] WebGL Conformance swrast failure in conformance/uniforms/uniform-default-values.html

2015-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89819 --- Comment #6 from Luke lukebe...@hotmail.com --- Roland, Did I miss the commit or is your fix still in the process of being reviewed? I'd be glad to help test out your patch. -- You are receiving this mail because: You are the QA Contact for

[Mesa-dev] [Bug 89819] WebGL Conformance swrast failure in conformance/uniforms/uniform-default-values.html

2015-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89819 --- Comment #7 from Roland Scheidegger srol...@vmware.com --- (In reply to Luke from comment #6) Roland, Did I miss the commit or is your fix still in the process of being reviewed? I'd be glad to help test out your patch. The crash fix was

Re: [Mesa-dev] [PATCH shader-db] si-report: Fix algorithm for determing difference in shader stats

2015-06-15 Thread Matt Turner
On Mon, Jun 15, 2015 at 11:39 AM, Tom Stellard thomas.stell...@amd.com wrote: --- si-report.py | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) Feel free to commit. I think anyone with mesa commit access can push to shader-db as well. Let me know if that's not the case.

[Mesa-dev] [PATCH shader-db] si-report: Fix algorithm for determing difference in shader stats

2015-06-15 Thread Tom Stellard
--- si-report.py | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/si-report.py b/si-report.py index fbeed11..ec88112 100755 --- a/si-report.py +++ b/si-report.py @@ -145,7 +145,13 @@ class si_stats: self.__dict__[name] += 1 def is_empty(self): -

Re: [Mesa-dev] [PATCH] i965: correct alignment units for 2D compressed textures on Skylake

2015-06-15 Thread Nanley Chery
Although most of the patch is incorrect, the following change is still necessary isn't it? if (mt-compressed) { mip1_width = ALIGN(minify(mt-physical_width0, 1), mt-align_w) + - ALIGN(minify(mt-physical_width0, 2), bw); + ALIGN(minify(mt-physical_width0,

Re: [Mesa-dev] [PATCH] i965: correct alignment units for 2D compressed textures on Skylake

2015-06-15 Thread Neil Roberts
Nanley Chery nanleych...@gmail.com writes: Although most of the patch is incorrect, the following change is still necessary isn't it? if (mt-compressed) { mip1_width = ALIGN(minify(mt-physical_width0, 1), mt-align_w) + - ALIGN(minify(mt-physical_width0, 2),

Re: [Mesa-dev] [PATCHv2 1/9] dri: add putImageShm and getImageShm to swrastLoader

2015-06-15 Thread Marek Olšák
Hi, FWIW, drivers shouldn't use the *_VERSION definitions from dri_interface.h. If they do, it's a bug. Marek On Mon, Jun 15, 2015 at 5:38 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: Hi On Mon, Jun 15, 2015 at 4:51 PM, Boyan Ding boyan.j.d...@gmail.com wrote: Sorry I was in a

Re: [Mesa-dev] [PATCHv2 6/9] gallium: rename DRM_API_HANDLE_TYPE* WINSYS_HANDLE_TYPE*

2015-06-15 Thread Marek Olšák
The idea of drm_driver.h and the DRM prefix is that it's meant to be Linux-specific, and winsys_handle should be considered an opaque structure by most state trackers. I think VMWare have their own definition of winsys_handle for Windows. The terms like KMS, SHARED (= FLINK), and FD (= DMABUF)

[Mesa-dev] Mesa 10.6.0

2015-06-15 Thread Emil Velikov
Mesa 10.6.0 is now available. It's the three month effort of approximately 100 individuals, resulting in well over 2000 commits. Big thanks to all the developers, testers, bug-reporters and everyone else for their hard work ! The following extensions are now supported by the said drivers: -

[Mesa-dev] Mesa 10.6.0

2015-06-15 Thread Emil Velikov
Mesa 10.6.0 is now available. It's the three month effort of approximately 100 individuals, resulting in well over 2000 commits. Big thanks to all the developers, testers, bug-reporters and everyone else for their hard work ! The following extensions are now supported by the said drivers: -