Re: [Mesa-dev] [RFC] DRI3 support for EGL

2015-07-02 Thread Michel Dänzer
On 02.07.2015 13:34, Boyan Ding wrote: Forgot to mention that I was running piglit on platform x11_egl. Actually, I found egl and glx on dri2 both passes this test, but glx/dri3 fails. That's why you saw the failure without my patch. I know, my point is that the failure probably isn't

Re: [Mesa-dev] [Intel-gfx] [PATCH mesa v2] i965/gen8+: bo in state base address must be in 32-bit address range

2015-07-02 Thread Chris Wilson
On Wed, Jul 01, 2015 at 04:28:10PM +0100, Michel Thierry wrote: Gen8+ supports 48-bit virtual addresses, but some objects must always be allocated inside the 32-bit address range. In specific, any resource used with flat/heapless (0x-0xf000) General State Heap or Intruction State

Re: [Mesa-dev] [PATCH 20/78] i965/nir/vec4: Implement load_uniform intrinsic

2015-07-02 Thread Iago Toral
On Tue, 2015-06-30 at 11:53 -0700, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga ito...@igalia.com For the indirect case we need to take the index delivered by NIR and compute the parent uniform that we are

[Mesa-dev] [PATCH] i965/vs: Fix matNxM vertex attributes where M != 4.

2015-07-02 Thread Kenneth Graunke
Matrix vertex attributes have their columns padded out to vec4s, which I was failing to account for. Scalar NIR expects them to be packed, however. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 15

[Mesa-dev] [PATCH 10.6] i965/vs: Fix matNxM vertex attributes where M != 4.

2015-07-02 Thread Kenneth Graunke
Matrix vertex attributes have their columns padded out to vec4s, which I was failing to account for. Scalar NIR expects them to be packed, however. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 15

Re: [Mesa-dev] [PATCH 13/78] i965/nir/vec4: Implement conditional statements (nir_cf_node_if)

2015-07-02 Thread Iago Toral
On Tue, 2015-06-30 at 09:30 -0700, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga ito...@igalia.com The same we do in the FS NIR backend, only that here we need to consider the number of components in the

Re: [Mesa-dev] [PATCH 19/78] nir/nir_lower_io: Add vec4 support

2015-07-02 Thread Iago Toral
On Tue, 2015-06-30 at 11:32 -0700, Jason Ekstrand wrote: I'm not sure what I think about adding an is_scalar flag vs. having _scalar and _vec4 versions of each function. My feeling is that once we tweak assign_var_locations as I mentioned for vec4 outputs, we'll find that we want to have them

Re: [Mesa-dev] [PATCH] i965: allocate at least 1 BLEND_STATE element

2015-07-02 Thread Kenneth Graunke
On Wednesday, July 01, 2015 10:16:28 AM Mike Stroyan wrote: When there are no color buffer render targets, gen6 and gen7 still use the first BLEND_STATE element to determine alpha test. gen6_upload_blend_state was allocating zero elements when ctx-Color.AlphaEnabled was false. That left

Re: [Mesa-dev] [PATCH] mesa: reset the source packing when creating temp transfer image

2015-07-02 Thread Iago Toral
On Wed, 2015-07-01 at 15:18 -0400, Ilia Mirkin wrote: Commit 4b249d2ee (mesa: Handle transferOps in texstore_rgba) introduced proper transferops handling, but in updating the source to the newly allocated temporary image neglected to reset the source packing. Set it to the default which should

Re: [Mesa-dev] [PATCH] mesa/prog: relative offsets into constbufs are not constant

2015-07-02 Thread Jose Fonseca
On 02/07/15 06:55, Matt Turner wrote: On Wed, Jul 1, 2015 at 3:22 PM, Ilia Mirkin imir...@alum.mit.edu wrote: The optimization logic relies on being able to read out constbuf values from program parameters. However that only works if there's no relative addressing involved. Bugzilla:

[Mesa-dev] [Bug 91187] F.E.A.R 2 (in Wine) runs out of memory and crashes

2015-07-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91187 Bug ID: 91187 Summary: F.E.A.R 2 (in Wine) runs out of memory and crashes Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2015-07-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Mike bugs.freedesktop@pm.port0.org changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 12/78] i965/nir/vec4: Add nir_get_dst() and nir_get_src() methods

2015-07-02 Thread Eduardo Lima Mitev
On 06/30/2015 06:26 PM, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com These methods are essential for the implementation of the NIR-vec4 pass. They work similar to their fs_nir

Re: [Mesa-dev] [PATCH 20/78] i965/nir/vec4: Implement load_uniform intrinsic

2015-07-02 Thread Iago Toral
On Thu, 2015-07-02 at 09:33 +0200, Iago Toral wrote: On Tue, 2015-06-30 at 11:53 -0700, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga ito...@igalia.com For the indirect case we need to take the index

Re: [Mesa-dev] [PATCH 11/78] i965/vec4: Add auxiliary func to build a writemask from a component size

2015-07-02 Thread Eduardo Lima Mitev
On 06/30/2015 01:52 AM, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: New method brw_writemask_for_size() will return a writemask with the first 'size' components activated. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89580 ---

Re: [Mesa-dev] [PATCH v2] darwin: Suppress type conversion warnings for GLhandleARB

2015-07-02 Thread Emil Velikov
On 1 July 2015 at 00:33, Julien Isorce julien.iso...@gmail.com wrote: darwin: silence GLhandleARB convertions from and to GLuint This patch and its description are inspired from Jose Fonseca explanations and suggestions. With this patch the following logic applies and only if __APPLE__:

Re: [Mesa-dev] [PATCH v3] glsl: fix some strict aliasing issues in exec_list

2015-07-02 Thread Neil Roberts
Davin McCall dav...@davmac.org writes: I actually had thought about this, but technically, you can only use unions for type aliasing if you perform all accesses (that are not to the 'active' member) through the union. All the list processing code that iterates through all the nodes including

Re: [Mesa-dev] [Intel-gfx] [PATCH mesa v2] i965/gen8+: bo in state base address must be in 32-bit address range

2015-07-02 Thread Chris Wilson
On Thu, Jul 02, 2015 at 02:53:45PM +0100, Michel Thierry wrote: I would have just exposed setting the flag on the execobject. That way you still have existing userspace safe by default, can set a bufmgr-level flag to enable 48bit support by default and then individually turn off 48bit support

[Mesa-dev] New stable-branch 10.5 candidate pushed

2015-07-02 Thread Emil Velikov
Hello list, The candidate for the Mesa 10.5.9 is now available. Currently we have: - 28 queued - 8 nominated (outstanding) - and 0 rejected (obsoleete) patches The present queue consist of many driver fixes - nouveau, i915, i965, r600/radeonsi, alongside GLSL ones (amongst which a Dota2 Reborn

Re: [Mesa-dev] [PATCH 4/5] egl: use unix defines on osx with clang

2015-07-02 Thread Emil Velikov
On 19 June 2015 at 12:43, Emil Velikov emil.l.veli...@gmail.com wrote: On 19 June 2015 at 00:23, Julien Isorce julien.iso...@gmail.com wrote: On 18 June 2015 at 19:33, Emil Velikov emil.l.veli...@gmail.com wrote: On 18 June 2015 at 19:29, Emil Velikov emil.l.veli...@gmail.com wrote: Sorry

Re: [Mesa-dev] [PATCH 2/5] applegl: Provide requirements of _SET_DrawBuffers

2015-07-02 Thread Emil Velikov
On 27 June 2015 at 12:21, Jon TURNEY jon.tur...@dronecode.org.uk wrote: On 19/06/2015 12:51, Emil Velikov wrote: On 19 June 2015 at 00:05, Julien Isorce julien.iso...@gmail.com wrote: Sorry for removing the XXX line. Original message is here:

Re: [Mesa-dev] [PATCH v2] darwin: Suppress type conversion warnings for GLhandleARB

2015-07-02 Thread Jose Fonseca
On 01/07/15 00:33, Julien Isorce wrote: darwin: silence GLhandleARB convertions from and to GLuint This patch and its description are inspired from Jose Fonseca explanations and suggestions. With this patch the following logic applies and only if __APPLE__: When building mesa, GLhandleARB is

Re: [Mesa-dev] [PATCH v2] darwin: Suppress type conversion warnings for GLhandleARB

2015-07-02 Thread Jose Fonseca
On 02/07/15 13:16, Emil Velikov wrote: On 1 July 2015 at 00:33, Julien Isorce julien.iso...@gmail.com wrote: darwin: silence GLhandleARB convertions from and to GLuint This patch and its description are inspired from Jose Fonseca explanations and suggestions. With this patch the following

Re: [Mesa-dev] [PATCH 2/5] applegl: Provide requirements of _SET_DrawBuffers

2015-07-02 Thread Jon TURNEY
On 02/07/2015 13:42, Emil Velikov wrote: On 27 June 2015 at 12:21, Jon TURNEY wrote: This smells to me like there's something not quite right about the partitioning of stuff between libmesa and libglapi, but I don't have any insight into what exactly the problem is. Quite likely. Although it

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

2015-07-02 Thread Ilia Mirkin
On Thu, Jul 2, 2015 at 1:55 AM, Jose Fonseca jfons...@vmware.com wrote: On 01/07/15 22:30, bugzilla-dae...@freedesktop.org wrote: *Comment # 14 https://bugs.freedesktop.org/show_bug.cgi?id=91173#c14 on bug 91173 https://bugs.freedesktop.org/show_bug.cgi?id=91173 from Ilia Mirkin

Re: [Mesa-dev] [PATCH] i965: allocate at least 1 BLEND_STATE element

2015-07-02 Thread Mike Stroyan
I had actually made the change to gen8_upload_blend_state, but after reading through the gen8 PRM a few times I decided to back it out. It does seem that the initial gen8 BLEND_STATE DWord can disable alpha test. Of course, new hardware features may not always behave as described. In that case

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

2015-07-02 Thread Jose Fonseca
On 02/07/15 19:45, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 2:31 PM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 17:49, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:40 PM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 17:24, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:17

[Mesa-dev] [PATCH] nouveau: don't mark full range as used on unmap with explicit flush

2015-07-02 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nouveau_buffer.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/nouveau/nouveau_buffer.c b/src/gallium/drivers/nouveau/nouveau_buffer.c index 09cdbb5..c1702ad

Re: [Mesa-dev] [Intel-gfx] [PATCH mesa v2] i965/gen8+: bo in state base address must be in 32-bit address range

2015-07-02 Thread Michel Thierry
On 7/2/2015 8:21 AM, Chris Wilson wrote: On Wed, Jul 01, 2015 at 04:28:10PM +0100, Michel Thierry wrote: Gen8+ supports 48-bit virtual addresses, but some objects must always be allocated inside the 32-bit address range. OUT_BATCH(0); OUT_BATCH(mocs_wb 16); /* Surface state

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

2015-07-02 Thread Jose Fonseca
On 02/07/15 16:34, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 1:55 AM, Jose Fonseca jfons...@vmware.com wrote: On 01/07/15 22:30, bugzilla-dae...@freedesktop.org wrote: *Comment # 14 https://bugs.freedesktop.org/show_bug.cgi?id=91173#c14 on bug 91173

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

2015-07-02 Thread Jose Fonseca
On 02/07/15 17:08, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 11:57 AM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 16:34, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 1:55 AM, Jose Fonseca jfons...@vmware.com wrote: On 01/07/15 22:30, bugzilla-dae...@freedesktop.org wrote: *Comment #

Re: [Mesa-dev] [PATCH 12/78] i965/nir/vec4: Add nir_get_dst() and nir_get_src() methods

2015-07-02 Thread Jason Ekstrand
On Thu, Jul 2, 2015 at 2:54 AM, Eduardo Lima Mitev el...@igalia.com wrote: On 06/30/2015 06:26 PM, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com These methods are essential for the

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

2015-07-02 Thread Jose Fonseca
On 02/07/15 17:39, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:24 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Jul 2, 2015 at 12:17 PM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 17:08, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 11:57 AM, Jose Fonseca jfons...@vmware.com

[Mesa-dev] [Bug 91173] Oddworld: Stranger's Wrath HD: disfigured models in wrong colors

2015-07-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91173 Ilia Mirkin imir...@alum.mit.edu changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 05/11] mesa: implement _mesa_GetTextureSubImage()

2015-07-02 Thread Brian Paul
The main issue is I need to do additional work for cube and/or cube array textures. This is still on my to-do list. Do you need this? -Brian On 7/1/15 11:01 PM, Ilia Mirkin wrote: Brian, what happened to this series? Was there some conflict with DSA and so you held off? On Sat, Dec 13,

Re: [Mesa-dev] [PATCH 05/11] mesa: implement _mesa_GetTextureSubImage()

2015-07-02 Thread Ilia Mirkin
Nope, just looking over the GL 4.5 extensions, was wondering what was happening with this one. On Thu, Jul 2, 2015 at 2:14 PM, Brian Paul bri...@vmware.com wrote: The main issue is I need to do additional work for cube and/or cube array textures. This is still on my to-do list. Do you need

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

2015-07-02 Thread Ilia Mirkin
On Thu, Jul 2, 2015 at 11:57 AM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 16:34, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 1:55 AM, Jose Fonseca jfons...@vmware.com wrote: On 01/07/15 22:30, bugzilla-dae...@freedesktop.org wrote: *Comment # 14

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

2015-07-02 Thread Ilia Mirkin
On Thu, Jul 2, 2015 at 12:24 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Jul 2, 2015 at 12:17 PM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 17:08, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 11:57 AM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 16:34, Ilia Mirkin

Re: [Mesa-dev] [PATCH 13/78] i965/nir/vec4: Implement conditional statements (nir_cf_node_if)

2015-07-02 Thread Jason Ekstrand
On Wed, Jul 1, 2015 at 11:44 PM, Iago Toral ito...@igalia.com wrote: On Tue, 2015-06-30 at 09:30 -0700, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga ito...@igalia.com The same we do in the FS NIR backend, only

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

2015-07-02 Thread Ilia Mirkin
On Thu, Jul 2, 2015 at 12:17 PM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 17:08, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 11:57 AM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 16:34, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 1:55 AM, Jose Fonseca jfons...@vmware.com

Re: [Mesa-dev] [PATCH] i965/chv|skl: Apply sampler bypass w/a

2015-07-02 Thread Nanley Chery
Nice find. What do you think about putting this in a function to reduce the code duplication? - Nanley On Wed, Jul 1, 2015 at 6:14 PM, Ben Widawsky b...@bwidawsk.net wrote: On Wed, Jul 01, 2015 at 04:03:53PM -0700, Ben Widawsky wrote: Certain compressed formats require this setting. The docs

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

2015-07-02 Thread Jose Fonseca
On 02/07/15 17:24, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:17 PM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 17:08, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 11:57 AM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 16:34, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 1:55

[Mesa-dev] [PATCH] glapi: fix argument parsing in glX_proto_recv.py

2015-07-02 Thread Dylan Baker
One of the plugins I use with vim helpfully added an underscore to the front of mode for kicks. Obviously this isn't a feature used very often because it's been broken since d986cb7c70db (since May 20th), and no one has noticed. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com ---

Re: [Mesa-dev] [PATCH 20/78] i965/nir/vec4: Implement load_uniform intrinsic

2015-07-02 Thread Jason Ekstrand
On Thu, Jul 2, 2015 at 3:53 AM, Iago Toral ito...@igalia.com wrote: On Thu, 2015-07-02 at 09:33 +0200, Iago Toral wrote: On Tue, 2015-06-30 at 11:53 -0700, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga

Re: [Mesa-dev] [PATCH v3] glsl: fix some strict aliasing issues in exec_list

2015-07-02 Thread Davin McCall
On 02/07/15 14:58, Neil Roberts wrote: Davin McCalldav...@davmac.org writes: I actually had thought about this, but technically, you can only use unions for type aliasing if you perform all accesses (that are not to the 'active' member) through the union. All the list processing code that

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

2015-07-02 Thread Ilia Mirkin
On Thu, Jul 2, 2015 at 12:40 PM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 17:24, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:17 PM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 17:08, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 11:57 AM, Jose Fonseca jfons...@vmware.com

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

2015-07-02 Thread Jose Fonseca
On 02/07/15 17:49, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:40 PM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 17:24, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:17 PM, Jose Fonseca jfons...@vmware.com wrote: Ah OK. So I guess tilers will have to disable their render queues

[Mesa-dev] [PATCH] i965/fs: Don't disable SIMD16 when using the pixel interpolator

2015-07-02 Thread Neil Roberts
There was a comment saying that in SIMD16 mode the pixel interpolator returns coords interleaved 8 channels at a time and that this requires extra work to support. However, this interleaved format is exactly what the PLN instruction requires so I don't think anything needs to be done to support it

Re: [Mesa-dev] [PATCH 05/11] mesa: implement _mesa_GetTextureSubImage()

2015-07-02 Thread Brian Paul
On 7/2/15 1:00 PM, Eric Anholt wrote: Brian Paul bri...@vmware.com writes: The main issue is I need to do additional work for cube and/or cube array textures. This is still on my to-do list. Do you need this? FWIW, I just wanted this extension in X yesterday. I'm on vacation this week.

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

2015-07-02 Thread Ilia Mirkin
On Thu, Jul 2, 2015 at 2:31 PM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 17:49, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:40 PM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 17:24, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:17 PM, Jose Fonseca jfons...@vmware.com

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

2015-07-02 Thread Eric Anholt
Ilia Mirkin imir...@alum.mit.edu writes: On Thu, Jul 2, 2015 at 2:31 PM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 17:49, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:40 PM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 17:24, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

2015-07-02 Thread Ilia Mirkin
On Thu, Jul 2, 2015 at 2:59 PM, Eric Anholt e...@anholt.net wrote: Ilia Mirkin imir...@alum.mit.edu writes: On Thu, Jul 2, 2015 at 2:31 PM, Jose Fonseca jfons...@vmware.com wrote: On 02/07/15 17:49, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:40 PM, Jose Fonseca jfons...@vmware.com wrote:

Re: [Mesa-dev] [PATCH 05/11] mesa: implement _mesa_GetTextureSubImage()

2015-07-02 Thread Eric Anholt
Brian Paul bri...@vmware.com writes: The main issue is I need to do additional work for cube and/or cube array textures. This is still on my to-do list. Do you need this? FWIW, I just wanted this extension in X yesterday. signature.asc Description: PGP signature

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/vs: Fix matNxM vertex attributes where M != 4.

2015-07-02 Thread Mark Janes
This fixes 1256 tests on BDW. Tested-by: Mark Janes mark.a.ja...@intel.com Kenneth Graunke kenn...@whitecape.org writes: Matrix vertex attributes have their columns padded out to vec4s, which I was failing to account for. Scalar NIR expects them to be packed, however. Cc:

Re: [Mesa-dev] [PATCH] i965/chv|skl: Apply sampler bypass w/a

2015-07-02 Thread Matt Turner
On Wed, Jul 1, 2015 at 4:03 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: Certain compressed formats require this setting. The docs don't go into much detail as to why it's needed exactly. This fixes 0 piglit failures with a GBM gpu piglit run. That's a really weird way of saying that.

Re: [Mesa-dev] [PATCH] i965/chv|skl: Apply sampler bypass w/a

2015-07-02 Thread Matt Turner
On Thu, Jul 2, 2015 at 12:57 PM, Matt Turner matts...@gmail.com wrote: On Wed, Jul 1, 2015 at 4:03 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: Certain compressed formats require this setting. The docs don't go into much detail as to why it's needed exactly. This fixes 0 piglit

[Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

2015-07-02 Thread Erik Faye-Lund
After c61bc6e (util: port _mesa_strto[df] to C), make check fails due to a missing _mesa_locale_init. Fixup this oversight. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com Tested-by: Vinson Lee v...@freedesktop.org --- src/glsl/test.cpp | 4 1 file changed, 4 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

2015-07-02 Thread Ilia Mirkin
Can this be done at dlopen/init time? For example what happens if you do static int foo = _mesa_locale_init() IIRC things like that are possible in C++, not sure about C. On Thu, Jul 2, 2015 at 5:18 PM, Erik Faye-Lund kusmab...@gmail.com wrote: After c61bc6e (util: port _mesa_strto[df] to C),

Re: [Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

2015-07-02 Thread Matt Turner
On Thu, Jul 2, 2015 at 2:18 PM, Erik Faye-Lund kusmab...@gmail.com wrote: After c61bc6e (util: port _mesa_strto[df] to C), make check fails due to a missing _mesa_locale_init. Fixup this oversight. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com Tested-by: Vinson Lee v...@freedesktop.org

Re: [Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

2015-07-02 Thread Ilia Mirkin
On Thu, Jul 2, 2015 at 5:54 PM, Matt Turner matts...@gmail.com wrote: On Thu, Jul 2, 2015 at 2:22 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Can this be done at dlopen/init time? For example what happens if you do static int foo = _mesa_locale_init() IIRC things like that are possible in

Re: [Mesa-dev] [PATCH] i965/fs: Don't disable SIMD16 when using the pixel interpolator

2015-07-02 Thread Chris Forbes
Looks OK to me. I didn't think there was going to be much required to make this work -- is nice that it turned out to be nothing. Reviewed-by: Chris Forbes chr...@ijw.co.nz - Chris On Fri, Jul 3, 2015 at 6:41 AM, Neil Roberts n...@linux.intel.com wrote: There was a comment saying that in

Re: [Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

2015-07-02 Thread Matt Turner
On Thu, Jul 2, 2015 at 2:22 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Can this be done at dlopen/init time? For example what happens if you do static int foo = _mesa_locale_init() IIRC things like that are possible in C++, not sure about C. gcc has __attribute__((constructor)). But I

[Mesa-dev] [PATCH v2] egl: use unix defines on osx with clang

2015-07-02 Thread Julien Isorce
From: Julien Isorce j.iso...@samsung.com I also created an bug in Khronos 's bugzilla as you suggested: https://www.khronos.org/bugzilla/show_bug.cgi?id=1356 I'll let you know if I get feedback from this bug or else where. Patch with updated error messages: [PATCH] eglplatform: treat __APPLE__

Re: [Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

2015-07-02 Thread Erik Faye-Lund
On Thu, Jul 2, 2015 at 2:56 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Jul 2, 2015 at 5:54 PM, Matt Turner matts...@gmail.com wrote: On Thu, Jul 2, 2015 at 2:22 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Can this be done at dlopen/init time? For example what happens if you do static

Re: [Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

2015-07-02 Thread Ilia Mirkin
On Thu, Jul 2, 2015 at 6:23 PM, Erik Faye-Lund kusmab...@gmail.com wrote: On Thu, Jul 2, 2015 at 2:56 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Jul 2, 2015 at 5:54 PM, Matt Turner matts...@gmail.com wrote: On Thu, Jul 2, 2015 at 2:22 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Can