Re: [Mesa-dev] [PATCH v2 2/3] mesa: validate size parameters for glTexStorage*Multisample

2015-08-17 Thread Ian Romanick
On 08/13/2015 02:28 AM, Tapani Pälli wrote: On 08/13/2015 12:14 PM, Tapani Pälli wrote: On 08/13/2015 11:54 AM, Timothy Arceri wrote: I've sent a couple of follow-up patches I notice when reviewing this. On Thu, 2015-08-13 at 09:30 +0300, Tapani Pälli wrote: v2: code cleanup

[Mesa-dev] [PATCH] mesa: undo split out of create shader code

2015-08-17 Thread Timothy Arceri
This code was split out into a separate function to be used also by GL_EXT_separate_shader_objects which has since been removed from Mesa, so move it back. --- src/mesa/main/shaderapi.c | 109 +- 1 file changed, 50 insertions(+), 59 deletions(-) diff

Re: [Mesa-dev] [PATCH] [RFC] mesa/st: create a front buffer renderbuffer

2015-08-17 Thread Marek Olšák
I don't see why FRONT and BACK should be any different, so this is probably okay. The Mesa front buffer thing is an optimization. There is no point in allocating the front buffer by default if almost no apps use it. Marek On Mon, Aug 17, 2015 at 11:34 PM, Dave Airlie airl...@gmail.com wrote:

Re: [Mesa-dev] [PATCH 08/25] glsl: Forbid non-constant image array indexing in GLSL ES 3.1.

2015-08-17 Thread Timothy Arceri
Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC 2/3] mesa: hook up DiscardTexture for InvalidateFramebuffer and friends

2015-08-17 Thread Rob Clark
On Mon, Aug 17, 2015 at 3:38 PM, Eric Anholt e...@anholt.net wrote: Rob Clark robdcl...@gmail.com writes: From: Rob Clark robcl...@freedesktop.org We can use same Driver hook for these, in addition to DiscardFramebufferEXT() Signed-off-by: Rob Clark robcl...@freedesktop.org ---

Re: [Mesa-dev] [PATCH] mesa: undo split out of create shader code

2015-08-17 Thread Ian Romanick
Easy enough. I probably should have done this when I removed EXT_sso. Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 08/17/2015 02:42 PM, Timothy Arceri wrote: This code was split out into a separate function to be used also by GL_EXT_separate_shader_objects which has since been

Re: [Mesa-dev] [PATCH 03/25] mesa: Reject image formats not supported by GLES.

2015-08-17 Thread Tapani Pälli
Reviewed-by: Tapani Pälli tapani.pa...@intel.com On 08/17/2015 07:45 PM, Francisco Jerez wrote: --- src/mesa/main/shaderimage.c | 67 +++-- 1 file changed, 65 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderimage.c

Re: [Mesa-dev] [PATCH 1/5] nir: split out instruction comparison functions

2015-08-17 Thread Jason Ekstrand
On May 22, 2015 11:25 AM, Connor Abbott cwabbo...@gmail.com wrote: We'll want to use these outside of nir_opt_cse.c. Rather than adding yet another thing to the mess that is nir.c, create a new file and move nir_srcs_equal() there too. Signed-off-by: Connor Abbott cwabbo...@gmail.com ---

Re: [Mesa-dev] [PATCH 07/25] mesa: Refuse to bind image uniforms using glUniform in GLES.

2015-08-17 Thread Tapani Pälli
I find it strange that 7.10 Images does not mention this difference to desktop GL (when mentioning that locations can be queried with GetUniformLocation), one can only learn this by checking that all references to 'image' have been removed from the Uniform* calls. Reviewed-by: Tapani Pälli

[Mesa-dev] [PATCH 1/2] mesa: check samples 0 for glTex*Multisample

2015-08-17 Thread Timothy Arceri
The GL 4.5 spec says its an GL_INVALID_VALUE error if samples equals 0 for glTexImage*Multisample and an GL_INVALID_VALUE error if samples 1 for glTexStorage*Multisample. The spec says its undefined what happens if glTexImage*Multisample is passed a samples value 0 but we currently already

[Mesa-dev] [PATCH 2/2] mesa: move non-generic samples validation

2015-08-17 Thread Timothy Arceri
The previous patch replaces the other use case. V2: remove the validation from it old location. Cc: Tapani Pälli tapani.pa...@intel.com --- src/mesa/main/fbobject.c| 10 ++ src/mesa/main/multisample.c | 9 - 2 files changed, 10 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH] glsl: enable textureSize and texelFetch on GLSL ES 3.10 with MS samplers

2015-08-17 Thread Tapani Pälli
Patch separates array samplers from the texture_multisample check so that we can enable only [iu]sampler2DMS, [iu]sampler2DMSArray are not supported. Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/glsl/builtin_functions.cpp | 19 +-- 1 file changed, 13 insertions(+),

[Mesa-dev] [PATCH v2 2/2] mesa: Use the effective internal format instead for validation

2015-08-17 Thread Eduardo Lima Mitev
When validating format+type+internalFormat for texture pixel operations on GLES3, the effective internal format should be used if the one specified is an unsized internal format. Page 127, section 3.8 Texturing of the GLES 3.0.4 spec says: if internalformat is a base internal format, the

[Mesa-dev] [PATCH v2 1/2] mesa: Move _mesa_base_tex_format() from teximage to glformats files

2015-08-17 Thread Eduardo Lima Mitev
This function will be needed as part of validating the combination of format, type and internal format of texture pixel operations, which happens in glformats files. Specifically, we want to be able to obtain the base format of a resolved effective internal format, to compare it with the original

[Mesa-dev] [PATCH v2 0/2] mesa: Use the effective internal format instead for validation

2015-08-17 Thread Eduardo Lima Mitev
Hi, This is a new version of the patch that accounts for extensions that allow new combinations of format, type and internal format; where the internal format is in base (unsized) form. I also moved the check to glformats's _mesa_es3_error_check_format_and_type(), because this is really part of

Re: [Mesa-dev] [PATCH v2 2/2] mesa: Use the effective internal format instead for validation

2015-08-17 Thread Eduardo Lima Mitev
On 08/17/2015 12:35 PM, Eduardo Lima Mitev wrote: + if (error_check_subtexture_dimensions(ctx, dimensions, + texImage, xoffset, yoffset, zoffset, + width, height, depth, callerName)) { + return GL_TRUE;

Re: [Mesa-dev] [PATCH] glsl: enable textureSize and texelFetch on GLSL ES 3.10 with MS samplers

2015-08-17 Thread Timothy Arceri
On Mon, 2015-08-17 at 12:25 +0300, Tapani Pälli wrote: Patch separates array samplers from the texture_multisample check so that we can enable only [iu]sampler2DMS, [iu]sampler2DMSArray are not supported. Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/glsl/builtin_functions.cpp

Re: [Mesa-dev] [PATCH] glsl: enable textureSize and texelFetch on GLSL ES 3.10 with MS samplers

2015-08-17 Thread Tapani Pälli
On 08/17/2015 01:58 PM, Timothy Arceri wrote: On Mon, 2015-08-17 at 12:25 +0300, Tapani Pälli wrote: Patch separates array samplers from the texture_multisample check so that we can enable only [iu]sampler2DMS, [iu]sampler2DMSArray are not supported. Signed-off-by: Tapani Pälli

Re: [Mesa-dev] [PATCH] [RFC] mesa/st: create a front buffer renderbuffer

2015-08-17 Thread Marek Olšák
Gallium does create the front buffer (with DRI2 at least), but it's created only when it's used. glDrawBuffer(GL_FRONT) creates it usually. Marek On Mon, Aug 17, 2015 at 5:23 AM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com It appears CTS does a lot of

Re: [Mesa-dev] [PATCH] glsl: enable textureSize and texelFetch on GLSL ES 3.10 with MS samplers

2015-08-17 Thread Timothy Arceri
On Mon, 2015-08-17 at 14:23 +0300, Tapani Pälli wrote: On 08/17/2015 01:58 PM, Timothy Arceri wrote: On Mon, 2015-08-17 at 12:25 +0300, Tapani Pälli wrote: Patch separates array samplers from the texture_multisample check so that we can enable only [iu]sampler2DMS,

Re: [Mesa-dev] [PATCH 09/12] i965/fs: make SIMD-splitting respect the original stride/offset

2015-08-17 Thread Francisco Jerez
Connor Abbott cwabbo...@gmail.com writes: On Mon, Aug 17, 2015 at 12:09 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Fri, Aug 14, 2015 at 03:30:18PM -0700, Connor Abbott wrote: In some cases, we need to emit ALU instructions with a certain stride due to a HW limitation. When

[Mesa-dev] [Bug 90346] DispatchSanity_test.GLES2 regression

2015-08-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90346 --- Comment #3 from Tapani Pälli lem...@gmail.com --- Seems like this is fixed now? I could not reproduce using current Mesa (1af0641) and configuring like done in comment #2. -- You are receiving this mail because: You are the QA Contact for

Re: [Mesa-dev] [PATCH] glsl: enable textureSize and texelFetch on GLSL ES 3.10 with MS samplers

2015-08-17 Thread Timothy Arceri
Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC 2/3] mesa: hook up DiscardTexture for InvalidateFramebuffer and friends

2015-08-17 Thread Eric Anholt
Rob Clark robdcl...@gmail.com writes: On Mon, Aug 17, 2015 at 3:38 PM, Eric Anholt e...@anholt.net wrote: Rob Clark robdcl...@gmail.com writes: From: Rob Clark robcl...@freedesktop.org We can use same Driver hook for these, in addition to DiscardFramebufferEXT() Signed-off-by: Rob Clark

[Mesa-dev] [PATCH 3/8] i965: Move type_size() methods out of visitor classes.

2015-08-17 Thread Kenneth Graunke
I want to use C function pointers to these, and they don't use anything in the visitor classes anyway. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_fs.cpp | 10 +- src/mesa/drivers/dri/i965/brw_fs.h | 1 -

[Mesa-dev] [PATCH 4/8] nir: Pass a type_size() function pointer into nir_lower_io().

2015-08-17 Thread Kenneth Graunke
Previously, there were four type_size() functions in play - the i965 compiler backend defined scalar and vec4 type_size() functions, and nir_lower_io contained its own similar functions. In fact, the i965 driver used nir_lower_io() and then looped over the components using its own type_size -

[Mesa-dev] [PATCH 1/8] nir: Pull nir_lower_io's load_op selection into a helper function.

2015-08-17 Thread Kenneth Graunke
Makes the function a bit smaller. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/glsl/nir/nir_lower_io.c | 39 ++- 1 file changed, 22 insertions(+), 17 deletions(-) diff --git a/src/glsl/nir/nir_lower_io.c b/src/glsl/nir/nir_lower_io.c index

[Mesa-dev] [PATCH 5/8] i965/nir: Move IO lowering into helper functions.

2015-08-17 Thread Kenneth Graunke
I plan to expand these, so moving them into helper functions will keep things cleaner. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_nir.c | 51 ++--- 1 file changed, 31 insertions(+), 20 deletions(-) diff --git

[Mesa-dev] [PATCH 7/8] i965/vs: Map scalar VS input locations properly; avoid tons of MOVs.

2015-08-17 Thread Kenneth Graunke
Previously, we used nir_lower_io with the scalar type_size function, which mapped VERT_ATTRIB_* locations to...some numbers. Then, in fs_visitor::nir_setup_inputs(), we created temporaries indexed by those numbers, and emitted MOVs from the actual ATTR registers to those temporaries. This patch

[Mesa-dev] [PATCH 6/8] nir: Allow nir_lower_io() to only lower one type of variable.

2015-08-17 Thread Kenneth Graunke
We may want to use different type_size functions for (e.g.) inputs vs. uniforms. Passing in -1 for mode ignores this, handling all modes as before. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/glsl/nir/nir.h | 1 + src/glsl/nir/nir_lower_io.c | 21

[Mesa-dev] [PATCH 2/8] nir: Use nir_builder in nir_lower_io's get_io_offset().

2015-08-17 Thread Kenneth Graunke
Much more readable. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/glsl/nir/nir_lower_io.c | 42 ++ 1 file changed, 14 insertions(+), 28 deletions(-) diff --git a/src/glsl/nir/nir_lower_io.c b/src/glsl/nir/nir_lower_io.c index

[Mesa-dev] [PATCH 8/8] i965/vs: Simplify fs_visitor's ATTR file.

2015-08-17 Thread Kenneth Graunke
Previously, ATTR was indexed by VERT_ATTRIB_* slots; at the end of compilation, assign_vs_urb_setup() translated those into GRF units, and converted ATTR to HW_REGs. This patch moves the transslation earlier, making ATTR work in terms of GRF units from the beginning. assign_vs_urb_setup() simply

[Mesa-dev] [PATCH] radeon/uvd: remove unused variables

2015-08-17 Thread Grazvydas Ignotas
Recent commits introduced new unused variable warnings, fix them. --- src/gallium/drivers/radeon/radeon_uvd.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_uvd.c b/src/gallium/drivers/radeon/radeon_uvd.c index 16ee541..81f3f45 100644

Re: [Mesa-dev] [Nouveau] [PATCH] glsl: Extend lowering pass for gl_ClipDistance to support other arrays

2015-08-17 Thread Ilia Mirkin
I said this on IRC, but I'll say it here too: (a) please regenerate this with -M (not in the general case, but it makes sense here) (b) this seems odd as there's no support for cull distance elsewhere yet. should be part of a series that adds cull distance support. right now there is none, so

[Mesa-dev] [Bug 91672] [llvmpipe] [softpipe] piglit gl-3.2-layered-rendering-framebuffertexture regression

2015-08-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91672 Bug ID: 91672 Summary: [llvmpipe] [softpipe] piglit gl-3.2-layered-rendering-framebuffertexture regression Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [PATCH 7/8] i965: Fix {src, dst}_pitch alignment check for XY_SRC_COPY_BLT

2015-08-17 Thread Anuj Phogat
On Mon, Aug 17, 2015 at 12:24 PM, Ben Widawsky b...@bwidawsk.net wrote: On Fri, Aug 14, 2015 at 04:51:58PM -0700, Anuj Phogat wrote: Current code checks the alignment restrictions only for Y tiling. From Broadwell PRM vol 10: pitch is of 512Byte granularity for Tile-X: This means the tiled-x

Re: [Mesa-dev] [PATCH 1/4] mesa/formats: only do type and component lookup for uncompressed formats

2015-08-17 Thread Nanley Chery
On Fri, Aug 14, 2015 at 4:00 PM, Chad Versace chad.vers...@intel.com wrote: On Tue 11 Aug 2015, Nanley Chery wrote: From: Nanley Chery nanley.g.ch...@intel.com Only uncompressed formats have a non-void type and actual components per pixel. Rename _mesa_format_to_type_and_comps to

Re: [Mesa-dev] [PATCH 4/8] nir: Pass a type_size() function pointer into nir_lower_io().

2015-08-17 Thread Jason Ekstrand
The first four are Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com I'll get to the others later. On Mon, Aug 17, 2015 at 4:07 PM, Kenneth Graunke kenn...@whitecape.org wrote: Previously, there were four type_size() functions in play - the i965 compiler backend defined scalar and vec4

Re: [Mesa-dev] [PATCH] radeonsi: mark unreachable paths to avoid warnings

2015-08-17 Thread Michel Dänzer
On 18.08.2015 09:23, Grazvydas Ignotas wrote: Otherwise we get: warning: 'num_user_sgprs' may be used uninitialized in this function ... Reviewed-by: Michel Dänzer michel.daen...@amd.com -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast

[Mesa-dev] [PATCH] glsl: Extend lowering pass for gl_ClipDistance to support other arrays

2015-08-17 Thread Tobias Klausmann
This will come in handy when we want to lower gl_CullDistance into gl_CullDistanceMESA. Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/glsl/Makefile.sources| 2 +- src/glsl/ir_optimization.h | 1 + src/glsl/lower_clip_distance.cpp | 574

[Mesa-dev] [PATCH v3 2/2] mesa: return old name for deleted samplers for SAMPLER_BINDING queries

2015-08-17 Thread Daniel Scharrer
If the sampler object has been deleted in the same context the binding will have been cleared. If it has been deleted in another context, the spec does not say what should returned. None of the other binding point queries check for deletion in another context. Also, as names of deleted objects

[Mesa-dev] [PATCH v3 1/2] mesa: add missing queries for ARB_direct_state_access

2015-08-17 Thread Daniel Scharrer
This adds index queries (glGet*i_v) for GL_TEXTURE_BINDING_* and GL_SAMPLER_BINDING, as well as textue queries (glGetTex{,ture}Parameter*) for GL_TEXTURE_TARGET. CC: 10.6 mesa-sta...@lists.freedesktop.org --- v3: fixed uper limit for texture units don't use extension suffixes for core tokens

Re: [Mesa-dev] [PATCH 4/8] i965: Use helper function intel_miptree_get_tile_dimensions() in surface setup

2015-08-17 Thread Anuj Phogat
On Mon, Aug 17, 2015 at 12:19 PM, Ben Widawsky b...@bwidawsk.net wrote: On Fri, Aug 14, 2015 at 04:51:55PM -0700, Anuj Phogat wrote: It takes care of using the correct tile width if we later use other tiling patterns (e.g. Yf) for aux miptree. Cc: Ben Widawsky b...@bwidawsk.net

Re: [Mesa-dev] [PATCH 1/4] mesa/formats: only do type and component lookup for uncompressed formats

2015-08-17 Thread Nanley Chery
Cc'ing Brian. I'm planning to make a patch to implement the first (3-step) solution. On Mon, Aug 17, 2015 at 3:45 PM, Nanley Chery nanleych...@gmail.com wrote: On Fri, Aug 14, 2015 at 4:00 PM, Chad Versace chad.vers...@intel.com wrote: On Tue 11 Aug 2015, Nanley Chery wrote: From: Nanley

Re: [Mesa-dev] [PATCH 3/8] i965: Add a helper function intel_miptree_get_tile_dimensions()

2015-08-17 Thread Anuj Phogat
On Mon, Aug 17, 2015 at 12:06 PM, Ben Widawsky b...@bwidawsk.net wrote: On Fri, Aug 14, 2015 at 04:51:54PM -0700, Anuj Phogat wrote: Cc: Ben Widawsky b...@bwidawsk.net Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 67

[Mesa-dev] texstore byteswap allocation bug

2015-08-17 Thread Dave Airlie
Hey, while running CTS under valgrind I got to see a lot of ==32256== Invalid read of size 2 ==32256==at 0x5B53F07: convert_ushort (format_utils.c:1155) ==32256==by 0x5B8523A: _mesa_swizzle_and_convert (format_utils.c:1453) ==32256==by 0x5B11151: _mesa_format_convert

Re: [Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

2015-08-17 Thread Eric Anholt
Chris Wilson ch...@chris-wilson.co.uk writes: X rendering calls made prior to glXWaitX are guaranteed to be executed before GL rendering calls made after glXWaitX. The goal is to implement that without adding a round-trip to the Xserver. Adding one using XSync() is easy, but we can

[Mesa-dev] [PATCH] radeonsi: mark unreachable paths to avoid warnings

2015-08-17 Thread Grazvydas Ignotas
Otherwise we get: warning: 'num_user_sgprs' may be used uninitialized in this function ... --- src/gallium/drivers/radeonsi/si_shader.c| 2 +- src/gallium/drivers/radeonsi/si_state_shaders.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 41/71] st/nine: Rework rasterizer states

2015-08-17 Thread Axel Davy
On Sun, 16 Aug 2015, Axel Davy wrote: void -nine_convert_rasterizer_state(struct cso_context *ctx, const DWORD *rs) +nine_convert_rasterizer_state(struct pipe_rasterizer_state *rast_state, const DWORD *rs) { struct pipe_rasterizer_state rast; -memset(rast, 0, sizeof(rast)); /* memcmp

Re: [Mesa-dev] [RFC 2/2] i965: add support for image AoA

2015-08-17 Thread Francisco Jerez
Timothy Arceri t_arc...@yahoo.com.au writes: On Sun, 2015-08-16 at 13:15 +0300, Francisco Jerez wrote: Timothy Arceri t_arc...@yahoo.com.au writes: On Sat, 2015-08-15 at 17:33 +0300, Francisco Jerez wrote: Timothy Arceri t_arc...@yahoo.com.au writes: On Wed, 2015-08-12 at 19:39

Re: [Mesa-dev] [RFC 2/2] i965: add support for image AoA

2015-08-17 Thread Timothy Arceri
On Sun, 2015-08-16 at 13:15 +0300, Francisco Jerez wrote: Timothy Arceri t_arc...@yahoo.com.au writes: On Sat, 2015-08-15 at 17:33 +0300, Francisco Jerez wrote: Timothy Arceri t_arc...@yahoo.com.au writes: On Wed, 2015-08-12 at 19:39 +1000, Timothy Arceri wrote: Cc: Francisco

Re: [Mesa-dev] [PATCH 7/8] i965/vs: Map scalar VS input locations properly; avoid tons of MOVs.

2015-08-17 Thread Jason Ekstrand
On Aug 17, 2015 4:08 PM, Kenneth Graunke kenn...@whitecape.org wrote: Previously, we used nir_lower_io with the scalar type_size function, which mapped VERT_ATTRIB_* locations to...some numbers. Then, in fs_visitor::nir_setup_inputs(), we created temporaries indexed by those numbers, and

[Mesa-dev] [Bug 91672] [llvmpipe] [softpipe] piglit gl-3.2-layered-rendering-framebuffertexture regression

2015-08-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91672 Timothy Arceri t_arc...@yahoo.com.au changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH] ABI-check: Use more portable bash invocation.

2015-08-17 Thread Vinson Lee
Fixes 'make check' on FreeBSD. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/mapi/es1api/ABI-check | 2 +- src/mapi/es2api/ABI-check | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mapi/es1api/ABI-check b/src/mapi/es1api/ABI-check index 44654cd..819568f 100755

Re: [Mesa-dev] [PATCH 03/25] mesa: Reject image formats not supported by GLES.

2015-08-17 Thread Timothy Arceri
Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 04/25] mesa: Reset image unit state to the default values when a bound image is deleted.

2015-08-17 Thread Tapani Pälli
On 08/17/2015 07:45 PM, Francisco Jerez wrote: The ES31-CTS.shader_image_load_store.basic-api-bind conformance test expects the whole image unit state to be reset when the bound texture object is deleted. The ARB_shader_image_load_store extension is rather vague regarding what should happen

Re: [Mesa-dev] [PATCH 8/8] i965/vs: Simplify fs_visitor's ATTR file.

2015-08-17 Thread Jason Ekstrand
On Aug 17, 2015 4:08 PM, Kenneth Graunke kenn...@whitecape.org wrote: Previously, ATTR was indexed by VERT_ATTRIB_* slots; at the end of compilation, assign_vs_urb_setup() translated those into GRF units, and converted ATTR to HW_REGs. This patch moves the transslation earlier, making ATTR

Re: [Mesa-dev] [PATCH 01/25] mesa: Rename MaxCombinedImageUnitsAndFragmentOutputs to MaxCombinedShaderOutputResources.

2015-08-17 Thread Timothy Arceri
Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 7/8] i965/vs: Map scalar VS input locations properly; avoid tons of MOVs.

2015-08-17 Thread Jason Ekstrand
On Aug 17, 2015 4:08 PM, Kenneth Graunke kenn...@whitecape.org wrote: Previously, we used nir_lower_io with the scalar type_size function, which mapped VERT_ATTRIB_* locations to...some numbers. Then, in fs_visitor::nir_setup_inputs(), we created temporaries indexed by those numbers, and

Re: [Mesa-dev] [PATCH 23/25] glsl: Implement the required built-in functions when OES_shader_image_atomic is enabled.

2015-08-17 Thread Ilia Mirkin
On Mon, Aug 17, 2015 at 1:14 PM, Matt Turner matts...@gmail.com wrote: On Mon, Aug 17, 2015 at 9:46 AM, Francisco Jerez curroje...@riseup.net wrote: This is basically just the same atomic functions exposed by ARB_shader_image_load_store, with one exception: highp float

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glsl: avoid compiler's segfault when processing operators with void arguments

2015-08-17 Thread Ian Romanick
On 08/10/2015 11:32 AM, Mark Janes wrote: Should this patch be cc'd to stable branches? Without it, the compiler crashes on invalid inputs, instead of generating an error. This patch applies cleanly to 10.5 and 10.6. I don't care too much either. I submitted the original bug report

Re: [Mesa-dev] [PATCH 0/3] GREMEDY_string_marker support

2015-08-17 Thread Rob Clark
On Mon, Aug 17, 2015 at 1:12 PM, Ian Romanick i...@freedesktop.org wrote: On 08/10/2015 09:15 AM, Rob Clark wrote: From: Rob Clark robcl...@freedesktop.org Punch it through mesa and gallium, plus implementation in freedreno to serve as an example. Radeon should be able to do a similar thing

Re: [Mesa-dev] [PATCH 23/25] glsl: Implement the required built-in functions when OES_shader_image_atomic is enabled.

2015-08-17 Thread Matt Turner
On Mon, Aug 17, 2015 at 9:46 AM, Francisco Jerez curroje...@riseup.net wrote: This is basically just the same atomic functions exposed by ARB_shader_image_load_store, with one exception: highp float imageAtomicExchange( coherent IMAGE_PARAMS, float data); There's no

Re: [Mesa-dev] [PATCH 1/3] mesa: add GREMEDY_string_marker

2015-08-17 Thread Ian Romanick
Two comments below. On 08/10/2015 09:15 AM, Rob Clark wrote: From: Rob Clark robcl...@freedesktop.org Signed-off-by: Rob Clark robcl...@freedesktop.org --- src/mapi/glapi/gen/GREMEDY_string_marker.xml | 18 ++ src/mapi/glapi/gen/Makefile.am | 1 +

Re: [Mesa-dev] [PATCH 02/71] target/d3dadapter9: Return Windows like card names

2015-08-17 Thread Benjamin Bellec
Hello, Where does this mapping list come from ? Is this an official map (Vendor or Windows drivers) ? Is that used just for information ? Because many of them are not really precise, if not completely wrong at all (eg. the Radeon R400/R500 series names). Regards. -- Benjamin 2015-08-16 17:27

Re: [Mesa-dev] [PATCH 1/8] i965: Change the parameters passed to intel_miptree_get_tile_masks()

2015-08-17 Thread Ben Widawsky
On Fri, Aug 14, 2015 at 04:51:52PM -0700, Anuj Phogat wrote: This change is required by the later patches. Cc: Ben Widawsky b...@bwidawsk.net Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/dri/i965/brw_blorp.cpp | 3 ++-

Re: [Mesa-dev] [PATCH 21/25] mesa: Add extension enable and table entry for OES_shader_image_atomic.

2015-08-17 Thread Ilia Mirkin
On Mon, Aug 17, 2015 at 12:46 PM, Francisco Jerez curroje...@riseup.net wrote: --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index d934d19..38c7bc8 100644 ---

Re: [Mesa-dev] [PATCH 0/3] GREMEDY_string_marker support

2015-08-17 Thread Ian Romanick
On 08/10/2015 09:15 AM, Rob Clark wrote: From: Rob Clark robcl...@freedesktop.org Punch it through mesa and gallium, plus implementation in freedreno to serve as an example. Radeon should be able to do a similar thing with no-op packets. Not sure about other drivers. The idea behind this

Re: [Mesa-dev] [PATCH 08/70] i965: Remove early release of DRI2 miptree

2015-08-17 Thread Chad Versace
On Fri 14 Aug 2015, Chris Wilson wrote: On Thu, Aug 13, 2015 at 09:58:52PM -0700, Kenneth Graunke wrote: On Thursday, August 13, 2015 02:57:20 PM Martin Peres wrote: On 07/08/15 23:13, Chris Wilson wrote: intel_update_winsys_renderbuffer_miptree() will release the existing miptree

Re: [Mesa-dev] [PATCH 09/12] i965/fs: make SIMD-splitting respect the original stride/offset

2015-08-17 Thread Connor Abbott
On Mon, Aug 17, 2015 at 2:41 AM, Francisco Jerez curroje...@riseup.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Mon, Aug 17, 2015 at 12:09 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Fri, Aug 14, 2015 at 03:30:18PM -0700, Connor Abbott wrote: In some cases, we need

Re: [Mesa-dev] Mesa 11.0.0 release plan

2015-08-17 Thread Emil Velikov
On 17 August 2015 at 01:24, Rob Clark robdcl...@gmail.com wrote: On Tue, Aug 11, 2015 at 1:45 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 29/07/15 19:20, Emil Velikov wrote: Hi all, Below is the preliminary release schedule for Mesa 11.0.0 August 21st 2015 - Feature freeze/Release

[Mesa-dev] [PATCH 12/25] glsl: Allow precision qualifiers on general opaque types.

2015-08-17 Thread Francisco Jerez
From the GLSL ES 3.1 spec, section 4.7.3: Any floating point, integer, opaque type declaration can have the type preceded by one of these precision qualifiers: [...] highp [...], mediump [...], lowp [...]. --- src/glsl/ast_to_hir.cpp | 10 ++ 1 file changed, 6 insertions(+), 4

[Mesa-dev] [PATCH 23/25] glsl: Implement the required built-in functions when OES_shader_image_atomic is enabled.

2015-08-17 Thread Francisco Jerez
This is basically just the same atomic functions exposed by ARB_shader_image_load_store, with one exception: highp float imageAtomicExchange( coherent IMAGE_PARAMS, float data); There's no float atomic exchange overload in the original ARB_shader_image_load_store or GL 4.2,

[Mesa-dev] [PATCH 07/25] mesa: Refuse to bind image uniforms using glUniform in GLES.

2015-08-17 Thread Francisco Jerez
The GLES 3.1 spec removed support for updating the image unit bound to an image uniform using glUniform1i() calls. --- src/mesa/main/uniform_query.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index

[Mesa-dev] [PATCH 09/25] glsl: Add support for image binding qualifiers.

2015-08-17 Thread Francisco Jerez
Support for binding an image to an image unit explicitly in the shader source is required by both GLSL 4.2 and GLSL ES 3.1, but not by the original ARB_shader_image_load_store extension. --- src/glsl/ast_to_hir.cpp| 12 +++- src/glsl/link_uniform_initializers.cpp | 24

[Mesa-dev] [PATCH 02/25] mesa: Don't lose track of the shader image layer originally specified by the user.

2015-08-17 Thread Francisco Jerez
The spec requires that all layers of the image starting from the 0-th are bound to the image unit regardless of the Layer parameter when Layered is true, so I was setting gl_image_unit::Layer to zero in that case for the convenience of the driver back-end. However the

[Mesa-dev] [PATCH 04/25] mesa: Reset image unit state to the default values when a bound image is deleted.

2015-08-17 Thread Francisco Jerez
The ES31-CTS.shader_image_load_store.basic-api-bind conformance test expects the whole image unit state to be reset when the bound texture object is deleted. The ARB_shader_image_load_store extension is rather vague regarding what should happen with image unit state other than the texture object

[Mesa-dev] [PATCH 03/25] mesa: Reject image formats not supported by GLES.

2015-08-17 Thread Francisco Jerez
--- src/mesa/main/shaderimage.c | 67 +++-- 1 file changed, 65 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c index 67f1716..2d86931 100644 --- a/src/mesa/main/shaderimage.c +++

[Mesa-dev] [PATCH 20/25] glsl: Parse the allowed image format qualifiers in GLSL ES 3.1.

2015-08-17 Thread Francisco Jerez
This includes the minimum required desktop/ES GLSL version in the format qualifier table in anticipation of new GLSL versions extending the set of supported image formats. According to section 4.4.7 of the GLSL ES 3.1 spec: The format layout qualifier identifiers for image variable declarations

[Mesa-dev] [PATCH 15/25] glsl: Accept supported image types in GLSL ES 3.1.

2015-08-17 Thread Francisco Jerez
These are a subset of the image types supported by desktop GL, excluding 1D, 1D array, rectangle, buffer, cube array, 2D MS and 2D MS array texture targets. --- src/glsl/builtin_types.cpp | 24 src/glsl/glsl_lexer.ll | 24 2 files changed, 24

[Mesa-dev] [PATCH 16/25] glsl: Accept atomic_uint type in GLSL ES 3.1.

2015-08-17 Thread Francisco Jerez
--- src/glsl/builtin_types.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/builtin_types.cpp b/src/glsl/builtin_types.cpp index c777f6e..9cf198f 100644 --- a/src/glsl/builtin_types.cpp +++ b/src/glsl/builtin_types.cpp @@ -253,7 +253,7 @@ const static struct

[Mesa-dev] [PATCH 01/25] mesa: Rename MaxCombinedImageUnitsAndFragmentOutputs to MaxCombinedShaderOutputResources.

2015-08-17 Thread Francisco Jerez
The name of both the GLSL built-in variable and the glGetInteger param with the same value changed in GLSL ES 3.1 and GL 4.5. Its semantics also changed slightly, since the limit now also takes into account the number of SSBs in use. Switch our internal data structures to the up-to-date name.

[Mesa-dev] Implement GLES 3.1 image load/store and OES_shader_image_atomic.

2015-08-17 Thread Francisco Jerez
This series implements a number of differences I've found while comparing the GLES 3.1 and desktop GL shader image APIs. Most of it is about taking into account additional restrictions for the GLES API, but there's also some new functionality (see PATCH 09 and 23). Together with Igalia's SSBO

[Mesa-dev] [PATCH 08/25] glsl: Forbid non-constant image array indexing in GLSL ES 3.1.

2015-08-17 Thread Francisco Jerez
--- src/glsl/ast_array_index.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/glsl/ast_array_index.cpp b/src/glsl/ast_array_index.cpp index 27e84d1..ae399f0 100644 --- a/src/glsl/ast_array_index.cpp +++ b/src/glsl/ast_array_index.cpp @@ -290,6 +290,21 @@

[Mesa-dev] [PATCH 11/25] glsl: Implement GLSL ES restriction on images being either readonly or writeonly.

2015-08-17 Thread Francisco Jerez
--- src/glsl/ast_to_hir.cpp | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 4d279f6..ff57ec3 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -2469,6 +2469,24 @@

[Mesa-dev] [PATCH 05/25] mesa: Initialize image unit state to different defaults in GLES.

2015-08-17 Thread Francisco Jerez
There is no GL_R8 image format in GLES, according to the state table 20.32 of the GLES 3.1 spec the default value should be GL_R32UI. --- src/mesa/main/shaderimage.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c

[Mesa-dev] [PATCH 24/25] i965/fs: Return result of image atomic in a register of the expected type.

2015-08-17 Thread Francisco Jerez
So the result is of float type if we're implementing the float overload of imageAtomicExchange. This is the only back-end change required to support OES_shader_image_atomic AFAICT. --- src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH 10/25] glsl: Require that all image uniforms have a format qualifier in GLSL ES.

2015-08-17 Thread Francisco Jerez
Note that this is slightly more permissive than the spec language requires: Any image variable must specify a format layout qualifier. The GLSL ES spec seems really sketchy regarding format layout qualifiers on function formal parameters -- On the one hand they are required, but on the other hand

[Mesa-dev] [PATCH 22/25] glsl: Add usual extension boilerplate for OES_shader_image_atomic.

2015-08-17 Thread Francisco Jerez
--- src/glsl/glcpp/glcpp-parse.y| 2 ++ src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ 3 files changed, 5 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index dd5ec2a..4bd4f17 100644 --- a/src/glsl/glcpp/glcpp-parse.y

[Mesa-dev] [PATCH 06/25] mesa: Refuse to bind a mutable texture object to an image unit in GLES.

2015-08-17 Thread Francisco Jerez
--- src/mesa/main/shaderimage.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c index 5a3c47a..6f7d1c9 100644 --- a/src/mesa/main/shaderimage.c +++ b/src/mesa/main/shaderimage.c @@ -546,6 +546,17 @@

[Mesa-dev] [PATCH 14/25] glsl: Expose image load and store built-ins in GLSL ES 3.1.

2015-08-17 Thread Francisco Jerez
--- src/glsl/builtin_functions.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 482cae2..c53858e 100644 --- a/src/glsl/builtin_functions.cpp +++ b/src/glsl/builtin_functions.cpp @@ -394,7 +394,7 @@

[Mesa-dev] [PATCH 21/25] mesa: Add extension enable and table entry for OES_shader_image_atomic.

2015-08-17 Thread Francisco Jerez
--- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index d934d19..38c7bc8 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -319,6 +319,7 @@ static

[Mesa-dev] [PATCH 18/25] glsl: Define image-related built-in constants required by GLSL ES 3.1.

2015-08-17 Thread Francisco Jerez
--- src/glsl/builtin_variables.cpp | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index 4966ba3..dd7804f 100644 --- a/src/glsl/builtin_variables.cpp +++ b/src/glsl/builtin_variables.cpp @@

[Mesa-dev] [PATCH 13/25] glsl: Use a separate availability class for image atomic built-ins.

2015-08-17 Thread Francisco Jerez
These are not part of unextended GLSL ES 3.1. --- src/glsl/builtin_functions.cpp | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 2175c66..482cae2 100644 ---

[Mesa-dev] [PATCH 17/25] glsl: Remove duplicate definition of gl_MaxTess*ImageUniforms built-in constants.

2015-08-17 Thread Francisco Jerez
These seem to have been re-added at some point during the ARB_tessellation_shader implementation work. AFAICT the second (correct) definition of each constant would have had no effect because the symbols were already defined. --- src/glsl/builtin_variables.cpp | 2 -- 1 file changed, 2

[Mesa-dev] [PATCH 25/25] i965: Expose OES_shader_image_atomic.

2015-08-17 Thread Francisco Jerez
--- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 0da528b..0ae24cb 100644 --- a/src/mesa/drivers/dri/i965/intel_extensions.c +++

[Mesa-dev] [PATCH 19/25] glsl: Recognise image memory qualifiers in GLSL ES 3.1.

2015-08-17 Thread Francisco Jerez
--- src/glsl/glsl_lexer.ll | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/glsl/glsl_lexer.ll b/src/glsl/glsl_lexer.ll index de6855f..24998c1 100644 --- a/src/glsl/glsl_lexer.ll +++ b/src/glsl/glsl_lexer.ll @@ -406,11 +406,11 @@ image2DShadow

Re: [Mesa-dev] [PATCH 1/2][RFC] docs: Update with GLES3.2 entries and status

2015-08-17 Thread Ian Romanick
On 08/11/2015 10:48 AM, Thomas Helland wrote: Signed-off-by: Thomas Helland thomashellan...@gmail.com --- These are listed to the best of my knowledge, looking at the nvidia driver dropped yesterday, and a glance at the what changed according to the ARB variant section of each extension

Re: [Mesa-dev] [PATCH 1/8] i965: Change the parameters passed to intel_miptree_get_tile_masks()

2015-08-17 Thread Anuj Phogat
On Mon, Aug 17, 2015 at 11:03 AM, Ben Widawsky b...@bwidawsk.net wrote: On Fri, Aug 14, 2015 at 04:51:52PM -0700, Anuj Phogat wrote: This change is required by the later patches. Cc: Ben Widawsky b...@bwidawsk.net Signed-off-by: Anuj Phogat anuj.pho...@gmail.com ---

Re: [Mesa-dev] [PATCH 0/3] GREMEDY_string_marker support

2015-08-17 Thread Ian Romanick
On 08/17/2015 11:06 AM, Rob Clark wrote: On Mon, Aug 17, 2015 at 1:12 PM, Ian Romanick i...@freedesktop.org wrote: On 08/10/2015 09:15 AM, Rob Clark wrote: From: Rob Clark robcl...@freedesktop.org Punch it through mesa and gallium, plus implementation in freedreno to serve as an example.

  1   2   >