Series is Reviewed-by: Ilia Mirkin
On Aug 26, 2015 11:41 PM, "Tapani Pälli" wrote:
> Hi;
>
> Once more the OES_texture_storage_multisample_2d_array extension
> with using ARB_texture_multisample enable bit rather than introducing
> own one.
>
> Thanks;
>
> Tapani Pälli (4):
> glapi: add GL_OES
All 3 patches
Reviewed-by: Tapani Pälli
On 08/23/2015 10:09 AM, Jordan Justen wrote:
git://people.freedesktop.org/~jljusten/mesa cs-global-id-v2
http://patchwork.freedesktop.org/bundle/jljusten/cs-global-id-v2
For i965, these also depend on the texture sampling series:
http://patchwork.freede
On Wed, Aug 26, 2015 at 8:40 PM, Tapani Pälli wrote:
> v2: use ARB_texture_multisample enable bit
>
> Patch adds extension enable bit and enables required keywords
> and builtin functions for the extension.
>
> Signed-off-by: Tapani Pälli
> ---
> src/glsl/builtin_functions.cpp | 5 +++--
> src/
v2: use ARB_texture_multisample enable bit
Patch adds extension enable bit and enables required keywords
and builtin functions for the extension.
Signed-off-by: Tapani Pälli
---
src/glsl/builtin_functions.cpp | 5 +++--
src/glsl/builtin_types.cpp | 3 ++-
src/glsl/glcpp/glcpp-parse.y|
v2: use _mesa_is_gles31(ctx) for verifying we are on ES 3.1,
remove _es31 usage from get_hash_params.py
Signed-off-by: Tapani Pälli
---
src/mesa/main/get_hash_params.py | 6 +++---
src/mesa/main/texobj.c | 3 ++-
src/mesa/main/texparam.c | 2 +-
3 files changed, 6 insertion
v2: use ARB_texture_multisample bit to enable extension
Signed-off-by: Tapani Pälli
---
src/mesa/main/extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
index 03303ac..a57d5ba 100644
--- a/src/mesa/main/extensions.c
+++ b/src/
Hi;
Once more the OES_texture_storage_multisample_2d_array extension
with using ARB_texture_multisample enable bit rather than introducing
own one.
Thanks;
Tapani Pälli (4):
glapi: add GL_OES_texture_storage_multisample_2d_array extension
mesa: Add extension enable for
OES_texture_storag
Signed-off-by: Tapani Pälli
Reviewed-by: Marta Lofstedt
---
src/mapi/glapi/gen/es_EXT.xml | 19 +++
1 file changed, 19 insertions(+)
diff --git a/src/mapi/glapi/gen/es_EXT.xml b/src/mapi/glapi/gen/es_EXT.xml
index 642e3b3..cfca5a9 100644
--- a/src/mapi/glapi/gen/es_EXT.xml
+++ b
From: Dave Airlie
The glsl->tgsi convertor does some temporary register reduction
however in profiling shader-db this shows up quite highly,
so optimise things to reduce the number of loops through
all the instructions we do. This drops merge_registers
from 4-5% on the profile to 1%. I think thi
Oh I missed one of these patches on the initial send, at least
shader-db shows no output changes with these on radeonsi,
and also it removes the merge/renumber passes from the profiles
for a shader-db run.
Dave.
___
mesa-dev mailing list
mesa-dev@lists.
From: Dave Airlie
This can be done with a single pass for the instruction base,
and takes renumber_registers out of its spot on the profile.
Signed-off-by: Dave Airlie
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 57 --
1 file changed, 38 insertions(+), 19 delet
On 27 August 2015 at 11:29, Dave Airlie wrote:
> I profiled shader-db running on radeonsi, and the temp register
> handling passes in the glsl->tgsi convertor were quite heavy
> users of CPU.
>
> These two passes are my attempt at cleaning them up to avoid
> looping over the instruction set so muc
I profiled shader-db running on radeonsi, and the temp register
handling passes in the glsl->tgsi convertor were quite heavy
users of CPU.
These two passes are my attempt at cleaning them up to avoid
looping over the instruction set so much. I'm in the process
of piglitting then,
On my CPU, a sha
From: Dave Airlie
This can be done with a single pass for the instruction base,
and takes renumber_registers out of its spot on the profile.
Signed-off-by: Dave Airlie
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 57 --
1 file changed, 38 insertions(+), 19 delet
From: Dave Airlie
Instead of looking this up lots, lets just cache it in the instruction
translation up front. I just noticed this function what high in a profile
of shader-db on radeonsi.
Signed-off-by: Dave Airlie
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 39 --
This reverts commit 1bba29ed403e735ba0bf04ed8aa2e571884fcaaf
Author: Topi Pohjolainen
Date: Thu Jun 25 14:00:41 2015 +0300
i965: Stop aux data compare preventing program binary re-use
This fixes an intermittent failure in
piglit.spec.arb_pixel_buffer_object.texsubimage pbo.sklm64 (maybe ot
https://bugs.freedesktop.org/show_bug.cgi?id=91039
xpue changed:
What|Removed |Added
CC||r9k...@gmail.com
--
You are receiving this mail
From: Nanley Chery
This function's cases for non-generic compressed formats duplicate
the GL to MESA translation in _mesa_glenum_to_compressed_format().
This patch replaces the switch cases with a call to the translation
function.
Cc: Brian Paul
Cc: Chad Versace
Cc: Ian Romanick
Signed-off-by
From: Nanley Chery
MESA_FORMAT_RGBA_DXT5 should actually be reserved for GL_RGBA[4]_DXT5_S3TC.
Also, Gallium and other dri drivers (radeon and nouveau) follow this mapping
scheme.
Cc: Brian Paul
Cc: Chad Versace
Cc: Ian Romanick
Signed-off-by: Nanley Chery
---
src/mesa/main/texcompress.c |
On Wed, Aug 26, 2015 at 10:20 AM, Ian Romanick wrote:
> From: Ian Romanick
>
> Signed-off-by: Ian Romanick
> ---
> src/glsl/nir/nir_constant_expressions.py | 13 +
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/src/glsl/nir/nir_constant_expressions.py
> b/src/gl
On Wed, Aug 26, 2015 at 1:40 PM, Matt Turner wrote:
> On Wed, Aug 26, 2015 at 10:50 AM, Jason Ekstrand wrote:
>> I like adding constness but I don't really see the need for the
>> whitespace changes or adding braces and breaks to the switch.
>
> Please don't top quote.
>
> Looks like he's removin
On Tue, Aug 25, 2015 at 4:19 PM, Chad Versace
wrote:
> On Sun 16 Aug 2015, Nanley Chery wrote:
> > The last line of the commit message should say:
> >
> >GL_RGBA4_S3TC (0x83A3) -> COMPRESSED_RGBA_S3TC_DXT5_EXT (0x83F3)
>
> There's another weird line too, see below.
>
> > On Wed, Aug 12, 201
Previously, we used PROGRAM_ARRAY only for variables which were
arrays or matrices. But if the variable is a structure containing
an array or matrix, we need to use PROGRAM_ARRAY for that too.
Before, we failed an assertion:
state_tracker/st_glsl_to_tgsi.cpp:4900:
Assertion `src_reg->file !=
On Wed, Aug 26, 2015 at 10:50 AM, Jason Ekstrand wrote:
> I like adding constness but I don't really see the need for the
> whitespace changes or adding braces and breaks to the switch.
Please don't top quote.
Looks like he's removing braces and breaks from the switch, not adding them.
_
On Wed, Aug 26, 2015 at 2:43 AM, Kenneth Graunke wrote:
> driParseDebugString() doesn't have actual code to parse comma separated
> lists (or any other supported options?); instead it dumbly uses strstr().
>
> This means that INTEL_DEBUG="vec4vs" will trigger both DEBUG_VEC4VS and
> DEBUG_VS, as "
On Wed, Aug 26, 2015 at 7:09 AM, Marek Olšák wrote:
> Ping
for the series:
Reviewed-by: Alex Deucher
>
> On Sun, Aug 23, 2015 at 2:13 PM, Marek Olšák wrote:
>> From: Marek Olšák
>>
>> ---
>> src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 54
>> +++
>> src/gallium/wi
On Wed, Aug 26, 2015 at 10:52:58AM -0700, Ben Widawsky wrote:
> Docs suggest this is no longer required starting with Gen8.
>
> Perf (no regressions in n=20)
> OglMultithread 0.67%
> OglTerrainPanInst0.12%
> trex 0.45%
> warsow 0.64%
I forgot to mention thi
Docs suggest this is no longer required starting with Gen8.
Perf (no regressions in n=20)
OglMultithread 0.67%
OglTerrainPanInst0.12%
trex 0.45%
warsow 0.64%
I have a couple of spurious failures in piglit on BSW, and SKL. I have no
evidence that they are re
I like adding constness but I don't really see the need for the
whitespace changes or adding braces and breaks to the switch.
--Jason
On Wed, Aug 26, 2015 at 10:20 AM, Ian Romanick wrote:
> From: Ian Romanick
>
> Signed-off-by: Ian Romanick
> ---
> src/glsl/nir/nir_constant_expressions.py | 13
I think I'd rather just run it through indent like we do for some of
the other auto-generated code. That way the mako file (the one you'll
actually be editing) can remain readable.
--Jason
On Wed, Aug 26, 2015 at 10:19 AM, Ian Romanick wrote:
> From: Ian Romanick
>
> Signed-off-by: Ian Romanick
*every* other callback takes a ctx... this feels really asymmetric.
I'd kinda rather just keep the ctx's in and add (void) uses on them.
Don't feel too strongly about it though.
On Wed, Aug 26, 2015 at 1:20 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> _mesa_initialize_buffer_object did not u
Reviewed-by: Ilia Mirkin
On Wed, Aug 26, 2015 at 1:20 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> main/bufferobj.c: In function '_mesa_handle_bind_buffer_gen':
> main/bufferobj.c:915:37: warning: unused parameter 'target'
> [-Wunused-parameter]
> GLenum targe
Reviewed-by: Ilia Mirkin
On Wed, Aug 26, 2015 at 1:20 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> main/bufferobj.c: In function 'count_buffer_size':
> main/bufferobj.c:520:26: warning: unused parameter 'key' [-Wunused-parameter]
> count_buffer_size(GLuint key, void *data, void *userData)
Reviewed-by: Ilia Mirkin
On Wed, Aug 26, 2015 at 1:20 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> The purpose of the macro was to create the name_as_gs_input from name.
> The previous commit removed the name_as_gs_input from add_varying, so
> the macro is unnecessary.
>
> Signed-off-by: Ia
On Wed, Aug 26, 2015 at 1:20 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> builtin_variables.cpp:1062:53: warning: unused parameter 'name_as_gs_input'
> [-Wunused-parameter]
> const char *name_as_gs_input)
>
On 17/08/15 18:14, Matt Turner wrote:
On Mon, Aug 17, 2015 at 9:46 AM, Francisco Jerez wrote:
This is basically just the same atomic functions exposed by
ARB_shader_image_load_store, with one exception:
"highp float imageAtomicExchange(
coherent IMAGE_PARAMS,
float dat
The split_virtual_grfs code doesn't properly rewrite reladdr so we need to
make sure that any uniform indirects are lowered away first.
Cc: "10.6"
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
These two patches are largely a re-send of other patches in my bigger
series to push small uniform arrays. The first patch is a really nice
cleanup that I think we want regardless of pushing uniform arrays.
Unfortunately, it was in the middle of the series after a patch to the same
function that w
Now that all constant locations are assigned in a single function, we can
refactor it a bit to unify things. In particular, we now handle
pull_constant_loc and push_constant_loc more similarly and we only modify
stage_prog_data->params[] in one place at the end of the function.
---
src/mesa/drive
Fair enough... if they need ctx in the future, someone can re-add them.
Reviewed-by: Ilia Mirkin
On Wed, Aug 26, 2015 at 1:19 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> linker.cpp:320:55: warning: unused parameter 'ir' [-Wunused-parameter]
> virtual ir_visitor_status visit_leave(ir_f
Reviewed-by: Ilia Mirkin
On Wed, Aug 26, 2015 at 1:19 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> Because the compiler already has enough things to complain about.
>
> grep -rl 'const static' src/ | while read f
> do
> sed --in-place -e 's/const static/static const/g' $f
>
From: Ian Romanick
main/bufferobj.c: In function 'count_buffer_size':
main/bufferobj.c:520:26: warning: unused parameter 'key' [-Wunused-parameter]
count_buffer_size(GLuint key, void *data, void *userData)
^
main/bufferobj.c: In function 'flush_mapped_buffer_range_fallb
From: Ian Romanick
The purpose of the macro was to create the name_as_gs_input from name.
The previous commit removed the name_as_gs_input from add_varying, so
the macro is unnecessary.
Signed-off-by: Ian Romanick
---
src/glsl/builtin_variables.cpp | 27 ---
1 file chan
From: Ian Romanick
Signed-off-by: Ian Romanick
---
src/glsl/nir/nir_constant_expressions.py | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/glsl/nir/nir_constant_expressions.py
b/src/glsl/nir/nir_constant_expressions.py
index e2feff3..099bb77 100644
--- a/
From: Ian Romanick
Because the compiler already has enough things to complain about.
grep -rl 'const static' src/ | while read f
do
sed --in-place -e 's/const static/static const/g' $f
done
brw_eu_emit.c: In function 'brw_reg_type_to_hw_type':
brw_eu_emit.c:98:7: warning: 's
From: Ian Romanick
This should remove all of the unused parameter warnings in src/glsl/nir.
These cases had the parameter removed:
nir/nir_lower_vars_to_ssa.c: In function 'get_ssa_def_for_block':
nir/nir_lower_vars_to_ssa.c:527:59: warning: unused parameter 'block'
[-Wunused-parameter]
get_s
From: Ian Romanick
nir/nir.h: In function 'nir_src_for_ssa':
nir/nir.h:552:4: warning: missing initializer for field 'use_link' of 'nir_src'
[-Wmissing-field-initializers]
nir_src src = NIR_SRC_INIT;
^
In file included from nir/nir.c:28:0:
nir/nir.h:508:21: note: 'use_link' declared here
From: Ian Romanick
nir/nir_constant_expressions.c:290:25: warning: unused parameter
'num_components' [-Wunused-parameter]
evaluate_ball3(unsigned num_components, nir_const_value *_src)
^
nir/nir_constant_expressions.c: In function 'evaluate_fddx':
nir/nir_constant_expre
From: Ian Romanick
All of the other state upload functions are static because the only use
is in the brw_tracked_state structure.
Signed-off-by: Ian Romanick
Cc: Abdiel Janulgue
---
src/mesa/drivers/dri/i965/brw_binding_tables.c | 2 +-
src/mesa/drivers/dri/i965/brw_state.h | 1 -
2
From: Ian Romanick
Signed-off-by: Ian Romanick
---
src/glsl/nir/nir_constant_expressions.py | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/src/glsl/nir/nir_constant_expressions.py
b/src/glsl/nir/nir_constant_expressions.py
index 6006358..
From: Ian Romanick
nir/nir_builder.h:234:4: warning: missing initializer for field 'use_link' of 'n
ir_src' [-Wmissing-field-initializers]
nir_alu_src alu_src = { NIR_SRC_INIT };
^
Number of total warnings in my build reduced from 1664 to 1651.
(reduction of 13).
Patch generated by:
From: Ian Romanick
_mesa_initialize_buffer_object did not use it. Once that parameter was
removed, none of the implementations of dd::NewBufferObject used it
either.
Also silences a warning:
main/bufferobj.c: In function '_mesa_initialize_buffer_object':
main/bufferobj.c:503:51: warning: unuse
From: Ian Romanick
builtin_variables.cpp:1062:53: warning: unused parameter 'name_as_gs_input'
[-Wunused-parameter]
const char *name_as_gs_input)
^
builtin_functions.cpp:4774:47: warning: unused paramet
From: Ian Romanick
All of the other state upload functions are static because the only use
is in the brw_tracked_state structure.
Signed-off-by: Ian Romanick
---
src/mesa/drivers/dri/i965/brw_state.h | 4
src/mesa/drivers/dri/i965/gen8_misc_state.c | 3 ++-
2 files changed, 2 insert
From: Ian Romanick
nir/nir.h:576:4: warning: missing initializer for field 'is_ssa' of 'nir_dest' [
-Wmissing-field-initializers]
nir_dest dest = NIR_DEST_INIT;
^
nir/nir.h:538:10: note: 'is_ssa' declared here
bool is_ssa;
^
nir/nir.h:576:55: warning: missing initializer for
From: Ian Romanick
nir/nir_constant_expressions.c: In function 'evaluate_ball2':
nir/nir_constant_expressions.c:279:7: warning: missing initializer for field
'z' of 'struct bool_vec' [-Wmissing-field-initializers]
};
^
nir/nir_constant_expressions.c:234:10: note: 'z' declared here
From: Ian Romanick
main/bufferobj.c: In function '_mesa_handle_bind_buffer_gen':
main/bufferobj.c:915:37: warning: unused parameter 'target' [-Wunused-parameter]
GLenum target,
^
Signed-off-by: Ian Romanick
---
src/mesa/main/bu
From: Ian Romanick
linker.cpp:320:55: warning: unused parameter 'ir' [-Wunused-parameter]
virtual ir_visitor_status visit_leave(ir_function *ir)
^
linker.cpp:327:53: warning: unused parameter 'ir' [-Wunused-parameter]
virtual ir_visit
Acked-by: Jason Ekstrand
On Wed, Aug 26, 2015 at 2:43 AM, Kenneth Graunke wrote:
> driParseDebugString() doesn't have actual code to parse comma separated
> lists (or any other supported options?); instead it dumbly uses strstr().
>
> This means that INTEL_DEBUG="vec4vs" will trigger both DEBUG_
https://bugs.freedesktop.org/show_bug.cgi?id=91747
Benjamin Bellec changed:
What|Removed |Added
CC||b.bel...@gmail.com
--- Comment #1 from
On Wed, Aug 26, 2015 at 5:03 AM, Tapani Pälli wrote:
> On 08/26/2015 08:26 AM, Ilia Mirkin wrote:
>>
>> On Wed, Aug 26, 2015 at 1:19 AM, Tapani Pälli
>> wrote:
>>>
>>> On 08/24/2015 04:18 PM, Ilia Mirkin wrote:
On Fri, Aug 21, 2015 at 3:22 AM, Tapani Pälli
wrote:
>
> Signe
On 08/24/2015 06:37 PM, Ilia Mirkin wrote:
On Mon, Aug 24, 2015 at 11:35 AM, Ilia Mirkin wrote:
Signed-off-by: Ilia Mirkin
---
src/mesa/main/get.c | 37 +---
src/mesa/main/get_hash_params.py | 46
2 files cha
This avoids generation of undefined packing in qir and qpu instructions,
fixing a lot of rendering errors.
Fixes 8b36d107fdd (vc4: Pack the unorm-packing bits into a src MUL
instruction when possible.)
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Boyan Ding
---
src/gallium/drivers/vc4/v
Ping
On Sun, Aug 23, 2015 at 2:13 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 54
> +++
> src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 25 +
> 2 files changed, 41 insertions(+), 38 deletions(-)
>
__
On Tue, Aug 25, 2015 at 1:56 PM, Edward O'Callaghan
wrote:
> From: Edward O'Callaghan
>
> tgsi_shader_scan() has already happened so just use the results.
>
> Signed-off-by: Edward O'Callaghan
> Signed-off-by: Dave Airlie
Did Dave really give you this sign-off?
> ---
> src/gallium/drivers/r6
On Tue, Aug 25, 2015 at 1:56 PM, Edward O'Callaghan
wrote:
> From: Edward O'Callaghan
>
> Signed-off-by: Edward O'Callaghan
> ---
> src/gallium/drivers/r600/evergreen_state.c | 16
> src/gallium/drivers/r600/r600_pipe.h | 5 +
> src/gallium/drivers/r600/r600_shad
driParseDebugString() doesn't have actual code to parse comma separated
lists (or any other supported options?); instead it dumbly uses strstr().
This means that INTEL_DEBUG="vec4vs" will trigger both DEBUG_VEC4VS and
DEBUG_VS, as "vs" is also a substring.
We should probably improve the driconf p
On 08/26/2015 08:26 AM, Ilia Mirkin wrote:
On Wed, Aug 26, 2015 at 1:19 AM, Tapani Pälli wrote:
On 08/24/2015 04:18 PM, Ilia Mirkin wrote:
On Fri, Aug 21, 2015 at 3:22 AM, Tapani Pälli
wrote:
Signed-off-by: Tapani Pälli
---
src/mesa/main/get_hash_params.py | 6 +++---
src/mesa/main/tex
On Wednesday, August 26, 2015 04:55:32 PM Dave Airlie wrote:
> On 26 August 2015 at 16:48, Ilia Mirkin wrote:
> > On Wed, Aug 26, 2015 at 2:38 AM, Dave Airlie wrote:
> >> From: Dave Airlie
> >>
> >> GL33-CTS.shaders.preprocessor.definitions.*
> >> has 4 tests the undefine these,
> >>
> >> I can'
On 25/08/15 12:46, Emil Velikov wrote:
> On 25 August 2015 at 06:42, Samuel Iglesias Gonsálvez
> wrote:
>> On 24/08/15 16:10, Emil Velikov wrote:
>>> Hi Samuel, Iago,
>>>
>>> On 05/08/15 09:30, Iago Toral Quiroga wrote:
From: Samuel Iglesias Gonsalvez
v2:
- Add ShaderStorage
Looks like the change happened as of 4.40. I checked as far back as
GLSL 1.50, and it was the older "you can do whatever" wording
everywhere there:
"""
All macro names containing two consecutive underscores ( __ ) are
reserved for future use as predefined
macro names. All macro names prefixed with
On 26 August 2015 at 16:55, Dave Airlie wrote:
> On 26 August 2015 at 16:48, Ilia Mirkin wrote:
>> On Wed, Aug 26, 2015 at 2:38 AM, Dave Airlie wrote:
>>> From: Dave Airlie
>>>
>>> GL33-CTS.shaders.preprocessor.definitions.*
>>> has 4 tests the undefine these,
>>>
>>> I can't find anything in t
72 matches
Mail list logo
