Re: [Mesa-dev] [RFC 1/2] nir: Add a new lowering pass nir_lower_vec_and_coalesce

On 09/10/2015 08:45 PM, Jason Ekstrand wrote: > On Wed, Sep 9, 2015 at 11:51 PM, Eduardo Lima Mitev wrote: >> On 09/09/2015 07:10 PM, Jason Ekstrand wrote: >>> >>> On Sep 8, 2015 23:27, "Eduardo Lima Mitev" >> > wrote: This

Re: [Mesa-dev] [PATCH v2] glsl: add packed varyings to program resource list

On 09/11/2015 09:15 AM, Ilia Mirkin wrote: On Fri, Sep 11, 2015 at 2:12 AM, Tapani Pälli wrote: This makes sure that user is still able to query properties about variables that have gotten packed by lower_packed_varyings pass. Fixes following OpenGL ES 3.1 test:

Re: [Mesa-dev] [PATCH v2] glsl: add packed varyings to program resource list

On Fri, Sep 11, 2015 at 2:12 AM, Tapani Pälli wrote: > This makes sure that user is still able to query properties about > variables that have gotten packed by lower_packed_varyings pass. > > Fixes following OpenGL ES 3.1 test: >

Re: [Mesa-dev] [PATCH 07/11] nir/lower_vec_to_movs: Handle partially SSA shaders

On 09/10/2015 08:38 PM, Jason Ekstrand wrote: > On Thu, Sep 10, 2015 at 9:08 AM, Eduardo Lima Mitev wrote: >> On 09/10/2015 02:50 AM, Jason Ekstrand wrote: >>> --- >>> src/glsl/nir/nir_lower_vec_to_movs.c | 18 -- >>> 1 file changed, 16 insertions(+), 2

Re: [Mesa-dev] [PATCH v5 01/70] mesa: set MAX_SHADER_STORAGE_BUFFERS to 15.

On Thu, 2015-09-10 at 15:17 -0400, Ilia Mirkin wrote: > On Thu, Sep 10, 2015 at 2:52 PM, Ian Romanick wrote: > > On 09/10/2015 10:45 AM, Ilia Mirkin wrote: > >> On Thu, Sep 10, 2015 at 9:35 AM, Iago Toral Quiroga > >> wrote: > >>> From: Samuel Iglesias

Re: [Mesa-dev] [PATCH v2] glsl: add packed varyings to program resource list

On Fri, Sep 11, 2015 at 2:18 AM, Tapani Pälli wrote: > On 09/11/2015 09:15 AM, Ilia Mirkin wrote: >> >> On Fri, Sep 11, 2015 at 2:12 AM, Tapani Pälli >> wrote: >>> >>> This makes sure that user is still able to query properties about >>> variables

Re: [Mesa-dev] [PATCH v2] glsl: add packed varyings to program resource list

On 09/11/2015 09:32 AM, Ilia Mirkin wrote: On Fri, Sep 11, 2015 at 2:18 AM, Tapani Pälli wrote: On 09/11/2015 09:15 AM, Ilia Mirkin wrote: On Fri, Sep 11, 2015 at 2:12 AM, Tapani Pälli wrote: This makes sure that user is still able to

[Mesa-dev] [PATCH v2] glsl: add packed varyings to program resource list

This makes sure that user is still able to query properties about variables that have gotten packed by lower_packed_varyings pass. Fixes following OpenGL ES 3.1 test: ES31-CTS.program_interface_query.separate-programs-vertex v2: fix 'name included in packed list' check (Ilia Mirkin)

Re: [Mesa-dev] [PATCH v2 10.1/11] nir: Add a fdot instruction that replicates the result to a vec4

On Fri, Sep 11, 2015 at 11:52 AM, Jason Ekstrand wrote: > Fortunately, nir_constant_expr already auto-splats if "dst" never shows up > in the constant expression field so we don't need to do anything there. > > Cc: Connor Abbott > --- >

Re: [Mesa-dev] [PATCH 0/4] gallium: add support for retrieving number of texture samples

On Fri, Sep 11, 2015 at 10:47 AM, Brian Paul wrote: > On 09/11/2015 07:26 AM, Roland Scheidegger wrote: >> >> Am 11.09.2015 um 05:15 schrieb Ilia Mirkin: >>> >>> My hope was (as you can see in the last patch) to enable this for all >>> drivers that support MS textures. I've got

Re: [Mesa-dev] i965: L3 cache partitioning.

On Fri, Sep 11, 2015 at 10:24:29AM -0700, Ben Widawsky wrote: > On Sun, Sep 06, 2015 at 06:12:38PM +0200, Francisco Jerez wrote: > > This series implements dynamic partitioning of the L3 cache space > > among its clients, the purpose is multiple: > > > > - Steal a chunk of L3 space when

Re: [Mesa-dev] [PATCH v2] i965/vec4: check writemask when bailing out at register coalesce

Cc'ing stable On Fri, Sep 11, 2015 at 8:13 AM, Alejandro Piñeiro wrote: > opt_register_coalesce stopped to check previous instructions to > coalesce with if somebody else was writing on the same > destination. This can be optimized to check if somebody else was > writing to

Re: [Mesa-dev] [PATCH] nir: Fix output variable names

Hi, didnt Jason just send a similar patch to the list? [Mesa-dev] [PATCH] nir/lower_outputs_to_temporaries: Reparent the output name Regards Michael Am 11/09/2015 um 09:24 schrieb Eduardo Lima Mitev: > Commit 1dbe4af9c9e318525fc082b542b93fb7f1e5efba > "nir: Add a pass to lower outputs to

Re: [Mesa-dev] [PATCH v3] i915: fixing driver crashes if too few vertices are submitted

On Fri, Sep 11, 2015 at 12:36 PM, Marius Predut wrote: > Comparison with a signed expression and unsigned value > is converted to unsigned value, reason for minus value is interpreted > as a big unsigned value. For this case the "for" loop > is going into unexpected

Re: [Mesa-dev] [PATCH v2 10.1/11] nir: Add a fdot instruction that replicates the result to a vec4

On Fri, Sep 11, 2015 at 9:00 AM, Connor Abbott wrote: > On Fri, Sep 11, 2015 at 11:52 AM, Jason Ekstrand wrote: >> Fortunately, nir_constant_expr already auto-splats if "dst" never shows up >> in the constant expression field so we don't need to do

[Mesa-dev] [PATCH 3/7] tgsi, softpipe: Constify tgsi_sampler in query_lod vfunc

A followup from previous commit - since all functions called by query_lod take pointers to const sp_sampler_view and const sp_sampler, which are taken from tgsi_sampler subclass, we can the tgsi_sampler as const itself now. --- src/gallium/auxiliary/tgsi/tgsi_exec.h | 2 +-

[Mesa-dev] [PATCH 1/7] softpipe: Move the faces array from view to filter_args

With that, sp_sampler_view instances are not abused anymore as a local storage, so we can later make them constant. --- src/gallium/drivers/softpipe/sp_tex_sample.c | 36 +--- src/gallium/drivers/softpipe/sp_tex_sample.h | 4 +--- 2 files changed, 23 insertions(+), 17

[Mesa-dev] [PATCH 2/7] softpipe: Constify some sampler and view parameters

This is to prepare for making tgsi_sampler parameter in query_lod a const too. These functions do not modify anything in either sampler or view anymore. --- src/gallium/drivers/softpipe/sp_tex_sample.c | 51 ++-- src/gallium/drivers/softpipe/sp_tex_sample.h | 4 +-- 2

[Mesa-dev] [PATCH 0/7] Const fixes/cleanups in softpipe's tex samplers

This stops abusing sp_sampler_view as a local storage and thus allowing to put some more const modifiers in front of some types. I might have gotten carried away too bit with the last commit. :) So if you don't like it, then please ignore it. Tested it with piglit shader tests and got no

[Mesa-dev] [PATCH 5/7] softpipe: Constify sampler and view parameters in mip filters

Those functions actually could always take them as constants. --- src/gallium/drivers/softpipe/sp_tex_sample.c | 32 ++-- src/gallium/drivers/softpipe/sp_tex_sample.h | 4 ++-- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git

[Mesa-dev] [PATCH 6/7] softpipe: Constify sp_tgsi_sampler

Add a small inline function doing the casting - this is to make sure we don't do a cast from some completely unrelated type. This commit does not make tgsi_sampler parameters const in vfuncs themselves for now - probably llvmpipe would need looking at before making such a change. ---

[Mesa-dev] [PATCH 7/7] softpipe: Constify variables

This commit makes a lot of variables constant - this is basically done by moving the computation to variable definition. Some of them are moved into lower scopes (like in img_filter_2d_ewa). --- src/gallium/drivers/softpipe/sp_tex_sample.c | 441 --- 1 file changed, 199

Re: [Mesa-dev] [PATCH V2 1/8] i965: Add a helper function intel_get_tile_dims()

On Thu, Sep 10, 2015 at 12:20 PM, Chad Versace wrote: > On Wed 19 Aug 2015, Anuj Phogat wrote: > > V2: > > - Do the tile width/height computations in the new helper > > function and use it later in intel_miptree_get_tile_masks(). > > - Change the name to

Re: [Mesa-dev] [PATCH 1/4] tgsi: add a TXQS opcode to retrieve the number of texture samples

On Fri, Sep 11, 2015 at 10:42 AM, Brian Paul wrote: > On 09/10/2015 09:15 PM, Ilia Mirkin wrote: >> >> Signed-off-by: Ilia Mirkin >> --- >> src/gallium/auxiliary/tgsi/tgsi_info.c | 3 ++- >> src/gallium/docs/source/tgsi.rst | 12

Re: [Mesa-dev] [PATCH 2/3] mesa: return initial value for PROGRAM_SEPARABLE when not linked

On 09/11/2015 10:53 AM, Lofstedt, Marta wrote: Hi Tapani, For spec. reference I believe you could go for section 7.12: "Most properties set within program objects are specified not to take effect until the next call to LinkProgram or ProgramBinary. Some properties further require a

[Mesa-dev] [PATCH 09/20] nir: Add glsl_get_type_without_array() wrapper

Signed-off-by: Abdiel Janulgue --- src/glsl/nir/nir_types.cpp | 6 ++ src/glsl/nir/nir_types.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/src/glsl/nir/nir_types.cpp b/src/glsl/nir/nir_types.cpp index a0caf0e..332da8f 100644 ---

[Mesa-dev] [PATCH 07/20] i965: Assign hw-binding table index for uniform constant buffer block

Assign the uploaded uniform block with hardware binding table indices. This is indexed by the resource streamer to fetch the constant buffers referred to by our gather table entries. Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/gen6_vs_state.c |

[Mesa-dev] [PATCH 14/20] i965/vec4: Append uniform entries to the gather table

Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 12 src/mesa/drivers/dri/i965/brw_vec4.h | 1 + 2 files changed, 13 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp

[Mesa-dev] [PATCH 03/20] i965: Allocate space on the gather pool for plain uniforms

Reserve space in the gather pool where the gathered uniforms are flushed. Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/gen6_vs_state.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/gen6_vs_state.c

[Mesa-dev] [PATCH 06/20] i965: Assign hw-binding table index for each UBO constant buffer.

To be able to refer to a constant buffer, the resource streamer needs to index it with a hardware binding table entry. This blankets the ubo buffers with hardware binding table indices. Gather constants hardware fetches in 16-entry binding table blocks. So we need to use a block that is unused.

[Mesa-dev] [PATCH 12/20] i965/fs/nir: Append nir_intrinsic_load_ubo entries to the gather table

When the const block and offset are immediate values. Otherwise just fall-back to the previous method of uploading the UBO constant data to GRF using pull constants. Cc: kenn...@whitecape.org Cc: ja...@jlekstrand.net Signed-off-by: Abdiel Janulgue ---

[Mesa-dev] [PATCH 10/20] i965: Include UBO parameter sizes in push constant parameters

Now that we consider UBO constants as push constants, we need to include the sizes of the UBO's constant slots in the visitor's uniform slot sizes. This information is needed to properly pack vector constants tightly next to each other. Signed-off-by: Abdiel Janulgue

[Mesa-dev] [PATCH 13/20] i965/fs: Pack UBO registers right after uniform registers

We now have two sources of constant buffers: UBOs and ordinary uniforms. After assigning a block of push constant hw-register to normal uniforms, just pack the UBO push constant registers right after it. Signed-off-by: Abdiel Janulgue ---

[Mesa-dev] [PATCH 08/20] nir: Add glsl_get_array_size() wrapper.

Signed-off-by: Abdiel Janulgue --- src/glsl/nir/nir_types.cpp | 6 ++ src/glsl/nir/nir_types.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/src/glsl/nir/nir_types.cpp b/src/glsl/nir/nir_types.cpp index 940c676..a0caf0e 100644 ---

[Mesa-dev] [PATCH] nir: Fix output variable names

Commit 1dbe4af9c9e318525fc082b542b93fb7f1e5efba "nir: Add a pass to lower outputs to temporary variables" messed up output variable names. The issue can be reproduced by dumping the NIR shaders with INTEL_DEBUG="vs,fs". --- src/glsl/nir/nir_lower_outputs_to_temporaries.c | 3 ++- 1 file changed,

Re: [Mesa-dev] [PATCH 4/7] i965/cs: Reserve local invocation id in payload regs

On Mon, 2015-08-03 at 23:00 -0700, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_cs.cpp | 29 + > src/mesa/drivers/dri/i965/brw_cs.h | 5 + > src/mesa/drivers/dri/i965/brw_fs.cpp | 11

Re: [Mesa-dev] [PATCH 0/4] gallium: add support for retrieving number of texture samples

This series is, Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Fri, Sep 11, 2015, at 01:15 PM, Ilia Mirkin wrote: > My hope was (as you can see in the last patch) to enable this for all > drivers that support MS

Re: [Mesa-dev] [PATCH 2/2] r600g: lower number of driver const buffers

Series is: Reviewed-by: Glenn Kennard ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v3] glsl: add packed varyings to program resource list

This makes sure that user is still able to query properties about variables that have gotten packed by lower_packed_varyings pass. Fixes following OpenGL ES 3.1 test: ES31-CTS.program_interface_query.separate-programs-vertex v2: fix 'name included in packed list' check (Ilia Mirkin) v3:

Re: [Mesa-dev] [PATCH 2/3] mesa: return initial value for PROGRAM_SEPARABLE when not linked

Hi Tapani, For spec. reference I believe you could go for section 7.12: "Most properties set within program objects are specified not to take effect until the next call to LinkProgram or ProgramBinary. Some properties further require a successful call to either of these commands before taking

Re: [Mesa-dev] [PATCH 2/2] r600g: lower number of driver const buffers

This series is, Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Fri, Sep 11, 2015, at 08:09 PM, Glenn Kennard wrote: > Series is: > > Reviewed-by: Glenn Kennard >

Re: [Mesa-dev] [PATCH 1/3] mesa: enable query of PROGRAM_PIPELINE_BINDING for ES 3.1

Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Tapani Pälli > Sent: Tuesday, September 1, 2015 12:54 PM > To: mesa-dev@lists.freedesktop.org > Cc: Romanick, Ian D > Subject:

[Mesa-dev] [PATCH 02/20] i965: Enable gather push constants

The 3DSTATE_GATHER_POOL_ALLOC is used to enable or disable the gather push constants feature within a context. This patch provides the toggle functionality of using gather push constants to program constant data within a batch. Using gather push constants require that a gather pool be allocated

[Mesa-dev] [PATCH 01/20] i965: Define gather push constants opcodes

Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_defines.h | 20 1 file changed, 20 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dri/i965/brw_defines.h index a8594af..7b07c50 100644

[Mesa-dev] i965: Turn UBOs as push constants

Some updated figures first: Ue4 Reflections Subway demo x fs gather constants disabled + fs gather constants enabled HSW: N Min MaxMedian AvgStddev x 10 5.09739 6.48963 6.33357 6.1979850.40742969 + 10 6.56139

[Mesa-dev] [PATCH 17/20] i965: Upload UBO surfaces before emitting constant state packet

Now that UBOs are uploaded as push constants. We need to obtain and append the amount of push constant entries generated by the UBO entry fetches to the 3DSTATE_CONSTANT_* packets. v2: GEN8 support Signed-off-by: Abdiel Janulgue ---

[Mesa-dev] [PATCH 18/20] i965: Program the push constants state using the gather table

Use the gather table generated from the uniform uploads and ir_binop_ubo_load to gather and pack the constants to the gather pool. Note that the 3DSTATE_CONSTANT_* packet now refers to the gather pool generated by the resource streamer instead of the constant buffer pointed to by an offset of the

[Mesa-dev] [PATCH 15/20] i965/vec4: Append ir_binop_ubo_load entries to the gather table

When the const block and offset are immediate values. Otherwise just fall-back to the previous method of uploading the UBO constant data to GRF using pull constants. Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_vec4.cpp| 13

[Mesa-dev] [PATCH 11/20] i965/fs: Append uniform entries to the gather table

This patch generates the gather table entries for ordinary uniforms if they are present. The uniform constants here will later be packed together with UBO constants. Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_fs.cpp | 18 +-

[Mesa-dev] [PATCH 04/20] i965: Allocate space on the gather pool for UBO entries

If there are UBO constant entries, append them to stage_state->push_const_size. The gather pool contains the combined entries of both ordinary uniforms and UBO constants. Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/gen6_vs_state.c | 20

[Mesa-dev] [PATCH 19/20] i965: Disable gather push constants for null constants

Programming null constants with gather constant tables seems to be unsupported and results in a GPU lockup even with the prescribed GPU workarounds in the bspec. Found out by trial and error that disabling HW gather constant when the constant state for a stage needs to be nullified is the only way

[Mesa-dev] [PATCH 20/20] i965: Enable push constants for UBOs

Switches on push constants whenever we have UBO entries. Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/gen7_wm_state.c | 2 +- src/mesa/drivers/dri/i965/gen8_ps_state.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 16/20] i965/vec4: Pack UBO registers right after uniform registers

Since we now consider UBOs as push constants, we need to layout our push constant register space in such a way that UBO registers are packed right after uniform registers. Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 38

Re: [Mesa-dev] [PATCH 3/3] mesa: return initial value for VALIDATE_STATUS if pipe not bound

Reviewed-by: Marta Lofstedt From: mesa-dev [mesa-dev-boun...@lists.freedesktop.org] on behalf of Tapani Pälli [tapani.pa...@intel.com] Sent: Tuesday, September 01, 2015 12:53 PM To: mesa-dev@lists.freedesktop.org Cc: Romanick,

Re: [Mesa-dev] [PATCH 1/2] mesa/texcompress: add function to determine compressed format type

On Fri, Aug 28, 2015 at 9:09 AM, Nanley Chery wrote: > From: Nanley Chery > > Determines if a compressed format is non-palettized and specific. > > Signed-off-by: Nanley Chery > --- > src/mesa/main/texcompress.c | 10

Re: [Mesa-dev] [PATCH] i965/skl: Use larger URB size where available.

On Fri, Sep 11, 2015 at 12:12:15PM -0700, Jordan Justen wrote: > On 2015-09-10 16:59:12, Ben Widawsky wrote: > > All SKL SKUs except the lowest one which has half the L3 size actually have > > 384K > > These commit message lines seem to wrap a bit long. This first line is > 80 characters. > > >

Re: [Mesa-dev] i965: L3 cache partitioning.

On Fri, Sep 11, 2015 at 11:37:21AM -0700, Ben Widawsky wrote: > On Fri, Sep 11, 2015 at 10:24:29AM -0700, Ben Widawsky wrote: > > On Sun, Sep 06, 2015 at 06:12:38PM +0200, Francisco Jerez wrote: > > > This series implements dynamic partitioning of the L3 cache space > > > among its clients, the

Re: [Mesa-dev] [PATCH] i965/skl: Use larger URB size where available.

On 2015-09-10 16:59:12, Ben Widawsky wrote: > All SKL SKUs except the lowest one which has half the L3 size actually have > 384K These commit message lines seem to wrap a bit long. This first line is 80 characters. > of URB per slice. > > For once, I can explain how this mistake was made and

Re: [Mesa-dev] [PATCH V3 1/6] glsl: order indices for samplers inside a struct array

On Thu, 2015-09-10 at 21:36 -0700, Jason Ekstrand wrote: > On Thu, Sep 10, 2015 at 7:43 PM, Timothy Arceri < > t_arc...@yahoo.com.au> wrote: > > On Tue, 2015-09-08 at 14:14 -0700, Jason Ekstrand wrote: > > > On Mon, Sep 7, 2015 at 3:09 PM, Timothy Arceri < > > > t_arc...@yahoo.com.au > > > >

Re: [Mesa-dev] [PATCH 1/7] softpipe: Move the faces array from view to filter_args

On Fri, Sep 11, 2015 at 11:57 PM, Emil Velikov wrote: > On 11 September 2015 at 19:07, Krzesimir Nowak > wrote: > > With that, sp_sampler_view instances are not abused anymore as a local > > storage, so we can later make them constant. > > --- > >

Re: [Mesa-dev] [PATCH v2 3/3] glsl/cs: Initialize gl_GlobalInvocationID in main()

On 2015-09-10 05:48:50, Alejandro Piñeiro wrote: > Not a full review, but a comment. See inline. > > On 23/08/15 09:09, Jordan Justen wrote: > > We initialize gl_GlobalInvocationID based on the extension spec > > formula: > > > > gl_GlobalInvocationID = > > gl_WorkGroupID *

Re: [Mesa-dev] [RFC 2/3] nir: Add a pass to rewrite uses of vecN sources to the vecN destination

Given that coalescing seems to be hard, I'm bumping this series from RFC to PATCH. It's kinda nuts, but seems fairly effective. --Jason On Tue, Sep 8, 2015 at 5:35 PM, Jason Ekstrand wrote: > --- > src/glsl/Makefile.sources| 1 + > src/glsl/nir/nir.h

[Mesa-dev] [PATCH v2 4/5] r600g: add support for TXQS tgsi opcode

Signed-off-by: Ilia Mirkin Reviewed-by: Glenn Kennard --- src/gallium/drivers/r600/r600_pipe.c | 2 +- src/gallium/drivers/r600/r600_shader.c | 16 2 files changed, 13 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH v2 1/5] tgsi: add a TXQS opcode to retrieve the number of texture samples

Signed-off-by: Ilia Mirkin Reviewed-by: Roland Scheidegger Reviewed-by: Edward O'Callaghan --- src/gallium/auxiliary/tgsi/tgsi_info.c | 3 ++- src/gallium/docs/source/tgsi.rst | 12 +++-

[Mesa-dev] [PATCH v2 3/5] nv50/ir: add support for TXQS tgsi opcode

Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 4 ++-- .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 22 +- .../nouveau/codegen/nv50_ir_lowering_nv50.cpp | 20

[Mesa-dev] [PATCH v2 0/5] gallium: add support for retrieving number of texture samples

OK, I've added a PIPE_CAP to control it now. I've left the relevant R-b's from v1 in place despite a few changes, I think they're minor enough. Ilia Mirkin (5): tgsi: add a TXQS opcode to retrieve the number of texture samples gallium: add PIPE_CAP_TGSI_TXQS to let st know if TXQS is

[Mesa-dev] [PATCH v2 5/5] st/mesa: emit TXQS, support ARB_shader_texture_image_samples

The image component of the ext is a no-op since there is no image support in gallium (yet). Signed-off-by: Ilia Mirkin Reviewed-by: Edward O'Callaghan Reviewed-by: Brian Paul --- docs/GL3.txt

[Mesa-dev] [PATCH v2 2/5] gallium: add PIPE_CAP_TGSI_TXQS to let st know if TXQS is supported

Signed-off-by: Ilia Mirkin --- src/gallium/docs/source/screen.rst | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/ilo/ilo_screen.c | 1 +

Re: [Mesa-dev] i965: Turn UBOs as push constants

On Fri, Sep 11, 2015 at 11:33:14AM +0300, Abdiel Janulgue wrote: > Some updated figures first: > > Ue4 Reflections Subway demo > x fs gather constants disabled > + fs gather constants enabled > > HSW: > N Min MaxMedian AvgStddev > x 10

Re: [Mesa-dev] [PATCH 0/7] Const fixes/cleanups in softpipe's tex samplers

On 09/11/2015 12:07 PM, Krzesimir Nowak wrote: This stops abusing sp_sampler_view as a local storage and thus allowing to put some more const modifiers in front of some types. I might have gotten carried away too bit with the last commit. :) So if you don't like it, then please ignore it.

Re: [Mesa-dev] [PATCH 7/7] softpipe: Constify variables

Honestly, I don't see much point of constifying simple one-time-assigned local variables (won't make a difference to the compiler anyway, and even for reading imho doesn't add much). I don't object changing it though, and the rest of the series definitely looks good to me, I'm glad you got rid of

Re: [Mesa-dev] [PATCH 1/7] softpipe: Move the faces array from view to filter_args

On 11 September 2015 at 19:07, Krzesimir Nowak wrote: > With that, sp_sampler_view instances are not abused anymore as a local > storage, so we can later make them constant. > --- > src/gallium/drivers/softpipe/sp_tex_sample.c | 36 > +--- >

Re: [Mesa-dev] [PATCH 2/6] mesa/glformats: restrict ETC1_RGB8 support to GLES1/2

On Fri, Aug 28, 2015 at 7:50 AM, Nanley Chery wrote: > From: Nanley Chery > > According to the extensions table and our glext headers, > OES_compressed_ETC1_RGB8_texture is only supported in > GLES1 and GLES2. > > Signed-off-by: Nanley Chery

Re: [Mesa-dev] [PATCH 1/7] softpipe: Move the faces array from view to filter_args

On 09/11/2015 04:49 PM, Krzesimir Nowak wrote: On Fri, Sep 11, 2015 at 11:57 PM, Emil Velikov > wrote: On 11 September 2015 at 19:07, Krzesimir Nowak > wrote: > With that,

Re: [Mesa-dev] [PATCH] ralloc: Use __attribute__((destructor)) instead of atexit(3)

On 11/09/15 00:35, Erik Faye-Lund wrote: On Mon, Sep 7, 2015 at 3:54 PM, Jose Fonseca wrote: On 07/09/15 10:17, Jean-Sébastien Pédron wrote: On 04.09.2015 01:37, Matt Turner wrote: You need to test for this support in configure.ac. It's as simple as adding a call to

Re: [Mesa-dev] [PATCH 1/4] tgsi: add a TXQS opcode to retrieve the number of texture samples

Am 11.09.2015 um 05:15 schrieb Ilia Mirkin: > Signed-off-by: Ilia Mirkin > --- > src/gallium/auxiliary/tgsi/tgsi_info.c | 3 ++- > src/gallium/docs/source/tgsi.rst | 12 +++- > src/gallium/include/pipe/p_shader_tokens.h | 1 + > 3 files changed, 14

Re: [Mesa-dev] [PATCH 1/2] r600g: Support I2D/U2D/D2I/D2U

Am 11.09.2015 um 05:14 schrieb Dave Airlie: > On 11 September 2015 at 12:37, Roland Scheidegger wrote: >> Just on a very quick glance, seems somewhat odd this function is named >> "cypress" whereas the other 64bit ones are named "cayman". >> In any case, saying enabling

Re: [Mesa-dev] [PATCH] i965/vec4: check writemask when bailing out at register coalesce

On Fri, Sep 11, 2015 at 5:18 AM, Alejandro Piñeiro wrote: > opt_register_coalesce stopped to check previous instructions to > coalesce with if somebody else was writing on the same > destination. This can be optimized to check if somebody else was > writing to the same

Re: [Mesa-dev] [PATCH 08/11] i965/vec4_nir: Use partial SSA form rather than full non-SSA

On 09/10/2015 02:50 AM, Jason Ekstrand wrote: > We made this switch in the FS backend some time ago and it seems to make a > number of things a bit easier. > The commit log could be a bit less abstract, like mentioning why this change helps the subsequent passes. In any case, if it was only for

Re: [Mesa-dev] [PATCH v2] i915: fixing driver crashes if too few vertices are submitted

> -Original Message- > From: Ian Romanick [mailto:i...@freedesktop.org] > Sent: Wednesday, September 09, 2015 8:54 PM > To: Predut, Marius; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v2] i915: fixing driver crashes if too few > vertices are submitted > > On

[Mesa-dev] [PATCH v2 2/2] r600: Enable fp64 on chips with native support

Cypress/Cayman/Aruba, earlier r6xx/r7xx chips only support a subset of the needed fp64 ops, and don't do GL4 anyway. Signed-off-by: Glenn Kennard --- Changes since v1: Updated commit message docs/GL3.txt | 4 ++-- docs/relnotes/11.1.0.html

[Mesa-dev] [PATCH v2 1/2] r600g: Support I2D/U2D/D2I/D2U

Only for Cypress/Cayman/Aruba, older chips have only partial fp64 support. Uses float intermediate values so only accurate for int24 range, which matches what the blob does. Signed-off-by: Glenn Kennard --- Changes since v1: Split into two functions Make names a bit

Re: [Mesa-dev] [PATCH v1] i915: fixing driver crashes if too few vertices are submitted

> -Original Message- > From: Eirik Byrkjeflot Anonsen [mailto:ei...@eirikba.org] > Sent: Wednesday, September 09, 2015 9:18 PM > To: Predut, Marius; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v1] i915: fixing driver crashes if too few > vertices are submitted > >

Re: [Mesa-dev] [PATCH] nir: Fix output variable names

On Fri, 2015-09-11 at 09:24 +0200, Eduardo Lima Mitev wrote: > Commit 1dbe4af9c9e318525fc082b542b93fb7f1e5efba > "nir: Add a pass to lower outputs to temporary variables" messed up output > variable names. The issue can be reproduced by dumping the NIR shaders > with INTEL_DEBUG="vs,fs". > --- >

[Mesa-dev] [PATCH] i965/vec4: check writemask when bailing out at register coalesce

opt_register_coalesce stopped to check previous instructions to coalesce with if somebody else was writing on the same destination. This can be optimized to check if somebody else was writing to the same channels of the same destination using the writemask. Shader DB results (taking into account

Re: [Mesa-dev] [PATCH 1/2] r600: define some values for the fetch constant offsets.

Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Fri, Sep 11, 2015, at 02:43 PM, Dave Airlie wrote: > From: Dave Airlie > > This just puts these in one place and #defines them. > > Signed-off-by: Dave

Re: [Mesa-dev] [PATCH 2/4] svga: remove useless MAX2() call

Reviewed-by: Iago Toral Quiroga On Thu, 2015-09-10 at 09:04 -0600, Brian Paul wrote: > The sum of two unsigned ints is always >= 0. Found with Coverity. > --- > src/gallium/drivers/svga/svga_state_tss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH v2] i915: fixing driver crashes if too few vertices are submitted

On 09/11/2015 03:41 AM, Predut, Marius wrote: > > >> -Original Message- >> From: Ian Romanick [mailto:i...@freedesktop.org] >> Sent: Wednesday, September 09, 2015 8:54 PM >> To: Predut, Marius; mesa-dev@lists.freedesktop.org >> Subject: Re: [Mesa-dev] [PATCH v2] i915: fixing driver

Re: [Mesa-dev] [PATCH v3 2/4] nvc0: add support for st/va

On Mon, Sep 7, 2015 at 8:15 AM, Julien Isorce wrote: > - split nvc0_decoder_bsp in begin/next/end > - preserve content buffer when calling nvc0_decoder_bsp_next > - implement pipe_video_codec::begin_frame/end_frame > > https://bugs.freedesktop.org/show_bug.cgi?id=89969 > >

Re: [Mesa-dev] [PATCH v3 2/4] nvc0: add support for st/va

On Fri, Sep 11, 2015 at 7:54 PM, Ilia Mirkin wrote: > On Mon, Sep 7, 2015 at 8:15 AM, Julien Isorce wrote: >> - split nvc0_decoder_bsp in begin/next/end >> - preserve content buffer when calling nvc0_decoder_bsp_next >> - implement

[Mesa-dev] [PATCH] gbm: Add a flag to enable creation of rotated scanout buffers

For certain platforms that support rotated scanout buffers, currently, there is no way to create them with the GBM DRI interface. This flag will tell the DRI driver to set Y-tiling while creating the rotated scanout buffer. Cc: Matthew D Roper Signed-off-by: Vivek

Re: [Mesa-dev] [PATCH v3] i915: fixing driver crashes if too few vertices are submitted

On 09/11/2015 10:55 AM, Ilia Mirkin wrote: > On Fri, Sep 11, 2015 at 12:36 PM, Marius Predut > wrote: >> Comparison with a signed expression and unsigned value >> is converted to unsigned value, reason for minus value is interpreted >> as a big unsigned value. For this

Re: [Mesa-dev] [PATCH 0/4] gallium: add support for retrieving number of texture samples

Am 11.09.2015 um 05:15 schrieb Ilia Mirkin: > My hope was (as you can see in the last patch) to enable this for all > drivers that support MS textures. I've got nv50/nvc0/r600g covered. > > RadeonSI will have to read the data from the texture descriptor. I'm > totally unfamiliar with LLVM, the

Re: [Mesa-dev] [PATCH] nir: Fix output variable names

Oops, I missed a patch from Jason from two days ago, fixing exactly the same thing. http://lists.freedesktop.org/archives/mesa-dev/2015-September/094107.html Please ignore this one. Eduardo On 09/11/2015 09:24 AM, Eduardo Lima Mitev wrote: > Commit 1dbe4af9c9e318525fc082b542b93fb7f1e5efba >

Re: [Mesa-dev] [PATCH] nir/lower_outputs_to_temporaries: Reparent the output name

Reviewed-by: Eduardo Lima Mitev On 09/10/2015 10:58 PM, Jason Ekstrand wrote: > We copy the output, make the old output the temporary, and give the > temporary a new name. The copy keeps the pointer to the old name. This > works just fine up until the point where we lower

[Mesa-dev] nv3x xfce4 compositing issue, making good progress, need help / input

Hi, I've been working on trying to fix this one: https://bugs.freedesktop.org/show_bug.cgi?id=90871 And today I've more or less root caused this, it seems that some code is making glTexImage2D calls with npot width / height, which fails on nv3x (where as it works on nv4x). The bug has a

Re: [Mesa-dev] [PATCH] vc4: Try to pair up instructions when only one of them has PM bit

2015-08-30 15:07 GMT+08:00 Boyan Ding : > Instructions with difference in PM field can actually be paired up if > the one without PM doesn't do packing/unpacking and non-NOP > packing/unpacking operations from PM instruction aren't added to the > other without PM. > > total

Re: [Mesa-dev] [PATCH 4/4] st/mesa: emit TXQS, support ARB_shader_texture_image_samples

On 09/10/2015 09:15 PM, Ilia Mirkin wrote: This is enabled for all drivers that support MS textures. The image component of the ext is a no-op since there is no image support in gallium (yet). Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_extensions.c | 1

Re: [Mesa-dev] [PATCH 1/4] tgsi: add a TXQS opcode to retrieve the number of texture samples

On 09/10/2015 09:15 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_info.c | 3 ++- src/gallium/docs/source/tgsi.rst | 12 +++- src/gallium/include/pipe/p_shader_tokens.h | 1 + 3 files changed, 14

Re: [Mesa-dev] [PATCH 0/4] gallium: add support for retrieving number of texture samples

On 09/11/2015 07:26 AM, Roland Scheidegger wrote: Am 11.09.2015 um 05:15 schrieb Ilia Mirkin: My hope was (as you can see in the last patch) to enable this for all drivers that support MS textures. I've got nv50/nvc0/r600g covered. RadeonSI will have to read the data from the texture

  1   2   >