Re: [Mesa-dev] [PATCH] egl/dri2: don't require a context for ClientWaitSync (v2)

On 27/09/15 19:21, Marek Olšák wrote: > From: Marek Olšák > > The spec doesn't require it. This fixes a crash on Android. > > v2: don't set any flags if ctx == NULL > > Cc: 10.6 11.0 > --- > src/egl/drivers/dri2/egl_dri2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --gi

Re: [Mesa-dev] ssbo support missing imin/umin dinstinction

On Fri, 2015-09-25 at 21:15 -0400, Ilia Mirkin wrote: > Hi Samuel, > > It seems like there's only a single atomic_min intrinsic for ssbo > (same for max), but the ssbo spec actually calls for both signed and > unsigned semantics: > > uint atomicMin(inout uint mem, uint data); > in

Re: [Mesa-dev] [PATCH 8/8] radeonsi: dump buffer lists while debugging

On Mon, Sep 28, 2015 at 3:38 AM, Michel Dänzer wrote: > On 28.09.2015 07:53, Marek Olšák wrote: >> + /* Note: Buffer sizes are expected to be aligned to 4k by the >> winsys. */ >> + const unsigned page_size = 4096; > > This stems from TTM; it requires BOs to be aligned to

[Mesa-dev] [PATCH] main: replace str*dup() by str*cpy() to be compliant with C89, C99.

Fix SCons MinGW build error: Compiling src/mesa/main/shader_query.cpp ... src/mesa/main/shader_query.cpp: In function ‘char* get_top_level_name(const char*)’: src/mesa/main/shader_query.cpp:841:34: error: ‘strndup’ was not declared in this scope return strndup(name, name_size);

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

On Mon, Sep 28, 2015 at 7:20 AM, Albert Freeman wrote: > On 28 September 2015 at 14:38, Albert Freeman > wrote: >> On 28 September 2015 at 04:12, Emil Velikov wrote: >>> On 26 September 2015 at 00:49, Marek Olšák wrote: From: Marek Olšák The spec doesn't require it. This fixes

[Mesa-dev] [Bug 92124] shader_query.cpp:841:34: error: ‘strndup’ was not declared in this scope

https://bugs.freedesktop.org/show_bug.cgi?id=92124 --- Comment #3 from Samuel Iglesias --- Patch sent for review: http://lists.freedesktop.org/archives/mesa-dev/2015-September/095514.html Vinson, Would you mind testing it with SCons on MinGW? -- You are receiving this mail because: You are th

Re: [Mesa-dev] [PATCH] st/dri: Use packed RGB formats

On 02.09.2015 01:49, Ilia Mirkin wrote: > On Mon, Aug 10, 2015 at 5:44 AM, Michel Dänzer wrote: >> >> diff --git a/src/gallium/state_trackers/dri/dri_drawable.c >> b/src/gallium/state_trackers/dri/dri_drawable.c >> index 0d2929a..f0cc4a2 100644 >> --- a/src/gallium/state_trackers/dri/dri_drawable

[Mesa-dev] [PATCH] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

NIR is typeless so this is the only way to keep track of the type to select the proper atomic to use. --- I decided to squash the i965 changes in because otherwise we would break the build between the nir and i965 patches. Let me know if we rather split them anyway. src/glsl/nir/glsl_to_nir.cpp

[Mesa-dev] i965/vec4 (nir): Plan to implement cmod_propagation on vec4

Hi, TL;DR: as there are several people working on improving the shader quality at vec4 using NIR, to avoid overlapping, Im explicitly announcing that this week I will work on implement an equivalent to fs_cmod_propagation but for the vec4 case. More details: While checking shader-db HURT regres

Re: [Mesa-dev] [PATCH 09/12] i965/fs/skl+: Fix calculating gl_SampleID for 16x MSAA

Anuj Phogat writes: > As per docs we're supposed to get the per slot SampleID written to > 15:0 bits in R1.0. I used SSPI to compute the SampleID because I never > got anything useful in these bits on IVB. Things might have changed on > later platforms. So, I think it's worth trying to do what do

[Mesa-dev] [PATCH] mesa: fix GetProgramiv/GetActiveAttrib regression

Commit 4639cea2921669527eb43dcb49724c05afb27e8e added packed varyings as part of program resource list. We need to take this to account with all functions dealing with active input attributes. Patch fixes the issue by adding additional check to is_active_attrib and iterating active attribs explici

[Mesa-dev] [Bug 92122] [bisected] Regression with Assault Android Cactus

https://bugs.freedesktop.org/show_bug.cgi?id=92122 --- Comment #6 from Daniel Scharrer --- I can confirm that your patch fixes the issue with the full game as well. -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-d

Re: [Mesa-dev] Returning 0 from std430_base_alignment

On 26/09/15 19:42, Ilia Mirkin wrote: > Hi Samuel, > > Coverity is up in a tizzy because std430_base_alignment can return 0 > (which in turn would cause tons of errors since it's used with > glsl_align). Is there a better starting value that can be used for its > is_record() case? For std140 it'

Re: [Mesa-dev] [PATCH 2/6] mesa: rename gl_shader_program's NumUniformBlocks to NumUniformShaderStorageBlocks

On 26/09/15 09:51, Jordan Justen wrote: > On 2015-09-25 01:24:46, Samuel Iglesias Gonsalvez wrote: >> Because it counts shader storage blocks too. >> >> Signed-off-by: Samuel Iglesias Gonsalvez >> --- >> src/glsl/link_uniform_initializers.cpp | 2 +- >> src/glsl/link_uniforms.cpp

Re: [Mesa-dev] [PATCH 3/6] glsl: return the number of uniform blocks in error message

On 27/09/15 23:05, Timothy Arceri wrote: > On Fri, 2015-09-25 at 10:24 +0200, Samuel Iglesias Gonsalvez wrote: >> Signed-off-by: Samuel Iglesias Gonsalvez > > Maybe change the commit message to something like: > > glsl: use correct number of uniform blocks in error message > > Otherwise: > >

Re: [Mesa-dev] [PATCH 6/6] docs: mention ARB_shader_storage_buffer_object on 11.1.0 release notes

On 27/09/15 23:06, Timothy Arceri wrote: > On Fri, 2015-09-25 at 10:24 +0200, Samuel Iglesias Gonsalvez wrote: >> Signed-off-by: Samuel Iglesias Gonsalvez > > Reviewed-by: Timothy Arceri > Thanks! Sam >> --- >> docs/relnotes/11.1.0.html | 1 + >> 1 file changed, 1 insertion(+) >> >> diff -

Re: [Mesa-dev] [PATCH v5 45/70] glsl: atomic counters can be declared as buffer-qualified variables

Iago Toral Quiroga writes: > From: Kristian Høgsberg > > --- > src/glsl/ast_to_hir.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp > index 566cc87..a364aae 100644 > --- a/src/glsl/ast_to_hir.cpp > +++ b/src/gls

Re: [Mesa-dev] [PATCH 1/6] main: fix ACTIVE_UNIFORM_BLOCKS value

On 27/09/15 23:15, Timothy Arceri wrote: > On Fri, 2015-09-25 at 10:24 +0200, Samuel Iglesias Gonsalvez wrote: >> NumUniformBlocks also counts shader storage blocks. >> NumUniformBlocks variable will be renamed in a later patch to avoid >> misunderstandings. >> >> Signed-off-by: Samuel Iglesias G

Re: [Mesa-dev] [PATCH 1/6] main: fix ACTIVE_UNIFORM_BLOCKS value

On 28/09/15 12:39, Samuel Iglesias Gonsálvez wrote: > > > On 27/09/15 23:15, Timothy Arceri wrote: >> On Fri, 2015-09-25 at 10:24 +0200, Samuel Iglesias Gonsalvez wrote: >>> NumUniformBlocks also counts shader storage blocks. >>> NumUniformBlocks variable will be renamed in a later patch to avo

[Mesa-dev] [PATCH] mesa: fix ARRAY_SIZE query for GetProgramResourceiv

Patch also refactors name length queries which were using array size in computation, this has to be done in same time to avoid regression in arb_program_interface_query-resource-query Piglit test. Fixes rest of the failures with ES31-CTS.program_interface_query.no-locations v2: make additional

[Mesa-dev] [PATCH 2/3] glsl: Fix null return coverity warning

Add an assert on the result of as_dereference() not being NULL: >>> CID 1324978: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a null pointer "deref_record->record->as_dereference()". Since we are introducing a new variable to hold the result of as_dereference(), take the o

[Mesa-dev] [PATCH 1/3] glsl: Fix unused value warning reported by Coverity

We don't use param in this part of the code, so no point in advancing the pointer forward: >>> CID 1324983: Code maintainability issues (UNUSED_VALUE) >>> Assigning value from "param->get_next()" to "param" here, but that >>> stored value is overwritten before it can be used. --- src/g

[Mesa-dev] [PATCH 3/3] glsl: Fix forward NULL dereference coverity warning

The comment says that it should be impossible for decl_type to be NULL here, so don't try to handle the case where it is, simply add an assert. >>> CID 1324977: Null pointer dereferences (FORWARD_NULL) >>> Comparing "decl_type" to null implies that "decl_type" might be null. No piglit r

Re: [Mesa-dev] [PATCH 3/3] glsl: Fix forward NULL dereference coverity warning

Ian, you wrote the original code, so you might want to have a look at this one just in case I missed something even if piglit does not complain. In any case, I guess that either the code or the comment should be fixed. Iago On Mon, 2015-09-28 at 12:59 +0200, Iago Toral Quiroga wrote: > The commen

Re: [Mesa-dev] [PATCH 3/3] glsl: Fix forward NULL dereference coverity warning

CCing Ian... On Mon, 2015-09-28 at 13:02 +0200, Iago Toral wrote: > Ian, you wrote the original code, so you might want to have a look at > this one just in case I missed something even if piglit does not > complain. In any case, I guess that either the code or the comment > should be fixed. > >

[Mesa-dev] [Bug 90121] All OpenCL samples are failing with clGetPlatformID

https://bugs.freedesktop.org/show_bug.cgi?id=90121 Serge Martin changed: What|Removed |Added CC||edb+freedesk...@sigluy.net Compo

[Mesa-dev] [PATCH] i965: store reference to the context within struct brw_fence

As the spec allows for {server,client}_wait_sync to be called without currently bound context, while our implementation requires context pointer. UNTESTED. Cc: Chad Versace Cc: Marek Olšák Cc: Chih-Wei Huang Cc: Mauro Rossi Cc: 10.6 11.0 Signed-off-by: Emil Velikov --- Upon second thought

Re: [Mesa-dev] [PATCH] main: replace str*dup() by str*cpy() to be compliant with C89, C99.

On 28/09/15 09:09, Samuel Iglesias Gonsalvez wrote: Fix SCons MinGW build error: Compiling src/mesa/main/shader_query.cpp ... src/mesa/main/shader_query.cpp: In function ‘char* get_top_level_name(const char*)’: src/mesa/main/shader_query.cpp:841:34: error: ‘strndup’ was not declared in this sc

Re: [Mesa-dev] [PATCH v5 45/70] glsl: atomic counters can be declared as buffer-qualified variables

On Mon, 2015-09-28 at 13:13 +0300, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > From: Kristian Høgsberg > > > > --- > > src/glsl/ast_to_hir.cpp | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp > >

Re: [Mesa-dev] [PATCH] main: replace str*dup() by str*cpy() to be compliant with C89, C99.

On 28/09/15 13:34, Jose Fonseca wrote: > On 28/09/15 09:09, Samuel Iglesias Gonsalvez wrote: >> Fix SCons MinGW build error: >> >> Compiling src/mesa/main/shader_query.cpp ... >> src/mesa/main/shader_query.cpp: In function ‘char* >> get_top_level_name(const char*)’: >> src/mesa/main/shader_query.

[Mesa-dev] [Bug 92124] shader_query.cpp:841:34: error: ‘strndup’ was not declared in this scope

https://bugs.freedesktop.org/show_bug.cgi?id=92124 --- Comment #4 from Samuel Iglesias --- As commented here [0], I will create a different patch to tackle this issue. [0] http://lists.freedesktop.org/archives/mesa-dev/2015-September/095540.html -- You are receiving this mail because: You are

Re: [Mesa-dev] [PATCH v5 45/70] glsl: atomic counters can be declared as buffer-qualified variables

On Mon, 2015-09-28 at 13:45 +0200, Iago Toral wrote: > On Mon, 2015-09-28 at 13:13 +0300, Francisco Jerez wrote: > > Iago Toral Quiroga writes: > > > > > From: Kristian Høgsberg > > > > > > --- > > > src/glsl/ast_to_hir.cpp | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > >

Re: [Mesa-dev] [PATCH v5 45/70] glsl: atomic counters can be declared as buffer-qualified variables

Iago Toral writes: > On Mon, 2015-09-28 at 13:45 +0200, Iago Toral wrote: >> On Mon, 2015-09-28 at 13:13 +0300, Francisco Jerez wrote: >> > Iago Toral Quiroga writes: >> > >> > > From: Kristian Høgsberg >> > > >> > > --- >> > > src/glsl/ast_to_hir.cpp | 6 +++--- >> > > 1 file changed, 3 inse

Re: [Mesa-dev] [PATCH 1/6] main: fix ACTIVE_UNIFORM_BLOCKS value

On Mon, 2015-09-28 at 12:46 +0200, Samuel Iglesias Gonsálvez wrote: > > On 28/09/15 12:39, Samuel Iglesias Gonsálvez wrote: > > > > > > On 27/09/15 23:15, Timothy Arceri wrote: > > > On Fri, 2015-09-25 at 10:24 +0200, Samuel Iglesias Gonsalvez > > > wrote: > > > > NumUniformBlocks also counts sh

Re: [Mesa-dev] [PATCH v5 45/70] glsl: atomic counters can be declared as buffer-qualified variables

Iago Toral writes: > On Mon, 2015-09-28 at 13:13 +0300, Francisco Jerez wrote: >> Iago Toral Quiroga writes: >> >> > From: Kristian Høgsberg >> > >> > --- >> > src/glsl/ast_to_hir.cpp | 6 +++--- >> > 1 file changed, 3 insertions(+), 3 deletions(-) >> > >> > diff --git a/src/glsl/ast_to_hir.c

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

On 27/09/15 19:14, Marek Olšák wrote: Hi, For some reason, st/mesa assumes that shaders can't be shared by multiple contexts and therefore has a context pointer in shader keys. I'd like to get rid of this dependency, because there is no reason why shaders would need to be tied to a context. In f

Re: [Mesa-dev] [PATCH v5 45/70] glsl: atomic counters can be declared as buffer-qualified variables

On Mon, 2015-09-28 at 15:23 +0300, Francisco Jerez wrote: > Iago Toral writes: > > > On Mon, 2015-09-28 at 13:13 +0300, Francisco Jerez wrote: > >> Iago Toral Quiroga writes: > >> > >> > From: Kristian Høgsberg > >> > > >> > --- > >> > src/glsl/ast_to_hir.cpp | 6 +++--- > >> > 1 file changed

Re: [Mesa-dev] [PATCH] i965: store reference to the context within struct brw_fence

On Mon, Sep 28, 2015 at 1:29 PM, Emil Velikov wrote: > As the spec allows for {server,client}_wait_sync to be called without > currently bound context, while our implementation requires context > pointer. > > UNTESTED. > > Cc: Chad Versace > Cc: Marek Olšák > Cc: Chih-Wei Huang > Cc: Mauro Ross

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

On Mon, Sep 28, 2015 at 2:55 PM, Jose Fonseca wrote: > On 27/09/15 19:14, Marek Olšák wrote: >> >> Hi, >> >> For some reason, st/mesa assumes that shaders can't be shared by >> multiple contexts and therefore has a context pointer in shader keys. >> I'd like to get rid of this dependency, because

Re: [Mesa-dev] [PATCH] i965: store reference to the context within struct brw_fence

On 28 September 2015 at 14:15, Marek Olšák wrote: > On Mon, Sep 28, 2015 at 1:29 PM, Emil Velikov > wrote: >> As the spec allows for {server,client}_wait_sync to be called without >> currently bound context, while our implementation requires context >> pointer. >> >> UNTESTED. >> >> Cc: Chad Ver

Re: [Mesa-dev] nv3x xfce4 compositing issue, making good progress, need help / input

Hi, As always thanks for your input :) On 25-09-15 17:21, Ilia Mirkin wrote: On Fri, Sep 25, 2015 at 10:34 AM, Hans de Goede wrote: Hi, On 11-09-15 18:48, Ilia Mirkin wrote: On Fri, Sep 11, 2015 at 10:46 AM, Hans de Goede wrote: Hi, I've been working on trying to fix this one: https:/

Re: [Mesa-dev] [PATCH] configure.ac: handle llvm built with cmake in one shared library.

Hi Laurent, On 27 September 2015 at 13:21, Laurent Carlier wrote: > llvm can be built with cmake in a libray with the name libLLVM.so.$version > Do you know if this is intentional and consistent (i.e. all the build produce such library/ies) behaviour ? If so can you please rework the conditional

[Mesa-dev] [PATCH] util: implement strndup for WIN32

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92124 Cc: Jose Fonseca --- I tested it on MSVC but not MinGW. I hope I did not something wrong. src/mesa/main/shader_query.cpp | 1 + src/util/Makefile.sources | 1 + src/util/strndup.c | 47 ++

Re: [Mesa-dev] [PATCH 05/11] gallium: add PIPE_SHADER_CAP_MAX_BUFFERS

On 09/27/2015 12:33 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/freedreno/freedreno_screen

Re: [Mesa-dev] [PATCH 08/70] i965: Remove early release of DRI2 miptree

Hi all, On 17 August 2015 at 19:06, Chad Versace wrote: > On Fri 14 Aug 2015, Chris Wilson wrote: >> On Thu, Aug 13, 2015 at 09:58:52PM -0700, Kenneth Graunke wrote: >> > On Thursday, August 13, 2015 02:57:20 PM Martin Peres wrote: >> > > On 07/08/15 23:13, Chris Wilson wrote: >> > > > intel_upda

Re: [Mesa-dev] [PATCH 1/6] main: fix ACTIVE_UNIFORM_BLOCKS value

On 28/09/15 14:23, Timothy Arceri wrote: > On Mon, 2015-09-28 at 12:46 +0200, Samuel Iglesias Gonsálvez wrote: >> >> On 28/09/15 12:39, Samuel Iglesias Gonsálvez wrote: >>> >>> >>> On 27/09/15 23:15, Timothy Arceri wrote: On Fri, 2015-09-25 at 10:24 +0200, Samuel Iglesias Gonsalvez wrot

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

On Mon, Sep 28, 2015 at 8:55 AM, Jose Fonseca wrote: > > >> I see only 2 options out of this: >> >> 1) Removing the context pointer from the shader keys. If drivers need >> this, they should handle it by themselves. This will simplify st/mesa, >> because TCS, TES, GS won't need the variant-trackin

Re: [Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

Superficial comments below. On 09/27/2015 12:33 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/mesa/Makefile.sources| 1 + src/mesa/program/ir_to_mesa.cpp | 4 +- src/mesa/state_tracker/st_atom.c | 5 + src/mesa/state_tracker/s

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

Am 28.09.2015 um 15:51 schrieb Marek Olšák: > On Mon, Sep 28, 2015 at 2:55 PM, Jose Fonseca wrote: >> On 27/09/15 19:14, Marek Olšák wrote: >>> >>> Hi, >>> >>> For some reason, st/mesa assumes that shaders can't be shared by >>> multiple contexts and therefore has a context pointer in shader keys.

Re: [Mesa-dev] [PATCH 08/70] i965: Remove early release of DRI2 miptree

On 28/09/15 17:27, Emil Velikov wrote: Hi all, On 17 August 2015 at 19:06, Chad Versace wrote: On Fri 14 Aug 2015, Chris Wilson wrote: On Thu, Aug 13, 2015 at 09:58:52PM -0700, Kenneth Graunke wrote: On Thursday, August 13, 2015 02:57:20 PM Martin Peres wrote: On 07/08/15 23:13, Chris Wilso

Re: [Mesa-dev] i965/vec4 (nir): Plan to implement cmod_propagation on vec4

On Sep 28, 2015 2:09 AM, "Alejandro Piñeiro" wrote: > > Hi, > > TL;DR: > > as there are several people working on improving the shader quality at > vec4 using NIR, to avoid overlapping, Im explicitly announcing that this > week I will work on implement an equivalent to fs_cmod_propagation but > fo

Re: [Mesa-dev] nv3x xfce4 compositing issue, making good progress, need help / input

On Mon, Sep 28, 2015 at 10:14 AM, Hans de Goede wrote: > On 25-09-15 17:21, Ilia Mirkin wrote: >> Looking at the spec, it actually looks like you can drop >> GLX_TEXTURE_2D_BIT to make 2D textures go away, and mark them all RECT >> in bo_from_handle() [for nv3x only of course]. > > > Erm, unless I

Re: [Mesa-dev] [PATCH 05/11] gallium: add PIPE_SHADER_CAP_MAX_BUFFERS

On Mon, Sep 28, 2015 at 10:25 AM, Brian Paul wrote: > On 09/27/2015 12:33 AM, Ilia Mirkin wrote: >> >> Signed-off-by: Ilia Mirkin >> --- >> src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + >> src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + >> src/gallium/docs/source/screen.rst

Re: [Mesa-dev] i965/vec4 (nir): Plan to implement cmod_propagation on vec4

On 28/09/15 17:05, Jason Ekstrand wrote: > > > On Sep 28, 2015 2:09 AM, "Alejandro Piñeiro" > wrote: > > > > Hi, > > > > TL;DR: > > > > as there are several people working on improving the shader quality at > > vec4 using NIR, to avoid overlapping, Im explicitly anno

Re: [Mesa-dev] [PATCH v2 0/3] clover: implement clCreateImage

Serge Martin writes: > Francisco Jerez (1): > clover: Move down canonicalization of memory object flags into > validate_flags(). > > Serge Martin (2): > clover: implement clCreateImage > clover: implement clCreateImage?D w/ clCreateImage > Just pushed your patches, thanks. > src/gall

Re: [Mesa-dev] [PATCH] i965/vec4/nir: add nir_intrinsic_memory_barrier support

Samuel Iglesias Gonsalvez writes: > Fix OpenGL ES 3.1 conformance tests: advanced-readWrite-case1-vsfs > and advanced-matrix-vsfs. > > Signed-off-by: Samuel Iglesias Gonsalvez > Tested-by: Tapani Pälli > Cc: Francisco Jerez > --- > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 9 + > 1

Re: [Mesa-dev] Returning 0 from std430_base_alignment

On Mon, Sep 28, 2015 at 5:44 AM, Samuel Iglesias Gonsálvez wrote: > > > On 26/09/15 19:42, Ilia Mirkin wrote: >> Hi Samuel, >> >> Coverity is up in a tizzy because std430_base_alignment can return 0 >> (which in turn would cause tons of errors since it's used with >> glsl_align). Is there a better

Re: [Mesa-dev] [PATCH] util: implement strndup for WIN32

Samuel Iglesias Gonsalvez writes: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92124 > Cc: Jose Fonseca > --- > > I tested it on MSVC but not MinGW. I hope I did not something wrong. > > src/mesa/main/shader_query.cpp | 1 + > src/util/Makefile.sources | 1 + > src/util/strnd

Re: [Mesa-dev] [PATCH] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

On Mon, Sep 28, 2015 at 4:47 AM, Iago Toral Quiroga wrote: > NIR is typeless so this is the only way to keep track of the > type to select the proper atomic to use. > --- > I decided to squash the i965 changes in because otherwise we would break > the build between the nir and i965 patches. Let me

Re: [Mesa-dev] [PATCH] util: implement strndup for WIN32

Hi Samuel, On 28 September 2015 at 15:19, Samuel Iglesias Gonsalvez wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92124 > Cc: Jose Fonseca > --- > > I tested it on MSVC but not MinGW. I hope I did not something wrong. > > src/mesa/main/shader_query.cpp | 1 + > src/util/Makef

Re: [Mesa-dev] [PATCH 06/11] loader: use HAVE_LIBDRM instead of ! __NOT_HAVE_DRM_H

Hi Jeremy, On 27 September 2015 at 01:44, Jeremy Huddleston Sequoia wrote: > Sorry, been slammed and trying to catch up. I forget if I replied to this or > not, but if you're still waiting on me: > I'm afraid I pushed this patch already. Although if you notice any side effect on your platform d

Re: [Mesa-dev] mesa-10.6.8: ERROR on 'make distclean' when removing *.Plo files

On 25 September 2015 at 18:12, Sedat Dilek wrote: > On Fri, Sep 25, 2015 at 6:46 PM, Emil Velikov > wrote: >> On 25 September 2015 at 16:14, Sedat Dilek wrote: >>> On Fri, Sep 25, 2015 at 4:44 PM, Emil Velikov >>> wrote: On 25 September 2015 at 14:35, Sedat Dilek wrote: > On Fri, Se

Re: [Mesa-dev] glx-tls: Visibility hidden attribute and fix x86/x86_64 tls/tds entry points

On 26 September 2015 at 00:59, Sedat Dilek wrote: > Hi, > > unfortunately, we still have no cool upstream fix for > -fvisibility=hidden compiler flag handling. > There is still no visibility-attribute "hidden" available or defined. > These two are separate things, as Alan pointed out. The -fvisibi

Re: [Mesa-dev] [PATCH] st/dri: Use packed RGB formats

On Mon, Sep 28, 2015 at 4:40 AM, Michel Dänzer wrote: > On 02.09.2015 01:49, Ilia Mirkin wrote: >> On Mon, Aug 10, 2015 at 5:44 AM, Michel Dänzer wrote: >>> >>> diff --git a/src/gallium/state_trackers/dri/dri_drawable.c >>> b/src/gallium/state_trackers/dri/dri_drawable.c >>> index 0d2929a..f0cc4

Re: [Mesa-dev] [PATCH 1/2] glx: Fix build errors with --enable-mangling.

Hi Kyle, On 24 September 2015 at 23:22, Kyle Brenneman wrote: > Rearranged the GLX_ALIAS macro in glextensions.h so that it will pick up > the renames from glx_mangle.h. > > Fixed the alias attribute for glXGetProcAddress when USE_MGL_NAMESPACE is > defined. > > Bugzilla: https://bugs.freedesktop

Re: [Mesa-dev] [PATCH 2/2] mapi: Make _glapi_get_stub work with "gl" or "mgl" prefix.

On 24 September 2015 at 23:22, Kyle Brenneman wrote: > When USE_MGL_NAMESPACE is defined, _glapi_get_stub will check for the "m" > prefix before trying to skip it, so that "glFoo" and "mglFoo" are > equivalent. > > This should let it work with all the places where something calls > _glapi_get_proc

Re: [Mesa-dev] [PATCH 2/6] mesa: rename gl_shader_program's NumUniformBlocks to NumUniformShaderStorageBlocks

On 2015-09-28 02:55:48, Samuel Iglesias Gonsálvez wrote: > > > On 26/09/15 09:51, Jordan Justen wrote: > > On 2015-09-25 01:24:46, Samuel Iglesias Gonsalvez wrote: > >> Because it counts shader storage blocks too. > >> > >> Signed-off-by: Samuel Iglesias Gonsalvez > >> --- > >> src/glsl/link_un

Re: [Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver (v3)

Hi Kyle, On 25 September 2015 at 21:01, Kyle Brenneman wrote: > Add a macro GL_LIB_NAME to hold the filename that configure comes up with > based on the --with-gl-lib-name and --enable-mangling options. > > In driOpenDriver, use the GL_LIB_NAME macro instead of hard-coding > "libGL.so.1". > > v2:

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

I'll give it a go. It is still needed on OS X (and I think Windows). It's just not used by the X server any more. --Jeremy > On Sep 28, 2015, at 10:26, Arlie Davis wrote: > > I tried building Mesa on OS X, but I'm not nearly as familiar with > development on OS X, so I wasn't able to get it

Re: [Mesa-dev] [PATCH 1/2] gallivm: Allow drivers and state trackers to initialize gallivm LLVM targets

On 25 September 2015 at 14:55, Tom Stellard wrote: > On Thu, Sep 24, 2015 at 10:48:32PM +0100, Emil Velikov wrote: >> Hi Tom, >> >> On 24 September 2015 at 17:31, Tom Stellard wrote: >> > Drivers and state trackers that use LLVM for generating code, must >> > register the targets they use with LL

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

Tested-by: Mark Janes Eduardo Lima Mitev writes: > This is a new version of the series that attempt to fix the regression > reported at: > > https://bugs.freedesktop.org/show_bug.cgi?id=91582 > > The review by Jason helped me uncover the fact that the following 3 dEQP > tests are buggy: > > d

Re: [Mesa-dev] [PATCH 00/12] i965: Add support for 16x MSAA on SKL+

Neil Roberts writes: > The following tests are failing but on my SKL device the corresponding > tests with 8 samples are also failing. As far as I understand these > aren't known regressions for other people so it may be something to do > with my device being pre-production. It would be great if

[Mesa-dev] [PATCH 1/2] glx: Fix build errors with --enable-mangling (v2)

Rearranged the GLX_ALIAS macro in glextensions.h so that it will pick up the renames from glx_mangle.h. Fixed the alias attribute for glXGetProcAddress when USE_MGL_NAMESPACE is defined. v2: Add a comment clarifying why GLX_ALIAS needs two macros. Bugzilla: https://bugs.freedesktop.org/show_bug.

[Mesa-dev] [PATCH 2/2] mapi: Make _glapi_get_stub work with "gl" or "mgl" prefix.

When USE_MGL_NAMESPACE is defined, _glapi_get_stub will check for the "m" prefix before trying to skip it, so that "glFoo" and "mglFoo" are equivalent. This should let it work with all the places where something calls _glapi_get_proc_offset with a hard-coded name that starts with the normal "gl" p

[Mesa-dev] [PATCH] mesa/meta: Use interpolateAtSample for 16x MSAA copy blit

Previously there was a problem in i965 where if 16x MSAA is used then some of the sample positions are exactly on the 0 x or y axis. When the MSAA copy blit shader interpolates the texture coordinates at these sample positions it was possible that it would jump to a neighboring texel due to roundin

Re: [Mesa-dev] [PATCH] mesa/meta: Use interpolateAtSample for 16x MSAA copy blit

On Mon, Sep 28, 2015 at 11:00 AM, Neil Roberts wrote: > Previously there was a problem in i965 where if 16x MSAA is used then > some of the sample positions are exactly on the 0 x or y axis. When > the MSAA copy blit shader interpolates the texture coordinates at > these sample positions it was po

Re: [Mesa-dev] [PATCH 1/2] glx: Fix build errors with --enable-mangling.

On 09/28/2015 11:26 AM, Emil Velikov wrote: Hi Kyle, On 24 September 2015 at 23:22, Kyle Brenneman wrote: Rearranged the GLX_ALIAS macro in glextensions.h so that it will pick up the renames from glx_mangle.h. Fixed the alias attribute for glXGetProcAddress when USE_MGL_NAMESPACE is defined.

[Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver (v3)

Add a macro GL_LIB_NAME to hold the filename that configure comes up with based on the --with-gl-lib-name and --enable-mangling options. In driOpenDriver, use the GL_LIB_NAME macro instead of hard-coding "libGL.so.1". v2: Add an #ifndef/#define for GL_LIB_NAME so that non-autoconf builds will

Re: [Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver (v3)

On 09/28/2015 11:33 AM, Emil Velikov wrote: Hi Kyle, On 25 September 2015 at 21:01, Kyle Brenneman wrote: Add a macro GL_LIB_NAME to hold the filename that configure comes up with based on the --with-gl-lib-name and --enable-mangling options. In driOpenDriver, use the GL_LIB_NAME macro instea

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

Eduardo, Is there anything here still awaiting review? I thought I reviewed it all. --Jason On Mon, Sep 28, 2015 at 10:57 AM, Mark Janes wrote: > Tested-by: Mark Janes > > Eduardo Lima Mitev writes: > >> This is a new version of the series that attempt to fix the regression >> reported at: >>

Re: [Mesa-dev] [PATCH] mesa/meta: Use interpolateAtSample for 16x MSAA copy blit

A couple of fairly generic comments: - It is not at all clear to me why it's OK to interpolate at sample 0 -- this was previously interpolated at the sample, but apparently it doesn't matter where it's interpolated? Why not? [A future reader of the code might have a similar question.] - I think th

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

On 28/09/15 14:51, Marek Olšák wrote: On Mon, Sep 28, 2015 at 2:55 PM, Jose Fonseca wrote: On 27/09/15 19:14, Marek Olšák wrote: Hi, For some reason, st/mesa assumes that shaders can't be shared by multiple contexts and therefore has a context pointer in shader keys. I'd like to get rid of t

Re: [Mesa-dev] [PATCH] util: implement strndup for WIN32

Looks great Samuel. Just minor suggestions. Either way: Reviewed-by: Jose Fonseca On 28/09/15 15:19, Samuel Iglesias Gonsalvez wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92124 Cc: Jose Fonseca --- I tested it on MSVC but not MinGW. I hope I did not something wrong. s

Re: [Mesa-dev] [PATCH v5 2/3] mesa: Move _mesa_base_tex_format() from teximage to glformats files

Hi Eduardo, On 24 September 2015 at 09:57, Eduardo Lima Mitev wrote: > This function will be needed as part of validating the combination of format, > type and internal format of texture pixel operations, which happens in > glformats files. Specifically, we want to be able to obtain the base form

Re: [Mesa-dev] Pending issues of lollipop-x86

On Fri 25 Sep 2015, Chih-Wei Huang wrote: > CC to mesa-dev for help. > > 2015-09-25 22:12 GMT+08:00 Chih-Wei Huang : > > 2015-09-25 16:21 GMT+08:00 Chih-Wei Huang : > >> Actually I'm testing your mesa 11.0 branch > >> to see if it is acceptable. > >> The major issue I found is the > >> Camera and

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

On Mon, Sep 28, 2015 at 9:28 PM, Jose Fonseca wrote: > On 28/09/15 14:51, Marek Olšák wrote: >> >> On Mon, Sep 28, 2015 at 2:55 PM, Jose Fonseca wrote: >>> >>> On 27/09/15 19:14, Marek Olšák wrote: Hi, For some reason, st/mesa assumes that shaders can't be shared by

Re: [Mesa-dev] Pending issues of lollipop-x86

On Mon, Sep 28, 2015 at 10:19 PM, Chad Versace wrote: > On Fri 25 Sep 2015, Chih-Wei Huang wrote: >> CC to mesa-dev for help. >> >> 2015-09-25 22:12 GMT+08:00 Chih-Wei Huang : >> > 2015-09-25 16:21 GMT+08:00 Chih-Wei Huang : >> >> Actually I'm testing your mesa 11.0 branch >> >> to see if it is ac

Re: [Mesa-dev] [PATCH] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

On Mon, Sep 28, 2015 at 1:47 AM, Iago Toral Quiroga wrote: > NIR is typeless so this is the only way to keep track of the > type to select the proper atomic to use. > --- > I decided to squash the i965 changes in because otherwise we would break > the build between the nir and i965 patches. Let me

Re: [Mesa-dev] [PATCH] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

On Mon, Sep 28, 2015 at 4:55 PM, Kristian Høgsberg wrote: > On Mon, Sep 28, 2015 at 1:47 AM, Iago Toral Quiroga wrote: >> NIR is typeless so this is the only way to keep track of the >> type to select the proper atomic to use. >> --- >> I decided to squash the i965 changes in because otherwise we

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

On 09/28/2015 08:25 PM, Jason Ekstrand wrote: > Eduardo, > Is there anything here still awaiting review? I thought I reviewed it all. > --Jason > Hi, Sorry for the delays, I'm on holidays for a couple weeks. Jason, all patches in the series are reviewed by you. Thanks! Mark, I guess your Test

[Mesa-dev] [PATCH] nir: Don't set dest in SSBO store glsl_to_nir conversion

This matches the function signature created in lower_ubo_reference_visitor::ssbo_store which has a void return. Suggested-by: Jason Ekstrand Signed-off-by: Jordan Justen Cc: Samuel Iglesias Gonsalvez Cc: Jason Ekstrand --- src/glsl/nir/glsl_to_nir.cpp | 1 - 1 file changed, 1 deletion(-) dif

Re: [Mesa-dev] [PATCH] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

On Mon, Sep 28, 2015 at 1:59 PM, Ilia Mirkin wrote: > On Mon, Sep 28, 2015 at 4:55 PM, Kristian Høgsberg wrote: >> On Mon, Sep 28, 2015 at 1:47 AM, Iago Toral Quiroga >> wrote: >>> NIR is typeless so this is the only way to keep track of the >>> type to select the proper atomic to use. >>> ---

Re: [Mesa-dev] [PATCH 05/11] gallium: add PIPE_SHADER_CAP_MAX_BUFFERS

On 09/28/2015 09:20 AM, Ilia Mirkin wrote: On Mon, Sep 28, 2015 at 10:25 AM, Brian Paul wrote: On 09/27/2015 12:33 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + src/

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

On 28/09/15 21:21, Marek Olšák wrote: On Mon, Sep 28, 2015 at 9:28 PM, Jose Fonseca wrote: On 28/09/15 14:51, Marek Olšák wrote: On Mon, Sep 28, 2015 at 2:55 PM, Jose Fonseca wrote: On 27/09/15 19:14, Marek Olšák wrote: Hi, For some reason, st/mesa assumes that shaders can't be shared

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

On Mon, Sep 28, 2015 at 2:19 PM, Eduardo Lima Mitev wrote: > On 09/28/2015 08:25 PM, Jason Ekstrand wrote: >> Eduardo, >> Is there anything here still awaiting review? I thought I reviewed it all. >> --Jason >> > > Hi, > > Sorry for the delays, I'm on holidays for a couple weeks. > > Jason, all p

Re: [Mesa-dev] [PATCH] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

On Mon, Sep 28, 2015 at 1:59 PM, Ilia Mirkin wrote: > On Mon, Sep 28, 2015 at 4:55 PM, Kristian Høgsberg wrote: >> On Mon, Sep 28, 2015 at 1:47 AM, Iago Toral Quiroga >> wrote: >>> NIR is typeless so this is the only way to keep track of the >>> type to select the proper atomic to use. >>> ---

Re: [Mesa-dev] [PATCH] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

On Mon, Sep 28, 2015 at 6:07 PM, Kristian Høgsberg wrote: > On Mon, Sep 28, 2015 at 1:59 PM, Ilia Mirkin wrote: >> On Mon, Sep 28, 2015 at 4:55 PM, Kristian Høgsberg >> wrote: >>> On Mon, Sep 28, 2015 at 1:47 AM, Iago Toral Quiroga >>> wrote: NIR is typeless so this is the only way to ke

[Mesa-dev] [PATCH 2/4] i965: Move reads_flag()/writes_flag() to backend_instruction.

--- src/mesa/drivers/dri/i965/brw_fs.cpp| 15 --- src/mesa/drivers/dri/i965/brw_ir_fs.h | 3 --- src/mesa/drivers/dri/i965/brw_ir_vec4.h | 12 src/mesa/drivers/dri/i965/brw_shader.h | 13 + 4 files changed, 13 insertions(+), 30 deletions(-) diff --git

[Mesa-dev] [PATCH 3/4] i965: Add a pass to predicate short blocks.

total instructions in shared programs: 6496326 -> 6492315 (-0.06%) instructions in affected programs: 159282 -> 155271 (-2.52%) helped:411 --- src/mesa/drivers/dri/i965/Makefile.sources| 1 + src/mesa/drivers/dri/i965/brw_fs.cpp | 1 + s

[Mesa-dev] [PATCH 1/4] i965: Don't print line numbers with INTEL_DEBUG=optimizer.

The thing you want to do with the output files is diff them, which is made more difficult by line numbers changing. --- src/mesa/drivers/dri/i965/brw_shader.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dr

  1   2   >