Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

On Tue, Sep 29, 2015 at 2:48 AM, Timothy Arceri wrote: > On Tue, 2015-09-29 at 02:33 -0400, Ilia Mirkin wrote: >> On Tue, Sep 29, 2015 at 2:26 AM, Timothy Arceri < >> t_arc...@yahoo.com.au> wrote: >> > On Tue, 2015-09-29 at 02:08 -0400, Ilia Mirkin wrote: >> > > On Tue, Sep 29, 2015 at 2:05 AM, Ti

Re: [Mesa-dev] [PATCH] i965/vec4/nir: add nir_intrinsic_memory_barrier support

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 28/09/15 17:48, Francisco Jerez wrote: > Samuel Iglesias Gonsalvez writes: > >> Fix OpenGL ES 3.1 conformance tests: >> advanced-readWrite-case1-vsfs and advanced-matrix-vsfs. >> >> Signed-off-by: Samuel Iglesias Gonsalvez >> Tested-by: Tap

Re: [Mesa-dev] [PATCH] nir: Don't set dest in SSBO store glsl_to_nir conversion

On 28/09/15 23:47, Jordan Justen wrote: > This matches the function signature created in > lower_ubo_reference_visitor::ssbo_store which has a void return. True! Good catch. Reviewed-by: Samuel Iglesias Gonsálvez Thanks, Sam > > Suggested-by: Jason Ekstrand > Signed-off-by: Jordan Justen

Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

On Tue, 2015-09-29 at 02:33 -0400, Ilia Mirkin wrote: > On Tue, Sep 29, 2015 at 2:26 AM, Timothy Arceri < > t_arc...@yahoo.com.au> wrote: > > On Tue, 2015-09-29 at 02:08 -0400, Ilia Mirkin wrote: > > > On Tue, Sep 29, 2015 at 2:05 AM, Timothy Arceri < > > > t_arc...@yahoo.com.au> wrote: > > > > On

Re: [Mesa-dev] [PATCH 5/6] glsl: apply shader storage block member rules when adding program resources

On 28/09/15 00:05, Timothy Arceri wrote: > On Fri, 2015-09-25 at 10:24 +0200, Samuel Iglesias Gonsalvez wrote: >> From ARB_program_interface_query: >> >> "For an active shader storage block member declared as an array, an >> entry will be generated only for the first array element, regardless >>

Re: [Mesa-dev] [PATCH] util: implement strndup for WIN32

On 28/09/15 21:44, Jose Fonseca wrote: > Looks great Samuel. > > Just minor suggestions. > > Either way: > > Reviewed-by: Jose Fonseca > Thanks! > > On 28/09/15 15:19, Samuel Iglesias Gonsalvez wrote: >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92124 >> Cc: Jose Fonseca >>

Re: [Mesa-dev] [PATCH 25/24] glsl: add std140 layout support for AoA

On 29/09/15 08:34, Timothy Arceri wrote: > On Thu, 2015-09-24 at 11:31 +0200, Samuel Iglesias Gonsálvez wrote: >> >> On 24/09/15 02:16, Timothy Arceri wrote: >>> On Wed, 2015-09-23 at 13:21 +0200, Samuel Iglesias Gonsálvez wrote: On 22/09/15 15:30, Samuel Iglesias Gonsálvez wrote: > Revi

Re: [Mesa-dev] [PATCH] util: implement strndup for WIN32

On 28/09/15 18:14, Emil Velikov wrote: > Hi Samuel, > > On 28 September 2015 at 15:19, Samuel Iglesias Gonsalvez > wrote: >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92124 >> Cc: Jose Fonseca >> --- >> >> I tested it on MSVC but not MinGW. I hope I did not something wrong. >> >>

Re: [Mesa-dev] [PATCH 25/24] glsl: add std140 layout support for AoA

On Thu, 2015-09-24 at 11:31 +0200, Samuel Iglesias Gonsálvez wrote: > > On 24/09/15 02:16, Timothy Arceri wrote: > > On Wed, 2015-09-23 at 13:21 +0200, Samuel Iglesias Gonsálvez wrote: > > > On 22/09/15 15:30, Samuel Iglesias Gonsálvez wrote: > > > > Reviewed-by: Samuel Iglesias Gonsálvez > > > >

Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

On Tue, Sep 29, 2015 at 2:26 AM, Timothy Arceri wrote: > On Tue, 2015-09-29 at 02:08 -0400, Ilia Mirkin wrote: >> On Tue, Sep 29, 2015 at 2:05 AM, Timothy Arceri < >> t_arc...@yahoo.com.au> wrote: >> > On Tue, 2015-09-29 at 01:05 -0400, Ilia Mirkin wrote: >> > > On Mon, Sep 28, 2015 at 10:42 PM, T

Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

On Tue, 2015-09-29 at 02:08 -0400, Ilia Mirkin wrote: > On Tue, Sep 29, 2015 at 2:05 AM, Timothy Arceri < > t_arc...@yahoo.com.au> wrote: > > On Tue, 2015-09-29 at 01:05 -0400, Ilia Mirkin wrote: > > > On Mon, Sep 28, 2015 at 10:42 PM, Timothy Arceri < > > > t_arc...@yahoo.com.au> wrote: > > > > Si

Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

On Tue, Sep 29, 2015 at 2:05 AM, Timothy Arceri wrote: > On Tue, 2015-09-29 at 01:05 -0400, Ilia Mirkin wrote: >> On Mon, Sep 28, 2015 at 10:42 PM, Timothy Arceri < >> t_arc...@yahoo.com.au> wrote: >> > Since commit c0cd5b var->data.binding was being used as a >> > replacement >> > for atomic buff

Re: [Mesa-dev] List of unsupported extensions per driver

FMA isn't required really. R600 is mainly missing GS streams, which are complete on the mailing somewhere I think. Marek On Tue, Sep 29, 2015 at 7:32 AM, Romain Failliot wrote: > Hi! > > I'm diving into the unsupported extensions list and I'm wondering how is it > possible that GL_ARB_gpu_shader

[Mesa-dev] [PATCH] nir: Use a system value for gl_PrimitiveIDIn.

At least on Intel hardware, gl_PrimitiveIDIn comes in as a special part of the payload rather than a normal input. This is typically what we use system values for. Dave and Ilia also agree that a system value would be nicer. At some point, we should change it at the GLSL IR level as well. But t

Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

On Tue, 2015-09-29 at 01:05 -0400, Ilia Mirkin wrote: > On Mon, Sep 28, 2015 at 10:42 PM, Timothy Arceri < > t_arc...@yahoo.com.au> wrote: > > Since commit c0cd5b var->data.binding was being used as a > > replacement > > for atomic buffer index, but they don't have to be the same value > > they > >

Re: [Mesa-dev] List of unsupported extensions per driver

On Tue, Sep 29, 2015 at 1:32 AM, Romain Failliot wrote: > Hi! > > I'm diving into the unsupported extensions list and I'm wondering how is it > possible that GL_ARB_gpu_shader5 is unsupported for R600, but some of the > "sub-extensions" like "Dynamically uniform sampler array indices" are > suppor

Re: [Mesa-dev] List of unsupported extensions per driver

Hi! I'm diving into the unsupported extensions list and I'm wondering how is it possible that GL_ARB_gpu_shader5 is unsupported for R600, but some of the "sub-extensions" like "Dynamically uniform sampler array indices" are supported nonetheless. That makes me wonder if "not done" sub-extensions,

Re: [Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

On Mon, Sep 28, 2015 at 10:42 PM, Timothy Arceri wrote: > Since commit c0cd5b var->data.binding was being used as a replacement > for atomic buffer index, but they don't have to be the same value they > just happen to end up the same when binding is 0. > > Now that we store the atomic uniform loca

Re: [Mesa-dev] [PATCH 1/5] tgsi/scan: add interpolation info into tgsi_shader_info

On 29.09.2015 09:38, Marek Olšák wrote: > From: Marek Olšák The series is Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer __

[Mesa-dev] [PATCH V6 26/27] i965: enable ARB_arrays_of_arrays

Reviewed-by: Samuel Iglesias Gonsálvez --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 3c77f47..16b7019 100644 --- a/src/mesa/drivers/dri/i965/in

[Mesa-dev] [PATCH V6 10/27] i965: fix atomic buffer index for bindings other than 0

Since commit c0cd5b var->data.binding was being used as a replacement for atomic buffer index, but they don't have to be the same value they just happen to end up the same when binding is 0. Now that we store the atomic uniform location in var->data.location we can use this to lookup the atomic bu

[Mesa-dev] [PATCH V6 23/27] glsl: link uniform block arrays of arrays

This adds support for setting up the UniformBlock structures for AoA and also adds support for resizing AoA blocks with a packed layout. --- src/glsl/link_uniform_block_active_visitor.cpp | 168 - src/glsl/link_uniform_block_active_visitor.h | 13 +- src/glsl/link_unifor

[Mesa-dev] [PATCH V6 24/27] glsl: build ubo name and indexing offset for AoA

--- src/glsl/lower_ubo_reference.cpp | 119 --- 1 file changed, 87 insertions(+), 32 deletions(-) diff --git a/src/glsl/lower_ubo_reference.cpp b/src/glsl/lower_ubo_reference.cpp index 31885cd..2ed8c10 100644 --- a/src/glsl/lower_ubo_reference.cpp +++ b/src/gls

[Mesa-dev] [PATCH V6 14/27] glsl: add AoA support to subroutines

--- src/glsl/ast_function.cpp | 43 ++- src/glsl/lower_subroutine.cpp | 2 +- 2 files changed, 39 insertions(+), 6 deletions(-) diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp index cf4e64a..402180b 100644 --- a/src/glsl/ast_function

[Mesa-dev] [PATCH V6 11/27] glsl: calculate AoA uniform offset correctly for structs

This allows the correct offset to be calculated for use in indirect indexing of samplers. --- src/glsl/glsl_types.cpp | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_types.cpp index 0ead0f2..6664a47 100644 --- a/src/glsl/

[Mesa-dev] [PATCH V6 19/27] glsl: add AoA support for linking interface blocks with unsized members

--- src/glsl/ir.cpp | 4 ++-- src/glsl/linker.cpp | 9 + 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp index 2c45b9e..ee80abb 100644 --- a/src/glsl/ir.cpp +++ b/src/glsl/ir.cpp @@ -1673,8 +1673,8 @@ ir_variable::ir_variable(const struc

[Mesa-dev] [PATCH V6 16/27] glsl: set image access qualifiers for AoA

--- src/glsl/link_uniforms.cpp | 77 +- 1 file changed, 49 insertions(+), 28 deletions(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index f3508a3..ddf72d0 100644 --- a/src/glsl/link_uniforms.cpp +++ b/src/glsl/link_uniforms.cp

[Mesa-dev] [PATCH V6 15/27] i965: add arrays of arrays support for varyings

V2: get the correct vector elements value for outputs --- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 7 +++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs

[Mesa-dev] [PATCH V6 18/27] glsl: add std140 layout support for AoA

Reviewed-by: Samuel Iglesias Gonsálvez --- src/glsl/glsl_types.cpp | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_types.cpp index 6664a47..cc2f102 100644 --- a/src/glsl/glsl_types.cpp +++ b/src/glsl/glsl_types.cpp @@ -13

[Mesa-dev] [PATCH V6 08/27] nir: add atomic lowering support for AoA

--- src/glsl/nir/nir_lower_atomics.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/glsl/nir/nir_lower_atomics.c b/src/glsl/nir/nir_lower_atomics.c index 6f9ecc0..46e1376 100644 --- a/src/glsl/nir/nir_lower_atomics.c +++ b/src/glsl/nir/nir_lower_at

[Mesa-dev] [PATCH V6 21/27] glsl: Add support for lowering interface block arrays of arrays

V2: make array processing functions static --- src/glsl/lower_named_interface_blocks.cpp | 51 ++- 1 file changed, 37 insertions(+), 14 deletions(-) diff --git a/src/glsl/lower_named_interface_blocks.cpp b/src/glsl/lower_named_interface_blocks.cpp index 01bbdd0..04677

[Mesa-dev] [PATCH V6 27/27] docs: Mark AoA as done for i965

Reviewed-by: Ian Romanick --- docs/GL3.txt | 4 ++-- docs/relnotes/11.1.0.html | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index b9e5321..e48c18d 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -149,7 +149,7 @@ GL 4.2, GLSL 4.20:

[Mesa-dev] [PATCH V6 12/27] glsl: avoid hitting assert for arrays of arrays

Also add TODO comment about adding proper support Signed-off-by: Timothy Arceri --- src/glsl/ir_set_program_inouts.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/ir_set_program_inouts.cpp b/src/glsl/ir_set_program_inouts.cpp index b7a0f6e..d7c29b0 100644 --- a/src/glsl/i

[Mesa-dev] [PATCH V6 22/27] glsl: Add AoA support when checking for non-const index

When checking for non-const indexing of interfaces take into account arrays of arrays --- src/glsl/ast_array_index.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ast_array_index.cpp b/src/glsl/ast_array_index.cpp index 9585408..0cc68be 100644 --- a/src/glsl/ast_ar

[Mesa-dev] [PATCH V6 03/27] glsl: allow AoA to be sized by initializer or constructor

From Section 4.1.9 of the GLSL ES 3.10 spec: "Arrays are sized either at compile-time or at run-time. To size an array at compile-time, either the size must be specified within the brackets as above or must be inferred from the type of the initializer." --- src/glsl/ast.h | 1

[Mesa-dev] [PATCH V6 02/27] glsl: add support for initialising sampler AoA

--- src/glsl/link_uniform_initializers.cpp | 83 -- 1 file changed, 49 insertions(+), 34 deletions(-) diff --git a/src/glsl/link_uniform_initializers.cpp b/src/glsl/link_uniform_initializers.cpp index f64ba1b..ce1f15c 100644 --- a/src/glsl/link_uniform_initializer

[Mesa-dev] [PATCH V6 05/27] glsl: remove dead code in a single pass

Currently only one ir assignment is removed for each var in a single dead code optimisation pass. This means if a var has more than one assignment, then it requires all the glsl optimisations to be run again for each additional assignment to be removed. Another pass is also required to remove the v

[Mesa-dev] [PATCH V6 25/27] glsl: Allow arrays of arrays in GLSL ES 3.10 and GLSL 4.30

V3: use a check_*_allowed style function for requirements checking rather than has_* which doesn't encapsulate the error message V2: add missing 's' to the extension name in error messages and add decimal place in version string Reviewed-by: Marta Lofstedt --- src/glsl/ast_to_hir.cpp |

[Mesa-dev] [PATCH V6 17/27] i965: add support for image AoA

--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 45 1 file changed, 29 insertions(+), 16 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 5bc183c..e1544f0 100644 --- a/src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH V6 13/27] glsl: fix whitespace

--- src/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index a9696dc..2fd4443 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -6400,7 +6400,7 @@ ast_interface_block::hir(exec_list *inst

[Mesa-dev] [PATCH V6 09/27] i965: support atomic counter AoA

--- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index 3443e5c..63c40ba 100644 --- a/src/mesa/drivers/dri/i

[Mesa-dev] [PATCH V6 20/27] glsl: add AoA support for an inteface with unsized array members

Add support for setting the max access of an unsized member of an interface array of arrays. For example ifc[j][k].foo[i] where foo is unsized. --- src/glsl/ast_array_index.cpp | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/glsl/ast_array_index.cpp b/src

[Mesa-dev] [PATCH V6 04/27] glsl: dont allow gl_PerVertex to be redeclared as an array of arrays

V3: move patch after fixes to ast for AoA and add const to helper as suggested by Ian V2: move single dimensional array detection into a helper Signed-off-by: Timothy Arceri Reviewed-by: Ian Romanick --- src/glsl/ast.h | 6 ++ src/glsl/ast_to_hir.cpp | 3 ++- 2 files changed, 8 in

[Mesa-dev] [PATCH V6 06/27] glsl: add AoA support for atmoic counters

This marks all counters in an AoA as active. For AoA all but the innermost array are treated as separate counters/uniforms. The Nvidia binary also goes further and finds inactive counters in the AoA, in future we should do this too, however this gets things working for the time being. This change

[Mesa-dev] Arrays of Arrays v6

The following are standalone patches I would like to commit asap. [PATCH 05/27] glsl: remove dead code in a single pass [PATCH 10/27] i965: fix atomic buffer index for bindings other than 0 [PATCH 13/27] glsl: fix whitespace Changes in v6 - fix image support after chages to master - fix vector o

[Mesa-dev] [PATCH V6 07/27] nir: wrapper for glsl_type arrays_of_arrays_size()

Reviewed-by: Tapani Pälli Reviewed-by: Ian Romanick --- src/glsl/nir/nir_types.cpp | 6 ++ src/glsl/nir/nir_types.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/src/glsl/nir/nir_types.cpp b/src/glsl/nir/nir_types.cpp index da9807f..965f423 100644 --- a/src/glsl/nir/nir_types.cpp

[Mesa-dev] [PATCH V6 01/27] glsl: Add support for linking uniform arrays of arrays

V3: Fix setting of data.location for struct AoA UBO members V2: Handle arrays of arrays in the same way structures are handled The ARB_arrays_of_arrays spec doesn't give very many details on how AoA uniforms are intended to be implemented. However in the ARB_program_interface_query spec there are

Re: [Mesa-dev] [PATCH] configure.ac: handle llvm built with cmake in one shared library.

On 29 September 2015 at 11:31, Tom Stellard wrote: > On Mon, Sep 28, 2015 at 03:15:27PM +0100, Emil Velikov wrote: >> Hi Laurent, >> >> On 27 September 2015 at 13:21, Laurent Carlier wrote: >> > llvm can be built with cmake in a libray with the name libLLVM.so.$version >> > >> Do you know if this

Re: [Mesa-dev] [PATCH] configure.ac: handle llvm built with cmake in one shared library.

On Mon, Sep 28, 2015 at 03:15:27PM +0100, Emil Velikov wrote: > Hi Laurent, > > On 27 September 2015 at 13:21, Laurent Carlier wrote: > > llvm can be built with cmake in a libray with the name libLLVM.so.$version > > > Do you know if this is intentional and consistent (i.e. all the build > produc

Re: [Mesa-dev] [PATCH] configure.ac: handle llvm built with cmake in one shared library.

On Sun, Sep 27, 2015 at 02:21:41PM +0200, Laurent Carlier wrote: > llvm can be built with cmake in a libray with the name libLLVM.so.$version > Hi, Thanks for working on this. > Signed-off-by: Laurent Carlier > --- > configure.ac | 18 +- > 1 file changed, 13 insertions(+), 5

Re: [Mesa-dev] [PATCH 1/6] main: fix ACTIVE_UNIFORM_BLOCKS value

On Mon, 2015-09-28 at 16:30 +0200, Samuel Iglesias Gonsálvez wrote: > > On 28/09/15 14:23, Timothy Arceri wrote: > > On Mon, 2015-09-28 at 12:46 +0200, Samuel Iglesias Gonsálvez wrote: > > > > > > On 28/09/15 12:39, Samuel Iglesias Gonsálvez wrote: > > > > > > > > > > > > On 27/09/15 23:15, Tim

Re: [Mesa-dev] [PATCH 3/3] glsl: Fix forward NULL dereference coverity warning

On Mon, 2015-09-28 at 12:59 +0200, Iago Toral Quiroga wrote: > The comment says that it should be impossible for decl_type to be > NULL > here, so don't try to handle the case where it is, simply add an > assert. > > > > > CID 1324977: Null pointer dereferences (FORWARD_NULL) > > > > Com

[Mesa-dev] [PATCH] i965/copy_image: Fix a copy+past error

Reported-by: Ilia Mirkin --- src/mesa/drivers/dri/i965/intel_copy_image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_copy_image.c b/src/mesa/drivers/dri/i965/intel_copy_image.c index d57651c..0a3337e 100644 --- a/src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 2/5] radeonsi: move SPI_PS_INPUT_ENA/ADDR registers to a separate state

From: Marek Olšák This will be a derived state used for changing center->sample and centroid->sample at runtime. --- src/gallium/drivers/radeonsi/si_hw_context.c| 1 + src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state.h | 1 + src/gallium

[Mesa-dev] [PATCH 5/5] radeonsi: enable PIPE_CAP_FORCE_PERSAMPLE_INTERP

From: Marek Olšák Now st/mesa won't generate 2 variants for this state. --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index a56a580..c072c6d 100644 --

[Mesa-dev] [PATCH 1/5] tgsi/scan: add interpolation info into tgsi_shader_info

From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 91 +- src/gallium/auxiliary/tgsi/tgsi_scan.h | 13 - 2 files changed, 101 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan

[Mesa-dev] [PATCH 2/3] st/mesa: set force_persample_interp if ARB_sample_shading is used

From: Marek Olšák This is only a half of the work. The next patch will handle gl_SampleID/SamplePos, which is the other half of ARB_sample_shading. --- src/mesa/state_tracker/st_atom_rasterizer.c | 8 src/mesa/state_tracker/st_atom_shader.c | 1 + src/mesa/state_tracker/st_context.c

[Mesa-dev] [PATCH 4/5] radeonsi: do force_persample_interp in shaders for non-trivial cases

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c| 53 - src/gallium/drivers/radeonsi/si_shader.h| 49 ++- src/gallium/drivers/radeonsi/si_state_shaders.c | 34 3 files changed, 117 insertions(+), 19 deleti

[Mesa-dev] [PATCH 1/3] gallium: add per-sample interpolation control into rasterizer state

From: Marek Olšák Required by ARB_sample_shading for drivers that don't want a shader variant in st/mesa. --- src/gallium/docs/source/screen.rst | 9 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/galliu

[Mesa-dev] [PATCH 3/3] st/mesa: automatically set per-sample interpolation if using SampleID/Pos

From: Marek Olšák --- src/mesa/state_tracker/st_atom_shader.c | 8 +++- src/mesa/state_tracker/st_program.c | 4 +++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_shader.c b/src/mesa/state_tracker/st_atom_shader.c index dc03156..1e880a1

[Mesa-dev] Gallium and RadeonSI: new state for forcing per-sample interpolation

Hi, This consists of 2 patch series: Gallium: gallium: add per-sample interpolation control into rasterizer state st/mesa: set force_persample_interp if ARB_sample_shading is used st/mesa: automatically set per-sample interpolation if using SampleID/Pos RadeonSI: tgsi/sca

[Mesa-dev] [PATCH 3/5] radeonsi: implement the simple case of force_persample_interp

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state.c | 1 + src/gallium/drivers/radeonsi/si_state.h | 1 + src/gallium/drivers/radeonsi/si_state_shaders.c | 35 - 4 files changed, 37 insert

Re: [Mesa-dev] [PATCH 3/4] i965: Add a pass to predicate short blocks.

On Mon, Sep 28, 2015 at 3:26 PM, Matt Turner wrote: > total instructions in shared programs: 6496326 -> 6492315 (-0.06%) > instructions in affected programs: 159282 -> 155271 (-2.52%) > helped:411 > --- > src/mesa/drivers/dri/i965/Makefile.sources| 1

Re: [Mesa-dev] [PATCH] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

Hi, Am 28.09.2015 um 10:47 schrieb Iago Toral Quiroga: > NIR is typeless so this is the only way to keep track of the > type to select the proper atomic to use. > --- > I decided to squash the i965 changes in because otherwise we would break > the build between the nir and i965 patches. Let me kno

Re: [Mesa-dev] [PATCH 2/3] glsl: Fix null return coverity warning

On Mon, Sep 28, 2015 at 12:59:34PM +0200, Iago Toral Quiroga wrote: > Add an assert on the result of as_dereference() not being NULL: > > >>> CID 1324978: Null pointer dereferences (NULL_RETURNS) > >>> Dereferencing a null pointer "deref_record->record->as_dereference()". > > Since we a

Re: [Mesa-dev] [PATCH] st/mesa: add ST_DEBUG=precompile support for tessellation shaders

Reviewed-by: Ilia Mirkin On Mon, Sep 28, 2015 at 7:50 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/state_tracker/st_program.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/src/mesa/state_tracker/st_program.c > b/src/mesa/state_tracker/st_progr

[Mesa-dev] [PATCH] st/mesa: add ST_DEBUG=precompile support for tessellation shaders

From: Marek Olšák --- src/mesa/state_tracker/st_program.c | 20 1 file changed, 20 insertions(+) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tracker/st_program.c index e62dd7a..9c27147 100644 --- a/src/mesa/state_tracker/st_program.c +++ b/src/mesa/st

Re: [Mesa-dev] [PATCH 1/3] glsl: Fix unused value warning reported by Coverity

On Mon, Sep 28, 2015 at 12:59:33PM +0200, Iago Toral Quiroga wrote: > We don't use param in this part of the code, so no point in advancing > the pointer forward: > > >>> CID 1324983: Code maintainability issues (UNUSED_VALUE) > >>> Assigning value from "param->get_next()" to "param" her

[Mesa-dev] Mesa 11.0.2

Mesa 11.0.2 is now available. This is a emergency release which covers the final dEQP regressions introduced in the 11.0 development cycle. Eduardo Lima Mitev (3): mesa: Fix order of format+type and internal format checks for glTexImageXD ops mesa: Move _mesa_base_tex_format() from

Re: [Mesa-dev] [PATCH 2/6] mesa: rename gl_shader_program's NumUniformBlocks to NumUniformShaderStorageBlocks

Jordan Justen writes: > On 2015-09-28 02:55:48, Samuel Iglesias Gonsálvez wrote: >> >> >> On 26/09/15 09:51, Jordan Justen wrote: >> > On 2015-09-25 01:24:46, Samuel Iglesias Gonsalvez wrote: >> >> Because it counts shader storage blocks too. >> >> >> >> Signed-off-by: Samuel Iglesias Gonsalvez

[Mesa-dev] [Bug 91596] EGL_KHR_gl_colorspace (v2) causes problem with Android-x86 GUI

https://bugs.freedesktop.org/show_bug.cgi?id=91596 --- Comment #7 from Marek Olšák --- MESA_EXTENSION_OVERRIDE won't work. You need to set KHR_gl_colorspace = false manually in the code. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

On Mon, Sep 28, 2015 at 11:59 PM, Jose Fonseca wrote: > On 28/09/15 21:21, Marek Olšák wrote: >> >> On Mon, Sep 28, 2015 at 9:28 PM, Jose Fonseca wrote: >>> >>> On 28/09/15 14:51, Marek Olšák wrote: On Mon, Sep 28, 2015 at 2:55 PM, Jose Fonseca wrote: > > > On 27/

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

On 28/09/15 15:30, Rob Clark wrote: On Mon, Sep 28, 2015 at 8:55 AM, Jose Fonseca wrote: I see only 2 options out of this: 1) Removing the context pointer from the shader keys. If drivers need this, they should handle it by themselves. This will simplify st/mesa, because TCS, TES, GS won't

[Mesa-dev] [PATCH 4/4] i965: Merge brw_dead_control_flow.h into brw_shader.h.

--- src/mesa/drivers/dri/i965/Makefile.sources| 1 - src/mesa/drivers/dri/i965/brw_dead_control_flow.h | 26 --- src/mesa/drivers/dri/i965/brw_fs.cpp | 1 - src/mesa/drivers/dri/i965/brw_shader.h| 1 + src/mesa/drivers/dri/i965/brw_vec4.cpp

[Mesa-dev] [PATCH 3/4] i965: Add a pass to predicate short blocks.

total instructions in shared programs: 6496326 -> 6492315 (-0.06%) instructions in affected programs: 159282 -> 155271 (-2.52%) helped:411 --- src/mesa/drivers/dri/i965/Makefile.sources| 1 + src/mesa/drivers/dri/i965/brw_fs.cpp | 1 + s

[Mesa-dev] [PATCH 1/4] i965: Don't print line numbers with INTEL_DEBUG=optimizer.

The thing you want to do with the output files is diff them, which is made more difficult by line numbers changing. --- src/mesa/drivers/dri/i965/brw_shader.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dr

[Mesa-dev] [PATCH 2/4] i965: Move reads_flag()/writes_flag() to backend_instruction.

--- src/mesa/drivers/dri/i965/brw_fs.cpp| 15 --- src/mesa/drivers/dri/i965/brw_ir_fs.h | 3 --- src/mesa/drivers/dri/i965/brw_ir_vec4.h | 12 src/mesa/drivers/dri/i965/brw_shader.h | 13 + 4 files changed, 13 insertions(+), 30 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

On Mon, Sep 28, 2015 at 6:07 PM, Kristian Høgsberg wrote: > On Mon, Sep 28, 2015 at 1:59 PM, Ilia Mirkin wrote: >> On Mon, Sep 28, 2015 at 4:55 PM, Kristian Høgsberg >> wrote: >>> On Mon, Sep 28, 2015 at 1:47 AM, Iago Toral Quiroga >>> wrote: NIR is typeless so this is the only way to ke

Re: [Mesa-dev] [PATCH] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

On Mon, Sep 28, 2015 at 1:59 PM, Ilia Mirkin wrote: > On Mon, Sep 28, 2015 at 4:55 PM, Kristian Høgsberg wrote: >> On Mon, Sep 28, 2015 at 1:47 AM, Iago Toral Quiroga >> wrote: >>> NIR is typeless so this is the only way to keep track of the >>> type to select the proper atomic to use. >>> ---

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

On Mon, Sep 28, 2015 at 2:19 PM, Eduardo Lima Mitev wrote: > On 09/28/2015 08:25 PM, Jason Ekstrand wrote: >> Eduardo, >> Is there anything here still awaiting review? I thought I reviewed it all. >> --Jason >> > > Hi, > > Sorry for the delays, I'm on holidays for a couple weeks. > > Jason, all p

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

On 28/09/15 21:21, Marek Olšák wrote: On Mon, Sep 28, 2015 at 9:28 PM, Jose Fonseca wrote: On 28/09/15 14:51, Marek Olšák wrote: On Mon, Sep 28, 2015 at 2:55 PM, Jose Fonseca wrote: On 27/09/15 19:14, Marek Olšák wrote: Hi, For some reason, st/mesa assumes that shaders can't be shared

Re: [Mesa-dev] [PATCH 05/11] gallium: add PIPE_SHADER_CAP_MAX_BUFFERS

On 09/28/2015 09:20 AM, Ilia Mirkin wrote: On Mon, Sep 28, 2015 at 10:25 AM, Brian Paul wrote: On 09/27/2015 12:33 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + src/

Re: [Mesa-dev] [PATCH] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

On Mon, Sep 28, 2015 at 1:59 PM, Ilia Mirkin wrote: > On Mon, Sep 28, 2015 at 4:55 PM, Kristian Høgsberg wrote: >> On Mon, Sep 28, 2015 at 1:47 AM, Iago Toral Quiroga >> wrote: >>> NIR is typeless so this is the only way to keep track of the >>> type to select the proper atomic to use. >>> ---

[Mesa-dev] [PATCH] nir: Don't set dest in SSBO store glsl_to_nir conversion

This matches the function signature created in lower_ubo_reference_visitor::ssbo_store which has a void return. Suggested-by: Jason Ekstrand Signed-off-by: Jordan Justen Cc: Samuel Iglesias Gonsalvez Cc: Jason Ekstrand --- src/glsl/nir/glsl_to_nir.cpp | 1 - 1 file changed, 1 deletion(-) dif

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

On 09/28/2015 08:25 PM, Jason Ekstrand wrote: > Eduardo, > Is there anything here still awaiting review? I thought I reviewed it all. > --Jason > Hi, Sorry for the delays, I'm on holidays for a couple weeks. Jason, all patches in the series are reviewed by you. Thanks! Mark, I guess your Test

Re: [Mesa-dev] [PATCH] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

On Mon, Sep 28, 2015 at 4:55 PM, Kristian Høgsberg wrote: > On Mon, Sep 28, 2015 at 1:47 AM, Iago Toral Quiroga wrote: >> NIR is typeless so this is the only way to keep track of the >> type to select the proper atomic to use. >> --- >> I decided to squash the i965 changes in because otherwise we

Re: [Mesa-dev] [PATCH] nir: split SSBO min/max atomic instrinsics into signed/unsigned versions

On Mon, Sep 28, 2015 at 1:47 AM, Iago Toral Quiroga wrote: > NIR is typeless so this is the only way to keep track of the > type to select the proper atomic to use. > --- > I decided to squash the i965 changes in because otherwise we would break > the build between the nir and i965 patches. Let me

Re: [Mesa-dev] Pending issues of lollipop-x86

On Mon, Sep 28, 2015 at 10:19 PM, Chad Versace wrote: > On Fri 25 Sep 2015, Chih-Wei Huang wrote: >> CC to mesa-dev for help. >> >> 2015-09-25 22:12 GMT+08:00 Chih-Wei Huang : >> > 2015-09-25 16:21 GMT+08:00 Chih-Wei Huang : >> >> Actually I'm testing your mesa 11.0 branch >> >> to see if it is ac

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

On Mon, Sep 28, 2015 at 9:28 PM, Jose Fonseca wrote: > On 28/09/15 14:51, Marek Olšák wrote: >> >> On Mon, Sep 28, 2015 at 2:55 PM, Jose Fonseca wrote: >>> >>> On 27/09/15 19:14, Marek Olšák wrote: Hi, For some reason, st/mesa assumes that shaders can't be shared by

Re: [Mesa-dev] Pending issues of lollipop-x86

On Fri 25 Sep 2015, Chih-Wei Huang wrote: > CC to mesa-dev for help. > > 2015-09-25 22:12 GMT+08:00 Chih-Wei Huang : > > 2015-09-25 16:21 GMT+08:00 Chih-Wei Huang : > >> Actually I'm testing your mesa 11.0 branch > >> to see if it is acceptable. > >> The major issue I found is the > >> Camera and

Re: [Mesa-dev] [PATCH v5 2/3] mesa: Move _mesa_base_tex_format() from teximage to glformats files

Hi Eduardo, On 24 September 2015 at 09:57, Eduardo Lima Mitev wrote: > This function will be needed as part of validating the combination of format, > type and internal format of texture pixel operations, which happens in > glformats files. Specifically, we want to be able to obtain the base form

Re: [Mesa-dev] [PATCH] util: implement strndup for WIN32

Looks great Samuel. Just minor suggestions. Either way: Reviewed-by: Jose Fonseca On 28/09/15 15:19, Samuel Iglesias Gonsalvez wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92124 Cc: Jose Fonseca --- I tested it on MSVC but not MinGW. I hope I did not something wrong. s

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

On 28/09/15 14:51, Marek Olšák wrote: On Mon, Sep 28, 2015 at 2:55 PM, Jose Fonseca wrote: On 27/09/15 19:14, Marek Olšák wrote: Hi, For some reason, st/mesa assumes that shaders can't be shared by multiple contexts and therefore has a context pointer in shader keys. I'd like to get rid of t

Re: [Mesa-dev] [PATCH] mesa/meta: Use interpolateAtSample for 16x MSAA copy blit

A couple of fairly generic comments: - It is not at all clear to me why it's OK to interpolate at sample 0 -- this was previously interpolated at the sample, but apparently it doesn't matter where it's interpolated? Why not? [A future reader of the code might have a similar question.] - I think th

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

Eduardo, Is there anything here still awaiting review? I thought I reviewed it all. --Jason On Mon, Sep 28, 2015 at 10:57 AM, Mark Janes wrote: > Tested-by: Mark Janes > > Eduardo Lima Mitev writes: > >> This is a new version of the series that attempt to fix the regression >> reported at: >>

Re: [Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver (v3)

On 09/28/2015 11:33 AM, Emil Velikov wrote: Hi Kyle, On 25 September 2015 at 21:01, Kyle Brenneman wrote: Add a macro GL_LIB_NAME to hold the filename that configure comes up with based on the --with-gl-lib-name and --enable-mangling options. In driOpenDriver, use the GL_LIB_NAME macro instea

[Mesa-dev] [PATCH] glx: Don't hard-code the name "libGL.so.1" in driOpenDriver (v3)

Add a macro GL_LIB_NAME to hold the filename that configure comes up with based on the --with-gl-lib-name and --enable-mangling options. In driOpenDriver, use the GL_LIB_NAME macro instead of hard-coding "libGL.so.1". v2: Add an #ifndef/#define for GL_LIB_NAME so that non-autoconf builds will

Re: [Mesa-dev] [PATCH 1/2] glx: Fix build errors with --enable-mangling.

On 09/28/2015 11:26 AM, Emil Velikov wrote: Hi Kyle, On 24 September 2015 at 23:22, Kyle Brenneman wrote: Rearranged the GLX_ALIAS macro in glextensions.h so that it will pick up the renames from glx_mangle.h. Fixed the alias attribute for glXGetProcAddress when USE_MGL_NAMESPACE is defined.

Re: [Mesa-dev] [PATCH] mesa/meta: Use interpolateAtSample for 16x MSAA copy blit

On Mon, Sep 28, 2015 at 11:00 AM, Neil Roberts wrote: > Previously there was a problem in i965 where if 16x MSAA is used then > some of the sample positions are exactly on the 0 x or y axis. When > the MSAA copy blit shader interpolates the texture coordinates at > these sample positions it was po

[Mesa-dev] [PATCH] mesa/meta: Use interpolateAtSample for 16x MSAA copy blit

Previously there was a problem in i965 where if 16x MSAA is used then some of the sample positions are exactly on the 0 x or y axis. When the MSAA copy blit shader interpolates the texture coordinates at these sample positions it was possible that it would jump to a neighboring texel due to roundin

  1   2   >