Re: [Mesa-dev] [PATCH 0/3] Make pull constant loads in gen6 start at MRFs 16/17

On Thursday, October 08, 2015 08:16:23 AM Iago Toral wrote: > Hi Ken, > > I think this never got reviewed. Could you have a quick look at least to > patch 1? That looks like something we want to fix since we currently > have a hard-coded array size for 16 MRFs registers which won't do for > SNB.

Re: [Mesa-dev] [PATCH V7 03/24] glsl: allow AoA to be sized by initializer or constructor

On 07/10/15 00:47, Timothy Arceri wrote: > From Section 4.1.9 of the GLSL ES 3.10 spec: > > "Arrays are sized either at compile-time or at run-time. > To size an array at compile-time, either the size > must be specified within the brackets as above or > must be inferred from the type of

[Mesa-dev] [Bug 92343] New account request

https://bugs.freedesktop.org/show_bug.cgi?id=92343 Bug ID: 92343 Summary: New account request Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority:

[Mesa-dev] [Bug 92343] New account request

https://bugs.freedesktop.org/show_bug.cgi?id=92343 --- Comment #1 from Boyan Ding --- Created attachment 118755 --> https://bugs.freedesktop.org/attachment.cgi?id=118755=edit GPG public key -- You are receiving this mail because: You are the QA Contact for the bug. You are

Re: [Mesa-dev] [PATCH 05/12] i965/cs: Split out helper for building local id payload

On Wed, Oct 07, 2015 at 07:11:45AM -0700, Kristian H?gsberg Kristensen wrote: > The initial motivation for this patch was to avoid calling > brw_cs_prog_local_id_payload_dwords() in gen7_cs_state.c from the > compiler. This commit ends up refactoring things a bit more so as to > split out the

Re: [Mesa-dev] [PATCH V7 03/24] glsl: allow AoA to be sized by initializer or constructor

On 08/10/15 11:08, Samuel Iglesias Gonsálvez wrote: > On 07/10/15 00:47, Timothy Arceri wrote: >> From Section 4.1.9 of the GLSL ES 3.10 spec: >> >> "Arrays are sized either at compile-time or at run-time. >> To size an array at compile-time, either the size >> must be specified within the

[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope

https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #9 from Tapani Pälli --- (In reply to Emil Velikov from comment #8) > Iirc the mingw + autoconf build was dropped. So we might want to 'sync' with > the autoconf build. The latter currently requires gcc 4.2, whist

Re: [Mesa-dev] [PATCH v3 5/6] glsl: fix matrix stride calculation for std430's row_major matrices with two columns

On 08/10/15 00:47, Timothy Arceri wrote: > On Wed, 2015-10-07 at 09:21 +0200, Samuel Iglesias Gonsalvez wrote: >> It doesn't round up to vec4 size. >> >> Fixes 15 dEQP tests: >> >> dEQP >> -GLES31.functional.ssbo.layout.single_basic_type.std430.row_major_low >> p_mat2 >> dEQP >>

[Mesa-dev] [PATCH v2] mesa: add GL_UNSIGNED_INT_24_8 to _mesa_pack_depth_span

Patch adds missing type (used with NV_read_depth) so that it gets handled correctly. This fixes errors seen with following CTS test: ES3-CTS.gtf.GL3Tests.packed_pixels.packed_pixels Signed-off-by: Tapani Pälli --- src/mesa/main/pack.c | 15 +++ 1 file

Re: [Mesa-dev] [PATCH v3 6/6] main: fix length of values written to glGetProgramResourceiv() for ACTIVE_VARIABLES

On Thu, 2015-10-08 at 03:01 -0400, Ilia Mirkin wrote: > On Thu, Oct 8, 2015 at 2:56 AM, Iago Toral wrote: > > On Thu, 2015-10-08 at 09:53 +1100, Timothy Arceri wrote: > >> On Wed, 2015-10-07 at 09:21 +0200, Samuel Iglesias Gonsalvez wrote: > >> > Return the number of values

[Mesa-dev] [Bug 92342] BGRA_EXT and type UNSIGNED_BYTE is a valid combination for TexImage2D

https://bugs.freedesktop.org/show_bug.cgi?id=92342 --- Comment #3 from kalyank --- Will check with the fix http://cgit.freedesktop.org/mesa/mesa/commit/?id=6ad9ebb073fc4ed245ef8e9db4479a52e818cb92 -- You are receiving this mail because: You are the QA

Re: [Mesa-dev] [RFC] i965: Resolve color for all active shader images in intel_update_state().

On Sat, Oct 03, 2015 at 05:57:05PM +0300, Francisco Jerez wrote: > Jordan Justen writes: > > > From: Francisco Jerez > > > > Fixes > > arb_shader_image_load_store/execution/load-from-cleared-image.shader_test > > > > Cc: Chris Wilson

[Mesa-dev] [mesa-dev, mesa-demos][PATCH] sharedtex_mt: fix rendering thread hang

XNextEvent is a blocking call which locks up the display mutex this causes the rendering threads to hang when they try call glXSwapBuffers() as that tries to take the same mutex in underlying calls through XCopyArea(). So we only go to XNextEvent when it has at least one event and we wouldn't lock

Re: [Mesa-dev] [PATCH] main: fix length of values written to glGetProgramResourceiv() for ACTIVE_VARIABLES

Reviewed-by: Tapani Pälli On 10/06/2015 11:08 AM, Samuel Iglesias Gonsalvez wrote: Return the number of values written. Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/main/shader_query.cpp | 14 ++ 1 file changed, 10

[Mesa-dev] [PATCH] docs/relnotes: document EGL_KHR_create_context on llvmpipe and softpipe

Signed-off-by: Boyan Ding --- docs/relnotes/11.1.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html index 4c8b9d8..d4f30d0 100644 --- a/docs/relnotes/11.1.0.html +++ b/docs/relnotes/11.1.0.html @@ -50,6 +50,7

Re: [Mesa-dev] [PATCH v2] mesa: add GL_UNSIGNED_INT_24_8 to _mesa_pack_depth_span

On Thu, 2015-10-08 at 09:50 +0300, Tapani Pälli wrote: > Patch adds missing type (used with NV_read_depth) so that it gets > handled correctly. This fixes errors seen with following CTS test: > >ES3-CTS.gtf.GL3Tests.packed_pixels.packed_pixels > > Signed-off-by: Tapani Pälli

Re: [Mesa-dev] [PATCH V7 12/24] i965: add arrays of arrays support for varyings

Reviewed-by: Samuel Iglesias Gonsálvez On 07/10/15 00:47, Timothy Arceri wrote: > V2: get the correct vector elements value for outputs > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 7 +++ > 2 files changed, 5

Re: [Mesa-dev] [PATCH] gallium/swrast: fix front buffer blitting.

2015-10-08 13:26 GMT+08:00 Ian Romanick : > On 10/07/2015 08:05 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> So I've known this was broken before, cogl has a workaround >> for it from what I know, but with the gallium based swrast >> drivers

Re: [Mesa-dev] [PATCH v2] main: fix TOP_LEVEL_ARRAY_SIZE and TOP_LEVEL_ARRAY_STRIDE

On 07/10/15 16:25, Ilia Mirkin wrote: > On Tue, Oct 6, 2015 at 4:08 AM, Samuel Iglesias Gonsalvez > wrote: >> When the active variable is an array which is already a top-level >> shader storage block member, don't return its array size and stride >> when querying

Re: [Mesa-dev] [PATCH v3 6/6] main: fix length of values written to glGetProgramResourceiv() for ACTIVE_VARIABLES

On Thu, 2015-10-08 at 09:53 +1100, Timothy Arceri wrote: > On Wed, 2015-10-07 at 09:21 +0200, Samuel Iglesias Gonsalvez wrote: > > Return the number of values written. > > > > Signed-off-by: Samuel Iglesias Gonsalvez > > Reviewed-by: Timothy Arceri

Re: [Mesa-dev] [PATCH 02/12] util: Move DRI parse_debug_string() to util

On Wed, Oct 07, 2015 at 07:11:42AM -0700, Kristian H?gsberg Kristensen wrote: > We want to use intel_debug.c in code that doesn't link to dri common. > > Signed-off-by: Kristian Høgsberg Kristensen > --- > src/mesa/drivers/dri/i965/intel_debug.c | 5 ++-- >

[Mesa-dev] [Bug 92342] BGRA_EXT and type UNSIGNED_BYTE is a valid combination for TexImage2D

https://bugs.freedesktop.org/show_bug.cgi?id=92342 Jason Ekstrand changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

https://bugs.freedesktop.org/show_bug.cgi?id=92265 Jason Ekstrand changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 0/3] Make pull constant loads in gen6 start at MRFs 16/17

Hi Ken, I think this never got reviewed. Could you have a quick look at least to patch 1? That looks like something we want to fix since we currently have a hard-coded array size for 16 MRFs registers which won't do for SNB. Iago On Tue, 2015-09-22 at 14:00 +0200, Iago Toral Quiroga wrote: >

Re: [Mesa-dev] [PATCH] mesa: add GL_UNSIGNED_INT_24_8 to _mesa_pack_depth_span

On 10/01/2015 10:12 PM, Ian Romanick wrote: On 10/01/2015 09:50 AM, Tapani Pälli wrote: On 10/01/2015 03:17 PM, Iago Toral wrote: On Thu, 2015-10-01 at 08:28 +0300, Tapani Pälli wrote: Patch adds missing type (used with NV_read_depth) so that it gets

Re: [Mesa-dev] [PATCH v3 6/6] main: fix length of values written to glGetProgramResourceiv() for ACTIVE_VARIABLES

On Thu, Oct 8, 2015 at 2:56 AM, Iago Toral wrote: > On Thu, 2015-10-08 at 09:53 +1100, Timothy Arceri wrote: >> On Wed, 2015-10-07 at 09:21 +0200, Samuel Iglesias Gonsalvez wrote: >> > Return the number of values written. >> > >> > Signed-off-by: Samuel Iglesias Gonsalvez

Re: [Mesa-dev] [PATCH 05/12] i965/cs: Split out helper for building local id payload

On Wed, Oct 07, 2015 at 07:11:45AM -0700, Kristian H?gsberg Kristensen wrote: > The initial motivation for this patch was to avoid calling > brw_cs_prog_local_id_payload_dwords() in gen7_cs_state.c from the > compiler. This commit ends up refactoring things a bit more so as to > split out the

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

The problem was that it declared SVIEW but llvmpipe didn't like that for some reason. Marek On Oct 8, 2015 5:12 AM, "Roland Scheidegger" wrote: > Am 08.10.2015 um 02:02 schrieb Marek Olšák: > > Hi Brian, > > > > This is the commit that broke DrawPixels on llvmpipe, but not

Re: [Mesa-dev] [PATCH 03/12] i965: Configure bufmgr debug options from intel_screen.c

On Wed, Oct 07, 2015 at 07:11:43AM -0700, Kristian H?gsberg Kristensen wrote: > We need the debug flag parsing and INTEL_DEBUG in the compiler, but we > don't want the dependency on bufmgr (libdrm_intel) in there. Move to > intel_screen.c. > > Signed-off-by: Kristian Høgsberg Kristensen

Re: [Mesa-dev] [PATCH 00/12] Introduce libi965_compiler.la

On Wed, Oct 07, 2015 at 07:11:40AM -0700, Kristian H?gsberg Kristensen wrote: > This series introduces a new libtool convenience library, > libi965_compiler.la. Most of the series is concerned with moving bits > of code around to allow for splitting the compiler files in the > second-to-last

Re: [Mesa-dev] [PATCH 2/4 v2] glsl: Restrict initializers for global variables to constant expression in ES

Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ian Romanick > Sent: Wednesday, October 7, 2015 11:34 PM > To: mesa-dev@lists.freedesktop.org > Cc: Romanick, Ian D; 10.6 11.0 >

[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope

https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #10 from Jose Fonseca --- (In reply to Brian Paul from comment #7) > I routinely use MinGW 4.6.3: > > $ i686-w64-mingw32-g++ --version > i686-w64-mingw32-g++ (GCC) 4.6.3 If this version is still widely used,

Re: [Mesa-dev] [PATCH 4/4] glsl: In later GLSL versions, sequence operator is cannot be a constant expression

Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ian Romanick > Sent: Wednesday, October 7, 2015 11:34 PM > To: mesa-dev@lists.freedesktop.org > Cc: Romanick, Ian D > Subject:

Re: [Mesa-dev] [PATCH 3/4] glsl: Add method to determine whether an expression contains the sequence operator

Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ian Romanick > Sent: Wednesday, October 7, 2015 11:34 PM > To: mesa-dev@lists.freedesktop.org > Cc: Romanick, Ian D > Subject:

Re: [Mesa-dev] [PATCH 1/4] glsl: Only set ir_variable::constant_value for const-decorated variables

Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ian Romanick > Sent: Wednesday, October 7, 2015 11:34 PM > To: mesa-dev@lists.freedesktop.org > Cc: Romanick, Ian D > Subject:

Re: [Mesa-dev] [PATCH 01/12] i965: Move brw_dump_ir() out of brw_*_emit() functions

Well, this is weird this patch makes this crash: INTEL_DEBUG=vs glxgears because that uses a vertex program, so >base is a NULL pointer dereference in this call: brw_dump_ir("vertex", prog, >base, >program.Base); The surprising part is that this is the same without this patch (!) just that

Re: [Mesa-dev] [PATCH] mesa: Correctly handle GL_BGRA_EXT in ES3 format_and_type checks

On 07/10/15 23:58, Jason Ekstrand wrote: > The EXT_texture_format_BGRA extension (which mesa supports > unconditionally) adds a new format and internal format called GL_BGRA_EXT. > Previously, this was not really handled at all in > _mesa_ex3_error_check_format_and_type. When the checks were

Re: [Mesa-dev] [PATCH 01/12] i965: Move brw_dump_ir() out of brw_*_emit() functions

On Thu, Oct 08, 2015 at 01:23:27PM +0200, Iago Toral wrote: > Well, this is weird this patch makes this crash: > > INTEL_DEBUG=vs glxgears > > because that uses a vertex program, so >base is a NULL pointer > dereference in this call: > > brw_dump_ir("vertex", prog, >base, >program.Base); >

Re: [Mesa-dev] [PATCH 01/12] i965: Move brw_dump_ir() out of brw_*_emit() functions

On Thu, 2015-10-08 at 12:32 +0100, Chris Wilson wrote: > On Thu, Oct 08, 2015 at 01:23:27PM +0200, Iago Toral wrote: > > Well, this is weird this patch makes this crash: > > > > INTEL_DEBUG=vs glxgears > > > > because that uses a vertex program, so >base is a NULL pointer > > dereference in

Re: [Mesa-dev] [PATCH V7 19/24] glsl: Add AoA support when checking for non-const index

Reviewed-by: Samuel Iglesias Gonsálvez On 07/10/15 00:47, Timothy Arceri wrote: > When checking for non-const indexing of interfaces > take into account arrays of arrays > --- > src/glsl/ast_array_index.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Mesa-dev] [PATCH 4/6] nir: add shader_clock intrinsic

On 7 October 2015 at 23:50, Connor Abbott wrote: > On Wed, Oct 7, 2015 at 4:48 PM, Emil Velikov wrote: >> On 7 October 2015 at 18:04, Connor Abbott wrote: >>> On Wed, Oct 7, 2015 at 7:51 AM, Emil Velikov

[Mesa-dev] New stable-branch 11.0 candidate pushed

Hello list, The candidate for the Mesa 11.0.3 is now available. Currently we have: - 46 queued - 18 nominated (outstanding) - and 7 rejected/obsolete patches This time around we have a bunch of EGL patches, mangledGL build fixes and a healthy amount of driver bugfixes - radeonsi, nouveau,

Re: [Mesa-dev] [PATCH 1/4] glsl: Only set ir_variable::constant_value for const-decorated variables

On Wed, 2015-10-07 at 14:34 -0700, Ian Romanick wrote: > From: Ian Romanick > > Right now we're also setting for uniforms, and that doesn't seem to hurt > things. The next patch will make general global variables in GLSL ES, > and those definitely should not have

Re: [Mesa-dev] [PATCH 4/4] glsl: In later GLSL versions, sequence operator is cannot be a constant expression

On Wed, 2015-10-07 at 14:34 -0700, Ian Romanick wrote: > From: Ian Romanick > > Fixes: > ES3-CTS.shaders.negative.constant_sequence > > spec/glsl-es-3.00/compiler/global-initializer/from-sequence.vert >

Re: [Mesa-dev] [PATCH 5/6] i965: Implement nir_intrinsic_shader_clock

On 8 October 2015 at 00:36, Connor Abbott wrote: > On Wed, Oct 7, 2015 at 7:51 AM, Emil Velikov wrote: >> Signed-off-by: Emil Velikov >> --- >> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 9 + >>

Re: [Mesa-dev] [PATCH V7 20/24] glsl: link uniform block arrays of arrays

I have minor comments below. I don't see anything wrong here, but maybe others with more knowledge of this area want to review this patch as well. With the minor comments addressed, Reviewed-by: Samuel Iglesias Gonsálvez On 07/10/15 00:47, Timothy Arceri wrote: > This

Re: [Mesa-dev] [PATCH V7 18/24] glsl: Add support for lowering interface block arrays of arrays

On 07/10/15 00:47, Timothy Arceri wrote: > V2: make array processing functions static > --- > src/glsl/lower_named_interface_blocks.cpp | 51 > ++- > 1 file changed, 37 insertions(+), 14 deletions(-) > > diff --git a/src/glsl/lower_named_interface_blocks.cpp >

Re: [Mesa-dev] make distclean failing

Ilia Mirkin wrote: Edit shader_enums.Plo and replace shader_enums.cpp with shader_enums.c (or vice-versa) shader_enums.Plo does not exist anymore by the time distclean gets to the error. After autogen it contains #dummy, after build it looks like- ph4[mesa]$ cat

Re: [Mesa-dev] [PATCH 4/4] program: remove _mesa_init_*_program wrappers

On 8 October 2015 at 01:12, Marek Olšák wrote: > From: Marek Olšák > > They didn't do anything useful. > --- > src/mesa/drivers/dri/i915/i915_fragprog.c | 7 +- > src/mesa/drivers/dri/i965/brw_program.c| 10 +- >

[Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Callers of create_texture() will either pass target=0 or a validated GL texture target enum so no need to do another error check inside the loop. --- src/mesa/main/texobj.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/texobj.c

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

On 10/07/2015 04:47 PM, Mark Janes wrote: Brian Paul writes: On 10/05/2015 05:18 PM, Mark Janes wrote: I tested this patch and found: regressions: spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW only) expected[1] = 1.00. Read value: 0.00

[Mesa-dev] [PATCH 3/3] mesa, meta: move gl_texture_object::TargetIndex initializations

Before, we were unconditionally assigning the TargetIndex field in _mesa_BindTexture(), even if it was already set properly. Now we initialize TargetIndex wherever we initialize the Target field, in _mesa_initialize_texture_object(), finish_texture_init(), etc. v2: also update the

[Mesa-dev] [PATCH 2/3] mesa: remove unused _mesa_create_nameless_texture()

--- src/mesa/main/texobj.c | 20 src/mesa/main/texobj.h | 3 --- 2 files changed, 23 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index aa4b38c..66eacf8 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -1185,26 +1185,6 @@

[Mesa-dev] [Bug 92343] New account request

https://bugs.freedesktop.org/show_bug.cgi?id=92343 Brian Paul changed: What|Removed |Added Component|Other |New Accounts

Re: [Mesa-dev] [PATCH 4/6] nir: add shader_clock intrinsic

On Thu, Oct 8, 2015 at 8:54 AM, Emil Velikov wrote: > On 8 October 2015 at 11:54, Emil Velikov wrote: >> On 7 October 2015 at 23:50, Connor Abbott wrote: >>> On Wed, Oct 7, 2015 at 4:48 PM, Emil Velikov

[Mesa-dev] [Bug 92183] linker.cpp:3187:46: error: ‘strtok_r’ was not declared in this scope

https://bugs.freedesktop.org/show_bug.cgi?id=92183 --- Comment #11 from Brian Paul --- (In reply to Jose Fonseca from comment #10) > (In reply to Brian Paul from comment #7) > > I routinely use MinGW 4.6.3: > > > > $ i686-w64-mingw32-g++ --version > > i686-w64-mingw32-g++

Re: [Mesa-dev] [PATCH 4/6] nir: add shader_clock intrinsic

On 8 October 2015 at 11:54, Emil Velikov wrote: > On 7 October 2015 at 23:50, Connor Abbott wrote: >> On Wed, Oct 7, 2015 at 4:48 PM, Emil Velikov >> wrote: >>> On 7 October 2015 at 18:04, Connor Abbott

Re: [Mesa-dev] [PATCH] c11/threads: initialize timeout structure

On 8 October 2015 at 06:44, Jan Vesely wrote: > On Tue, 2015-10-06 at 10:38 -0700, Ian Romanick wrote: >> I had also noticed the unused parameter warning, but I had a patch >> that >> just papered over the problem. I'm a bit annoyed that GCC didn't >> warn >> (but I guess

Re: [Mesa-dev] [PATCH 4/6] nir: add shader_clock intrinsic

On Thu, Oct 8, 2015 at 6:54 AM, Emil Velikov wrote: > On 7 October 2015 at 23:50, Connor Abbott wrote: >> On Wed, Oct 7, 2015 at 4:48 PM, Emil Velikov >> wrote: >>> On 7 October 2015 at 18:04, Connor Abbott

Re: [Mesa-dev] [PATCH 02/12] util: Move DRI parse_debug_string() to util

Moe than moving, this patch is duplicating it... wouldn't it be better if we moved it for real? Seems like it would only be a matter of adding #include "util/debug.h" s/driParseDebugString/parse_debug_string/ in the following files: ./src/mesa/drivers/dri/radeon/radeon_debug.c

Re: [Mesa-dev] [PATCH 0/4] program: removal of Mesa IR functions

On 8 October 2015 at 01:11, Marek Olšák wrote: > Hi, > > Some of these functions became unused after I made the big st/mesa patch > series. Hopefully, nobody will miss them. > > The last one is a cleanup. > > Please review. > > src/mesa/drivers/dri/i915/i915_fragprog.c

Re: [Mesa-dev] [PATCH 03/12] i965: Configure bufmgr debug options from intel_screen.c

On Thu, 2015-10-08 at 10:07 +0300, Pohjolainen, Topi wrote: > On Wed, Oct 07, 2015 at 07:11:43AM -0700, Kristian H?gsberg Kristensen wrote: > > We need the debug flag parsing and INTEL_DEBUG in the compiler, but we > > don't want the dependency on bufmgr (libdrm_intel) in there. Move to > >

Re: [Mesa-dev] [PATCH 2/4] program: remove unused cloning and combining functions

On 8 October 2015 at 01:12, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/program/program.c | 250 > - > src/mesa/program/program.h | 44 > 2 files changed, 294 deletions(-) > > diff --git

Re: [Mesa-dev] make distclean failing

On Wed, Oct 7, 2015 at 6:00 PM, Andy Furniss wrote: > Noticed recently that make distclean is failing for me - > > Making distclean in mesa > make[2]: Entering directory '/mnt/sdb1/Src64/Mesa-git/mesa/src/mesa' > Makefile:2486: ../glsl/.deps/shader_enums.Plo: No such file or

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

Was that because stencil used sampler 1 but sview 0 which looks definitely wrong as there needs o be a 1:1 mapping between these when the tex opcodes are used? Roland Am 08.10.2015 um 10:45 schrieb Marek Olšák: > The problem was that it declared SVIEW but llvmpipe didn't like that for > some

Re: [Mesa-dev] [PATCH 4/6] nir: add shader_clock intrinsic

On 8 October 2015 at 14:20, Connor Abbott wrote: > On Thu, Oct 8, 2015 at 6:54 AM, Emil Velikov wrote: >> On 7 October 2015 at 23:50, Connor Abbott wrote: >>> On Wed, Oct 7, 2015 at 4:48 PM, Emil Velikov

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

On 10/07/2015 06:02 PM, Marek Olšák wrote: Hi Brian, This is the commit that broke DrawPixels on llvmpipe, but not radeonsi and softpipe. It's fixed in v2, which is attached. Thanks. That fixes the conform and piglit regressions. For the series, Reviewed-by: Brian Paul

Re: [Mesa-dev] [PATCH 4/6] nir: add shader_clock intrinsic

On 8 October 2015 at 14:26, Connor Abbott wrote: > On Thu, Oct 8, 2015 at 8:54 AM, Emil Velikov wrote: >> On 8 October 2015 at 11:54, Emil Velikov wrote: >>> On 7 October 2015 at 23:50, Connor Abbott

Re: [Mesa-dev] make distclean failing

On Thu, Oct 8, 2015 at 6:56 AM, Rob Clark wrote: > On Wed, Oct 7, 2015 at 6:00 PM, Andy Furniss wrote: >> Noticed recently that make distclean is failing for me - >> >> Making distclean in mesa >> make[2]: Entering directory

Re: [Mesa-dev] make distclean failing

On Thu, Oct 8, 2015 at 11:39 AM, Emil Velikov wrote: > On 8 October 2015 at 16:12, Matt Turner wrote: >> On Thu, Oct 8, 2015 at 6:56 AM, Rob Clark wrote: >>> On Wed, Oct 7, 2015 at 6:00 PM, Andy Furniss

[Mesa-dev] [PATCH] nir: Mark the shader name during nir_sweep

Previously the name of the nir shader was being freed prematurely during nir_sweep. Since 756613ed35d the name was later being used to generate filenames for the optimiser debug output and these would end up with garbage from the dangling pointer. --- src/glsl/nir/nir_sweep.c | 3 +++ 1 file

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

Am 08.10.2015 um 16:46 schrieb Marek Olšák: > > On Oct 8, 2015 4:03 PM, "Roland Scheidegger" > wrote: >> >> Was that because stencil used sampler 1 but sview 0 which looks >> definitely wrong as there needs o be a 1:1 mapping between these when >>

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

On Oct 8, 2015 4:03 PM, "Roland Scheidegger" wrote: > > Was that because stencil used sampler 1 but sview 0 which looks > definitely wrong as there needs o be a 1:1 mapping between these when > the tex opcodes are used? I don't remember how the SVIEW declarations work. It was

Re: [Mesa-dev] [PATCH 0/4] program: removal of Mesa IR functions

On 10/07/2015 06:11 PM, Marek Olšák wrote: Hi, Some of these functions became unused after I made the big st/mesa patch series. Hopefully, nobody will miss them. The last one is a cleanup. Please review. LGTM. Reviewed-by: Brian Paul

Re: [Mesa-dev] [PATCH] nir: Mark the shader name during nir_sweep

On Thu, Oct 8, 2015 at 7:58 AM, Neil Roberts wrote: > Previously the name of the nir shader was being freed prematurely > during nir_sweep. Since 756613ed35d the name was later being used to > generate filenames for the optimiser debug output and these would end > up with

Re: [Mesa-dev] [PATCH] nir/sweep: Reparent the shader name

Oops, I just made a similar patch without noticing this one. Feel free to take the commit message from my patch if you want. Either way this one is: Reviewed-by: Neil Roberts http://patchwork.freedesktop.org/patch/61369/ Sorry for the noise. Regards, - Neil Jason

Re: [Mesa-dev] [PATCH V7 21/24] glsl: build ubo name and indexing offset for AoA

On 07/10/15 00:47, Timothy Arceri wrote: > --- > src/glsl/lower_ubo_reference.cpp | 119 > --- > 1 file changed, 87 insertions(+), 32 deletions(-) > > diff --git a/src/glsl/lower_ubo_reference.cpp > b/src/glsl/lower_ubo_reference.cpp > index 247620e..7e983d0

Re: [Mesa-dev] make distclean failing

On 8 October 2015 at 16:12, Matt Turner wrote: > On Thu, Oct 8, 2015 at 6:56 AM, Rob Clark wrote: >> On Wed, Oct 7, 2015 at 6:00 PM, Andy Furniss wrote: >>> Noticed recently that make distclean is failing for me - >>> >>> Making

[Mesa-dev] [Bug 92122] [bisected, cts] Regression with Assault Android Cactus

https://bugs.freedesktop.org/show_bug.cgi?id=92122 Alex Deucher changed: What|Removed |Added CC|

[Mesa-dev] [PATCH 1/7] glsl: move gl_shader_stage_name() definition to shader_enums.h

This is a trivial enough function that can live in the header. While we're here, add a STATIC_ASSERT for good measure. Signed-off-by: Emil Velikov --- src/glsl/shader_enums.c | 13 - src/glsl/shader_enums.h | 23 +-- 2 files changed,

[Mesa-dev] [PATCH 3/7] glsl: move gl_varying_slot_name() definition to shader_enums.h

This is a trivial enough function that can live in the header. While we're here, add a STATIC_ASSERT for good measure. Move VARYING_SLOT_MAX macro to shader_enums.h Signed-off-by: Emil Velikov --- src/glsl/shader_enums.c | 65

[Mesa-dev] [PATCH 4/7] glsl: move gl_system_value_name() definition to shader_enums.h

This is a trivial enough function that can live in the header. While we're here, add a STATIC_ASSERT for good measure. Add the missing SYSTEM_VALUE_NUM_WORK_GROUPS enum. Signed-off-by: Emil Velikov --- src/glsl/shader_enums.c | 24

[Mesa-dev] [PATCH 5/7] glsl: move glsl_interp_qualifier_name() definition to shader_enums.h

This is a trivial enough function that can live in the header. While we're here, add a STATIC_ASSERT for good measure. Signed-off-by: Emil Velikov --- src/glsl/shader_enums.c | 11 --- src/glsl/shader_enums.h | 16 +++- 2 files changed, 15

[Mesa-dev] [PATCH 2/7] glsl: move gl_vert_attrib_name() definition to shader_enums.h

This is a trivial enough function that can live in the header. While we're here, add a STATIC_ASSERT for good measure. Signed-off-by: Emil Velikov --- src/glsl/shader_enums.c | 40 src/glsl/shader_enums.h | 45

Re: [Mesa-dev] [PATCH 2/3] mesa: remove unused _mesa_create_nameless_texture()

On Thu, Oct 8, 2015 at 7:20 AM, Brian Paul wrote: > --- > src/mesa/main/texobj.c | 20 > src/mesa/main/texobj.h | 3 --- > 2 files changed, 23 deletions(-) > > diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c > index aa4b38c..66eacf8 100644 >

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

On Thu, Oct 8, 2015 at 7:20 AM, Brian Paul wrote: > Callers of create_texture() will either pass target=0 or a validated > GL texture target enum so no need to do another error check inside > the loop. > --- > src/mesa/main/texobj.c | 11 ++- > 1 file changed, 2

Re: [Mesa-dev] [PATCH 4/6] nir: add shader_clock intrinsic

On Thu, Oct 8, 2015 at 10:09 AM, Emil Velikov wrote: > On 8 October 2015 at 14:20, Connor Abbott wrote: >> On Thu, Oct 8, 2015 at 6:54 AM, Emil Velikov >> wrote: >>> On 7 October 2015 at 23:50, Connor Abbott

Re: [Mesa-dev] [PATCH 03/12] i965: Configure bufmgr debug options from intel_screen.c

On Thu, Oct 8, 2015 at 6:52 AM, Iago Toral wrote: > On Thu, 2015-10-08 at 10:07 +0300, Pohjolainen, Topi wrote: >> On Wed, Oct 07, 2015 at 07:11:43AM -0700, Kristian H?gsberg Kristensen wrote: >> > We need the debug flag parsing and INTEL_DEBUG in the compiler, but we >> >

[Mesa-dev] [PATCH 6/7] glsl: move gl_frag_result_name() definition to shader_enums.h

This is a trivial enough function that can live in the header. While we're here, add a STATIC_ASSERT for good measure. Move FRAG_RESULT_MAX macro to shader_enums.h Signed-off-by: Emil Velikov --- src/glsl/shader_enums.c | 18 --

[Mesa-dev] [PATCH 7/7] glsl: remove shader_enums.c

It's an empty file now. Signed-off-by: Emil Velikov --- src/Makefile.am | 1 - src/glsl/shader_enums.c | 34 -- src/mesa/Makefile.sources | 4 +--- 3 files changed, 1 insertion(+), 38 deletions(-) delete mode 100644

Re: [Mesa-dev] [PATCH 1/7] glsl: move gl_shader_stage_name() definition to shader_enums.h

On Thu, Oct 8, 2015 at 1:09 PM, Emil Velikov wrote: > This is a trivial enough function that can live in the header. While > we're here, add a STATIC_ASSERT for good measure. > > Signed-off-by: Emil Velikov > --- > src/glsl/shader_enums.c |

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

https://bugs.freedesktop.org/show_bug.cgi?id=92265 Mark Janes changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: [Mesa-dev] [PATCH 1/7] glsl: move gl_shader_stage_name() definition to shader_enums.h

On 8 October 2015 at 18:08, Ilia Mirkin wrote: > On Thu, Oct 8, 2015 at 1:09 PM, Emil Velikov wrote: >> This is a trivial enough function that can live in the header. While >> we're here, add a STATIC_ASSERT for good measure. >> >> Signed-off-by:

Re: [Mesa-dev] [PATCH 05/12] i965/cs: Split out helper for building local id payload

On Thu, Oct 8, 2015 at 1:34 AM, Pohjolainen, Topi wrote: > On Wed, Oct 07, 2015 at 07:11:45AM -0700, Kristian H?gsberg Kristensen wrote: >> The initial motivation for this patch was to avoid calling >> brw_cs_prog_local_id_payload_dwords() in gen7_cs_state.c from the

Re: [Mesa-dev] [PATCH 1/4] glsl: Only set ir_variable::constant_value for const-decorated variables

On 10/08/2015 02:50 AM, Iago Toral wrote: > On Wed, 2015-10-07 at 14:34 -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> Right now we're also setting for uniforms, and that doesn't seem to hurt >> things. The next patch will make general global variables in GLSL

Re: [Mesa-dev] [PATCH 02/12] util: Move DRI parse_debug_string() to util

On Thu, Oct 8, 2015 at 6:43 AM, Iago Toral wrote: > Moe than moving, this patch is duplicating it... wouldn't it be better > if we moved it for real? Seems like it would only be a matter of adding > #include "util/debug.h" s/driParseDebugString/parse_debug_string/ in the >

Re: [Mesa-dev] [PATCH 05/12] i965/cs: Split out helper for building local id payload

On Thu, Oct 8, 2015 at 1:53 AM, Pohjolainen, Topi wrote: > On Wed, Oct 07, 2015 at 07:11:45AM -0700, Kristian H?gsberg Kristensen wrote: >> The initial motivation for this patch was to avoid calling >> brw_cs_prog_local_id_payload_dwords() in gen7_cs_state.c from the

Re: [Mesa-dev] [PATCH 05/12] i965/cs: Split out helper for building local id payload

On Thu, Oct 08, 2015 at 10:53:59AM -0700, Kristian H?gsberg wrote: > On Thu, Oct 8, 2015 at 1:53 AM, Pohjolainen, Topi > wrote: > > On Wed, Oct 07, 2015 at 07:11:45AM -0700, Kristian H?gsberg Kristensen > > wrote: > >> The initial motivation for this patch was to

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

You tested with all 3 patches and everything's OK now? I guess I'd still like an R-b on the 3rd patch ("mesa,meta: move gl_texture_object::TargetIndex initializations") from someone before pushing. -Brian On 10/08/2015 11:57 AM, Mark Janes wrote: Tested-by: Mark Janes

Re: [Mesa-dev] make distclean failing

On 8 October 2015 at 16:56, Rob Clark wrote: > On Thu, Oct 8, 2015 at 11:39 AM, Emil Velikov > wrote: >> On 8 October 2015 at 16:12, Matt Turner wrote: >>> On Thu, Oct 8, 2015 at 6:56 AM, Rob Clark wrote:

  1   2   >