On Fri, Nov 13, 2015 at 04:55:33PM +0100, Neil Roberts wrote:
> Hi,
>
> You don't seem to have included any of the suggestions I made in my
> review. Was this deliberate? If not, the main points were:
>
It was not intentional, I apologize. It just got lost on top of Chad's feedback
which conflic
This was only used to implement an unnecessarily restrictive interpretation
of the spec of AMD_performance_monitor. The spec says
A performance monitor consists of a number of hardware and software
counters that can be sampled by the GPU and reported back to the
application.
I guess one cou
---
src/gallium/auxiliary/hud/hud_driver_query.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/gallium/auxiliary/hud/hud_driver_query.c
b/src/gallium/auxiliary/hud/hud_driver_query.c
index f14305e..3198ab3 100644
--- a/src/gallium/auxiliary/hud/hud_driver_query.c
+++ b/src/gallium/auxili
Some drivers (in particular radeon[si], but also freedreno judging from
a quick grep) may want to expose performance counters that cannot be
individually enabled or disabled.
Allow such drivers to mark driver-specific queries as requiring a new
type of batch query object that is used to start and
---
src/mesa/state_tracker/st_cb_perfmon.c | 75 ++
src/mesa/state_tracker/st_cb_perfmon.h | 6 +++
2 files changed, 74 insertions(+), 7 deletions(-)
diff --git a/src/mesa/state_tracker/st_cb_perfmon.c
b/src/mesa/state_tracker/st_cb_perfmon.c
index 6c71a13..078d2
---
src/gallium/include/pipe/p_defines.h | 2 ++
src/mesa/state_tracker/st_cb_perfmon.c | 3 +++
2 files changed, 5 insertions(+)
diff --git a/src/gallium/include/pipe/p_defines.h
b/src/gallium/include/pipe/p_defines.h
index 7f241c8..7ed9f6d 100644
--- a/src/gallium/include/pipe/p_defines.h
++
---
src/mesa/state_tracker/st_cb_perfmon.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/mesa/state_tracker/st_cb_perfmon.c
b/src/mesa/state_tracker/st_cb_perfmon.c
index 80ff170..ec12eb2 100644
--- a/src/mesa/state_tracker/st_cb_perfmon.c
+++ b/src/mesa/state_tra
Hi,
the main point of this patch series is to introduce batch query objects.
For AMD_performance_monitor, hardware may not be able to start and stop
performance counters independently of each other. The current query interface
does not fit such hardware well.
With this series, drivers can mark d
---
src/gallium/auxiliary/hud/hud_context.c | 24 ++-
src/gallium/auxiliary/hud/hud_driver_query.c | 248 +++
src/gallium/auxiliary/hud/hud_private.h | 13 +-
3 files changed, 240 insertions(+), 45 deletions(-)
diff --git a/src/gallium/auxiliary/hud/hud_context
It is easy enough to pre-determine the required size, and arrays are
generally better behaved especially when they get large.
---
src/mesa/state_tracker/st_cb_perfmon.c | 78 --
src/mesa/state_tracker/st_cb_perfmon.h | 18
2 files changed, 55 insertions(+),
Previously, when a performance monitor was initialized, an inner loop through
all driver queries with string comparisons for each enabled performance
monitor counter was used. This hurts when a driver exposes lots of queries.
---
src/mesa/state_tracker/st_cb_perfmon.c | 74 +++-
On Fri, Nov 13, 2015 at 10:53 AM, Tapani Pälli wrote:
> On 11/12/2015 05:47 PM, Ilia Mirkin wrote:
>>
>> On Mon, Nov 2, 2015 at 6:36 AM, Tapani Pälli
>> wrote:
>>>
>>> Patch sets matrix_stride as 0 for non matrix uniforms that are in a
>>> atomic counter buffer. Matrix stride calculation for actu
Hi,
You don't seem to have included any of the suggestions I made in my
review. Was this deliberate? If not, the main points were:
• You don't need to call brw_fast_clear_init or use_rectlist in the
function because these are already called before entering it.
• I don't think it's worth creati
On 11/13/2015 03:40 PM, Samuel Iglesias Gonsálvez wrote:
On 13/11/15 11:32, Tapani Pälli wrote:
Patch adds additional mask for tracking which vertex buffer bindings
are set. This array can be directly compared to which vertex arrays
are enabled and should match when drawing.
Fixes following CT
On 11/12/2015 05:47 PM, Ilia Mirkin wrote:
On Mon, Nov 2, 2015 at 6:36 AM, Tapani Pälli wrote:
Patch sets matrix_stride as 0 for non matrix uniforms that are in a
atomic counter buffer. Matrix stride calculation for actual matrix
uniforms is done during link_assign_uniform_locations.
From ARB
On Fri, 2015-11-13 at 07:37 -0800, Jason Ekstrand wrote:
> I didn't want to pull a non-inline mesa function into NIR and add a
> link dependency and I was too lazy to move it into util.
But at this moment _mesa_fls() is an inline function. So I guess it is
safe to push it, isn't it?
J.A
On Nov 13, 2015 5:49 AM, "Iago Toral" wrote:
>
> On Wed, 2015-11-11 at 17:26 -0800, Jason Ekstrand wrote:
> > ---
> > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 10 +-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.
On Nov 13, 2015 5:25 AM, "Iago Toral" wrote:
>
> On Wed, 2015-11-11 at 17:26 -0800, Jason Ekstrand wrote:
> > ---
> > src/glsl/nir/nir.h | 2 +-
> > src/glsl/nir/nir_lower_tex.c | 19 +++
> > 2 files changed, 16 insertions(+), 5 deletions(-)
> >
> > diff --git a/src/gls
On Fri, Nov 13, 2015 at 9:38 AM, Ilia Mirkin wrote:
> On Fri, Nov 13, 2015 at 9:25 AM, Emil Velikov
> wrote:
>> Hello Hans,
>>
>> Not to muddy the waters or anything, have you thought about the NIR
>> integration that Rob was thinking about ?
>> I'm pretty sure he'll be happy to have extra peopl
On Nov 6, 2015 12:21 PM, "Matt Turner" wrote:
>
> On Fri, Nov 6, 2015 at 8:27 AM, Juan A. Suarez Romero
> wrote:
> > Replace the current loop by a direct call to _mesa_fls() function.
> >
> > It also fixes an implicit bug in the current code where num_textures
> > seems to be one value less than
On Nov 13, 2015 5:53 AM, "Iago Toral" wrote:
>
> On Wed, 2015-11-11 at 17:26 -0800, Jason Ekstrand wrote:
> > ---
> > src/mesa/drivers/dri/i965/brw_fs.cpp | 11 +--
> > src/mesa/drivers/dri/i965/brw_nir.c | 1 -
> > src/mesa/drivers/dri/i965/brw_vec4.cpp
Great! Glad to hear it. I'll check in the updated documentation today.
-Brian
On 11/13/2015 03:03 AM, Valera Rozuvan wrote:
Hi Brian,
The updated instructions worked for me. Thank you = )
Regards,
Valera Rozuvan |
https://urldefense.proofpoint.com/v2/url?u=http-3A__valera.rozuvan.net_&d=BQ
Hi Samuel,
The subject line should probably be something like:
"mesa: add locking in create_render_buffers() and create_framebuffers()"
Then, the comment body:
"""
This makes generation of framebuffer and renderbuffer id's threadsafe
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=9263
This should fix the issue described in
https://bugs.freedesktop.org/show_bug.cgi?id=92633
---
src/mesa/main/fbobject.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index fe6bdc2..6398ff6 100644
--- a/src/mesa
Hi Emil,
Emil Velikov wrote on 13.11.2015 13:58:
> On 13 November 2015 at 09:14, Kai Wasserbäch
> wrote:
>> Emil Velikov wrote on 12.11.2015 18:45:
>>> On 12 November 2015 at 15:36, Samuel Iglesias Gonsálvez
>>> wrote:
On 12/11/15 15:28, Timothy Arceri wrote:
> On 13 November 2015 12:22
Hi Brian,
The updated instructions worked for me. Thank you = )
Regards,
Valera Rozuvan | http://valera.rozuvan.net/
Skype: valera.rozuvan
E-mail: valera.rozu...@gmail.com
Phone: +38 (050) 837-29-73
On Wed, Nov 11, 2015 at 11:18 PM, Emil Velikov wrote:
> On 11 November 2015 at 19:51, Brian P
On Fri, Nov 13, 2015 at 9:25 AM, Emil Velikov wrote:
> Hello Hans,
>
> Not to muddy the waters or anything, have you thought about the NIR
> integration that Rob was thinking about ?
> I'm pretty sure he'll be happy to have extra people helping him out.
How would that in any way plug into llvm or
Hello Hans,
Not to muddy the waters or anything, have you thought about the NIR
integration that Rob was thinking about ?
I'm pretty sure he'll be happy to have extra people helping him out.
Cheers,
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesk
On 10 November 2015 at 17:30, Martin Peres wrote:
> Here is an update to the v3, addressing almost all the comments I got during
> the previous round. The one item that is left to do is the handling of
> EGL_BUFFER_PRESERVED which will take some time since I need to write a piglit
> test for it.
>
On Wed, 2015-11-11 at 17:26 -0800, Jason Ekstrand wrote:
> ---
> src/mesa/drivers/dri/i965/brw_fs.cpp | 11 +--
> src/mesa/drivers/dri/i965/brw_nir.c | 1 -
> src/mesa/drivers/dri/i965/brw_vec4.cpp| 5 -
> src/mesa/drivers/dri/i965/brw_vec4_gs_v
On Wed, 2015-11-11 at 17:26 -0800, Jason Ekstrand wrote:
> ---
> src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> i
Hi All,
So as discussed I've started working on a TGSI backend for
llvm to use as a way to get compute going on nouveau (and other gpu-s).
I'm still learning all the ins and outs of llvm so I do not have
much to show yet.
I've rebased Francisco's (curro's) latest version on top of llvm
trunk, a
On 13/11/15 11:32, Tapani Pälli wrote:
> Patch adds additional mask for tracking which vertex buffer bindings
> are set. This array can be directly compared to which vertex arrays
> are enabled and should match when drawing.
>
> Fixes following CTS tests:
>
>ES31-CTS.draw_indirect.negative-
Reviewed-by: Iago Toral Quiroga
On Wed, 2015-11-11 at 17:26 -0800, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir_lower_tex.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/glsl/nir/nir_lower_tex.c b/src/glsl/nir/nir_lower_tex.c
> index 21ed103..6dea837 100644
> --- a/src/glsl/nir
On Wed, 2015-11-11 at 17:26 -0800, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir.h | 2 +-
> src/glsl/nir/nir_lower_tex.c | 19 +++
> 2 files changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h
> index 41125b1..2299ece 100
On 13 November 2015 at 12:56, Samuel Iglesias Gonsálvez
wrote:
> On 13/11/15 13:40, Emil Velikov wrote:
>> On 13 November 2015 at 12:34, Antía Puentes wrote:
>>> On vie, 2015-11-13 at 13:26 +0100, Samuel Iglesias Gonsálvez wrote:
Hello,
I would like to have admin permissions to Mes
On 13 November 2015 at 09:14, Kai Wasserbäch
wrote:
> Hi Emil,
> Emil Velikov wrote on 12.11.2015 18:45:
>> On 12 November 2015 at 15:36, Samuel Iglesias Gonsálvez
>> wrote:
>>> On 12/11/15 15:28, Timothy Arceri wrote:
On 13 November 2015 12:22:39 am AEDT, "Samuel Iglesias Gonsálvez"
On 13/11/15 13:40, Emil Velikov wrote:
> On 13 November 2015 at 12:34, Antía Puentes wrote:
>> On vie, 2015-11-13 at 13:26 +0100, Samuel Iglesias Gonsálvez wrote:
>>> Hello,
>>>
>>> I would like to have admin permissions to Mesa and Piglit projects in
>>> patchwork [0] to change the status of pa
On Fri, Nov 13, 2015 at 7:40 AM, Emil Velikov wrote:
> On 13 November 2015 at 12:34, Antía Puentes wrote:
>> On vie, 2015-11-13 at 13:26 +0100, Samuel Iglesias Gonsálvez wrote:
>>> Hello,
>>>
>>> I would like to have admin permissions to Mesa and Piglit projects in
>>> patchwork [0] to change the
On 13 November 2015 at 12:34, Antía Puentes wrote:
> On vie, 2015-11-13 at 13:26 +0100, Samuel Iglesias Gonsálvez wrote:
>> Hello,
>>
>> I would like to have admin permissions to Mesa and Piglit projects in
>> patchwork [0] to change the status of patches that are mine but they
>> are not assigned
On vie, 2015-11-13 at 13:26 +0100, Samuel Iglesias Gonsálvez wrote:
> Hello,
>
> I would like to have admin permissions to Mesa and Piglit projects in
> patchwork [0] to change the status of patches that are mine but they
> are not assigned to me.
As Samuel, I would like to have admin permissions
On Fri, 2015-11-06 at 12:21 -0800, Matt Turner wrote:
> On Fri, Nov 6, 2015 at 8:27 AM, Juan A. Suarez Romero
> Looks good to me, and we use _mesa_fls elsewhere to do this same
> calculation.
>
> Reviewed-by: Matt Turner
>
> Jason, was there some reason we weren't doing this? I'm confused why
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hello,
I would like to have admin permissions to Mesa and Piglit projects in
patchwork [0] to change the status of patches that are mine but they
are not assigned to me.
I saw in previous emails than just asking for it here is enough. If I
need to
On 11/13/2015 12:36 PM, Juha-Pekka Heikkila wrote:
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/mesa/drivers/dri/i965/brw_eu_validate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_eu_validate.c
> b/src/mesa/drivers/dri/i965/brw_eu_v
Ben Widawsky writes:
> Here is one proposal to fix the issue. I noticed that only formats
> without alpha were failing. This sucks for RGBX formats (which
> technically aren't fast clearable based on the surface format). The
> hunk for moving the format should happen regardless of this patch.
If
Signed-off-by: Juha-Pekka Heikkila
---
src/mesa/drivers/dri/i965/brw_eu_validate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_eu_validate.c
b/src/mesa/drivers/dri/i965/brw_eu_validate.c
index eb57962..2de2ea1 100644
--- a/src/mesa/drivers/dr
Patch adds additional mask for tracking which vertex buffer bindings
are set. This array can be directly compared to which vertex arrays
are enabled and should match when drawing.
Fixes following CTS tests:
ES31-CTS.draw_indirect.negative-noVBO-arrays
ES31-CTS.draw_indirect.negative-noVBO-e
On 12 November 2015 at 16:47, Jason Ekstrand wrote:
> On Thu, Nov 12, 2015 at 6:46 AM, Pekka Paalanen wrote:
>> Reviewed-by: Pekka Paalanen
>>
>> Perhaps a TODO comment referring to
>> https://bugs.freedesktop.org/show_bug.cgi?id=78190
>> would be nice.
>
> Yes, that would be good. One day, we
Hi Emil,
Emil Velikov wrote on 12.11.2015 18:45:
> On 12 November 2015 at 15:36, Samuel Iglesias Gonsálvez
> wrote:
>> On 12/11/15 15:28, Timothy Arceri wrote:
>>> On 13 November 2015 12:22:39 am AEDT, "Samuel Iglesias Gonsálvez"
>>> wrote:
'shared' was added in ARB_uniform_buffer_object an
If a source operand in a MOV has source modifiers, then we cannot
copy-propagate it from the parent instruction and remove the MOV.
v2: remove the check for source modifiers from is_move() (Jason)
v3: Put the check for source modifiers back into is_move() since
this function is called from co
On Thu, Nov 12, 2015 at 03:38:52PM -0800, Kenneth Graunke wrote:
> This was getting pretty out of hand, and with compute partially in place
> and tessellation on the way, it was only going to get worse.
>
> This patch makes a "stage exists?" predicate and a "number of stages"
> count and uses them
On Thu, Nov 12, 2015 at 03:38:51PM -0800, Kenneth Graunke wrote:
> I was going to add scalar_tcs and scalar_tes flags, and then thought
> better of it and decided to convert this to an array. Simpler.
>
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/drivers/dri/i965/brw_compiler.h |
101 - 152 of 152 matches
Mail list logo
