Re: [Mesa-dev] [PATCH] travis: Initial import of travis instructions.

2015-11-24 Thread Jose Fonseca
On 24/11/15 21:38, Rob Clark wrote: On Tue, Nov 24, 2015 at 4:10 PM, Eric Anholt wrote: Rob Clark writes: On Tue, Nov 24, 2015 at 2:10 PM, Ilia Mirkin wrote: On Tue, Nov 24, 2015 at 2:04 PM, Eric Anholt wrote: This just builds/installs our dependencies, and runs "make check". I'm intere

Re: [Mesa-dev] [PATCH] i965: Don't inline intel_batchbuffer_require_space().

2015-11-24 Thread Kenneth Graunke
On Tuesday, November 24, 2015 05:17:29 PM Matt Turner wrote: > It's called by the inline intel_batchbuffer_begin() function which > itself is used in BEGIN_BATCH. So in sequence of code emitting multiple > packets, we have inlined this ~200 byte function multiple times. Making > it an out-of-line f

[Mesa-dev] [PATCH 2/2] i965: Fix scalar vertex shader struct outputs.

2015-11-24 Thread Kenneth Graunke
While we correctly set output[] for composite varyings, we set completely bogus values for output_components[], making emit_urb_writes() output zeros instead of the actual values. Unfortunately, our simple approach goes out the window, and we need to recurse into structs to get the proper value of

[Mesa-dev] [PATCH 1/2] i965: Fix fragment shader struct inputs.

2015-11-24 Thread Kenneth Graunke
Apparently we have literally no support for FS varying struct inputs. This is somewhat surprising, given that we've had tests for that very feature that have been passing for a long time. Normally, varying packing splits up structures for us, so we don't see them in the backend. However, with SSO

Re: [Mesa-dev] [PATCH v3] mesa: error out in indirect draw when vertex bindings mismatch

2015-11-24 Thread Fredrik Höglund
On Tuesday 24 November 2015, Tapani Pälli wrote: > Patch adds additional mask for tracking which vertex arrays have > associated vertex buffer binding set. This array can be directly > compared to which vertex arrays are enabled and should match when > drawing. > > Fixes following CTS tests: > >

[Mesa-dev] [PATCH 7/8] xlib: Unify the style of function pointer calls in structs

2015-11-24 Thread Boyan Ding
Signed-off-by: Boyan Ding --- src/mesa/drivers/x11/glxapi.c | 144 +- 1 file changed, 72 insertions(+), 72 deletions(-) diff --git a/src/mesa/drivers/x11/glxapi.c b/src/mesa/drivers/x11/glxapi.c index a870e94..a3993d5 100644 --- a/src/mesa/drivers/x11/glxa

Re: [Mesa-dev] [PATCH] i965: Don't inline intel_batchbuffer_require_space().

2015-11-24 Thread Abdiel Janulgue
On 11/25/2015 03:17 AM, Matt Turner wrote: > It's called by the inline intel_batchbuffer_begin() function which > itself is used in BEGIN_BATCH. So in sequence of code emitting multiple > packets, we have inlined this ~200 byte function multiple times. Making > it an out-of-line function presumab

[Mesa-dev] [PATCH 8/8] program: Unify the style of function pointer calls in structs

2015-11-24 Thread Boyan Ding
Signed-off-by: Boyan Ding --- src/mesa/program/prog_hash_table.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/program/prog_hash_table.c b/src/mesa/program/prog_hash_table.c index 5592b6f..25ca6b3 100644 --- a/src/mesa/program/prog_hash_table.c +++ b/src

[Mesa-dev] [PATCH 5/8] nouveau: Unify the style of function pointer calls in structs

2015-11-24 Thread Boyan Ding
Signed-off-by: Boyan Ding --- src/mesa/drivers/dri/nouveau/nouveau_context.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/nouveau/nouveau_context.c b/src/mesa/drivers/dri/nouveau/nouveau_context.c index cb854b8..6ddcadc 100644 --- a/src/mesa/driv

[Mesa-dev] [PATCH 3/8] loader/dri3: Unify the style of function pointer calls in structs

2015-11-24 Thread Boyan Ding
Signed-off-by: Boyan Ding --- src/loader/loader_dri3_helper.c | 74 - 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c index 62bfe84..ca0f7a0 100644 --- a/src/loader/loader_dri

[Mesa-dev] [PATCH 1/8] egl/dri2: Unify the style of function pointer calls in structs

2015-11-24 Thread Boyan Ding
Signed-off-by: Boyan Ding --- src/egl/drivers/dri2/egl_dri2.c | 10 -- src/egl/drivers/dri2/platform_android.c | 8 src/egl/drivers/dri2/platform_drm.c | 14 +++--- src/egl/drivers/dri2/platform_wayland.c | 14 +++--- src/egl/drivers/dri2/platform_x11

[Mesa-dev] [PATCH 4/8] glX_proto_send.py: Unify the style of function pointer calls in structs

2015-11-24 Thread Boyan Ding
Signed-off-by: Boyan Ding --- src/mapi/glapi/gen/glX_proto_send.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/glX_proto_send.py b/src/mapi/glapi/gen/glX_proto_send.py index 2b33030..27e2d87 100644 --- a/src/mapi/glapi/gen/glX_proto_send.py +++ b/src/ma

[Mesa-dev] [PATCH 6/8] radeon: Unify the style of function pointer calls in structs

2015-11-24 Thread Boyan Ding
Signed-off-by: Boyan Ding --- src/mesa/drivers/dri/radeon/radeon_common.c| 4 ++-- .../drivers/dri/radeon/radeon_common_context.c | 24 +++--- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/mesa/drivers/dri/radeon/radeon_common.c b/src/mesa/driv

[Mesa-dev] [PATCH 2/8] glx: Unify the style of function pointer calls in structs

2015-11-24 Thread Boyan Ding
Signed-off-by: Boyan Ding --- src/glx/dri3_glx.c | 2 +- src/glx/dri_common.c | 4 ++-- src/glx/glxcmds.c| 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/glx/dri3_glx.c b/src/glx/dri3_glx.c index ee24312..8a4d893 100644 --- a/src/glx/dri3_glx.c +++ b/src/glx/dr

[Mesa-dev] Unify the style of function pointer calls in structs

2015-11-24 Thread Boyan Ding
This series is a follow-up of Brian's patch ([1], commit 47fae842). It converts nearly all of the function-pointer-in-a-struct calls from (*foo->bar)(...) or (foo->bar)(...) to foo->bar(...) The sed regex to do the conversion looks like this (really ugly): s/(\*\?\([^*(), \]]*->[^*), \]]*\))

[Mesa-dev] [PATCH] i965: Don't inline intel_batchbuffer_require_space().

2015-11-24 Thread Matt Turner
It's called by the inline intel_batchbuffer_begin() function which itself is used in BEGIN_BATCH. So in sequence of code emitting multiple packets, we have inlined this ~200 byte function multiple times. Making it an out-of-line function presumably improved icache usage. Improves performance of Gl

[Mesa-dev] [PATCH] gallium/tests: fix build with clang compiler

2015-11-24 Thread Samuel Pitoiset
Nested functions are supported as an extension in GNU C, but Clang don't support them. This fixes compilation errors when (manually) building compute.c, or by setting --enable-gallium-tests to the configure script. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75165 Signed-off-by: Samue

[Mesa-dev] [Bug 93091] [opencl] segfault when running any opencl programs (like clinfo)

2015-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93091 --- Comment #6 from Aaron Watry --- Created attachment 120098 --> https://bugs.freedesktop.org/attachment.cgi?id=120098&action=edit gdb output and backtrace for clinfo -- You are receiving this mail because: You are the QA Contact for the bug

[Mesa-dev] [Bug 93091] [opencl] segfault when running any opencl programs (like clinfo)

2015-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93091 --- Comment #5 from Aaron Watry --- Created attachment 120097 --> https://bugs.freedesktop.org/attachment.cgi?id=120097&action=edit output of "valgrind clinfo" -- You are receiving this mail because: You are the QA Contact for the bug. You ar

[Mesa-dev] [Bug 93091] [opencl] segfault when running any opencl programs (like clinfo)

2015-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93091 --- Comment #4 from Aaron Watry --- Hmm. I'm still getting a segfault with the proposed patch. Valgrind and gdb output in a second. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. _

[Mesa-dev] [PATCH] glapi: remove the final function offset tags

2015-11-24 Thread Emil Velikov
A commit earlier this year reworked out python scripts to use a separate file for these. Followed by removing support from the parser, and removing all of the offset tags. Seems like we either missed a few, or people added them by mistake. Either way let's nuke the ones that are still around. Cc:

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

2015-11-24 Thread Kyle Brenneman
On 11/24/2015 02:49 PM, Emil Velikov wrote: On 24 November 2015 at 20:22, Kyle Brenneman wrote: On 11/13/2015 12:50 PM, Kyle Brenneman wrote: I agree that a separate directory from the other GL headers would be best. I'm leaning toward putting the libglvnd headers into a sibling directory to th

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

2015-11-24 Thread Emil Velikov
On 24 November 2015 at 20:22, Kyle Brenneman wrote: > On 11/13/2015 12:50 PM, Kyle Brenneman wrote: > I agree that a separate directory from the other GL headers would be best. > I'm leaning toward putting the libglvnd headers into a sibling directory to > the GL headers, probably /usr/include/GL

Re: [Mesa-dev] [PATCH] swrast: Fix the coordinates passed to _mesa_regions_overlap()

2015-11-24 Thread Anuj Phogat
On Mon, Nov 23, 2015 at 8:29 PM, Matt Turner wrote: > On Mon, Nov 23, 2015 at 5:35 PM, Anuj Phogat wrote: >> Cc: "11.1" >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/swrast/s_copypix.c | 6 -- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/src/mesa/swrast/s_copypi

Re: [Mesa-dev] [PATCH] travis: Initial import of travis instructions.

2015-11-24 Thread Rob Clark
On Tue, Nov 24, 2015 at 4:10 PM, Eric Anholt wrote: > Rob Clark writes: > >> On Tue, Nov 24, 2015 at 2:10 PM, Ilia Mirkin wrote: >>> On Tue, Nov 24, 2015 at 2:04 PM, Eric Anholt wrote: This just builds/installs our dependencies, and runs "make check". I'm interested in integrating mo

Re: [Mesa-dev] [PATCH] i965: Don't check for draw-time errors that cannot occur in core profile

2015-11-24 Thread Matt Turner
On Mon, Aug 10, 2015 at 10:12 AM, Ian Romanick wrote: > From: Ian Romanick > > On many CPU-limited applications, this is *the* hot path. The idea is > to generate per-API versions of brw_draw_prims that elide some checks. > This patch removes render-mode and "is everything in VBOs" checks from >

Re: [Mesa-dev] [PATCH] travis: Initial import of travis instructions.

2015-11-24 Thread Eric Anholt
Rob Clark writes: > On Tue, Nov 24, 2015 at 2:10 PM, Ilia Mirkin wrote: >> On Tue, Nov 24, 2015 at 2:04 PM, Eric Anholt wrote: >>> This just builds/installs our dependencies, and runs "make check". I'm >>> interested in integrating more tests into it, but this seems like a pretty >>> easy firs

Re: [Mesa-dev] [Freedreno] [PATCH] docs: add freedreno to GL3.txt

2015-11-24 Thread Ilia Mirkin
On Tue, Nov 24, 2015 at 3:47 PM, Rob Clark wrote: > On Tue, Nov 24, 2015 at 3:37 PM, Ilia Mirkin wrote: >> The Adreno A4xx GPU should be capable of a large fraction if not >> all of the desktop GL 4.5 features. >> >> Signed-off-by: Ilia Mirkin >> --- >> docs/GL3.txt | 70 >> +++

Re: [Mesa-dev] [Freedreno] [PATCH] docs: add freedreno to GL3.txt

2015-11-24 Thread Rob Clark
On Tue, Nov 24, 2015 at 3:37 PM, Ilia Mirkin wrote: > The Adreno A4xx GPU should be capable of a large fraction if not > all of the desktop GL 4.5 features. > > Signed-off-by: Ilia Mirkin > --- > docs/GL3.txt | 70 > ++-- > 1 file changed,

[Mesa-dev] [PATCH] docs: add freedreno to GL3.txt

2015-11-24 Thread Ilia Mirkin
The Adreno A4xx GPU should be capable of a large fraction if not all of the desktop GL 4.5 features. Signed-off-by: Ilia Mirkin --- docs/GL3.txt | 70 ++-- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/docs/GL3.txt b/docs/

Re: [Mesa-dev] [PATCH 10/11] gallium: do not wrap header inclusion in extern "C"

2015-11-24 Thread Jose Fonseca
On 24/11/15 18:24, Emil Velikov wrote: On 24 November 2015 at 17:08, Jose Fonseca wrote: On 24/11/15 16:29, Emil Velikov wrote: From: Emil Velikov Add one missing extern C guard within include/pipe/p_video_enums.h, and remove the wrapping throughout gallium. On Haiku one could even use the

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

2015-11-24 Thread Kyle Brenneman
On 11/13/2015 12:50 PM, Kyle Brenneman wrote: On 10/08/2015 12:29 PM, Emil Velikov wrote: On 06/10/15 20:58, Kyle Brenneman wrote: On 10/06/2015 12:43 PM, Emil Velikov wrote: On 6 October 2015 at 16:39, Kyle Brenneman wrote: On 10/06/2015 07:34 AM, Emil Velikov wrote: Hello Kyle, A few que

Re: [Mesa-dev] [PATCH] travis: Initial import of travis instructions.

2015-11-24 Thread Dave Airlie
>> but then I noticed that http://tinderbox.x.org/ is in kind of dire shape.. >> :-( > > Is it? > > http://tinderbox.x.org/builds/2015-11-24-0009/ > > It looks like xf86-video-v4l and -wsfb are failing, and that's it. Well I think he meant the website, rather than the build state. The tinderbox

Re: [Mesa-dev] [PATCH 1/4] glsl: remove trailing spaces in ast_to_hir.cpp

2015-11-24 Thread Kenneth Graunke
On Tuesday, November 24, 2015 12:47:35 PM Iago Toral Quiroga wrote: > --- > src/glsl/ast_to_hir.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp > index 81cde73..8fcda63 100644 > --- a/src/glsl/ast_to_hir.cpp > ++

Re: [Mesa-dev] [PATCH 01/11] i965: remove trailing space in brw_blorp_blit.cpp

2015-11-24 Thread Kenneth Graunke
On Tuesday, November 24, 2015 01:07:02 PM Iago Toral Quiroga wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp > b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp > index

Re: [Mesa-dev] [PATCH 01/13] util: Include assert.h in macros.h.

2015-11-24 Thread Matt Turner
On Tue, Nov 24, 2015 at 11:19 AM, Emil Velikov wrote: > Hi Matt, > > Did you go through all the header requirements by hand ? > Include-what-you-use looks appealing, despite that sometimes it sorts > includes in reverse order (and adds indirect dependencies). No, I used include-what-you-use but t

Re: [Mesa-dev] [PATCH] travis: Initial import of travis instructions.

2015-11-24 Thread Matt Turner
On Tue, Nov 24, 2015 at 11:13 AM, Rob Clark wrote: > On Tue, Nov 24, 2015 at 2:10 PM, Ilia Mirkin wrote: >> On Tue, Nov 24, 2015 at 2:04 PM, Eric Anholt wrote: >>> This just builds/installs our dependencies, and runs "make check". I'm >>> interested in integrating more tests into it, but this s

Re: [Mesa-dev] [PATCH 01/13] util: Include assert.h in macros.h.

2015-11-24 Thread Emil Velikov
Hi Matt, Did you go through all the header requirements by hand ? Include-what-you-use looks appealing, despite that sometimes it sorts includes in reverse order (and adds indirect dependencies). -Emil ___ mesa-dev mailing list mesa-dev@lists.freedeskto

Re: [Mesa-dev] [PATCH] travis: Initial import of travis instructions.

2015-11-24 Thread Rob Clark
On Tue, Nov 24, 2015 at 2:10 PM, Ilia Mirkin wrote: > On Tue, Nov 24, 2015 at 2:04 PM, Eric Anholt wrote: >> This just builds/installs our dependencies, and runs "make check". I'm >> interested in integrating more tests into it, but this seems like a pretty >> easy first start. >> >> If your per

Re: [Mesa-dev] [PATCH] travis: Initial import of travis instructions.

2015-11-24 Thread Ilia Mirkin
On Tue, Nov 24, 2015 at 2:04 PM, Eric Anholt wrote: > This just builds/installs our dependencies, and runs "make check". I'm > interested in integrating more tests into it, but this seems like a pretty > easy first start. > > If your personal branches of Mesa are on github, you can enable it on y

[Mesa-dev] [PATCH] travis: Initial import of travis instructions.

2015-11-24 Thread Eric Anholt
This just builds/installs our dependencies, and runs "make check". I'm interested in integrating more tests into it, but this seems like a pretty easy first start. If your personal branches of Mesa are on github, you can enable it on your account and the repository (see https://docs.travis-ci.com

[Mesa-dev] [Bug 93092] lp_test_format regression

2015-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93092 Roland Scheidegger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 93091] [opencl] segfault when running any opencl programs (like clinfo)

2015-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93091 --- Comment #3 from Emil Velikov --- (In reply to Dieter Nützel from comment #2) > (In reply to Emil Velikov from comment #1) > > Without debug symbols, the backtrace isn't that useful. Before you install > > the extra dbg packages or anything el

Re: [Mesa-dev] [PATCH 10/11] gallium: do not wrap header inclusion in extern "C"

2015-11-24 Thread Emil Velikov
On 24 November 2015 at 17:08, Jose Fonseca wrote: > On 24/11/15 16:29, Emil Velikov wrote: >> >> From: Emil Velikov >> >> Add one missing extern C guard within include/pipe/p_video_enums.h, and >> remove the wrapping throughout gallium. >> >> On Haiku one could even use the gallium debug_printf()

Re: [Mesa-dev] [PATCH] glsl: Pass ast_type_qualifier by const reference.

2015-11-24 Thread Matt Turner
On Tue, Nov 24, 2015 at 2:34 AM, Iago Toral wrote: > On Mon, 2015-11-23 at 18:08 -0800, Matt Turner wrote: >> Coverity noticed that we were passing this by value, and it's 152 bytes. >> --- >> src/glsl/ast.h | 10 +- >> src/glsl/ast_type.cpp | 6 +++--- >> src/

Re: [Mesa-dev] [PATCH] Revert "i965: Combine assembly annotations if possible."

2015-11-24 Thread Matt Turner
On Tue, Nov 24, 2015 at 2:55 AM, Kenneth Graunke wrote: > This reverts commit a280e83d71bb046098ed5380cb053318f9e8cf8e. > > It breaks INTEL_DEBUG=fs output. For example, > glsl-fs-discard-01.shader_test has 11 instructions but only prints 5. > --- Acked-by: Mat Turner __

Re: [Mesa-dev] [PATCH] nir: include what we want/need

2015-11-24 Thread Jason Ekstrand
Assuming you compile-tested, Reviewed-by: Jason Ekstrand Thanks! On Tue, Nov 24, 2015 at 8:30 AM, Emil Velikov wrote: > From: Emil Velikov > > Swap core.h with macros.h, as the latter provides the required MAX2 > macro. > > Signed-off-by: Emil Velikov > --- > src/glsl/nir/glsl_types.cpp | 2

Re: [Mesa-dev] [PATCH 2/2] softpipe/llvmpipe: don't advertize support for ASTC

2015-11-24 Thread Ilia Mirkin
On Tue, Nov 24, 2015 at 12:07 PM, Roland Scheidegger wrote: > Am 24.11.2015 um 17:58 schrieb Ilia Mirkin: >> Series is >> >> Reviewed-by: Ilia Mirkin >> >> Sorry for the breakage! > No problem. I think initially the idea was that every format would be > supported by util helpers for format fetch.

Re: [Mesa-dev] [PATCH 2/2] softpipe/llvmpipe: don't advertize support for ASTC

2015-11-24 Thread Roland Scheidegger
Am 24.11.2015 um 17:58 schrieb Ilia Mirkin: > Series is > > Reviewed-by: Ilia Mirkin > > Sorry for the breakage! No problem. I think initially the idea was that every format would be supported by util helpers for format fetch. But this is no longer true, so softpipe, llvmpipe, and lp_test_format

Re: [Mesa-dev] [PATCH 10/11] gallium: do not wrap header inclusion in extern "C"

2015-11-24 Thread Jose Fonseca
On 24/11/15 16:29, Emil Velikov wrote: From: Emil Velikov Add one missing extern C guard within include/pipe/p_video_enums.h, and remove the wrapping throughout gallium. On Haiku one could even use the gallium debug_printf() although that's another topic. Cc: Jose Fonseca Cc: Brian Paul Cc:

Re: [Mesa-dev] [PATCH 2/2] softpipe/llvmpipe: don't advertize support for ASTC

2015-11-24 Thread Jose Fonseca
On 24/11/15 16:56, srol...@vmware.com wrote: From: Roland Scheidegger 9775565154040e0c4ea2e196217dccc08cdf added support for ASTC textures to gallium. They don't have any helpers hooked up for software decoding, however, so cannot support them in drivers relying on util code for decoding. -

Re: [Mesa-dev] [PATCH 2/2] softpipe/llvmpipe: don't advertize support for ASTC

2015-11-24 Thread Ilia Mirkin
Series is Reviewed-by: Ilia Mirkin Sorry for the breakage! On Tue, Nov 24, 2015 at 11:56 AM, wrote: > From: Roland Scheidegger > > 9775565154040e0c4ea2e196217dccc08cdf added support for ASTC textures to > gallium. They don't have any helpers hooked up for software decoding, however, > so

[Mesa-dev] [PATCH 2/2] softpipe/llvmpipe: don't advertize support for ASTC

2015-11-24 Thread sroland
From: Roland Scheidegger 9775565154040e0c4ea2e196217dccc08cdf added support for ASTC textures to gallium. They don't have any helpers hooked up for software decoding, however, so cannot support them in drivers relying on util code for decoding. --- src/gallium/drivers/llvmpipe/lp_screen.c |

[Mesa-dev] [PATCH 1/2] llvmpipe: don't test for unsupported formats in lp_test_format

2015-11-24 Thread sroland
From: Roland Scheidegger Removing the fake format helpers (1c7d0a6aa4f5cb38af7e281e1e5437cd1a20f781) caused this to fail. These formats were never supported, but previously they would have asserted in the generated jit functions (which, due to lack of test cases for these formats, were never call

Re: [Mesa-dev] Mesa (master): gallium/util: remove the fake format helpers for bptc and etc2

2015-11-24 Thread Roland Scheidegger
Am 24.11.2015 um 16:08 schrieb Roland Scheidegger: > Am 24.11.2015 um 16:04 schrieb Ilia Mirkin: >> On Tue, Nov 24, 2015 at 1:37 AM, Michel Dänzer wrote: >>> On 24.11.2015 01:21, Ilia Mirkin wrote: Module: Mesa Branch: master Commit: 1c7d0a6aa4f5cb38af7e281e1e5437cd1a20f781 URL

[Mesa-dev] [PATCH] nir: include what we want/need

2015-11-24 Thread Emil Velikov
From: Emil Velikov Swap core.h with macros.h, as the latter provides the required MAX2 macro. Signed-off-by: Emil Velikov --- src/glsl/nir/glsl_types.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/glsl_types.cpp b/src/glsl/nir/glsl_types.cpp index 9cc3715.

[Mesa-dev] [PATCH 10/11] gallium: do not wrap header inclusion in extern "C"

2015-11-24 Thread Emil Velikov
From: Emil Velikov Add one missing extern C guard within include/pipe/p_video_enums.h, and remove the wrapping throughout gallium. On Haiku one could even use the gallium debug_printf() although that's another topic. Cc: Jose Fonseca Cc: Brian Paul Cc: Alexander von Gluck IV Signed-off-by: E

[Mesa-dev] [PATCH 00/11] do not wrap header inclusion in extern "C"

2015-11-24 Thread Emil Velikov
Hi all, As pointed out by Jose a while back adding extern C guard around header inclusion is a bad idea. As I noticed a few in the glsl/nir code I went on and grepped through mesa. I have build tested the series on Linux only, yet patch 10/11 contains some windows/haiku specific code. Regardle

[Mesa-dev] [PATCH 07/11] i965: do not wrap header inclusion in extern "C"

2015-11-24 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_vec4.h | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h b/src/mesa/drivers/dri/i965/brw_vec4.h index 3f67432..574d134 100644 --- a/src/mes

[Mesa-dev] [PATCH 03/11] glsl: do not wrap header inclusion in extern "C"

2015-11-24 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/glsl/blob.h | 4 ++-- src/glsl/nir/glsl_types.h | 9 ++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/glsl/blob.h b/src/glsl/blob.h index ec903ec..7fd6e33 100644 --- a/src/glsl/blob.h +++ b/src/glsl/blo

[Mesa-dev] [PATCH 04/11] util/sha: do not wrap header inclusion in extern "C"

2015-11-24 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/util/mesa-sha1.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/mesa-sha1.h b/src/util/mesa-sha1.h index 1599405..0be5485 100644 --- a/src/util/mesa-sha1.h +++ b/src/util/mesa-sha1.h @@ -23,12 +23,12 @@ #i

[Mesa-dev] [PATCH 06/11] i915: limit extern "C" hack only for libdrm headers

2015-11-24 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i915/intel_context.h | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i915/intel_context.h b/src/mesa/drivers/dri/i915/intel_context.h index aecd7c2..39b328a 100644 ---

[Mesa-dev] [PATCH 05/11] xmesa: do not wrap header inclusion in extern "C"

2015-11-24 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/mesa/drivers/x11/xmesa.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/x11/xmesa.h b/src/mesa/drivers/x11/xmesa.h index b6a2576..cc878e7 100644 --- a/src/mesa/drivers/x11/xmesa.h +++ b/src/mesa

[Mesa-dev] [PATCH 02/11] egl/wayland: do not wrap header inclusion in extern "C"

2015-11-24 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/wayland/wayland-egl/wayland-egl-priv.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/egl/wayland/wayland-egl/wayland-egl-priv.h b/src/egl/wayland/wayland-egl/wayland-egl-priv.h index 74a1552..f1e3ba2 1

[Mesa-dev] [PATCH 11/11] winsys/amdgpu/addrlib: do not wrap header inclusion in extern "C"

2015-11-24 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/gallium/winsys/amdgpu/drm/addrlib/addrinterface.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/addrlib/addrinterface.h b/src/gallium/winsys/amdgpu/drm/addrlib/addrinterface.h index 0

[Mesa-dev] [PATCH 08/11] mesa/main: remove unneeded extern "C" wrapping

2015-11-24 Thread Emil Velikov
From: Emil Velikov The header only contains a few defines and includes some system headers. The latter of which is strongly unadvised. Signed-off-by: Emil Velikov --- src/mesa/main/compiler.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/src/mesa/main/compiler.h b/src/mesa/mai

[Mesa-dev] [PATCH 09/11] mesa/main: do not wrap header inclusion in extern "C"

2015-11-24 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/mesa/main/samplerobj.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/samplerobj.h b/src/mesa/main/samplerobj.h index 7bea911..8c2325c 100644 --- a/src/mesa/main/samplerobj.h +++ b/src/mesa/main/samp

[Mesa-dev] [PATCH 01/11] gbm: do not wrap header inclusion in extern "C"

2015-11-24 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/gbm/main/gbm.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gbm/main/gbm.h b/src/gbm/main/gbm.h index 8db2153..63d9a9e 100644 --- a/src/gbm/main/gbm.h +++ b/src/gbm/main/gbm.h @@ -28,16 +28,16 @@ #ifnd

Re: [Mesa-dev] [PATCH 0/8] radeonsi: Implement AMD_performance_monitor

2015-11-24 Thread Marek Olšák
On Tue, Nov 24, 2015 at 5:08 PM, Ilia Mirkin wrote: > On Tue, Nov 24, 2015 at 11:00 AM, Nicolai Hähnle wrote: >> One annoyance of the series as it currently stands is that exposing thousands >> of counters affects the context creation time due to the way the Mesa state >> tracker initializes itse

Re: [Mesa-dev] [PATCH 0/8] radeonsi: Implement AMD_performance_monitor

2015-11-24 Thread Ilia Mirkin
On Tue, Nov 24, 2015 at 11:00 AM, Nicolai Hähnle wrote: > One annoyance of the series as it currently stands is that exposing thousands > of counters affects the context creation time due to the way the Mesa state > tracker initializes itself, especially given that this is a feature that > isn't u

[Mesa-dev] [PATCH 1/2] gallium: add PIPE_DRIVER_QUERY_FLAG_DONT_LIST

2015-11-24 Thread Nicolai Hähnle
This allows the driver to give a hint to the HUD so that GALLIUM_HUD=help is less spammy. --- src/gallium/auxiliary/hud/hud_context.c | 10 +- src/gallium/include/pipe/p_defines.h| 3 +++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_cont

[Mesa-dev] [PATCH 2/2] radeon: use PIPE_DRIVER_QUERY_FLAG_DONT_LIST for perfcounters

2015-11-24 Thread Nicolai Hähnle
Since the query names are not very enlightening, and there are thousands of them, GALLIUM_HUD=help should only show the first and last query name for each hardware block. --- This patch obviously only applies on top of the series implementing AMD_performance_monitor for radeonsi, but it illustrates

[Mesa-dev] [PATCH 4/8] radeonsi/sid: add hardware constants for COPY_DATA packet

2015-11-24 Thread Nicolai Hähnle
--- src/gallium/drivers/radeonsi/sid.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/sid.h b/src/gallium/drivers/radeonsi/sid.h index c2e177d..4e03ceb 100644 --- a/src/gallium/drivers/radeonsi/sid.h +++ b/src/gallium/drivers/radeonsi/sid.h @@ -127,7 +127,10 @

[Mesa-dev] [PATCH 2/8] radeon: add perfcounter-related EVENT_TYPEs

2015-11-24 Thread Nicolai Hähnle
--- src/gallium/drivers/radeon/r600d_common.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeon/r600d_common.h b/src/gallium/drivers/radeon/r600d_common.h index 2f40e52..f32da06 100644 --- a/src/gallium/drivers/radeon/r600d_common.h +++ b/src/gallium/drivers/radeon

[Mesa-dev] [PATCH 6/8] radeon: scale query buffer size to result size

2015-11-24 Thread Nicolai Hähnle
Performance monitor queries can become very big, especially considering that instances of a block in different shader engines are queried separately. --- src/gallium/drivers/radeon/r600_query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_quer

[Mesa-dev] [PATCH 7/8] radeonsi: implement AMD_performance_monitor for CIK+

2015-11-24 Thread Nicolai Hähnle
Expose most of the performance counter groups that are exposed by Catalyst. Ideally, the driver will work with GPUPerfStudio at some point, but we are not quite there yet. In any case, this is the reason for grouping multiple instances of hardware blocks in the way it is implemented. The counters

[Mesa-dev] [PATCH 5/8] radeonsi/sid: add performance counter registers

2015-11-24 Thread Nicolai Hähnle
--- src/gallium/drivers/radeonsi/sid.h | 1013 1 file changed, 1013 insertions(+) diff --git a/src/gallium/drivers/radeonsi/sid.h b/src/gallium/drivers/radeonsi/sid.h index 4e03ceb..d2648e9 100644 --- a/src/gallium/drivers/radeonsi/sid.h +++ b/src/gallium/dri

[Mesa-dev] [PATCH 3/8] radeon: extend CIK_UCONFIG_REG_END for performance counters

2015-11-24 Thread Nicolai Hähnle
--- src/gallium/drivers/radeon/r600d_common.h | 2 +- src/gallium/drivers/radeonsi/sid.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600d_common.h b/src/gallium/drivers/radeon/r600d_common.h index f32da06..b8e6564 100644 --- a/src/gall

[Mesa-dev] [PATCH 1/8] radeon: additional constants for WAIT_REG_MEM and EVENT_WRITE_EOP

2015-11-24 Thread Nicolai Hähnle
--- src/gallium/drivers/radeon/r600d_common.h | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/radeon/r600d_common.h b/src/gallium/drivers/radeon/r600d_common.h index a3d182c..2f40e52 100644 --- a/src/gallium/drivers/radeon/r600d_common.h +++ b/src/gallium/drivers/r

[Mesa-dev] [PATCH 8/8] docs: update relnotes with AMD_performance_monitor for radeonsi

2015-11-24 Thread Nicolai Hähnle
--- docs/relnotes/11.2.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/11.2.0.html b/docs/relnotes/11.2.0.html index 20f4543..c9c0c90 100644 --- a/docs/relnotes/11.2.0.html +++ b/docs/relnotes/11.2.0.html @@ -52,6 +52,7 @@ Note: some of the new features are only available

Re: [Mesa-dev] Mesa (master): gallium/util: remove the fake format helpers for bptc and etc2

2015-11-24 Thread Ilia Mirkin
On Tue, Nov 24, 2015 at 10:08 AM, Roland Scheidegger wrote: > Am 24.11.2015 um 16:04 schrieb Ilia Mirkin: >> On Tue, Nov 24, 2015 at 1:37 AM, Michel Dänzer wrote: >>> On 24.11.2015 01:21, Ilia Mirkin wrote: Module: Mesa Branch: master Commit: 1c7d0a6aa4f5cb38af7e281e1e5437cd1a20f78

[Mesa-dev] [PATCH 0/8] radeonsi: Implement AMD_performance_monitor

2015-11-24 Thread Nicolai Hähnle
Hi, with this series, a first batch of performance counters are usable on CIK+. The registers and programming are slightly different on SI, so support for that might come later. This doesn't cover all hardware blocks with performance counters, in particular some compute and video blocks are missi

Re: [Mesa-dev] [PATCH] targets/dri: android: use WHOLE static libraries

2015-11-24 Thread Emil Velikov
On 24 November 2015 at 15:06, Ilia Mirkin wrote: > On Tue, Nov 24, 2015 at 6:57 AM, Emil Velikov > wrote: >> This is bring behaviour similar to whole-archive, where hunks of the >> static libraries are not discarded and thus the exact order of the >> libraries does not matter. >> >> It has been

Re: [Mesa-dev] Mesa (master): gallium/util: remove the fake format helpers for bptc and etc2

2015-11-24 Thread Roland Scheidegger
Am 24.11.2015 um 16:04 schrieb Ilia Mirkin: > On Tue, Nov 24, 2015 at 1:37 AM, Michel Dänzer wrote: >> On 24.11.2015 01:21, Ilia Mirkin wrote: >>> Module: Mesa >>> Branch: master >>> Commit: 1c7d0a6aa4f5cb38af7e281e1e5437cd1a20f781 >>> URL: >>> https://urldefense.proofpoint.com/v2/url?u=http-3

Re: [Mesa-dev] [PATCH] targets/dri: android: use WHOLE static libraries

2015-11-24 Thread Ilia Mirkin
On Tue, Nov 24, 2015 at 6:57 AM, Emil Velikov wrote: > This is bring behaviour similar to whole-archive, where hunks of the > static libraries are not discarded and thus the exact order of the > libraries does not matter. > > It has been used in i915/i965 for a very long time, we might want to > s

Re: [Mesa-dev] Mesa (master): gallium/util: remove the fake format helpers for bptc and etc2

2015-11-24 Thread Ilia Mirkin
On Tue, Nov 24, 2015 at 1:37 AM, Michel Dänzer wrote: > On 24.11.2015 01:21, Ilia Mirkin wrote: >> Module: Mesa >> Branch: master >> Commit: 1c7d0a6aa4f5cb38af7e281e1e5437cd1a20f781 >> URL: >> http://cgit.freedesktop.org/mesa/mesa/commit/?id=1c7d0a6aa4f5cb38af7e281e1e5437cd1a20f781 >> >> Autho

Re: [Mesa-dev] [PATCH 1/7] i965/fs_surface_builder: Explicitly handle FORMAT_NONE in num_image_coordinates

2015-11-24 Thread Francisco Jerez
Jason Ekstrand writes: > On Mon, Nov 23, 2015 at 6:15 AM, Francisco Jerez > wrote: >> Jason Ekstrand writes: >> >>> On Fri, Nov 20, 2015 at 5:49 AM, Francisco Jerez >>> wrote: Chad Versace writes: > On Wed 04 Nov 2015, Jason Ekstrand wrote: >> Previously, we were relying o

Re: [Mesa-dev] [PATCH] mesa: remove ARB_geometry_shader4

2015-11-24 Thread Lofstedt, Marta
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Kenneth Graunke > Sent: Tuesday, November 24, 2015 12:12 PM > To: mesa-dev@lists.freedesktop.org; Marta Lofstedt > Subject: Re: [Mesa-dev] [PATCH] mesa: remove ARB_geometry_shader4 > > On T

[Mesa-dev] [Bug 93091] [opencl] segfault when running any opencl programs (like clinfo)

2015-11-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93091 --- Comment #2 from Dieter Nützel --- (In reply to Emil Velikov from comment #1) > Without debug symbols, the backtrace isn't that useful. Before you install > the extra dbg packages or anything else try this patch > http://patchwork.freedesktop.

[Mesa-dev] [PATCH v3] mesa: error out in indirect draw when vertex bindings mismatch

2015-11-24 Thread Tapani Pälli
Patch adds additional mask for tracking which vertex arrays have associated vertex buffer binding set. This array can be directly compared to which vertex arrays are enabled and should match when drawing. Fixes following CTS tests: ES31-CTS.draw_indirect.negative-noVBO-arrays ES31-CTS.draw_

Re: [Mesa-dev] [PATCH 1/4] glsl: remove trailing spaces in ast_to_hir.cpp

2015-11-24 Thread Iago Toral
On Tue, 2015-11-24 at 12:26 +, Emil Velikov wrote: > Hi Iago, > > I'm not sure how others feel on the topic, but imho it's not that > useful to have XX patches where each addresses a couple of lines of > whitespace issues. Squashing the lot per section (one for glsl, > another for i965) seems

Re: [Mesa-dev] [PATCH 1/4] glsl: remove trailing spaces in ast_to_hir.cpp

2015-11-24 Thread Emil Velikov
Hi Iago, I'm not sure how others feel on the topic, but imho it's not that useful to have XX patches where each addresses a couple of lines of whitespace issues. Squashing the lot per section (one for glsl, another for i965) seems like a better thing. Then again let see if others feel the same wa

[Mesa-dev] [PATCH 05/11] i965: remove trailing spaces in brw_meta_stencil_blit.c

2015-11-24 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c b/src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c index 4e9aa94..a3daef8 100644 --- a/src/mesa/drivers/dri/i965/brw_met

Re: [Mesa-dev] [PATCH v2 07/42] i965: Implement programming of the L3 configuration.

2015-11-24 Thread Francisco Jerez
Kenneth Graunke writes: > On Monday, November 23, 2015 11:09:22 PM Jordan Justen wrote: >> On 2015-11-17 21:54:39, Jordan Justen wrote: >> > From: Francisco Jerez >> > >> > --- >> > src/mesa/drivers/dri/i965/gen7_l3_state.c | 95 >> > +++ >> > 1 file changed, 95 in

[Mesa-dev] [PATCH 09/11] i965: remove trailing spaces in gen8_ps_state.c

2015-11-24 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/gen8_ps_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/gen8_ps_state.c b/src/mesa/drivers/dri/i965/gen8_ps_state.c index 10e433b..945f710 100644 --- a/src/mesa/drivers/dri/i965/gen8_ps_state.c +++ b/src/mesa/driv

[Mesa-dev] [PATCH 03/11] i965: remove trailing spaces in brw_clip_unfilled.c

2015-11-24 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/brw_clip_unfilled.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_clip_unfilled.c b/src/mesa/drivers/dri/i965/brw_clip_unfilled.c index 9a4d2a9..e18fe45 100644 --- a/src/mesa/drivers/dri/i965/brw_clip_unfille

[Mesa-dev] [PATCH 02/11] i965: remove trailing spaces in brw_clip_tri.c

2015-11-24 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/brw_clip_tri.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c b/src/mesa/drivers/dri/i965/brw_clip_tri.c index cca7eb1..993584e 100644 --- a/src/mesa/drivers/dri/i965/brw_clip_tri.c +++ b/src/mesa/

[Mesa-dev] [PATCH 01/11] i965: remove trailing space in brw_blorp_blit.cpp

2015-11-24 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp index ba11d3d..1dd7554 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp +++ b/s

[Mesa-dev] [PATCH 06/11] i965: remove trailing spaces in brw_sf_emit.c

2015-11-24 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/brw_sf_emit.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_sf_emit.c b/src/mesa/drivers/dri/i965/brw_sf_emit.c index b3ee5c1..458c424 100644 --- a/src/mesa/drivers/dri/i965/brw_sf_emit.c +++ b/src/mesa/

[Mesa-dev] [PATCH 08/11] i965: remove trailing spaces in brw_wm_surface_state.c

2015-11-24 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c index f88f8d5..31b6422 100644 --- a/src/mesa/drivers/dri/i965/brw_wm_surface

  1   2   >