On 8 December 2015 at 04:33, Timothy Arceri
wrote:
>
> On Mon, 2015-12-07 at 14:05 +, Emil Velikov wrote:
>> The third release candidate for Mesa 11.1.0 is now available.
>>
>
> Hi Emil,
>
> 76c09c1792ff1209bd34e1ae0e17b9c4929a892f
>
Shader linking may fail but if glUseProgramStages does not take shader
in use, previously set stages to pipeline should continue to work.
This fixes a subtest in following CTS test:
ES31-CTS.sepshaderobjs.StateInteraction
Signed-off-by: Tapani Pälli
---
Validation checks that we do not have active shader stages that are not
used by the pipeline.
This fixes a subtest in following CTS test:
ES31-CTS.sepshaderobjs.StateInteraction
v2: move as generic validation check for both ES and desktop (Timothy)
Signed-off-by: Tapani Pälli
Patch adds ValidProgramUse flag to gl_shader_program that can be used
to track if a program is fully utilized by program pipeline. Flag is
set by glUseProgramStages and will be used for pipeline validation by
the next patch.
Signed-off-by: Tapani Pälli
Suggested-by:
Hi;
I marked this as v2 as this is alternative approach to patch series
I sent ealier:
http://lists.freedesktop.org/archives/mesa-dev/2015-December/102548.html
I took then direction suggested by Timothy which makes validation step
simpler. These patches fix 2
On 12/07/2015 04:45 PM, Ilia Mirkin wrote:
> On Mon, Dec 7, 2015 at 7:39 AM, Abdiel Janulgue
> wrote:
>> v2 (Francisco Jerez):
>>- Rename HSW_GATHER_CONSTANTS_RESERVED to
>> HSW_GATHER_POOL_ALLOC_MUST_BE_ONE.
>>- Rename BRW_GATHER_* prefix to
On 12/08/2015 01:31 PM, Tapani Pälli wrote:
On 12/08/2015 12:57 PM, Timothy Arceri wrote:
On Tue, 2015-12-08 at 11:16 +0200, Tapani Pälli wrote:
Validation checks that we do not have active shader stages that are
not
used by the pipeline.
This fixes a subtest in following CTS test:
For the series:
Reviewed-by: Marek Olšák
Marek
On Mon, Dec 7, 2015 at 2:44 PM, Edward O'Callaghan
wrote:
> Signed-off-by: Edward O'Callaghan
> ---
> docs/GL3.txt | 2 +-
>
https://bugs.freedesktop.org/show_bug.cgi?id=93261
--- Comment #1 from Martin Peres ---
I can reproduce the issue, I will investigate this issue this week!
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
On 7 December 2015 at 18:55, Rob Clark wrote:
> On Mon, Dec 7, 2015 at 1:42 PM, Emil Velikov wrote:
>> On 7 December 2015 at 16:45, Rob Clark wrote:
>>> From: Rob Clark
>>>
>>> Only exposed w/
On Tue, 2015-12-08 at 11:16 +0200, Tapani Pälli wrote:
> Validation checks that we do not have active shader stages that are
> not
> used by the pipeline.
>
> This fixes a subtest in following CTS test:
> ES31-CTS.sepshaderobjs.StateInteraction
>
> v2: move as generic validation check for
On 12/08/2015 12:57 PM, Timothy Arceri wrote:
On Tue, 2015-12-08 at 11:16 +0200, Tapani Pälli wrote:
Validation checks that we do not have active shader stages that are
not
used by the pipeline.
This fixes a subtest in following CTS test:
ES31-CTS.sepshaderobjs.StateInteraction
v2:
In core profile even if re-linking fails rendering shouldn't fail as the
previous succesfully linked program will still be available. It also
shouldn't be possible to have an unlinked program as part of the
current rendering state.
This fixes a subtest in:
ES31-CTS.sepshaderobjs.StateInteraction
On 07/12/15 16:13, olivier.pena...@gmail.com wrote:
From: Olivier Pena
---
scons/llvm.py | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/scons/llvm.py b/scons/llvm.py
index c59b8cb..1fc8a3f 100644
--- a/scons/llvm.py
+++ b/scons/llvm.py
@@
On 12/08/2015 03:55 PM, Timothy Arceri wrote:
On Tue, 2015-12-08 at 13:34 +0200, Tapani Pälli wrote:
On 12/08/2015 01:31 PM, Tapani Pälli wrote:
On 12/08/2015 12:57 PM, Timothy Arceri wrote:
On Tue, 2015-12-08 at 11:16 +0200, Tapani Pälli wrote:
Validation checks that we do not have active
On 08/12/15 01:42, Brian Paul wrote:
When a buffer is created with GL_STATIC_DRAW, its contents should not
be changed frequently. But that's exactly what one application I'm
debugging does. This patch adds code to try to detect inefficient
buffer use in a couple places. The
On Tue, 2015-12-08 at 13:34 +0200, Tapani Pälli wrote:
> On 12/08/2015 01:31 PM, Tapani Pälli wrote:
> > On 12/08/2015 12:57 PM, Timothy Arceri wrote:
> > > On Tue, 2015-12-08 at 11:16 +0200, Tapani Pälli wrote:
> > > > Validation checks that we do not have active shader stages that
> > > > are
>
On 4 December 2015 at 17:37, wrote:
> On 2015-12-05 01:33, Emil Velikov wrote:
>>
>> You mentioned that you've done these with a Coccinelle schematic patch
>> (script) - mind if we get that (actually start collecting) in tree ...
>> perhaps in bin/ or bin/cocci/ ?
This will cause validation to run during next draw, this is done
because possible changes in used stages and programs can cause
invalid pipeline state.
This fixes a subtest in following CTS test:
ES31-CTS.sepshaderobjs.StateInteraction
Signed-off-by: Tapani Pälli
If EGL_KHR_surfaceless_context is used then glViewport can be called
with NULL for the draw and read surfaces. This was previously causing
a crash because the i965 driver tries to use this point to invalidate
the surfaces and it was derferencing the NULL pointer.
Bugzilla:
This is going to require some rather intrusive kernel changes to fix
properly, in the meantime (and forever on at least pre-v4.1 kernels)
we'll have to restore the hardware defaults at the end of every batch
in which the L3 configuration was changed to avoid interfering with
the DDX and GL clients
On 06.12.2015 19:00, Marek Olšák wrote:
From: Marek Olšák
This simplified (basically duplicated) version of pb_cache_manager will
allow removing some ugly hacks from radeon and amdgpu winsyses and
flatten simplify their design.
The difference is that winsyses must
On 06.12.2015 19:01, Marek Olšák wrote:
From: Marek Olšák
This is a prerequisite for the removal of radeon_winsys_cs_handle.
---
src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 212 +++---
src/gallium/winsys/radeon/drm/radeon_drm_bo.h | 14 +-
Otherwise packed and inactive varyings get optimized away. This needs
to be prevented when using separate shader objects where interface
needs to be preserved.
Signed-off-by: Tapani Pälli
---
src/glsl/lower_packed_varyings.cpp | 1 +
1 file changed, 1 insertion(+)
diff
Patch makes following changes for interface matching:
- do not try to match builtin variables
- handle swizzle in input name, as example 'a.z' should
match with 'a'
- check that amount of inputs and outputs matches
These changes make interface matching tests to work in:
On Tuesday, December 08, 2015 01:46:20 PM Jason Ekstrand wrote:
[snip]
> @@ -461,8 +455,7 @@ print_intrinsic_instr(nir_intrinsic_instr *instr,
> print_state *state)
> }
>
> nir_foreach_variable(var, var_list) {
> - if ((var->data.driver_location == instr->const_index[0]) &&
> -
On Fri, Dec 4, 2015 at 10:51 AM, Neil Roberts wrote:
> Matt Turner writes:
>
>> # Written in the form (, ) where is an expression
>> # and is either an expression or a value. An expression is
>> # defined as a tuple of the form (, , , , )
>> @@
On Tuesday, December 08, 2015 01:46:22 PM Jason Ekstrand wrote:
> diff --git a/src/glsl/nir/nir_lower_io.c b/src/glsl/nir/nir_lower_io.c
> index f64ac69..a2723d5 100644
> --- a/src/glsl/nir/nir_lower_io.c
> +++ b/src/glsl/nir/nir_lower_io.c
> @@ -333,18 +311,18 @@ nir_lower_io(nir_shader *shader,
On Tue, Dec 8, 2015 at 4:19 PM, Kenneth Graunke wrote:
> On Tuesday, December 08, 2015 01:46:20 PM Jason Ekstrand wrote:
>> +/* src[] = { buffer_index, offset }. No const_index */
>> +LOAD(ssbo, 2, 0, NIR_INTRINSIC_CAN_ELIMINATE)
>
> I'm pretty sure const_index[0] is a
On Tue, Dec 8, 2015 at 2:47 PM, Kenneth Graunke wrote:
> On Tuesday, December 08, 2015 01:46:20 PM Jason Ekstrand wrote:
> [snip]
>> @@ -461,8 +455,7 @@ print_intrinsic_instr(nir_intrinsic_instr *instr,
>> print_state *state)
>> }
>>
>> nir_foreach_variable(var,
This format has been added in commit:
28090b30dd6b5977de085f48c620574214b6b4ba
But it was handled in the same way as MESA_FORMAT_B8G8R8A8_UNORM format.
It was causing the screen in Supertuxkart to be darker than expected, see:
https://bugs.freedesktop.org/show_bug.cgi?id=92759
Cc: Boyan Ding
On Tue, Dec 8, 2015 at 4:44 PM, Kenneth Graunke wrote:
> On Tuesday, December 08, 2015 01:46:23 PM Jason Ekstrand wrote:
>> ---
>> src/mesa/drivers/dri/i965/brw_fs.h | 2 +-
>> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 106
>> ++-
>>
Hi,
I was told that it's easier for people to review my patch if it comes in via
email than being stuck in the bug tracker; FWIW, this is for bug 120238.
(It's the same patch as is already in the tracker.)
/* Steinar */
===
From 6e3d1880fa78a3a965cb7eb51ee12b1f785f84bb Mon Sep 17 00:00:00 2001
To be safe, set all the fields in case the enums ordering/values
ever change.
---
src/gallium/drivers/svga/svga_screen.c | 43 ++
1 file changed, 28 insertions(+), 15 deletions(-)
diff --git a/src/gallium/drivers/svga/svga_screen.c
On Tuesday, December 08, 2015 01:46:23 PM Jason Ekstrand wrote:
> ---
> src/mesa/drivers/dri/i965/brw_fs.h | 2 +-
> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 106
> ++-
> src/mesa/drivers/dri/i965/brw_nir.c | 45 ++---
> 3 files changed, 84
On Tuesday, December 08, 2015 01:46:20 PM Jason Ekstrand wrote:
> +/* src[] = { buffer_index, offset }. No const_index */
> +LOAD(ssbo, 2, 0, NIR_INTRINSIC_CAN_ELIMINATE)
I'm pretty sure const_index[0] is a writemask, so this comemnt is wrong.
signature.asc
Description: This is a digitally
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, December 8, 2015 4:35 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee
Subject: [PATCH] svga: initialize pipe_driver_query_info entries with a
On Mon, Dec 7, 2015 at 5:32 PM, Dawid Gan wrote:
> This format has been added in commit:
> 28090b30dd6b5977de085f48c620574214b6b4ba
> But it was handled in the same way as MESA_FORMAT_B8G8R8A8_UNORM format.
> It was causing the screen in Supertuxkart to be darker than expected,
Change the __m128i variables to be volatile so gcc 4.9 won't optimise
all of them out with -O1 or greater. The _mm_set1_epi32/pinsrd calls
still get optimised out but now there is at least one SSE4.1 instruction
generated via _mm_max_epu32/pmaxud. When all of the sse4.1 instructions
got
From: Dave Airlie
This doesn't apply to other stages. This is only
used in the mesa/st code, which needs further fixes.
Signed-off-by: Dave Airlie
---
src/glsl/ir_set_program_inouts.cpp | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff
From: Dave Airlie
Don't use a bool here, as for some 64-bit fixes we need
the stage.
Signed-off-by: Dave Airlie
---
src/glsl/ir_set_program_inouts.cpp | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
From: Dave Airlie
The old function didn't work for matrices, and we need this
in other places to fix some other problems, so move to a helper
in glsl type and fix the one user so far.
A dual slot double is one that has 3 or 4 components in it's
base type.
Signed-off-by:
From: Dave Airlie
Signed-off-by: Dave Airlie
---
src/glsl/linker.cpp | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index ae628cd..89659c7 100644
--- a/src/glsl/linker.cpp
+++
From: Dave Airlie
So vertex shader input attributes are handled different than internal
varyings between shader stages, dvec3 and dvec4 only count as
one slot for vertex attributes, but for internal varyings, they
count as 2.
This patch comments all the uses of this API to
I've been trying to get GL41-CTS.gpu_shader_fp64.varyings to
pass on mesa for a while now on radeonsi/r600.
I finally got it to pass, so this is the first round of changes.
The second round are all st/glsl->tgsi convertor changes, so I
decided to post the GLSL changes first.
The main changes
From: Dave Airlie
This doubles the element width for the types that are greater
than 2 elements wide.
Signed-off-by: Dave Airlie
---
src/glsl/ir_set_program_inouts.cpp | 7 +++
1 file changed, 7 insertions(+)
diff --git
We were ignoring the partial derivatives on the last dim.
Signed-off-by: Ilia Mirkin
---
A little frightening that we weren't failing any tests... perhaps I
got this wrong somehow?
src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 2 +-
From: Michel Dänzer
Signed-off-by: Michel Dänzer
---
src/gallium/state_trackers/clover/llvm/invocation.cpp | 4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
https://bugs.freedesktop.org/show_bug.cgi?id=91888
--- Comment #15 from nerdopol...@verizon.net ---
(In reply to Daniel Stone from comment #14)
> Ugh, so I think I'm using the same options, and I can't see what's going
> wrong with either big GL or GLES. To be honest, I'm at a total loss ... can
This fixes my initial attempt so that piglit now passes 14/14. Thanks
to a couple of tips from Roland in the previous patch I was able to
fix the remaining issue. This should be golden now.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
From: Dave Airlie
This fixes the calculations for transform feedback for doubles.
Signed-off-by: Dave Airlie
---
src/glsl/link_varyings.cpp | 7 +--
src/glsl/link_varyings.h | 26 +-
2 files changed, 30 insertions(+), 3
From: Dave Airlie
Signed-off-by: Dave Airlie
---
src/glsl/lower_packed_varyings.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/lower_packed_varyings.cpp
b/src/glsl/lower_packed_varyings.cpp
index 037c27d..ec9af62 100644
From: Roland Scheidegger
ARB_fragment_layer_viewport requires that if a fs reads layer or viewport
index but it wasn't output by gs (or vs with other extensions), then it reads
0. This never worked for llvmpipe, and is surprisingly non-trivial to fix.
The problem is the
The following changes since commit
a13b14930d94b024160fe17814e091356d07f7fb:
llvmpipe: fix fp64 inputs to geom shader. (2015-12-09 13:56:39 +1000)
are available in the git repository at:
https://github.com/victoredwardocallaghan/mesa-GLwork.git
softpipe-ARB_viewport_array
for you to
Use PKG_CHECK_MODULES to get the flags to link libelf
v2: keep AC_CHECK_LIB as a fallback for elfutils provided
libelf that doesn't install a pkg-config file.
Signed-off-by: Jonathan Gray
Reviewed-by: Michel D�nzer
Tested-by: Michel D�nzer
On 09.12.2015 13:03, Dave Airlie wrote:
> From: Dave Airlie
>
> This adds two cases of missing double handling to radeonsi,
> one for loading doubles from LDS and one for fetch doubles
> for geometry shader inputs.
>
> Signed-off-by: Dave Airlie
Please
From: Dave Airlie
This adds two cases of missing double handling to radeonsi,
one for loading doubles from LDS and one for fetch doubles
for geometry shader inputs.
Signed-off-by: Dave Airlie
---
src/gallium/drivers/radeonsi/si_shader.c | 28
On 06.12.2015 19:00, Marek Olšák wrote:
This series addresses the weirdness in radeon drivers that every buffer has 2
handles:
- pb_buffer (== pb_cache_buffer)
- radeon_winsys_cs_handle (winsys-specific pb_buffer)
The inefficiency of converting pb_cache_buffer into the winsys-specific buffer
This is my third sending of this series. I think this version is close to
working on all of the relevant drivers (it works on i965). Hopefully, we
can actually push it this time.
As mentioned before, all but the first two patches will be squashed
together so it's important to get this right.
---
src/gallium/drivers/vc4/vc4_nir_lower_blend.c | 1 +
src/gallium/drivers/vc4/vc4_nir_lower_io.c| 38 --
src/gallium/drivers/vc4/vc4_program.c | 47 +--
3 files changed, 58 insertions(+), 28 deletions(-)
diff --git
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=93300
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 9 ++---
src/gallium/drivers/nouveau/codegen/nv50_ir_target.h | 2 ++
On Tue, 2015-12-08 at 19:02 +0200, Tapani Pälli wrote:
> This will cause validation to run during next draw, this is done
> because possible changes in used stages and programs can cause
> invalid pipeline state.
>
> This fixes a subtest in following CTS test:
>
---
src/glsl/nir/glsl_to_nir.cpp | 47 +++-
1 file changed, 7 insertions(+), 40 deletions(-)
diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp
index 45d045c..ba23b91 100644
--- a/src/glsl/nir/glsl_to_nir.cpp
+++
There was way too much incrementing of things going on. Instead, let's
just start everything off at the right base location, and then increment in
the loop.
---
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 45 ++--
1 file changed, 19 insertions(+), 26 deletions(-)
diff
---
src/mesa/drivers/dri/i965/brw_fs.h | 2 +-
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 106 ++-
src/mesa/drivers/dri/i965/brw_nir.c | 45 ++---
3 files changed, 84 insertions(+), 69 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.h
---
src/gallium/auxiliary/nir/tgsi_to_nir.c | 52 ++---
1 file changed, 28 insertions(+), 24 deletions(-)
diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c
b/src/gallium/auxiliary/nir/tgsi_to_nir.c
index 5fef542..5def6d3 100644
---
Previously, we lowered direct uniform loads to dword offsets and indirect
loads to byte offsets in vc4_nir_lower_io. However, it simplifies things a
bit if we just use byte offsets for everything and then divide by 4 when we
handle the direct uniform load.
---
---
.../drivers/freedreno/ir3/ir3_compiler_nir.c | 79 +-
1 file changed, 47 insertions(+), 32 deletions(-)
diff --git a/src/gallium/drivers/freedreno/ir3/ir3_compiler_nir.c
b/src/gallium/drivers/freedreno/ir3/ir3_compiler_nir.c
index 2723959..eea5c5e 100644
---
---
src/glsl/nir/nir_lower_two_sided_color.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/glsl/nir/nir_lower_two_sided_color.c
b/src/glsl/nir/nir_lower_two_sided_color.c
index 6995b9d..7df12e0 100644
--- a/src/glsl/nir/nir_lower_two_sided_color.c
+++
There is some special-casing needed in a competent back-end. However, they
can do their special-casing easily enough based on whether or not the
offset is a constant. In the mean time, having the *_indirect variants
adds special cases a number of places where they don't need to be and, in
---
src/glsl/nir/nir.h | 2 +-
src/glsl/nir/nir_lower_io.c | 111 +---
2 files changed, 44 insertions(+), 69 deletions(-)
diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h
index e161b70..2e72e66 100644
--- a/src/glsl/nir/nir.h
+++
---
src/mesa/drivers/dri/i965/brw_vec4_gs_nir.cpp | 7 +-
src/mesa/drivers/dri/i965/brw_vec4_nir.cpp| 95 +++
2 files changed, 43 insertions(+), 59 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_gs_nir.cpp
---
src/glsl/nir/nir_lower_clip.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/glsl/nir/nir_lower_clip.c b/src/glsl/nir/nir_lower_clip.c
index c58c778..e2a2bb6 100644
--- a/src/glsl/nir/nir_lower_clip.c
+++ b/src/glsl/nir/nir_lower_clip.c
@@ -74,6 +74,7 @@
https://bugs.freedesktop.org/show_bug.cgi?id=1626
--- Comment #3 from Alex Perez ---
The last comment on this bug was eight and a half years ago...the bug itself
was filed back in 2004. Probably close as WONTFIX, if it's even relevant any
longer?
--
You are receiving this
74 matches
Mail list logo