Re: [Mesa-dev] [PATCH] i965/fs: Replace subreg_offset with brw_reg's subnr.

2016-02-12 Thread Iago Toral
On Thu, 2016-02-11 at 19:12 -0800, Kenneth Graunke wrote: > On Thursday, February 11, 2016 5:49:55 PM PST Matt Turner wrote: > > On Thu, Feb 11, 2016 at 3:33 PM, Francisco Jerez > wrote: > > > Would be really nice if we could also get rid of reg_offset as we're at > > >

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/4] glx: fix error code when there is no context bound

2016-02-12 Thread Ian Romanick
This sounds like a bug in the unit tests. I'll take a look in the morning. On February 11, 2016 9:34:36 PM Tapani Pälli wrote: On 02/12/2016 02:54 AM, Emil Velikov wrote: On 11 February 2016 at 12:04, Tapani Pälli wrote: From: Bernard

Re: [Mesa-dev] [v2] Compression support for single-sampled

2016-02-12 Thread Pohjolainen, Topi
On Thu, Feb 11, 2016 at 04:03:00PM -0800, Ben Widawsky wrote: > On Thu, Feb 11, 2016 at 08:33:53PM +0200, Topi Pohjolainen wrote: > > This series enables compression for single sampled color surfaces, > > also referred to as "lossless compression". This is yet only for > > driver internal use

[Mesa-dev] [Bug 89330] piglit glsl-1.50 invariant-qualifier-in-out-block-01 regression

2016-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89330 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2016-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 89330, which changed state. Bug 89330 Summary: piglit glsl-1.50 invariant-qualifier-in-out-block-01 regression https://bugs.freedesktop.org/show_bug.cgi?id=89330 What|Removed |Added

Re: [Mesa-dev] [PATCH 11/19] st/mesa: add compute shader states

2016-02-12 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Feb 11, 2016 at 9:17 PM, Samuel Pitoiset wrote: > Changes from v2: > - use as much common code as possible (eg. st_basic_variant) > > Signed-off-by: Samuel Pitoiset >

Re: [Mesa-dev] [PATCH 2/4] i965: Consider tessellation in get_pipeline_state_l3_weights.

2016-02-12 Thread Francisco Jerez
Kenneth Graunke writes: > On Thursday, February 11, 2016 11:28:44 PM PST Francisco Jerez wrote: >> Kenneth Graunke writes: >> >> > I think this was just missed; Curro and I were probably writing >> > code simultaneously and forgot to combine them

Re: [Mesa-dev] [PATCH] glsl: replace _strtoui64() with strtoull() for MSVC

2016-02-12 Thread Jose Fonseca
On 11/02/16 23:08, Timothy Arceri wrote: Now that MSVC 2013 is required we can remove this. --- src/compiler/glsl/glsl_lexer.ll | 4 1 file changed, 4 deletions(-) diff --git a/src/compiler/glsl/glsl_lexer.ll b/src/compiler/glsl/glsl_lexer.ll index e59f93e..9704fc7 100644 ---

[Mesa-dev] [PATCH] compiler/glsl: Fix uniform location counting.

2016-02-12 Thread Plamena Manolova
This patch moves the calculation of current uniforms to link_uniforms, which makes use of UniformRemapTable which stores all the reserved uniform locations. Location assignment for implicit uniforms now tries to use any gaps left in the table after the location assignment for explicit uniforms.

[Mesa-dev] [Bug 38454] [KMS] ATI RV280 ennoying many OpenGL troubles

2016-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38454 Timothy Arceri changed: What|Removed |Added Component|Mesa core |Drivers/DRI/r200

[Mesa-dev] [Bug 54369] Make fails on Debian Squeeze 644

2016-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54369 Timothy Arceri changed: What|Removed |Added Status|NEEDINFO|RESOLVED

[Mesa-dev] [PATCH] mesa: Use _aligned_malloc/free for MinGW too.

2016-02-12 Thread Jose Fonseca
We already use these for gallium in src/gallium/auxiliary/os/os_memory_stdc.h and it's always better to minimize divergences between MinGW and MSVC. --- src/mesa/main/imports.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/imports.c

[Mesa-dev] [Bug 64952] Build failure in egl-static when using llvm-3.3

2016-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64952 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 3/3] include, gallium: Remove pre-MSVC 2013 compatibility.

2016-02-12 Thread Jose Fonseca
On 11/02/16 22:13, Emil Velikov wrote: On 11 February 2016 at 13:02, Jose Fonseca wrote: --- Makefile.am | 1 - include/c99/inttypes.h| 305 -- include/c99/stdbool.h |

[Mesa-dev] [Bug 78666] [r600g glsl-1.20] fs-const-array-of-struct-of-array broken on 6550D

2016-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=78666 Timothy Arceri changed: What|Removed |Added Resolution|--- |WORKSFORME

Re: [Mesa-dev] [PATCH 3/3] include, gallium: Remove pre-MSVC 2013 compatibility.

2016-02-12 Thread Timothy Arceri
On Fri, 2016-02-12 at 10:45 +, Jose Fonseca wrote: > On 11/02/16 22:13, Emil Velikov wrote: > > On 11 February 2016 at 13:02, Jose Fonseca > > wrote: > > > --- > > >   Makefile.am   |   1 - > > >   include/c99/inttypes.h|

[Mesa-dev] [Bug 30489] mesa 7.9 fails to build on 32bit system with 64bit kernel

2016-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=30489 Timothy Arceri changed: What|Removed |Added Resolution|--- |WONTFIX

[Mesa-dev] [Bug 42154] g++: error: swrast_dri.so.tmp: No such file or directory on build for radeon 600g

2016-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42154 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 1/5] mesa: remove _ARB suffix from cube map enums

2016-02-12 Thread Brian Paul
Ping. This is a pretty simple set of patches. -Brian On 02/11/2016 08:35 AM, Brian Paul wrote: Just minor clean-up so we're consistent everywhere. --- src/mesa/main/attrib.c | 4 ++-- src/mesa/main/enable.c | 4 ++-- src/mesa/main/genmipmap.c | 2 +- src/mesa/main/get.c

Re: [Mesa-dev] [RFC] vc4: Remove logically dead variable 'handled_qinst_cond'

2016-02-12 Thread Rhys Kidd
Thanks Eric, that makes sense. I'll respin the patch, confirm no piglit regressions and send it back to the mailing list for your R-b. Regards, Rhys On Friday, February 12, 2016, Eric Anholt wrote: > Rhys Kidd > writes: > > > Variable no

Re: [Mesa-dev] [PATCH] mesa: Use _aligned_malloc/free for MinGW too.

2016-02-12 Thread Brian Paul
On 02/12/2016 06:23 AM, Jose Fonseca wrote: We already use these for gallium in src/gallium/auxiliary/os/os_memory_stdc.h and it's always better to minimize divergences between MinGW and MSVC. --- src/mesa/main/imports.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH] mesa: Fix test for big-endian architecture in compiler.h

2016-02-12 Thread Jochen Rollwagen
Hi, i think i found & fixed a bug in mesa concerning tests for big-endian machines. The defines tested don't exist or are wrongly defined so the test (probably) never fires. The gcc defines on my machine concerning big-endian are jochen@mac-mini:~/sources/mesa$ gcc -dM -E - < /dev/null |

[Mesa-dev] [PATCH] mesa: need to check resource and set length even if bufSize is 0

2016-02-12 Thread Ilia Mirkin
This fixes a number of dEQP tests, such as: dEQP-GLES31.functional.program_interface_query.buffer_limited_query.resource_query It was expecting the length to be set even in the bufSize == 0 case. Also _mesa_get_program_resourceiv does some error checking on the resource which should probably

[Mesa-dev] [PATCH 3/7] st/mesa: use cso_save/restore_state() in st_cb_texture.c

2016-02-12 Thread Brian Paul
This simplifies the error handling code too. --- src/mesa/state_tracker/st_cb_texture.c | 55 ++ 1 file changed, 22 insertions(+), 33 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index 559347e..a4c4648

[Mesa-dev] [PATCH 1/4] st/mesa: used _mesa_num_tex_faces() in st_finalize_texture()

2016-02-12 Thread Brian Paul
--- src/mesa/state_tracker/st_cb_texture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index a4c4648..09ff4c1 100644 --- a/src/mesa/state_tracker/st_cb_texture.c +++

[Mesa-dev] [PATCH 6/7] postprocess: use new cso_save/restore_state() functions

2016-02-12 Thread Brian Paul
--- src/gallium/auxiliary/postprocess/pp_run.c | 58 +++--- 1 file changed, 20 insertions(+), 38 deletions(-) diff --git a/src/gallium/auxiliary/postprocess/pp_run.c b/src/gallium/auxiliary/postprocess/pp_run.c index c6c7b88..9dc8fb5 100644 ---

[Mesa-dev] [PATCH 1/7] cso: add new cso_save/restore_state() functions

2016-02-12 Thread Brian Paul
cso_save_state() takes a bitmask of state items to save. Calling cso_restore_state() restores those states. --- src/gallium/auxiliary/cso_cache/cso_context.c | 109 ++ src/gallium/auxiliary/cso_cache/cso_context.h | 24 ++ 2 files changed, 133 insertions(+) diff

[Mesa-dev] [PATCH 7/7] cso: make most of the cso_save/restore_x() functions static

2016-02-12 Thread Brian Paul
Users of the CSO save/restore facility all use the new cso_save/restore_state() functions instead. --- src/gallium/auxiliary/cso_cache/cso_context.c | 108 +- src/gallium/auxiliary/cso_cache/cso_context.h | 47 --- 2 files changed, 70 insertions(+), 85

[Mesa-dev] [PATCH 5/7] gallium/hud: use new cso_save/restore_state() functions

2016-02-12 Thread Brian Paul
--- src/gallium/auxiliary/hud/hud_context.c | 56 +++-- 1 file changed, 19 insertions(+), 37 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index 75afebe..fb99834 100644 ---

Re: [Mesa-dev] [PATCH 1/5] mesa: remove _ARB suffix from cube map enums

2016-02-12 Thread Brian Paul
On 02/12/2016 08:46 AM, Roland Scheidegger wrote: Am 11.02.2016 um 16:35 schrieb Brian Paul: Just minor clean-up so we're consistent everywhere. --- src/mesa/main/attrib.c | 4 ++-- src/mesa/main/enable.c | 4 ++-- src/mesa/main/genmipmap.c | 2 +- src/mesa/main/get.c

[Mesa-dev] [PATCH 3/4] st/mesa: use 'cso' instead of 'st->cso_context' in st_DrawTex()

2016-02-12 Thread Brian Paul
--- src/mesa/state_tracker/st_cb_drawtex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_cb_drawtex.c b/src/mesa/state_tracker/st_cb_drawtex.c index 39e4b21..d36d59b 100644 --- a/src/mesa/state_tracker/st_cb_drawtex.c +++

Re: [Mesa-dev] [PATCH 1/5] mesa: remove _ARB suffix from cube map enums

2016-02-12 Thread Roland Scheidegger
Am 11.02.2016 um 16:35 schrieb Brian Paul: > Just minor clean-up so we're consistent everywhere. > --- > src/mesa/main/attrib.c | 4 ++-- > src/mesa/main/enable.c | 4 ++-- > src/mesa/main/genmipmap.c | 2 +- > src/mesa/main/get.c | 2 +- > src/mesa/main/mipmap.c | 14

[Mesa-dev] [PATCH 2/4] st/mesa: fix whitespace and add comment in st_DrawTex()

2016-02-12 Thread Brian Paul
--- src/mesa/state_tracker/st_cb_drawtex.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_drawtex.c b/src/mesa/state_tracker/st_cb_drawtex.c index 7e9a958..39e4b21 100644 --- a/src/mesa/state_tracker/st_cb_drawtex.c +++

[Mesa-dev] [PATCH 4/7] gallium/util: use new cso_save/restore_state() functions

2016-02-12 Thread Brian Paul
--- src/gallium/auxiliary/util/u_blit.c | 52 + 1 file changed, 18 insertions(+), 34 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blit.c b/src/gallium/auxiliary/util/u_blit.c index 9737c94..22c40d1 100644 --- a/src/gallium/auxiliary/util/u_blit.c

[Mesa-dev] [PATCH 4/4] st/mesa: rename attr variable in st_DrawTex()

2016-02-12 Thread Brian Paul
Rename to 'tex_attr' to be a bit more clear. --- src/mesa/state_tracker/st_cb_drawtex.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_drawtex.c b/src/mesa/state_tracker/st_cb_drawtex.c index d36d59b..0fb54ce 100644 ---

Re: [Mesa-dev] [PATCH 6/6] st/mesa: use new cso_set_viewport_dims() helper

2016-02-12 Thread Ilia Mirkin
On Fri, Feb 12, 2016 at 10:43 AM, Brian Paul wrote: > --- > src/mesa/state_tracker/st_cb_bitmap.c | 16 +++- > src/mesa/state_tracker/st_cb_clear.c | 13 ++--- > src/mesa/state_tracker/st_cb_drawpixels.c | 14 ++ > 3 files changed, 7

Re: [Mesa-dev] [PATCH 6/6] st/mesa: use new cso_set_viewport_dims() helper

2016-02-12 Thread Brian Paul
On 02/12/2016 09:06 AM, Ilia Mirkin wrote: On Fri, Feb 12, 2016 at 10:43 AM, Brian Paul wrote: --- src/mesa/state_tracker/st_cb_bitmap.c | 16 +++- src/mesa/state_tracker/st_cb_clear.c | 13 ++--- src/mesa/state_tracker/st_cb_drawpixels.c |

[Mesa-dev] [PATCH 3/6] st/mesa: consolidate quad drawing code

2016-02-12 Thread Brian Paul
The glClear, glBitmap and glDrawPixels code now use a new st_draw_quad() helper function. --- src/mesa/state_tracker/st_cb_bitmap.c | 66 +--- src/mesa/state_tracker/st_cb_clear.c | 91 -- src/mesa/state_tracker/st_cb_drawpixels.c | 120

[Mesa-dev] [PATCH 5/6] cso: add new cso_set_viewport_dims() helper

2016-02-12 Thread Brian Paul
To simplify some viewport setting code in the state tracker. --- src/gallium/auxiliary/cso_cache/cso_context.c | 18 ++ src/gallium/auxiliary/cso_cache/cso_context.h | 2 ++ 2 files changed, 20 insertions(+) diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c

[Mesa-dev] [PATCH 4/6] st/mesa: use 'cso' local var instead of st->cso_context

2016-02-12 Thread Brian Paul
Just a little cleaner. --- src/mesa/state_tracker/st_cb_clear.c | 83 +-- src/mesa/state_tracker/st_cb_drawpixels.c | 2 +- src/mesa/state_tracker/st_cb_texture.c| 94 +++ 3 files changed, 89 insertions(+), 90 deletions(-) diff --git

[Mesa-dev] [PATCH 2/6] st/mesa: overhaul vertex setup for clearing, glDrawPixels, glBitmap

2016-02-12 Thread Brian Paul
Define a new st_util_vertex structure which is a bit smaller (9 floats versus the previous 12 floats per vertex). Clean up the glClear, glDrawPixels and glBitmap code that sets up the vertex data and does the drawing so it's all very similar. This can lead to more consolidation. ---

[Mesa-dev] [PATCH 6/6] st/mesa: use new cso_set_viewport_dims() helper

2016-02-12 Thread Brian Paul
--- src/mesa/state_tracker/st_cb_bitmap.c | 16 +++- src/mesa/state_tracker/st_cb_clear.c | 13 ++--- src/mesa/state_tracker/st_cb_drawpixels.c | 14 ++ 3 files changed, 7 insertions(+), 36 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_bitmap.c

[Mesa-dev] [PATCH 2/7] st/mesa: use new cso_save/restore_state() functions

2016-02-12 Thread Brian Paul
--- src/mesa/state_tracker/st_cb_bitmap.c | 36 src/mesa/state_tracker/st_cb_clear.c | 46 +++ src/mesa/state_tracker/st_cb_drawpixels.c | 46 +++ src/mesa/state_tracker/st_cb_drawtex.c| 26

[Mesa-dev] [PATCH 1/6] st/mesa: include u_draw.h, not u_draw_quad.h in st_draw.c

2016-02-12 Thread Brian Paul
--- src/mesa/state_tracker/st_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_draw.c b/src/mesa/state_tracker/st_draw.c index 10e294c..a299dd5 100644 --- a/src/mesa/state_tracker/st_draw.c +++ b/src/mesa/state_tracker/st_draw.c @@ -60,7 +60,7

[Mesa-dev] [Bug 94116] program interface queries not returning right data for UBO / GL_BLOCK_INDEX

2016-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94116 Bug ID: 94116 Summary: program interface queries not returning right data for UBO / GL_BLOCK_INDEX Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH 6/6] st/mesa: use new cso_set_viewport_dims() helper

2016-02-12 Thread Ilia Mirkin
On Fri, Feb 12, 2016 at 11:18 AM, Brian Paul wrote: > On 02/12/2016 09:06 AM, Ilia Mirkin wrote: >> >> On Fri, Feb 12, 2016 at 10:43 AM, Brian Paul wrote: >>> >>> --- >>> src/mesa/state_tracker/st_cb_bitmap.c | 16 +++- >>>

Re: [Mesa-dev] [v2 03/19] i965: Don't try to create aux buffer for non-msrt aux-buffer

2016-02-12 Thread Ben Widawsky
On Fri, Feb 12, 2016 at 09:24:42AM +0200, Pohjolainen, Topi wrote: > On Thu, Feb 11, 2016 at 01:41:47PM -0800, Ben Widawsky wrote: > > On Thu, Feb 11, 2016 at 08:33:56PM +0200, Topi Pohjolainen wrote: > > > In addition to simply calling miptree_create() the higher level > > > call

[Mesa-dev] [PATCH] mesa: recognize enums GL_COLOR_ATTACHMENT8-31 as valid

2016-02-12 Thread Ilia Mirkin
Similar as for AUX1-3, these enums aren't invalid (i.e. -1) but also not supported by mesa. Returning BUFFER_COUNT causes the proper error to be returned by ReadBuffer and other functions. This resolves some failures in dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.read_buffer

Re: [Mesa-dev] [PATCH] i965/fs: Replace subreg_offset with brw_reg's subnr.

2016-02-12 Thread Matt Turner
On Thu, Feb 11, 2016 at 11:21 PM, Francisco Jerez wrote: > Matt Turner writes: > >> On Thu, Feb 11, 2016 at 7:31 PM, Francisco Jerez >> wrote: >>> Matt Turner writes: >>> On Thu, Feb 11, 2016 at 3:33

[Mesa-dev] [PATCH 1/4] mesa/clear: remove dead code handling ClearBufferiv(GL_DEPTH)

2016-02-12 Thread Ilia Mirkin
There's a hunk above which sets INVALID_ENUM for GL_DEPTH unconditionally. Signed-off-by: Ilia Mirkin --- src/mesa/main/clear.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/src/mesa/main/clear.c b/src/mesa/main/clear.c index 3bfcc5c..5c40a03

[Mesa-dev] [PATCH 3/4] mesa/clear: update ClearBufferuiv error handling for GL 4.5 spec

2016-02-12 Thread Ilia Mirkin
This fixes dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.clear_bufferuiv and brings the logic up to spec with GL 4.5 Signed-off-by: Ilia Mirkin --- src/mesa/main/clear.c | 29 + 1 file changed, 5 insertions(+), 24

[Mesa-dev] [PATCH 4/4] mesa/clear: update ClearBufferfv error handling for GL 4.5 spec

2016-02-12 Thread Ilia Mirkin
This fixes dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.clear_bufferfv and brings the logic up to spec with GL 4.5 Signed-off-by: Ilia Mirkin --- src/mesa/main/clear.c | 23 +-- 1 file changed, 5 insertions(+), 18 deletions(-) diff

[Mesa-dev] [PATCH 2/4] mesa/clear: simplify ClearBufferiv error handling

2016-02-12 Thread Ilia Mirkin
Might as well handle everything in the same error call. Signed-off-by: Ilia Mirkin --- src/mesa/main/clear.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/clear.c b/src/mesa/main/clear.c index 5c40a03..568f600 100644

[Mesa-dev] [PATCH] mesa: reset offset/size to 0 when removing atomic binding

2016-02-12 Thread Ilia Mirkin
Similar to commit dd9d2963d6 (mesa: AtomicBufferBindings should be initialized to zero.), we should reset these to zero when unbinding. This fixes a number of dEQP failures due to cross-test pollution. The tests properly unbound everything, but when querying the values again, the expectation was

[Mesa-dev] [PATCH] mesa: avoid segfault in GetProgramPipelineInfoLog when no length

2016-02-12 Thread Ilia Mirkin
If there is no pipe info log, we would unconditionally deref length, which was only optionally there. _mesa_copy_string handles the source being null, as well as the length, so may as well just always call it. Fixes a segfault in dEQP-GLES31.functional.state_query.program_pipeline.info_log

Re: [Mesa-dev] [PATCH] i965/fs: Replace subreg_offset with brw_reg's subnr.

2016-02-12 Thread Francisco Jerez
Matt Turner writes: > On Thu, Feb 11, 2016 at 11:21 PM, Francisco Jerez > wrote: >> Matt Turner writes: >> >>> On Thu, Feb 11, 2016 at 7:31 PM, Francisco Jerez >>> wrote: Matt Turner

Re: [Mesa-dev] [PATCH 4/4] mesa/clear: update ClearBufferfv error handling for GL 4.5 spec

2016-02-12 Thread Brian Paul
On 02/12/2016 11:01 AM, Ilia Mirkin wrote: This fixes dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.clear_bufferfv and brings the logic up to spec with GL 4.5 Signed-off-by: Ilia Mirkin --- src/mesa/main/clear.c | 23 +-- 1 file

[Mesa-dev] [PATCH] glsl: reject invalid input layout qualifiers

2016-02-12 Thread Timothy Arceri
Global in validation is already handled, this will do the validation for variables, blocks and block members. This fixes some CTS tests for the new enhanced layouts transform feedback qualifiers. --- Applies on top of my component qualifier series:

[Mesa-dev] [Bug 94116] program interface queries not returning right data for UBO / GL_BLOCK_INDEX

2016-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94116 Timothy Arceri changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH] i965: Reupload push and pull constants when we get new shader image unit state.

2016-02-12 Thread Kenneth Graunke
On Friday, February 12, 2016 12:20:15 PM PST Francisco Jerez wrote: > Fixes several of the > "dEQP-GLES31.functional.image_load_store*load_store*single_layer" dEQP > tests that use image formats we implement using untyped surface > messages. > > Cc: mesa-sta...@lists.freedesktop.org > Tested-by:

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/4] glx: fix error code when there is no context bound

2016-02-12 Thread Tapani Pälli
On 02/12/2016 11:55 PM, Emil Velikov wrote: On 12 February 2016 at 05:34, Tapani Pälli wrote: On 02/12/2016 02:54 AM, Emil Velikov wrote: On 11 February 2016 at 12:04, Tapani Pälli wrote: From: Bernard Kilarski

[Mesa-dev] [PATCH] i965/bxt: Production thread counts

2016-02-12 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_device_info.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_device_info.c b/src/mesa/drivers/dri/i965/brw_device_info.c index

[Mesa-dev] [PATCH] [v2] i965/bxt: Production thread counts

2016-02-12 Thread Ben Widawsky
v2: Forgot to squash in the comment removal Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_device_info.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_device_info.c

Re: [Mesa-dev] [v2 05/19] i965: Add helper for detecting lossless compression

2016-02-12 Thread Pohjolainen, Topi
On Thu, Feb 11, 2016 at 01:48:18PM -0800, Ben Widawsky wrote: > On Thu, Feb 11, 2016 at 08:33:58PM +0200, Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 26 > > ++ > >

Re: [Mesa-dev] [PATCH] mesa: recognize enums GL_COLOR_ATTACHMENT8-31 as valid

2016-02-12 Thread Brian Paul
On 02/12/2016 11:22 AM, Ilia Mirkin wrote: Similar as for AUX1-3, these enums aren't invalid (i.e. -1) but also not supported by mesa. Returning BUFFER_COUNT causes the proper error to be returned by ReadBuffer and other functions. This resolves some failures in

Re: [Mesa-dev] [PATCH] mesa: reset offset/size to 0 when removing atomic binding

2016-02-12 Thread Brian Paul
On 02/12/2016 11:51 AM, Ilia Mirkin wrote: Similar to commit dd9d2963d6 (mesa: AtomicBufferBindings should be initialized to zero.), we should reset these to zero when unbinding. This fixes a number of dEQP failures due to cross-test pollution. The tests properly unbound everything, but when

Re: [Mesa-dev] [PATCH] mesa: avoid segfault in GetProgramPipelineInfoLog when no length

2016-02-12 Thread Brian Paul
On 02/12/2016 12:25 PM, Ilia Mirkin wrote: If there is no pipe info log, we would unconditionally deref length, which was only optionally there. _mesa_copy_string handles the source being null, as well as the length, so may as well just always call it. Fixes a segfault in

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/4] glx: fix error code when there is no context bound

2016-02-12 Thread Emil Velikov
On 12 February 2016 at 05:34, Tapani Pälli wrote: > On 02/12/2016 02:54 AM, Emil Velikov wrote: >> >> On 11 February 2016 at 12:04, Tapani Pälli wrote: >>> >>> From: Bernard Kilarski >>> >>> Signed-off-by: Bernard

Re: [Mesa-dev] [PATCH] egl/wayland: Try to use wl_surface.damage_buffer for SwapBuffersWithDamage

2016-02-12 Thread Emil Velikov
On 11 February 2016 at 16:34, Derek Foreman wrote: > Since commit d1314de293e9e4a63c35f094c3893aaaed8580b4 we ignore > damage passed to SwapBuffersWithDamage. > > Wayland 1.10 now has functionality that allows us to properly > process those damage rectangles, and a way to

Re: [Mesa-dev] [PATCH] mesa: reset offset/size to 0 when removing atomic binding

2016-02-12 Thread Francisco Jerez
Ilia Mirkin writes: > Similar to commit dd9d2963d6 (mesa: AtomicBufferBindings should be > initialized to zero.), we should reset these to zero when unbinding. > This fixes a number of dEQP failures due to cross-test pollution. The > tests properly unbound everything, but

Re: [Mesa-dev] [PATCH] st/nine: Forbid POSITION0 and fix depth input for PS3.0

2016-02-12 Thread Emil Velikov
On 12 February 2016 at 22:10, Axel Davy wrote: > POSITION0 input is forbidden for PS3.0 apparently. > > Besides for depth input we weren't using the system value > version if needed > > Signed-off-by: Axel Davy > > --- > Could be better having it separated

Re: [Mesa-dev] [PATCH 2/5] mesa: make _mesa_tex_target_to_face() an inline function

2016-02-12 Thread Timothy Arceri
On Thu, 2016-02-11 at 08:35 -0700, Brian Paul wrote: > --- >  src/mesa/main/teximage.c | 14 -- >  src/mesa/main/teximage.h | 15 +++ >  2 files changed, 15 insertions(+), 14 deletions(-) > > diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c > index

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/4] glx: fix error code when there is no context bound

2016-02-12 Thread Emil Velikov
On 12 February 2016 at 02:28, Matt Turner wrote: > On Thu, Feb 11, 2016 at 4:54 PM, Emil Velikov > wrote: >> On 11 February 2016 at 12:04, Tapani Pälli wrote: >>> From: Bernard Kilarski >>> >>>

[Mesa-dev] [PATCH] st/nine: Forbid POSITION0 and fix depth input for PS3.0

2016-02-12 Thread Axel Davy
POSITION0 input is forbidden for PS3.0 apparently. Besides for depth input we weren't using the system value version if needed Signed-off-by: Axel Davy --- Could be better having it separated into two patches perhaps. It should get into Mesa 11.2, to prevent regression caused

[Mesa-dev] [PATCH] virtio_gpu: Add virtio 1.0 PCI ID to driver map

2016-02-12 Thread Marc-André Lureau
From: Marc-André Lureau Add the virtio-gpu PCI ID for virtio 1.0 (according to the specification, "the PCI Device ID is calculated by adding 0x1040 to the Virtio Device ID") Signed-off-by: Marc-André Lureau ---

Re: [Mesa-dev] [PATCH 0/9] Types, types, and more types

2016-02-12 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On 2016-02-11 22:16:18, Jason Ekstrand wrote: > This little series expands the GLSL type system in preparation for SPIR-V. > The first few patches are to glsl_types and add a bare sampler type, > function types, and an image type

Re: [Mesa-dev] [PATCH] glsl: reject explicit location on atomic counter uniforms

2016-02-12 Thread Timothy Arceri
On Thu, 2016-02-11 at 20:10 -0500, Ilia Mirkin wrote: > This fixes > > dEQP-GLES31.functional.uniform_location.negative.atomic_fragment > dEQP-GLES31.functional.uniform_location.negative.atomic_vertex > > Both of which have lines like > > layout(location = 3, binding = 0, offset = 0) uniform

[Mesa-dev] [PATCH] i965: Reupload push and pull constants when we get new shader image unit state.

2016-02-12 Thread Francisco Jerez
Fixes several of the "dEQP-GLES31.functional.image_load_store*load_store*single_layer" dEQP tests that use image formats we implement using untyped surface messages. Cc: mesa-sta...@lists.freedesktop.org Tested-by: Ilia Mirkin ---

Re: [Mesa-dev] [PATCH 00/12] Some more Nine fixes

2016-02-12 Thread Axel Davy
On 09/02/2016 14:58, Emil Velikov wrote: On 7 February 2016 at 23:13, Axel Davy wrote: A few more patches I'd like to get in 11.2. There a few cleanup patches and some fixes. The last patch fixes build with llvm 32 bits when it isn't built with -mstackrealign. Basically

Re: [Mesa-dev] [PATCH] egl/wayland: Try to use wl_surface.damage_buffer for SwapBuffersWithDamage

2016-02-12 Thread Derek Foreman
On 12/02/16 04:46 PM, Emil Velikov wrote: > On 11 February 2016 at 16:34, Derek Foreman wrote: >> Since commit d1314de293e9e4a63c35f094c3893aaaed8580b4 we ignore >> damage passed to SwapBuffersWithDamage. >> >> Wayland 1.10 now has functionality that allows us to properly

Re: [Mesa-dev] [PATCH 6/7] glx: remove incorrect refcounting of DRIdrawable

2016-02-12 Thread Miklós Máté
On 02/12/2016 06:56 AM, Michel Dänzer wrote: On 12.02.2016 05:58, Miklós Máté wrote: On 02/09/2016 05:02 PM, Ian Romanick wrote: On 02/08/2016 05:11 PM, Ian Romanick wrote: On 02/05/2016 01:11 PM, Miklós Máté wrote: dri drawables must never be released when unbound from a context as long as

Re: [Mesa-dev] [PATCH] egl/wayland: Try to use wl_surface.damage_buffer for SwapBuffersWithDamage

2016-02-12 Thread Emil Velikov
On 12 February 2016 at 23:09, Derek Foreman wrote: > On 12/02/16 04:46 PM, Emil Velikov wrote: >> On 11 February 2016 at 16:34, Derek Foreman wrote: >>> Since commit d1314de293e9e4a63c35f094c3893aaaed8580b4 we ignore >>> damage passed to

Re: [Mesa-dev] [PATCH] mesa: Fix test for big-endian architecture in compiler.h

2016-02-12 Thread Roland Scheidegger
Am 12.02.2016 um 10:01 schrieb Jochen Rollwagen: > Hi, > > i think i found & fixed a bug in mesa concerning tests for big-endian > machines. The defines tested don't exist or are wrongly defined so the > test (probably) never fires. The gcc defines on my machine concerning > big-endian are > >

Re: [Mesa-dev] [PATCH] i965: Enable tiled mem_copy with sRGB-formatted resources

2016-02-12 Thread Anuj Phogat
On Thu, Feb 11, 2016 at 5:29 PM, Nanley Chery wrote: > From: Nanley Chery > > RGBA8 and BGRA8 unorm formats are compatible with the various > mem_copy functions. Their sRGB counterparts are also compatible > because they're also color-renderable

[Mesa-dev] [PATCH 2/2] st/mesa: new st_DrawAtlasBitmaps() function for drawing bitmap text

2016-02-12 Thread Brian Paul
This basically saves the current pipeline state, sets up state for rendering, constructs a set of textured quads, renders, then restores the previous pipeline state. It shouldn't be hard to implement a similar function for non-gallium drives. With some code refactoring, the vertex definition

[Mesa-dev] [PATCH 1/2] mesa: implement a display list / glBitmap texture atlas

2016-02-12 Thread Brian Paul
This improves the performance of applications which use glXUseXFont() or wglUseFontBitmaps() and glCallLists() to draw bitmap text. Basically, we collect all the glBitmap images from the display lists and put them into a texture atlas. To render the bitmaps for a glCallLists() command, we render

[Mesa-dev] [PATCH 2/2] st/mesa: simplify st->ctx, ctx->st usage in a various places

2016-02-12 Thread Brian Paul
--- src/mesa/state_tracker/st_cb_bitmap.c | 11 +-- src/mesa/state_tracker/st_cb_clear.c | 2 +- src/mesa/state_tracker/st_cb_drawpixels.c | 4 ++-- src/mesa/state_tracker/st_cb_drawtex.c| 6 +++--- src/mesa/state_tracker/st_cb_texture.c| 2 +-

[Mesa-dev] [PATCH 1/2] st/mesa: use _mesa_geometric_width/height() in glDrawPixels code

2016-02-12 Thread Brian Paul
--- src/mesa/state_tracker/st_cb_drawpixels.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c b/src/mesa/state_tracker/st_cb_drawpixels.c index ee172a0..15a91c7 100644 ---

[Mesa-dev] [PATCH] configure.ac: enable_asm=yes when x-compiling across same X86 arch

2016-02-12 Thread Dongwon Kim
Currently, configure script is forcing 'enable_asm' to be 'no' whenever cross-compilation is performed on X86 host. This is based on an assumption that target architecture is different from host's (i.e. ARM). But there's always a case that we do cross-compile for target that is also X86 based just

Re: [Mesa-dev] [PATCH] configure.ac: enable_asm=yes when x-compiling across same X86 arch

2016-02-12 Thread Matt Turner
On Fri, Feb 12, 2016 at 5:04 PM, Dongwon Kim wrote: > Currently, configure script is forcing 'enable_asm' to be 'no' > whenever cross-compilation is performed on X86 host. This is > based on an assumption that target architecture is different > from host's (i.e. ARM). But

Re: [Mesa-dev] [PATCH] glsl: reject explicit location on atomic counter uniforms

2016-02-12 Thread Timothy Arceri
On Fri, 2016-02-12 at 18:45 -0500, Ilia Mirkin wrote: > On Fri, Feb 12, 2016 at 5:53 PM, Timothy Arceri u> wrote: > > On Thu, 2016-02-11 at 20:10 -0500, Ilia Mirkin wrote: > > > This fixes > > > > > > dEQP-GLES31.functional.uniform_location.negative.atomic_fragment > > >

Re: [Mesa-dev] [PATCH] glsl: reject explicit location on atomic counter uniforms

2016-02-12 Thread Ilia Mirkin
On Fri, Feb 12, 2016 at 8:52 PM, Timothy Arceri wrote: > On Fri, 2016-02-12 at 18:45 -0500, Ilia Mirkin wrote: >> On Fri, Feb 12, 2016 at 5:53 PM, Timothy Arceri > u> wrote: >> > On Thu, 2016-02-11 at 20:10 -0500, Ilia Mirkin wrote: >> > > This fixes

[Mesa-dev] [PATCH 1/1] configure: Bail out on llvm-config component error

2016-02-12 Thread Jan Vesely
Signed-off-by: Jan Vesely --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 2750d4d..57330cb 100644 --- a/configure.ac +++ b/configure.ac @@ -2295,6 +2295,9 @@ dnl in LLVM_LIBS. if test "x$MESA_LLVM" != x0; then

Re: [Mesa-dev] [PATCH 1/2] st/mesa: use _mesa_geometric_width/height() in glDrawPixels code

2016-02-12 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Fri, Feb 12, 2016 at 8:07 PM, Brian Paul wrote: > --- > src/mesa/state_tracker/st_cb_drawpixels.c | 19 +-- > 1 file changed, 9 insertions(+), 10 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] glsl: reject explicit location on atomic counter uniforms

2016-02-12 Thread Timothy Arceri
On Fri, 2016-02-12 at 20:57 -0500, Ilia Mirkin wrote: > On Fri, Feb 12, 2016 at 8:52 PM, Timothy Arceri u> wrote: > > On Fri, 2016-02-12 at 18:45 -0500, Ilia Mirkin wrote: > > > On Fri, Feb 12, 2016 at 5:53 PM, Timothy Arceri > > om.a > > > u> wrote: > >

Re: [Mesa-dev] [PATCH] glsl: reject explicit location on atomic counter uniforms

2016-02-12 Thread Ilia Mirkin
On Fri, Feb 12, 2016 at 5:53 PM, Timothy Arceri wrote: > On Thu, 2016-02-11 at 20:10 -0500, Ilia Mirkin wrote: >> This fixes >> >> dEQP-GLES31.functional.uniform_location.negative.atomic_fragment >> dEQP-GLES31.functional.uniform_location.negative.atomic_vertex >> >> Both