Re: [Mesa-dev] [PATCH 4/4] xlib: remove MESA_GLX_VISUAL_HACK

2016-04-03 Thread Alejandro Piñeiro
On 02/04/16 01:52, John Sheu wrote: > This removes a hack introduced in 1999 in the first version of > fakeglx.c, with the comment: > > /* XXX revisit this after 3.0 is finished. */ > > Mesa 4.0 was released in 2001. It is now 2016, and Mesa 11.0 was > released last year. Probably it would be g

Re: [Mesa-dev] [PATCH 2/4] xlib: fix memory leak of and remove vishandle from XMesaVisualInfo

2016-04-03 Thread Alejandro Piñeiro
Assuming that the comments on the previous patch would be updated: Reviewed-by: Alejandro Piñeiro On 02/04/16 01:52, John Sheu wrote: > The vishandle member of XMesaVisualInfo is used to support the > comparison of XVisualInfo instances by pointer value, in > find_glx_visual(). The comparison h

Re: [Mesa-dev] [PATCH 3/4] xlib: fix leaks of returned values from XGetVisualInfo

2016-04-03 Thread Alejandro Piñeiro
Reviewed-by: Alejandro Piñeiro On 02/04/16 01:52, John Sheu wrote: > --- > src/mesa/drivers/x11/fakeglx.c | 29 + > 1 file changed, 21 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/drivers/x11/fakeglx.c b/src/mesa/drivers/x11/fakeglx.c > index 208fc5bb..508d

Re: [Mesa-dev] [PATCH 1/4] xlib: fix memory leak in glXChooseVisual/glXGetVisualFromFBConfig

2016-04-03 Thread Alejandro Piñeiro
On 04/04/16 08:11, Alejandro Piñeiro wrote: > On 02/04/16 01:52, John Sheu wrote: >> XMesaVisual.vishandle is being unconditionally overwritten every time >> glXChooseVisual/glXGetVisualFromFBConfig returns a new XVisualInfo >> instance, causing a memory leak. >> --- >> src/mesa/drivers/x11/fakegl

Re: [Mesa-dev] [PATCH 2/6] glsl: remove unused buffer block splitting function

2016-04-03 Thread Kenneth Graunke
On Sunday, April 3, 2016 9:16:29 PM PDT Timothy Arceri wrote: > --- > src/compiler/glsl/linker.cpp | 70 > 1 file changed, 70 deletions(-) Hrm? glsl: remove unused buffer block splitting function But it /is/ used...you just delete the use here.

Re: [Mesa-dev] [PATCH 1/6] glsl: make use of separate UBO and SSBO lists

2016-04-03 Thread Kenneth Graunke
On Sunday, April 3, 2016 9:16:28 PM PDT Timothy Arceri wrote: [snip] > @@ -3295,8 +3296,8 @@ should_add_buffer_variable(struct gl_shader_program *shProg, > if (type != GL_BUFFER_VARIABLE) >return true; > > - for (unsigned i = 0; i < shProg->NumBufferInterfaceBlocks; i++) { > -

[Mesa-dev] [Bug 94805] Compile Mesa , specific compilation , error: LLVM is required to build Gallium

2016-04-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94805 Kenneth Graunke changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/4] xlib: fix memory leak in glXChooseVisual/glXGetVisualFromFBConfig

2016-04-03 Thread Alejandro Piñeiro
On 02/04/16 01:52, John Sheu wrote: > XMesaVisual.vishandle is being unconditionally overwritten every time > glXChooseVisual/glXGetVisualFromFBConfig returns a new XVisualInfo > instance, causing a memory leak. > --- > src/mesa/drivers/x11/fakeglx.c | 26 -- > 1 file chang

[Mesa-dev] [PATCH 1/2] i965: Make bblock_t::next and friends return NULL at sentinels.

2016-04-03 Thread Kenneth Graunke
The bblock_t::prev/prev_const/next/next_const API returns bblock_t pointers, rather than exec_nodes. So it's a bit surprising. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_cfg.h | 12 src/mesa/drivers/dri/i965/brw_shader.cpp | 2 +- 2 files changed, 13 ins

[Mesa-dev] [PATCH v2 2/2] i965: Fix invalid pointer read in dead_control_flow_eliminate().

2016-04-03 Thread Kenneth Graunke
There may not be a previous block. In this case, there's no real work to do, so just continue on to the next one. v2: Update for bblock->prev() API change. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_dead_control_flow.cpp | 4 1 file changed, 4 insertions(+) diff --g

Re: [Mesa-dev] [PATCH] nir: Use PRIi64 and PRIu64 instead of %ld and %lu.

2016-04-03 Thread Jason Ekstrand
On Apr 3, 2016 7:51 PM, "Kenneth Graunke" wrote: > > %ld and %lu aren't the right format specifiers for int64_t and uint64_t > on 32-bit (x86) systems. They're %zu on Linux and %Iu on Windows. > > Use the standard C99 macros in hopes that they work everywhere. > > Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] report ARB_cull_distance

2016-04-03 Thread eocallaghan
Patches 1-5, 8 & 10 are, Reviewed-by: Edward O'Callaghan On 2016-04-04 12:15, Dave Airlie wrote: Okay I've taken Tobias' last work in progress, cleaned it up a bit, move the rename out into a separate patch, reordered things slightly. I've dropped the separate passes, I think nearly all hw op

Re: [Mesa-dev] [PATCH 1/2] glsl: Don't remove XFB-only varyings.

2016-04-03 Thread Kenneth Graunke
On Sunday, April 3, 2016 9:34:05 PM PDT Timothy Arceri wrote: > On Sun, 2016-04-03 at 01:37 -0700, Kenneth Graunke wrote: > > Consider the case of linking a program with both a vertex and > > fragment > > shader. The VS may compute output varyings that are intended for > > transform feedback, and

[Mesa-dev] [PATCH] nir: Use PRIi64 and PRIu64 instead of %ld and %lu.

2016-04-03 Thread Kenneth Graunke
%ld and %lu aren't the right format specifiers for int64_t and uint64_t on 32-bit (x86) systems. They're %zu on Linux and %Iu on Windows. Use the standard C99 macros in hopes that they work everywhere. Signed-off-by: Kenneth Graunke --- src/compiler/nir/nir_search.c | 5 +++-- 1 file changed,

Re: [Mesa-dev] [PATCH 07/12] glsl: Add arb_cull_distance support

2016-04-03 Thread Timothy Arceri
On Mon, 2016-04-04 at 12:15 +1000, Dave Airlie wrote: > From: Tobias Klausmann > > Signed-off-by: Tobias Klausmann > > --- >  src/compiler/glsl/ast_to_hir.cpp |  14 +++ >  src/compiler/glsl/builtin_variables.cpp  |  11 ++- >  src/compiler/glsl/glcpp/glcpp-parse.y|   3 + >

Re: [Mesa-dev] [PATCH 11/12] nvc0: Implement cull_distance as a special form of clip distance

2016-04-03 Thread Ilia Mirkin
On Sun, Apr 3, 2016 at 10:15 PM, Dave Airlie wrote: > From: Tobias Klausmann > > This enables ARB_cull_distance. This isn't enough - something needs to lower the CULLDIST into CLIPDIST (or some combined thing). Ideally they'd both just come in as CLIPDIST and the property would let us know where

[Mesa-dev] [PATCH 09/12] mesa/st: Add support for GL_ARB_cull_distance

2016-04-03 Thread Dave Airlie
From: Tobias Klausmann Signed-off-by: Tobias Klausmann --- src/mesa/state_tracker/st_extensions.c | 1 + src/mesa/state_tracker/st_program.c| 40 ++ 2 files changed, 41 insertions(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_trac

[Mesa-dev] [PATCH 06/12] glsl: Extend lowering pass for gl_ClipDistance to support other arrays (v2)

2016-04-03 Thread Dave Airlie
From: Tobias Klausmann This will come in handy when we want to lower gl_CullDistance into gl_CullDistanceMESA. [airlied: drop separate APIs for clip/cull - just use single API to call both passes.] Signed-off-by: Tobias Klausmann --- src/compiler/glsl/ir_optimization.h | 3 +- src/compiler

[Mesa-dev] [PATCH 04/12] glsl: Add a helper to see if an array was unsize in the shader

2016-04-03 Thread Dave Airlie
From: Tobias Klausmann Signed-off-by: Tobias Klausmann --- src/compiler/glsl/linker.cpp | 2 +- src/compiler/glsl_types.cpp | 8 src/compiler/glsl_types.h| 10 -- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/

[Mesa-dev] [PATCH 01/12] glapi: Add GL_ARB_cull_distance

2016-04-03 Thread Dave Airlie
From: Tobias Klausmann Signed-off-by: Tobias Klausmann --- src/mapi/glapi/gen/gl_API.xml | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 8b49f91..024acfd 100644 --- a/src/mapi/glapi/gen/gl_API.xml +++

[Mesa-dev] [PATCH 10/12] nv50/ir: Check for TGSI_SEMANTIC_CULLDIST in tgsi declarations

2016-04-03 Thread Dave Airlie
From: Tobias Klausmann Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp inde

[Mesa-dev] [PATCH 12/12] llvmpipe: Enable already implemented cull_distance

2016-04-03 Thread Dave Airlie
From: Tobias Klausmann Signed-off-by: Tobias Klausmann --- src/gallium/drivers/llvmpipe/lp_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c index 4665487..eb00e7c 100644 --- a/src/ga

[Mesa-dev] [PATCH 08/12] gallium: Add a pipe cap for arb_cull_distance

2016-04-03 Thread Dave Airlie
From: Tobias Klausmann This lets us safely enable or disable the extension as needed Signed-off-by: Tobias Klausmann --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/

[Mesa-dev] [PATCH 05/12] glsl: rename lower_clip_distance to lower_distance.

2016-04-03 Thread Dave Airlie
From: Dave Airlie This just renames the file in anticipation of adding cull lowering. Signed-off-by: Dave Airlie --- src/compiler/Makefile.sources | 2 +- src/compiler/glsl/Makefile.sources| 2 +- src/compiler/glsl/lower_clip_distance.cpp | 574 -

[Mesa-dev] [PATCH 07/12] glsl: Add arb_cull_distance support

2016-04-03 Thread Dave Airlie
From: Tobias Klausmann Signed-off-by: Tobias Klausmann --- src/compiler/glsl/ast_to_hir.cpp | 14 +++ src/compiler/glsl/builtin_variables.cpp | 11 ++- src/compiler/glsl/glcpp/glcpp-parse.y| 3 + src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/gls

[Mesa-dev] [PATCH 03/12] mesa/prog: Add varyings for arb_cull_distance

2016-04-03 Thread Dave Airlie
From: Tobias Klausmann Signed-off-by: Tobias Klausmann --- src/mesa/program/prog_print.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/program/prog_print.c b/src/mesa/program/prog_print.c index 08381b4..755d644 100644 --- a/src/mesa/program/prog_print.c +++ b/src/mesa/program

[Mesa-dev] [PATCH 02/12] mesa/main: Add support for GL_ARB_cull_distance (v2)

2016-04-03 Thread Dave Airlie
From: Tobias Klausmann airlied: v2: rename LowerClipDistance to LowerCombinedClipCullDistnace. I don't think we want any other behaviour with any current hw. Signed-off-by: Tobias Klausmann --- src/compiler/glsl/link_varyings.cpp | 2 +- src/compiler/glsl/linker.cpp | 2 +-

[Mesa-dev] [PATCH 11/12] nvc0: Implement cull_distance as a special form of clip distance

2016-04-03 Thread Dave Airlie
From: Tobias Klausmann This enables ARB_cull_distance. Signed-off-by: Tobias Klausmann --- docs/GL3.txt| 2 +- src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_program.h | 1 + src/gallium/drivers/nouveau/nvc0/nvc

[Mesa-dev] report ARB_cull_distance

2016-04-03 Thread Dave Airlie
Okay I've taken Tobias' last work in progress, cleaned it up a bit, move the rename out into a separate patch, reordered things slightly. I've dropped the separate passes, I think nearly all hw operates the same, I do wonder why we even have this as an option, since at least 965/gallium always req

[Mesa-dev] [PATCH] mesa: typecast arguments to printf to avoid 32-bit warnings

2016-04-03 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/main/bufferobj.c | 3 ++- src/mesa/vbo/vbo_exec_array.c | 8 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 731b62e..9a59043 100644 --- a/src/mesa/main/bufferobj.c +++

Re: [Mesa-dev] [PATCH] glsl: Don't copy propagate or tree graft precise/invariant values.

2016-04-03 Thread Jason Ekstrand
On Sun, Apr 3, 2016 at 5:36 PM, Kenneth Graunke wrote: > This is kind of a hack. We currently track precise/invariant > requirements by decorating ir_variables. Propagating or grafting > the RHS of an assignment to a precise/invariant value into some > other expression tree can lose those decor

[Mesa-dev] [PATCH 3/4] xlib: fix leaks of returned values from XGetVisualInfo

2016-04-03 Thread John Sheu
--- src/mesa/drivers/x11/fakeglx.c | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/x11/fakeglx.c b/src/mesa/drivers/x11/fakeglx.c index 208fc5bb..508dc65e 100644 --- a/src/mesa/drivers/x11/fakeglx.c +++ b/src/mesa/drivers/x11/fake

[Mesa-dev] [PATCH 1/4] xlib: fix memory leak in glXChooseVisual/glXGetVisualFromFBConfig

2016-04-03 Thread John Sheu
XMesaVisual.vishandle is being unconditionally overwritten every time glXChooseVisual/glXGetVisualFromFBConfig returns a new XVisualInfo instance, causing a memory leak. --- src/mesa/drivers/x11/fakeglx.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git

[Mesa-dev] [PATCH 4/4] xlib: remove MESA_GLX_VISUAL_HACK

2016-04-03 Thread John Sheu
This removes a hack introduced in 1999 in the first version of fakeglx.c, with the comment: /* XXX revisit this after 3.0 is finished. */ Mesa 4.0 was released in 2001. It is now 2016, and Mesa 11.0 was released last year. --- src/mesa/drivers/x11/fakeglx.c | 42 +++---

[Mesa-dev] [PATCH 2/4] xlib: fix memory leak of and remove vishandle from XMesaVisualInfo

2016-04-03 Thread John Sheu
The vishandle member of XMesaVisualInfo is used to support the comparison of XVisualInfo instances by pointer value, in find_glx_visual(). The comparison however will always be false, as in every case the comparison is made, the VisualInfo instance being compared to is a new allocation passed in t

[Mesa-dev] [PATCH] glsl: Don't copy propagate or tree graft precise/invariant values.

2016-04-03 Thread Kenneth Graunke
This is kind of a hack. We currently track precise/invariant requirements by decorating ir_variables. Propagating or grafting the RHS of an assignment to a precise/invariant value into some other expression tree can lose those decorations. In the long run, it might be better to replace these ir_

[Mesa-dev] [PATCH] i965: Add an INTEL_PRECISE_TRIG=1 option to fix SIN/COS output range.

2016-04-03 Thread Kenneth Graunke
The SIN and COS instructions on Intel hardware can produce values slightly outside of the [-1.0, 1.0] range for a small set of values. Obviously, this can break everyone's expectations about trig functions. According to an internal presentation, the COS instruction can produce a value up to 1.

Re: [Mesa-dev] [PATCH 4/6] gallium: add way for drivers to create fences without flushing

2016-04-03 Thread Roland Scheidegger
Am 03.04.2016 um 17:05 schrieb Rob Clark: > On Sat, Apr 2, 2016 at 8:31 PM, Rob Clark wrote: >> On Sat, Apr 2, 2016 at 7:55 PM, Roland Scheidegger >> wrote: >>> I don't really have anything against the new interface (though don't >>> really feel qualified for a proper review), but it is indeed t

Re: [Mesa-dev] [PATCH 4/6] gallium: add way for drivers to create fences without flushing

2016-04-03 Thread Roland Scheidegger
Am 03.04.2016 um 02:31 schrieb Rob Clark: > On Sat, Apr 2, 2016 at 7:55 PM, Roland Scheidegger wrote: >> I don't really have anything against the new interface (though don't >> really feel qualified for a proper review), but it is indeed the >> existence of the two interfaces living in parallel se

Re: [Mesa-dev] [PATCH] gallivm: Introduce lp_format_intrinsic.

2016-04-03 Thread Roland Scheidegger
Am 04.04.2016 um 00:25 schrieb Jose Fonseca: > For adding .v4f32 like suffixes to intrinsics, taking special care for > scalar case, which was being often neglected. > > This fixes invalid IR when doing mipmap filtering on SSE2 (the only > case where we'd use intrinsics with scalars.) > --- > src

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-04-03 Thread Rob Herring
On Sun, Apr 3, 2016 at 12:29 PM, Chih-Wei Huang wrote: > 2016-04-04 0:53 GMT+08:00 Chih-Wei Huang : >> 2016-04-02 4:42 GMT+08:00 Rob Herring : >>> >>> Here's an initial gralloc implementation based on my GBM map/unmap support: >>> >>> https://github.com/robherring/gbm_gralloc >>> >>> It's based on

[Mesa-dev] [PATCH] gallivm: Introduce lp_format_intrinsic.

2016-04-03 Thread Jose Fonseca
For adding .v4f32 like suffixes to intrinsics, taking special care for scalar case, which was being often neglected. This fixes invalid IR when doing mipmap filtering on SSE2 (the only case where we'd use intrinsics with scalars.) --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 19 -

Re: [Mesa-dev] [PATCH] nv50, nvc0: support sending string markers down into the command stream

2016-04-03 Thread Ilia Mirkin
The functionality should be accessible today with KHR_debug (and ARB_something, also in GL 4.3). I believe glretrace uses it, and there's also an option to expose GREMEDY_string_marker. (If you do ST_DEBUG=gremedy iirc.) On Sun, Apr 3, 2016 at 5:53 PM, Samuel Pitoiset wrote: > I guess it's needed

Re: [Mesa-dev] [PATCH] nv50, nvc0: support sending string markers down into the command stream

2016-04-03 Thread Samuel Pitoiset
I guess it's needed to override the gl version to use this feature as 4.3 is not yet supported? Anyway, this might be useful if apps use glDebugMessageInsert(). Reviewed-by: Samuel Pitoiset On 04/03/2016 10:04 PM, Ilia Mirkin wrote: This should hopefully make it a little easier to debug with

Re: [Mesa-dev] [PATCH 2/3] gallivm: Prefer backend agnostic intrinsic for rounding.

2016-04-03 Thread Jose Fonseca
On 03/04/16 16:20, Roland Scheidegger wrote: Am 03.04.2016 um 12:24 schrieb Jose Fonseca: We could unconditionally use these instrinsics, but performance with SSE2 would suck, as LLVM falls back to calling libm. Would that really work now? Last time I checked, calls out to libm from the jitted

[Mesa-dev] [PATCH] radeon: Change AA sample locations for EG+

2016-04-03 Thread Axel Davy
This sets the AA location to the d3d11 spec. EG/NI 8X MSAA is left as is. Not sure why it was set different to Cayman, so let it as is. Signed-off-by: Axel Davy --- src/gallium/drivers/radeon/cayman_msaa.c | 68 1 file changed, 34 insertions(+), 34 deletions(-)

[Mesa-dev] [PATCH] nv50, nvc0: support sending string markers down into the command stream

2016-04-03 Thread Ilia Mirkin
This should hopefully make it a little easier to debug with GL applications like glretrace and looking at command streams. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nv50/nv50_context.c | 25 + src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 +- src/g

[Mesa-dev] [PATCH] r600g: Change default behaviour for undefined COLOR0

2016-04-03 Thread Axel Davy
d3d 9 needs COLOR0 to be 1.0 on all channels when undefined. 0.0 for the others is fine. GL behaviour is undefined. Signed-off-by: Axel Davy --- src/gallium/drivers/r600/evergreen_state.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/r600/evergreen_state.c b/src/ga

[Mesa-dev] [PATCH] nv50, nvc0: add invalidate_resource support for buffer resources

2016-04-03 Thread Ilia Mirkin
Provide a callback to reallocate the underlying storage of a resource so that it is not bound to any existing fences. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nouveau_buffer.c | 33 src/gallium/drivers/nouveau/nouveau_buffer.h | 4 +++ src/gall

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-04-03 Thread Rob Clark
On Sun, Apr 3, 2016 at 12:53 PM, Chih-Wei Huang wrote: > 2016-04-02 4:42 GMT+08:00 Rob Herring : >> >> Here's an initial gralloc implementation based on my GBM map/unmap support: >> >> https://github.com/robherring/gbm_gralloc >> >> It's based on drm_gralloc, but heavily re-written to collapse som

Re: [Mesa-dev] [PATCH 1/3] r600: Change default behaviour for undefined COLOR0

2016-04-03 Thread Roland Scheidegger
Am 03.04.2016 um 10:11 schrieb Axel Davy: > d3d 9 needs COLOR0 to be 1.0 on all channels when > undefined. 0.0 for the others is fine. > GL behaviour is undefined. > > Signed-off-by: Axel Davy > --- > src/gallium/drivers/r600/r600_state.c | 4 > 1 file changed, 4 insertions(+) > > diff --g

Re: [Mesa-dev] [PATCH 1/3] r600: Change default behaviour for undefined COLOR0

2016-04-03 Thread Axel Davy
On 03/04/2016 19:37, Marek Olšák wrote: r600_state.c only applies to r600-r700. evergreen_state.c is for EG and NI. Did you want to update that as well? Marek Thanks for pointing that out, I'll write a patch for EG and NI as well. Axem ___ mesa-dev

Re: [Mesa-dev] [PATCH 3/3] radeonsi: Mixed colorbuffer formats are unsupported

2016-04-03 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Sun, Apr 3, 2016 at 10:11 AM, Axel Davy wrote: > Besides depth/stencil, the hardware doesn't support > mixed formats. > > The GL state tracker doesn't make use of them. > > Signed-off-by: Axel Davy > --- > src/gallium/drivers/radeonsi/si_stat

Re: [Mesa-dev] [PATCH 1/3] r600: Change default behaviour for undefined COLOR0

2016-04-03 Thread Marek Olšák
r600_state.c only applies to r600-r700. evergreen_state.c is for EG and NI. Did you want to update that as well? Marek On Sun, Apr 3, 2016 at 10:11 AM, Axel Davy wrote: > d3d 9 needs COLOR0 to be 1.0 on all channels when > undefined. 0.0 for the others is fine. > GL behaviour is undefined. > > S

Re: [Mesa-dev] [PATCH] glsl: Print "precise" on ir_variable nodes.

2016-04-03 Thread Eduardo Lima Mitev
Reviewed-by: Eduardo Lima Mitev On 04/03/2016 10:34 AM, Kenneth Graunke wrote: Signed-off-by: Kenneth Graunke --- src/compiler/glsl/ir_print_visitor.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/ir_print_visitor.cpp b/src/compiler/glsl/ir_pr

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-04-03 Thread Chih-Wei Huang
2016-04-04 0:53 GMT+08:00 Chih-Wei Huang : > 2016-04-02 4:42 GMT+08:00 Rob Herring : >> >> Here's an initial gralloc implementation based on my GBM map/unmap support: >> >> https://github.com/robherring/gbm_gralloc >> >> It's based on drm_gralloc, but heavily re-written to collapse some >> unnecess

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-04-03 Thread Chih-Wei Huang
2016-04-02 4:42 GMT+08:00 Rob Herring : > > Here's an initial gralloc implementation based on my GBM map/unmap support: > > https://github.com/robherring/gbm_gralloc > > It's based on drm_gralloc, but heavily re-written to collapse some > unnecessary layers. Thank you for it. What GPU have you te

Re: [Mesa-dev] [PATCH 2/2] i965: Enable the GL_OES_texture_buffer extension.

2016-04-03 Thread Ilia Mirkin
On Sun, Apr 3, 2016 at 4:37 AM, Kenneth Graunke wrote: > Ilia Mirkin did all the hard work here. We can just enable it. In fairness, the *hard* work was done by the people who added texture and image buffers support to mesa. Anyways, mind also updating GL3.txt and perhaps relnotes? This was the

Re: [Mesa-dev] [PATCH 2/3] gallivm: Prefer backend agnostic intrinsic for rounding.

2016-04-03 Thread Roland Scheidegger
Am 03.04.2016 um 12:24 schrieb Jose Fonseca: > We could unconditionally use these instrinsics, but performance with SSE2 > would suck, as LLVM falls back to calling libm. Would that really work now? Last time I checked, calls out to libm from the jitted code weren't just slow, they simply crashed.

Re: [Mesa-dev] [PATCH 3/3] gallivm: Use llvm.fabs.

2016-04-03 Thread Roland Scheidegger
Am 03.04.2016 um 12:24 schrieb Jose Fonseca: > Exactly the same code. > --- > src/gallium/auxiliary/gallivm/lp_bld_arit.c | 11 +++ > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit.c > b/src/gallium/auxiliary/gallivm/lp_bld_arit

Re: [Mesa-dev] [PATCH 4/6] gallium: add way for drivers to create fences without flushing

2016-04-03 Thread Rob Clark
On Sat, Apr 2, 2016 at 8:31 PM, Rob Clark wrote: > On Sat, Apr 2, 2016 at 7:55 PM, Roland Scheidegger wrote: >> I don't really have anything against the new interface (though don't >> really feel qualified for a proper review), but it is indeed the >> existence of the two interfaces living in par

Re: [Mesa-dev] [PATCH] nv50: add edgeflag support when using inline vertex data submit

2016-04-03 Thread Samuel Pitoiset
Ping? (~4 months later). Ilia? :) On 11/23/2015 09:36 PM, Samuel Pitoiset wrote: Fixes the following piglit tests: - gl-1.0-edgeflag - gl-1.0-edgeflag-quads - gl-2.0-edgeflag - gl-2.0-edgeflag-immediate - point-vertex-id divisor - point-vertex-id gl_InstanceID - point-vertex-id gl_

Re: [Mesa-dev] [PATCH 00/20] GL compute shaders for radeonsi

2016-04-03 Thread eocallaghan
This series is, Tested-By: Edward O'Callaghan I didn`t pick up anything major wrong with it, but with others minor suggestions this series is also, Reviewed-By: Edward O'Callaghan Kind Regards, On 2016-04-03 00:10, Bas Nieuwenhuizen wrote: This series implements OpenGL compute shader for r

Re: [Mesa-dev] Split buffer block array into UBO and SSBO arrays

2016-04-03 Thread eocallaghan
This series is, Acked-by: Edward O'Callaghan On 2016-04-03 21:16, Timothy Arceri wrote: This is the final clean-up of the buffer block structures. With this series we just create two arrays to begin with and drop the combined array. Note to avoid code churn and regressions I intend to squash

Re: [Mesa-dev] radeonsi, r600g ARB_framebuffer_no_attachments rebased

2016-04-03 Thread eocallaghan
On 2016-04-03 14:55, Ilia Mirkin wrote: On Sat, Apr 2, 2016 at 10:54 PM, Edward O'Callaghan wrote: This series implements ARB_framebuffer_no_attachments for radeonsi & r600g. It is a rebase of the last previous patch series with the respective Rb's added. I have given back my R9 hw today and s

Re: [Mesa-dev] [PATCH 1/2] glsl: Don't remove XFB-only varyings.

2016-04-03 Thread Timothy Arceri
On Sun, 2016-04-03 at 01:37 -0700, Kenneth Graunke wrote: > Consider the case of linking a program with both a vertex and > fragment > shader.  The VS may compute output varyings that are intended for > transform feedback, and not read by the fragment shader. > > In this case, var->data.is_unmatch

[Mesa-dev] Split buffer block array into UBO and SSBO arrays

2016-04-03 Thread Timothy Arceri
This is the final clean-up of the buffer block structures. With this series we just create two arrays to begin with and drop the combined array. Note to avoid code churn and regressions I intend to squash patches 1-4 before pushing I've just sent them split up to make reviewing easier. __

[Mesa-dev] [PATCH 2/6] glsl: remove unused buffer block splitting function

2016-04-03 Thread Timothy Arceri
--- src/compiler/glsl/linker.cpp | 70 1 file changed, 70 deletions(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index 75a2afa..2f152d6 100644 --- a/src/compiler/glsl/linker.cpp +++ b/src/compiler/glsl/linker.cpp @@ -4122

[Mesa-dev] [PATCH 1/6] glsl: make use of separate UBO and SSBO lists

2016-04-03 Thread Timothy Arceri
--- src/compiler/glsl/link_uniform_initializers.cpp | 17 +++--- src/compiler/glsl/link_uniforms.cpp | 22 +++-- src/compiler/glsl/linker.cpp| 42 ++--- 3 files changed, 48 insertions(+), 33 deletions(-) diff --git a/src/compiler/gls

[Mesa-dev] [PATCH 4/6] glsl: fully split apart buffer block arrays

2016-04-03 Thread Timothy Arceri
With this chage we create the UBO and SSBO arrays separately from the beginning rather than putting them into a combined array and splitting it apart later. --- src/compiler/glsl/link_uniform_blocks.cpp | 204 +--- src/compiler/glsl/link_uniform_initializers.cpp | 4 +-

[Mesa-dev] [PATCH 5/6] mesa: remove unused IsShaderStorage field

2016-04-03 Thread Timothy Arceri
--- src/compiler/glsl/link_uniform_blocks.cpp | 1 - src/mesa/main/mtypes.h| 5 - 2 files changed, 6 deletions(-) diff --git a/src/compiler/glsl/link_uniform_blocks.cpp b/src/compiler/glsl/link_uniform_blocks.cpp index 3ef1633..2efb4e3 100644 --- a/src/compiler/glsl/link_

[Mesa-dev] [PATCH 6/6] glsl: remove remaining tabs in link_uniform_blocks.cpp

2016-04-03 Thread Timothy Arceri
--- src/compiler/glsl/link_uniform_blocks.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/link_uniform_blocks.cpp b/src/compiler/glsl/link_uniform_blocks.cpp index 2efb4e3..25a30e3 100644 --- a/src/compiler/glsl/link_uniform_blocks.cpp +++ b/sr

[Mesa-dev] [PATCH 3/6] glsl: fix UBO and SSBO stage ref query

2016-04-03 Thread Timothy Arceri
Index is the block index so we need to lookup the reference in the separate arrays not the combined buffer block array. --- src/mesa/main/shader_query.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp inde

[Mesa-dev] [PATCH 1/3] gallivm: Add debug option to force SSE2.

2016-04-03 Thread Jose Fonseca
For simulating less capable machines. --- src/gallium/auxiliary/gallivm/lp_bld_init.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_init.c b/src/gallium/auxiliary/gallivm/lp_bld_init.c index ab55be4..6e08ac4 10

[Mesa-dev] [PATCH 3/3] gallivm: Use llvm.fabs.

2016-04-03 Thread Jose Fonseca
Exactly the same code. --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit.c b/src/gallium/auxiliary/gallivm/lp_bld_arit.c index 1277743..587c83a 100644 --- a/src/gallium/auxiliar

[Mesa-dev] [PATCH 2/3] gallivm: Prefer backend agnostic intrinsic for rounding.

2016-04-03 Thread Jose Fonseca
We could unconditionally use these instrinsics, but performance with SSE2 would suck, as LLVM falls back to calling libm. lp_test_arit. --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 46 - 1 file changed, 39 insertions(+), 7 deletions(-) diff --git a/src/gallium/au

[Mesa-dev] [Bug 94805] Compile Mesa , specific compilation , error: LLVM is required to build Gallium

2016-04-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94805 Bug ID: 94805 Summary: Compile Mesa , specific compilation , error: LLVM is required to build Gallium Product: Mesa Version: 11.1 Hardware: Other OS: All

[Mesa-dev] [PATCH 2/2] i965: Enable the GL_OES_texture_buffer extension.

2016-04-03 Thread Kenneth Graunke
Ilia Mirkin did all the hard work here. We can just enable it. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) ES31-CTS.texture_buffer.texture_buffer_texture_buffer_range failed when I originally enabled this extension, but

[Mesa-dev] [PATCH 1/2] glsl: Don't remove XFB-only varyings.

2016-04-03 Thread Kenneth Graunke
Consider the case of linking a program with both a vertex and fragment shader. The VS may compute output varyings that are intended for transform feedback, and not read by the fragment shader. In this case, var->data.is_unmatched_generic_inout will be true, but we still cannot eliminate the varyi

[Mesa-dev] [PATCH] glsl: Print "precise" on ir_variable nodes.

2016-04-03 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/compiler/glsl/ir_print_visitor.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/ir_print_visitor.cpp b/src/compiler/glsl/ir_print_visitor.cpp index 960b23f..e06acce 100644 --- a/src/compiler/glsl/ir_print_visito

[Mesa-dev] [PATCH 2/3] radeonsi: Change default behaviour for undefined COLOR0

2016-04-03 Thread Axel Davy
d3d 9 needs COLOR0 to be 1.0 on all channels when undefined. 0.0 for the others is fine. GL behaviour is undefined. Signed-off-by: Axel Davy --- src/gallium/drivers/radeonsi/si_state_shaders.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c

[Mesa-dev] [PATCH 3/3] radeonsi: Mixed colorbuffer formats are unsupported

2016-04-03 Thread Axel Davy
Besides depth/stencil, the hardware doesn't support mixed formats. The GL state tracker doesn't make use of them. Signed-off-by: Axel Davy --- src/gallium/drivers/radeonsi/si_state.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/g

[Mesa-dev] [PATCH 1/3] r600: Change default behaviour for undefined COLOR0

2016-04-03 Thread Axel Davy
d3d 9 needs COLOR0 to be 1.0 on all channels when undefined. 0.0 for the others is fine. GL behaviour is undefined. Signed-off-by: Axel Davy --- src/gallium/drivers/r600/r600_state.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/r600/r600_state.c b/src/gallium/driv