Re: [Mesa-dev] [PATCH 1/2] i965: Expose the surface format table

2016-04-14 Thread Alejandro Piñeiro
On 14/04/16 20:37, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/Makefile.sources | 1 + > src/mesa/drivers/dri/i965/brw_surface_formats.c | 22 +++-- > src/mesa/drivers/dri/i965/brw_surface_formats.h | 43 > + > 3 files changed, 48 insertions(+), 1

Re: [Mesa-dev] [PATCH v2] xlib: do not cache return value of glXChooseVisual/glXGetVisualFromFBConfig

2016-04-14 Thread Alejandro Piñeiro
On 14/04/16 19:23, Emil Velikov wrote: > On 14 April 2016 at 08:09, Alejandro Piñeiro wrote: >> For next time, on the cases were minor changes are suggested, but a RB >> is granted in any case, you don't need to send the patch again to the >> list, you can made the changes locally and push directl

Re: [Mesa-dev] [PATCH v2] xlib: do not cache return value of glXChooseVisual/glXGetVisualFromFBConfig

2016-04-14 Thread Alejandro Piñeiro
On 14/04/16 19:10, John Sheu wrote: > Thanks! I don't have push permissions actually, so all my stuff is > going through the mailing list at the moment. > > -John Sheu Those 4 patches pushed. Best regards. > > On Thu, Apr 14, 2016 at 12:09 AM Alejandro Piñeiro > mailto:apinhe...@igalia.com>> wr

Re: [Mesa-dev] [PATCH] util: Fix race condition on libgcrypt initialization

2016-04-14 Thread Mark Janes
Jason Ekstrand writes: > On Tue, Apr 12, 2016 at 3:51 PM, Jason Ekstrand > wrote: > >> >> On Apr 12, 2016 3:41 PM, "Matt Turner" wrote: >> > >> > On Tue, Apr 12, 2016 at 3:10 PM, Mark Janes >> wrote: >> > > Fixes intermittent Vulkan CTS failures within the test groups: >> > > dEQP-VK.api.objec

[Mesa-dev] [PATCH] i965/fs: Don't allow OOB array access of images

2016-04-14 Thread Jason Ekstrand
We have had a guard against OOB array access of images on IVB for a long time, but it can actually cause hangs on any GPU generation. This can happen due to getting an untyped SURFACE_STATE for a typed message or vice-versa. We didn't used to hit this with the piglit test on anything other than I

Re: [Mesa-dev] [PATCH] nir: passthrough-edgeflags support

2016-04-14 Thread Eric Anholt
Rob Clark writes: > From: Rob Clark > > Handled by tgsi_emulate for glsl->tgsi case. > > Signed-off-by: Rob Clark > Reviewed-by: Connor Abbott > --- > src/compiler/Makefile.sources | 1 + > src/compiler/nir/nir.h | 2 + > src/compiler/nir/nir

[Mesa-dev] [PATCH] util/list: Add list splicing functions

2016-04-14 Thread Jason Ekstrand
This adds functions for splicing one list into another. These have more-or-less the same API as the kernel list splicing functions. --- src/util/list.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/util/list.h b/src/util/list.h index b98ce59..d4b4851 100644 --- a

Re: [Mesa-dev] [PATCH] nir: add lowering pass for glBitmap

2016-04-14 Thread Eric Anholt
Rob Clark writes: > From: Rob Clark > > Signed-off-by: Rob Clark > Reviewed-by: Connor Abbott Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org

Re: [Mesa-dev] [PATCH] util: Fix race condition on libgcrypt initialization

2016-04-14 Thread Jason Ekstrand
On Tue, Apr 12, 2016 at 3:51 PM, Jason Ekstrand wrote: > > On Apr 12, 2016 3:41 PM, "Matt Turner" wrote: > > > > On Tue, Apr 12, 2016 at 3:10 PM, Mark Janes > wrote: > > > Fixes intermittent Vulkan CTS failures within the test groups: > > > dEQP-VK.api.object_management.multithreaded_per_thread

Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-14 Thread Jason Ekstrand
Adding the list back in... On Thu, Apr 14, 2016 at 6:05 PM, Jason Ekstrand wrote: > > > On Thu, Apr 14, 2016 at 5:52 PM, Rob Clark wrote: > >> On Thu, Apr 14, 2016 at 7:23 PM, Jason Ekstrand >> wrote: >> > >> > On Apr 14, 2016 4:15 PM, "Connor Abbott" wrote: >> >> >> >> On Wed, Apr 13, 2016 a

[Mesa-dev] [PATCH] radeonsi: enable GLSL 4.30 and therefore OpenGL 4.3

2016-04-14 Thread Edward O'Callaghan
This is the last necessary bit for OpenGL 4.3 support. All driver-specific functionality has already been implemented as part of extensions. Signed-off-by: Edward O'Callaghan --- docs/GL3.txt | 2 +- docs/relnotes/11.3.0.html | 8 src/gallium/drive

[Mesa-dev] Enable GL 4.3 for radeonsi + update resp. docs

2016-04-14 Thread Edward O'Callaghan
Enable GL level once shader_compute series has been merged and remaining issues have been resolved. Edward O'Callaghan (1): radeonsi: enable GLSL 4.30 and therefore OpenGL 4.3 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freed

Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-14 Thread Jason Ekstrand
On Apr 12, 2016 9:36 PM, "Connor Abbott" wrote: > > Previously, these were functions which took a callback. This meant that > the per-block code had to be in a separate function, and all the data > that you wanted to pass in had to be a single void *. They walked the > control flow tree recursivel

Re: [Mesa-dev] [PATCH] radeonsi: Enable GLSL 4.30 and therefore OpenGL 4.3

2016-04-14 Thread Nicolai Hähnle
The patch is fine, of course, but for pragmatic reasons we need to wait until the Unreal Engine problem is resolved. E.g. Elemental Demo (but really anything UE4) fails with LowLevelFatalError [File:C:\UnrealEngine\4.5-src\Engine\Source\Runtime\OpenGLDrv\Private\OpenGLShaders.cpp] [Line: 71]

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-14 Thread Ilia Mirkin
On Thu, Apr 14, 2016 at 7:26 PM, Roland Scheidegger wrote: > Am 14.04.2016 um 14:18 schrieb Oded Gabbay: >> This patch adds a new field, called "endian_format", to >> "struct pipe_resource". The new field is of type "enum pipe_endian" and >> can receive one of two values: >> - PIPE_ENDIAN_LITTLE >

[Mesa-dev] [PATCH] gallium/swr: confine c++11 flag to swr driver

2016-04-14 Thread Tim Rowley
On the philosophy that a driver shouldn't change the compile flags for the entire tree, take the clove approach of moving the c++11 flag to the swr driver directory. --- configure.ac| 9 +- m4/ax_cxx_compile_stdcxx.m4 | 558 sr

Re: [Mesa-dev] [PATCH v2 04/11] gallium: add endian_format field to struct pipe_resource

2016-04-14 Thread Roland Scheidegger
Am 14.04.2016 um 14:18 schrieb Oded Gabbay: > This patch adds a new field, called "endian_format", to > "struct pipe_resource". The new field is of type "enum pipe_endian" and > can receive one of two values: > - PIPE_ENDIAN_LITTLE > - PIPE_ENDIAN_NATIVE > > PIPE_ENDIAN_NATIVE is initialized to ei

Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-14 Thread Jason Ekstrand
On Apr 14, 2016 4:15 PM, "Connor Abbott" wrote: > > On Wed, Apr 13, 2016 at 7:45 PM, Jason Ekstrand wrote: > > > > > > On Wed, Apr 13, 2016 at 2:06 PM, Connor Abbott wrote: > >> > >> On Wed, Apr 13, 2016 at 3:20 PM, Jason Ekstrand > >> wrote: > >> > > >> > > >> > On Wed, Apr 13, 2016 at 12:15 P

Re: [Mesa-dev] [PATCH 01/47] nir: rewrite nir_foreach_block and friends

2016-04-14 Thread Connor Abbott
On Wed, Apr 13, 2016 at 7:45 PM, Jason Ekstrand wrote: > > > On Wed, Apr 13, 2016 at 2:06 PM, Connor Abbott wrote: >> >> On Wed, Apr 13, 2016 at 3:20 PM, Jason Ekstrand >> wrote: >> > >> > >> > On Wed, Apr 13, 2016 at 12:15 PM, Connor Abbott >> > wrote: >> >> >> >> On Wed, Apr 13, 2016 at 2:49

Re: [Mesa-dev] [PATCH] nir: add lowering pass for glBitmap

2016-04-14 Thread Connor Abbott
This looks much better :) both patches LGTM. On Thu, Apr 14, 2016 at 6:44 PM, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > Reviewed-by: Connor Abbott > --- > src/compiler/Makefile.sources | 1 + > src/compiler/nir/nir.h | 7 ++ > src/compiler/nir/ni

[Mesa-dev] [PATCH] nir: add lowering pass for glBitmap

2016-04-14 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Connor Abbott --- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h | 7 ++ src/compiler/nir/nir_lower_bitmap.c | 139 3 files changed, 147 insertions(+) create mode 100

[Mesa-dev] [PATCH] nir: passthrough-edgeflags support

2016-04-14 Thread Rob Clark
From: Rob Clark Handled by tgsi_emulate for glsl->tgsi case. Signed-off-by: Rob Clark Reviewed-by: Connor Abbott --- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h | 2 + src/compiler/nir/nir_lower_passthrough_edgeflags.c | 55 ++

Re: [Mesa-dev] [PATCH] nir: add lowering pass for glBitmap

2016-04-14 Thread Rob Clark
On Thu, Apr 14, 2016 at 6:40 PM, Rob Clark wrote: > On Thu, Apr 14, 2016 at 6:33 PM, Connor Abbott wrote: >> On Thu, Apr 14, 2016 at 6:10 PM, Rob Clark wrote: >>> From: Rob Clark >>> >>> Signed-off-by: Rob Clark >>> Reviewed-by: Connor Abbott >>> --- >>> src/compiler/Makefile.sources |

[Mesa-dev] [PATCH] radeonsi: Enable GLSL 4.30 and therefore OpenGL 4.3

2016-04-14 Thread Mike Lothian
This is the last necessary bit for OpenGL 4.3 support, All driver-specific functionality has been implemented as part of extensions. --- Was testing Bas's patches with Middle-Earth: Shadow of Mordor but needed this to expose OpenGL 4.3 src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 1 file chang

Re: [Mesa-dev] [PATCH] nir: add lowering pass for glBitmap

2016-04-14 Thread Rob Clark
On Thu, Apr 14, 2016 at 6:33 PM, Connor Abbott wrote: > On Thu, Apr 14, 2016 at 6:10 PM, Rob Clark wrote: >> From: Rob Clark >> >> Signed-off-by: Rob Clark >> Reviewed-by: Connor Abbott >> --- >> src/compiler/Makefile.sources | 1 + >> src/compiler/nir/nir.h | 7 ++ >>

Re: [Mesa-dev] [PATCH] nir: add lowering pass for glBitmap

2016-04-14 Thread Connor Abbott
On Thu, Apr 14, 2016 at 6:10 PM, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > Reviewed-by: Connor Abbott > --- > src/compiler/Makefile.sources | 1 + > src/compiler/nir/nir.h | 7 ++ > src/compiler/nir/nir_lower_bitmap.c | 167 >

Re: [Mesa-dev] [RFC 15/24] nv50/ir: make use of OP_SUQ for surfaces query

2016-04-14 Thread Samuel Pitoiset
On 04/13/2016 10:33 PM, Ilia Mirkin wrote: On Tue, Apr 12, 2016 at 7:57 PM, Samuel Pitoiset wrote: This implements RESQ for surfaces which comes from imageSize() GLSL bultin. As the dimensions are sticked into the driver constant buffer, this only has to be lowered with loads. Signed-off-by:

Re: [Mesa-dev] [RFC 24/24] nvc0: expose GLSL version 420 on GK104

2016-04-14 Thread Samuel Pitoiset
On 04/13/2016 10:46 PM, Ilia Mirkin wrote: Reviewed-by: Ilia Mirkin Maybe even make it 440 while you're at it? No harm done, we have all the features. It'll get clamped down by mesa core for now having this or that extension. I would prefer to make this change later in a separate patch.

Re: [Mesa-dev] [RFC 20/24] nvc0/ir: prevent out of bounds when no images are bound

2016-04-14 Thread Samuel Pitoiset
On 04/13/2016 10:44 PM, Ilia Mirkin wrote: On Tue, Apr 12, 2016 at 7:57 PM, Samuel Pitoiset wrote: Checking if the image address is not 0 should be enough to prevent read faults. To improve robustness, make sure that the destination value of atomic operations is correctly initialized in case

Re: [Mesa-dev] [RFC 18/24] nvc0/ir: fix 1D arrays images for Kepler

2016-04-14 Thread Samuel Pitoiset
On 04/13/2016 10:39 PM, Ilia Mirkin wrote: On Tue, Apr 12, 2016 at 7:57 PM, Samuel Pitoiset wrote: For 1D arrays, the array index is stored in the Z component. Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 17 + 1 file change

[Mesa-dev] [PATCH] nir: passthrough-edgeflags support

2016-04-14 Thread Rob Clark
From: Rob Clark Handled by tgsi_emulate for glsl->tgsi case. Signed-off-by: Rob Clark Reviewed-by: Connor Abbott --- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h | 2 + src/compiler/nir/nir_lower_passthrough_edgeflags.c | 82 ++

[Mesa-dev] [PATCH] nir: add lowering pass for glBitmap

2016-04-14 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Connor Abbott --- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h | 7 ++ src/compiler/nir/nir_lower_bitmap.c | 167 3 files changed, 175 insertions(+) create mode 100

[Mesa-dev] [PATCH] mesa/st: add support for NIR as possible driver IR

2016-04-14 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/mesa/Makefile.sources | 1 + src/mesa/SConscript| 1 + src/mesa/state_tracker/st_glsl_to_nir.cpp | 423 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 40 ++- src/mesa/sta

Re: [Mesa-dev] [RFC 11/24] nv50/ir: re-introduce TGSI lowering pass for images

2016-04-14 Thread Samuel Pitoiset
On 04/13/2016 10:27 PM, Ilia Mirkin wrote: The .raw stuff is never true. I'd just kill it off for now. Okay. On Tue, Apr 12, 2016 at 7:57 PM, Samuel Pitoiset wrote: This is loosely based on the previous lowering pass wrote by calim four years ago. I did clean the code and fixed some issu

Re: [Mesa-dev] [RFC 09/24] nvc0: add missing glMemoryBarrier bits

2016-04-14 Thread Samuel Pitoiset
On 04/13/2016 10:25 PM, Ilia Mirkin wrote: Reviewed-by: Ilia Mirkin If you wanted to play around with it to figure out which bit was which, I wouldn't object. I think someone pushed (or has sent) a more complete mem barrier test. Although such guessing can't be conclusive, so perhaps might as

[Mesa-dev] [PATCH] mesa/st: add nir pass for lowering builtin uniforms

2016-04-14 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/mesa/Makefile.sources | 2 + src/mesa/state_tracker/st_nir.h | 31 src/mesa/state_tracker/st_nir_lower_builtin.c | 245 ++ 3 files changed, 278 insertions(+) create mode 100644 sr

Re: [Mesa-dev] [RFC 05/24] nvc0: compute correct image dimensions based on the target

2016-04-14 Thread Samuel Pitoiset
On 04/13/2016 10:23 PM, Ilia Mirkin wrote: On Tue, Apr 12, 2016 at 7:56 PM, Samuel Pitoiset wrote: Loosely based on softpipe but with some changes, this computes correct width, height and depth of different targets to help in processing coordinates from the codegen part. This fixes a ton of

Re: [Mesa-dev] [RFC 04/24] nvc0: bind images on 3D shaders for Kepler

2016-04-14 Thread Samuel Pitoiset
On 04/14/2016 08:03 PM, Pierre Moreau wrote: On 01:56 AM - Apr 13 2016, Samuel Pitoiset wrote: Similar to surfaces validation for compute shaders. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 4 +++- src/gallium/drivers/nouveau/nvc0/nvc0_tex.c

Re: [Mesa-dev] [RFC 01/24] nvc0: add preliminary support for images

2016-04-14 Thread Ilia Mirkin
On Thu, Apr 14, 2016 at 5:58 PM, Samuel Pitoiset wrote: >> >>> + for (i = 0; i < NVC0_MAX_IMAGES; ++i) { >> >> >> Any reason not to intend this second for loop? > > > Presumably you meant indent? The answer is no because it's the coding style > in that function. I wouldn't be against fixing

Re: [Mesa-dev] [RFC 04/24] nvc0: bind images on 3D shaders for Kepler

2016-04-14 Thread Samuel Pitoiset
On 04/13/2016 10:14 PM, Ilia Mirkin wrote: On Tue, Apr 12, 2016 at 7:56 PM, Samuel Pitoiset wrote: Similar to surfaces validation for compute shaders. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 4 +++- src/gallium/drivers/nouveau/nvc0/nvc0_tex.c

Re: [Mesa-dev] [RFC 01/24] nvc0: add preliminary support for images

2016-04-14 Thread Samuel Pitoiset
On 04/14/2016 07:48 PM, Pierre Moreau wrote: On 01:56 AM - Apr 13 2016, Samuel Pitoiset wrote: This implements set_shader_images() and resource invalidation for images. As OpenGL requires at least 8 images, we are going to expose this minimum value even if this might be raised for Kepler, but

Re: [Mesa-dev] [RFC 03/24] nvc0: bind images on compute shaders for Kepler

2016-04-14 Thread Samuel Pitoiset
On 04/13/2016 10:11 PM, Ilia Mirkin wrote: On Wed, Apr 13, 2016 at 11:26 AM, Samuel Pitoiset wrote: On 04/13/2016 03:38 AM, Ilia Mirkin wrote: On Tue, Apr 12, 2016 at 7:56 PM, Samuel Pitoiset wrote: Old surfaces validation code will be removed once images are completely done for Fermi/

Re: [Mesa-dev] [PATCH] radeonsi: set SLC for atomics and coherent ops on APUs

2016-04-14 Thread Nicolai Hähnle
On 14.04.2016 10:36, Nicolai Hähnle wrote: From: Nicolai Hähnle --- Hi Michel, perhaps we have to set the SLC (system level coherent) bit for images and buffers that may be accessed via GTT. Could you give this patch a try? This change may or may not be needed, but it is insufficient for fix

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler view leak in st_DrawAtlasBitmaps()

2016-04-14 Thread Roland Scheidegger
Am 14.04.2016 um 23:12 schrieb Brian Paul: > I neglected to free the sampler view which was created earlier in the > function. So for each glCallLists() command that used the bitmap atlas > to draw text, we'd leak a smpler view object. > > Also, check for st_create_texture_sampler_view() failure

Re: [Mesa-dev] [PATCH v2 00/15] i965: Rework uniform handling in the back-end

2016-04-14 Thread Kenneth Graunke
On Tuesday, March 22, 2016 3:33:35 PM PDT Jason Ekstrand wrote: > This is mostly a re-send of a patch series I've had floating around in one > form or a while for quite some time. It's basically the same except that > the original version was missing a work-around for Sandy Bridge. For a > while,

Re: [Mesa-dev] [PATCH 07/11] swr: [rasterizer] Interpolation utility functions

2016-04-14 Thread Roland Scheidegger
Am 14.04.2016 um 21:53 schrieb Tim Rowley: > --- > .../drivers/swr/rasterizer/common/simdintrin.h | 51 > -- > src/gallium/drivers/swr/rasterizer/core/frontend.h | 12 + > src/gallium/drivers/swr/rasterizer/core/state.h| 2 - > 3 files changed, 59 insertions(+), 6

Re: [Mesa-dev] [PATCH v2 04/15] i965/fs: Add support for MOV_INDIRECT on pre-Broadwell hardware

2016-04-14 Thread Jason Ekstrand
On Thu, Apr 14, 2016 at 2:32 PM, Kenneth Graunke wrote: > On Tuesday, March 22, 2016 3:33:39 PM PDT Jason Ekstrand wrote: > > While we're at it, we also add support for the possibility that the > > indirect is, in fact, a constant. This shouldn't happen in the common > case > > (if it does, that

Re: [Mesa-dev] [PATCH v2 05/15] nir: Add another index to load_uniform to specify the range read

2016-04-14 Thread Kenneth Graunke
On Tuesday, March 22, 2016 3:33:40 PM PDT Jason Ekstrand wrote: > --- > src/compiler/nir/nir.h| 7 +++ > src/compiler/nir/nir_intrinsics.h | 6 +- > src/compiler/nir/nir_lower_io.c | 5 + > src/compiler/nir/nir_print.c | 1 + > 4 files changed, 18 insertions(+), 1 de

Re: [Mesa-dev] [PATCH v2 04/15] i965/fs: Add support for MOV_INDIRECT on pre-Broadwell hardware

2016-04-14 Thread Kenneth Graunke
On Tuesday, March 22, 2016 3:33:39 PM PDT Jason Ekstrand wrote: > While we're at it, we also add support for the possibility that the > indirect is, in fact, a constant. This shouldn't happen in the common case > (if it does, that means NIR failed to constant-fold something), but it's > possible s

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler view leak in st_DrawAtlasBitmaps()

2016-04-14 Thread Charmaine Lee
Looks good to me. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, April 14, 2016 2:12 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; 11.1 11.2 Subject: [PATCH] st/mesa: fix sampler view leak in st_DrawAtlasBitmaps() I neglected to

Re: [Mesa-dev] [PATCH 2/2] i965/surface_formats: Update some formats for more recent gens

2016-04-14 Thread Jason Ekstrand
On Thu, Apr 14, 2016 at 2:08 PM, Kenneth Graunke wrote: > On Thursday, April 14, 2016 11:37:57 AM PDT Jason Ekstrand wrote: > > The surface format table hasn't entirely been kept up-to-date. This > commit > > marks a couple more compressed formats as sampleable on gen8+ and adds > the > > A4B4G4

Re: [Mesa-dev] [PATCH v2 1/2] configure: Add support for detecting valgrind headers

2016-04-14 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2 1/2] configure: Add support for detecting valgrind headers

2016-04-14 Thread Jason Ekstrand
We have several places where the Vulkan driver explicitly hooks into valgrind when it's available. We need to be able to detect it. Cc: Matt Turner --- configure.ac | 21 + 1 file changed, 21 insertions(+) diff --git a/configure.ac b/configure.ac index c426c72..3905922 1006

Re: [Mesa-dev] [PATCH] nir/lower_io: Add UBOs and SSBOs to get_io_offset_src

2016-04-14 Thread Kenneth Graunke
On Thursday, April 14, 2016 10:31:44 AM PDT Jason Ekstrand wrote: > --- > src/compiler/nir/nir_lower_io.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/compiler/nir/nir_lower_io.c b/src/compiler/nir/ nir_lower_io.c > index 8b660c1..238b86d 100644 > --- a/src/compiler/nir/nir_low

[Mesa-dev] [PATCH] st/mesa: fix sampler view leak in st_DrawAtlasBitmaps()

2016-04-14 Thread Brian Paul
I neglected to free the sampler view which was created earlier in the function. So for each glCallLists() command that used the bitmap atlas to draw text, we'd leak a smpler view object. Also, check for st_create_texture_sampler_view() failure and record GL_OUT_OF_MEMORY. Cc: "11.1 11.2" --- s

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Use UD type for offsets in VARYING_PULL_CONSTANT_LOAD

2016-04-14 Thread Kenneth Graunke
On Wednesday, April 13, 2016 2:16:19 PM PDT Jason Ekstrand wrote: > Reveiewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 5 +++-- > 2 files changed, 4 insertions(+), 3 deletions(-) These two are: Reviewed-by: Kennet

Re: [Mesa-dev] [PATCH 2/2] i965/surface_formats: Update some formats for more recent gens

2016-04-14 Thread Kenneth Graunke
On Thursday, April 14, 2016 11:37:57 AM PDT Jason Ekstrand wrote: > The surface format table hasn't entirely been kept up-to-date. This commit > marks a couple more compressed formats as sampleable on gen8+ and adds the > A4B4G4R4 format as renderable on gen9. > --- > src/mesa/drivers/dri/i965/br

Re: [Mesa-dev] [PATCH 2/2] configure: Add support for the Intel Vulkan driver

2016-04-14 Thread Kenneth Graunke
On Thursday, April 14, 2016 1:06:25 PM PDT Jason Ekstrand wrote: > This adds a --with-vulkan-drivers option with one driver, "intel". In the > future, we may add more drivers to this list. > --- > configure.ac | 66 > 1 file changed, 6

Re: [Mesa-dev] [PATCH 1/2] configure: Detect valgrind headers

2016-04-14 Thread Matt Turner
On Thu, Apr 14, 2016 at 1:06 PM, Jason Ekstrand wrote: > We have several places where the Vulkan driver explicitly hooks into > valgrind when it's available. We need to be able to detect it. > --- > configure.ac | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/configure.ac b/confi

[Mesa-dev] Mesa 11.2.1 release candidate

2016-04-14 Thread Emil Velikov
Hello list, The candidate for the Mesa 11.2.1 is now available. Currently we have: - 16 queued - 16 nominated (outstanding) - and 5 (self-)rejected patches The current queue fixes crashes in VAAPI and Nine, adds a drirc workaround for Warsow and resolves a few nouveau, radeonsi and i965 fixes.

Re: [Mesa-dev] [PATCH 01/13] nir/builder: add nir_imm_uint()

2016-04-14 Thread Jason Ekstrand
On Tue, Apr 12, 2016 at 1:05 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Connor Abbott > > --- > src/compiler/nir/nir_builder.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/compiler/nir/nir_builder.h > b/src/compiler/nir/nir_builder.h > index 29b13

Re: [Mesa-dev] [PATCH 12/13] nir: add pack_double_2x32_split_y opcode

2016-04-14 Thread Jason Ekstrand
On Thu, Apr 14, 2016 at 1:50 AM, Iago Toral wrote: > On Wed, 2016-04-13 at 08:29 -0700, Jason Ekstrand wrote: > > > > On Apr 13, 2016 7:57 AM, "Connor Abbott" wrote: > > > > > > On Wed, Apr 13, 2016 at 3:24 AM, Iago Toral > > wrote: > > > > On Tue, 2016-04-12 at 13:16 -0400, Connor Abbott wrote

Re: [Mesa-dev] [PATCH] glx: Refactor the configure options for glx implementation choice

2016-04-14 Thread Chuck Atkins
Thinking more about this, would it be better to implement as a single --enable-glx=dri|xlib|gallium-xlib option instead of three separate conflicting options? Most of the implementation would remain the same but it would certainly simplify the set of configure options a bit. - Chuck On Thu, Apr

[Mesa-dev] [PATCH 2/2] configure: Add support for the Intel Vulkan driver

2016-04-14 Thread Jason Ekstrand
This adds a --with-vulkan-drivers option with one driver, "intel". In the future, we may add more drivers to this list. --- configure.ac | 66 1 file changed, 66 insertions(+) diff --git a/configure.ac b/configure.ac index 40b08d3..3cf

[Mesa-dev] [PATCH 1/2] configure: Detect valgrind headers

2016-04-14 Thread Jason Ekstrand
We have several places where the Vulkan driver explicitly hooks into valgrind when it's available. We need to be able to detect it. --- configure.ac | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure.ac b/configure.ac index c426c72..40b08d3 100644 --- a/configure.ac +++ b/config

Re: [Mesa-dev] [PATCH] nvc0: do not break the universe on GK110+

2016-04-14 Thread Ilia Mirkin
Oops indeed. Reviewed-by: Ilia Mirkin On Thu, Apr 14, 2016 at 3:50 PM, Samuel Pitoiset wrote: > I removed that return 0 by mistake. Ooops. > > Fixes: 6e23fd4 ("nvc0: allow to use compute support on GM200") > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_screen.c

[Mesa-dev] [PATCH 03/11] swr: [rasterizer core] Fix thread binding for 32-bit windows

2016-04-14 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/threads.cpp | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/threads.cpp b/src/gallium/drivers/swr/rasterizer/core/threads.cpp index 4b7a207..21bff4e 100644 --- a/src/gallium/dr

[Mesa-dev] [PATCH 08/11] swr: [rasterizer scripts] Knob scripts tweaks

2016-04-14 Thread Tim Rowley
--- .../drivers/swr/rasterizer/scripts/knob_defs.py| 4 +++- .../rasterizer/scripts/templates/knobs.template| 25 +- 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/scripts/knob_defs.py b/src/gallium/drivers/swr/raste

[Mesa-dev] [PATCH 02/11] swr: [rasterizer fetch] Add support for fetching non-uniform component formats

2016-04-14 Thread Tim Rowley
For example, R10G10B10A2_UNORM. --- .../drivers/swr/rasterizer/jitter/fetch_jit.cpp| 190 - 1 file changed, 189 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp b/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp inde

[Mesa-dev] [PATCH 01/11] swr: [rasterizer core] Use CS spill/fill size in core

2016-04-14 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/api.cpp | 4 +++- src/gallium/drivers/swr/rasterizer/core/api.h | 6 -- src/gallium/drivers/swr/rasterizer/core/backend.cpp | 3 +-- src/gallium/drivers/swr/rasterizer/core/context.h | 1 + 4 files changed, 9 insertions(+), 5 deletions(-)

[Mesa-dev] [PATCH 11/11] swr: [rasterizer memory] Constify load tiles

2016-04-14 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/memory/LoadTile.cpp | 12 +++- src/gallium/drivers/swr/swr_memory.h | 2 +- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/memory/LoadTile.cpp b/src/gallium/drivers/swr/rasterizer/

[Mesa-dev] [PATCH 07/11] swr: [rasterizer] Interpolation utility functions

2016-04-14 Thread Tim Rowley
--- .../drivers/swr/rasterizer/common/simdintrin.h | 51 -- src/gallium/drivers/swr/rasterizer/core/frontend.h | 12 + src/gallium/drivers/swr/rasterizer/core/state.h| 2 - 3 files changed, 59 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/swr/rast

[Mesa-dev] [PATCH 05/11] swr: [rasterizer core] Arena: make most allocated blocks the same size

2016-04-14 Thread Tim Rowley
Reduces sorting cost --- src/gallium/drivers/swr/rasterizer/core/arena.h | 68 +++-- 1 file changed, 52 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/arena.h b/src/gallium/drivers/swr/rasterizer/core/arena.h index d0c0123..b80f6f0 100644

[Mesa-dev] [PATCH 10/11] swr: [rasterizer core] CompleteDrawContext changes for gcc

2016-04-14 Thread Tim Rowley
Add explicit inline and non-inline versions of CompleteDrawContext to make gcc happy. --- src/gallium/drivers/swr/rasterizer/core/threads.cpp | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/threads.cpp b/src/gallium/driv

[Mesa-dev] [PATCH 06/11] swr: [rasterizer core] TemplateArgUnroller

2016-04-14 Thread Tim Rowley
Switch boolean template arguments to typename template arguments of type std::integral_constant. This allows the template argument unroller to easily be extended to enums. --- src/gallium/drivers/swr/rasterizer/core/api.cpp| 41 +-- .../drivers/swr/rasterizer/core/frontend.cpp | 12

[Mesa-dev] [PATCH 04/11] swr: [rasterizer core] Fix global arena allocator bug

2016-04-14 Thread Tim Rowley
- Plus some minor code refactoring --- src/gallium/drivers/swr/rasterizer/core/arena.h| 88 -- .../drivers/swr/rasterizer/core/backend.cpp| 5 +- 2 files changed, 51 insertions(+), 42 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/arena.h b/src

[Mesa-dev] [PATCH 09/11] swr: [rasterizer] Small cleanups

2016-04-14 Thread Tim Rowley
--- .../drivers/swr/rasterizer/core/frontend.cpp | 3 ++- src/gallium/drivers/swr/rasterizer/core/frontend.h | 2 +- src/gallium/drivers/swr/rasterizer/core/utils.cpp | 31 +++--- src/gallium/drivers/swr/rasterizer/core/utils.h| 3 ++- .../drivers/swr/rasterizer/jitte

[Mesa-dev] [PATCH 00/11] update swr rasterizer

2016-04-14 Thread Tim Rowley
Another batch of updates to the swr rasterizer. No huge new features, but should fix at least one of the coverity flagged issues. Tim Rowley (11): swr: [rasterizer core] Use CS spill/fill size in core swr: [rasterizer fetch] Add support for fetching non-uniform component formats swr: [r

[Mesa-dev] [PATCH] nvc0: do not break the universe on GK110+

2016-04-14 Thread Samuel Pitoiset
I removed that return 0 by mistake. Ooops. Fixes: 6e23fd4 ("nvc0: allow to use compute support on GM200") Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/ga

[Mesa-dev] [PATCH] glx: Refactor the configure options for glx implementation choice

2016-04-14 Thread Chuck Atkins
Instead of cascading support for various different implementations of GLX, all three options are now mutually exclusive top level options: --enable-glx : Enable the DRI-based GLX --enable-xlib-glx: Enable the classic Xlib-based GLX --enable-gallium-xlib-glx: Enable the gallium

[Mesa-dev] [PATCH 0/2] more Android build fixes

2016-04-14 Thread Rob Herring
A couple more Android build fixes after rebasing to the current tip. Android master builds are still a bit broken because makefiles get processed by kati in a different order. To fix, we need to go thru and eliminate all the variables set by one lower level makefile and used by another one. Ro

[Mesa-dev] [PATCH 1/2] glsl: android: add back missing generated glcpp include path

2016-04-14 Thread Rob Herring
Commit 4db8f15a2576 ("glsl: move the android build scripts a level up") dropped a generated include path for glcpp. Add it back adjusting for the new location. Cc: Emil Velikov Signed-off-by: Rob Herring --- src/compiler/Android.glsl.gen.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/sr

[Mesa-dev] [PATCH 2/2] i965: add build rule for brw_nir_trig_workarounds.c on Android

2016-04-14 Thread Rob Herring
Commit bfd17c76c126 ("i965: Port INTEL_PRECISE_TRIG=1 to NIR.") added a generated file brw_nir_trig_workarounds.c which broke the Android build. Add the necessary makefiles to the Android build. Cc: Kenneth Graunke Cc: Emil Velikov Signed-off-by: Rob Herring --- src/mesa/drivers/dri/i965/Andro

[Mesa-dev] [PATCH v3] math: Import isinf and others to global namespace

2016-04-14 Thread Pierre Moreau
Starting from C++11, several math functions, like isinf, moved into the std namespace. Since cmath undefines those functions before redefining them inside the namespace, and glibc 2.23 defines the C variants as macros, the C variants in global namespace are not accessible any longer. v2: Move the

Re: [Mesa-dev] [PATCH v2 20/20] radeonsi: enable TGSI support cap for compute shaders

2016-04-14 Thread Nicolai Hähnle
Patches 7, 8, 12-14, 17 are Reviewed-by: Nicolai Hähnle On 13.04.2016 14:30, Bas Nieuwenhuizen wrote: v2: Use chip_class instead of family. Signed-off-by: Bas Nieuwenhuizen Reviewed-by: Nicolai Hähnle --- docs/GL3.txt | 4 ++-- docs/relnotes/11.3.0.html

[Mesa-dev] [PATCH 1/2] i965: Expose the surface format table

2016-04-14 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_surface_formats.c | 22 +++-- src/mesa/drivers/dri/i965/brw_surface_formats.h | 43 + 3 files changed, 48 insertions(+), 18 deletions(-) create mode 100644 src/mesa/drivers/dr

[Mesa-dev] [PATCH 2/2] i965/surface_formats: Update some formats for more recent gens

2016-04-14 Thread Jason Ekstrand
The surface format table hasn't entirely been kept up-to-date. This commit marks a couple more compressed formats as sampleable on gen8+ and adds the A4B4G4R4 format as renderable on gen9. --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 24 1 file changed, 12 insert

Re: [Mesa-dev] [PATCH v2 04/20] radeonsi: implement shared atomics

2016-04-14 Thread Nicolai Hähnle
Patches 2-4 are Reviewed-by: Nicolai Hähnle On 13.04.2016 14:29, Bas Nieuwenhuizen wrote: v2: - Use single region - Use get_memory_ptr Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_shader.c | 77 +++- 1 file changed, 76 insertions(+)

Re: [Mesa-dev] [PATCH 00/13] Use the constant engine in radeonsi

2016-04-14 Thread Nicolai Hähnle
On 13.04.2016 20:34, Bas Nieuwenhuizen wrote: This series implements updating descriptors using the constant engine. This should result in a 0%-3% improvement for CPU bound applications, as we only have to upload the change descriptors from the CPU. Thanks again for looking at this! There are

Re: [Mesa-dev] [PATCH 05/13] radeonsi: Create CE IB.

2016-04-14 Thread Nicolai Hähnle
On 13.04.2016 20:34, Bas Nieuwenhuizen wrote: Based on work by Marek Olšák. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeonsi/si_hw_context.c | 4 +++- src/gallium/dri

Re: [Mesa-dev] [RFC 04/24] nvc0: bind images on 3D shaders for Kepler

2016-04-14 Thread Pierre Moreau
On 01:56 AM - Apr 13 2016, Samuel Pitoiset wrote: > Similar to surfaces validation for compute shaders. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 4 +++- > src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 26 > - > 2 f

Re: [Mesa-dev] [PATCH 13/13] radeonsi: Use CE for all descriptors.

2016-04-14 Thread Nicolai Hähnle
On 13.04.2016 20:35, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_descriptors.c | 46 +-- 1 file changed, 36 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drive

Re: [Mesa-dev] [PATCH 12/13] gallium/util: Add u_bit_scan_consecutive_range64.

2016-04-14 Thread Nicolai Hähnle
On 13.04.2016 20:35, Bas Nieuwenhuizen wrote: For use by radeonsi. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/auxiliary/util/u_math.h | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/auxiliary/util/u_math.h b/src/gallium/auxiliary/util/u_math.h index b4ac0db..3a

Re: [Mesa-dev] [PATCH 08/13] radeonsi: Add CE synchronization.

2016-04-14 Thread Nicolai Hähnle
On 13.04.2016 20:34, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_pipe.h | 2 ++ src/gallium/drivers/radeonsi/si_state_draw.c | 24 2 files changed, 26 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si

Re: [Mesa-dev] [RFC 01/24] nvc0: add preliminary support for images

2016-04-14 Thread Pierre Moreau
On 01:56 AM - Apr 13 2016, Samuel Pitoiset wrote: > This implements set_shader_images() and resource invalidation for > images. As OpenGL requires at least 8 images, we are going to expose > this minimum value even if this might be raised for Kepler, but this > limit is mainly for Fermi because the

Re: [Mesa-dev] [PATCH 11/16] nir/lower-io: split out some helper fxns

2016-04-14 Thread Rob Clark
On Fri, Apr 1, 2016 at 1:57 PM, Jason Ekstrand wrote: > I don't know that I like the lower-io prefix. Maybe nir/io-to-temp? > Doesn't really matter > > On Sat, Mar 26, 2016 at 2:02 PM, Rob Clark wrote: >> >> From: Rob Clark >> >> Prep work to reduce the noise in the next patch. >> >> Signed-off

[Mesa-dev] [PATCH] nir/lower_io: Add UBOs and SSBOs to get_io_offset_src

2016-04-14 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_io.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/nir/nir_lower_io.c b/src/compiler/nir/nir_lower_io.c index 8b660c1..238b86d 100644 --- a/src/compiler/nir/nir_lower_io.c +++ b/src/compiler/nir/nir_lower_io.c @@ -426,10 +426,13 @@ nir_get_io_of

Re: [Mesa-dev] [PATCH] gallium/radeon: handle vertex shaders that disable clipping & viewport

2016-04-14 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 13.04.2016 10:37, Marek Olšák wrote: From: Marek Olšák This should fix Nine. --- src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeon/r600_viewport.c| 20 +++- 2 files changed, 20 insertions(+), 1 deletion(-)

[Mesa-dev] [Bug 94086] Multiple conflicting libGL libraries installed

2016-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94086 --- Comment #8 from Chuck Atkins --- (In reply to Emil Velikov from comment #6) > I'd rather not do that, as the current "enable foo when bar is on" feels > quite magic. Sometimes it gives you a warning although in all honestly, I > doubt (m)any

Re: [Mesa-dev] [PATCH v2] xlib: do not cache return value of glXChooseVisual/glXGetVisualFromFBConfig

2016-04-14 Thread Emil Velikov
On 14 April 2016 at 08:09, Alejandro Piñeiro wrote: > For next time, on the cases were minor changes are suggested, but a RB > is granted in any case, you don't need to send the patch again to the > list, you can made the changes locally and push directly without > re-submitting to the list. > > B

  1   2   >