[Mesa-dev] [PATCH] glsl: mark link_uniform_blocks_are_compatible() as static

Missed this when doing 6d1a59d15b. --- src/compiler/glsl/link_uniform_blocks.cpp | 2 +- src/compiler/glsl/linker.h| 4 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/compiler/glsl/link_uniform_blocks.cpp b/src/compiler/glsl/link_uniform_blocks.cpp index

Re: [Mesa-dev] [PATCH 4/4] i965: Fix remaining flush vs invalidate race conditions in brw_emit_pipe_control_flush.

On Fri, Jul 1, 2016 at 5:43 PM, Francisco Jerez wrote: > Jason Ekstrand writes: > > > 3 and 4 are > > > > Cc: "12.0 11.1 11.2" > > Hmm, I'll cc PATCH 2 to mesa-stable too since technically it also fixes > a bug.

Re: [Mesa-dev] [PATCH 2/4] anv/image: Simplify initialization of the isl_tiling

On Fri, Jul 1, 2016 at 6:13 PM, Nanley Chery wrote: > On Fri, Jul 01, 2016 at 02:24:19PM -0700, Chad Versace wrote: > > On Mon 27 Jun 2016, Nanley Chery wrote: > > > Signed-off-by: Nanley Chery > > > --- > > > src/intel/vulkan/anv_image.c | 10

Re: [Mesa-dev] [PATCHv5 2/4] anv: use cache uuid based on the build timestamp.

I think this patch finally looks good. I read the SOURCE_DATE_EPOCH spec and we seem to be following it correctly. Thanks for all your hard work (I know it's been a lot) on this! Reviewed-by: Jason Ekstrand On Fri, Jul 1, 2016 at 9:22 AM, Emil Velikov

Re: [Mesa-dev] [PATCH 2/4] anv/image: Simplify initialization of the isl_tiling

On Fri, Jul 01, 2016 at 02:24:19PM -0700, Chad Versace wrote: > On Mon 27 Jun 2016, Nanley Chery wrote: > > Signed-off-by: Nanley Chery > > --- > > src/intel/vulkan/anv_image.c | 10 -- > > 1 file changed, 4 insertions(+), 6 deletions(-) > > > > diff --git

Re: [Mesa-dev] [PATCH 4/4] i965: Fix remaining flush vs invalidate race conditions in brw_emit_pipe_control_flush.

Jason Ekstrand writes: > 3 and 4 are > > Cc: "12.0 11.1 11.2" Hmm, I'll cc PATCH 2 to mesa-stable too since technically it also fixes a bug. PATCH 1 shouldn't make much of a difference though. > Reviewed-by: Jason Ekstrand

Re: [Mesa-dev] [PATCH 4/4] i965: Fix remaining flush vs invalidate race conditions in brw_emit_pipe_control_flush.

3 and 4 are Cc: "12.0 11.1 11.2" Reviewed-by: Jason Ekstrand I did look over 3 fairly carefully. It's worth noting that I think we have some double-pipe-controls that could probably be put together now. Not sure that we actually want

[Mesa-dev] [PATCH] glsl: don't try to lower non-gl builtins as if they were gl_FragData

If a shader has an output array, it will get treated as though it were gl_FragData and rewritten into gl_out_FragData instances. We only want this to happen on the actual gl_FragData and not everything else. This is a small part of the problem pointed out by the below bug. Bugzilla:

[Mesa-dev] [PATCH v2 23/36] isl: Remove duplicate px->sa conversions

In all three cases, we start with width and height taken from isl_surf::phys_slice0_extent_sa which is already in samples. There is no need to do the conversion and doing so gives us an incorrect value. --- src/intel/isl/isl.c | 20 1 file changed, 20 deletions(-) diff

[Mesa-dev] [PATCH 23.5/36] isl: Take the slice0_extent shortcut for interleaved MSAA

The shortcut works just fine for MSAA and the comment even says so. --- src/intel/isl/isl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index be3adfc..6bdb248 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -575,7

Re: [Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

On Thu 30 Jun 2016, Stéphane Marchesin wrote: > On Thu, Jun 30, 2016 at 3:20 PM, Gurchetan Singh > wrote: > > There are a few places in the code where clearing and reading are done on > > incorrect buffers for GLES contexts. See comments for details. This > > fixes

Re: [Mesa-dev] [PATCH 1/7] glsl: Separate overlapping sentinel nodes in exec_list.

On 06/27/2016 02:42 PM, Matt Turner wrote: > I do appreciate the cleverness, but unfortunately it prevents a lot more > cleverness in the form of additional compiler optimizations brought on > by -fstrict-aliasing. > > No difference in OglBatch7 (n=20). > > Co-authored-by: Davin McCall

Re: [Mesa-dev] [PATCH 3/4] anv/blit2d: Copy with stencil sources when needed

seems fine to me On Fri, Jul 1, 2016 at 2:25 PM, Chad Versace wrote: > On Mon 27 Jun 2016, Nanley Chery wrote: > > In the next patch, ISL will unconditionally perform verification of a > > surface's tiling and usage. Since it will require that w-tiled images > > be

Re: [Mesa-dev] [PATCH 3/4] anv/blit2d: Copy with stencil sources when needed

On Mon 27 Jun 2016, Nanley Chery wrote: > In the next patch, ISL will unconditionally perform verification of a > surface's tiling and usage. Since it will require that w-tiled images > be stencil buffers, create a stencil surface to copy from a > w-tiled/stencil surface. > > Signed-off-by:

Re: [Mesa-dev] [PATCH 2/4] anv/image: Simplify initialization of the isl_tiling

On Mon 27 Jun 2016, Nanley Chery wrote: > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/anv_image.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c > index

Re: [Mesa-dev] [PATCH 4/4] Revert "isl: Don't filter tiling flags if a specific tiling bit is set"

On Mon 27 Jun 2016, Nanley Chery wrote: > This reverts commit 091f1da902c71ac8d3d27b325a118e2f683f1ae5. > > Although a user may specify a specfic tiling bit, ISL should still > prevent incompatible tiling/surface combinations. > > Signed-off-by: Nanley Chery > --- > >

Re: [Mesa-dev] [PATCH 1/4] isl: Fix isl_tiling_is_any_y()

On Mon 27 Jun 2016, Nanley Chery wrote: > Signed-off-by: Nanley Chery > --- > src/intel/isl/isl.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch 1 is Reviewed-by: Chad Versace ___

Re: [Mesa-dev] [PATCH 14/36] i965/blorp: Refactor interleaved multisample destination handling

On Thu, Jun 30, 2016 at 11:56 PM, Pohjolainen, Topi < topi.pohjolai...@intel.com> wrote: > On Wed, Jun 29, 2016 at 05:37:33PM -0700, Jason Ekstrand wrote: > > We put all of the code for fake IMS together. This requires moving a bit > > of the program key setup code further down so that it gets

Re: [Mesa-dev] [PATCH 15/36] i965/blorp: Move intratile offset calculations out of surface state setup

On Fri, Jul 1, 2016 at 12:24 AM, Pohjolainen, Topi < topi.pohjolai...@intel.com> wrote: > On Wed, Jun 29, 2016 at 05:37:34PM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/brw_blorp.c| 24 > > > src/mesa/drivers/dri/i965/brw_blorp.h|

[Mesa-dev] [Bug 96770] include/GL/mesa_glinterop.h:62: error: redefinition of typedef ‘GLXContext’

https://bugs.freedesktop.org/show_bug.cgi?id=96770 Bug ID: 96770 Summary: include/GL/mesa_glinterop.h:62: error: redefinition of typedef ‘GLXContext’ Product: Mesa Version: git Hardware: x86-64 (AMD64) OS:

Re: [Mesa-dev] i965/blorp: Use flat vertex inputs instead of uniforms

On Thu, Jun 23, 2016 at 12:16 PM, Topi Pohjolainen < topi.pohjolai...@intel.com> wrote: > In addition to the actual vertex coordinates blorp will get another > vertex input buffer providing the constants that are until now > provided as uniforms. This will remove the need to configure push >

Re: [Mesa-dev] [PATCH 14/18] i965/blorp: Remove support for push constants

Hooray! \o/ On Thu, Jun 23, 2016 at 12:17 PM, Topi Pohjolainen < topi.pohjolai...@intel.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 17 ++- > src/mesa/drivers/dri/i965/brw_blorp.h | 15 - >

Re: [Mesa-dev] [PATCH 13/18] i965/blorp: Use flat inputs instead of uniforms

On Thu, Jun 23, 2016 at 12:17 PM, Topi Pohjolainen < topi.pohjolai...@intel.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 43 > ++- > src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 9

Re: [Mesa-dev] [PATCH 06/18] i965/blorp: Share input slot between pixel kill and blend/scaled

On Thu, Jun 23, 2016 at 12:17 PM, Topi Pohjolainen < topi.pohjolai...@intel.com> wrote: > These are never used in parallel, lets document this. > > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_blorp.h | 47 --- >

Re: [Mesa-dev] [PATCH 06/18] i965/blorp: Share input slot between pixel kill and blend/scaled

Since we're using inputs_read and the packing from the fs compiler, is this really needed? It seems like we could just add two floats worth of padding after rect_grid_y1 to pad it to a vec4. On Thu, Jun 23, 2016 at 12:17 PM, Topi Pohjolainen < topi.pohjolai...@intel.com> wrote: > These are

Re: [Mesa-dev] [PATCH 02/18] i965: Unify vertex buffer setup

I don't know what I think about re-using the VB setup in blorp, but these two patches are a very nice cleanup in their own right. 1 and 2 are Reviewed-by: Jason Ekstrand On Thu, Jun 23, 2016 at 12:16 PM, Topi Pohjolainen < topi.pohjolai...@intel.com> wrote: > On gen >= 8

Re: [Mesa-dev] [PATCH 2/2] mesa: Add -fno-math-errno -fno-trapping-math to CXXFLAGS.

Reviewed-by: Marek Olšák Marek On Fri, Jul 1, 2016 at 12:59 AM, Matt Turner wrote: > Not sure why I forgot to add them to CXXFLAGS in commit f55c408067 or > commit 875458b778. Cuts about 1k of .text. > >text data bss dec hex

[Mesa-dev] [Bug 96765] BindFragDataLocationIndexed on array fragment shader output.

https://bugs.freedesktop.org/show_bug.cgi?id=96765 Bug ID: 96765 Summary: BindFragDataLocationIndexed on array fragment shader output. Product: Mesa Version: 11.2 Hardware: Other OS: Linux (All)

[Mesa-dev] [Bug 96765] BindFragDataLocationIndexed on array fragment shader output.

https://bugs.freedesktop.org/show_bug.cgi?id=96765 Corentin Wallez changed: What|Removed |Added CC|

[Mesa-dev] [PATCH] mesa/main: fix error checking logic on CopyImageSubData

For the case (both src or dst) where we had a texobject, but the texobject target was not the same that the method target, this spec paragraph was appplied: /* Section 18.3.2 (Copying Between Images) of the OpenGL 4.5 Core * Profile spec says: * * "An INVALID_VALUE error is generated

[Mesa-dev] [PATCHv5 2/4] anv: use cache uuid based on the build timestamp.

From: Emil Velikov Do not rely on the git sha1: - its current truncated form makes it less unique - it does not attribute for local (Vulkand or otherwise) changes Use a timestamp produced at the time of build. It's perfectly unique, unless someone explicitly

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Christian König wrote: Am 01.07.2016 um 18:02 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first version? I notice on

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Am 01.07.2016 um 18:02 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first version? I notice on Tonga that I previously got

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Christian König wrote: Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first version? I notice on Tonga that I previously got cabac, but don't now. I see the new options

[Mesa-dev] [Bug 96639] st/mesa: transfer_map with too-high level with dEQP-GLES2.functional.texture.completeness.cube.extra_level

https://bugs.freedesktop.org/show_bug.cgi?id=96639 Nicolai Hähnle changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [Bug 96639] st/mesa: transfer_map with too-high level with dEQP-GLES2.functional.texture.completeness.cube.extra_level

https://bugs.freedesktop.org/show_bug.cgi?id=96639 --- Comment #1 from Nicolai Hähnle --- Fixed in master commit 07cc838b105dd3f34526db73064f1f21b452240e. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 96629] dEQP-GLES2.functional.texture.completeness.cube.not_positive_level_0: Assertion `width >= 1' failed.

https://bugs.freedesktop.org/show_bug.cgi?id=96629 Nicolai Hähnle changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first version? I notice on Tonga that I previously got cabac, but don't now. I see the new options are now in

[Mesa-dev] [PATCH] swr: clean up c++ feature flag test to not deal with IFS

Cc: Tim Rowley Signed-off-by: Chuck Atkins --- configure.ac | 43 ++- 1 file changed, 18 insertions(+), 25 deletions(-) diff --git a/configure.ac b/configure.ac index 8321e8e..844e91c 100644 ---

Re: [Mesa-dev] [PATCH 16/36] i965/blorp: Add an isl_view to blorp_surface_info

On Jul 1, 2016 1:04 AM, "Pohjolainen, Topi" wrote: > > On Wed, Jun 29, 2016 at 05:37:35PM -0700, Jason Ekstrand wrote: > > Eventually, this will be the actual view that gets passed into isl to > > create the surface state. For now, we just use it for the format and

Re: [Mesa-dev] [PATCH 09/36] i965/blorp: Make sample count asserts a bit more lazy

On Jun 30, 2016 10:14 PM, "Pohjolainen, Topi" wrote: > > On Thu, Jun 30, 2016 at 06:57:39AM -0700, Jason Ekstrand wrote: > >On Jun 29, 2016 11:07 PM, "Pohjolainen, Topi" > ><[1]topi.pohjolai...@intel.com> wrote: > >> > >> On Wed, Jun 29, 2016 at

Re: [Mesa-dev] [PATCH v4] swr: Refactor checks for compiler feature flags

On 1 July 2016 at 16:03, Chuck Atkins wrote: >> This part should have been a separate patch. Please try to keep things >> separate for the future. > > > Indeed, I should have this as two separate commits, one to encapsulate the > flag test and another to add additional

Re: [Mesa-dev] [PATCH v4] swr: Refactor checks for compiler feature flags

> > This part should have been a separate patch. Please try to keep things > separate for the future. > Indeed, I should have this as two separate commits, one to encapsulate the flag test and another to add additional options to test for. I'll keep them more segmented in the future. > Esp

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first version? I notice on Tonga that I previously got cabac, but don't now. I see the new options are now in radeon_vce_52.c whereas before radeon_vce_40_2_2.c was

[Mesa-dev] [PATCH 07/14] gallium/radeon: add can_sample_z/s flags for textures

From: Nicolai Hähnle --- src/gallium/drivers/r600/r600_blit.c | 6 ++ src/gallium/drivers/r600/r600_pipe.h | 8 src/gallium/drivers/r600/r600_state.c | 14 +++--- src/gallium/drivers/radeon/r600_pipe_common.h | 9

[Mesa-dev] [PATCH 08/14] gallium/radeon: replace is_flushing_texture with db_compatible

From: Nicolai Hähnle This is a left-over of when I considered generalizing the separate stencil support. I do prefer the new name since it emphasizes what flushing vs. non-flushing means from a functional point-of-view, namely special handling of the texture format. ---

[Mesa-dev] [PATCH 09/14] radeonsi: sample from flushed depth texture when required

From: Nicolai Hähnle Note that this has no effect yet. A case where can_sample_z/s can be false in radeonsi will be added in a later patch. --- src/gallium/drivers/radeonsi/si_descriptors.c | 35 +-- src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] [PATCH 05/14] r600g: remove obsolete flushed texture initialization in color surface setup

From: Nicolai Hähnle Seems to have been unnecessary for quite some time, and seems like an odd place to do the initialization anyway. --- src/gallium/drivers/r600/r600_state.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/gallium/drivers/r600/r600_state.c

[Mesa-dev] [PATCH 02/14] gallium/radeon: print StencilLayout only once

From: Nicolai Hähnle It is the same for all levels. --- src/gallium/drivers/radeon/r600_texture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index

[Mesa-dev] [PATCH 10/14] radeonsi: extract DB->CB copy logic into its own function

From: Nicolai Hähnle Also clean up some of the looping. --- src/gallium/drivers/radeonsi/si_blit.c | 97 +- 1 file changed, 61 insertions(+), 36 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c

[Mesa-dev] [PATCH 03/14] gallium/radeon: remove redundant null-pointer check

From: Nicolai Hähnle --- src/gallium/drivers/radeon/r600_texture.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index 0a25dbe..b3920d7 100644 ---

[Mesa-dev] [PATCH 13/14] gallium/radeon: add depth/stencil_adjusted output to surface computation

From: Nicolai Hähnle This fixes a rare bug with stencil texturing -- seen on Polaris and Tonga, though it's basically a function of the memory configuration so could affect other parts as well. Fixes piglit "unaligned-blit * stencil downsample" and various

[Mesa-dev] [PATCH 04/14] gallium/radeon/winsyses: remove unused stencil_offset

From: Nicolai Hähnle --- src/gallium/drivers/radeon/radeon_winsys.h | 1 - src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 2 -- src/gallium/winsys/radeon/drm/radeon_drm_surface.c | 2 -- 3 files changed, 5 deletions(-) diff --git

[Mesa-dev] [PATCH 14/14] winsys/amdgpu: avoid flushed depth when possible

From: Nicolai Hähnle If a depth/stencil texture has no mipmaps, we can always get a layout that is compatible with DB and TC. --- src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 11/14] radeonsi: decompress to flushed depth texture when required

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_blit.c | 132 + 1 file changed, 103 insertions(+), 29 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index

[Mesa-dev] [PATCH 12/14] gallium/radeon: allocate only the required plane for flushed depth

From: Nicolai Hähnle --- src/gallium/drivers/radeon/r600_texture.c | 37 --- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index

[Mesa-dev] [PATCH 06/14] radeonsi: correctly mark levels of 3D textures as fully decompressed

From: Nicolai Hähnle Account for the fact that max_layer is minified for higher levels. --- src/gallium/drivers/radeonsi/si_blit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c

[Mesa-dev] [PATCH 00/14] gallium/radeon: flushed depth textures for radeonsi

Hi, this series is motivated by a rare stencil texturing bug. The bug is that a combined Z/S buffer (with separate stencil) must use the same pitch for both Z and S when accessed by the DB hardware block, but in some configurations, the S part wants a larger pitch because its alignment

[Mesa-dev] [PATCH 01/14] gallium/radeon: flush stdout after printing texture information

From: Nicolai Hähnle --- src/gallium/drivers/radeon/r600_texture.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index 68f1701..7651e87 100644 ---

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Kai changed: What|Removed |Added Depends on||96762 Referenced

[Mesa-dev] [PATCH] gallium/radeon: add and use radeon_info::max_alloc_size (v2)

From: Marek Olšák v2: - squashed the patches - use INT_MAX - clamp max_const_buffer_size - check the DRM version in radeon --- src/gallium/drivers/r600/r600_pipe.c | 4 ++-- src/gallium/drivers/radeon/r600_pipe_common.c | 11 +--

Re: [Mesa-dev] [RFC] Coding style scripts (Was Re: [PATCH 1/2] gallium: replace [0-9]*.f with [0-9]*.0f)

On 28 June 2016 at 04:00, Michel Dänzer wrote: > On 27.06.2016 19:52, Jose Fonseca wrote: >> >> BTW, I've been using http://editorconfig.org/ on several projects. It's >> widely supported by many editors including Emacs. >> Very nice suggestion Jose. Thanks ! >> There's even

Re: [Mesa-dev] [PATCH 0/6] RadeonSI & ddebug: Apitrace interactions and better debugging

Series is Reviewed-by: Bas Nieuwenhuizen On Fri, Jul 1, 2016 at 1:21 AM, Marek Olšák wrote: > Hi, > > This series adds apitrace call tracking into ddebug and radeonsi and > other improvements. > > It will improve our debugging and profiling

Re: [Mesa-dev] [PATCH 6/8] nv50/ir: optimize ADD3(d, 0x0, b, c) to ADD(d, b, c)

On 07/01/2016 06:19 AM, Ilia Mirkin wrote: On Thu, Jun 30, 2016 at 6:54 PM, Samuel Pitoiset wrote: On 07/01/2016 12:44 AM, Ilia Mirkin wrote: If moveSources doesn't move modifiers, we have a serious problem. However it looks like it does: void

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

On 07/01/2016 02:27 PM, Marek Olšák wrote: On Fri, Jul 1, 2016 at 1:45 PM, Vedran Miletić wrote: On 07/01/2016 11:11 AM, Marek Olšák wrote: On Fri, Jul 1, 2016 at 10:54 AM, Marek Olšák wrote: On Fri, Jul 1, 2016 at 2:52 AM, Vedran Miletić

Re: [Mesa-dev] [PATCH v4] swr: Refactor checks for compiler feature flags

Hi Chuck, On 28 June 2016 at 20:50, Chuck Atkins wrote: > Encapsulate the test for which flags are needed to get a compiler to > support certain features. Along with this, give various options to try > for AVX and AVX2 support. Ideally we want to use specific

Re: [Mesa-dev] [PATCH 08/12] st/va: add functions for VAAPI encode

Am 30.06.2016 um 20:30 schrieb Boyuan Zhang: Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/buffer.c | 6 + src/gallium/state_trackers/va/picture.c| 170 - src/gallium/state_trackers/va/va_private.h | 3 + 3 files

Re: [Mesa-dev] [PATCH 06/12] st/va: colorspace conversion when image is yv12 and surface is nv12

Am 30.06.2016 um 20:30 schrieb Boyuan Zhang: Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/image.c | 48 +-- 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/src/gallium/state_trackers/va/image.c

Re: [Mesa-dev] [PATCH 5/6] radeonsi: enable string markers and record apitrace call numbers

On Fri, Jul 1, 2016 at 2:24 PM, Marek Olšák wrote: > On Fri, Jul 1, 2016 at 2:16 PM, Bas Nieuwenhuizen > wrote: >> On Fri, Jul 1, 2016 at 1:21 AM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> --- >>>

Re: [Mesa-dev] [PATCH 05/12] st/va: add nv12 i420 yv12 format to deriveimage call

Am 30.06.2016 um 20:30 schrieb Boyuan Zhang: Signed-off-by: Boyuan Zhang That only works by coincident correctly, the buffer only contains a reference to the first texture plane and not all of them. So vlVaMapBuffer() won't be able to come up with something reasonable

Re: [Mesa-dev] [PATCH 04/12] st/va: use correct pitch value for deriveimage call

Am 30.06.2016 um 20:30 schrieb Boyuan Zhang: Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/image.c | 55 --- 1 file changed, 51 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/va/image.c

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

On Fri, Jul 1, 2016 at 1:45 PM, Vedran Miletić wrote: > On 07/01/2016 11:11 AM, Marek Olšák wrote: >> >> On Fri, Jul 1, 2016 at 10:54 AM, Marek Olšák wrote: >>> >>> On Fri, Jul 1, 2016 at 2:52 AM, Vedran Miletić >>> wrote: On

Re: [Mesa-dev] [PATCH 5/6] radeonsi: enable string markers and record apitrace call numbers

On Fri, Jul 1, 2016 at 2:16 PM, Bas Nieuwenhuizen wrote: > On Fri, Jul 1, 2016 at 1:21 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeonsi/si_debug.c | 4 >>

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Hi Boyuan, as Emil wrote as well try to add some commit messages to the set. For this patch something like the following should do it: Allow to specify more parameters in the encoding interface which where previously just hardcoded in the encoder. Additional to that we need to reorder the

Re: [Mesa-dev] [PATCH 5/6] radeonsi: enable string markers and record apitrace call numbers

On Fri, Jul 1, 2016 at 1:21 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_debug.c | 4 > src/gallium/drivers/radeonsi/si_pipe.c | 20 +++- > src/gallium/drivers/radeonsi/si_pipe.h | 1 + > 3

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

On Fri, 2016-07-01 at 13:45 +0200, Vedran Miletić wrote: > On 07/01/2016 11:11 AM, Marek Olšák wrote: > > > > On Fri, Jul 1, 2016 at 10:54 AM, Marek Olšák > > wrote: > > > > > > On Fri, Jul 1, 2016 at 2:52 AM, Vedran Miletić > > t> wrote: > > > > > > > >

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for amdgpu

Am 01.07.2016 um 13:14 schrieb Emil Velikov: Hi all, On 29 June 2016 at 20:20, Christian König wrote: Am 29.06.2016 um 18:35 schrieb Alex Deucher: On Wed, Jun 29, 2016 at 11:38 AM, Leo Liu wrote: From: sonjiang Signed-off-by:

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

On 07/01/2016 11:11 AM, Marek Olšák wrote: On Fri, Jul 1, 2016 at 10:54 AM, Marek Olšák wrote: On Fri, Jul 1, 2016 at 2:52 AM, Vedran Miletić wrote: On 07/01/2016 01:29 AM, Marek Olšák wrote: From: Marek Olšák also fix

Re: [Mesa-dev] [PATCH 1/2] gallium/radeon: add radeon_info::max_alloc_size into the winsys interface

On 07/01/2016 10:54 AM, Michel Dänzer wrote: On 01.07.2016 08:29, Marek Olšák wrote: diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c b/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c index c4d28ff..76a125c 100644 --- a/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c +++

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Hi Boyuan, I believe Christian already mentioned this - here (and other patches really) you want to mention "why we want this". Something like "VAAPI does not allow for XX and YY. And requires the driver to explicitly manage/provide ZZ" will be more than enough imho. In general I would suggest

Re: [Mesa-dev] [PATCH] mesa: make attribute binding message more useful

On Fri, 2016-07-01 at 14:00 +1000, Timothy Arceri wrote: > --- > src/mesa/main/shader_query.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp > index b5e1a44..a2a93b1 100644 > ---

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for amdgpu

Hi all, On 29 June 2016 at 20:20, Christian König wrote: > Am 29.06.2016 um 18:35 schrieb Alex Deucher: >> >> On Wed, Jun 29, 2016 at 11:38 AM, Leo Liu wrote: >>> >>> From: sonjiang >>> >>> Signed-off-by: sonjiang

Re: [Mesa-dev] Add gperf as a build dependency?

On 30 June 2016 at 19:50, Jose Fonseca wrote: > On 30/06/16 18:13, Ian Romanick wrote: >> >> I think I might want to use gperf for something in Mesa, but I'm not >> 100% sure yet. Before I proceed, is it even acceptable to add that as a >> build dependency? > > > > I presume

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

On Fri, Jul 1, 2016 at 10:54 AM, Marek Olšák wrote: > On Fri, Jul 1, 2016 at 2:52 AM, Vedran Miletić wrote: >> On 07/01/2016 01:29 AM, Marek Olšák wrote: >>> >>> From: Marek Olšák >>> >>> also fix max_global_size to take a maximum of

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

On Fri, Jul 1, 2016 at 2:52 AM, Vedran Miletić wrote: > On 07/01/2016 01:29 AM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> also fix max_global_size to take a maximum of {vram_size, gart_size} >> --- >> src/gallium/drivers/r600/r600_pipe.c

Re: [Mesa-dev] [PATCH 1/2] gallium/radeon: add radeon_info::max_alloc_size into the winsys interface

On 01.07.2016 08:29, Marek Olšák wrote: > > diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c > b/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c > index c4d28ff..76a125c 100644 > --- a/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c > +++

Re: [Mesa-dev] [PATCH 16/36] i965/blorp: Add an isl_view to blorp_surface_info

On Wed, Jun 29, 2016 at 05:37:35PM -0700, Jason Ekstrand wrote: > Eventually, this will be the actual view that gets passed into isl to > create the surface state. For now, we just use it for the format and the > swizzle. > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 38 >

Re: [Mesa-dev] [PATCH 15/36] i965/blorp: Move intratile offset calculations out of surface state setup

On Wed, Jun 29, 2016 at 05:37:34PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp.c| 24 > src/mesa/drivers/dri/i965/brw_blorp.h| 15 ++- > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 8 > 3 files changed,

[Mesa-dev] [Bug 96235] st_nir.h:34: error: redefinition of typedef ‘nir_shader’

https://bugs.freedesktop.org/show_bug.cgi?id=96235 Vinson Lee changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH 14/36] i965/blorp: Refactor interleaved multisample destination handling

On Fri, Jul 01, 2016 at 09:56:10AM +0300, Pohjolainen, Topi wrote: > On Wed, Jun 29, 2016 at 05:37:33PM -0700, Jason Ekstrand wrote: > > We put all of the code for fake IMS together. This requires moving a bit > > of the program key setup code further down so that it gets the right values > > out

Re: [Mesa-dev] [PATCH 2/4] i965: Emit SKL VF cache invalidation W/A from brw_emit_pipe_control_flush.

Looks good to me: Reviewed-by: Alejandro Piñeiro Note: I think that patches 3-4 should be reviewed by a more seasoned developer (specially patch 3). On 01/07/16 07:07, Francisco Jerez wrote: > There were two places in the driver doing a pipe control VF cache > flush, one

Re: [Mesa-dev] [PATCH 14/36] i965/blorp: Refactor interleaved multisample destination handling

On Wed, Jun 29, 2016 at 05:37:33PM -0700, Jason Ekstrand wrote: > We put all of the code for fake IMS together. This requires moving a bit > of the program key setup code further down so that it gets the right values > out of the final surface. > --- >

Re: [Mesa-dev] [PATCH 1/4] i965: Emit SNB write cache flush W/A from brw_emit_pipe_control_flush.

Looks good to me: Reviewed-by: Alejandro Piñeiro On 01/07/16 07:07, Francisco Jerez wrote: > Shouldn't cause any functional changes at this point, but we have > forgotten to apply this workaround several times in the past, make > sure it doesn't happen again. > --- >

Re: [Mesa-dev] [PATCH 13/36] i965/blorp: Get rid of brw_blorp_surface_info::array_layout

On Wed, Jun 29, 2016 at 05:37:32PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 1 - > src/mesa/drivers/dri/i965/brw_blorp.h | 9 - > 2 files changed, 10 deletions(-) I found only one piece of blorp even considering the layout, and that reads it from the

Re: [Mesa-dev] [PATCH 11/36] i965/blorp: Use the ISL aux_layout for deciding whether to do an MCS fetch

On Wed, Jun 29, 2016 at 05:37:30PM -0700, Jason Ekstrand wrote: > AUX USAGE Commit message looks a little incomplete. Otherwise patches 10-12 are Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_blorp.h| 2 ++ >

Re: [Mesa-dev] [PATCH v2] docs: update MESA_DEBUG envvar documentation.

On 30/06/16 15:28, Brian Paul wrote: > On 06/29/2016 09:50 AM, Alejandro Piñeiro wrote: >> silent, flush, incomplete_tex and incomplete_fbo flags were not >> documented (see src/mesa/main.debug.c for more info). >> >> FP is not checked anymore. >> >> v2 (Brian Paul): >> * MESA_DEBUG accepts a

Re: [Mesa-dev] [PATCH v3] i965: intel_texture_barrier reimplemented

On 30/06/16 23:16, Francisco Jerez wrote: > Alejandro Piñeiro writes: > >> Fixes: >> GL44-CTS.texture_barrier_ARB.same-texel-rw-multipass >> >> On Haswell, Broadwell and Skylake (note that in order to execute that >> test, it is needed to override GL and GLSL versions). >>