[Mesa-dev] [Bug 96949] [regression] Piglit numSamples assertion failures with 9a23a177b90

2016-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96949 Kenneth Graunke changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH] mesa: handle numSamples=0 in _mesa_test_proxy_teximage()

2016-07-15 Thread Kenneth Graunke
On Friday, July 15, 2016 9:22:53 PM PDT Brian Paul wrote: > Should fix the regressions reported in bug 96949. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96949 > --- > src/mesa/main/teximage.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git

[Mesa-dev] [PATCH] mesa: handle numSamples=0 in _mesa_test_proxy_teximage()

2016-07-15 Thread Brian Paul
Should fix the regressions reported in bug 96949. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96949 --- src/mesa/main/teximage.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 10232d6..d74a45f 100644 ---

[Mesa-dev] [Bug 96949] [regression] Piglit numSamples assertion failures with 9a23a177b90

2016-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96949 --- Comment #2 from Brian Paul --- OK, I think the fix is simple. I posted a patch to mesa-dev. If it checks out for you, feel free to push it to master. -- You are receiving this mail because: You are the QA Contact for

[Mesa-dev] [Bug 96953] dri2_wl_swrast crashes on 64 bit, but not on 32 bit

2016-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96953 --- Comment #1 from n3rdopolis --- I can add that this is swrast and wayland, as when I try using qtwayland's x11 backend it works, and when I try 64 bit on Intel with qtwayland it works -- You are receiving

[Mesa-dev] [Bug 96953] dri2_wl_swrast crashes on 64 bit, but not on 32 bit

2016-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96953 Bug ID: 96953 Summary: dri2_wl_swrast crashes on 64 bit, but not on 32 bit Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity:

Re: [Mesa-dev] mesa from git fails to compile

2016-07-15 Thread Dylan Baker
Sorry to not respond earlier, I've apparently been having silent filesystem corruption for over a week now. Can you use pip --user to install a newer version of mako locally? mako 0.5 was realeased in late 2011, and not having the output_encoding and future_imports arguments are going to make

Re: [Mesa-dev] Required Mako version? (WAS: mesa from git fails to compile)

2016-07-15 Thread Jason Ekstrand
Adding Dylan On Jul 14, 2016 10:24 PM, "Samuel Iglesias Gonsálvez" wrote: > > > On 14/07/16 18:34, Eric Engestrom wrote: > > On Thu, Jul 14, 2016 at 04:01:13PM +0100, Eric Engestrom wrote: > >> Oh right, there's already check for the Mako version, but the minimum is > >>

Re: [Mesa-dev] [PATCH 3/3] i915: store reference to the context within struct intel_fence

2016-07-15 Thread Mauro Rossi
Hi, I'm sending the v2 re-spin of patch as per i965, rechecked twice line-by-line with Tomasz's one. Building ok, marshmallow-x86 booting ok and here are the results of Android CTS egl and gles2 x86 target tests Android CTS 6.0_r7 build:2906653 07-16 00:52:42 I/DeviceManager: Detected new

[Mesa-dev] [Bug 96949] [regression] Piglit numSamples assertion failures with 9a23a177b90

2016-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96949 Nanley Chery changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-15 Thread Andy Furniss
Zhang, Boyuan wrote: Hi Andy, The memory issue is fixed. Please try the new patch set I just submitted. Should NOT have hard lock anymore. Seems good, no leak and no lock :-) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

2016-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96950 --- Comment #2 from Brian Paul --- (In reply to Rob Clark from comment #1) > Do you still see the issue after 64d35f81 "vbo: fix attr reset"? Yes. -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

2016-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96950 --- Comment #1 from Rob Clark --- Do you still see the issue after 64d35f81 "vbo: fix attr reset"? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

2016-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96950 Rob Clark changed: What|Removed |Added CC|

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

2016-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96950 Brian Paul changed: What|Removed |Added CC||mathias.froehl...@web.de

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

2016-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96950 Bug ID: 96950 Summary: Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*. Product: Mesa Version: unspecified Hardware: Other

[Mesa-dev] [Bug 96949] [regression] Piglit numSamples assertion failures with 9a23a177b90

2016-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96949 --- Comment #1 from Brian Paul --- I'd appreciate it if you could debug this a bit further. I didn't see any of those regressions here. I'm on vacation for the next week so I won't be able to do anything. Feel free to

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Multithreaded shader compilation

2016-07-15 Thread Marek Olšák
On Wed, Jul 13, 2016 at 10:50 AM, Vedran Miletić wrote: > On 07/13/2016 05:19 AM, Timothy Arceri wrote: >> >> So I finally got around to setting up my new polaris card on fedora. I >> was curious to see how Talos performed compared to i965 as I was pretty >> sure the

Re: [Mesa-dev] [PATCH v4 19/34] i965/state: Add a helper for emitting a surface state using isl

2016-07-15 Thread Jason Ekstrand
On Fri, Jul 15, 2016 at 2:30 PM, Chad Versace wrote: > On Thu 14 Jul 2016, Chad Versace wrote: > > On Wed 13 Jul 2016, Jason Ekstrand wrote: > > > Reviewed-by: Topi Pohjolainen > > > --- > > > src/mesa/drivers/dri/i965/brw_state.h

[Mesa-dev] [Bug 96949] [regression] Piglit numSamples assertion failures with 9a23a177b90

2016-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96949 Bug ID: 96949 Summary: [regression] Piglit numSamples assertion failures with 9a23a177b90 Product: Mesa Version: git Hardware: Other OS: All

[Mesa-dev] [PATCH 1/2] nir: Add a nir_deref_foreach_leaf helper

2016-07-15 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" Cc: Connor Abbott --- src/compiler/nir/nir.c | 107 +++ src/compiler/nir/nir.h | 4 ++

[Mesa-dev] [PATCH 2/2] nir/inline: Constant-initialize local variables in the callee if needed

2016-07-15 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" Cc: Connor Abbott --- src/compiler/nir/nir_inline_functions.c | 41 +++-- 1 file changed, 39 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-15 Thread Zhang, Boyuan
Hi Andy, The memory issue is fixed. Please try the new patch set I just submitted. Should NOT have hard lock anymore. And thanks for providing the rate control info, I will do some test about it. Regards, Boyuan -Original Message- From: Andy Furniss [mailto:adf.li...@gmail.com] Sent:

[Mesa-dev] [PATCH 10/11] st/va: add preset values for VAAPI encode

2016-07-15 Thread Boyuan Zhang
Add some hardcoded values hardware needs mainly for rate control purpose. With previously hardcoded values for OMX, the rate control result is not correct. This change fixed the rate control result by setting correct values for Vaapi. Signed-off-by: Boyuan Zhang ---

[Mesa-dev] [PATCH 08/11] st/va: get rate control method from configattrib

2016-07-15 Thread Boyuan Zhang
Rate control method is passed from app to driver through config attrib list. That is why we need to store this rate control method to config. And later on, we will pass this value to context->desc.h264enc.rate_ctrl.rate_ctrl_method. Signed-off-by: Boyuan Zhang ---

[Mesa-dev] [PATCH 11/11] st/va: enable h264 VAAPI encode

2016-07-15 Thread Boyuan Zhang
Enable H.264 VAAPI encoding through config. Currently only H.264 baseline is supported. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/config.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH 09/11] st/va: add functions for VAAPI encode

2016-07-15 Thread Boyuan Zhang
Add necessary functions/changes for VAAPI encoding to buffer and picture. These changes will allow driver to handle all Vaapi encode related operations. This patch doesn't change the Vaapi decode behaviour. Signed-off-by: Boyuan Zhang ---

[Mesa-dev] [PATCH 06/11] vl/util: add copy func for yv12image to nv12surface

2016-07-15 Thread Boyuan Zhang
Add function to copy from yv12 image to nv12 surface for VAAPI putimage call. We need this function in VaPutImage call where copying from yv12 image to nv12 surface for encoding. Existing function can't be used because it only work for copying from yv12 surface to nv12 image in Vaapi.

[Mesa-dev] [PATCH 05/11] st/va: add encode entrypoint

2016-07-15 Thread Boyuan Zhang
VAAPI passes PIPE_VIDEO_ENTRYPOINT_ENCODE as entry point for encoding case. We will save this encode entry point in config. config_id was used as profile previously. Now, config has both profile and entrypoint field, and config_id is used to get the config object. Later on, we pass this

[Mesa-dev] [PATCH 07/11] st/va: add conversion for yv12 to nv12in putimage

2016-07-15 Thread Boyuan Zhang
For putimage call, if image format is yv12 (or IYUV with U V field swap) and surface format is nv12, then we need to convert yv12 to nv12 and then copy the converted data from image to surface. We can't use the existing logic where surface is destroyed and re-created with yv12 format.

[Mesa-dev] [PATCH 02/11] vl: add entry point

2016-07-15 Thread Boyuan Zhang
Add entrypoint to distinguish H.264 decode and encode. For example, in patch 5/11 when is calling "VaCreateContext", "pps" and "sps" shouldn't be allocated for H.264 encoding. So we need to use the entry_point to determine this is H.264 decode or H.264 encode. We can use config to determine the

Re: [Mesa-dev] [PATCH] gallium/sw/kms: Fix multiple imports from PRIME FDs

2016-07-15 Thread Emil Velikov
On 15 July 2016 at 08:27, Tomasz Figa wrote: > When a buffer with a GEM handle already existing in our context is > (re-)imported from a PRIME FD, the resulting GEM handle is exactly the > same as the original one. Since the GEM handles are not reference > counted, we need to

Re: [Mesa-dev] [PATCH v4 24/34] i965/gen8: Use the generic ISL-based path for texture surfaces

2016-07-15 Thread Chad Versace
On Wed 13 Jul 2016, Jason Ekstrand wrote: > Reviewed-by: Topi Pohjolainen > --- Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH v4 19/34] i965/state: Add a helper for emitting a surface state using isl

2016-07-15 Thread Chad Versace
On Thu 14 Jul 2016, Chad Versace wrote: > On Wed 13 Jul 2016, Jason Ekstrand wrote: > > Reviewed-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/brw_state.h| 8 +++ > > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 79 > >

Re: [Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

2016-07-15 Thread Francisco Jerez
Alejandro Piñeiro writes: > On 14/07/16 21:24, Francisco Jerez wrote: >> Alejandro Piñeiro writes: >> >>> Without this commit, a image is considered valid if the level of the >>> texture bound to the image is complete, something we can check as mesa

Re: [Mesa-dev] [PATCH] st/nine: add missing copyright headers

2016-07-15 Thread Axel Davy
Some copyrights are not correct, please look at the log of https://github.com/chrisbmr/Mesa-3D/tree/gallium-nine/src/gallium/state_trackers/nine to find out. Axel On 14/07/2016 20:17, Vedran Miletić wrote : Few files were missing the copyright headers. This patch adds correct copyright

Re: [Mesa-dev] [PATCH 4/4] mesa: handle numLevels, numSamples in _mesa_test_proxy_teximage()

2016-07-15 Thread Anuj Phogat
On Fri, Jul 15, 2016 at 12:34 PM, Brian Paul wrote: > On 07/15/2016 01:19 PM, Anuj Phogat wrote: >> >> On Fri, Jul 15, 2016 at 10:14 AM, Brian Paul wrote: >>> >>> If numSamples > 0, we can compute the size of the whole mipmapped >>> texture. >>> That's the

Re: [Mesa-dev] [PATCH 05/10] egl/android: Respect buffer mask in droid_image_get_buffers

2016-07-15 Thread Emil Velikov
On 15 July 2016 at 08:53, Tomasz Figa wrote: > Drivers can request different set of buffers depending on the buffer > mask they pass to the get_buffers callback. This patch makes > droid_image_get_buffers() respect this mask. > > Signed-off-by: Tomasz Figa

Re: [Mesa-dev] [Mesa-stable] i915: Enable EGL_KHR_{fence, wait}_sync

2016-07-15 Thread Mauro Rossi
2016-07-15 21:18 GMT+02:00 Emil Velikov : > Hi Mauro, > > On 14 July 2016 at 04:33, Mauro Rossi wrote: > > Sending patches to implement DRI2_Fence extension for i915, > > to enable EGL_KHR_fence_sync and EGL_KHR_wait_sync. > > > > It is the

Re: [Mesa-dev] [PATCH 4/4] mesa: handle numLevels, numSamples in _mesa_test_proxy_teximage()

2016-07-15 Thread Brian Paul
On 07/15/2016 01:19 PM, Anuj Phogat wrote: On Fri, Jul 15, 2016 at 10:14 AM, Brian Paul wrote: If numSamples > 0, we can compute the size of the whole mipmapped texture. That's the case for glTexStorage(GL_PROXY_TEXTURE_x). Also, multiply the texture size by numSamples for

Re: [Mesa-dev] [PATCH 01/10] egl/android: Set EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT

2016-07-15 Thread Emil Velikov
On 15 July 2016 at 18:57, Tomasz Figa wrote: > [Adding Haixia to the thread.] > > On Sat, Jul 16, 2016 at 2:52 AM, Eric Anholt wrote: >> Tomasz Figa writes: >> >>> From: Haixia Shi >>> >>> Set config attributes

Re: [Mesa-dev] [PATCH 4/4] mesa: handle numLevels, numSamples in _mesa_test_proxy_teximage()

2016-07-15 Thread Anuj Phogat
On Fri, Jul 15, 2016 at 10:14 AM, Brian Paul wrote: > If numSamples > 0, we can compute the size of the whole mipmapped texture. > That's the case for glTexStorage(GL_PROXY_TEXTURE_x). > > Also, multiply the texture size by numSamples for MSAA textures. > --- >

Re: [Mesa-dev] [Mesa-stable] i915: Enable EGL_KHR_{fence, wait}_sync

2016-07-15 Thread Emil Velikov
Hi Mauro, On 14 July 2016 at 04:33, Mauro Rossi wrote: > Sending patches to implement DRI2_Fence extension for i915, > to enable EGL_KHR_fence_sync and EGL_KHR_wait_sync. > > It is the step-by-step porting to i915 of i965/sync, > plus patch to support

Re: [Mesa-dev] [PATCH v4 18/34] i965/blorp: Use the generic ISL path for texture surfaces on gen6

2016-07-15 Thread Chad Versace
On Wed 13 Jul 2016, Jason Ekstrand wrote: > Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/gen6_blorp.c | 76 > +- > 1 file changed, 2 insertions(+), 74 deletions(-) Patches 14-18 are Reviewed-by: Chad Versace

Re: [Mesa-dev] [PATCH v4 13/34] i965/blorp: Add a generic ISL-based surface state emit path

2016-07-15 Thread Chad Versace
On Thu 14 Jul 2016, Jason Ekstrand wrote: > On Thu, Jul 14, 2016 at 2:26 PM, Chad Versace > wrote: > > > On Wed 13 Jul 2016, Jason Ekstrand wrote: > > > Reviewed-by: Topi Pohjolainen > > > --- > > > src/mesa/drivers/dri/i965/brw_blorp.c | 157

Re: [Mesa-dev] [PATCH v4 34/34] i965/context: Remove some unnecessary vfuncs

2016-07-15 Thread Chad Versace
On Wed 13 Jul 2016, Jason Ekstrand wrote: > Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_context.h | 17 - > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 3 +-- >

Re: [Mesa-dev] [PATCH v4 33/34] i965: Get rid of gen6_surface_state.c

2016-07-15 Thread Chad Versace
On Wed 13 Jul 2016, Jason Ekstrand wrote: > The only useful thing left was gen6_init_vtable_surface_functions which we > can easily put in brw_wm_surface_state.c. > > Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/Makefile.sources | 1 - >

Re: [Mesa-dev] [PATCH v4 25/34] i965/gen8: Use the generic ISL-based path for renderbuffer surfaces

2016-07-15 Thread Chad Versace
On Wed 13 Jul 2016, Jason Ekstrand wrote: > Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_state.h | 16 -- > src/mesa/drivers/dri/i965/gen8_surface_state.c | 249 > + > 2 files changed, 2 insertions(+), 263

Re: [Mesa-dev] [PATCH v4 29/34] i965/gen4-6: Use the generic ISL-based path for texture surfaces

2016-07-15 Thread Chad Versace
On Wed 13 Jul 2016, Jason Ekstrand wrote: > Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 94 > +--- > 1 file changed, 1 insertion(+), 93 deletions(-) Patches 28 and 29 are Reviewed-by: Chad Versace

Re: [Mesa-dev] [PATCH v4 31/34] i965/state: Account for the element size in emit_buffer_surface_state

2016-07-15 Thread Chad Versace
On Wed 13 Jul 2016, Jason Ekstrand wrote: > Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 11 ++- > src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 9 + > src/mesa/drivers/dri/i965/gen8_surface_state.c

Re: [Mesa-dev] [PATCH v4 32/34] i965: Use ISL for emitting buffer surface states

2016-07-15 Thread Chad Versace
On Wed 13 Jul 2016, Jason Ekstrand wrote: > Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_binding_tables.c| 2 +- > src/mesa/drivers/dri/i965/brw_context.h | 8 -- > src/mesa/drivers/dri/i965/brw_state.h | 9 +++ >

Re: [Mesa-dev] [PATCH v4 27/34] i965/gen7: Use the generic ISL-based path for renderbuffer surfaces

2016-07-15 Thread Chad Versace
On Wed 13 Jul 2016, Jason Ekstrand wrote: > Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_state.h | 7 - > src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 194 > +- > 2 files changed, 1 insertion(+), 200

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-15 Thread Andy Furniss
Andy Furniss wrote: omx doesn't have this issue, for 30mbit the files produced are 53M and 26M. Actually by default omx will make the same size files, I lucked into that behavior playing around with the control-rate param. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH v4 23/34] i965/state: Add generic surface update functions based on ISL

2016-07-15 Thread Chad Versace
On Wed 13 Jul 2016, Jason Ekstrand wrote: > Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_state.h| 9 ++ > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 184 > +++ > 2 files changed, 193 insertions(+) >

Re: [Mesa-dev] [PATCH 04/10] egl/android: Stop leaking DRI images

2016-07-15 Thread Eric Anholt
Tomasz Figa writes: > Hi Eric, > > On Sat, Jul 16, 2016 at 3:05 AM, Eric Anholt wrote: >> Tomasz Figa writes: >> >>> Current implementation of the DRI image loader does not free the images >>> created in get_back_bo() and so leaks

Re: [Mesa-dev] [PATCH 10/10] egl/android: Add fallback to kms_swrast driver

2016-07-15 Thread Eric Anholt
Tomasz Figa writes: > If no hardware driver is present, it is possible to fall back to > the kms_swrast driver with any DRI node that supports dumb GEM create > and mmap IOCTLs with softpipe/llvmpipe drivers. This patch makes the > Android EGL platform code retry probe with

Re: [Mesa-dev] [PATCH 08/10] egl/android: Make get_fourcc() accept HAL formats

2016-07-15 Thread Eric Anholt
Tomasz Figa writes: > There are DRI_IMAGE_FOURCC macros, for which there are no corresponding > DRI_IMAGE_FORMAT macros. To support such formats we need to make the > lookup function take the native format directly. As a side effect, it > simplifies all existing calls to this

Re: [Mesa-dev] [PATCH 06/10] egl/android: Fix support for pbuffers

2016-07-15 Thread Eric Anholt
Tomasz Figa writes: > From: Nicolas Boichat > > Existing image loader code supports creating images only for window > surfaces. Moreover droid_create_surface() passes wrong surface type to > dri2_get_dri_config(), resulting in incorrect configs being

[Mesa-dev] [Bug 96943] [gallium] glCopyPixels is affected by enabled texture state

2016-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96943 --- Comment #2 from Ilia Mirkin --- (In reply to Roland Scheidegger from comment #1) > The piglit test is probably wrong (I didn't really look), at least different > results based on enabled texturing don't surprise me.

Re: [Mesa-dev] [PATCH 04/10] egl/android: Stop leaking DRI images

2016-07-15 Thread Tomasz Figa
Hi Eric, On Sat, Jul 16, 2016 at 3:05 AM, Eric Anholt wrote: > Tomasz Figa writes: > >> Current implementation of the DRI image loader does not free the images >> created in get_back_bo() and so leaks memory. Moreover, it creates a new >> image every time

[Mesa-dev] [Bug 96943] [gallium] glCopyPixels is affected by enabled texture state

2016-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96943 --- Comment #1 from Roland Scheidegger --- (In reply to Ilia Mirkin from comment #0) > The recently rewritten copy-pixels test has exposed some failures in > st/mesa. When there's an overlapping copy (among other conditions),

Re: [Mesa-dev] [PATCH 04/10] egl/android: Stop leaking DRI images

2016-07-15 Thread Eric Anholt
Tomasz Figa writes: > Current implementation of the DRI image loader does not free the images > created in get_back_bo() and so leaks memory. Moreover, it creates a new > image every time the DRI driver queries for buffers, even if the backing > native buffer has not changed.

Re: [Mesa-dev] [PATCH 01/10] egl/android: Set EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT

2016-07-15 Thread Tomasz Figa
[Adding Haixia to the thread.] On Sat, Jul 16, 2016 at 2:52 AM, Eric Anholt wrote: > Tomasz Figa writes: > >> From: Haixia Shi >> >> Set config attributes EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT to >> hard-coded non-zero values.

Re: [Mesa-dev] [PATCH 4/4] anv: Handle VK_WHOLE_SIZE properly for buffer views

2016-07-15 Thread Jason Ekstrand
On Fri, Jul 15, 2016 at 9:57 AM, Nanley Chery wrote: > On Thu, Jul 14, 2016 at 09:20:08PM -0700, Jason Ekstrand wrote: > > The old calculation, which used view->offset, encorporated buffer->offset > > into the size calculation where it doesn't belong. This meant that, if

Re: [Mesa-dev] [PATCH 03/10] egl/android: Add some useful error messages

2016-07-15 Thread Eric Anholt
Tomasz Figa writes: > It is much easier to debug issues when the application gives some > meaningful error messages. This patch adds few to the EGL Android > platform backend. > > Signed-off-by: Tomasz Figa Reviewed-by: Eric Anholt

Re: [Mesa-dev] [PATCH 01/10] egl/android: Set EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT

2016-07-15 Thread Eric Anholt
Tomasz Figa writes: > From: Haixia Shi > > Set config attributes EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT to > hard-coded non-zero values. These two attributes are required on Android. > > Signed-off-by: Tomasz Figa > --- >

Re: [Mesa-dev] [PATCH 02/10] egl/android: Check return value of dri2_get_dri_config()

2016-07-15 Thread Eric Anholt
Tomasz Figa writes: > It might return NULL if specific config variant is unsupported. > > Signed-off-by: Tomasz Figa Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-15 Thread Andy Furniss
Zhang, Boyuan wrote: Hi Andy, Thanks for the testing. I will look into the memory issue. For the cbr test, what was the bitrate you set? And by saying testing high rates, how high was the rate approximately? Testing more shows that I get the same size file independent of framerate. An example

Re: [Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-15 Thread Nanley Chery
On Thu, Jul 14, 2016 at 04:18:33PM -0700, Jason Ekstrand wrote: > On Thu, Jul 14, 2016 at 4:13 PM, Nanley Chery wrote: > > > On Thu, Jul 14, 2016 at 03:57:09PM -0700, Jason Ekstrand wrote: > > > On Thu, Jul 14, 2016 at 3:45 PM, Nanley Chery > >

[Mesa-dev] [PATCH 4/4] mesa: handle numLevels, numSamples in _mesa_test_proxy_teximage()

2016-07-15 Thread Brian Paul
If numSamples > 0, we can compute the size of the whole mipmapped texture. That's the case for glTexStorage(GL_PROXY_TEXTURE_x). Also, multiply the texture size by numSamples for MSAA textures. --- src/mesa/main/teximage.c | 48 +--- 1 file changed, 45

[Mesa-dev] [PATCH 1/4] mesa: use _mesa_clear_texture_image() in clear_texture_fields()

2016-07-15 Thread Brian Paul
This avoids a failed assert(img->_BaseFormat != -1) in init_teximage_fields_ms() because the internalFormat argument is GL_NONE. This was hit when using glTexStorage() to do a proxy texture test. Fixes a failure with the updated Piglit tex3d-maxsize test. Cc:

[Mesa-dev] [PATCH 3/4] mesa: add proxy texture targets in _mesa_next_mipmap_level_size()

2016-07-15 Thread Brian Paul
So we can use it for computing size of proxy textures. --- src/mesa/main/mipmap.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/mipmap.c b/src/mesa/main/mipmap.c index 5ff53f4..996e3f8 100644 --- a/src/mesa/main/mipmap.c +++ b/src/mesa/main/mipmap.c @@

[Mesa-dev] [PATCH 2/4] mesa: add numLevels, numSamples to Driver.TestProxyTexImage()

2016-07-15 Thread Brian Paul
So that the function can work properly with glTexStorage(), where we know how many mipmap levels there are. And so we can compute storage for MSAA textures. Also, remove the obsolete texture border parameter. A subsequent patch will update _mesa_test_proxy_teximage() to use these new

[Mesa-dev] [Bug 96943] [gallium] glCopyPixels is affected by enabled texture state

2016-07-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96943 Bug ID: 96943 Summary: [gallium] glCopyPixels is affected by enabled texture state Product: Mesa Version: git Hardware: Other OS: All Status:

Re: [Mesa-dev] [PATCH 4/4] anv: Handle VK_WHOLE_SIZE properly for buffer views

2016-07-15 Thread Nanley Chery
On Thu, Jul 14, 2016 at 09:20:08PM -0700, Jason Ekstrand wrote: > The old calculation, which used view->offset, encorporated buffer->offset > into the size calculation where it doesn't belong. This meant that, if > buffer->offset > buffer->size, you would always get a negative size. This > fixes

Re: [Mesa-dev] [PATCH 1/4] genxml: Make gen6-7 blending look more like gen8

2016-07-15 Thread Jason Ekstrand
On Fri, Jul 15, 2016 at 3:38 AM, Kenneth Graunke wrote: > On Thursday, July 14, 2016 9:20:05 PM PDT Jason Ekstrand wrote: > > This renames BLEND_STATE to BLEND_STATE_ENTRY and adds an new struct > > BLEND_STATE which is just an array of 8 BLEND_STATE_ENTRYs. This will >

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-15 Thread Zhang, Boyuan
Hi Andy, Thanks for the testing. I will look into the memory issue. For the cbr test, what was the bitrate you set? And by saying testing high rates, how high was the rate approximately? Regards, Boyuan -Original Message- From: Andy Furniss [mailto:adf.li...@gmail.com] Sent:

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-15 Thread Andy Furniss
Christian König wrote: Am 05.07.2016 um 13:17 schrieb Christian König: Am 01.07.2016 um 18:18 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 18:02 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by:

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Make sure display is initialized before using it

2016-07-15 Thread Emil Velikov
On 15 July 2016 at 09:28, Nicolas Boichat wrote: > android.opengl.cts.WrapperTest#testGetIntegerv1 CTS test calls > eglTerminate, followed by eglReleaseThread. In that case, the > display will not be initialized when eglReleaseThread calls > MakeCurrent with NULL

Re: [Mesa-dev] [PATCH 2/2] i965/tes/scalar: fix 64-bit indirect input loads

2016-07-15 Thread Iago Toral
On Fri, 2016-07-15 at 21:20 +1000, Timothy Arceri wrote: > On Fri, 2016-07-15 at 13:16 +0200, Iago Toral wrote: > > > > On Fri, 2016-07-15 at 20:59 +1000, Timothy Arceri wrote: > > > > > > On Fri, 2016-07-15 at 11:04 +0200, Iago Toral Quiroga wrote: > > > > > > > > > > > > We totally ignored

Re: [Mesa-dev] [PATCH 2/2] i965/tes/scalar: fix 64-bit indirect input loads

2016-07-15 Thread Timothy Arceri
On Fri, 2016-07-15 at 13:16 +0200, Iago Toral wrote: > On Fri, 2016-07-15 at 20:59 +1000, Timothy Arceri wrote: > > On Fri, 2016-07-15 at 11:04 +0200, Iago Toral Quiroga wrote: > > > > > > We totally ignored this before because there were no piglit tests > > > for > > > indirect loads in

Re: [Mesa-dev] [PATCH 2/2] i965/tes/scalar: fix 64-bit indirect input loads

2016-07-15 Thread Iago Toral
On Fri, 2016-07-15 at 20:59 +1000, Timothy Arceri wrote: > On Fri, 2016-07-15 at 11:04 +0200, Iago Toral Quiroga wrote: > > > > We totally ignored this before because there were no piglit tests > > for > > indirect loads in tessellation stages with doubles. > > > > Cc: "12.0"

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Make sure display is initialized before using it

2016-07-15 Thread Rhys Kidd
Whilst I don't know that code as well as I'd like. It does get my Tested-by: Rhys Kidd for fixing that piglit on i965 ILK. Thanks for the two patches! On 15 July 2016 at 04:28, Nicolas Boichat wrote: > android.opengl.cts.WrapperTest#testGetIntegerv1

Re: [Mesa-dev] [PATCH 2/2] i965/tes/scalar: fix 64-bit indirect input loads

2016-07-15 Thread Timothy Arceri
On Fri, 2016-07-15 at 20:59 +1000, Timothy Arceri wrote: > On Fri, 2016-07-15 at 11:04 +0200, Iago Toral Quiroga wrote: > > We totally ignored this before because there were no piglit tests > > for > > indirect loads in tessellation stages with doubles. > > > > Cc: "12.0"

Re: [Mesa-dev] [PATCH 2/2] i965/tes/scalar: fix 64-bit indirect input loads

2016-07-15 Thread Timothy Arceri
On Fri, 2016-07-15 at 11:04 +0200, Iago Toral Quiroga wrote: > We totally ignored this before because there were no piglit tests for > indirect loads in tessellation stages with doubles. > > Cc: "12.0" > --- >  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 86 >

Re: [Mesa-dev] [PATCH 1/4] genxml: Make gen6-7 blending look more like gen8

2016-07-15 Thread Kenneth Graunke
On Thursday, July 14, 2016 9:20:05 PM PDT Jason Ekstrand wrote: > This renames BLEND_STATE to BLEND_STATE_ENTRY and adds an new struct > BLEND_STATE which is just an array of 8 BLEND_STATE_ENTRYs. This will make > it much easier to write gen-agnostic blend handling code. > > Signed-off-by: Jason

[Mesa-dev] VAAPI egl interop on radeon

2016-07-15 Thread Jan Burgmeier
Hi, I am developing an application which uses vaapi and egl. My goal is to use vaDeriveImage and vaAcquireBufferHandle to get the drm buffer id which then can be used to create a EGLImageKHR. My problem is, that on amd hardware (AMD GX-212ZC SOC with Radeon(TM) R1E Graphics and AMD GX-424CC

[Mesa-dev] [PATCH 2/2] i965/tes/scalar: fix 64-bit indirect input loads

2016-07-15 Thread Iago Toral Quiroga
We totally ignored this before because there were no piglit tests for indirect loads in tessellation stages with doubles. Cc: "12.0" --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 86 1 file changed, 64 insertions(+), 22

[Mesa-dev] [PATCH 1/2] i965/tcs/scalar: only update imm_offset for second message in 64bit input loads

2016-07-15 Thread Iago Toral Quiroga
Our indirect URB read messages take both a direct and an indirect offset so when we emit the second message for a 64-bit input load we can just always incremement the immediate offset, even for the indirect case. --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 8 +--- 1 file changed, 1

[Mesa-dev] [PATCH v2] main/shaderimage: image unit is invalid if texture is incomplete

2016-07-15 Thread Alejandro Piñeiro
From the OpenGL 4.3 Core Specification, section 8.25 ("Texture Image Loads and Stores"): "An access is considered invalid if: the texture bound to the selected image unit is incomplete;" This fixes: GL44-CTS.shader_image_load_store.incomplete_textures v2: use _mesa_is_texture_complete,

Re: [Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

2016-07-15 Thread Alejandro Piñeiro
On 14/07/16 21:24, Francisco Jerez wrote: > Alejandro Piñeiro writes: > >> Without this commit, a image is considered valid if the level of the >> texture bound to the image is complete, something we can check as mesa >> save independently if it is "base incomplete" of

[Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Make sure display is initialized before using it

2016-07-15 Thread Nicolas Boichat
android.opengl.cts.WrapperTest#testGetIntegerv1 CTS test calls eglTerminate, followed by eglReleaseThread. In that case, the display will not be initialized when eglReleaseThread calls MakeCurrent with NULL parameters, to unbind the context, which causes a a segfault in drv->API.MakeCurrent

[Mesa-dev] [PATCH v3] egl/dri2: dri2_make_current: Set EGL error if bindContext fails

2016-07-15 Thread Nicolas Boichat
From: Nicolas Boichat Without this, if a configuration is, say, available only on GLES2/3, but not on GLES1, and is rejected by the dri module's bindContext call, eglMakeCurrent fails with error "EGL_SUCCESS". In this patch, we set error to EGL_BAD_MATCH, which is what

Re: [Mesa-dev] [PATCH v2] egl/dri2: dri2_make_current: Set EGL error if bindContext fails

2016-07-15 Thread Nicolas Boichat
Please ignore this patch, I'll resend along with some slightly improved/annotated EGL error handling. On Thu, Jul 14, 2016 at 12:22 PM, Nicolas Boichat wrote: > From: Nicolas Boichat > > Without this, if a configuration is, say, available only on

[Mesa-dev] [PATCH 10/10] egl/android: Add fallback to kms_swrast driver

2016-07-15 Thread Tomasz Figa
If no hardware driver is present, it is possible to fall back to the kms_swrast driver with any DRI node that supports dumb GEM create and mmap IOCTLs with softpipe/llvmpipe drivers. This patch makes the Android EGL platform code retry probe with kms_swrast if hardware-only probe fails.

[Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

2016-07-15 Thread Tomasz Figa
We can support render nodes alone without any private headers, so let's make support for control nodes depend on presence of private drm_gralloc headers. Signed-off-by: Tomasz Figa --- src/egl/Android.mk | 1 + src/egl/drivers/dri2/egl_dri2.h |

[Mesa-dev] [PATCH 09/10] egl/android: Add support for YV12 pixel format

2016-07-15 Thread Tomasz Figa
This patch adds support for YV12 pixel format to the Android platform backend. Only creating EGL images is supported, it is not added to the list of available visuals. Signed-off-by: Tomasz Figa Signed-off-by: Kalyan Kondapally ---

[Mesa-dev] [PATCH 08/10] egl/android: Make get_fourcc() accept HAL formats

2016-07-15 Thread Tomasz Figa
There are DRI_IMAGE_FOURCC macros, for which there are no corresponding DRI_IMAGE_FORMAT macros. To support such formats we need to make the lookup function take the native format directly. As a side effect, it simplifies all existing calls to this function, because they all called get_format()

[Mesa-dev] [PATCH 06/10] egl/android: Fix support for pbuffers

2016-07-15 Thread Tomasz Figa
From: Nicolas Boichat Existing image loader code supports creating images only for window surfaces. Moreover droid_create_surface() passes wrong surface type to dri2_get_dri_config(), resulting in incorrect configs being returned for pbuffers. This patch fixes these

[Mesa-dev] [PATCH 01/10] egl/android: Set EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT

2016-07-15 Thread Tomasz Figa
From: Haixia Shi Set config attributes EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT to hard-coded non-zero values. These two attributes are required on Android. Signed-off-by: Tomasz Figa --- src/egl/drivers/dri2/platform_android.c | 2 ++ 1 file

  1   2   >