[Mesa-dev] [PATCH 09/10] intel/genxml: Make "Predication enable" a boolean

2016-10-14 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/intel/genxml/gen8.xml | 2 +- src/intel/genxml/gen9.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml index 07fe014..971c997 100644 --- a/src/intel/genxml/gen8.xml +++ b/src/intel/

[Mesa-dev] [PATCH 07/10] intel/genxml; Make "Tiled Surface" a boolean

2016-10-14 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/intel/genxml/gen6.xml | 4 ++-- src/intel/genxml/gen7.xml | 2 +- src/intel/genxml/gen75.xml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index 3b7685b..b7bbd80 100644 --- a/src

[Mesa-dev] [PATCH 04/10] intel/genxml: Make a couple of STREAMOUT fields booleans

2016-10-14 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/intel/genxml/gen7.xml | 4 ++-- src/intel/genxml/gen75.xml | 4 ++-- src/intel/genxml/gen8.xml | 4 ++-- src/intel/genxml/gen9.xml | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/intel/genxml/gen7.xml b/src/intel/genxml/gen7.xm

[Mesa-dev] [PATCH 01/10] intel/genxml: Make "Single Program Flow" a boolean

2016-10-14 Thread Jason Ekstrand
We also get rid of the "(SPF)" a few places. Signed-off-by: Jason Ekstrand --- src/intel/genxml/gen6.xml | 6 +++--- src/intel/genxml/gen7.xml | 8 src/intel/genxml/gen75.xml | 8 src/intel/genxml/gen8.xml | 6 +++--- src/intel/genxml/gen9.xml | 6 +++--- 5 files changed, 1

[Mesa-dev] [PATCH 05/10] intel/genxml: Make "Stencil Buffer Enable" a boolean

2016-10-14 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/intel/genxml/gen75.xml | 2 +- src/intel/genxml/gen8.xml | 2 +- src/intel/genxml/gen9.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/genxml/gen75.xml b/src/intel/genxml/gen75.xml index 8c90f22..67762c6 100644 --- a/src

[Mesa-dev] [PATCH 02/10] intel/genxml: Make "Vector Mask Enable" a boolean

2016-10-14 Thread Jason Ekstrand
We also get rid of the "(VME)" a few places Signed-off-by: Jason Ekstrand --- src/intel/genxml/gen6.xml | 6 +++--- src/intel/genxml/gen7.xml | 6 +++--- src/intel/genxml/gen75.xml | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/

[Mesa-dev] [PATCH 03/10] intel/genxml: Make "Include Vertex Handles" and "Include Primitive ID" booleans

2016-10-14 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/intel/genxml/gen7.xml | 6 +++--- src/intel/genxml/gen75.xml | 6 +++--- src/intel/genxml/gen8.xml | 6 +++--- src/intel/genxml/gen9.xml | 6 +++--- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/intel/genxml/gen7.xml b/src/intel/genx

[Mesa-dev] [PATCH 10/10] intel/genxml: Make some PIPE_CONTROL fields booleans

2016-10-14 Thread Jason Ekstrand
--- src/intel/genxml/gen6.xml | 9 +++-- src/intel/genxml/gen7.xml | 7 ++- src/intel/genxml/gen75.xml | 7 ++- src/intel/genxml/gen8.xml | 7 ++- src/intel/genxml/gen9.xml | 7 ++- 5 files changed, 11 insertions(+), 26 deletions(-) diff --git a/src/intel/genxml/gen6.xml b

[Mesa-dev] [PATCH 08/10] intel/genxml; Make "Use Global GTT a boolean

2016-10-14 Thread Jason Ekstrand
We also remove the redundant zero defaults since everything without an explicit default gets zeroed automatically. Signed-off-by: Jason Ekstrand --- src/intel/genxml/gen6.xml | 11 --- src/intel/genxml/gen7.xml | 15 ++- src/intel/genxml/gen75.xml | 15 ++- src/

[Mesa-dev] [PATCH 06/10] intel/genxml: Make "SO Buffer Enable" fields boolean

2016-10-14 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/intel/genxml/gen7.xml | 8 src/intel/genxml/gen75.xml | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/intel/genxml/gen7.xml b/src/intel/genxml/gen7.xml index 7d09835..6d88f4a 100644 --- a/src/intel/genxml/gen7.xml ++

[Mesa-dev] [PATCH 00/10] intel/genxml: Make more stuff booleans

2016-10-14 Thread Jason Ekstrand
This is a fairly trivial little cleanup that makes a bunch of 1-bit fields that used to have the "uint" type have the "bool" type instead. Ideally, a field should have the "bool" type if and only if, given the name of the field and a true/false value, it's obvious what that value means. I think t

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

2016-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #16 from shinji.suz...@gmail.com --- Created attachment 127317 --> https://bugs.freedesktop.org/attachment.cgi?id=127317&action=edit Arbitration on so->fence through per sync-object mutex. -- You are receiving this mail because: Yo

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

2016-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #15 from shinji.suz...@gmail.com --- Created attachment 127316 --> https://bugs.freedesktop.org/attachment.cgi?id=127316&action=edit Arbitration on so->fence based on Michel-san's patch -- You are receiving this mail because: You a

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

2016-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #14 from shinji.suz...@gmail.com --- I've ben running tests with changes derived from your patch, with and without random sleeps to give some shake-ups to execution order with, and have seen no crashes so far. The differences from your

[Mesa-dev] [PATCH] i965: Fix gl_InvocationID in dual object GS where invocations == 1.

2016-10-14 Thread Kenneth Graunke
dEQP-GLES31.functional.geometry_shading.instanced.geometry_1_invocations draws using a geometry shader that specifies layout(points, invocations = 1) in; and then uses gl_InvocationID. According to the Haswell PRM, the "GS Instance ID 0" (and 1) thread payload fields are undefined in dual obj

Re: [Mesa-dev] [PATCH 4/4] i965: Silence unused parameter warnings

2016-10-14 Thread Ian Romanick
On 10/14/2016 05:44 PM, Eric Engestrom wrote: >> Subject: [PATCH 4/4] i965: Silence unused parameter warnings > > How about "remove unused parameters" instead? > Silencing the warnings is nothing more than a side effect of this > change, albeit the reason you realised it was needed. There are alr

Re: [Mesa-dev] [PATCH 02/16] loader: slim down loader_get_pci_id_for_fd implementation(s)

2016-10-14 Thread Jonathan Gray
On Tue, Oct 11, 2016 at 07:31:46PM +0100, Emil Velikov wrote: > From: Emil Velikov > > Currently mesa has three code paths in the loader - libudev, manual > sysfs and drm ioctl one. > > Considering the issues we had with libudev - strip those down in favour > of the libdrm drm device API. The la

[Mesa-dev] [PATCH] draw: improve vertex fetch (v2)

2016-10-14 Thread sroland
From: Roland Scheidegger The per-element fetch has quite some calculations which are constant, these can be moved outside both the per-element as well as the main shader loop (llvm can figure out it's constant mostly on its own, however this can have a significant compile time cost). Similarly, i

Re: [Mesa-dev] [PATCH] state_tracker: Fix check for scissor enabled when < 0.

2016-10-14 Thread Kenneth Graunke
On Friday, October 14, 2016 4:37:38 PM PDT Eric Anholt wrote: > DEQP's clear tests like to give us x + w < 0 or y + h < 0. Since we > were comparing to an unsigned, it would get promoted to unsigned and come > out as bignum >= width or height and we would clear the whole fb instead > of none of th

Re: [Mesa-dev] [PATCH v2] egl/wayland: Avoid race conditions when on non-main thread

2016-10-14 Thread Emil Velikov
[Cc-ing Daniel/Pekka] Hi all, On 24 June 2016 at 03:46, Jonas Ådahl wrote: > When EGL is used on some other thread than the thread that drives the > main wl_display queue, the Wayland EGL dri2 implementation is > vulnerable to a race condition related to display round trips and global > object a

Re: [Mesa-dev] [PATCH 4/4] i965: Silence unused parameter warnings

2016-10-14 Thread Eric Engestrom
> Subject: [PATCH 4/4] i965: Silence unused parameter warnings How about "remove unused parameters" instead? Silencing the warnings is nothing more than a side effect of this change, albeit the reason you realised it was needed. (Sorry, I've seen so many "silence warning" commits at $DAYJOB that

Re: [Mesa-dev] [PATCH] egl/surfaceless: use correct index when accesing the visual

2016-10-14 Thread Eric Engestrom
On Fri, Oct 14, 2016 at 09:42:00PM +0100, Emil Velikov wrote: > From: Emil Velikov > > i is used for the driver_configs, while j is for the visuals. > > Fixes: 4b8a55809eb ("egl/surfaceless: tweak > surfaceless_add_configs_for_visuals()") > Reported-by: Chad Versace > Cc: Chad Versace > Signe

Re: [Mesa-dev] [PATCH 3/4] glsl: Remove unused function import_prototypes

2016-10-14 Thread Timothy Arceri
On 15 October 2016 10:11:17 am AEDT, Kenneth Graunke wrote: >On Friday, October 14, 2016 11:59:46 AM PDT Ian Romanick wrote: >> From: Ian Romanick >> >> Once upon a time, this was used to extract prototypes from the shader >> containing GLSL built-in functions. This was removed by f5692f45 i

Re: [Mesa-dev] [PATCH 2/2] i965: Fix typo in nir_op_pack_double_2x32_split handling

2016-10-14 Thread Jason Ekstrand
On Fri, Oct 14, 2016 at 10:23 AM, Ian Romanick wrote: > On 10/08/2016 09:33 AM, Eduardo Lima Mitev wrote: > > On 10/08/2016 02:12 AM, Ian Romanick wrote: > >> From: Ian Romanick > >> > >> This was found partially by inspection and partially by hitting a > >> problem while working on nir_op_pack_

[Mesa-dev] [PATCH] state_tracker: Fix check for scissor enabled when < 0.

2016-10-14 Thread Eric Anholt
DEQP's clear tests like to give us x + w < 0 or y + h < 0. Since we were comparing to an unsigned, it would get promoted to unsigned and come out as bignum >= width or height and we would clear the whole fb instead of none of the fb. Fixes 10 tests under deqp-gles2/functional/color_clear. --- sr

Re: [Mesa-dev] [PATCH] egl/surfaceless: Fix comparison between pointer and integer

2016-10-14 Thread Emil Velikov
On Friday, 14 October 2016, Chad Versace wrote: > Fixes GCC warning: > drivers/dri2/platform_surfaceless.c:196:18: warning: comparison > between pointer and integer > > Fixes: 4b8a55809eb ("egl/surfaceless: tweak surfaceless_add_configs_for_ > visuals()") > Cc: Emil Velikov > Reviewed-by

Re: [Mesa-dev] [PATCH 3/4] glsl: Remove unused function import_prototypes

2016-10-14 Thread Kenneth Graunke
On Friday, October 14, 2016 11:59:46 AM PDT Ian Romanick wrote: > From: Ian Romanick > > Once upon a time, this was used to extract prototypes from the shader > containing GLSL built-in functions. This was removed by f5692f45 in > November 2010 for Mesa 7.10. > > Signed-off-by: Ian Romanick >

[Mesa-dev] [PATCH] egl/surfaceless: Fix comparison between pointer and integer

2016-10-14 Thread Chad Versace
Fixes GCC warning: drivers/dri2/platform_surfaceless.c:196:18: warning: comparison between pointer and integer Fixes: 4b8a55809eb ("egl/surfaceless: tweak surfaceless_add_configs_for_visuals()") Cc: Emil Velikov --- src/egl/drivers/dri2/platform_surfaceless.c | 2 +- 1 file changed, 1 i

Re: [Mesa-dev] [PATCH] egl/surfaceless: use correct index when accesing the visual

2016-10-14 Thread Chad Versace
On Fri 14 Oct 2016, Emil Velikov wrote: > From: Emil Velikov > > i is used for the driver_configs, while j is for the visuals. > > Fixes: 4b8a55809eb ("egl/surfaceless: tweak > surfaceless_add_configs_for_visuals()") > Reported-by: Chad Versace > Cc: Chad Versace > Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH] egl/surfaceless: use correct index when accesing the visual

2016-10-14 Thread Emil Velikov
From: Emil Velikov i is used for the driver_configs, while j is for the visuals. Fixes: 4b8a55809eb ("egl/surfaceless: tweak surfaceless_add_configs_for_visuals()") Reported-by: Chad Versace Cc: Chad Versace Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_surfaceless.c | 2 +-

Re: [Mesa-dev] [PATCH v2 05/16] loader: reimplement loader_get_user_preferred_fd via libdrm

2016-10-14 Thread Emil Velikov
On 14 October 2016 at 20:21, Axel Davy wrote: > On 14/10/2016 20:21, Emil Velikov wrote: >> >> From: Emil Velikov >> >> Currently not everyone has libudev and with follow-up patches we'll >> completely remove the divergent codepaths. >> >> Use the libdrm drm device API to construct the required I

Re: [Mesa-dev] [PATCH] gallivm: print out time for jitting functions with GALLIVM_DEBUG=perf

2016-10-14 Thread Roland Scheidegger
Am 14.10.2016 um 18:05 schrieb Jose Fonseca: > On 14/10/16 15:36, Brian Paul wrote: >> On 10/13/2016 09:38 PM, srol...@vmware.com wrote: >>> From: Roland Scheidegger >>> >>> Compilation to actual machine code can easily take as much time as the >>> optimization passes on the IR if not more, so pri

Re: [Mesa-dev] [PATCH 17/22] anv: Use blorp for ClearAttachments

2016-10-14 Thread Jason Ekstrand
On Wed, Oct 12, 2016 at 2:26 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Oct 07, 2016 at 09:41:15PM -0700, Jason Ekstrand wrote: > > Signed-off-by: Jason Ekstrand > > --- > > src/intel/vulkan/anv_blorp.c | 113 ++ > > > src/intel

Re: [Mesa-dev] [PATCH 16/22] anv/hiz: Perform HiZ resolves for all partial renders

2016-10-14 Thread Jason Ekstrand
On Wed, Oct 12, 2016 at 9:01 AM, Nanley Chery wrote: > On Tue, Oct 11, 2016 at 06:55:53PM -0700, Jason Ekstrand wrote: > > On Tue, Oct 11, 2016 at 6:16 PM, Nanley Chery > wrote: > > > > > On Mon, Oct 10, 2016 at 06:00:49PM -0700, Jason Ekstrand wrote: > > > > On Mon, Oct 10, 2016 at 2:23 PM, Nan

Re: [Mesa-dev] [PATCH v2 05/16] loader: reimplement loader_get_user_preferred_fd via libdrm

2016-10-14 Thread Axel Davy
On 14/10/2016 20:21, Emil Velikov wrote: From: Emil Velikov Currently not everyone has libudev and with follow-up patches we'll completely remove the divergent codepaths. Use the libdrm drm device API to construct the required ID_PATH_TAG-like string, to preserve the current functionality for

Re: [Mesa-dev] [PATCH] vulkan: Initial partial documentation for Vulkan internals.

2016-10-14 Thread Rhys Kidd
On 14 October 2016 at 10:36, wrote: > From: Kevin Rogovin > > A main page ala Doxygen together with a Doxygen file added. > In addition, documentation for portions of anv_private.h: > - placing portions into doxygen groups > - some cross linking doxygen style to other files > Hello Kevin, Th

[Mesa-dev] [PATCH 1/4] glsl: Replace assert with unreachable

2016-10-14 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/glsl/ir_print_visitor.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_print_visitor.cpp b/src/compiler/glsl/ir_print_visitor.cpp index c238c16..1299bfb 100644 --- a/src/compiler/glsl/

[Mesa-dev] [PATCH 3/4] glsl: Remove unused function import_prototypes

2016-10-14 Thread Ian Romanick
From: Ian Romanick Once upon a time, this was used to extract prototypes from the shader containing GLSL built-in functions. This was removed by f5692f45 in November 2010 for Mesa 7.10. Signed-off-by: Ian Romanick Cc: Kenneth Graunke --- src/compiler/Makefile.sources | 1 - sr

[Mesa-dev] [PATCH 4/4] i965: Silence unused parameter warnings

2016-10-14 Thread Ian Romanick
From: Ian Romanick brw_link.cpp:76:44: warning: unused parameter ‘shader_type’ [-Wunused-parameter] gl_shader_stage shader_type, ^ brw_nir.c: In function ‘brw_nir_lower_vs_inputs’: brw_nir.c:194:55: warning: unused parameter

[Mesa-dev] [PATCH 2/4] glsl: Remove prototypes for nonexistent functions

2016-10-14 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/glsl/ir.h | 9 - 1 file changed, 9 deletions(-) diff --git a/src/compiler/glsl/ir.h b/src/compiler/glsl/ir.h index 83b810b..7e06d42 100644 --- a/src/compiler/glsl/ir.h +++ b/src/compiler/glsl/ir.h @@ -2357,9 +2357,6 @@ _me

Re: [Mesa-dev] [PATCH v2 4/7] egl/surfaceless: tweak surfaceless_add_configs_for_visuals()

2016-10-14 Thread Chad Versace
On Fri 16 Sep 2016, Emil Velikov wrote: > From: Emil Velikov > > Analogous to previous commit. > > v2: Use correct comparison in loop conditional (Eric) > Use valid C initializer (Gurchetan) > > Signed-off-by: Emil Velikov > Reviewed-by: Gurchetan Singh > --- > src/egl/drivers/dri2/platf

[Mesa-dev] [PATCH v2 05/16] loader: reimplement loader_get_user_preferred_fd via libdrm

2016-10-14 Thread Emil Velikov
From: Emil Velikov Currently not everyone has libudev and with follow-up patches we'll completely remove the divergent codepaths. Use the libdrm drm device API to construct the required ID_PATH_TAG-like string, to preserve the current functionality for libudev users and allow others to benefit f

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Perform check for valid fbconfig against proper X-Screen.

2016-10-14 Thread Emil Velikov
On 14 October 2016 at 18:14, Mario Kleiner wrote: > > They've been all merged, so you can close them. > Done and thanks again! Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/6] EGL_MESA_platform_surfaceless (v2)

2016-10-14 Thread Chad Versace
Some people privately asked why we need to create this EGL platform. I want to respond publicly. Mesa *already* *has* this EGL platform. In my view, the issue at hand isn't whether to create or to not create the platform. It's whether to specify its behavior (formally in an extension spec) or not.

Re: [Mesa-dev] [PATCH 2/2] i965: Fix typo in nir_op_pack_double_2x32_split handling

2016-10-14 Thread Ian Romanick
On 10/08/2016 09:33 AM, Eduardo Lima Mitev wrote: > On 10/08/2016 02:12 AM, Ian Romanick wrote: >> From: Ian Romanick >> >> This was found partially by inspection and partially by hitting a >> problem while working on nir_op_pack_int64_2x32_split. The code >> previously would 'continue' if (instr

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Perform check for valid fbconfig against proper X-Screen.

2016-10-14 Thread Mario Kleiner
On 10/14/2016 11:14 AM, Emil Velikov wrote: On 12 October 2016 at 18:40, Emil Velikov wrote: On 11 October 2016 at 19:42, Mario Kleiner wrote: Tested to fix context creation failure on a dual-x-screen setup. Signed-off-by: Mario Kleiner Cc: "11.2 12.0" Reviewed-by: Emil Velikov ...

[Mesa-dev] [Bug 98263] [radv] The Talos Principle fails to launch with "Fatal error: Cannot set display mode."

2016-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98263 --- Comment #1 from Kai --- Created attachment 127306 --> https://bugs.freedesktop.org/attachment.cgi?id=127306&action=edit output of vulkaninfo -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2016-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Kai changed: What|Removed |Added Depends on||98263 Referenced Bugs: https://bugs.freedesktop.

[Mesa-dev] [Bug 98263] [radv] The Talos Principle fails to launch with "Fatal error: Cannot set display mode."

2016-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98263 Bug ID: 98263 Summary: [radv] The Talos Principle fails to launch with "Fatal error: Cannot set display mode." Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [PATCH] draw: improved handling of undefined inputs

2016-10-14 Thread Jose Fonseca
Looks great to me! Reviewed-by: José Fonseca From: Roland Scheidegger Sent: Friday, 14 October, 02:21 Subject: [PATCH] draw: improved handling of undefined inputs To: Jose Fonseca, ML mesa-dev Cc: Roland Scheidegger From: Roland Scheidegger Previous attempts to zero initialize all inputs were

[Mesa-dev] [PATCH] Initial Intel Vulkan internals documentation

2016-10-14 Thread kevin . rogovin
From: Kevin Rogovin This is an RFC for documentation I am making for the Intel OTC Vulkan driver. The eventual goal for the documentation is to help new developers understand the code base more quickly so that they can contribute more easily. Kevin Rogovin (1): vulkan: Initial partial documen

Re: [Mesa-dev] [PATCH] gallivm: print out time for jitting functions with GALLIVM_DEBUG=perf

2016-10-14 Thread Jose Fonseca
On 14/10/16 15:36, Brian Paul wrote: On 10/13/2016 09:38 PM, srol...@vmware.com wrote: From: Roland Scheidegger Compilation to actual machine code can easily take as much time as the optimization passes on the IR if not more, so print this out too. --- src/gallium/auxiliary/gallivm/lp_bld_in

[Mesa-dev] [Bug 98168] [vulkan, radv] Talos rendering glitches on Ultra settings on Tonga

2016-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98168 --- Comment #6 from Christoph Haag --- Created attachment 127304 --> https://bugs.freedesktop.org/attachment.cgi?id=127304&action=edit water with 8xaa (In reply to Vedran Miletić from comment #5) > https://youtu.be/dS2HLt5BjFY I believe I re

Re: [Mesa-dev] [PATCH] anv: fix enumeration of properties

2016-10-14 Thread Eric Engestrom
On Thursday, 2016-10-06 14:12:27 +0100, Emil Velikov wrote: > From: Emil Velikov > > Driver should enumerate only up-to min2(num_available, num_requested) > properties and return VK_INCOMPLETE if the # of requested props is > smaller than the ones available. > > Presently we assert out in such c

Re: [Mesa-dev] [PATCH 01/15] ralloc: don't memset ralloc_header, clear it manually

2016-10-14 Thread Emil Velikov
On 8 October 2016 at 11:58, Marek Olšák wrote: > From: Marek Olšák > > time GALLIUM_NOOP=1 ./run shaders/private/alien_isolation/ >/dev/null > > Before (2 takes): > > real0m8.734s0m8.773s > user0m34.232s 0m34.348s > sys 0m0.084s0m0.056s > > After (2 takes): > > real0m8.4

Re: [Mesa-dev] [PATCH v2 10/30] egl/dri2: rework dri2_make_current code flow

2016-10-14 Thread Lionel Landwerlin
Yeah, looking at it a bit longer, it seems that the unbind behavior broke (again like Eric suggested). When you replaced that condition : unbind = (cctx == NULL && ddraw == NULL && rdraw == NULL); if (unbind || dri2_dpy->core->bindContext(cctx, ddraw, rdraw)) { By this : if (cctx || ddraw ||

Re: [Mesa-dev] [PATCH v2 10/30] egl/dri2: rework dri2_make_current code flow

2016-10-14 Thread Lionel Landwerlin
Thanks a lot, The diff is a bit too complicated for me to tell how it's different. - Lionel On 14/10/16 16:11, Emil Velikov wrote: On 14 October 2016 at 15:58, Lionel Landwerlin wrote: Hi Emil, I've not been able to run the deqp gles31 test suite after this commit. Like Eric suggested I thi

Re: [Mesa-dev] [PATCH v2 10/30] egl/dri2: rework dri2_make_current code flow

2016-10-14 Thread Emil Velikov
On 14 October 2016 at 15:58, Lionel Landwerlin wrote: > Hi Emil, > > I've not been able to run the deqp gles31 test suite after this commit. > Like Eric suggested I think this is introducing a behavior change. > v2 should not do that, yet it might be missing something. I've reverted it and will gi

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/3] i915: store reference to the context within struct intel_fence

2016-10-14 Thread Emil Velikov
On 27 July 2016 at 15:30, Emil Velikov wrote: > On 16 July 2016 at 01:02, Mauro Rossi wrote: >> Hi, >> >> I'm sending the v2 re-spin of patch as per i965, rechecked twice >> line-by-line with Tomasz's one. >> >> Building ok, marshmallow-x86 booting ok and here are the results of Android >> CTS eg

Re: [Mesa-dev] [PATCH v2 10/30] egl/dri2: rework dri2_make_current code flow

2016-10-14 Thread Lionel Landwerlin
Hi Emil, I've not been able to run the deqp gles31 test suite after this commit. Like Eric suggested I think this is introducing a behavior change. Thanks, - Lionel On 03/10/16 19:28, Emil Velikov wrote: From: Emil Velikov Fold duplicate conditional blocks and add a few extra comments ;-)

Re: [Mesa-dev] [PATCH] gallivm: print out time for jitting functions with GALLIVM_DEBUG=perf

2016-10-14 Thread Brian Paul
On 10/13/2016 09:38 PM, srol...@vmware.com wrote: From: Roland Scheidegger Compilation to actual machine code can easily take as much time as the optimization passes on the IR if not more, so print this out too. --- src/gallium/auxiliary/gallivm/lp_bld_init.c | 11 +++ 1 file changed

[Mesa-dev] [Bug 98132] #version 300 es compute shaders should not be possible

2016-10-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98132 Iago Toral changed: What|Removed |Added CC||ito...@igalia.com --- Comment #2 from Iago

[Mesa-dev] [PACH v2] glsl: SSBO unsized array declarations, if present, must be declared last

2016-10-14 Thread Iago Toral Quiroga
From the ARB_shader_storage_buffer_object spec: "In a shader storage block, the last member may be declared without an explicit size. In this case, the effective array size is inferred at run-time from the size of the data store backing the interface block. Such unsized arrays may be indexed

[Mesa-dev] [PATCH 2/2] glsl: SSBO unsized array declarations, if present, must be declared last

2016-10-14 Thread Iago Toral Quiroga
From the ARB_shader_storage_buffer_object spec: "In a shader storage block, the last member may be declared without an explicit size. In this case, the effective array size is inferred at run-time from the size of the data store backing the interface block. Such unsized arrays may be indexed

[Mesa-dev] [PATCH 1/2] glsl: fail compilation of compute shaders when unsupported

2016-10-14 Thread Iago Toral Quiroga
Generally, we only check for the presence of compute shaders during parsing when we find any language (like layout qualifiers) that are specific to compute shaders, however, it is possible to define an empty compute shader does not use any language specific to compute shaders at all and we should f

Re: [Mesa-dev] [PATCH 1/6] util: add vector util code.

2016-10-14 Thread Marek Olšák
The beginning of the header file should describe what it is. Marek On Oct 14, 2016 6:45 AM, "Edward O'Callaghan" wrote: > Too easy, one trivial comment below but either way: > Reviewed-by: Edward O'Callaghan > > P.S. thanks for getting on top of this kind of maintainability stuff so > fast ! >

Re: [Mesa-dev] [PATCH 1/5] st/va: Return more useful config attributes

2016-10-14 Thread Andy Furniss
Andy Furniss wrote: Mark Thompson wrote: On 13/10/16 08:20, Christian König wrote: Am 13.10.2016 um 00:52 schrieb Mark Thompson: The encoder attributes are needed for a user of the encoder to be able to configure it sensibly without internal knowledge. Reviewed-by: Christian König for the w

Re: [Mesa-dev] [PATCH] anv: fix enumeration of properties

2016-10-14 Thread Emil Velikov
On 6 October 2016 at 14:12, Emil Velikov wrote: > From: Emil Velikov > > Driver should enumerate only up-to min2(num_available, num_requested) > properties and return VK_INCOMPLETE if the # of requested props is > smaller than the ones available. > > Presently we assert out in such cases. > > Ins

Re: [Mesa-dev] [PATCH] mesa_glinterop: allow building without X and related headers

2016-10-14 Thread Emil Velikov
On 12 October 2016 at 22:19, Vinson Lee wrote: > Builds okay with this patch for me. > Smashing. Thanks for the testing gents ! Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/5] st/va: Return more useful config attributes

2016-10-14 Thread Christian König
Am 13.10.2016 um 11:06 schrieb Mark Thompson: On 13/10/16 08:20, Christian König wrote: Am 13.10.2016 um 00:52 schrieb Mark Thompson: The encoder attributes are needed for a user of the encoder to be able to configure it sensibly without internal knowledge. Reviewed-by: Christian König for th

Re: [Mesa-dev] [PATCH v3 25/25] configure.ac: Add required LLVM versions to the top

2016-10-14 Thread Emil Velikov
On 14 October 2016 at 09:45, Michel Dänzer wrote: > On 14/10/16 05:14 PM, Emil Velikov wrote: >> On 14 October 2016 at 01:45, Michel Dänzer wrote: >>> On 13/10/16 07:14 PM, Emil Velikov wrote: On 13 October 2016 at 04:07, Michel Dänzer wrote: > On 13/10/16 03:37 AM, Tobias Droste wrote:

Re: [Mesa-dev] [PATCH v3] doc/features.txt: factor out i965/hsw+ & radeonsi as GL45 complete

2016-10-14 Thread Eero Tamminen
Hi, On 14.10.2016 07:35, Edward O'Callaghan wrote: V2. add i965/hsw+ to list V3. rebased on master. Signed-off-by: Edward O'Callaghan --- docs/features.txt | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index 0d6c16

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Perform check for valid fbconfig against proper X-Screen.

2016-10-14 Thread Emil Velikov
On 12 October 2016 at 18:40, Emil Velikov wrote: > On 11 October 2016 at 19:42, Mario Kleiner wrote: >> Tested to fix context creation failure on a dual-x-screen setup. >> >> Signed-off-by: Mario Kleiner >> Cc: "11.2 12.0" > Reviewed-by: Emil Velikov > ... and pushed to master. Mario, can yo

Re: [Mesa-dev] [PATCH 0/6] EGL_MESA_platform_surfaceless (v2)

2016-10-14 Thread Emil Velikov
On 13 October 2016 at 23:06, Chad Versace wrote: > Mesa's EGL has supported Chrome OS's "surfaceless" platform for many > months, but the behavior of that platform has never been documented. > Here's my attempt to fix that. > > I've already committed the draft extension spec into the private Khron

Re: [Mesa-dev] [PATCH v3 25/25] configure.ac: Add required LLVM versions to the top

2016-10-14 Thread Michel Dänzer
On 14/10/16 05:14 PM, Emil Velikov wrote: > On 14 October 2016 at 01:45, Michel Dänzer wrote: >> On 13/10/16 07:14 PM, Emil Velikov wrote: >>> On 13 October 2016 at 04:07, Michel Dänzer wrote: On 13/10/16 03:37 AM, Tobias Droste wrote: > Am Mittwoch, 12. Oktober 2016, 11:53:50 CEST schri

Re: [Mesa-dev] [PATCH v3 25/25] configure.ac: Add required LLVM versions to the top

2016-10-14 Thread Emil Velikov
On 14 October 2016 at 01:45, Michel Dänzer wrote: > On 13/10/16 07:14 PM, Emil Velikov wrote: >> On 13 October 2016 at 04:07, Michel Dänzer wrote: >>> On 13/10/16 03:37 AM, Tobias Droste wrote: Am Mittwoch, 12. Oktober 2016, 11:53:50 CEST schrieb Emil Velikov: >> >> +LLVM_VERSION_REQ