Re: [Mesa-dev] [PATCH] radv: handle image transitions for fmasks

On Thu, Oct 20, 2016 at 4:07 AM, Dave Airlie wrote: > From: Dave Airlie > > This fixes > dEQP-VK.pipeline.multisample.sampled_image* > > These all render to multisampled image, and then > sample from it, so we must transition it correctly. > > Cc: "13.0"

Re: [Mesa-dev] [PATCH 0/2] glsl/es31: precision qualifier doesn't need to match in shader interface block members

Hi; On 10/19/2016 09:06 AM, Samuel Iglesias Gonsálvez wrote: Hello, The last patch of this series fixes one dEQP-GLES31 test [0] (bug [1]). GLSL ES 3.1 spec allows mismatching of precision qualifiers for shader interface block members (uniform blocks and shader storage blocks). However, in

Re: [Mesa-dev] [PATCH 02/16] loader: slim down loader_get_pci_id_for_fd implementation(s)

On Sat, Oct 15, 2016 at 01:32:02PM +0100, Emil Velikov wrote: > On Saturday, 15 October 2016, Jonathan Gray wrote: > > > On Tue, Oct 11, 2016 at 07:31:46PM +0100, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > > Currently mesa

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #40 from Suzuki, Shinji --- Sorry I misunderstood your question and thought that you are asking if my modification works or not. Your patch should work if mine works because yours has tighter serialization.

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #39 from Michel Dänzer --- Well, it seems to be the best test case we have so far, and it's the most relevant one for this bug report. :) -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

https://bugs.freedesktop.org/show_bug.cgi?id=98172 --- Comment #38 from Suzuki, Shinji --- As you saw, now I'm running my app without locking on the first block of code but with locking on the second. So far so good. But my application is streaming video processing. I

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

https://bugs.freedesktop.org/show_bug.cgi?id=98172 Michel Dänzer changed: What|Removed |Added Attachment #127267|0 |1 is

[Mesa-dev] [PATCH v2] nv50, nvc0: don't keep track of whether fb rt0 is integer-only

This reverts commits 1af0641db345209c076e9b1ba4dca7524541671a and a6ad49cbbd599aec054d0a3163fff5ad724f2b18. st/mesa adjusts the rasterizer state for us now. Signed-off-by: Ilia Mirkin --- v1 -> v2: also revert the nv50 commit

[Mesa-dev] [PATCH] nvc0: don't keep track of whether fb rt0 is integer-only

This reverts commit 1af0641db345209c076e9b1ba4dca7524541671a. st/mesa adjusts the rasterizer state for us now. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 10 ++ .../drivers/nouveau/nvc0/nvc0_state_validate.c | 21

[Mesa-dev] [PATCH] radv: handle image transitions for fmasks

From: Dave Airlie This fixes dEQP-VK.pipeline.multisample.sampled_image* These all render to multisampled image, and then sample from it, so we must transition it correctly. Cc: "13.0" Signed-off-by: Dave Airlie ---

Re: [Mesa-dev] [PATCH] util: Include string.h in bitscan.h.

On Thu, 2016-10-20 at 01:14 +, Vinson Lee wrote: > Fix build error with clang. > >   Compiling src/compiler/glsl/link_varyings.cpp ... > In file included from src/compiler/glsl/link_varyings.cpp:33: > In file included from src/compiler/glsl/glsl_symbol_table.h:34: > In file included from

[Mesa-dev] [PATCH] util: Include string.h in bitscan.h.

Fix build error with clang. Compiling src/compiler/glsl/link_varyings.cpp ... In file included from src/compiler/glsl/link_varyings.cpp:33: In file included from src/compiler/glsl/glsl_symbol_table.h:34: In file included from src/compiler/glsl/ir.h:33: In file included from

Re: [Mesa-dev] [PATCH 13/22] anv/wsi: split image alloc/free out to separate fns.

>> -fail_image: >> - anv_DestroyImage(vk_device, vk_image, pAllocator); >> + chain->base.image_fns->free_wsi_image(vk_device, pAllocator, >> + image->image, image->memory); > > Coverity points out that this code is unreachable. Should it be > removed,

Re: [Mesa-dev] [PATCH 6/6] vbo: clean up with 'indent', whitespace fixes, etc in vbo_exec_array.c

On 10/19/2016 06:18 PM, Charmaine Lee wrote: Series looks fine to me. Some minor nit below. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, October 19, 2016 3:07 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH

Re: [Mesa-dev] [PATCH 6/6] vbo: clean up with 'indent', whitespace fixes, etc in vbo_exec_array.c

Series looks fine to me. Some minor nit below. Reviewed-by: Charmaine Lee >From: Brian Paul >Sent: Wednesday, October 19, 2016 3:07 PM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee >Subject: [PATCH 6/6] vbo: clean up with 'indent',

Re: [Mesa-dev] [PATCH] glsl: Skip invariant/precision linker checks for built-in variables.

On Wed, Oct 19, 2016 at 3:44 PM, Ian Romanick wrote: > On 10/19/2016 02:31 PM, Kenneth Graunke wrote: > > On Wednesday, October 19, 2016 1:40:39 PM PDT Ian Romanick wrote: > >> On 10/19/2016 11:11 AM, Kenneth Graunke wrote: > >>> Brian found a bug with my "inline built-ins

[Mesa-dev] [PATCH 33/42] st/mesa: get interpolation location at translation time

Rather then messing around creating bitfields and arrays to store the interpolation location just translate it on the fly. Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 22 ++ src/mesa/state_tracker/st_glsl_to_tgsi.h | 1 -

[Mesa-dev] [PATCH 31/42] compiler: don't bother setting INTERP_MODE_NONE to 0

Now that the InterpQualifier array has been removed we don't need to bother with this. --- src/compiler/shader_enums.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/compiler/shader_enums.h b/src/compiler/shader_enums.h index b6e048e..aa97691 100644 ---

[Mesa-dev] [PATCH 37/42] i965: replace brw_vertex_program with new generic brw_program

--- src/mesa/drivers/dri/i965/brw_context.h | 17 + src/mesa/drivers/dri/i965/brw_program.c | 8 src/mesa/drivers/dri/i965/brw_vs.c | 10 -- src/mesa/drivers/dri/i965/brw_vs.h | 2 +-

[Mesa-dev] [PATCH 09/42] i965/mesa/st: eliminate gl_tess_ctrl_program

We now get all the tcs metadata from shader_info. --- src/mesa/drivers/dri/i965/brw_context.h | 6 +++--- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- src/mesa/drivers/dri/i965/brw_program.c | 2 +- src/mesa/drivers/dri/i965/brw_tcs.c | 13

[Mesa-dev] [PATCH 40/42] i965: replace brw_fragment_program with brw_program

--- src/mesa/drivers/dri/i965/brw_context.h | 21 + src/mesa/drivers/dri/i965/brw_program.c | 10 +- src/mesa/drivers/dri/i965/brw_wm.c | 10 -- src/mesa/drivers/dri/i965/brw_wm.h | 2 +-

[Mesa-dev] [PATCH 32/42] i965: remove unused debug param

This was accidently disabled in 832bcc3613 not long after it was added. Since it's only for gen5 and lower we might as well just remove it rather than fixing it. --- src/mesa/drivers/dri/i965/brw_interpolation_map.c | 3 ++- src/mesa/drivers/dri/i965/intel_debug.h | 31

[Mesa-dev] [PATCH 39/42] i965: replace brw_tess_{eval, ctrl}_program with brw_program

--- src/mesa/drivers/dri/i965/brw_context.h | 26 --- src/mesa/drivers/dri/i965/brw_program.c | 24 ++--- src/mesa/drivers/dri/i965/brw_tcs.c | 17 ++- src/mesa/drivers/dri/i965/brw_tcs_surface_state.c | 3 +--

[Mesa-dev] [PATCH 29/42] i965: remove unused BRW_STATE_INTERPOLATION_MAP flag

--- src/mesa/drivers/dri/i965/brw_context.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h index ba8b254..519c198 100644 --- a/src/mesa/drivers/dri/i965/brw_context.h +++

[Mesa-dev] [PATCH 27/42] st/mesa: stop making use of InterpQualifier array

A following patch is going to merge the gl_fragment_program struct into a common gl_program and we want to avoid all stages having this array. V2: use TGSI_INTERPOLATE_COUNT as the temporary placeholder. Suggested by Marek. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 33

[Mesa-dev] [PATCH 38/42] i965: replace brw_geomerty_program with brw_program

--- src/mesa/drivers/dri/i965/brw_compiler.h | 2 +- src/mesa/drivers/dri/i965/brw_context.h | 13 - src/mesa/drivers/dri/i965/brw_gs.c | 10 -- src/mesa/drivers/dri/i965/brw_gs.h | 2 +-

[Mesa-dev] [PATCH 20/42] i965: switch vs over to shared shader_info

Note we access shader_info from the program struct rather than the nir_shader pointer because shader cache won't create a nir_shader. --- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- src/mesa/drivers/dri/i965/brw_vs.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 23/42] st/mesa: switch cs over to shared shader_info

--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 11 --- src/mesa/state_tracker/st_program.c| 2 +- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 281f724..61a461d

[Mesa-dev] [PATCH 41/42] i965: replace brw_compute_program with brw_program

--- src/mesa/drivers/dri/i965/brw_context.h | 13 - src/mesa/drivers/dri/i965/brw_cs.c| 10 -- src/mesa/drivers/dri/i965/brw_program.c | 14 ++ src/mesa/drivers/dri/i965/gen7_cs_state.c | 6 ++ 4 files changed, 8 insertions(+), 35 deletions(-)

[Mesa-dev] [PATCH 19/42] i965/mesa/st: eliminate gl_geometry_program

We now get all the gs metadata from shader_info. --- src/mesa/drivers/dri/i965/brw_context.h | 6 +++--- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- src/mesa/drivers/dri/i965/brw_gs.c | 19 --- src/mesa/drivers/dri/i965/brw_gs_surface_state.c

[Mesa-dev] [PATCH 34/42] mesa: remove now unused IsCentroid from gl_fragment_program

--- src/compiler/glsl/ir_set_program_inouts.cpp | 6 +- src/mesa/main/mtypes.h | 6 -- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/src/compiler/glsl/ir_set_program_inouts.cpp b/src/compiler/glsl/ir_set_program_inouts.cpp index baa52b1..a177219

[Mesa-dev] [PATCH 17/42] st/mesa: switch gs over to shared shader_info

--- src/mesa/state_tracker/st_program.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tracker/st_program.c index 7804452..0a80568 100644 --- a/src/mesa/state_tracker/st_program.c +++

[Mesa-dev] [PATCH 25/42] i965/mesa/st: eliminate gl_compute_program

--- src/mesa/drivers/dri/i965/brw_context.h | 6 +++--- src/mesa/drivers/dri/i965/brw_cs.c| 22 ++ src/mesa/drivers/dri/i965/brw_program.c | 2 +- src/mesa/drivers/dri/i965/gen7_cs_state.c | 4 ++-- src/mesa/main/mtypes.h| 21

[Mesa-dev] [PATCH 36/42] st/mesa/r200/i915/i965: eliminate gl_fragment_program

Here we move OriginUpperLeft and PixelCenterInteger into gl_program all other fields have been replace by shader_info. V2: Don't use anonymous union/structs to hold vertex/fragment fields suggested by Ian. --- src/compiler/shader_info.c | 13 +

[Mesa-dev] [PATCH 30/42] glsl: remove now unused InterpQualifier

--- src/compiler/glsl/ir_set_program_inouts.cpp | 7 ++- src/mesa/main/mtypes.h | 7 --- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/src/compiler/glsl/ir_set_program_inouts.cpp b/src/compiler/glsl/ir_set_program_inouts.cpp index f5b36df..baa52b1

[Mesa-dev] [PATCH 42/42] meta: remove remaining tabs in meta.c

--- src/mesa/drivers/common/meta.c | 98 +- 1 file changed, 49 insertions(+), 49 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index f7240f4..7d131b6 100644 --- a/src/mesa/drivers/common/meta.c +++

[Mesa-dev] [PATCH 35/42] i965/mesa/st/swrast: set fs shader_info directly and switch to using it

Note we access shader_info from the program struct rather than the nir_shader pointer because shader cache won't create a nir_shader. --- src/compiler/glsl/ir_set_program_inouts.cpp | 14 -- src/compiler/shader_info.c | 3 ---

[Mesa-dev] [PATCH 05/42] glsl: add temporary copy_shader_info() function

This function is added here to ease refactoring towards using the new shared shader_info. Once refactoring is complete and values are set directly it will be removed. We call it from _mesa_copy_linked_program_data() rather than glsl_to_nir() so that the values will be set for all drivers. In

[Mesa-dev] [PATCH 28/42] i965: rewrite brw_setup_vue_interpolation()

Here brw_setup_vue_interpolation() is rewritten not to use the InterpQualifier array in gl_fragment_program which will allow us to remove it. This change also makes the code which is only used by gen4/5 more self contained as it now has its own gen5_fragment_program struct rather than storing the

[Mesa-dev] [PATCH 26/42] mesa: remove unrequired code

InterpQualifier is never set for ARB programs so this will do nothing. --- src/mesa/program/prog_to_nir.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/program/prog_to_nir.c b/src/mesa/program/prog_to_nir.c index 2f589ce..1192207 100644 --- a/src/mesa/program/prog_to_nir.c +++

[Mesa-dev] [PATCH 18/42] mesa: set gs shader_info metadata directly

--- src/compiler/shader_info.c | 10 -- src/mesa/main/shaderapi.c | 16 +++- 2 files changed, 7 insertions(+), 19 deletions(-) diff --git a/src/compiler/shader_info.c b/src/compiler/shader_info.c index fc4484a..22ea3a6 100644 --- a/src/compiler/shader_info.c +++

[Mesa-dev] [PATCH 21/42] mesa/i965/i915/r200: eliminate gl_vertex_program

Here we move the only field in gl_vertex_program to the ARB program fields in gl_program. --- src/mesa/drivers/common/meta.c | 10 +-- src/mesa/drivers/common/meta.h | 2 +- src/mesa/drivers/dri/i915/i915_fragprog.c| 4 +-

[Mesa-dev] [PATCH 22/42] compiler: add additional cs metadata fields to shader info

And copy values from GLSL. --- src/compiler/shader_info.c | 1 + src/compiler/shader_info.h | 5 + 2 files changed, 6 insertions(+) diff --git a/src/compiler/shader_info.c b/src/compiler/shader_info.c index 22ea3a6..20422ef 100644 --- a/src/compiler/shader_info.c +++

[Mesa-dev] [PATCH 24/42] mesa: set cs shader_info metadata directly

--- src/compiler/shader_info.c | 9 - src/mesa/main/shaderapi.c | 8 +++- 2 files changed, 3 insertions(+), 14 deletions(-) diff --git a/src/compiler/shader_info.c b/src/compiler/shader_info.c index 20422ef..9329e51 100644 --- a/src/compiler/shader_info.c +++

[Mesa-dev] [PATCH 13/42] mesa: copy tes metadata directly to shared shader info

--- src/compiler/shader_info.c | 11 --- src/mesa/main/shaderapi.c | 11 --- 2 files changed, 4 insertions(+), 18 deletions(-) diff --git a/src/compiler/shader_info.c b/src/compiler/shader_info.c index 3ec1e8a..2da9757 100644 --- a/src/compiler/shader_info.c +++

[Mesa-dev] [PATCH 15/42] compiler: add input primative field for gs in shader info

And copy the value from GLSL. --- src/compiler/shader_info.c | 1 + src/compiler/shader_info.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/compiler/shader_info.c b/src/compiler/shader_info.c index 2da9757..fc4484a 100644 --- a/src/compiler/shader_info.c +++

[Mesa-dev] [PATCH 16/42] i965: switch gs over to shared shader_info

Note we access shader_info from the program struct rather than the nir_shader pointer because shader cache won't create a nir_shader. --- src/mesa/drivers/dri/i965/brw_gs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_gs.c

[Mesa-dev] [PATCH 14/42] i965/mesa/st: eliminate gl_tess_eval_program

We now get all the tes metadata from shader_info. --- src/mesa/drivers/dri/i965/brw_context.h | 6 +++--- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- src/mesa/drivers/dri/i965/brw_program.c | 2 +- src/mesa/drivers/dri/i965/brw_tcs.c | 8

[Mesa-dev] [PATCH 08/42] mesa: set tcs shader_info metadata directly

--- src/compiler/shader_info.c | 4 src/mesa/main/shaderapi.c | 4 +--- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/compiler/shader_info.c b/src/compiler/shader_info.c index ebd9caf..2da9757 100644 --- a/src/compiler/shader_info.c +++ b/src/compiler/shader_info.c @@

[Mesa-dev] [PATCH 06/42] i965: switch tcs over to shared shader_info

Note we access shader_info from the program struct rather than the nir_shader pointer because shader cache won't create a nir_shader. --- src/mesa/drivers/dri/i965/brw_tcs.c | 19 --- src/mesa/drivers/dri/i965/brw_tes.c | 20 +--- 2 files changed, 17 insertions(+),

[Mesa-dev] [PATCH 10/42] compiler: add fields for tes metadata to shader info

And copy the values from gl_tess_eval_program struct. --- src/compiler/shader_info.c | 11 +++ src/compiler/shader_info.h | 7 +++ 2 files changed, 18 insertions(+) diff --git a/src/compiler/shader_info.c b/src/compiler/shader_info.c index 2da9757..3ec1e8a 100644 ---

[Mesa-dev] [PATCH 04/42] glsl: add a shader info field to the gl_program type

And use this field as the source for shader info in the nir_shader this will allow us to set some of these fields from GLSL directly. It will also simplify restoring from shader cache and allow the removal of duplicate fields from GLSL. --- src/compiler/glsl/glsl_to_nir.cpp | 3 ++-

[Mesa-dev] [PATCH 07/42] st/mesa: switch tcs over to shared shader_info

--- src/mesa/program/prog_statevars.c | 2 +- src/mesa/state_tracker/st_program.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/program/prog_statevars.c b/src/mesa/program/prog_statevars.c index 6e6007e..86bbd0a 100644 --- a/src/mesa/program/prog_statevars.c

[Mesa-dev] [PATCH 11/42] i965: switch tes over to shared shader_info

Note we access shader_info from the program struct rather than the nir_shader pointer because shader cache won't create a nir_shader. --- src/mesa/drivers/dri/i965/brw_tcs.c | 6 +++--- src/mesa/drivers/dri/i965/brw_tes.c | 10 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff

[Mesa-dev] [PATCH 12/42] st/mesa: switch tes over to shared shader_info

--- src/mesa/state_tracker/st_program.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tracker/st_program.c index cb40211..210aa33 100644 --- a/src/mesa/state_tracker/st_program.c +++

[Mesa-dev] [PATCH mesa] wsi/wayland: fix error path

Fixes: 1720bbd353d87412754f ("anv/wsi: split image alloc/free out to separate fns.") Cc: Dave Airlie Signed-off-by: Eric Engestrom --- I'm not sure this is the right fix. The other thing I'm starting to lean toward is to just remove these last two

[Mesa-dev] V3 Shared shader info

V3: - create a temporary copy_shader_info() helper and split up the changes in this series for easier review as suggested by Jason/Ken. - a couple of small changes as suggested by Ian and Marek (more details in patches). Having the shader info struct in nir_shader makes things difficult for

[Mesa-dev] [PATCH 02/42] nir: move nir_shader_info to a common compiler header

This will allow use to stop copying values between structs and will also simplify handling handling these values in the shader cache. --- src/compiler/nir/nir.h | 98 +-- src/compiler/shader_info.h | 131

[Mesa-dev] [PATCH 01/42] mesa: modify _mesa_copy_linked_program_data() to take gl_linked_shader

This allows us to do some small tidy ups, but will also allow us to call a new function that copies values to a shared shader info from here. In order to make this change this function now requires _mesa_reference_program() to have previously been called. ---

Re: [Mesa-dev] [PATCH] nvc0: do not break 3D state by pushing MS coordinates on Fermi

On 10/20/2016 12:55 AM, Ilia Mirkin wrote: On Wed, Oct 19, 2016 at 6:46 PM, Samuel Pitoiset wrote: Long short story, 3D and CP are aliased on Fermi and initializing compute after pushing the MS sample coordinate offsets seems to corrupt 3D state for weird reasons.

Re: [Mesa-dev] [PATCH] nvc0: do not break 3D state by pushing MS coordinates on Fermi

On Wed, Oct 19, 2016 at 6:46 PM, Samuel Pitoiset wrote: > Long short story, 3D and CP are aliased on Fermi and initializing > compute after pushing the MS sample coordinate offsets seems to > corrupt 3D state for weird reasons. > > I still don't have the faintest clue

[Mesa-dev] [PATCH 4/6] vbo: minor clean-up in vbo_exec_api.c

--- src/mesa/vbo/vbo_exec_api.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_api.c b/src/mesa/vbo/vbo_exec_api.c index b191a94..895f197 100644 --- a/src/mesa/vbo/vbo_exec_api.c +++ b/src/mesa/vbo/vbo_exec_api.c @@ -48,11 +48,6 @@ USE OR OTHER

[Mesa-dev] [PATCH 6/6] vbo: clean up with 'indent', whitespace fixes, etc in vbo_exec_array.c

--- src/mesa/vbo/vbo_exec_array.c | 537 ++ 1 file changed, 281 insertions(+), 256 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index dc1ef76..dcdbb6a 100644 --- a/src/mesa/vbo/vbo_exec_array.c +++

[Mesa-dev] [PATCH 5/6] vbo: whitespace fixes and reformatting in vbo_exec_api.c

--- src/mesa/vbo/vbo_exec_api.c | 106 ++-- 1 file changed, 64 insertions(+), 42 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_api.c b/src/mesa/vbo/vbo_exec_api.c index 895f197..cbf78b4 100644 --- a/src/mesa/vbo/vbo_exec_api.c +++

[Mesa-dev] [PATCH 2/6] vbo: rename reset_attrfv() to vbo_reset_all_attr()

Use a better name. --- src/mesa/vbo/vbo_exec_api.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_api.c b/src/mesa/vbo/vbo_exec_api.c index 6df8d88..c0a5bc0 100644 --- a/src/mesa/vbo/vbo_exec_api.c +++ b/src/mesa/vbo/vbo_exec_api.c @@ -57,7

[Mesa-dev] [PATCH 3/6] vbo: move attribute type assignment

If the attribute type is changing, we would have found that earlier in the ATTR_UNION() macro and would have called vbo_exec_fixup_vertex(). So move the assignment into that function so we don't do it every time. No Piglit regressions. --- src/mesa/vbo/vbo_exec_api.c | 3 ++- 1 file changed, 2

[Mesa-dev] [PATCH 1/6] vbo: make vbo_reset_attr() static

Not called from any other file. --- src/mesa/vbo/vbo_exec.h | 2 -- src/mesa/vbo/vbo_exec_api.c | 6 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_exec.h b/src/mesa/vbo/vbo_exec.h index 4f11f17..b150883 100644 --- a/src/mesa/vbo/vbo_exec.h +++

[Mesa-dev] [PATCH] nvc0: do not break 3D state by pushing MS coordinates on Fermi

Long short story, 3D and CP are aliased on Fermi and initializing compute after pushing the MS sample coordinate offsets seems to corrupt 3D state for weird reasons. I still don't have the faintest clue what is going on, but this seems to only affect Fermi generation. A possible fix could be to

Re: [Mesa-dev] [PATCH] glsl: Skip invariant/precision linker checks for built-in variables.

On 10/19/2016 02:31 PM, Kenneth Graunke wrote: > On Wednesday, October 19, 2016 1:40:39 PM PDT Ian Romanick wrote: >> On 10/19/2016 11:11 AM, Kenneth Graunke wrote: >>> Brian found a bug with my "inline built-ins immediately" code for shaders >>> which use ftransform() and declare gl_Position

Re: [Mesa-dev] [PATCH] egl/dri2: add a libname to dlopen for OpenBSD

On Wed, Oct 19, 2016 at 03:17:07PM +0100, Emil Velikov wrote: > On 19 October 2016 at 14:16, Jonathan Gray wrote: > > On Wed, Oct 19, 2016 at 10:29:47AM +0100, Emil Velikov wrote: > >> On 19 October 2016 at 01:05, Jonathan Gray wrote: > >> > On Tue, Oct 18, 2016

Re: [Mesa-dev] [PATCH] mesa: avoid pthread_mutexes when adjusting object refcounts

On 10/19/2016 12:58 PM, Matt Turner wrote: > On Wed, Oct 19, 2016 at 12:06 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: >> This patch removes locks around reference counts in favor of atomic inc/dec >> operations on the refcounts. This makes the refcount adjustments much faster. > > I had the

Re: [Mesa-dev] [PATCH] mesa: avoid pthread_mutexes when adjusting object refcounts

On Wed, Oct 19, 2016 at 1:58 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: > The current git code and the patched code are fully equivalent to each > other. In the unpatched code RefCount is always protected by a mutex > and the RefCount adjustment region protects just the RefCount (it > doesn't

[Mesa-dev] [PATCH 2/2] radeonsi: fix build of si_eliminate_const_vs_outputs on LLVM <= 3.8

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index a810d9a..30e45cc 100644 ---

[Mesa-dev] [PATCH 1/2] gallivm: add wrappers for missing functions in LLVM <= 3.8

From: Marek Olšák radeonsi needs these. --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 21 + src/gallium/auxiliary/gallivm/lp_bld_misc.h | 6 ++ 2 files changed, 27 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp

[Mesa-dev] [Bug 98168] [vulkan, radv] Talos rendering glitches on Ultra settings on Tonga

https://bugs.freedesktop.org/show_bug.cgi?id=98168 Dave Airlie changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH v2 4/4] anv: setup appropriate border color structures on gen7/gen75

On Wed, Oct 19, 2016 at 8:50 AM, Lionel Landwerlin wrote: > Up to this point we were using the gen8+ structures to program border > colors. This commit sets up the correct border colors for HSW & IVB. > > On HSW: >This fixes 140 failures of : >

Re: [Mesa-dev] [PATCH 2/3] nvc0/ir: remove useless NVC0LoweringPass::gMemBase

On 10/19/2016 11:41 PM, Ilia Mirkin wrote: On Wed, Oct 19, 2016 at 5:33 PM, Samuel Pitoiset wrote: On 10/19/2016 11:29 PM, Ilia Mirkin wrote: It avoids creating a ton of symbols unnecessarily during the lifetime of the pass. Does it hurt anything? I think

Re: [Mesa-dev] [PATCH 2/3] nvc0/ir: remove useless NVC0LoweringPass::gMemBase

On Wed, Oct 19, 2016 at 5:33 PM, Samuel Pitoiset wrote: > > > On 10/19/2016 11:29 PM, Ilia Mirkin wrote: >> >> It avoids creating a ton of symbols unnecessarily during the lifetime >> of the pass. Does it hurt anything? > > > I think either we use that symbol everywhere

Re: [Mesa-dev] [PATCH 3/3] nvc0/ir: simplify predicate logic for GK104 atomic operations

I'd feel better if there were a assert(su->getPredicate()) in there. With that, Reviewed-by: Ilia Mirkin On Wed, Oct 19, 2016 at 5:21 PM, Samuel Pitoiset wrote: > The predicate is always CC_NOT_P as defined in > processSurfaceCoordsNVE4(), so we

Re: [Mesa-dev] [PATCH 2/3] nvc0/ir: remove useless NVC0LoweringPass::gMemBase

On 10/19/2016 11:29 PM, Ilia Mirkin wrote: It avoids creating a ton of symbols unnecessarily during the lifetime of the pass. Does it hurt anything? I think either we use that symbol everywhere we can, or we simply remove it. We don't even use it for GF100 atomic operations. On Wed, Oct

Re: [Mesa-dev] [PATCH] glsl: Skip invariant/precision linker checks for built-in variables.

On Wednesday, October 19, 2016 1:40:39 PM PDT Ian Romanick wrote: > On 10/19/2016 11:11 AM, Kenneth Graunke wrote: > > Brian found a bug with my "inline built-ins immediately" code for shaders > > which use ftransform() and declare gl_Position invariant: > > > >

Re: [Mesa-dev] [PATCH] i965/cs: Don't use a thread channel ID for small local sizes

On 10/19/2016 02:26 PM, Jordan Justen wrote: > On 2016-10-19 13:47:35, Ian Romanick wrote: >> On 10/19/2016 12:45 PM, Jordan Justen wrote: >>> When the local group size is 8 or less, we will execute the program at >>> most 1 time. Therefore, the local channel ID will always be 0. By >>> using a

Re: [Mesa-dev] [PATCH 2/3] nvc0/ir: remove useless NVC0LoweringPass::gMemBase

It avoids creating a ton of symbols unnecessarily during the lifetime of the pass. Does it hurt anything? On Wed, Oct 19, 2016 at 5:21 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH 01/26] i965/meta: Split conversion of color and setting it

On 16-10-11 22:26:33, Topi Pohjolainen wrote: And fix a mangled comment while at it. Signed-off-by: Topi Pohjolainen CC: Ben Widawsky CC: Jason Ekstrand --- src/mesa/drivers/dri/i965/brw_blorp.c | 7 +++-

Re: [Mesa-dev] [PATCH] glsl: Skip invariant/precision linker checks for built-in variables.

On 10/19/2016 02:17 PM, Brian Paul wrote: > On 10/19/2016 02:40 PM, Ian Romanick wrote: >> On 10/19/2016 11:11 AM, Kenneth Graunke wrote: >>> Brian found a bug with my "inline built-ins immediately" code for >>> shaders >>> which use ftransform() and declare gl_Position invariant: >>> >>>

Re: [Mesa-dev] [PATCH 1/3] nv50/ir: print CCTL subops in debug mode

Reviewed-by: Ilia Mirkin On Wed, Oct 19, 2016 at 5:21 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_print.cpp | 9 + > 1 file changed, 9

Re: [Mesa-dev] [PATCH] i965: Skip register write checks if cmd_parser_version >= 2.

On Wednesday, October 19, 2016 8:35:11 PM PDT Chris Wilson wrote: > On Wed, Oct 19, 2016 at 12:25:51PM -0700, Kenneth Graunke wrote: > > If the kernel advertises a new enough command parser version, then we > > can just assume that register writes will work and not bother executing > > commands on

Re: [Mesa-dev] [PATCH] i965/cs: Don't use a thread channel ID for small local sizes

On 2016-10-19 13:47:35, Ian Romanick wrote: > On 10/19/2016 12:45 PM, Jordan Justen wrote: > > When the local group size is 8 or less, we will execute the program at > > most 1 time. Therefore, the local channel ID will always be 0. By > > using a constant 0 in this case we can prevent using push

[Mesa-dev] [PATCH 3/3] nvc0/ir: simplify predicate logic for GK104 atomic operations

The predicate is always CC_NOT_P as defined in processSurfaceCoordsNVE4(), so we only want to emit OR. Signed-off-by: Samuel Pitoiset --- .../nouveau/codegen/nv50_ir_lowering_nvc0.cpp| 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-)

[Mesa-dev] [PATCH 2/3] nvc0/ir: remove useless NVC0LoweringPass::gMemBase

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp

[Mesa-dev] [PATCH 1/3] nv50/ir: print CCTL subops in debug mode

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_print.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_print.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_print.cpp index

Re: [Mesa-dev] [PATCH] glsl: compute lvalues of [in]out parameters before inlined function body

On 10/19/2016 11:45 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This is required when an out argument involves an array index that is either > a global variable modified by the function or another out argument in the > same function call. > > Fixes the

Re: [Mesa-dev] [PATCH] radeonsi: fix 64-bit loads from LDS

Reviewed-by: Marek Olšák Marek On Wed, Oct 19, 2016 at 8:38 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fixes spec/arb_tessellation_shader/execution/dvec[23]-vs-tcs-tes, among > others. > > Cc:

Re: [Mesa-dev] [PATCH] glsl: Skip invariant/precision linker checks for built-in variables.

On 10/19/2016 02:40 PM, Ian Romanick wrote: On 10/19/2016 11:11 AM, Kenneth Graunke wrote: Brian found a bug with my "inline built-ins immediately" code for shaders which use ftransform() and declare gl_Position invariant:

Re: [Mesa-dev] [PATCH] st/mesa: only set primitive_restart when the restart index is in range

On Wed, Oct 19, 2016 at 8:39 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Even when enabled, primitive restart has no effect when the restart index > is larger than the representable values in the index buffer. > > Fixes

[Mesa-dev] [PATCH] mesa: avoid pthread_mutexes when adjusting object refcounts

This patch removes locks around reference counts in favor of atomic inc/dec operations on the refcounts. This makes the refcount adjustments much faster. The set of GL objects benefiting from this patch corresponds to the names of the patched files. The new code benefits applications in which

Re: [Mesa-dev] [PATCH] mesa: avoid pthread_mutexes when adjusting object refcounts

The current git code and the patched code are fully equivalent to each other. In the unpatched code RefCount is always protected by a mutex and the RefCount adjustment region protects just the RefCount (it doesn't protect anything else) - in the patched code RefCount is always adjusted via

Re: [Mesa-dev] [PATCH] i965/cs: Don't use a thread channel ID for small local sizes

On 10/19/2016 12:45 PM, Jordan Justen wrote: > When the local group size is 8 or less, we will execute the program at > most 1 time. Therefore, the local channel ID will always be 0. By > using a constant 0 in this case we can prevent using push constant > data. > > This is not expected to be

Re: [Mesa-dev] [PATCH] i965/cs: Use udiv/umod for local IDs

Since I believe the index must always be >= 0, this looks correct. Reviewed-by: Ian Romanick On 10/19/2016 12:40 PM, Jordan Justen wrote: > This allows for more optimizations relating to power-of-two divisions. > > Signed-off-by: Jordan Justen

Re: [Mesa-dev] [PATCH] glsl: Skip invariant/precision linker checks for built-in variables.

On 10/19/2016 11:11 AM, Kenneth Graunke wrote: > Brian found a bug with my "inline built-ins immediately" code for shaders > which use ftransform() and declare gl_Position invariant: > > https://lists.freedesktop.org/archives/mesa-dev/2016-October/132452.html > > Before my patch, things worked

  1   2   3   >