Re: [Mesa-dev] [PATCH] radv: allow cmask transitions without fast clear

2016-10-20 Thread Edward O'Callaghan
Acked-by: Edward O'Callaghan On 10/21/2016 10:36 AM, Dave Airlie wrote: > From: Dave Airlie > > This fixes > dEQP-VK.pipeline.multisample.sampled_image* > > These all render to multisampled image, and then > sample from it, so we must transition it correctly, > since we have a cmask and fmask

Re: [Mesa-dev] [PATCH 5/5] nv50/ir: detect when a SLCT is equivalent to a SET

2016-10-20 Thread Ilia Mirkin
On Fri, Oct 21, 2016 at 2:39 AM, Karol Herbst wrote: > > > On 21 October 2016 8:30:33 a.m. GMT+02:00, Ilia Mirkin > wrote: >>Signed-off-by: Ilia Mirkin >>--- >>.../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 23 >>++ >> 1 file changed, 19 insertions(+), 4 deletions(-) >>

Re: [Mesa-dev] [PATCH 5/5] nv50/ir: detect when a SLCT is equivalent to a SET

2016-10-20 Thread Karol Herbst
On 21 October 2016 8:30:33 a.m. GMT+02:00, Ilia Mirkin wrote: >Signed-off-by: Ilia Mirkin >--- >.../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 23 >++ > 1 file changed, 19 insertions(+), 4 deletions(-) > >diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephol

Re: [Mesa-dev] [PATCH v2.1] i965/gen7: expose OpenGL 4.0 on Haswell

2016-10-20 Thread Iago Toral
On Thu, 2016-10-20 at 16:25 -0700, Ian Romanick wrote: > On 10/20/2016 12:09 AM, Iago Toral Quiroga wrote: > > > > ARB_gpu_shader_fp64 was the last piece missing. Notice that some > > hardware and kernel combinations do not support pipelined register > > writes, which are required for some OpenGL

[Mesa-dev] [PATCH 5/5] nv50/ir: detect when a SLCT is equivalent to a SET

2016-10-20 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 23 ++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp index

[Mesa-dev] [PATCH 3/5] nv50/ir: it appears that OP_DISCARD can't take a join modifier

2016-10-20 Thread Ilia Mirkin
nvdisasm does not print a .S even though the bit is set. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv5

[Mesa-dev] [PATCH 2/5] nvc0/ir: use levelZero flag when the lod is set to 0

2016-10-20 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp index 68f2b15..4

[Mesa-dev] [PATCH 4/5] nv50/ir: don't carefully copy NOP values as a result of phi merging

2016-10-20 Thread Ilia Mirkin
In order to avoid impossible phi constraints, we insert moves in source BBs to allow the RA to have the flexibility it needs. However there's special logic in the RA to ignore NOPs. It's quite silly to then have logic which carefully copies NOP values into registers. Leave the LValue to be defined

[Mesa-dev] [PATCH 1/5] nv50/ir: use levelZero for non-frag tex/txp ops

2016-10-20 Thread Ilia Mirkin
radeonsi also does the same thing. I suspect that this is likely to be a no-op in reality, but it brings nouveau code closer to what the blob produces. Plus it makes sense to not try to do auto-derivatives on this. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_t

Re: [Mesa-dev] [PATCH 2/2] glsl: update default precision qualifiers when they are set in the shader

2016-10-20 Thread Samuel Iglesias Gonsálvez
On 21/10/16 07:48, Timothy Arceri wrote: > On Thu, 2016-10-20 at 12:39 +0200, Samuel Iglesias Gonsálvez wrote: >> For that, we use gls_symbol_table::set_default_precision_qualifier() >> that >> can update an existing definition or add a new one if it doesn't >> exist. >> >> Bugzilla: https://bugs

Re: [Mesa-dev] [PATCH 1/2] mesa/program: Add _mesa_symbol_table_replace_symbol()

2016-10-20 Thread Timothy Arceri
On Fri, 2016-10-21 at 15:06 +1100, Timothy Arceri wrote: > On Thu, 2016-10-20 at 12:39 +0200, Samuel Iglesias Gonsálvez wrote: > > > > This function allows to modify an existing symbol. > > > > Signed-off-by: Samuel Iglesias Gonsálvez > > --- > >  src/mesa/program/symbol_table.c | 35 > > +++

Re: [Mesa-dev] [PATCH 2/2] glsl: update default precision qualifiers when they are set in the shader

2016-10-20 Thread Timothy Arceri
On Thu, 2016-10-20 at 12:39 +0200, Samuel Iglesias Gonsálvez wrote: > For that, we use gls_symbol_table::set_default_precision_qualifier() > that > can update an existing definition or add a new one if it doesn't > exist. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97804 > Signed-of

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

2016-10-20 Thread Tapani Pälli
On 10/20/2016 09:24 PM, Marek Olšák wrote: On Thu, Oct 20, 2016 at 6:31 PM, Tapani Pälli wrote: On 10/20/2016 06:55 PM, Marek Olšák wrote: On Mon, Oct 17, 2016 at 9:03 PM, Marek Olšák wrote: Hi, The latest branch: https://cgit.freedesktop.org/~mareko/mesa/log/?h=glsl-alloc-rework2 It c

Re: [Mesa-dev] V3 Shared shader info

2016-10-20 Thread Jason Ekstrand
1-27/42 and 29-42/42 are Reviewed-by: Jason Ekstrand 28/42 will take more brain power than I can exert tonight. I'll look at it tomorrow. Thanks for working on this. I know how much pain refactoring can be. On Wed, Oct 19, 2016 at 4:09 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote

Re: [Mesa-dev] [PATCH 1/2] mesa/program: Add _mesa_symbol_table_replace_symbol()

2016-10-20 Thread Timothy Arceri
On Thu, 2016-10-20 at 12:39 +0200, Samuel Iglesias Gonsálvez wrote: > This function allows to modify an existing symbol. > > Signed-off-by: Samuel Iglesias Gonsálvez > --- >  src/mesa/program/symbol_table.c | 35 > +++ >  src/mesa/program/symbol_table.h |  3 +++ >  

[Mesa-dev] [PATCH V2] i965: remove unused BRW_STATE_INTERPOLATION_MAP flag

2016-10-20 Thread Timothy Arceri
V2: remove BRW_NEW_INTERPOLATION_MAP from dirty_bit_map --- src/mesa/drivers/dri/i965/brw_context.h | 2 -- src/mesa/drivers/dri/i965/brw_state_upload.c | 1 - 2 files changed, 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h inde

[Mesa-dev] [PATCH V2] i965: rewrite brw_setup_vue_interpolation()

2016-10-20 Thread Timothy Arceri
Here brw_setup_vue_interpolation() is rewritten not to use the InterpQualifier array in gl_fragment_program which will allow us to remove it. This change also makes the code which is only used by gen4/5 more self contained as it now has its own gen5_fragment_program struct rather than storing the

Re: [Mesa-dev] [PATCH 31/42] compiler: don't bother setting INTERP_MODE_NONE to 0

2016-10-20 Thread Timothy Arceri
On Thu, 2016-10-20 at 20:03 -0700, Jason Ekstrand wrote: > I'm not so sure we can sure about this one.  I think we also somewhat > rely on being able to memset ir_variable and nir_variable to zero as > well. Sure I can change this patch to just update the comment.  gl_fragment_program -> ir_varia

Re: [Mesa-dev] [PATCH] i965: Allow creating image from different dma_buf fds

2016-10-20 Thread Gurchetan Singh
Friendly ping ... this is not in master yet. On Wed, Aug 31, 2016 at 12:58 AM, Eric Engestrom wrote: > On Tue, Aug 30, 2016 at 04:49:53PM -0700, k...@bitplanet.net wrote: > > From: "Kristian H. Kristensen" > > > > As long as the dma_buf fds import to the same drm_intel_bo, we're fine. > > > > R

Re: [Mesa-dev] [PATCH 31/42] compiler: don't bother setting INTERP_MODE_NONE to 0

2016-10-20 Thread Jason Ekstrand
I'm not so sure we can sure about this one. I think we also somewhat rely on being able to memset ir_variable and nir_variable to zero as well. On Wed, Oct 19, 2016 at 4:09 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > Now that the InterpQualifier array has been removed we don't ne

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #22 from John --- Sorry for the late update I wanted to tests a few more things first. So I went back to a 11 mesa and rebooted before testing, no difference. I tried reverting to the DDX from back then, and disabling DRI3 (which I d

[Mesa-dev] [Bug 98271] [radeonsi]Playing videos with vdpau or vaapi hardware acceleration crashes my pc

2016-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98271 --- Comment #21 from John --- Sorry for the late update I wanted to tests a few more things first. So I went back to a 11 mesa and rebooted before testing, no difference. I tried reverting to the DDX from back then, and disabling DRI3 (which I d

Re: [Mesa-dev] [PATCH 1/3] anv: Suffix the intel_icd file with the host CPU

2016-10-20 Thread Jason Ekstrand
Dave asked for a different commit message that describes the problem a bit better: anv: Suffix the intel_icd file with the host CPU Vulkan has a multi-arch problem... The idea behind the Vulkan loader is that you have a little json file on your disk that tells the loader where to

Re: [Mesa-dev] [PATCH] glsl: Skip invariant/precision linker checks for built-in variables.

2016-10-20 Thread Francisco Jerez
Ian Romanick writes: > On 10/19/2016 04:52 PM, Jason Ekstrand wrote: >> On Wed, Oct 19, 2016 at 3:44 PM, Ian Romanick > > wrote: >> >> On 10/19/2016 02:31 PM, Kenneth Graunke wrote: >> > On Wednesday, October 19, 2016 1:40:39 PM PDT Ian Romanick wrote: >>

[Mesa-dev] [Bug 97952] /usr/include/string.h:518:12: error: exception specification in declaration does not match previous declaration

2016-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97952 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH] radv: handle image transitions for fmasks

2016-10-20 Thread Dave Airlie
On 20 October 2016 at 15:07, Bas Nieuwenhuizen wrote: > On Thu, Oct 20, 2016 at 4:07 AM, Dave Airlie wrote: >> From: Dave Airlie >> >> This fixes >> dEQP-VK.pipeline.multisample.sampled_image* >> >> These all render to multisampled image, and then >> sample from it, so we must transition it corr

[Mesa-dev] [PATCH] radv: allow cmask transitions without fast clear

2016-10-20 Thread Dave Airlie
From: Dave Airlie This fixes dEQP-VK.pipeline.multisample.sampled_image* These all render to multisampled image, and then sample from it, so we must transition it correctly, since we have a cmask and fmask this will cause the correct transition. Cc: "13.0" Signed-off-by: Dave Airlie --- src/

Re: [Mesa-dev] [PATCH v2.1] i965/gen7: expose OpenGL 4.0 on Haswell

2016-10-20 Thread Ian Romanick
On 10/20/2016 12:09 AM, Iago Toral Quiroga wrote: > ARB_gpu_shader_fp64 was the last piece missing. Notice that some > hardware and kernel combinations do not support pipelined register > writes, which are required for some OpenGL 4.0 features, in which > case the driver won't expose 4.0. > > v2 (

[Mesa-dev] [PATCH 1/3] anv: Suffix the intel_icd file with the host CPU

2016-10-20 Thread Jason Ekstrand
Vulkan has a multi-arch problem... The idea behind the Vulkan loader is that you have a little json file on your disk that tells the loader where to find drivers. The loader looks for these json files in standard locations, and then goes and loads the my_driver.so's that they specify. This allows

[Mesa-dev] [PATCH 2/3] anv: Always use the full driver path in the intel_icd.*.json

2016-10-20 Thread Jason Ekstrand
--- src/intel/vulkan/Makefile.am | 8 +--- src/intel/vulkan/intel_icd.json.in | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am index 1dee84b..ec7a638 100644 --- a/src/intel/vulkan/Makefile.am +++ b/src/inte

[Mesa-dev] [PATCH 3/3] configure: Get rid of the --disable-vulkan-icd-full-driver-path flag

2016-10-20 Thread Jason Ekstrand
--- configure.ac | 7 --- 1 file changed, 7 deletions(-) diff --git a/configure.ac b/configure.ac index 8e779d4..7619f1d 100644 --- a/configure.ac +++ b/configure.ac @@ -1667,13 +1667,6 @@ AC_ARG_WITH([vulkan-icddir], [VULKAN_ICD_INSTALL_DIR='${datarootdir}/vulkan/icd.d']) AC_SUBST([VUL

Re: [Mesa-dev] [PATCH] glsl: Skip invariant/precision linker checks for built-in variables.

2016-10-20 Thread Ian Romanick
On 10/19/2016 04:52 PM, Jason Ekstrand wrote: > On Wed, Oct 19, 2016 at 3:44 PM, Ian Romanick > wrote: > > On 10/19/2016 02:31 PM, Kenneth Graunke wrote: > > On Wednesday, October 19, 2016 1:40:39 PM PDT Ian Romanick wrote: > >> On 10/19/2016 11:11 AM, Ken

Re: [Mesa-dev] [PATCH 1/2] glapi: Move PrimitiveBoundingBox and BlendBarrier definitions into ES3.2 category.

2016-10-20 Thread Dylan Baker
Quoting Francisco Jerez (2016-10-18 20:48:51) > These two GLES 3.2 entry points were being defined in the category of > the ARB_ES3_2_compatibility and KHR_blend_equation_advanced extensions > respectively instead of in the ES3.2 category. Defining them in the > ES3.2 category makes sure that the

[Mesa-dev] [PATCH] amd/addrlib: limit fastcall/regparm to i386

2016-10-20 Thread Rob Herring
The use of regparm causes an error on arm/arm64 builds with clang. fastcall is allowed, but still throws a warning. As both options only have effect on 32-bit x86 builds, limit them to that case. Signed-off-by: Rob Herring --- src/amd/addrlib/addrtypes.h | 10 +++--- 1 file changed, 7 insert

Re: [Mesa-dev] [PATCH 2/2] st/nine: Fix leak at device dtor

2016-10-20 Thread Axel Davy
For some reason, it introduces crashes. Not sure why. I also figured out this doesn't free anything. There seems to be missing code to free the 'nine_range_pool', and we leak at every device dtor. Patch 1/2 is still an important fix to avoid leaks. On 18/10/2016 23:11, Axel Davy wrote: The dat

Re: [Mesa-dev] [PATCH v4 17/18] configure.ac: Only add default LLVM components if needed

2016-10-20 Thread Tobias Droste
Am Donnerstag, 20. Oktober 2016, 18:30:42 CEST schrieb Emil Velikov: > On 19 October 2016 at 18:55, Tobias Droste wrote: > > Am Mittwoch, 19. Oktober 2016, 14:17:53 CEST schrieb Emil Velikov: > >> On 16 October 2016 at 01:20, Tobias Droste wrote: > >> > LLVM components are only added when LLVM is

Re: [Mesa-dev] [PATCH] mesa: avoid pthread_mutexes when adjusting object refcounts

2016-10-20 Thread Jan Ziak
On Thu, Oct 20, 2016 at 12:22 AM, Matt Turner wrote: > On Wed, Oct 19, 2016 at 1:58 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: >> The current git code and the patched code are fully equivalent to each >> other. In the unpatched code RefCount is always protected by a mutex >> and the RefCount a

Re: [Mesa-dev] [ANNOUNCE] mesa 13.0.0-rc1

2016-10-20 Thread Kai Wasserbäch
Hey Emil, hey Jason, Emil Velikov wrote on 20.10.2016 17:28: > On 20 October 2016 at 16:20, Jason Ekstrand wrote: >> On Oct 20, 2016 8:11 AM, "Emil Velikov" wrote: >>> >>> On 19 October 2016 at 20:31, Jason Ekstrand wrote: On Wed, Oct 19, 2016 at 12:16 PM, Emil Velikov wrote: >>>

Re: [Mesa-dev] [PATCH v2] egl: add check that eglCreateContext gets a valid config

2016-10-20 Thread Emil Velikov
On 20 October 2016 at 18:20, Tapani Pälli wrote: > Fixes following dEQP test: > >dEQP-EGL.functional.negative_api.create_context > > v2: don't break EGL_KHR_no_config_context (Eric Engestrom) > > Signed-off-by: Tapani Pälli > --- > > Eric, the check you proposed does not work as KHR_no_config

[Mesa-dev] [PATCH 1/3] gallium/hud: fix a problem where objects are free'd while in use.

2016-10-20 Thread Steven Toth
Instead of trying to maintain a reference counted list of valid HUD objects, and freeing them accordingly, creating race conditions between unanticipated multiple threads, simply accept they're allocated once and never released until the process terminates. They're a shared resource between multip

[Mesa-dev] [PATCH 2/3] gallium/hud: fix a previously allocated handle.

2016-10-20 Thread Steven Toth
We're missing the closedir() to the matching opendir(). Signed-off-by: Steven Toth --- src/gallium/auxiliary/hud/hud_cpufreq.c | 1 + src/gallium/auxiliary/hud/hud_diskstat.c | 5 - src/gallium/auxiliary/hud/hud_nic.c | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a

[Mesa-dev] [PATCH 3/3] gallium/hud: protect against and initialization race

2016-10-20 Thread Steven Toth
In the event that multiple threads attempt to install a graph concurrently, protect the shared list. Signed-off-by: Steven Toth --- src/gallium/auxiliary/hud/hud_cpufreq.c | 12 ++-- src/gallium/auxiliary/hud/hud_diskstat.c | 13 +++-- src/gallium/auxiliary/hud/hud_nic.c

Re: [Mesa-dev] [PATCH] automake: don't forget to pick wglext.h in the tarball

2016-10-20 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

2016-10-20 Thread Marek Olšák
On Thu, Oct 20, 2016 at 6:31 PM, Tapani Pälli wrote: > On 10/20/2016 06:55 PM, Marek Olšák wrote: >> >> On Mon, Oct 17, 2016 at 9:03 PM, Marek Olšák wrote: >>> >>> Hi, >>> >>> The latest branch: >>> https://cgit.freedesktop.org/~mareko/mesa/log/?h=glsl-alloc-rework2 >>> >>> It contains: >>> - all

[Mesa-dev] [PATCH 4/7] tgsi/scan: handle indirect image indexing correctly

2016-10-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 23 +++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 2 ++ 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index 66f1fd

[Mesa-dev] [PATCH 5/7] tgsi/scan: get information about shader buffer usage

2016-10-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 19 +++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 4 2 files changed, 23 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index c27f0c6..517b983 100644

[Mesa-dev] [PATCH 3/7] tgsi/scan: don't treat RESQ etc. as memory instructions

2016-10-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index e5edea8..66f1fdf 100644 --- a/src/gallium/auxiliary/tgsi/tgs

[Mesa-dev] [PATCH 1/7] tgsi/scan: get information about indirect CONST access

2016-10-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 13 + src/gallium/auxiliary/tgsi/tgsi_scan.h | 2 ++ 2 files changed, 15 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index b862078..0c81005 100644 --- a/sr

[Mesa-dev] [PATCH 6/7] tgsi/scan: move src operand processing into a separate function

2016-10-20 Thread Marek Olšák
From: Marek Olšák the next commit will need this --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 354 + 1 file changed, 183 insertions(+), 171 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index 517b983..0

[Mesa-dev] [PATCH 7/7] tgsi/scan: scan texture offset operands

2016-10-20 Thread Marek Olšák
From: Marek Olšák This seems important considering how much we depend on some of the flags. --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index 00f5

[Mesa-dev] [PATCH 2/7] tgsi/scan: get information about indirect 2D file access

2016-10-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 6 ++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 + 2 files changed, 7 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index 0c81005..e5edea8 100644 --- a/src/gallium/a

[Mesa-dev] [PATCH 0/7] tgsi/scan: fixes and more scanning

2016-10-20 Thread Marek Olšák
Hi, Patches 3-4, 7 are fixes. Patch 6 is required for 7. Patches 1-2, 5 add new shader info fields that may be useful in the future. I kept them because I don't feel reordering the commits is worth it. Please review. Marek ___ mesa-dev mailing list m

[Mesa-dev] [PATCH] automake: don't forget to pick wglext.h in the tarball

2016-10-20 Thread Emil Velikov
From: Emil Velikov Earlier commit reworked the header install rules, to ensure that the correct ones are installed only as needed. By doing so it dropped a wildcard which was effectively including the wglext.h header in the tarball. Add the header to the top-level noinst_HEADERS, since the it i

Re: [Mesa-dev] [PATCH v4 17/18] configure.ac: Only add default LLVM components if needed

2016-10-20 Thread Emil Velikov
On 19 October 2016 at 18:55, Tobias Droste wrote: > Am Mittwoch, 19. Oktober 2016, 14:17:53 CEST schrieb Emil Velikov: >> On 16 October 2016 at 01:20, Tobias Droste wrote: >> > LLVM components are only added when LLVM is needed. >> > This means gallium adds this as soon as "--enable-gallium-llvm"

[Mesa-dev] [PATCH v2] egl: add check that eglCreateContext gets a valid config

2016-10-20 Thread Tapani Pälli
Fixes following dEQP test: dEQP-EGL.functional.negative_api.create_context v2: don't break EGL_KHR_no_config_context (Eric Engestrom) Signed-off-by: Tapani Pälli --- Eric, the check you proposed does not work as KHR_no_config_context is always there in extension list with Mesa EGL. So, solu

[Mesa-dev] [PATCH] Revert "egl/android: Set EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT"

2016-10-20 Thread Tapani Pälli
This reverts commit b1d636aa007c0c354a217024b4befe15cfb5149f, previous commit sets these values for all egl configs. Signed-off-by: Tapani Pälli Cc: "12.0 13.0" --- previous commit refers to patch "egl/dri2: set max values for pbuffer width and height" src/egl/drivers/dri2/platform_android

Re: [Mesa-dev] [PATCH v4 11/18] configure.ac: Remove swr_llvm_check()

2016-10-20 Thread Emil Velikov
On 19 October 2016 at 18:51, Tobias Droste wrote: > Am Mittwoch, 19. Oktober 2016, 13:55:16 CEST schrieb Emil Velikov: >> On 16 October 2016 at 01:20, Tobias Droste wrote: >> > No need for an additional function here. >> > Use the same style for LLVM checks as the other drivers >> > (e.g. r300, l

Re: [Mesa-dev] [PATCH 1/2] egl/dri2: set max values for pbuffer width and height

2016-10-20 Thread Tapani Pälli
On 10/20/2016 07:12 PM, Emil Velikov wrote: On 20 October 2016 at 10:02, Tapani Pälli wrote: While these max values were previously fixed for pbuffer creation, this change makes also eglGetConfigAttrib() return correct values. Fixes following dEQP tests: dEQP-EGL.functional.create_surface

Re: [Mesa-dev] [PATCH] glsl: allow local_size qualifiers in compute shader regardless of version

2016-10-20 Thread Miklós Máté
On 26/08/16 21:17, Ilia Mirkin wrote: On Fri, Aug 26, 2016 at 3:08 PM, Miklós Máté wrote: On 08/26/2016 07:47 PM, Ilia Mirkin wrote: On Fri, Aug 26, 2016 at 1:39 PM, Miklós Máté wrote: On 08/26/2016 06:46 PM, Ilia Mirkin wrote: On Fri, Aug 26, 2016 at 12:42 PM, Miklós Máté wrote: Tomb Rai

Re: [Mesa-dev] [PATCH 2/2] mesa: add missing formats to driGLFormatToImageFormat

2016-10-20 Thread Emil Velikov
On 20 October 2016 at 10:02, Tapani Pälli wrote: > Fixes following dEQP tests: > >dEQP-EGL.functional.image.api.create_image_gles2_tex2d_luminance >dEQP-EGL.functional.image.api.create_image_gles2_tex2d_luminance_alpha > > Signed-off-by: Tapani Pälli > Bugzilla: https://bugs.freedesktop.o

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

2016-10-20 Thread Tapani Pälli
On 10/20/2016 06:55 PM, Marek Olšák wrote: On Mon, Oct 17, 2016 at 9:03 PM, Marek Olšák wrote: Hi, The latest branch: https://cgit.freedesktop.org/~mareko/mesa/log/?h=glsl-alloc-rework2 It contains: - all review comments resolved - commits from Tapani's jenkins branch (fixes for glsl, nir, i9

Re: [Mesa-dev] [PATCH 1/2] egl/dri2: set max values for pbuffer width and height

2016-10-20 Thread Emil Velikov
On 20 October 2016 at 10:02, Tapani Pälli wrote: > While these max values were previously fixed for pbuffer creation, this > change makes also eglGetConfigAttrib() return correct values. > > Fixes following dEQP tests: > >dEQP-EGL.functional.create_surface.pbuffer.rgb888_no_depth_no_stencil >

Re: [Mesa-dev] [PATCH] nvc0: translate compute shaders at program creation

2016-10-20 Thread Samuel Pitoiset
On 10/20/2016 06:10 PM, Ilia Mirkin wrote: And is what we do for all the other shader types. I guess this got missed in your various rebases of compute? Or I missed it when I did the precompile thing... either way, This has been missed for a long time, yeah. :-) Reviewed-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH] nvc0: translate compute shaders at program creation

2016-10-20 Thread Ilia Mirkin
And is what we do for all the other shader types. I guess this got missed in your various rebases of compute? Or I missed it when I did the precompile thing... either way, Reviewed-by: Ilia Mirkin On Thu, Oct 20, 2016 at 12:08 PM, Samuel Pitoiset wrote: > This makes shader-db reports results fo

[Mesa-dev] [PATCH] nvc0: translate compute shaders at program creation

2016-10-20 Thread Samuel Pitoiset
This makes shader-db reports results for compute shaders. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_state.c b/src/gallium/drivers/nouveau/nvc0/nvc0_state.c index

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

2016-10-20 Thread Marek Olšák
On Mon, Oct 17, 2016 at 9:03 PM, Marek Olšák wrote: > Hi, > > The latest branch: > https://cgit.freedesktop.org/~mareko/mesa/log/?h=glsl-alloc-rework2 > > It contains: > - all review comments resolved > - commits from Tapani's jenkins branch (fixes for glsl, nir, i965) > > My updated patches are a

Re: [Mesa-dev] [PATCH 04/21] st/mesa: use common inputs read field

2016-10-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Oct 20, 2016 at 10:46 AM, Timothy Arceri wrote: > --- > src/mesa/state_tracker/st_atifs_to_tgsi.c | 14 +++--- > src/mesa/state_tracker/st_atom_rasterizer.c | 2 +- > src/mesa/state_tracker/st_cb_drawtex.c | 2 +- > src/mesa/state_tracker

Re: [Mesa-dev] [PATCH 18/21] st/mesa: use common system values read field

2016-10-20 Thread Marek Olšák
For patches 14, 16, 18: Reviewed-by: Marek Olšák Marek On Thu, Oct 20, 2016 at 10:47 AM, Timothy Arceri wrote: > --- > src/mesa/program/prog_to_nir.c | 1 - > src/mesa/program/program.c | 4 ++-- > src/mesa/program/programopt.c | 2 +- > src/mesa/state

Re: [Mesa-dev] [PATCH 09/21] st/mesa: use common outputs written field

2016-10-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Oct 20, 2016 at 10:46 AM, Timothy Arceri wrote: > --- > src/mesa/state_tracker/st_atifs_to_tgsi.c | 2 +- > src/mesa/state_tracker/st_atom_rasterizer.c | 6 -- > src/mesa/state_tracker/st_atom_shader.c | 2 +- > src/mesa/state_tracker/st_glsl_to

Re: [Mesa-dev] [PATCH 07/21] st/mesa: use common double inputs read field

2016-10-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Oct 20, 2016 at 10:46 AM, Timothy Arceri wrote: > --- > src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 +- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 +++- > src/mesa/state_tracker/st_program.c| 3 ++- > 3 files changed, 6 insertions(+), 3 d

Re: [Mesa-dev] [PATCH 27/42] st/mesa: stop making use of InterpQualifier array

2016-10-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Oct 20, 2016 at 1:09 AM, Timothy Arceri wrote: > A following patch is going to merge the gl_fragment_program struct into > a common gl_program and we want to avoid all stages having this array. > > V2: use TGSI_INTERPOLATE_COUNT as the temporary placeholde

Re: [Mesa-dev] [PATCH] egl: remove explicit config_id management from dri2_add_config()

2016-10-20 Thread Eric Engestrom
On Friday, 2016-09-30 13:45:55 +0100, Emil Velikov wrote: > From: Emil Velikov > > Currently we only saved the id to memcpy the whole _EGLConfig to write > back the exact same id value. > > Remove the unneeded and confusing/misleading code. > > Signed-off-by: Emil Velikov Reviewed-by: Eric En

Re: [Mesa-dev] [PATCH 23/42] st/mesa: switch cs over to shared shader_info

2016-10-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Oct 20, 2016 at 1:09 AM, Timothy Arceri wrote: > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 11 --- > src/mesa/state_tracker/st_program.c| 2 +- > 2 files changed, 5 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/state_tr

Re: [Mesa-dev] [PATCH 17/42] st/mesa: switch gs over to shared shader_info

2016-10-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Oct 20, 2016 at 1:09 AM, Timothy Arceri wrote: > --- > src/mesa/state_tracker/st_program.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/state_tracker/st_program.c > b/src/mesa/state_tracker/st_program.c >

Re: [Mesa-dev] LLVM gallivm issue in Mesa 12.1.0

2016-10-20 Thread Emil Velikov
On 19 October 2016 at 18:35, Matt Turner wrote: > On Wed, Oct 19, 2016 at 9:54 AM, Marek Olšák wrote: >> On Wed, Oct 19, 2016 at 6:06 PM, Emil Velikov >> wrote: >>> On 19 October 2016 at 15:55, Marek Olšák wrote: On Wed, Oct 19, 2016 at 12:47 PM, Emil Velikov wrote: > On 19 Oct

Re: [Mesa-dev] [ANNOUNCE] mesa 13.0.0-rc1

2016-10-20 Thread Emil Velikov
On 20 October 2016 at 16:20, Jason Ekstrand wrote: > On Oct 20, 2016 8:11 AM, "Emil Velikov" wrote: >> >> On 19 October 2016 at 20:31, Jason Ekstrand wrote: >> > On Wed, Oct 19, 2016 at 12:16 PM, Emil Velikov >> > >> > wrote: >> >> >> >> On 19 October 2016 at 19:50, Kai Wasserbäch >> >> >> >>

Re: [Mesa-dev] [ANNOUNCE] mesa 13.0.0-rc1

2016-10-20 Thread Jason Ekstrand
On Oct 20, 2016 8:11 AM, "Emil Velikov" wrote: > > On 19 October 2016 at 20:31, Jason Ekstrand wrote: > > On Wed, Oct 19, 2016 at 12:16 PM, Emil Velikov > > wrote: > >> > >> On 19 October 2016 at 19:50, Kai Wasserbäch > >> wrote: > >> > Hey Emil, > >> > just curious why you did the revert > >>

Re: [Mesa-dev] [PATCH v2] intel: genxml: add SO_WRITE_OFFSET register

2016-10-20 Thread Lionel Landwerlin
On 20/10/16 16:13, Jason Ekstrand wrote: On Oct 20, 2016 3:56 AM, "Lionel Landwerlin" > wrote: > > One of the register we happen to program but don't have a description for > yet. Heh... I've got more-or less this same patch in my tree... I figured you would

Re: [Mesa-dev] [PATCH 2/2] egl: add check that eglCreateContext gets a valid config

2016-10-20 Thread Tapani Pälli
Hi; On 10/20/2016 05:41 PM, Eric Engestrom wrote: On Thursday, 2016-10-20 15:34:52 +0100, Eric Engestrom wrote: On Thursday, 2016-10-20 14:55:25 +0300, Tapani Pälli wrote: Fixes following dEQP test: dEQP-EGL.functional.negative_api.create_context Signed-off-by: Tapani Pälli --- src/eg

Re: [Mesa-dev] LLVM gallivm issue in Mesa 12.1.0

2016-10-20 Thread Chuck Atkins
> Perhaps we need to make sure we pick --std=c++11. > > But this also implies that *all* Mesa needs to build reliably with > --std=c++11. Yes, that is correct. The issue is one of C++11 ABI mismatch. If a public interface to a library is C++ but contains no C++ std library data structures (rar

Re: [Mesa-dev] [PATCH v2] intel: genxml: add SO_WRITE_OFFSET register

2016-10-20 Thread Jason Ekstrand
On Oct 20, 2016 3:56 AM, "Lionel Landwerlin" wrote: > > One of the register we happen to program but don't have a description for > yet. Heh... I've got more-or less this same patch in my tree... > v2: Add SO_WRITE_OFFSET[1-3] on gen7+ (Kenneth) > > Signed-off-by: Lionel Landwerlin > --- > src

Re: [Mesa-dev] [ANNOUNCE] mesa 13.0.0-rc1

2016-10-20 Thread Emil Velikov
On 19 October 2016 at 20:31, Jason Ekstrand wrote: > On Wed, Oct 19, 2016 at 12:16 PM, Emil Velikov > wrote: >> >> On 19 October 2016 at 19:50, Kai Wasserbäch >> wrote: >> > Hey Emil, >> > just curious why you did the revert >> > >> > (

Re: [Mesa-dev] [PATCH] gallivm: try to fix build with LLVM <= 3.4 due to missing CallSite.h

2016-10-20 Thread Brian Paul
Reviewed-by: Brian Paul Tested-by: Brian Paul Thanks! On 10/20/2016 03:22 AM, Marek Olšák wrote: From: Marek Olšák untested --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_mi

Re: [Mesa-dev] [PATCH 12/42] st/mesa: switch tes over to shared shader_info

2016-10-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Oct 20, 2016 at 1:09 AM, Timothy Arceri wrote: > --- > src/mesa/state_tracker/st_program.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/src/mesa/state_tracker/st_program.c > b/src/mesa/state_tracker/st_program.c >

Re: [Mesa-dev] [PATCH 07/42] st/mesa: switch tcs over to shared shader_info

2016-10-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Oct 20, 2016 at 1:09 AM, Timothy Arceri wrote: > --- > src/mesa/program/prog_statevars.c | 2 +- > src/mesa/state_tracker/st_program.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/program/prog_statevars.c > b/src

Re: [Mesa-dev] [PATCH 2/2] egl: add check that eglCreateContext gets a valid config

2016-10-20 Thread Eric Engestrom
On Thursday, 2016-10-20 15:34:52 +0100, Eric Engestrom wrote: > On Thursday, 2016-10-20 14:55:25 +0300, Tapani Pälli wrote: > > Fixes following dEQP test: > > > >dEQP-EGL.functional.negative_api.create_context > > > > Signed-off-by: Tapani Pälli > > --- > > src/egl/main/eglapi.c | 1 + > >

Re: [Mesa-dev] [PATCH 2/2] egl: add check that eglCreateContext gets a valid config

2016-10-20 Thread Eric Engestrom
On Thursday, 2016-10-20 14:55:25 +0300, Tapani Pälli wrote: > Fixes following dEQP test: > >dEQP-EGL.functional.negative_api.create_context > > Signed-off-by: Tapani Pälli > --- > src/egl/main/eglapi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/egl/main/eglapi.c b/src/egl

Re: [Mesa-dev] [PATCH 1/2] egl: fix type mismatch error type in _eglInitSurface

2016-10-20 Thread Eric Engestrom
On Thursday, 2016-10-20 14:55:24 +0300, Tapani Pälli wrote: > EGL spec defines EGL_BAD_MATCH for windows, pixmaps and pbuffers in > case where user creates a surface but config does not support rendering > to such surface type. > > Following quotes are from EGL 1.5 spec 3.5 "Rendering Surfaces" :

[Mesa-dev] [Bug 94561] [llvmpipe] PIPE_CAP_VIDEO_MEMORY reports negative value on 32 bits (with 16GB ram)

2016-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94561 Roland Scheidegger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] radeonsi: fix a regression in si_eliminate_const_output

2016-10-20 Thread Marek Olšák
On Thu, Oct 20, 2016 at 2:35 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Is there a way to fold all constant expressions somehow? This is the constant expression: https://people.freedesktop.org/~mareko/cts-nonfp-expression.html No wonder LLVM gave up folding it. Marek ___

Re: [Mesa-dev] [PATCH v2] nv50, nvc0: don't keep track of whether fb rt0 is integer-only

2016-10-20 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 10/20/2016 04:44 AM, Ilia Mirkin wrote: This reverts commits 1af0641db345209c076e9b1ba4dca7524541671a and a6ad49cbbd599aec054d0a3163fff5ad724f2b18. st/mesa adjusts the rasterizer state for us now. Signed-off-by: Ilia Mirkin --- v1 -> v2: also revert the nv50

Re: [Mesa-dev] [PATCH] radeonsi: fix a regression in si_eliminate_const_output

2016-10-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Is there a way to fold all constant expressions somehow? Marek On Thu, Oct 20, 2016 at 1:09 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > A constant value of float type is not necessarily a ConstantFP: it could also > be a constant expression that for some reas

Re: [Mesa-dev] [PATCH] nvc0: do not break 3D state by pushing MS coordinates on Fermi

2016-10-20 Thread Samuel Pitoiset
On 10/20/2016 12:46 AM, Samuel Pitoiset wrote: Long short story, 3D and CP are aliased on Fermi and initializing compute after pushing the MS sample coordinate offsets seems to corrupt 3D state for weird reasons. I still don't have the faintest clue what is going on, but this seems to only aff

[Mesa-dev] [PATCH 2/2] egl: add check that eglCreateContext gets a valid config

2016-10-20 Thread Tapani Pälli
Fixes following dEQP test: dEQP-EGL.functional.negative_api.create_context Signed-off-by: Tapani Pälli --- src/egl/main/eglapi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index d8bd76d..e96999c 100644 --- a/src/egl/main/eglapi.c +++ b/s

[Mesa-dev] [PATCH 1/2] egl: fix type mismatch error type in _eglInitSurface

2016-10-20 Thread Tapani Pälli
EGL spec defines EGL_BAD_MATCH for windows, pixmaps and pbuffers in case where user creates a surface but config does not support rendering to such surface type. Following quotes are from EGL 1.5 spec 3.5 "Rendering Surfaces" : for eglCreatePlatformWindowSurface, eglCreateWindowSurface: "If c

Re: [Mesa-dev] [PATCH] st/mesa: only set primitive_restart when the restart index is in range

2016-10-20 Thread Nicolai Hähnle
On 20.10.2016 11:41, Marek Olšák wrote: I think st_indirect_draw_vbo needs the same fix. Yes. The indirect path also doesn't handle the RestartFixedIndex case correctly. I'll send out a patch later that unifies those two paths. Nicolai Marek On Wed, Oct 19, 2016 at 11:14 PM, Marek Olšák

[Mesa-dev] [Bug 98345] dEQP EGL: negative test failed w/ invalid return

2016-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98345 Tapani Pälli changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@list

Re: [Mesa-dev] [PATCH] egl/dri2: add a libname to dlopen for OpenBSD

2016-10-20 Thread Emil Velikov
On 19 October 2016 at 23:41, Jonathan Gray wrote: > On Wed, Oct 19, 2016 at 03:17:07PM +0100, Emil Velikov wrote: >> On 19 October 2016 at 14:16, Jonathan Gray wrote: >> > On Wed, Oct 19, 2016 at 10:29:47AM +0100, Emil Velikov wrote: >> >> On 19 October 2016 at 01:05, Jonathan Gray wrote: >> >>

Re: [Mesa-dev] [PATCH 1/2] egl/dri2: set max values for pbuffer width and height

2016-10-20 Thread Tapani Pälli
On 10/20/2016 02:10 PM, Eric Engestrom wrote: On Thursday, 2016-10-20 12:02:15 +0300, Tapani Pälli wrote: While these max values were previously fixed for pbuffer creation, this change makes also eglGetConfigAttrib() return correct values. Fixes following dEQP tests: dEQP-EGL.functional.c

Re: [Mesa-dev] [PATCH 02/16] loader: slim down loader_get_pci_id_for_fd implementation(s)

2016-10-20 Thread Jonathan Gray
On Thu, Oct 20, 2016 at 11:44:46AM +0100, Emil Velikov wrote: > On 20 October 2016 at 05:35, Jonathan Gray wrote: > > On Sat, Oct 15, 2016 at 01:32:02PM +0100, Emil Velikov wrote: > >> On Saturday, 15 October 2016, Jonathan Gray wrote: > >> > >> > On Tue, Oct 11, 2016 at 07:31:46PM +0100, Emil Ve

  1   2   >