[Mesa-dev] [PATCH 5/6] ac/nir: Implement Float64 SSBO loads.

Signed-off-by: Bas Nieuwenhuizen --- src/amd/common/ac_nir_to_llvm.c | 75 +++-- 1 file changed, 49 insertions(+), 26 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 74976b3e222..f8d0e8ab366 100644 --- a/src/am

[Mesa-dev] [PATCH 3/6] ac/nir: Implement Float64 load/store var.

Signed-off-by: Bas Nieuwenhuizen --- src/amd/common/ac_nir_to_llvm.c | 101 +++- 1 file changed, 48 insertions(+), 53 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 657f38626e7..c1bbb00184b 100644 --- a/src/am

[Mesa-dev] [PATCH 4/6] ac/nir: Imeplement Float64 UBO loads.

Signed-off-by: Bas Nieuwenhuizen --- src/amd/common/ac_nir_to_llvm.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index c1bbb00184b..74976b3e222 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/

[Mesa-dev] [PATCH 6/6] radv: Enable Float64 support.

Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_device.c | 2 +- src/amd/vulkan/radv_pipeline.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 06fefb3779e..d45c71c0e61 100644 --- a/src/amd/vulkan/ra

[Mesa-dev] [PATCH 1/6] ac/nir: Add core Float64 support.

Signed-off-by: Bas Nieuwenhuizen --- src/amd/common/ac_nir_to_llvm.c | 173 ++-- 1 file changed, 129 insertions(+), 44 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index c22529741fa..1b23a065633 100644 --- a/src/a

[Mesa-dev] [PATCH 2/6] ac/nir: Implement Float64 SSBO stores.

No f16 support as I'm not quite sure about alignment yet. Signed-off-by: Bas Nieuwenhuizen --- src/amd/common/ac_nir_to_llvm.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 1b23a06563

Re: [Mesa-dev] [PATCH] radv: handle VK_QUEUE_FAMILY_IGNORED in image transitions

On Tue, Jan 31, 2017, at 06:24, Dave Airlie wrote: > From: Dave Airlie > > The CTS tests at least are using this, and we were totally > ignoring it. > > This hopefully fixes the bouncing multisample CTS tests. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_cmd_buffer.c | 8 --

Re: [Mesa-dev] [PATCH v4] android: add vulkan build for intel

On 01/31/2017 08:38 AM, Jason Ekstrand wrote: On Jan 30, 2017 10:03 PM, "Tapani Pälli" mailto:tapani.pa...@intel.com>> wrote: On 01/30/2017 04:00 PM, Emil Velikov wrote: On 30 January 2017 at 11:37, Tapani Pälli mailto:tapani.pa...@intel.com>> wrote: fixes

[Mesa-dev] [PATCH] drm/radeon: Fix vram_size/visible values in DRM_RADEON_GEM_INFO ioctl

From: Michel Dänzer vram_size is supposed to be the total amount of VRAM that can be used by userspace, which corresponds to the TTM VRAM manager size (which is normally the full amount of VRAM, but can be just the visible VRAM when DMA can't be used for BO migration for some reason). The above

[Mesa-dev] [PATCH] winsys/radeon: Allow visible VRAM size > 256MB with kernel driver >= 2.49

From: Michel Dänzer The kernel driver reports correct values now. Signed-off-by: Michel Dänzer --- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c b/src/gallium/winsys

Re: [Mesa-dev] [PATCH 2/2] spirv: handle undefined components for OpVectorShuffle

On Jan 30, 2017 4:15 AM, "Lionel Landwerlin" wrote: On 27/01/17 09:57, Juan A. Suarez Romero wrote: > On Fri, 2017-01-27 at 09:46 +, Lionel Landwerlin wrote: > >> But what the test does is calling OpSpecConstantOp[2], which is the >>> operation we are patching here. >>> >>> And according to

Re: [Mesa-dev] [PATCH v4] android: add vulkan build for intel

On Jan 30, 2017 10:03 PM, "Tapani Pälli" wrote: On 01/30/2017 04:00 PM, Emil Velikov wrote: > On 30 January 2017 at 11:37, Tapani Pälli wrote: > >> fixes to issues spotted by Emil Velikov: >> >>- set ANV_TIMESTAMP corretly >>- fix typo with VULKAN_GEM_FILES >> >> v2: update to use Mak

[Mesa-dev] [PATCH] [RFC] radv: add dcc decompression stage to fast clear eliminate path. (v2)

From: Dave Airlie No idea if this is needed or not, just thought I'd write it while I was here. v2: missed a chunk. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_fast_clear.c | 53 +-- src/amd/vulkan/radv_private.h | 1 + 2 files changed, 51

[Mesa-dev] [PATCH] [RFC] radv: add dcc decompression stage to fast clear eliminate path.

From: Dave Airlie No idea if this is needed or not, just thought I'd write it while I was here. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_fast_clear.c | 53 +-- 1 file changed, 50 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_meta

Re: [Mesa-dev] [PATCH v4] android: add vulkan build for intel

On 01/30/2017 04:00 PM, Emil Velikov wrote: On 30 January 2017 at 11:37, Tapani Pälli wrote: fixes to issues spotted by Emil Velikov: - set ANV_TIMESTAMP corretly - fix typo with VULKAN_GEM_FILES v2: update to use Makefile.sources under vulkan instead of having own v3: update to

[Mesa-dev] [PATCH] radv: handle VK_QUEUE_FAMILY_IGNORED in image transitions

From: Dave Airlie The CTS tests at least are using this, and we were totally ignoring it. This hopefully fixes the bouncing multisample CTS tests. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 8 src/amd/vulkan/radv_image.c | 13 ++--- src/amd/vulkan

Re: [Mesa-dev] [PATCHv2 6/8] nir/spirv/glsl450: Rewrite atan2 implementation to fix accuracy and handling of zero/infinity.

This patch is Reviewed-by: Ian Romanick On 01/26/2017 02:52 PM, Francisco Jerez wrote: > See "glsl: Rewrite atan2 implementation to fix accuracy and handling > of zero/infinity." for the rationale, but note that the instruction > count benefit discussed there is somewhat less important for the S

Re: [Mesa-dev] [PATCHv2 5/8] glsl: Rewrite atan2 implementation to fix accuracy and handling of zero/infinity.

This patch is Reviewed-by: Ian Romanick On 01/26/2017 02:50 PM, Francisco Jerez wrote: > This addresses several issues of the current atan2 implementation: > > - Negative zero (and negative denorms which end up getting flushed to >zero) isn't handled correctly by the current implementation

Re: [Mesa-dev] [PATCH 03/10] gallium: set pipe_context::stream_uploader

On Mon, Jan 30, 2017 at 6:29 PM, Nicolai Hähnle wrote: > On 30.01.2017 18:20, Marek Olšák wrote: >> >> On Mon, Jan 30, 2017 at 6:00 PM, Nicolai Hähnle >> wrote: >>> >>> On 27.01.2017 12:02, Marek Olšák wrote: From: Marek Olšák Notes: - make sure the default size is

Re: [Mesa-dev] [PATCH] radv/ac: apply slice rounding to 1d arrays as well.

On Tue, Jan 31, 2017, at 01:10, Dave Airlie wrote: > From: Dave Airlie > > Fixes: > dEQP-VK.glsl.texture_functions.texture.*1darray* > > Signed-off-by: Dave Airlie > Please enter the commit message for your changes. Lines starting You probably did not intend to include this line. Reviewed-

Re: [Mesa-dev] [PATCH] radv/geom: check if esgs and gsvs ring exists before filling geom rings

Reviewed-by: Bas Nieuwenhuizen On Tue, Jan 31, 2017, at 01:38, Dave Airlie wrote: > From: Dave Airlie > > There are some corner cases where you end up with an esgs ring, but no > gsvs ring, test for both before dereferencing. > > Fixes: > dEQP-VK.geometry.emit.points_emit_0_end_0 > > Signed-o

[Mesa-dev] [PATCH] radv/geom: check if esgs and gsvs ring exists before filling geom rings

From: Dave Airlie There are some corner cases where you end up with an esgs ring, but no gsvs ring, test for both before dereferencing. Fixes: dEQP-VK.geometry.emit.points_emit_0_end_0 Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 9 ++--- 1 file changed, 6 insertions(+),

[Mesa-dev] [PATCH] radv/ac: apply slice rounding to 1d arrays as well.

From: Dave Airlie Fixes: dEQP-VK.glsl.texture_functions.texture.*1darray* Signed-off-by: Dave Airlie Please enter the commit message for your changes. Lines starting --- src/amd/common/ac_nir_to_llvm.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/s

[Mesa-dev] [Bug 99517] [TRACKER] Mesa 17.0 release tracker

https://bugs.freedesktop.org/show_bug.cgi?id=99517 Bug 99517 depends on bug 98892, which changed state. Bug 98892 Summary: [BDW] dEQP-VK.ubo.single_nested_struct_array tests intermittent https://bugs.freedesktop.org/show_bug.cgi?id=98892 What|Removed |Added ---

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: Use the proper depth input attachment surface state

Reviewed-by: Jason Ekstrand On Mon, Jan 30, 2017 at 2:37 PM, Nanley Chery wrote: > Commit 2852efcda40274acf3272611c6a3b7731523a72d moved the location of > the depth input attachment surface state from the render pass to the > image view, but failed to update the surface state location used when

[Mesa-dev] [Bug 99517] [TRACKER] Mesa 17.0 release tracker

https://bugs.freedesktop.org/show_bug.cgi?id=99517 Mark Janes changed: What|Removed |Added Depends on|99509 | Referenced Bugs: https://bugs.freedeskto

[Mesa-dev] [PATCH] st: remove pre C99 statement block for variable declaration

--- src/mesa/state_tracker/st_program.c | 118 ++-- 1 file changed, 58 insertions(+), 60 deletions(-) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tracker/st_program.c index 94204d7..b2d1586 100644 --- a/src/mesa/state_tracker/st_program.c +++

Re: [Mesa-dev] [PATCH v1] radv: Prevent Coverity warning

Pushed, thanks. On Mon, Jan 30, 2017, at 22:26, Robert Foss wrote: > Prevent Coverity seeing potential errors when src is > no initialized in the switch case. > > Coverity-Id: 1396397 > Signed-off-by: Robert Foss > --- > > Patch can be found here: > > https://git.collabora.com/cgit/user/robe

Re: [Mesa-dev] [PATCH v1] i965: Prevent coverity warning

On 2017-01-30 05:37 PM, Timothy Arceri wrote: On Mon, 2017-01-30 at 16:27 -0500, Robert Foss wrote: Add assert checking that num_sources is never larger than 3. This prevents Coverity from concluding that the improperly handled cases of num_sources not being 0-3 are relevant. Coverity-Id: 1399

[Mesa-dev] [PATCH 2/3] vc4: fix arm64 build with Neon

The addition of Neon assembly breaks on arm64 builds because the assembly syntax is different. For now, restrict Neon to ARMv7 builds. Signed-off-by: Rob Herring --- src/gallium/drivers/vc4/vc4_tiling.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/vc4/v

[Mesa-dev] [PATCH 1/3] vc4: Make Neon inline assembly clang compatible

clang throws an error on "%r2" and similar. I couldn't find any documentation on what "%r?" is supposed to mean and I've never seen any use like that as far as I remember. The parameter is supposed to be cpu_stride and just %2/%3 should be sufficient. There's no need for trailing ";" either, so re

[Mesa-dev] [PATCH 3/3] vc4: Enable Neon on arm builds

Signed-off-by: Rob Herring --- src/gallium/drivers/vc4/Android.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/vc4/Android.mk b/src/gallium/drivers/vc4/Android.mk index de9d5e3f5b3c..fdc06744e5ab 100644 --- a/src/gallium/drivers/vc4/Android.mk +++ b/src/gallium/drive

[Mesa-dev] [PATCH] anv/cmd_buffer: Use the proper depth input attachment surface state

Commit 2852efcda40274acf3272611c6a3b7731523a72d moved the location of the depth input attachment surface state from the render pass to the image view, but failed to update the surface state location used when emitting the binding table. Fix this by loading the surface state from the correct locatio

Re: [Mesa-dev] [PATCH v1] i965: Prevent coverity warning

On Mon, 2017-01-30 at 16:27 -0500, Robert Foss wrote: > Add assert checking that num_sources is never larger than 3. > > This prevents Coverity from concluding that the improperly handled > cases of num_sources not being 0-3 are relevant. > > Coverity-Id: 1399480-1399489 > Signed-off-by: Robert F

[Mesa-dev] [PATCH v1] i965: Prevent coverity warning

Add assert checking that num_sources is never larger than 3. This prevents Coverity from concluding that the improperly handled cases of num_sources not being 0-3 are relevant. Coverity-Id: 1399480-1399489 Signed-off-by: Robert Foss --- Patch can be found here: https://git.collabora.com/cgit

[Mesa-dev] [PATCH v1] radv: Prevent Coverity warning

Prevent Coverity seeing potential errors when src is no initialized in the switch case. Coverity-Id: 1396397 Signed-off-by: Robert Foss --- Patch can be found here: https://git.collabora.com/cgit/user/robertfoss/mesa.git/log/?h=cov_1396397_v1 src/amd/vulkan/radv_cmd_buffer.c | 2 ++ 1 file c

Re: [Mesa-dev] [PATCH 25/29] radv: emit geometry ring size and pointers via preamble

On Mon, Jan 30, 2017, at 07:02, Dave Airlie wrote: > From: Dave Airlie > > This uses the scratch infrastructure to handle the esgs > and gsvs rings. > > (this replaces the old code that did this with patching). > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_cmd_buffer.c | 28 ++

Re: [Mesa-dev] [PATCH] Revert "i915: Always enable GL 2.0 support."

On Sun, Jan 29, 2017 at 8:29 PM, Kenneth Graunke wrote: > On Sunday, January 29, 2017 6:20:10 PM PST Matt Turner wrote: >> This partially reverts commit 97217a40f97cdeae0304798b607f704deb0c3558. >> It leaves ES 2.0 support in place per Ian's suggestion, because ES 2.0 >> is designed to work on har

[Mesa-dev] [PATCH] glsl: fix heap-buffer-overflow

Found by ASAN. There is no need to add +1 to strlen, we have already add +1 to str_end. --- src/compiler/glsl/link_uniforms.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp index a450aa03a8..5a03257b9

[Mesa-dev] [Bug 99604] kwin_x11 disabling compositing with mesa 17

https://bugs.freedesktop.org/show_bug.cgi?id=99604 Bug ID: 99604 Summary: kwin_x11 disabling compositing with mesa 17 Product: Mesa Version: 17.0 Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH] radv/ac: implement txs for buffer textures.

Reviewed-by: Andres Rodriguez On 2017-01-30 02:21 PM, Dave Airlie wrote: From: Dave Airlie This fixes a bunch of buffer related: dEQP-VK.memory.pipeline_barrier.* tests, that were crashing in LLVM due to this being missing. Cc: "17.0" Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_

[Mesa-dev] [PATCH] android: fix llvm, elf dependencies for M, N releases

These changes set the correct llvm version and elf include path which differ for Marshmallow and Nougat --- Android.common.mk | 14 -- src/amd/Android.common.mk | 2 +- src/gallium/Android.common.mk | 2 +- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [Bug 99517] [TRACKER] Mesa 17.0 release tracker

https://bugs.freedesktop.org/show_bug.cgi?id=99517 Bug 99517 depends on bug 99266, which changed state. Bug 99266 Summary: piglit.spec.ext_framebuffer_object.getteximage-formats init-by-clear-and-render https://bugs.freedesktop.org/show_bug.cgi?id=99266 What|Removed

Re: [Mesa-dev] [PATCH] radv/ac: handle nir irem opcode.

Reviewed-by: Andres Rodriguez On 2017-01-30 01:50 PM, Dave Airlie wrote: From: Dave Airlie This fixes: dEQP-VK.spirv_assembly.instruction.compute.opsrem.* Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/common/

[Mesa-dev] [Bug 99591] Segmentation fault when running vulkaninfo with RADV Radeon Vulkan driver

https://bugs.freedesktop.org/show_bug.cgi?id=99591 --- Comment #2 from Jure Repinc --- Will try as soon as the up to date version of the package gets into openSUSE Thumbleweed. Bug reported here: https://bugzilla.opensuse.org/show_bug.cgi?id=1022156 -- You are receiving this mail because: You a

[Mesa-dev] [PATCH] radv/ac: implement txs for buffer textures.

From: Dave Airlie This fixes a bunch of buffer related: dEQP-VK.memory.pipeline_barrier.* tests, that were crashing in LLVM due to this being missing. Cc: "17.0" Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/amd/com

Re: [Mesa-dev] [PATCH 2/2] radv: Expose transfer format features.

Reviewed-by: Andres Rodriguez Fixes: dEQP-VK.api.info.image_format_properties.* Regards, Andres On 2017-01-25 06:24 PM, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen Tested-by: Andres Rodriguez --- src/amd/vulkan/radv_formats.c | 11 +++ 1 file changed, 11 insertions(

Re: [Mesa-dev] [PATCH 1/2] radv: Don't allow any operations on non-supported depth/stencil formats.

Reviewed-by: Andres Rodriguez On 2017-01-25 06:24 PM, Bas Nieuwenhuizen wrote: We really use the depth block for the blits. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_formats.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_f

Re: [Mesa-dev] [PATCH] i965: Implement another VF cache invalidate workaround on Gen8+.

On Sun, Jan 29, 2017 at 08:24:16PM -0800, Kenneth Graunke wrote: > ...and provide a better citation for the existing one. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_pipe_control.c | 32 > +--- > 1 file changed, 24 insertions(+), 8 deletions(

[Mesa-dev] [PATCH] radv/ac: handle nir irem opcode.

From: Dave Airlie This fixes: dEQP-VK.spirv_assembly.instruction.compute.opsrem.* Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index b90148e..bfe6a2e 10064

[Mesa-dev] [PATCH 1/2] gallivm: add no-signed-zeros-fp-math option to lp_create_builder

From: Marek Olšák --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 15 --- src/gallium/auxiliary/gallivm/lp_bld_misc.h | 8 +++- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 6 +- 3 files changed, 24 insertions(+), 5 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 2/2] radeonsi: set no-signed-zeros-fp-math

From: Marek Olšák Recommended by Matt Arsenault. 46757 shaders in 28742 tests Totals: SGPRS: 2068851 -> 2066907 (-0.09 %) VGPRS: 1604056 -> 1602676 (-0.09 %) Spilled SGPRs: 1402 -> 1382 (-1.43 %) Spilled VGPRs: 113 -> 113 (0.00 %) Private memory VGPRs: 1332 -> 1332 (0.00 %) Scratch size: 3224 ->

Re: [Mesa-dev] [PATCH v2 1/2] mesa: make glFramebuffer* check immutable texture level bounds

On Mon, Jan 30, 2017 at 1:06 PM, Ilia Mirkin wrote: > On Mon, Jan 30, 2017 at 12:26 PM, Nicolai Hähnle wrote: >> On 30.01.2017 18:23, Ilia Mirkin wrote: >>> >>> On Mon, Jan 30, 2017 at 4:36 AM, Ilia Mirkin wrote: On Mon, Jan 30, 2017 at 4:33 AM, Nicolai Hähnle wrote: > >

Re: [Mesa-dev] [PATCH v2 1/2] mesa: make glFramebuffer* check immutable texture level bounds

On Mon, Jan 30, 2017 at 12:26 PM, Nicolai Hähnle wrote: > On 30.01.2017 18:23, Ilia Mirkin wrote: >> >> On Mon, Jan 30, 2017 at 4:36 AM, Ilia Mirkin wrote: >>> >>> On Mon, Jan 30, 2017 at 4:33 AM, Nicolai Hähnle >>> wrote: On 26.01.2017 06:47, Ilia Mirkin wrote: > > > When

[Mesa-dev] [Bug 99517] [TRACKER] Mesa 17.0 release tracker

https://bugs.freedesktop.org/show_bug.cgi?id=99517 Bug 99517 depends on bug 99099, which changed state. Bug 99099 Summary: [SNB] intermittent gpu hang in piglit.spec.ext_framebuffer_multisample.accuracy https://bugs.freedesktop.org/show_bug.cgi?id=99099 What|Removed

Re: [Mesa-dev] [PATCH] winsys/amdgpu: add a fast exit path into amdgpu_cs_add_buffer

On 30.01.2017 18:17, Jan Ziak wrote: On Mon, Jan 30, 2017 at 5:08 PM, Marek Olšák wrote: On Mon, Jan 30, 2017 at 4:41 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: Hello Just a note about the future of Mesa: It is likely that optimizing Mesa will lead you (Marek) to consider generative prog

Re: [Mesa-dev] [PATCH 03/10] gallium: set pipe_context::stream_uploader

On 30.01.2017 18:20, Marek Olšák wrote: On Mon, Jan 30, 2017 at 6:00 PM, Nicolai Hähnle wrote: On 27.01.2017 12:02, Marek Olšák wrote: From: Marek Olšák Notes: - make sure the default size is large enough to handle all state trackers - pipe wrappers don't receive transfer calls from stream_

Re: [Mesa-dev] [PATCH v2 1/2] mesa: make glFramebuffer* check immutable texture level bounds

On 30.01.2017 18:23, Ilia Mirkin wrote: On Mon, Jan 30, 2017 at 4:36 AM, Ilia Mirkin wrote: On Mon, Jan 30, 2017 at 4:33 AM, Nicolai Hähnle wrote: On 26.01.2017 06:47, Ilia Mirkin wrote: When a texture is immutable, we can't tack on extra levels after-the-fact like we could with glTexImage.

Re: [Mesa-dev] [PATCH v2 1/2] mesa: make glFramebuffer* check immutable texture level bounds

On Mon, Jan 30, 2017 at 4:36 AM, Ilia Mirkin wrote: > On Mon, Jan 30, 2017 at 4:33 AM, Nicolai Hähnle wrote: >> On 26.01.2017 06:47, Ilia Mirkin wrote: >>> >>> When a texture is immutable, we can't tack on extra levels >>> after-the-fact like we could with glTexImage. So check against that >>> le

Re: [Mesa-dev] [PATCH 03/10] gallium: set pipe_context::stream_uploader

On Mon, Jan 30, 2017 at 6:00 PM, Nicolai Hähnle wrote: > On 27.01.2017 12:02, Marek Olšák wrote: >> >> From: Marek Olšák >> >> Notes: >> - make sure the default size is large enough to handle all state trackers >> - pipe wrappers don't receive transfer calls from stream_uploader, because >> pip

Re: [Mesa-dev] [PATCH] winsys/amdgpu: add a fast exit path into amdgpu_cs_add_buffer

On Mon, Jan 30, 2017 at 5:08 PM, Marek Olšák wrote: > On Mon, Jan 30, 2017 at 4:41 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: >> Hello >> >> Just a note about the future of Mesa: >> >> It is likely that optimizing Mesa will lead you (Marek) to consider >> generative programming some years into

Re: [Mesa-dev] [PATCH 01/10] gallium: add a common uploader to pipe_context

On 27.01.2017 16:02, Marek Olšák wrote: On Fri, Jan 27, 2017 at 3:38 PM, Roland Scheidegger wrote: Am 27.01.2017 um 12:02 schrieb Marek Olšák: From: Marek Olšák For lower memory usage and more efficient updates of the buffer residency list. (e.g. if drivers keep seeing the same buffer for ma

Re: [Mesa-dev] [PATCH 03/10] gallium: set pipe_context::stream_uploader

On 27.01.2017 12:02, Marek Olšák wrote: From: Marek Olšák Notes: - make sure the default size is large enough to handle all state trackers - pipe wrappers don't receive transfer calls from stream_uploader, because pipe_context::stream_uploader points directly to the underlying driver's stre

Re: [Mesa-dev] [PATCH v2] various: Fix missing DumpModule with recent LLVM.

FYI, LLVMDumpModule is back: r293436 - llvm-c: Keep LLVMDumpModule() even in release builds Marek On Mon, Jan 30, 2017 at 3:08 PM, Nicolai Hähnle wrote: > On 28.01.2017 23:08, Bas Nieuwenhuizen wrote: >> >> Since LLVM revision 293359 DumpModule gets only implemented when >> either a debug build

Re: [Mesa-dev] [PATCH 1/3] radeonsi: don't invoke DCC decompression in update_all_texture_descriptors

This patch fixes the bug uncovered. Tested-by: Edmondo Tommasina Thanks edmondo On Mon, Jan 30, 2017 at 1:33 AM, Marek Olšák wrote: > From: Marek Olšák > > This fixes a bug uncovered by the 17-part patch series, specifically: > "gallium/radeon: merge dirty_fb_counter and dirty_tex_descript

Re: [Mesa-dev] [PATCH] winsys/amdgpu: add a fast exit path into amdgpu_cs_add_buffer

On Mon, Jan 30, 2017 at 4:41 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: > Hello > > Just a note about the future of Mesa: > > It is likely that optimizing Mesa will lead you (Marek) to consider > generative programming some years into the future: > > Optimal code is basically a form of efficien

Re: [Mesa-dev] [PATCH] winsys/amdgpu: add a fast exit path into amdgpu_cs_add_buffer

Hello Just a note about the future of Mesa: It is likely that optimizing Mesa will lead you (Marek) to consider generative programming some years into the future: Optimal code is basically a form of efficient adaptation to current circumstances. Generating the optimal code by hand can be ineffic

Re: [Mesa-dev] [PATCH] etnaviv: Avoid infinite loop in find_frame()

2017-01-30 15:47 GMT+01:00 Rhys Kidd : > > On Sun, Jan 22, 2017 at 1:49 PM Rhys Kidd wrote: >> >> On 20 January 2017 at 17:06, Christian Gmeiner >> wrote: >>> >>> Hi Rhys, >>> >>> 2017-01-19 7:02 GMT+01:00 Rhys Kidd : >>> > Use of unsigned loop control variable with '>= 0' would lead to >>> > inf

Re: [Mesa-dev] [PATCH] etnaviv: Avoid infinite loop in find_frame()

On Sun, Jan 22, 2017 at 1:49 PM Rhys Kidd wrote: > On 20 January 2017 at 17:06, Christian Gmeiner < > christian.gmei...@gmail.com> wrote: > > Hi Rhys, > > 2017-01-19 7:02 GMT+01:00 Rhys Kidd : > > Use of unsigned loop control variable with '>= 0' would lead to infinite > loop. > > > > Reported by

Re: [Mesa-dev] [PATCH] r600: Fix stack overflow

On 30.01.2017 14:07, Bartosz Tomczyk wrote: Commit 7b5878ee0491e7a93914389a8369cd6752b9757d increased number of outputs to 64, but left output array intact. This caused stack overflow when number of outputs is bigger then 32. Found by ASAN. Pushed, thanks! --- src/gallium/drivers/r600/r600_s

Re: [Mesa-dev] [PATCH] r600/sb: Fix memory leak

It did not change anything, as we are not dereferencing iterator after delete. I think changing: delete *it; uses.erase(it); to: use_info *ptr = *it; uses.erase(it); delete ptr; don't make it more readable or safer, but I can change it if you want to. On Mon, Jan 30, 2017 at 3:16 PM, Nicolai Hä

Re: [Mesa-dev] [PATCH 16/17] radeonsi: atomize the scratch buffer state

Reviewed-by: Nicolai Hähnle On 30.01.2017 12:54, Marek Olšák wrote: From: Marek Olšák The update frequency is very low. Difference: Only account for the size when allocating a new one and when starting a new IB, and check for NULL. (v3) --- src/gallium/drivers/radeonsi/si_cp_dma

Re: [Mesa-dev] [PATCH] r600: fix a compilation warning in r600_screen_create()

On 30.01.2017 13:55, Samuel Pitoiset wrote: Should be r600_common_screen instead of r600_screen. Fixes: 80157a2c20 ("gallium/radeon: clean up r600_query_init_backend_mask") Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/r600/r600_pipe.c | 2 +- 1 file c

Re: [Mesa-dev] [PATCH 3/3] winsys/radeon: clamp vram_vis_size to 256MB

For the series: Reviewed-by: Nicolai Hähnle On 30.01.2017 01:33, Marek Olšák wrote: From: Marek Olšák the value from the kernel is wrong --- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/winsys/radeon/drm/ra

Re: [Mesa-dev] [PATCH] r600/sb: Fix memory leak

Nice find! On 29.01.2017 19:10, Bartosz Tomczyk wrote: --- src/gallium/drivers/r600/sb/sb_valtable.cpp | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/sb/sb_valtable.cpp b/src/gallium/drivers/r600/sb/sb_valtable.cpp index a8b7b49cd4..d31a1b76

Re: [Mesa-dev] [PATCH v2] various: Fix missing DumpModule with recent LLVM.

On 28.01.2017 23:08, Bas Nieuwenhuizen wrote: Since LLVM revision 293359 DumpModule gets only implemented when either a debug build or LLVM_ENABLE_DUMP is set. This patch adds a direct replacement for the function for radv and radeonsi, However, as I don't know a good place to put common LLVM co

Re: [Mesa-dev] [PATCH v4] android: add vulkan build for intel

On 30 January 2017 at 11:37, Tapani Pälli wrote: > fixes to issues spotted by Emil Velikov: > >- set ANV_TIMESTAMP corretly >- fix typo with VULKAN_GEM_FILES > > v2: update to use Makefile.sources under vulkan > instead of having own > > v3: update to changes to generate from vk.xml >

[Mesa-dev] [Bug 99601] Account request

https://bugs.freedesktop.org/show_bug.cgi?id=99601 --- Comment #2 from Emil Velikov --- Eric has 50+ fixes throughout the tree [1] and I'm happy to with him having commit access. [1] https://cgit.freedesktop.org/mesa/mesa/log/?qt=author&q=Eric+Engestrom -- You are receiving this mail because:

Re: [Mesa-dev] [PATCH 2/2] glx/dri3: handle NULL pointers in loader-to-DRI3 drawable conversion

On 27 January 2017 at 10:59, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > With the previous patch, we can now get NULL loaderPrivates, e.g. when > a DRIdrawable is flushed whose corresponding GLXDRIdrawable was destroyed. > This resulted in a crash, since the loader vs. DRI3 drawable structur

[Mesa-dev] [Bug 99601] Account request

https://bugs.freedesktop.org/show_bug.cgi?id=99601 --- Comment #1 from Eric Engestrom --- Created attachment 129231 --> https://bugs.freedesktop.org/attachment.cgi?id=129231&action=edit pgp key (CC31EF29D32A6637889530F2481D0E9D964E5593) -- You are receiving this mail because: You are the QA C

[Mesa-dev] [Bug 99601] Account request

https://bugs.freedesktop.org/show_bug.cgi?id=99601 Bug ID: 99601 Summary: Account request Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority: medium

Re: [Mesa-dev] [PATCH 1/3] gallium/radeon: rename grbm to mmio in the gpu load path

Reviewed-by: Marek Olšák Marek On Thu, Jan 26, 2017 at 8:54 PM, Samuel Pitoiset wrote: > We also want to monitor other MMIO counters like SRBM_STATUS2 in > order to know if SDMA is busy. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeon/r600_gpu_load.c| 30 +++-

[Mesa-dev] [PATCH] r600: Fix stack overflow

Commit 7b5878ee0491e7a93914389a8369cd6752b9757d increased number of outputs to 64, but left output array intact. This caused stack overflow when number of outputs is bigger then 32. Found by ASAN. --- src/gallium/drivers/r600/r600_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[Mesa-dev] [PATCH] r600: fix a compilation warning in r600_screen_create()

Should be r600_common_screen instead of r600_screen. Fixes: 80157a2c20 ("gallium/radeon: clean up r600_query_init_backend_mask") Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/r600/r600_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r6

Re: [Mesa-dev] [PATCH 2/2] spirv: handle undefined components for OpVectorShuffle

On 27/01/17 09:57, Juan A. Suarez Romero wrote: On Fri, 2017-01-27 at 09:46 +, Lionel Landwerlin wrote: But what the test does is calling OpSpecConstantOp[2], which is the operation we are patching here. And according to the spec, "all Operands must be the s of other constant instructions",

Re: [Mesa-dev] [PATCH 2/2] glx/dri3: handle NULL pointers in loader-to-DRI3 drawable conversion

For the series: Reviewed-by: Marek Olšák Marek On Fri, Jan 27, 2017 at 11:59 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > With the previous patch, we can now get NULL loaderPrivates, e.g. when > a DRIdrawable is flushed whose corresponding GLXDRIdrawable was destroyed. > This resulted

Re: [Mesa-dev] [PATCH 2/2] winsys/amdgpu: do not iterate twice when adding fence dependencies

Reviewed-by: Marek Olšák Marek On Fri, Jan 27, 2017 at 2:35 PM, Samuel Pitoiset wrote: > The perf difference is very small, 3.25->2.84% in amdgpu_cs_flush() > in the DXMD benchmark. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 63 > --

Re: [Mesa-dev] [PATCH 1/2] winsys/amdgpu: add one likely() call in amdgpu_cs_flush()

Reviewed-by: Marek Olšák Marek On Fri, Jan 27, 2017 at 2:35 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c > b

Re: [Mesa-dev] [PATCH] gallium: turn PIPE_SHADER_CAP_DOUBLES into a screen capability

On Fri, Jan 27, 2017 at 10:40 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Make the cap consistent with PIPE_CAP_INT64. > > Aside from the hypothetical case of using draw for vertex shaders (and > actually caring about doubles...), every implementation supports doubles > either nowhere or

Re: [Mesa-dev] [PATCH v2] hud: fix compilation warnings in hud_nic_graph_install()

Reviewed-by: Marek Olšák Marek On Mon, Jan 30, 2017 at 11:19 AM, Samuel Pitoiset wrote: > v2: use PRId64 instead of PRIx64 > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/auxiliary/hud/hud_nic.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/au

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

Michel Dänzer wrote: On 30/01/17 12:08 AM, Andy Furniss wrote: Christian König wrote: That looks correct to me, but I'm not deeply enough into the H264 encoding any more. Adding Leo and Boyuan to comment as well. I just sent v2 to list and tried to cc Boyuan and Leo but it failed. git send-

Re: [Mesa-dev] [PATCH v2 3/3] gallium/radeon: add new HUD queries for monitoring the CP

Reviewed-by: Marek Olšák Marek On Mon, Jan 30, 2017 at 12:52 PM, Samuel Pitoiset wrote: > There are even more counters in the CP_STAT register but I think > these ones are enough for now. > > v2: only read (and expose) CP_STAT on VI+ > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/driv

Re: [Mesa-dev] [PATCH] st/va: Support fractional framerate in misc parameter

Mark Thompson wrote: Signed-off-by: Mark Thompson --- See - this is a recent addition, but is backwards-compatible. Depends on Andy's patch for actual support fo

Re: [Mesa-dev] [PATCH v2 2/3] gallium/radeon: add new GPU-sdma-busy HUD query

Reviewed-by: Marek Olšák Marek On Mon, Jan 30, 2017 at 12:52 PM, Samuel Pitoiset wrote: > For simplicity, GPU-sdma-busy will return 0 on previous gens. > > v2: only read SRBM_STATUS2 on Evergreen+ > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeon/r600_gpu_load.c| 13 ++

Re: [Mesa-dev] [PATCH 17/17] radeonsi: fold info->indirect conditionals into the last one in draw_vbo

On Mon, Jan 30, 2017 at 11:02 AM, Nicolai Hähnle wrote: > I have one comment/question on patch #16. Apart from that, the series is I've updated patch 16 and it needs review. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.f

[Mesa-dev] [PATCH 16/17] radeonsi: atomize the scratch buffer state

From: Marek Olšák The update frequency is very low. Difference: Only account for the size when allocating a new one and when starting a new IB, and check for NULL. (v3) --- src/gallium/drivers/radeonsi/si_cp_dma.c| 3 ++- src/gallium/drivers/radeonsi/si_hw_context.c| 7

[Mesa-dev] [PATCH v2 3/3] gallium/radeon: add new HUD queries for monitoring the CP

There are even more counters in the CP_STAT register but I think these ones are enough for now. v2: only read (and expose) CP_STAT on VI+ Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeon/r600_gpu_load.c| 36 +++ src/gallium/drivers/radeon/r600_pipe_commo

[Mesa-dev] [PATCH v2 2/3] gallium/radeon: add new GPU-sdma-busy HUD query

For simplicity, GPU-sdma-busy will return 0 on previous gens. v2: only read SRBM_STATUS2 on Evergreen+ Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeon/r600_gpu_load.c| 13 + src/gallium/drivers/radeon/r600_pipe_common.h | 3 +++ src/gallium/drivers/radeon/r600_que

[Mesa-dev] [PATCH 16/17] radeonsi: atomize the scratch buffer state

From: Marek Olšák The update frequency is very low. Difference: Only account for the size when allocating a new one and when starting a new IB. (v2) --- src/gallium/drivers/radeonsi/si_cp_dma.c| 3 ++- src/gallium/drivers/radeonsi/si_hw_context.c| 5 - src/gallium/

Re: [Mesa-dev] [PATCH 16/17] radeonsi: atomize the scratch buffer state

On Mon, Jan 30, 2017 at 11:01 AM, Nicolai Hähnle wrote: > On 26.01.2017 17:04, Marek Olšák wrote: >> >> From: Marek Olšák >> >> The update frequency is very low. >> >> Difference: Only account for the size when allocating a new one. > > > Why not in the atom emit? With this patch, the size is onl

  1   2   >