Re: [Mesa-dev] [RFC] spec: MESA_program_binary

On 16/02/17 17:55, Tapani Pälli wrote: On 02/16/2017 04:52 AM, Timothy Arceri wrote: In order add functionality to ARB_get_program_binary we need binary format enums. I've understood that this is a driver internal enumeration. When application gets the binary it also receives enum (integer

Re: [Mesa-dev] [PATCH v3 08/24] i965/fs: fix dst stride in IVB/BYT type conversions

On Thu, 2017-02-16 at 08:11 +0100, Samuel Iglesias Gonsálvez wrote: > On Wed, 2017-02-15 at 12:08 -0800, Francisco Jerez wrote: > > Samuel Iglesias Gonsálvez writes: > > > > > From: "Juan A. Suarez Romero" > > > > > > When converting a DF to 32-bit

Re: [Mesa-dev] [PATCH v3 08/24] i965/fs: fix dst stride in IVB/BYT type conversions

On Wed, 2017-02-15 at 12:08 -0800, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > From: "Juan A. Suarez Romero" > > > > When converting a DF to 32-bit conversions, we set dst stride to 2, > > to fulfill alignment restrictions because

Re: [Mesa-dev] [PATCH v3 06/24] i965: Use <0, 2, 1> region for scalar DF sources on IVB/BYT.

On Wed, 2017-02-15 at 11:45 -0800, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > From: Matt Turner > > > > On HSW+, scalar DF sources can be accessed using the normal <0,1,0> > > region, but on IVB and BYT DF regions must be

Re: [Mesa-dev] [PATCH v3 04/24] i965/fs: double regioning parameters and execsize for DF in IVB/BYT

On Wed, 2017-02-15 at 11:41 -0800, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > From: "Juan A. Suarez Romero" > > > > In IVB and BYT, both regioning parameters and execution sizes are > > measured as > > 32-bits element size. > >

Re: [Mesa-dev] [RFC] spec: MESA_program_binary

On 02/16/2017 04:52 AM, Timothy Arceri wrote: In order add functionality to ARB_get_program_binary we need binary format enums. I've understood that this is a driver internal enumeration. When application gets the binary it also receives enum (integer value) what format we gave. Then when

[Mesa-dev] [PATCH v2 2/2] i965: Make a helper for emitting 3DSTATE_CONSTANT_XS packets.

This separates the logic from filling out a 3DSTATE_CONSTANT_XS packet from the decisions about what to put in the various buffers. It also should make it easier to use more than one buffer, should we decide to do so. It also provides a nice place to enforce the various restrictions via

Re: [Mesa-dev] [PATCH 2/2] i965: Make a helper for emitting 3DSTATE_CONSTANT_XS packets.

On Wednesday, February 15, 2017 3:23:14 PM PST Jordan Justen wrote: > On 2017-02-14 13:45:49, Kenneth Graunke wrote: [snip] > > diff --git a/src/mesa/drivers/dri/i965/gen6_constant_state.c > > b/src/mesa/drivers/dri/i965/gen6_constant_state.c > > index 6c0c32b26f7..7e6fa92ecf2 100644 > > ---

Re: [Mesa-dev] [RFC] spec: MESA_program_binary

On 16/02/17 15:42, Edward O'Callaghan wrote: On 02/16/2017 01:52 PM, Timothy Arceri wrote: In order add functionality to ARB_get_program_binary we need binary format enums. --- Techland games such as Dead Island and Dying Light make use of GetProgramBinary(). My current guess is the Dead

Re: [Mesa-dev] [PATCH 1/3] radeon/ac: add emit umsb shared code.

This series is, Reviewed-by: Edward O'Callaghan On 02/16/2017 02:55 PM, Dave Airlie wrote: > From: Dave Airlie > > Since we shared imsb, makes sense to share umsb. > > Signed-off-by: Dave Airlie > --- >

Re: [Mesa-dev] [PATCH 1/4] radeon/ac: add ac_emit_imsb helper.

This series is, Reviewed-by: Edward O'Callaghan On 02/16/2017 02:48 PM, Dave Airlie wrote: > From: Dave Airlie > > We want to use a different intrinsic on newer llvm, so move this > code to a shared area. > > Signed-off-by: Dave Airlie

Re: [Mesa-dev] [RFC] spec: MESA_program_binary

On 02/16/2017 01:52 PM, Timothy Arceri wrote: > In order add functionality to ARB_get_program_binary we need > binary format enums. > --- > > Techland games such as Dead Island and Dying Light make use of > GetProgramBinary(). My current guess is the Dead Island crash >

Re: [Mesa-dev] [PATCH v2 2/2] [swr] remove unneeded extern "C"

Thanks for taking care of these! Reviewed-by: Ilia Mirkin On Wed, Feb 15, 2017 at 10:53 PM, George Kyriazis wrote: > the guards have been added to the header files that needed them. > --- > src/gallium/drivers/swr/swr_context.cpp | 3 --- > 1

Re: [Mesa-dev] [PATCH v2 1/2] [util] add extern "C" guards

On Wed, Feb 15, 2017 at 10:53 PM, George Kyriazis wrote: > Added extern "C" __cplusplus guards on headers that did not have them. > --- > src/gallium/auxiliary/util/u_transfer.h | 8 > src/gallium/auxiliary/util/u_upload_mgr.h | 7 +++ > 2 files changed,

[Mesa-dev] [PATCH 2/3] radv/ac: use shader umsb helper.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index

[Mesa-dev] [PATCH 3/3] radeonsi: use shared emit_umsb helper.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 24 ++- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c

[Mesa-dev] [PATCH 1/3] radeon/ac: add emit umsb shared code.

From: Dave Airlie Since we shared imsb, makes sense to share umsb. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_build.c | 25 + src/amd/common/ac_llvm_build.h | 4 2 files changed, 29 insertions(+) diff --git

[Mesa-dev] [PATCH v2 1/2] [util] add extern "C" guards

Added extern "C" __cplusplus guards on headers that did not have them. --- src/gallium/auxiliary/util/u_transfer.h | 8 src/gallium/auxiliary/util/u_upload_mgr.h | 7 +++ 2 files changed, 15 insertions(+) diff --git a/src/gallium/auxiliary/util/u_transfer.h

[Mesa-dev] [PATCH v2 2/2] [swr] remove unneeded extern "C"

the guards have been added to the header files that needed them. --- src/gallium/drivers/swr/swr_context.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers/swr/swr_context.cpp b/src/gallium/drivers/swr/swr_context.cpp index 2e37bac..3e17edc 100644 ---

[Mesa-dev] [PATCH 1/4] radeon/ac: add ac_emit_imsb helper.

From: Dave Airlie We want to use a different intrinsic on newer llvm, so move this code to a shared area. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_build.c | 24 src/amd/common/ac_llvm_build.h | 4 2 files

[Mesa-dev] [PATCH 2/4] radv/ac: use shader imsb emission code.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index

[Mesa-dev] [PATCH 3/4] radeonsi: use shared emit imsb code.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 28 +++ 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c

[Mesa-dev] [PATCH 4/4] radeon/ac: use llvm.amdgcn.sffbh intrinsic instead of AMDGPU.flbit.i32

From: Dave Airlie Use the newer intrinsic. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_build.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index

[Mesa-dev] [RFC] spec: MESA_program_binary

In order add functionality to ARB_get_program_binary we need binary format enums. --- Techland games such as Dead Island and Dying Light make use of GetProgramBinary(). My current guess is the Dead Island crash https://bugs.freedesktop.org/show_bug.cgi?id=85564 is caused due to buggy handling of

Re: [Mesa-dev] [PATCH] mesa: Always expose GREMEDY_string_marker.

I don't think that's right. Gremedy is a debugger application that exposes the extension to allow the app to send info to a debugger. It should not be exposed under normal circumstances as it may enable debug code paths in applications. If the issue is that an application is erroneously calling

[Mesa-dev] [PATCH] mesa: Always expose GREMEDY_string_marker.

Equivalent marker functionality is already included in KHR_debug, which we already expose unconditionally in all drivers (dummy_true). Grim Fandango Remastered apparently calls glStringMarkerGREMEDY() without checking for the extension, spewing GL errors. Assuming the existence of the extension

[Mesa-dev] [Bug 99817] [softpipe] piglit glsl-fs-tan-1 regression

https://bugs.freedesktop.org/show_bug.cgi?id=99817 --- Comment #4 from Vinson Lee --- attachment 129616 fixes the regression. Tested-by: Vinson Lee -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

Re: [Mesa-dev] [PATCH 2/2] i965: Make a helper for emitting 3DSTATE_CONSTANT_XS packets.

On 2017-02-14 13:45:49, Kenneth Graunke wrote: > This separates the logic from filling out a 3DSTATE_CONSTANT_XS > packet from the decisions about what to put in the various buffers. > > It also should make it easier to use more than one buffer, should > we decide to do so. It also provides a

[Mesa-dev] [Bug 99817] [softpipe] piglit glsl-fs-tan-1 regression

https://bugs.freedesktop.org/show_bug.cgi?id=99817 Vinson Lee changed: What|Removed |Added Keywords||bisected

Re: [Mesa-dev] [PATCH] anv: implement pipeline statistics queries

On Tue, Jan 24, 2017 at 5:27 PM, Robert Bragg wrote: > Depending on how strictly we consider that the queries should only measure > the commands they bracket then I think some stalling will be necessary to > serialize the work associated with a query and defer

[Mesa-dev] [PATCH 4/5] nir/lower_indirect: Use nir_builder control-flow helpers

--- src/compiler/nir/nir_lower_indirect_derefs.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/src/compiler/nir/nir_lower_indirect_derefs.c b/src/compiler/nir/nir_lower_indirect_derefs.c index 09cc9a3..52adde8 100644 ---

[Mesa-dev] [PATCH 0/5] nir/builder: Add control-flow helpers

I was looking at Ian's int64 lowering code last night and was thinking about what the lowering would look like in NIR. The fact that it uses loops and other control flow for handling division got me thinking about doing control flow in nir_builder again. So I spent a little time this morning and

[Mesa-dev] [PATCH 3/5] nir/lower_gs_intrinsics: Use nir_builder control-flow helpers

--- src/compiler/nir/nir_lower_gs_intrinsics.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/compiler/nir/nir_lower_gs_intrinsics.c b/src/compiler/nir/nir_lower_gs_intrinsics.c index 3acb742..68e20dd 100644 --- a/src/compiler/nir/nir_lower_gs_intrinsics.c +++

[Mesa-dev] [PATCH 5/5] spirv: Use nir_builder for control flow

--- src/compiler/spirv/vtn_cfg.c | 45 ++-- 1 file changed, 14 insertions(+), 31 deletions(-) diff --git a/src/compiler/spirv/vtn_cfg.c b/src/compiler/spirv/vtn_cfg.c index 3a31657..54248b1 100644 --- a/src/compiler/spirv/vtn_cfg.c +++

[Mesa-dev] [PATCH 2/5] glsl/nir: Use nir_builder's new control-flow helpers

--- src/compiler/glsl/glsl_to_nir.cpp | 38 +++--- 1 file changed, 11 insertions(+), 27 deletions(-) diff --git a/src/compiler/glsl/glsl_to_nir.cpp b/src/compiler/glsl/glsl_to_nir.cpp index 96d8164..e46fe2c 100644 --- a/src/compiler/glsl/glsl_to_nir.cpp +++

[Mesa-dev] [PATCH 1/5] nir/builder: Add support for easily building control-flow

Each of the pop functions (and push_else) take a control flow parameter as their second argument. If NULL, it assumes that the builder is in a block that's a direct child of the control-flow node you want to pop off the virtual stack. This is what 90% of consumers will want. The SPIR-V pass,

Re: [Mesa-dev] [PATCH] [swr] fix windows build

Yeah, just like all the other headers: #ifdef __cplusplus extern "C" { #endif define api's #ifdef __cplusplus } #endif You can see examples in, e.g., u_bitcast.h (picked one at random). On Wed, Feb 15, 2017 at 5:45 PM, Kyriazis, George wrote: > You mean use extern

Re: [Mesa-dev] [PATCH] [swr] fix windows build

You mean use extern "C" (inside a c++ guard) on u_upload_mgr.h and friends? Thanks, George > -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Wednesday, February 15, 2017 4:25 PM > To: Kyriazis, George

Re: [Mesa-dev] [PATCH] util/disk_cache: do not allow space in MESA_GLSL_CACHE_MAX_SIZE

On 16/02/17 03:37, Emil Velikov wrote: On 9 February 2017 at 13:35, Emil Velikov wrote: From: Emil Velikov No other env var used in mesa allows for space in the variable contents. Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH] [swr] fix windows build

I'd rather see the remainder of the headers fixed to be includable from C++ contexts. extern "C" { #include } is an anti-pattern... -ilia On Wed, Feb 15, 2017 at 5:23 PM, George Kyriazis wrote: > move util/u_upload_mgr.h inside extern "C" > --- >

[Mesa-dev] [PATCH] [swr] fix windows build

move util/u_upload_mgr.h inside extern "C" --- src/gallium/drivers/swr/swr_context.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/swr_context.cpp b/src/gallium/drivers/swr/swr_context.cpp index 2e37bac..04ff146 100644 ---

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

On Wed, Feb 15, 2017 at 1:54 PM, Chad Versace wrote: > On Wed 15 Feb 2017, Emil Velikov wrote: > > On 14 February 2017 at 21:02, Chad Versace > wrote: > > > On Tue 14 Feb 2017, Kenneth Graunke wrote: > > >> On Tuesday, February 14, 2017

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

On Wed 15 Feb 2017, Emil Velikov wrote: > On 14 February 2017 at 21:02, Chad Versace wrote: > > On Tue 14 Feb 2017, Kenneth Graunke wrote: > >> On Tuesday, February 14, 2017 12:38:45 PM PST Chad Versace wrote: > >> > On Tue 14 Feb 2017, Matt Turner wrote: > >> > > >> > >

Re: [Mesa-dev] How about vk_features.txt?

I won't have time for the next 2 weeks, but after that I'll propose a file formatted in a way that is both easy to parse and easy to edit by a human. 2017-02-12 21:58 GMT-05:00 Jason Ekstrand : > I'm certainly not opposed. I've considered adding such a tracking file > for

[Mesa-dev] [PATCH 1/3] Separate INTEL_performance_query frontend

To allow the backend interfaces for AMD_performance_monitor and INTEL_performance_query to evolve independently based on the more specific requirements of each extension this starts by separating the frontends of these extensions. Even though there wasn't much tying these frontends together, this

[Mesa-dev] [PATCH 2/3] Model INTEL perf query backend after query object BE

Instead of using the same backend interface as AMD_performance_monitor this defines a dedicated INTEL_performance_query interface that is modelled more on the ARB_query_buffer_object interface (considering the similarity of the extensions) with the addition of vfuncs for initializing and

[Mesa-dev] [PATCH 3/3] i965: Implement INTEL_performance_query backend

This adds a bare-bones backend for the INTEL_performance_query extension that exposes pipeline statistics. Although this could be considered redundant given that the same statistics are already available via query objects, they are a simple starting point for this extension and it's expected to

[Mesa-dev] [PATCH 0/3] i965: INTEL_performance_query for pipeline stats

To hopefully make progress towards landing support for OA unit metrics exposed via INTEL_performance_query the idea here is to first just tackle upstreaming the backend rework with an initial implementation supporting pipeline statistics. In case anyone wants to look ahead, my branch with these

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

Series is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

On 15 February 2017 at 19:00, Matt Turner wrote: > On Wed, Feb 15, 2017 at 6:05 AM, Emil Velikov > wrote: >> Hi Matt, >> >> On 14 February 2017 at 23:58, Matt Turner wrote: >>> The --build-id=... ld flag has been present since

Re: [Mesa-dev] [PATCH v3 09/24] i965/fs: fix lower SIMD width for IVB/BYT's MOV_INDIRECT

Samuel Iglesias Gonsálvez writes: > From: "Juan A. Suarez Romero" > > According to the IVB and HSW PRMs: > > "2.When the destination requires two registers and the sources are > indirect, the sources must use 1x1 regioning mode." > > So for DF

Re: [Mesa-dev] [PATCH v3 08/24] i965/fs: fix dst stride in IVB/BYT type conversions

Samuel Iglesias Gonsálvez writes: > From: "Juan A. Suarez Romero" > > When converting a DF to 32-bit conversions, we set dst stride to 2, > to fulfill alignment restrictions because the upper Dword of every > Qword will be written with undefined value.

[Mesa-dev] [Bug 99789] Memory leak on failure to create an ir_constant in calculate_iterations in loop_controls.cpp

https://bugs.freedesktop.org/show_bug.cgi?id=99789 Matt Turner changed: What|Removed |Added CC|damian.di...@gmail.com | --- Comment #1 from

Re: [Mesa-dev] [PATCH v3 06/24] i965: Use <0, 2, 1> region for scalar DF sources on IVB/BYT.

Samuel Iglesias Gonsálvez writes: > From: Matt Turner > > On HSW+, scalar DF sources can be accessed using the normal <0,1,0> > region, but on IVB and BYT DF regions must be programmed in terms of > floats. A <0,2,1> region accomplishes this. > > v2: >

Re: [Mesa-dev] [PATCH 1/3] radv/ac: add support for some integer size conversions.

On Wed, Feb 15, 2017, at 09:43, Dave Airlie wrote: > From: Dave Airlie > > zero extend ->u64 and sign extend ->i64. > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_nir_to_llvm.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH v3 04/24] i965/fs: double regioning parameters and execsize for DF in IVB/BYT

Samuel Iglesias Gonsálvez writes: > From: "Juan A. Suarez Romero" > > In IVB and BYT, both regioning parameters and execution sizes are measured as > 32-bits element size. > > So when we have something like: > > mov(8) g2<1>DF g3<4,4,1>DF > > We are

Re: [Mesa-dev] [PATCH 3/4] docs/submittingpatches.html: remove version tag for nominations

Emil Velikov writes: > From: Emil Velikov > > The version tag used to nominate has bitten even experienced mesa > developers. Not to mention that it deviates from the one used in the > kernel leading to further confusion. > > Simplify things

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

https://bugs.freedesktop.org/show_bug.cgi?id=99467 --- Comment #18 from Bogomil Vasilev --- I can confirm the same. The blurry colors are gone. The game works perfect so far. David, are you polishing the patches before pushing them? I'm asking is because I don't see any reason

[Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

Provides the ability to read the .note.gnu.build-id section of ELF binaries, which is inserted by the --build-id=... flag to ld. Reviewed-by: Emil Velikov --- configure.ac | 6 +++ src/util/Makefile.sources | 2 + src/util/build_id.c | 109

[Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

The --build-id=... ld flag has been present since binutils-2.18, released 28 Aug 2007. --- src/intel/vulkan/Makefile.am | 1 + src/intel/vulkan/anv_device.c | 28 +++- 2 files changed, 8 insertions(+), 21 deletions(-) diff --git a/src/intel/vulkan/Makefile.am

Re: [Mesa-dev] [PATCH] softpipe: implement clear_texture

Yes, I guess a new util_clear_texture helper would work - util_clear_render_target and util_clear_depth_stencil are modeled after the respective pipe functions too, so why not have a util_clear_texture modeled after the respective pipe function... Maybe rip out most of the actual implementation of

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

Reviewed-by: Jason Ekstrand Thanks for getting this figured out! On Tue, Feb 14, 2017 at 3:58 PM, Matt Turner wrote: > The --build-id=... ld flag has been present since binutils-2.18, > released 28 Aug 2007. > --- > src/intel/vulkan/Makefile.am | 1

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

On Wed, Feb 15, 2017 at 10:57 AM, Matt Turner wrote: > On Wed, Feb 15, 2017 at 4:03 AM, Emil Velikov > wrote: > > Hi Matt, > > > > Afaics dl_iterate_phdr is available on musl, (some?) BSDs and Solaris > > - thank you for opting for it. > > > > Out

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

https://bugs.freedesktop.org/show_bug.cgi?id=99467 --- Comment #17 from Joeri Capens --- The new patches work great for me. No more brightly colored fog which occurred randomly and often made the game impossible to play. I'm on Gentoo with a 4.9.9 kernel, RX 460 card. Thank

Re: [Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

On Wed, Feb 15, 2017 at 6:05 AM, Emil Velikov wrote: > Hi Matt, > > On 14 February 2017 at 23:58, Matt Turner wrote: >> The --build-id=... ld flag has been present since binutils-2.18, >> released 28 Aug 2007. >> --- >> src/intel/vulkan/Makefile.am

Re: [Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

On Wed, Feb 15, 2017 at 4:03 AM, Emil Velikov wrote: > Hi Matt, > > Afaics dl_iterate_phdr is available on musl, (some?) BSDs and Solaris > - thank you for opting for it. > > Out of curiosity: > Have you checked if on those platforms the "GNU\0" strcmp is > applicable

Re: [Mesa-dev] [PATCH] getteximage: Return correct error value when texure object is not found

On 02/15/2017 01:56 PM, Nicolai Hähnle wrote: > On 15.02.2017 12:14, Eduardo Lima Mitev wrote: >> glGetTextureSubImage() and glGetCompressedTextureSubImage() are currently >> returning INVALID_OPERATION error when the passed texture argument >> does not >> correspond to an existing texture object.

Re: [Mesa-dev] [PATCH] anv/formats: handle correctly multisamples in gen7

On Wed, Feb 15, 2017 at 10:09 AM, Juan A. Suarez Romero wrote: > According to Ivybridge PRM, Volume 4 Part 1 p73, signed integer formats > cannot be multisampled. > > Also in the same PRM p63, any format with greater than 64 bits per > element cannot be multisampled. > >

[Mesa-dev] [PATCH] anv/formats: handle correctly multisamples in gen7

According to Ivybridge PRM, Volume 4 Part 1 p73, signed integer formats cannot be multisampled. Also in the same PRM p63, any format with greater than 64 bits per element cannot be multisampled. This fixes the following Vulkan CTS tests in Haswell:

Re: [Mesa-dev] [PATCH] util: Fix a typo in Makefile.sources

Reviewed-by: Eric Engestrom On Wednesday, 2017-02-15 09:30:01 -0800, Jason Ekstrand wrote: > --- > src/util/Makefile.sources | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/util/Makefile.sources b/src/util/Makefile.sources > index

Re: [Mesa-dev] [PATCH] egl: _eglFilterArray's filter is always non-null

On Wednesday, 2017-02-15 15:36:00 +, Emil Velikov wrote: > From: Emil Velikov > > Drop the extra handling and assert() if things change in the future. > > Signed-off-by: Emil Velikov Reviewed-by: Eric Engestrom

[Mesa-dev] [PATCH] util: Fix a typo in Makefile.sources

--- src/util/Makefile.sources | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/Makefile.sources b/src/util/Makefile.sources index eec0311..aecb7c2 100644 --- a/src/util/Makefile.sources +++ b/src/util/Makefile.sources @@ -45,7 +45,7 @@ MESA_UTIL_FILES :=\

Re: [Mesa-dev] [PATCH 1/2] util: Add helpers for iterating over Vulkan extension structs

On Wed, Feb 15, 2017 at 2:14 AM, Grazvydas Ignotas wrote: > On Wed, Feb 15, 2017 at 2:03 AM, Jason Ekstrand > wrote: > > --- > > src/util/Makefile.sources | 3 ++- > > src/util/vk_util.h| 43 ++ > + > > 2

Re: [Mesa-dev] [PATCH] i965: define default allow_higher_compat_version value

Reviewed-by: Matt Turner Please commit ASAP. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: define default allow_higher_compat_version value

Thanks. Reviewed-by: Samuel Pitoiset On 02/15/2017 05:59 PM, Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin Fixes: 9d16f3903e2 ("driconf: add allow_higher_compat_version option") ---

[Mesa-dev] [PATCH] i965: define default allow_higher_compat_version value

Signed-off-by: Lionel Landwerlin Fixes: 9d16f3903e2 ("driconf: add allow_higher_compat_version option") --- src/mesa/drivers/dri/i965/intel_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c

Re: [Mesa-dev] [PATCH v2 1/4] driconf: add allow_higher_compat_version option

Hey Samuel, I think you forgot to define the default value for our driver. I'm not too familiar with this code. Is there a way to have default values for all dri drivers? Thanks, - Lionel On 15/02/17 16:42, Samuel Pitoiset wrote: On 02/15/2017 05:36 PM, Mark Janes wrote: With this

Re: [Mesa-dev] [PATCH 32/32] r600/radeonsi: enable glsl/tgsi on-disk cache

On Wed, Feb 15, 2017 at 1:49 PM, Nicolai Hähnle wrote: > On 14.02.2017 23:51, Marek Olšák wrote: >> >> On Tue, Feb 14, 2017 at 11:47 PM, Timothy Arceri >> wrote: >>> >>> >>> >>> On 15/02/17 08:35, Marek Olšák wrote: On Tue, Feb 14, 2017

Re: [Mesa-dev] [PATCH v2 1/4] driconf: add allow_higher_compat_version option

With this series, I encounter the following crash using wflinfo: wflinfo: src/mesa/drivers/dri/common/xmlconfig.c:1028: driQueryOptionb: Assertion `cache->info[i].name != ((void *)0)' failed. Samuel Pitoiset writes: > Mesa currently doesn't allow to create 3.1+

Re: [Mesa-dev] [PATCH v2 6/6] anv: do not open random render node(s)

On 15 February 2017 at 16:38, Ilia Mirkin wrote: >> +anv_enumerate_devices(struct anv_instance *instance) >> +{ >> + /* TODO: Check for more devices ? */ >> + drmDevicePtr devices[8]; >> + VkResult result = VK_SUCCESS; Should read VkResult result =

Re: [Mesa-dev] [RFC] nir/builder: Add support for easily building control-flow

Only build-tested. On Wed, Feb 15, 2017 at 8:43 AM, Jason Ekstrand wrote: > --- > src/compiler/nir/nir_builder.h | 41 ++ > +++ > 1 file changed, 41 insertions(+) > > diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_ >

[Mesa-dev] [RFC] nir/builder: Add support for easily building control-flow

--- src/compiler/nir/nir_builder.h | 41 + 1 file changed, 41 insertions(+) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h index 194d327..cdfc15b 100644 --- a/src/compiler/nir/nir_builder.h +++ b/src/compiler/nir/nir_builder.h

Re: [Mesa-dev] [PATCH v2 1/4] driconf: add allow_higher_compat_version option

On 02/15/2017 05:36 PM, Mark Janes wrote: With this series, I encounter the following crash using wflinfo: wflinfo: src/mesa/drivers/dri/common/xmlconfig.c:1028: driQueryOptionb: Assertion `cache->info[i].name != ((void *)0)' failed. Mmh. Can you provide a full backtrace? Samuel

Re: [Mesa-dev] [PATCH v2 6/6] anv: do not open random render node(s)

On Wed, Feb 15, 2017 at 10:51 AM, Emil Velikov wrote: > From: Emil Velikov > > drmGetDevices2() provides us with enough flexibility to build heuristics > upon. Opening a random node on the other hand will wake up the device, > regardless if

Re: [Mesa-dev] [PATCH] util/disk_cache: do not allow space in MESA_GLSL_CACHE_MAX_SIZE

On 9 February 2017 at 13:35, Emil Velikov wrote: > From: Emil Velikov > > No other env var used in mesa allows for space in the variable contents. > > Signed-off-by: Emil Velikov > --- > Worth documenting and/or

[Mesa-dev] [PATCH] anv: remove spec quote from anv_EnumeratePhysicalDevices

From: Emil Velikov The VK_SUCCESS/VK_INCOMPLETE pattern is quite common. Signed-off-by: Emil Velikov --- Based on top of the drmGetDevice2 series sent earlier. src/intel/vulkan/anv_device.c | 17 - 1 file changed, 17

[Mesa-dev] [PATCH v2 3/6] winsys/amdgpu: use drmGetDevice2 API

From: Emil Velikov Analogous to previous commit Signed-off-by: Emil Velikov Reviewed-by: Michel Dänzer Reviewed-by: Marek Olšák Reviewed-by: Eric Engestrom ---

[Mesa-dev] [PATCH v2 2/6] loader: use drmGetDevice[s]2 API

From: Emil Velikov By this allows us to fetch the device list/info w/o the revision field. At the moment retrieving the latter wakes up the device. Note: kernel patch to resolve that should be in 4.10. Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH v2 5/6] radv: do not open random render node(s)

From: Emil Velikov drmGetDevices2() provides us with enough flexibility to build heuristics upon. Opening a random node on the other hand will wake up the device, regardless if it's the one we're interested or not. v2: Rebase. Cc: Michel Dänzer

[Mesa-dev] [PATCH v2 0/6] Use drmGetDevice[s]2 API

Hi all, This is mostly a resent from v1, with a couple of fixes on the ANV patch and commit message polish as per Eric/Michel's input. In case you've forgotten: Using the non "2" API fetches the PCI revision field, which wakes up the device [even if we don't end up using it], which can lead to

[Mesa-dev] [PATCH v2 4/6] radv/winsys: use drmGetDevice2 API

From: Emil Velikov Analogous to previous commit Cc: Dave Airlie Signed-off-by: Emil Velikov Reviewed-by: Michel Dänzer Reviewed-by: Bas Nieuwenhuizen Reviewed-by:

[Mesa-dev] [PATCH v2 1/6] autoconf/scons: bump libdrm to 2.4.75

From: Emil Velikov We'll be using the drmGetDevice[s]2 API in src/loader with next patch. v2: Rebase. Signed-off-by: Emil Velikov Reviewed-by: Michel Dänzer (v1) Reviewed-by: Eric Engestrom

[Mesa-dev] [PATCH v2 6/6] anv: do not open random render node(s)

From: Emil Velikov drmGetDevices2() provides us with enough flexibility to build heuristics upon. Opening a random node on the other hand will wake up the device, regardless if it's the one we're interested or not. v2: - Explicitly require/check for libdrm. - Zero

[Mesa-dev] [PATCH] egl: _eglFilterArray's filter is always non-null

From: Emil Velikov Drop the extra handling and assert() if things change in the future. Signed-off-by: Emil Velikov --- src/egl/main/eglarray.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff

Re: [Mesa-dev] [PATCH] softpipe: implement clear_texture

Happy to rework the implementation. Would creating a util_clear_texture function which pulls out the necessary components from util_clear_render_target be in alignment with what you're imagining? The idea would be to have util_clear_texture take a pipe_resource instead of a pipe_surface. Something

[Mesa-dev] [PATCHv2 2/6] docs/releasing: tweak the glxinfo/glxgear/etc. command lines

From: Emil Velikov Print only the information needed. Namely: *info: the DRI module picked and the vendor/renderer strings *gears: everything but the "...configuration file..." line(s) v2: (Eric) Use "2>&1 |" over "|&", properly escape &. Signed-off-by: Emil Velikov

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] i965/fs: fix indirect load DF uniforms on BSW/BXT

On Tue, 2017-02-14 at 11:11 -0800, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > Previously we were emitting two MOV_INDIRECT instructions by > > calculating > > source's indirect offsets for each 32-bit half of a DF source. > > However, > > this is not

Re: [Mesa-dev] [PATCH] spirv: handle SpvOpUConvert in proper place.

Oops... R-b On Feb 15, 2017 12:27 AM, "Dave Airlie" wrote: > From: Dave Airlie > > This was falling into the quantizetof16 path. > > Signed-off-by: Dave Airlie > --- > src/compiler/spirv/vtn_alu.c | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH 3/4] docs/submittingpatches.html: remove version tag for nominations

On 15 February 2017 at 12:33, Nicolai Hähnle wrote: > On 13.02.2017 20:23, Emil Velikov wrote: >> >> From: Emil Velikov >> >> The version tag used to nominate has bitten even experienced mesa >> developers. Not to mention that it deviates from the

Re: [Mesa-dev] [PATCH] glsl: link error if unsized array not-last in ssbo

I've forgot the --annotate to submit this comment about this patch, so here it is: This patch fixes an incorrect behavior exposed by the piglit tests about SSBOs and unsized arrays submitted by Dave Airlie not yet in master https://lists.freedesktop.org/archives/piglit/2016-May/019852.html Chema

  1   2   >