[Mesa-dev] [PATCH 5/4] radv: create on-disk shader cache

This is the drivers on-disk cache intended to be used as a fallback as opposed to the pipeline cache provided by apps. --- src/amd/vulkan/radv_device.c | 8 src/amd/vulkan/radv_private.h | 5 + src/util/disk_cache.h | 15 +++ 3 files changed, 28 insertions(+)

[Mesa-dev] [PATCH 6/4] radv: make use of on-disk cache

If the app provided and in-memory pipeline caches don't contain what we are looking for then we fallback to the on-disk cache. --- src/amd/vulkan/radv_pipeline_cache.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline_cache.c

[Mesa-dev] [PATCH] radv/ac: round cube array coordinate before fixup.

From: Dave Airlie This fixes: dEQP-VK.glsl.texture_functions.texture.samplercubearray* Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v2 07/18] anv/allocator: Add a BO cache

This cache allows us to easily ensure that we have a unique anv_bo for each gem handle. We'll need this in order to support multiple-import of memory objects and semaphores. v2 (Jason Ekstrand): - Reject BO imports if the size doesn't match the prime fd size as reported by lseek(). ---

[Mesa-dev] [PATCH] anv: Implement support for exporting semaphores as FENCE_FD

--- src/intel/vulkan/anv_batch_chain.c | 86 -- src/intel/vulkan/anv_device.c | 26 src/intel/vulkan/anv_gem.c | 36 src/intel/vulkan/anv_private.h | 24 --- src/intel/vulkan/anv_queue.c | 61

Re: [Mesa-dev] [PATCH 3/4] radv: fallback to an in-memory cache when no pipline cache is provided

On 15/03/17 15:17, Timothy Arceri wrote: --- src/amd/vulkan/radv_device.c | 4 +++- src/amd/vulkan/radv_pipeline.c | 9 ++--- src/amd/vulkan/radv_pipeline_cache.c | 7 +-- src/amd/vulkan/radv_private.h| 3 ++- 4 files changed, 16 insertions(+), 7 deletions(-) diff

[Mesa-dev] [PATCH 3/4] radv: fallback to an in-memory cache when no pipline cache is provided

--- src/amd/vulkan/radv_device.c | 4 +++- src/amd/vulkan/radv_pipeline.c | 9 ++--- src/amd/vulkan/radv_pipeline_cache.c | 7 +-- src/amd/vulkan/radv_private.h| 3 ++- 4 files changed, 16 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_device.c

[Mesa-dev] [PATCH 1/4] radv: move cache check inside insert and search functions

This will allow us to use fallback in-memory and on-disk caches should the app not provide a pipeline cache. --- src/amd/vulkan/radv_pipeline.c | 28 +--- src/amd/vulkan/radv_pipeline_cache.c | 8 +++- 2 files changed, 20 insertions(+), 16 deletions(-) diff

[Mesa-dev] [PATCH 2/4] radv: always create an fallback pipeline cache

This will be used as an in-memory cache when a pipeline cache is not provided by the app. --- src/amd/vulkan/radv_device.c | 15 +++ src/amd/vulkan/radv_private.h | 3 +++ 2 files changed, 18 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c

[Mesa-dev] [PATCH 4/4] radv: make sure gs copy shader is retrieved from the cache with the variant

Apps can limit the size of the cache via VkAllocationCallbacks so we can't be sure that both are always in the cache. --- src/amd/vulkan/radv_pipeline.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c

Re: [Mesa-dev] MESA and KOTOR

The game still crashes at the same null pointer, but I've seen it use that function you changed so I guess I'll keep the patch just to be safe. Are there any patches that touch wglMakeContextCurrentARB and didn't make it to master? (Resent the email because thunderbird removed the mesa-dev

Re: [Mesa-dev] MESA and KOTOR

The game runs smoothly if you decompress the textures, I'm getting 30-40 fps with llvmpipe and no "grass in the sky" artifacts. The problem is frame buffer effects and soft shadows, were they enabled when you tested it? If so, how did you make it use llvmpipe? Il 2017-03-13 22:40, Jan Vesely

Re: [Mesa-dev] MESA and KOTOR

Hello again, After further investigation it seems to me that wglMakeContextCurrentARB is not implemented by gallium llvmpipe, that's why it gets a null pointer. Can we add a stub or something? Il 2017-03-14 03:44, Brian Paul ha scritto: Looks like my KOTOR patch never made it to master.

Re: [Mesa-dev] mx6q: Cannot run Cinematic demo correctly

On Tue, Mar 14, 2017 at 2:53 PM, Fabio Estevam wrote: ... > Care to submit the revert for the two patches? I think Christian is going to proper fix it in next days; as we have a workaround for now I see no reason to speed this up. -- Otavio Salvador

Re: [Mesa-dev] mx6q: Cannot run Cinematic demo correctly

On Tue, Mar 14, 2017 at 12:31 PM, Fabio Estevam wrote: ... > The cover of the movies are just black rectangles instead of showing > the actual movie pictures. ... I am attaching the two patches I am applying on mesa locally and which has fixed our current issues. -- Otavio

Re: [Mesa-dev] mx6q: Cannot run Cinematic demo correctly

On Tue, Mar 14, 2017 at 2:39 PM, Christian Gmeiner wrote: > 2017-03-14 18:16 GMT+01:00 Fabio Estevam : ... > shader variants - due to lot of people are have this issue I will > spend some time the next > days to cleanup my wip patch series. I have

Re: [Mesa-dev] [PATCH] radeonsi: disable sinking common instructions down to the end block

On 03/15/2017 01:59 AM, Matt Arsenault wrote: On Mar 14, 2017, at 17:21, Samuel Pitoiset wrote: Initially this was a workaround for a bug introduced in LLVM 4.0 in the SimplifyCFG pass that caused image instrinsics to disappear (because they were badly sunk).

[Mesa-dev] [PATCH 1/2] radv/formats: reverse how the image format properties KHR2 is handled

From: Dave Airlie This just aligns with how anv does it. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_formats.c | 76 ++- 1 file changed, 46 insertions(+), 30 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] radv: add external memory support.

From: Dave Airlie This adds support for exporting 2D images, to an opaque fd. This implements the: VK_KHX_external_memory_capabilities VK_KHX_external_memory VK_KHX_external_memory_fd extensions. These are used by SteamVR, we should work with anv to decide if we should

[Mesa-dev] [PATCH] radeonsi: disable sinking common instructions down to the end block

Initially this was a workaround for a bug introduced in LLVM 4.0 in the SimplifyCFG pass that caused image instrinsics to disappear (because they were badly sunk). Finally, this is a win because it decreases SGPR spilling and increases the number of waves a bit. Although, shader-db results are

Re: [Mesa-dev] [PATCH 2/7] isl: Refactor row pitch calculation (v2)

On Mon, Mar 13, 2017 at 03:27:59PM -0700, Chad Versace wrote: > The calculations of row_pitch, the row pitch's alignment, surface size, > and base_alignment were mixed together. This patch moves the calculation > of row_pitch and its alignment to occur before the calculation of > surface_size and

Re: [Mesa-dev] [PATCH shader-db] run: disable GLSL shader cache

Reviewed-by: Marek Olšák Marek On Wed, Mar 15, 2017 at 12:17 AM, Samuel Pitoiset wrote: > I think we just don't want to store those shaders. > > Signed-off-by: Samuel Pitoiset > --- > run.c | 1 + > 1 file changed, 1

Re: [Mesa-dev] [PATCH] radv/ac: workaround regression in llvm 4.0 release

On 03/14/2017 10:21 PM, Dave Airlie wrote: On 15 March 2017 at 07:17, Dave Airlie wrote: From: Dave Airlie LLVM 4.0 released with a pretty messy regression, that hopefully get fixed in the future. This work around was proposed by Tom, and it fixes

Re: [Mesa-dev] [PATCH 1/7] isl: Drop misplaced comment about padding

On Mon, Mar 13, 2017 at 03:27:58PM -0700, Chad Versace wrote: > isl has a giant comment that explains the hardware's padding > requirements. (Hint: Cache lines and page faults). But the comment is in > the wrong place, in isl_calc_linear_row_pitch(), which is unrelated to > padding. > > The

Re: [Mesa-dev] [PATCH 2/2] radv: Set driver version to mesa version;

14.03.2017 u 23:08, Bas Nieuwenhuizen je napisao/la: I couldn't really find an encoding in the spec. I'm not sure it prescribes VK_MAKE_VERSION format, but vulkan.gpuinfo.org interprets it that way by default. vulkaninfo gives the raw number, so we could alternatively do something like 17001000,

[Mesa-dev] [PATCH shader-db] run: disable GLSL shader cache

I think we just don't want to store those shaders. Signed-off-by: Samuel Pitoiset --- run.c | 1 + 1 file changed, 1 insertion(+) diff --git a/run.c b/run.c index 74f87fd..12a78c6 100644 --- a/run.c +++ b/run.c @@ -392,6 +392,7 @@ main(int argc, char **argv)

[Mesa-dev] [PATCH 2/2] radv: Set driver version to mesa version;

I couldn't really find an encoding in the spec. I'm not sure it prescribes VK_MAKE_VERSION format, but vulkan.gpuinfo.org interprets it that way by default. vulkaninfo gives the raw number, so we could alternatively do something like 17001000, but that doesn't show up right on vulkan.gpuinfo.org

Re: [Mesa-dev] [PATCH] radv: Flush before copying with PKT3_WRITE_DATA in CmdUpdateBuffer

Thanks. Pushed. On Tue, Mar 14, 2017 at 4:26 PM, Alex Smith wrote: > Need to flush before updating the buffer to ensure that the copy is > ordered after previous accesses (assuming the app has performed the > appropriate barriers). > > This fixes potential issues due

[Mesa-dev] [PATCH 1/2] radv: Increase api version to 1.0.42.

I've skimmed to changes from 1.0.5 to 1.0.42 and I think we have all changes. We're still not conformant ofcourse, but this should not regress stuff, Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 3/6] [v6] gbm: Introduce modifiers into surface/bo creation

The idea behind modifiers like this is that the user of GBM will have some mechanism to query what properties the hardware supports for its BO or surface. This information is directly passed in (and stored) so that the DRI implementation can create an image with the appropriate attributes. A

Re: [Mesa-dev] [PATCH] radv/ac: workaround regression in llvm 4.0 release

On 15 March 2017 at 07:17, Dave Airlie wrote: > From: Dave Airlie > > LLVM 4.0 released with a pretty messy regression, that hopefully > get fixed in the future. > > This work around was proposed by Tom, and it fixes the CTS regressions > here at least, I'm

[Mesa-dev] [PATCH] radv/ac: workaround regression in llvm 4.0 release

From: Dave Airlie LLVM 4.0 released with a pretty messy regression, that hopefully get fixed in the future. This work around was proposed by Tom, and it fixes the CTS regressions here at least, I'm not sure if this will cause any major side effects, but correctness over

[Mesa-dev] [PATCH 1/2] nir/constant_expressions: Pull the guts out into a helper block

--- src/compiler/nir/nir_constant_expressions.py | 199 ++- 1 file changed, 101 insertions(+), 98 deletions(-) diff --git a/src/compiler/nir/nir_constant_expressions.py b/src/compiler/nir/nir_constant_expressions.py index c6745f1..ad841e3 100644 ---

[Mesa-dev] [PATCH 2/2] nir/constant_expressions: Don't switch on bit size when not needed

For opcodes such as the nir_op_pack_64_2x32 for which all sources and destinations have explicit sizes, the bit_size parameter to the evaluate function is pointless and *should* do nothing. Previously, we were always switching on the bit_size and asserting if it isn't one of the sizes in the

[Mesa-dev] [PATCH] radv: Emit cache flushes before CP DMA.

The flushes could be due to TRANSFER barriers. Signed-off-by: Bas Nieuwenhuizen Cc: 17.0 --- src/amd/vulkan/si_cmd_buffer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/si_cmd_buffer.c

Re: [Mesa-dev] [PATCH 3/6] gbm: Introduce modifiers into surface/bo creation

On 17-03-14 08:53:45, Jason Ekstrand wrote: On Mon, Mar 13, 2017 at 10:24 PM, Ben Widawsky wrote: The idea behind modifiers like this is that the user of GBM will have some mechanism to query what properties the hardware supports for its BO or surface. This information is

[Mesa-dev] [Bug 94739] Mesa 11.1.2 implementation error: bad format MESA_FORMAT_Z_FLOAT32 in _mesa_unpack_uint_24_8_depth_stencil_row

https://bugs.freedesktop.org/show_bug.cgi?id=94739 Luca Weiss changed: What|Removed |Added CC||bugzi...@z3ntu.xyz ---

Re: [Mesa-dev] MESA and KOTOR

On Tue, 2017-03-14 at 05:22 +0100, Federico Dossena wrote: > The game runs smoothly if you decompress the textures, I'm getting 30-40 > fps with llvmpipe and no "grass in the sky" artifacts. > The problem is frame buffer effects and soft shadows, were they enabled > when you tested it? If so,

[Mesa-dev] [Bug 100199] clover: implement non-blocking clEnqueueWriteBuffer and clEnqueueReadBuffer

https://bugs.freedesktop.org/show_bug.cgi?id=100199 --- Comment #2 from Vedran Miletić --- Benchmarking ftp://ftp.gromacs.org/pub/benchmarks/water_GMX50_bare.tar.gz with GROMACS 2016.3 I get the following results: Without the patch: Launch GPU ops.18 66001

Re: [Mesa-dev] mx6q: Cannot run Cinematic demo correctly

Hi Wladimir, On Tue, Mar 14, 2017 at 2:47 PM, Wladimir J. van der Laan wrote: > Yea, variants would be the way to render to RGBA succesfully > on vivantes. > > Until then it's best to revert those two patches. > > Reverting only the one (latest) patch can give red/blue swapped

Re: [Mesa-dev] mx6q: Cannot run Cinematic demo correctly

On Tue, Mar 14, 2017 at 06:39:32PM +0100, Christian Gmeiner wrote: > > By only reverting: > > > > commit 6c89a728d9e5d072cb504453e73077564c6523d3 > > Author: Wladimir J. van der Laan > > Date: Wed Dec 7 12:59:54 2016 + > > > > etnaviv: Cannot render to rb-swapped

Re: [Mesa-dev] mx6q: Cannot run Cinematic demo correctly

Hi Fabio 2017-03-14 18:16 GMT+01:00 Fabio Estevam : > Hi Otavio, > > On Tue, Mar 14, 2017 at 1:58 PM, Otavio Salvador > wrote: >> On Tue, Mar 14, 2017 at 12:31 PM, Fabio Estevam wrote: >> ... >>> The cover of the movies

[Mesa-dev] [Bug 99987] Mesa 13+ breaks Xvnc (and similar X servers)

https://bugs.freedesktop.org/show_bug.cgi?id=99987 --- Comment #15 from Dennis Schridde --- (In reply to Pierre Ossman from comment #14) > b) If it is indeed a fallback, why is that needed? I.e. why isn't Mesa being > chosen? It does not seem robust and future proof to rely

Re: [Mesa-dev] mx6q: Cannot run Cinematic demo correctly

Hi Otavio, On Tue, Mar 14, 2017 at 1:58 PM, Otavio Salvador wrote: > On Tue, Mar 14, 2017 at 12:31 PM, Fabio Estevam wrote: > ... >> The cover of the movies are just black rectangles instead of showing >> the actual movie pictures. > ... > >

[Mesa-dev] [Bug 100202] llvmpipe Windows scons build can't detect Visual Studio 2017 toolchain

https://bugs.freedesktop.org/show_bug.cgi?id=100202 Bug ID: 100202 Summary: llvmpipe Windows scons build can't detect Visual Studio 2017 toolchain Product: Mesa Version: 17.0 Hardware: All OS: Windows (All)

Re: [Mesa-dev] [PATCH 1/2] anv/image: Move handling of INTEL_VK_HIZ

On Tue, Mar 14, 2017 at 07:55:01AM -0700, Jason Ekstrand wrote: > This makes it so that you don't get an "Implement gen7 HiZ" perf warning > when you manually disable HiZ on gen8. Both: Reviewed-by: Topi Pohjolainen > --- > src/intel/vulkan/anv_image.c | 4 ++-- >

[Mesa-dev] [Bug 100201] llvmpipe Windows scons build with Visual Studio 2015 toolchain and LLVM 4.0 fails

https://bugs.freedesktop.org/show_bug.cgi?id=100201 Bug ID: 100201 Summary: llvmpipe Windows scons build with Visual Studio 2015 toolchain and LLVM 4.0 fails Product: Mesa Version: 17.0 Hardware: All OS:

Re: [Mesa-dev] [PATCH 3/6] gbm: Introduce modifiers into surface/bo creation

The comments below are my only remaining questions on this 6-patch series. All of the *other* patches are Reviewed-by: Jason Ekstrand On Tue, Mar 14, 2017 at 8:53 AM, Jason Ekstrand wrote: > On Mon, Mar 13, 2017 at 10:24 PM, Ben Widawsky

Re: [Mesa-dev] [PATCH 3/6] gbm: Introduce modifiers into surface/bo creation

On Mon, Mar 13, 2017 at 10:24 PM, Ben Widawsky wrote: > The idea behind modifiers like this is that the user of GBM will have > some mechanism to query what properties the hardware supports for its BO > or surface. This information is directly passed in (and stored) so that >

[Mesa-dev] [Bug 99987] Mesa 13+ breaks Xvnc (and similar X servers)

https://bugs.freedesktop.org/show_bug.cgi?id=99987 --- Comment #14 from Pierre Ossman --- That does make things work. But I'm hesitant to consider the issue closed though. There are some outstanding questions: a) I'm still getting direct rendering, despite the file being

[Mesa-dev] [Bug 100199] clover: implement non-blocking clEnqueueWriteBuffer and clEnqueueReadBuffer

https://bugs.freedesktop.org/show_bug.cgi?id=100199 --- Comment #1 from Vedran Miletić --- Created attachment 130217 --> https://bugs.freedesktop.org/attachment.cgi?id=130217=edit Attempt at a fix -- You are receiving this mail because: You are the QA Contact for the

Re: [Mesa-dev] [PATCH] vulkan: enums: fix generation with enum aliases

On Tue, Mar 14, 2017 at 4:04 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > It seems new extensions will start to use aliases in enums, meaning > multiple enums with the same value. This forces us to track the values > of the enums to generate correct C code. > Seriously? That

[Mesa-dev] [Bug 100199] clover: implement non-blocking clEnqueueWriteBuffer and clEnqueueReadBuffer

https://bugs.freedesktop.org/show_bug.cgi?id=100199 Vedran Miletić changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |ved...@miletic.net

[Mesa-dev] [Bug 100199] clover: implement non-blocking clEnqueueWriteBuffer and clEnqueueReadBuffer

https://bugs.freedesktop.org/show_bug.cgi?id=100199 Bug ID: 100199 Summary: clover: implement non-blocking clEnqueueWriteBuffer and clEnqueueReadBuffer Product: Mesa Version: git Hardware: Other OS: All

[Mesa-dev] mx6q: Cannot run Cinematic demo correctly

Hi, On a imx6q-sabresd board running kernel 4.9.14, mesa 17.0.1 and QT5.8: # export QT_QPA_EGLFS_KMS_CONFIG=/media/sabresd.json where sabresd.json contains: { "device": "/dev/dri/card1", "hwcursor": false, "pbuffers": true, "outputs": [ { "name": "HDMI-1", "mode": "off"

[Mesa-dev] [PATCH] radv: Flush before copying with PKT3_WRITE_DATA in CmdUpdateBuffer

Need to flush before updating the buffer to ensure that the copy is ordered after previous accesses (assuming the app has performed the appropriate barriers). This fixes potential issues due to draws prior to an update reading the new buffer content, despite having the necessary barriers between

[Mesa-dev] [PATCH 4/4] anv: Use subpass dependencies for flushes

Instead of figuring it all out ourselves, just use the information given to us by the client. --- src/intel/vulkan/anv_blorp.c | 88 -- src/intel/vulkan/genX_cmd_buffer.c | 10 + 2 files changed, 18 insertions(+), 80 deletions(-) diff --git

[Mesa-dev] [PATCH 3/4] anv/pass: Record required pipe flushes

--- src/intel/vulkan/anv_pass.c| 87 ++ src/intel/vulkan/anv_private.h | 2 + 2 files changed, 89 insertions(+) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index 8d1768d..d6d3794 100644 --- a/src/intel/vulkan/anv_pass.c +++

[Mesa-dev] [PATCH 2/4] anv/pass: Use goto-based error handling in CreateRenderPass

--- src/intel/vulkan/anv_pass.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index 4a1a340..8d1768d 100644 --- a/src/intel/vulkan/anv_pass.c +++ b/src/intel/vulkan/anv_pass.c @@ -59,10 +59,8 @@

[Mesa-dev] [PATCH 1/4] anv: Add helpers for converting access flags to pipe bits

--- src/intel/vulkan/anv_private.h | 59 ++ src/intel/vulkan/genX_cmd_buffer.c | 48 ++- 2 files changed, 62 insertions(+), 45 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index

[Mesa-dev] [PATCH 1/2] anv/image: Move handling of INTEL_VK_HIZ

This makes it so that you don't get an "Implement gen7 HiZ" perf warning when you manually disable HiZ on gen8. --- src/intel/vulkan/anv_image.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index

[Mesa-dev] [PATCH 2/2] intel/debug: Add a common INTEL_DEBUG=nohiz option

The GL driver had a driconf option (which doesn't make much sense) and the Vulkan driver had a hand-rolled environment variable. Instead, let's tie both into the INTEL_DEBUG mechanism and unify things. --- src/intel/common/gen_debug.c | 1 + src/intel/common/gen_debug.h |

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

https://bugs.freedesktop.org/show_bug.cgi?id=99467 --- Comment #22 from Vedran Miletić --- (In reply to Drago from comment #21) > Since workaround is not that big, can't it be committed and activated with > ENV var switch, until Id fixes the game. This will allow stressing

Re: [Mesa-dev] [PATCH] anv/blorp: Only set a clear color for resolves if fast-cleared

On Tue, Mar 14, 2017 at 5:23 AM, Emil Velikov wrote: > On 14 March 2017 at 01:45, Jason Ekstrand wrote: > > On Mon, Mar 13, 2017 at 5:34 PM, Emil Velikov > > wrote: > >> > >> On 13 March 2017 at 19:08, Jason Ekstrand

[Mesa-dev] [PATCH] anv: Properly enumerate physical devices when none are present

--- src/intel/vulkan/anv_device.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index d2d9117..c73b9af 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src/intel/vulkan/anv_device.c @@ -412,8 +412,11 @@

Re: [Mesa-dev] [libdrm PATCH] intel: Make unsynchronized GTT mappings work on systems with snooping.

Hi, On 14.03.2017 12:48, Eero Tamminen wrote: On 11.03.2017 03:14, Kenneth Graunke wrote: On systems without LLC, drm_intel_gem_bo_map_unsynchronized() has had the surprising behavior of doing a synchronized GTT mapping. This is obviously not what the user of the API wanted. Eric left a

Re: [Mesa-dev] [PATCH v2 10/24] anv: handle failures when growing reloc lists

On Tue, Mar 14, 2017 at 04:02:17PM +0200, Pohjolainen, Topi wrote: > On Tue, Mar 14, 2017 at 02:08:10PM +0100, Iago Toral wrote: > > On Tue, 2017-03-14 at 14:04 +0200, Pohjolainen, Topi wrote: > > > On Tue, Mar 14, 2017 at 12:06:16PM +0100, Iago Toral wrote: > > > > > > > > On Tue, 2017-03-14 at

Re: [Mesa-dev] [PATCH kmscube 1/7] kmscube.c: remove uninitialized var returned

> Subject: kmscube.c: remove uninitialized var returned Huh? Not sure what my brain was thinking; changed that locally to "don't return uninitialized variable" :) On Tuesday, 2017-03-14 13:33:51 +, Eric Engestrom wrote: > `ret` isn't used by anything, so remove it as well. > >

Re: [Mesa-dev] [PATCH v2 10/24] anv: handle failures when growing reloc lists

On Tue, Mar 14, 2017 at 02:08:10PM +0100, Iago Toral wrote: > On Tue, 2017-03-14 at 14:04 +0200, Pohjolainen, Topi wrote: > > On Tue, Mar 14, 2017 at 12:06:16PM +0100, Iago Toral wrote: > > > > > > On Tue, 2017-03-14 at 12:01 +0100, Iago Toral wrote: > > > > > > > > On Tue, 2017-03-14 at 11:25

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: set result writemask based on ir type

On 14 March 2017 at 13:16, Ilia Mirkin wrote: > I am waiting to have time to do proper testing on the patch like I promised. > Thus far, the time to do so has failed to materialize. > Right - I seems to have misread your reply s/will do some testing tonight/have done some

[Mesa-dev] [PATCH kmscube 5/7] drm-atomic.c: remove unused variables `gpu_fence_fd`, `kms_fence_fd`

Signed-off-by: Eric Engestrom --- I feel like I might be missing something here; is copying the fields into these vars of any use when debugging? --- drm-atomic.c | 4 1 file changed, 4 deletions(-) diff --git a/drm-atomic.c b/drm-atomic.c index 5d64e50..27c6b1e

[Mesa-dev] [PATCH kmscube 7/7] drm-legacy.c: suppress 'unused parameter warnings

Signed-off-by: Eric Engestrom --- drm-legacy.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drm-legacy.c b/drm-legacy.c index 2392a3d..8e49075 100644 --- a/drm-legacy.c +++ b/drm-legacy.c @@ -33,6 +33,9 @@ static struct drm drm; static void

[Mesa-dev] [PATCH kmscube 3/7] drm-atomic.c: fix signed comparison

Signed-off-by: Eric Engestrom --- drm-atomic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drm-atomic.c b/drm-atomic.c index 3362eac..01fa35a 100644 --- a/drm-atomic.c +++ b/drm-atomic.c @@ -362,7 +362,7 @@ const struct drm *

[Mesa-dev] [PATCH kmscube 4/7] drm-atomic.c: remove unused variables `i`

Signed-off-by: Eric Engestrom --- drm-atomic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drm-atomic.c b/drm-atomic.c index 01fa35a..5d64e50 100644 --- a/drm-atomic.c +++ b/drm-atomic.c @@ -108,7 +108,6 @@ static int

[Mesa-dev] [PATCH kmscube 6/7] drm-common.c: remove unused variable `gbm`

Signed-off-by: Eric Engestrom --- drm-common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drm-common.c b/drm-common.c index 764ffa2..0262816 100644 --- a/drm-common.c +++ b/drm-common.c @@ -35,7 +35,6 @@ drm_fb_destroy_callback(struct gbm_bo *bo, void *data) {

[Mesa-dev] [PATCH kmscube 1/7] kmscube.c: remove uninitialized var returned

`ret` isn't used by anything, so remove it as well. Signed-off-by: Eric Engestrom --- kmscube.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kmscube.c b/kmscube.c index 91e0104..8057e66 100644 --- a/kmscube.c +++ b/kmscube.c @@ -67,7 +67,7

[Mesa-dev] [PATCH kmscube 2/7] cube-tex.c: fix signed comparison

Signed-off-by: Eric Engestrom --- cube-tex.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cube-tex.c b/cube-tex.c index 1e7741d..a543e83 100644 --- a/cube-tex.c +++ b/cube-tex.c @@ -227,7 +227,7 @@ static int get_fd_rgba(uint32_t *pstride)

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: set result writemask based on ir type

I am waiting to have time to do proper testing on the patch like I promised. Thus far, the time to do so has failed to materialize. On Mar 14, 2017 8:27 AM, "Emil Velikov" wrote: > Ilia, are you waiting for another person to review the patch or it's > no longer

Re: [Mesa-dev] [PATCH v2 00/24] anv: Handle out of memory situations better

BTW, in case it is useful, I have the series available here, including fixes to review feedback obtained so far: https://github.com/Igalia/mesa/tree/vk-oom Iago On Fri, 2017-03-10 at 13:38 +0100, Iago Toral Quiroga wrote: > I think this series addresses all the issues raised for v1, except >

Re: [Mesa-dev] [PATCH v2 10/24] anv: handle failures when growing reloc lists

On Tue, 2017-03-14 at 14:04 +0200, Pohjolainen, Topi wrote: > On Tue, Mar 14, 2017 at 12:06:16PM +0100, Iago Toral wrote: > > > > On Tue, 2017-03-14 at 12:01 +0100, Iago Toral wrote: > > > > > > On Tue, 2017-03-14 at 11:25 +0200, Pohjolainen, Topi wrote: > > > > > > > > > > > > On Fri, Mar 10,

Re: [Mesa-dev] [PATCH kmscube 1/5] configure.ac: wire -Wall -Wextra directly into the build

On Tuesday, 2017-03-14 12:10:48 +, Emil Velikov wrote: > Both flags are widely available and the rest of MAYBE_WARN are of little > interest. Since atm no flags were passed, we might as well not bother > with anything but the former two. > > Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH v2 03/24] anv/blorp: return early if we failed to create the shader binary

On Tue, 2017-03-14 at 11:53 +0200, Pohjolainen, Topi wrote: > On Tue, Mar 14, 2017 at 10:35:43AM +0100, Iago Toral wrote: > > > > On Tue, 2017-03-14 at 10:12 +0200, Pohjolainen, Topi wrote: > > > > > > On Fri, Mar 10, 2017 at 01:38:16PM +0100, Iago Toral Quiroga > > > wrote: > > > > > > > > >

Re: [Mesa-dev] [PATCH] anv/blorp: Only set a clear color for resolves if fast-cleared

On 14 March 2017 at 01:45, Jason Ekstrand wrote: > On Mon, Mar 13, 2017 at 5:34 PM, Emil Velikov > wrote: >> >> On 13 March 2017 at 19:08, Jason Ekstrand wrote: >> > On Mon, Mar 13, 2017 at 11:19 AM, Emil Velikov >> >

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: set result writemask based on ir type

Ilia, are you waiting for another person to review the patch or it's no longer applicable ? Thanks Emil On 10 March 2017 at 11:07, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Sat, Mar 4, 2017 at 7:52 PM, Ilia Mirkin

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 99194, which changed state. Bug 99194 Summary: Saints Row IV and Unturned cause GPU resets https://bugs.freedesktop.org/show_bug.cgi?id=99194 What|Removed |Added

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/8] nir/intrinsics: Make load_barycentric_input take a 2-component coor

On 4 March 2017 at 01:12, Jason Ekstrand wrote: > Cc: "17.0 13.0" > --- > src/compiler/nir/nir_intrinsics.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/compiler/nir/nir_intrinsics.h >

[Mesa-dev] [PATCH kmscube 3/5] configure.ac: remove unused AC_PROG_LIBTOOL

We're creating a single binary with no static/shared libraries. We implicitly relied on the macro to pull AC_PROG_CC, so we should add it now, otherwise configure will fail. As a nice bonus, with the last three commits combined the execution time of autogen.sh drops by more than half.

[Mesa-dev] [PATCH kmscube 4/5] configure.ac: remove no-longer applicable m4 folder

With the removal of libtool as of last commit we no longer need the m4 folder or any of the related infra. Signed-off-by: Emil Velikov --- Makefile.am | 2 -- configure.ac | 1 - m4/.gitignore | 5 - 3 files changed, 8 deletions(-) delete mode 100644

[Mesa-dev] [PATCH kmscube 5/5] .gitignore: cleanups no-longer applicable files

Signed-off-by: Emil Velikov --- .gitignore | 17 - 1 file changed, 17 deletions(-) diff --git a/.gitignore b/.gitignore index 3f95cde..1fc8950 100644 --- a/.gitignore +++ b/.gitignore @@ -5,26 +5,9 @@ Makefile .deps .libs *.o -*.lo -*.la -libtool

[Mesa-dev] [PATCH kmscube 1/5] configure.ac: wire -Wall -Wextra directly into the build

Both flags are widely available and the rest of MAYBE_WARN are of little interest. Since atm no flags were passed, we might as well not bother with anything but the former two. Signed-off-by: Emil Velikov --- This will prompt some warnings, but we can sort this at a

[Mesa-dev] [PATCH kmscube 2/5] configure.ac: remove useless AC_CONFIG_* macros

Namely: AC_CONFIG_SRCDIR - it's used to "help" people who deliberatelly override --srcdir. Nobody should be doing this to begin with, so just let them get what they're asking for. AC_CONFIG_HEADERS - we don't have any conditionals, function or macro checks. Hence we don't need the header.

Re: [Mesa-dev] [PATCH kmscube] drm-common.h: forward-declare needed structs

On 13 March 2017 at 19:24, Emil Velikov wrote: > On 13 March 2017 at 17:14, Eric Engestrom wrote: >> drm-common.h:63:49: warning: ‘struct egl’ declared inside parameter list >> will not be >> visible outside of this definition or declaration

Re: [Mesa-dev] [PATCH v2 10/24] anv: handle failures when growing reloc lists

On Tue, Mar 14, 2017 at 12:06:16PM +0100, Iago Toral wrote: > On Tue, 2017-03-14 at 12:01 +0100, Iago Toral wrote: > > On Tue, 2017-03-14 at 11:25 +0200, Pohjolainen, Topi wrote: > > > > > > On Fri, Mar 10, 2017 at 01:38:23PM +0100, Iago Toral Quiroga wrote: > > > > > > > > > > > > Growing the

Re: [Mesa-dev] [PATCH 4/5] util/disk_cache: actually enforce cache size

On Tue, Mar 14, 2017 at 4:08 AM, Timothy Arceri wrote: > From: Alan Swanson > > Currently only a one in one out eviction so if at max_size and > cache files were to constantly increase in size then so would the > cache. Restrict to limit of 8

Re: [Mesa-dev] [PATCH v2 21/24] anv/blorp: make anv_cmd_buffer_alloc_blorp_binding_table() return a VkResult

On Tue, Mar 14, 2017 at 12:18:59PM +0100, Iago Toral wrote: > On Tue, 2017-03-14 at 11:39 +0200, Pohjolainen, Topi wrote: > > On Fri, Mar 10, 2017 at 01:38:34PM +0100, Iago Toral Quiroga wrote: > > > > > > Instead of asserting inside the function, and then use use that > > > information > > > to

Re: [Mesa-dev] [PATCH v2 21/24] anv/blorp: make anv_cmd_buffer_alloc_blorp_binding_table() return a VkResult

On Tue, 2017-03-14 at 11:39 +0200, Pohjolainen, Topi wrote: > On Fri, Mar 10, 2017 at 01:38:34PM +0100, Iago Toral Quiroga wrote: > > > > Instead of asserting inside the function, and then use use that > > information > > to return early from its callers upon failure. > > --- > >  

Re: [Mesa-dev] [PATCH V3] util/disk_cache: use a thread queue to write to shader cache

On 14/03/17 21:27, Grazvydas Ignotas wrote: On Tue, Mar 14, 2017 at 4:06 AM, Timothy Arceri wrote: This should help reduce any overhead added by the shader cache when programs are not found in the cache. To avoid creating any special function just for the sake of the

Re: [Mesa-dev] [PATCH v2 10/24] anv: handle failures when growing reloc lists

On Tue, 2017-03-14 at 12:01 +0100, Iago Toral wrote: > On Tue, 2017-03-14 at 11:25 +0200, Pohjolainen, Topi wrote: > > > > On Fri, Mar 10, 2017 at 01:38:23PM +0100, Iago Toral Quiroga wrote: > > > > > > > > > Growing the reloc list happens through calling > > > anv_reloc_list_add() > > > or > >

[Mesa-dev] [PATCH] vulkan: enums: fix generation with enum aliases

It seems new extensions will start to use aliases in enums, meaning multiple enums with the same value. This forces us to track the values of the enums to generate correct C code. Signed-off-by: Lionel Landwerlin Cc: Dylan Baker ---

Re: [Mesa-dev] [PATCH v2 10/24] anv: handle failures when growing reloc lists

On Tue, 2017-03-14 at 11:25 +0200, Pohjolainen, Topi wrote: > On Fri, Mar 10, 2017 at 01:38:23PM +0100, Iago Toral Quiroga wrote: > > > > Growing the reloc list happens through calling anv_reloc_list_add() > > or > > anv_reloc_list_append(). Make sure that we call these through > > helpers > >

  1   2   >