Re: [Mesa-dev] [PATCH] st/clover: Fix build after shrink of pipe_box

2017-04-04 Thread Vinson Lee
On Tue, Apr 4, 2017 at 6:20 PM, Aaron Watry wrote: > Fixes: 3dfe61e ("gallium: decrease the size of pipe_box - 24 -> 16 bytes") > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100569 > Signed-off-by: Aaron Watry > --- >

Re: [Mesa-dev] [PATCH v4 00/28] i965: Ivybridge ARB_gpu_shader_fp64 / OpenGL 4.0

2017-04-04 Thread Samuel Iglesias Gonsálvez
On Tue, Apr 04, 2017 at 06:04:28PM +0200, Andreas Boll wrote: > Please update the release notes in the last patch. OK, thanks! Sam > > Thanks, > Andreas > > 2017-03-20 10:16 GMT+01:00 Samuel Iglesias Gonsálvez : > > Hi, > > > > This series implements initial support for

Re: [Mesa-dev] [PATCH] travis: remove r600 as it requires llvm 3.8

2017-04-04 Thread Rhys Kidd
On 2 April 2017 at 17:26, Dave Airlie wrote: > On 3 April 2017 at 06:44, Rhys Kidd wrote: > > On 2 April 2017 at 08:42, Christian Gmeiner > > > wrote: > >> > >> At the moment travis ci failes with the following error: > >> >

[Mesa-dev] [PATCH] travis: Add radv vulkan driver to continuous integration

2017-04-04 Thread Rhys Kidd
Signed-off-by: Rhys Kidd --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index aa212b1..0b03ae7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -115,6 +115,7 @@ script: --with-egl-platforms=x11,drm

[Mesa-dev] V2 More shader cache improvements

2017-04-04 Thread Timothy Arceri
This is a resend of version 2. The follow is some load/start-up times gathered by Grazvydas Ignotas. I was seeing similar results as noted in the commit messages. beforeafter cold hot cold hot DeusExMDbench: 285 34 261 27 Talos: 20 20 18 17

[Mesa-dev] [PATCH 3/3] glsl: don't run the GLSL pre-processor when we are skipping compilation

2017-04-04 Thread Timothy Arceri
Improves Deus Ex start-up times with a warm cache from ~30 seconds to ~22 seconds. Also fixes the leaking of state. V2: fix indentation Tested-by: Grazvydas Ignotas --- src/compiler/glsl/glsl_parser_extras.cpp | 19 ++- 1 file changed, 10 insertions(+), 9

[Mesa-dev] [PATCH] travis: Add radeonsi to continuous integration

2017-04-04 Thread Rhys Kidd
Signed-off-by: Rhys Kidd --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index aa212b1..c0b2c1f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -114,7 +114,7 @@ script: ./autogen.sh --enable-debug

[Mesa-dev] [PATCH 2/3] glsl: disable cache if MESA_EXTENSION_OVERRIDE is set

2017-04-04 Thread Timothy Arceri
In the following patch we will stop pre-processing shaders before hashing them, so we just disable the cache if MESA_EXTENSION_OVERRIDE is set. Tested-by: Grazvydas Ignotas --- src/util/disk_cache.c | 9 + 1 file changed, 9 insertions(+) diff --git

[Mesa-dev] [PATCH 1/3] glsl: delay optimisations on individual shaders when cache is available

2017-04-04 Thread Timothy Arceri
Due to a max limit of 65,536 entries on the index table that we use to decide if we can skip compiling individual shaders, it is very likely we will have collisions. To avoid doing too much work when the linked program may be in the cache this patch delays calling the optimisations until link

Re: [Mesa-dev] [PATCH 03/53] i965: Make sure we don't use CPU maps for the scanout buffer.

2017-04-04 Thread Jason Ekstrand
Seems like a good idea. Reviewed-by: Jason Ekstrand On Tue, Apr 4, 2017 at 5:09 PM, Kenneth Graunke wrote: > Using an incoherent CPU map on the active scanout buffer is really > sketchy - we may need extra flushing via GEM_SW_FINISH, or using >

Re: [Mesa-dev] [PATCH 01/53] i965: Fix GLX_MESA_query_renderer video memory on 32-bit.

2017-04-04 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Apr 4, 2017 at 5:09 PM, Kenneth Graunke wrote: > On modern systems with 4GB apertures, the size in bytes is 4294967296, > or (1ull << 32). The kernel gives us the aperture size as a __u64, > which works out

[Mesa-dev] debian wheezy - r300 bug

2017-04-04 Thread Richard Kuenz
Hello , i am affected on Powermac 7,3 by r300 bug as i cannot achieve 3d acceleration and video playback is blue with mpv and gnome-mplayer. is there a way to overcome this whiteout upgrading to newer debian version? thank you very much ___ mesa-dev

[Mesa-dev] [PATCH] anv/query: Busy-wait for available query entries

2017-04-04 Thread Jason Ekstrand
Before, we were just looking at whether or not the user wanted us to wait and waiting on the BO. This instead makes us busy-loop on each query until it's available. This reduces some of the pipeline bubbles we were getting and improves performance of The Talos Principle on medium settings (where

Re: [Mesa-dev] [PATCH 2/3] mesa: rework bind_buffer_object()

2017-04-04 Thread Timothy Arceri
On 05/04/17 11:41, Timothy Arceri wrote: This allows internal users to pass buffer objects directly and alows for KHR_no_error support in the following patch. Sorry this should read: This allows internal users to pass buffer objects directly and allows for KHR_no_error support to be more

[Mesa-dev] [PATCH 2/3] mesa: rework bind_buffer_object()

2017-04-04 Thread Timothy Arceri
This allows internal users to pass buffer objects directly and alows for KHR_no_error support in the following patch. --- src/mesa/main/bufferobj.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/src/mesa/main/bufferobj.c

[Mesa-dev] [PATCH 1/3] mesa: small texstate tidy up

2017-04-04 Thread Timothy Arceri
Possibly more efficient, either way it make the code easier to follow. --- src/mesa/main/texstate.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index ada0dfd..aa99b06 100644 --- a/src/mesa/main/texstate.c +++

[Mesa-dev] [PATCH 3/3] mesa: use internal function when deleting buffers

2017-04-04 Thread Timothy Arceri
This avoids validation and looking up the buffer for a second time. --- src/mesa/main/bufferobj.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 9669f8a..d9aee58 100644 ---

Re: [Mesa-dev] [PATCH] st/clover: Fix build after shrink of pipe_box

2017-04-04 Thread Francisco Jerez
Aaron Watry writes: > Fixes: 3dfe61e ("gallium: decrease the size of pipe_box - 24 -> 16 bytes") > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100569 > Signed-off-by: Aaron Watry Thanks! Reviewed-by: Francisco Jerez > ---

[Mesa-dev] [PATCH] st/clover: Fix build after shrink of pipe_box

2017-04-04 Thread Aaron Watry
Fixes: 3dfe61e ("gallium: decrease the size of pipe_box - 24 -> 16 bytes") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100569 Signed-off-by: Aaron Watry --- src/gallium/state_trackers/clover/core/resource.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3

[Mesa-dev] [Bug 93089] mesa fails to check for gcc atomic primitives before using them

2017-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93089 Matt Turner changed: What|Removed |Added Status|RESOLVED|REOPENED

[Mesa-dev] [Bug 93089] mesa fails to check for gcc atomic primitives before using them

2017-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93089 Jonathan Gray changed: What|Removed |Added Status|REOPENED|RESOLVED

[Mesa-dev] [Bug 93089] mesa fails to check for gcc atomic primitives before using them

2017-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93089 --- Comment #19 from Timothy Arceri --- (In reply to Jonathan Gray from comment #18) > (In reply to Matt Turner from comment #16) > > (In reply to Jonathan Gray from comment #15) > > > Shocking as it may seem Mesa runs on

[Mesa-dev] [Bug 100562] u_debug_stack.c:59: undefined reference to `_Ux86_64_getcontext'

2017-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100562 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH 41/53] i965/drm: Merge bo->handle and bo_gem->gem_handle.

2017-04-04 Thread Kenneth Graunke
These fields are the same value. In the bad old days, bo->handle could have been an identifier from the pre-GEM fake bufmgr, but that's long gone. Keep the "gem_handle" name for clarity. --- src/mesa/drivers/dri/i965/brw_bufmgr.h| 6 +- src/mesa/drivers/dri/i965/intel_batchbuffer.c |

[Mesa-dev] [PATCH 52/53] i965/drm: Reindent intel_bufmgr_gem.c and brw_bufmgr.h.

2017-04-04 Thread Kenneth Graunke
indent -i3 -nut -br -brs -npcs -ce --no-tabs -Tuint32_t -Tuint64_t plus some manual fixes because those aren't quite the right settings. --- src/mesa/drivers/dri/i965/brw_bufmgr.h | 196 +-- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 2152 +- 2 files changed,

[Mesa-dev] [PATCH 53/53] i965/drm: Rename intel_bufmgr_gem.c to brw_bufmgr.c.

2017-04-04 Thread Kenneth Graunke
Matches the class name and the header file name. --- src/mesa/drivers/dri/i965/Makefile.sources | 2 +- src/mesa/drivers/dri/i965/{intel_bufmgr_gem.c => brw_bufmgr.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename src/mesa/drivers/dri/i965/{intel_bufmgr_gem.c =>

[Mesa-dev] [PATCH 49/53] i965/drm: Rename drm_bacon_reg_read() to brw_reg_read().

2017-04-04 Thread Kenneth Graunke
Less bacon. --- src/mesa/drivers/dri/i965/brw_bufmgr.h | 4 +--- src/mesa/drivers/dri/i965/brw_queryobj.c | 6 +++--- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 4 +--- src/mesa/drivers/dri/i965/intel_screen.c | 6 +++--- 4 files changed, 8 insertions(+), 12 deletions(-) diff

[Mesa-dev] [PATCH 44/53] i965/drm: Drop drm_bacon_* from static functions.

2017-04-04 Thread Kenneth Graunke
Mesa style is to not use lengthy prefixes for static functions. --- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 150 --- 1 file changed, 69 insertions(+), 81 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_bufmgr_gem.c

[Mesa-dev] [PATCH 48/53] i965/drm: Rename drm_bacon_bufmgr to struct brw_bufmgr.

2017-04-04 Thread Kenneth Graunke
Also stop using typedefs, per Mesa coding style. --- src/mesa/drivers/dri/i965/brw_bufmgr.h| 29 - src/mesa/drivers/dri/i965/brw_context.c | 2 +- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 6 +-

[Mesa-dev] [PATCH 34/53] i965/drm: Drop GEM_SW_FINISH stuff.

2017-04-04 Thread Kenneth Graunke
This is only useful when doing an incoherent CPU mapping of the current scanout buffer. That's a terrible plan, so we never do it. We always use an uncached GTT map. So, this is useless. Drop the code. --- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 24 1 file

[Mesa-dev] [PATCH 37/53] i965: Make/use a brw_batch_references() wrapper.

2017-04-04 Thread Kenneth Graunke
We'll want to change the implementation of this shortly. --- src/mesa/drivers/dri/i965/brw_performance_query.c | 6 +++--- src/mesa/drivers/dri/i965/brw_queryobj.c | 4 ++-- src/mesa/drivers/dri/i965/gen6_queryobj.c | 2 +- src/mesa/drivers/dri/i965/gen6_sol.c | 2 +-

[Mesa-dev] [PATCH 36/53] i965: Use brw_emit_reloc() instead of drm_bacon_bo_emit_reloc().

2017-04-04 Thread Kenneth Graunke
I'm about to make brw_emit_reloc do actual work, so everybody needs to start using it and not the raw drm_bacon function. --- src/mesa/drivers/dri/i965/brw_cc.c | 10 +++--- src/mesa/drivers/dri/i965/brw_clip_state.c | 11 +++--- src/mesa/drivers/dri/i965/brw_context.h

[Mesa-dev] [PATCH 40/53] i965/drm: Rewrite relocation handling.

2017-04-04 Thread Kenneth Graunke
The execbuf2 kernel API requires us to construct two kinds of lists. First is a "validation list" (struct drm_i915_gem_exec_object2[]) containing each BO referenced by the batch. (The batch buffer itself must be the last entry in this list.) Each validation list entry contains a pointer to the

[Mesa-dev] [PATCH 47/53] i965: Just use a uint32_t context handle rather than a malloc'd wrapper.

2017-04-04 Thread Kenneth Graunke
drm_bacon_context is a malloc'd struct containing a uint32_t context ID and a pointer back to the bufmgr. The bufmgr pointer is pretty useless, as everybody already has brw->bufmgr. At that point...we may as well just use the ctx_id handle directly. A number of places already had to call

[Mesa-dev] [PATCH 50/53] i965: Drop brw_bo_map[_gtt] wrappers which issue perf warnings.

2017-04-04 Thread Kenneth Graunke
The stupid reason for eliminating these functions is that I'm about to rename drm_bacon_bo_map() to brw_bo_map(), which makes the real function have the short name, rather than the wrapper. I'm also planning on reworking our mapping code soon, so we use WC mappings and proper unsynchronized

[Mesa-dev] [PATCH 39/53] i965/drm: Make register write check handle execbuffer directly.

2017-04-04 Thread Kenneth Graunke
I'm about to rewrite how relocation handling works, at which point drm_bacon_bo_emit_reloc() and drm_bacon_bo_mrb_exec() won't exist anymore. This code is already largely not using the batchbuffer infrastructure, so just go all the way and handle relocations, the validation list, and execbuffer

[Mesa-dev] [PATCH 38/53] i965: Make a screen::aperture_threshold field.

2017-04-04 Thread Kenneth Graunke
This is the threshold after which drm_intel_bufmgr_check_aperture_space returns -ENOSPC, signalling that it thinks an execbuf is likely to fail and we need to roll back and flush the batch. We'll need this when we rewrite aperture space checking, shortly. In the meantime, we can also use it in

[Mesa-dev] [PATCH 45/53] i965/drm: Rename drm_bacon_gem_bo_bucket to bo_cache_bucket.

2017-04-04 Thread Kenneth Graunke
No need for a prefix as this struct is local to the .c file. Less bacon. --- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_bufmgr_gem.c

[Mesa-dev] [PATCH 46/53] i965/drm: Fold drm_bacon_gem_reset_stats into the callers.

2017-04-04 Thread Kenneth Graunke
--- src/mesa/drivers/dri/i965/brw_bufmgr.h | 5 src/mesa/drivers/dri/i965/brw_reset.c| 36 +--- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 32 - 3 files changed, 17 insertions(+), 56 deletions(-) diff --git

[Mesa-dev] [PATCH 32/53] i965/drm: Unwrap the unnecessary drm_bacon_reloc_target_info struct.

2017-04-04 Thread Kenneth Graunke
This used to have another field, but now it's just a BO pointer. --- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 45 1 file changed, 19 insertions(+), 26 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_bufmgr_gem.c

[Mesa-dev] [PATCH 43/53] i965/drm: Drop drm_bacon_gem_bo_madvise_internal().

2017-04-04 Thread Kenneth Graunke
The only difference is that it takes an explicit bufmgr rather than using bo->bufmgr, but there is only one bufmgr per screen so they should be identical anyway. --- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff

[Mesa-dev] [PATCH 42/53] i965/drm: Merge drm_bacon_bo_gem into drm_bacon_bo.

2017-04-04 Thread Kenneth Graunke
The separate class gives us a bit of extra encapsulation, but I don't know that it's really worth the boilerplate. I think we can reasonably expect the rest of the driver to be responsible. --- src/mesa/drivers/dri/i965/brw_bufmgr.h | 37 ++ src/mesa/drivers/dri/i965/intel_bufmgr_gem.c |

[Mesa-dev] [PATCH 28/53] i965/drm: Drop softpin support for now.

2017-04-04 Thread Kenneth Graunke
We may want this eventually, but simplify for now. We can add it back later when we actually intend to use it. --- src/mesa/drivers/dri/i965/brw_bufmgr.h | 7 -- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 144 ++- 2 files changed, 8 insertions(+), 143

[Mesa-dev] [PATCH 35/53] i965: Change intel_batchbuffer_reloc() into brw_emit_reloc().

2017-04-04 Thread Kenneth Graunke
This renames intel_batchbuffer_reloc to brw_emit_reloc and changes the parameter naming and ordering to match drm_intel_bo_emit_reloc(). For now, it's a trivial wrapper that accesses batch->bo. When we rework relocations, it will start doing actual work. ---

[Mesa-dev] [PATCH 22/53] i965/drm: Assume aperture size query will work.

2017-04-04 Thread Kenneth Graunke
This query has been available since 2.6.28. We require 3.6. --- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_bufmgr_gem.c b/src/mesa/drivers/dri/i965/intel_bufmgr_gem.c index

[Mesa-dev] [PATCH 30/53] i965/drm: Drop bo_gem::kflags.

2017-04-04 Thread Kenneth Graunke
It's always zero now. --- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_bufmgr_gem.c b/src/mesa/drivers/dri/i965/intel_bufmgr_gem.c index fb02b1258eb..499cd19808f 100644 ---

[Mesa-dev] [PATCH 21/53] i965/drm: Combine drm_bacon_bufmgr_gem and drm_bacon_bufmgr classes.

2017-04-04 Thread Kenneth Graunke
--- src/mesa/drivers/dri/i965/Makefile.sources| 1 - src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 687 -- src/mesa/drivers/dri/i965/intel_bufmgr_priv.h | 45 -- 3 files changed, 328 insertions(+), 405 deletions(-) delete mode 100644

[Mesa-dev] [PATCH 31/53] i965/drm: Switch from uthash to Mesa's hash table.

2017-04-04 Thread Kenneth Graunke
No performance data has been gathered about this choice. I just don't want that many hash tables. --- src/mesa/drivers/dri/i965/Makefile.sources |3 +- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 79 +- src/mesa/drivers/dri/i965/uthash.h | 1074 -- 3

[Mesa-dev] [PATCH 33/53] i965/drm: Drop code to search for an existing bufmgr.

2017-04-04 Thread Kenneth Graunke
This functionality was added by libdrm commit 743af59669386cb6e063fa4bd85f0a0b2da86295 (intel: make bufmgr_gem shareable from different API) in an attempt to solve libva/mesa buffer sharing problems. Specifically, this was working around an issue hit by Chromium, which used the same drm_fd for

[Mesa-dev] [PATCH 23/53] i965/drm: Drop has_wait_timeout.

2017-04-04 Thread Kenneth Graunke
We require Kernel 3.6 and fail screen creation if this doesn't exist. --- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 16 1 file changed, 16 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_bufmgr_gem.c b/src/mesa/drivers/dri/i965/intel_bufmgr_gem.c index

[Mesa-dev] [PATCH 26/53] i965/drm: Delete engine checks.

2017-04-04 Thread Kenneth Graunke
This is basically handholding to prevent a bogus caller from trying to execbuffer on a bogus engine. i965 already does this correctly. --- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 35 1 file changed, 35 deletions(-) diff --git

[Mesa-dev] [PATCH 29/53] i965/drm: Drop has_exec_async related API.

2017-04-04 Thread Kenneth Graunke
Mesa doesn't use this yet. We'll almost certainly want to, but we can add the functionality back after we clean up the messy drm code. --- src/mesa/drivers/dri/i965/brw_bufmgr.h | 5 --- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 61 2 files changed, 66

[Mesa-dev] [PATCH 27/53] i965/drm: Drop userptr support for now.

2017-04-04 Thread Kenneth Graunke
We'll probably want this someday, but let's simplify now and add it back when we actually intend to use it. --- src/mesa/drivers/dri/i965/brw_bufmgr.h | 13 -- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 192 +-- 2 files changed, 1 insertion(+), 204 deletions(-)

[Mesa-dev] [PATCH 25/53] i965/drm: Drop intel_chipset.h in favor of using gen_device_info.

2017-04-04 Thread Kenneth Graunke
This moves the PCI ID detection to intel_screen.c and makes drm_bacon_bufmgr_gem_init() take a devinfo pointer. We also drop the HAS_LLC query stuff - devinfo has that info already, without kernel queries, and it makes no sense to have two has_llc flags set by different mechanisms. ---

[Mesa-dev] [PATCH 24/53] i965/drm: Drop deprecated drm_bacon_bo::offset.

2017-04-04 Thread Kenneth Graunke
This field was the wrong size, so we replaced it with offset64. --- src/mesa/drivers/dri/i965/brw_bufmgr.h | 6 -- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 3 --- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 3 files changed, 1 insertion(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH 19/53] i965/drm: Drop cliprects and dr4 from execbuf variants.

2017-04-04 Thread Kenneth Graunke
Legacy DRI1 leftovers. --- src/mesa/drivers/dri/i965/brw_bufmgr.h| 9 ++--- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 +- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 25 + src/mesa/drivers/dri/i965/intel_screen.c | 1 - 4 files changed, 12

[Mesa-dev] [PATCH 17/53] i965/drm: Check INTEL_DEBUG & DEBUG_BUFMGR directly.

2017-04-04 Thread Kenneth Graunke
Eliminates some API around this, and more importantly, the last field in one bufmgr class. --- src/mesa/drivers/dri/i965/brw_bufmgr.h| 1 - src/mesa/drivers/dri/i965/intel_bufmgr.c | 6 -- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 9 +++--

[Mesa-dev] [PATCH 20/53] i965/drm: Move _drm_bacon_context to intel_bufmgr_gem.c.

2017-04-04 Thread Kenneth Graunke
This moves us one step closer to killing off intel_bufmgr_priv.h. --- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 5 + src/mesa/drivers/dri/i965/intel_bufmgr_priv.h | 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_bufmgr_gem.c

[Mesa-dev] [PATCH 18/53] i965/drm: Devirtualize the bufmgr.

2017-04-04 Thread Kenneth Graunke
libdrm_bacon used to have a GEM-based bufmgr and a legacy fake bufmgr, but that's long since dead (and we never imported it to i965). So, drop the extra layer of function pointers. --- src/mesa/drivers/dri/i965/Makefile.sources| 1 - src/mesa/drivers/dri/i965/brw_bufmgr.h| 155

[Mesa-dev] [PATCH 16/53] i965/drm: Use Mesa's macros.h instead of duplicating them.

2017-04-04 Thread Kenneth Graunke
--- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 5 ++--- src/mesa/drivers/dri/i965/intel_bufmgr_priv.h | 4 src/mesa/drivers/dri/i965/libdrm_macros.h | 10 +- 3 files changed, 3 insertions(+), 16 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_bufmgr_gem.c

[Mesa-dev] [PATCH 13/53] i965/drm: Remove a bunch of gen < 4 stuff

2017-04-04 Thread Kenneth Graunke
Based on a patch by Kristian Høgsberg. --- src/mesa/drivers/dri/i965/brw_bufmgr.h| 5 - src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 237 ++ src/mesa/drivers/dri/i965/intel_bufmgr_priv.h | 5 - 3 files changed, 13 insertions(+), 234 deletions(-) diff --git

[Mesa-dev] [PATCH 15/53] i965/drm: Use ALIGN, not ROUND_UP_TO.

2017-04-04 Thread Kenneth Graunke
ROUND_UP_TO handles a NPOT alignment, but all the alignments we use are power of two anyway, so there's no need. --- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_bufmgr_gem.c

[Mesa-dev] [PATCH 14/53] i965/drm: Delete execbuf1 support.

2017-04-04 Thread Kenneth Graunke
execbuf2 has been around for years. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 183 +-- 1 file changed, 2 insertions(+), 181 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_bufmgr_gem.c

[Mesa-dev] [PATCH 10/53] i965/drm: Port to Mesa's atomic header.

2017-04-04 Thread Kenneth Graunke
Drop xf86atomic.h in favor of Mesa's util/u_atomic.h. We replace the atomic_t wrapper struct with a bare integer, switch to the 'p_atomic' naming conventions, and move over the one extra helper. Signed-off-by: Kenneth Graunke ---

[Mesa-dev] [PATCH 12/53] i965/drm: Remove some unused functions and macros.

2017-04-04 Thread Kenneth Graunke
Based on a patch by Kristian Høgsberg. --- src/mesa/drivers/dri/i965/brw_bufmgr.h| 12 -- src/mesa/drivers/dri/i965/intel_bufmgr.c | 49 src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 170 -- src/mesa/drivers/dri/i965/intel_bufmgr_priv.h | 28

[Mesa-dev] [PATCH 11/53] i965/drm: Switch to util/list.h instead of libdrm_lists.h.

2017-04-04 Thread Kenneth Graunke
Both are kernel style lists, so this is trivial. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/Makefile.sources | 1 - src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 91 ++--- src/mesa/drivers/dri/i965/libdrm_lists.h | 118

[Mesa-dev] [PATCH 01/53] i965: Fix GLX_MESA_query_renderer video memory on 32-bit.

2017-04-04 Thread Kenneth Graunke
On modern systems with 4GB apertures, the size in bytes is 4294967296, or (1ull << 32). The kernel gives us the aperture size as a __u64, which works out great. Unfortunately, libdrm "helpfully" returns the data as a size_t, which on 32-bit systems means it truncates the aperture size to 0

[Mesa-dev] [PATCH 00/53] i965: Eat libdrm_intel for breakfast

2017-04-04 Thread Kenneth Graunke
Hello, This series imports libdrm_intel into the i965 driver, hacks and slashes it down to size, and greatly simplifies our relocation handling. Some of the patches may be held for moderation. You can find the series in git here: https://cgit.freedesktop.org/~kwg/mesa/log/?h=bacondrm A couple

[Mesa-dev] [PATCH 02/53] i965: Stop calling drm_intel_bufmgr_gem_enable_fenced_relocs().

2017-04-04 Thread Kenneth Graunke
This does nothing on Gen4+, which is the only hardware we support. --- src/mesa/drivers/dri/i965/intel_screen.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index f94e8a77c10..fd15c37e943 100644 ---

[Mesa-dev] [PATCH 03/53] i965: Make sure we don't use CPU maps for the scanout buffer.

2017-04-04 Thread Kenneth Graunke
Using an incoherent CPU map on the active scanout buffer is really sketchy - we may need extra flushing via GEM_SW_FINISH, or using drmModeDirtyFB() and kernel commit a6a7cc4b7db6d (4.10+). Chris suggests "never ever do that", which seems like a wise plan! intel_miptree_map_raw() uses CPU maps

[Mesa-dev] [PATCH 05/53] i965/drm: remove legacy defines, aub functions, and decoder prototypes

2017-04-04 Thread Kenneth Graunke
We never imported any of this code, so drop the prototypes, unused enums, and defines. Based on patches by Emil Velikov. --- src/mesa/drivers/dri/i965/brw_bufmgr.h | 110 --- src/mesa/drivers/dri/i965/intel_bufmgr_gem.c | 66 2 files changed, 176

[Mesa-dev] [PATCH 06/53] i965/drm: Use __typeof__ rather than typeof.

2017-04-04 Thread Kenneth Graunke
typeof doesn't seem to exist. This code is going to die soon anyway. --- src/mesa/drivers/dri/i965/libdrm_lists.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/libdrm_lists.h b/src/mesa/drivers/dri/i965/libdrm_lists.h index

[Mesa-dev] [PATCH 07/53] i965/drm: Drop libpciaccess dependencies.

2017-04-04 Thread Kenneth Graunke
i965 doesn't use drm_intel_get_aperture_sizes(), so we can delete support for it. This avoids a build dependency on libpciaccess. --- src/mesa/drivers/dri/i965/brw_bufmgr.h | 1 - src/mesa/drivers/dri/i965/intel_bufmgr.c | 48 2 files changed, 49 deletions(-)

[Mesa-dev] [Bug 100569] core/resource.cpp:36:33: error: non-constant-expression cannot be narrowed from type 'int' to 'int16_t' (aka 'short') in initializer list [-Wc++11-narrowing]

2017-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100569 Vinson Lee changed: What|Removed |Added CC|

[Mesa-dev] [Bug 93089] mesa fails to check for gcc atomic primitives before using them

2017-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93089 --- Comment #18 from Jonathan Gray --- (In reply to Matt Turner from comment #16) > (In reply to Jonathan Gray from comment #15) > > Shocking as it may seem Mesa runs on more than just Linux. > > Don't act like that. Grazvydas

[Mesa-dev] [Bug 93089] mesa fails to check for gcc atomic primitives before using them

2017-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93089 --- Comment #17 from Matt Turner --- (In reply to Grazvydas Ignotas from comment #14) > Yes but any affected platforms we actually care about? > > Newer gcc should cover some of the cases mentioned in this bug. I think >

[Mesa-dev] [Bug 93089] mesa fails to check for gcc atomic primitives before using them

2017-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93089 --- Comment #16 from Matt Turner --- (In reply to Jonathan Gray from comment #15) > Shocking as it may seem Mesa runs on more than just Linux. Don't act like that. Grazvydas wrote code to fix a bug you reported more than two

[Mesa-dev] [Bug 93089] mesa fails to check for gcc atomic primitives before using them

2017-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93089 --- Comment #15 from Jonathan Gray --- Shocking as it may seem Mesa runs on more than just Linux. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 93089] mesa fails to check for gcc atomic primitives before using them

2017-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93089 --- Comment #14 from Grazvydas Ignotas --- Yes but any affected platforms we actually care about? Newer gcc should cover some of the cases mentioned in this bug. I think pre-v6 ARM now has 32bit atomics on Linux thanks to a

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/fs: Always provide a default LOD of 0 for TXS and TXL

2017-04-04 Thread Anuj Phogat
On Tue, Apr 4, 2017 at 3:38 PM, Jason Ekstrand wrote: > We already provide a default LOD for textureQueryLevels and texture() on > non-fragment stages. However, there are more cases where one is needed > such as textureSize(gsampler2DMS*) in SPIR-V. Instead of trying to

Re: [Mesa-dev] [PATCH v2] glsl/blob: handle NULL ptr in blob_write_string/blob_read_string

2017-04-04 Thread Timothy Arceri
On 05/04/17 02:29, Gregory Hainaut wrote: Context: Nouveau uses NULL strings for unnamed parameter of texture gather offsets opcode. Fix piglit crashes of the 'texturegatheroffsets' tests on Nouveau v2: based on Nicolai feedback Hi Gregory, Nicolai suggested you change the caller of create

Re: [Mesa-dev] [PATCH v2] libgl-xlib: Link with libunwind.

2017-04-04 Thread Rob Clark
On Tue, Apr 4, 2017 at 6:04 PM, Vinson Lee wrote: > Fix linking error. > > CXXLDlibGL.la > ../../../../src/gallium/auxiliary/.libs/libgallium.a(u_debug_stack.o): In > function `debug_backtrace_capture': > src/gallium/auxiliary/util/u_debug_stack.c:59: undefined

[Mesa-dev] [PATCH 8/8] intel/blorp: Use ISL for emitting depth/stencil/hiz

2017-04-04 Thread Jason Ekstrand
--- src/intel/blorp/blorp_genX_exec.h | 120 +++--- 1 file changed, 35 insertions(+), 85 deletions(-) diff --git a/src/intel/blorp/blorp_genX_exec.h b/src/intel/blorp/blorp_genX_exec.h index 3791462..e1acb07 100644 --- a/src/intel/blorp/blorp_genX_exec.h +++

[Mesa-dev] [PATCH 6/8] intel/isl: Add support for emitting depth/stencil/hiz

2017-04-04 Thread Jason Ekstrand
--- src/intel/Makefile.sources | 7 ++ src/intel/isl/isl.c| 93 src/intel/isl/isl.h| 82 ++ src/intel/isl/isl_emit_depth_stencil.c | 189 + src/intel/isl/isl_priv.h |

[Mesa-dev] [PATCH 7/8] anv: Use ISL for emitting depth/stencil/hiz

2017-04-04 Thread Jason Ekstrand
--- src/intel/vulkan/genX_cmd_buffer.c | 215 +++-- 1 file changed, 37 insertions(+), 178 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 1ce549a..4e519cd 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++

[Mesa-dev] [PATCH 5/8] intel/isl: Use genx_bits.h instead of a hand-rolled table

2017-04-04 Thread Jason Ekstrand
This gets rid of one piece of ugliness with the way ISL handles surface emitting surface states. I've never liked that hand-rolled table but it was the best we had at the time. --- src/intel/isl/isl.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff

[Mesa-dev] [PATCH 4/8] intel/genxml/bits: Emit per-container _length helpers

2017-04-04 Thread Jason Ekstrand
--- src/intel/genxml/gen_bits_header.py | 34 ++ 1 file changed, 34 insertions(+) diff --git a/src/intel/genxml/gen_bits_header.py b/src/intel/genxml/gen_bits_header.py index fc31baa..ac8ec4c 100644 --- a/src/intel/genxml/gen_bits_header.py +++

[Mesa-dev] [PATCH 3/8] intel/genxml/bits: Emit per-field _start helpers

2017-04-04 Thread Jason Ekstrand
--- src/intel/genxml/gen_bits_header.py | 8 1 file changed, 8 insertions(+) diff --git a/src/intel/genxml/gen_bits_header.py b/src/intel/genxml/gen_bits_header.py index cfe2a89..fc31baa 100644 --- a/src/intel/genxml/gen_bits_header.py +++ b/src/intel/genxml/gen_bits_header.py @@

[Mesa-dev] [PATCH 0/8] intel/isl: Emit depth/stencil/hiz packets

2017-04-04 Thread Jason Ekstrand
This little series adds support to ISL for emitting the packets required for depth and stencil buffers: - 3DSTATE_DEPTH_BUFFER - 3DSTATE_STENCIL_BUFFER - 3DSTATE_HIER_DEPTH_BUFFER - 3DSTATE_CLEAR_PARAMS The approach taken here is to have a single function which emits all four commands in one

[Mesa-dev] [PATCH 2/8] intel/genxml/bits: Pull the function emit code into a helper block

2017-04-04 Thread Jason Ekstrand
The helper block is extremely general. It takes an string property name and an object that supports three methods: has_prop, iter_prop, and get_prop. This way we can easily generalize it to emit more different types of getter functions. --- src/intel/genxml/gen_bits_header.py | 69

[Mesa-dev] [PATCH 1/8] intel/genxml/bits: Refactor to add a container class

2017-04-04 Thread Jason Ekstrand
--- src/intel/genxml/gen_bits_header.py | 56 - 1 file changed, 36 insertions(+), 20 deletions(-) diff --git a/src/intel/genxml/gen_bits_header.py b/src/intel/genxml/gen_bits_header.py index 808e6cf..9a89da4 100644 --- a/src/intel/genxml/gen_bits_header.py

[Mesa-dev] [PATCH] i965/fs: Always provide a default LOD of 0 for TXS and TXL

2017-04-04 Thread Jason Ekstrand
We already provide a default LOD for textureQueryLevels and texture() on non-fragment stages. However, there are more cases where one is needed such as textureSize(gsampler2DMS*) in SPIR-V. Instead of trying to list out all of the cases one at a time, just provide the default for all TXS and TXL

Re: [Mesa-dev] [PATCH] anv/pipeline: Properly handle unset gl_Layer and gl_ViewportIndex

2017-04-04 Thread Kenneth Graunke
On Tuesday, April 4, 2017 11:12:32 AM PDT Jason Ekstrand wrote: > When the shader does not set one of these values, they are supposed to > get a default value of 0. We have hardware bits in 3DSTATE_CLIP for > this but haven't been setting them. This fixes the intermittent failure > of

Re: [Mesa-dev] [PATCH] gallium/hud: set the dump file streams to line buffered

2017-04-04 Thread Julien Isorce
I confirm it works, awesome! Thx! Should you check that fopen succeeded ? because I think setvbuf would crash otherwise. That's said: Tested-by: Julien Isorce On 4 April 2017 at 21:52, Edmondo Tommasina wrote: > Flush the HUD value streams to

Re: [Mesa-dev] [PATCH 1/2] anv: Check for device loss at the end of WaitForFences

2017-04-04 Thread Kenneth Graunke
On Tuesday, March 28, 2017 2:39:53 PM PDT Jason Ekstrand wrote: > It's possible that the device could have been lost while we were > waiting. We should let the user know if this has happened. > --- > src/intel/vulkan/anv_device.c | 19 ++- > 1 file changed, 14 insertions(+), 5

Re: [Mesa-dev] [PATCH v3 2/2] anv: Query the kernel for reset status

2017-04-04 Thread Kenneth Graunke
On Wednesday, March 29, 2017 12:37:50 PM PDT Jason Ekstrand wrote: > When a client causes a GPU hang (or experiences issues due to a hang in > another client) we want to let it know as soon as possible. In > particular, if it submits work with a fence and calls vkWaitForFences or >

[Mesa-dev] [Bug 93089] mesa fails to check for gcc atomic primitives before using them

2017-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93089 Jonathan Gray changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: [Mesa-dev] [PATCH V2] util/disk_cache: compress individual cache entries

2017-04-04 Thread Brian Paul
On 03/04/2017 07:12 AM, Emil Velikov wrote: On 2 March 2017 at 21:52, Timothy Arceri wrote: On 03/03/17 01:49, Emil Velikov wrote: Hi Tim, On 2 March 2017 at 01:36, Timothy Arceri wrote: This reduces the cache size for Deus Ex from ~160M to

[Mesa-dev] [Bug 93089] mesa fails to check for gcc atomic primitives before using them

2017-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93089 Grazvydas Ignotas changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH 1/4] anv/blorp: Align vertex buffers to 64B

2017-04-04 Thread Kenneth Graunke
On Friday, March 31, 2017 4:17:08 PM PDT Jason Ekstrand wrote: > This fixes issues seen when adding support for full 48-bit addresses. > The 48-bit addresses themselves have nothing to do with it other than > that it caused the kernel to place buffers slightly differently so they > interacted

  1   2   3   >