Re: [Mesa-dev] [PATCH 2/2] mesa: add fastpath version of the format conversion loop

On 15/06/17 15:34, Jason Ekstrand wrote: On Wed, Jun 14, 2017 at 10:26 PM, Timothy Arceri > wrote: If all the swizzles are inside the src channels range than we can just grab the srcs we need rather than converting everything.

Re: [Mesa-dev] [PATCH 2/2] mesa: add fastpath version of the format conversion loop

On Wed, Jun 14, 2017 at 10:26 PM, Timothy Arceri wrote: > If all the swizzles are inside the src channels range than we can just > grab the srcs we need rather than converting everything. > > perf report convert_float() going from ~10% -> ~7% for the when > running the

[Mesa-dev] [PATCH 1/2] mesa: make _mesa_swizzle_and_convert() static

--- src/mesa/main/format_utils.c | 91 src/mesa/main/format_utils.h | 9 - 2 files changed, 49 insertions(+), 51 deletions(-) diff --git a/src/mesa/main/format_utils.c b/src/mesa/main/format_utils.c index d16d69c..65e65d4 100644 ---

[Mesa-dev] [PATCH 2/2] mesa: add fastpath version of the format conversion loop

If all the swizzles are inside the src channels range than we can just grab the srcs we need rather than converting everything. perf report convert_float() going from ~10% -> ~7% for the when running the following glean test: glean -o -v -v -v -t +pointAtten Cc: Jason Ekstrand

[Mesa-dev] [PATCH] automake: increase the MESA_GIT_SHA1 hash id length from 7 to 10 digits

The SCons build has been using 10 digits of the git hash id for the MESA_GIT_SHA1 string in git_sha1.h for about a year now. I bumped it up after running into a case where a 7-digit hash ID was ambiguous. This patch makes the same change for the autotools build. The command "git log | grep

[Mesa-dev] [PATCH] r600: remove unnecessary NULL check in r600_shader_select

r600_shader_select is always called through the macro SELECT_SHADER_OR_FAIL, which never passes NULL pointers as parameter 'dirty'. --- src/gallium/drivers/r600/r600_state_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_state_common.c

[Mesa-dev] [PATCH V2] mesa: stop assigning unused storage for non-bindless opaque types

The storage was once used by get_sampler_uniform_value() but that was fixed long ago to use the uniform storage assigned by the linker. By not assigning storage for images/samplers the constant buffer for gallium drivers will be reduced which could result in small perf improvements. V2: rebase

[Mesa-dev] [PATCH 4/5] i965: Only do depth resolves prior to clearing when needed

--- src/mesa/drivers/dri/i965/brw_clear.c | 35 +-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_clear.c b/src/mesa/drivers/dri/i965/brw_clear.c index f5a990d..99ddc4e 100644 ---

[Mesa-dev] [PATCH 2/5] i965: Move surface resolves back to draw/dispatch time

This is effectively a revert of 388f02729bbf88ba104f4f8ee1fdf005a240969c though much code has been added since. Kristian initially moved it to try and avoid locking problems with meta-based resolves. Now that meta is gone from the resolve path (for good this time, we hope), we can move it back.

[Mesa-dev] [PATCH 3/5] i965: Simplify HiZ clears a bit

No need for all that switching when we can just assign a nice little variable with the number of layers. --- src/mesa/drivers/dri/i965/brw_clear.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_clear.c

[Mesa-dev] [PATCH 5/5] i965/clear: Don't perform redundant depth clears

We already have this little optimization for color clears. Now that we're actually tracking whether or not a slice has any fast-clear blocks, It's easy enough to add for depth clears too. --- src/mesa/drivers/dri/i965/brw_clear.c | 34 ---

[Mesa-dev] [PATCH 1/5] i965: Enable non-CCS_E fast-clears on gen9+

Sky Lake and above can fast-clear exactly the same set of formats as older hardware. The only restriction is that you can't *texture* from it unless the format supports CCS_E but you can fast-clear and render to it just fine. All of the code exists and now that we have sane resolves, we can

[Mesa-dev] [Bug 101432] make check DispatchSanity_test.GL31_CORE regression

https://bugs.freedesktop.org/show_bug.cgi?id=101432 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] mesa: fix 'make check' by moving bindless functions at the right place

On 15/06/17 01:08 AM, Samuel Pitoiset wrote: > Fixes: 5f249b9f05e ("mapi: add GL_ARB_bindless_texture entry points") > Reported-by: Mark Janes > Signed-off-by: Samuel Pitoiset Pushed, thanks! -- Earthling Michel Dänzer |

[Mesa-dev] [Bug 101432] make check DispatchSanity_test.GL31_CORE regression

https://bugs.freedesktop.org/show_bug.cgi?id=101432 Bug ID: 101432 Summary: make check DispatchSanity_test.GL31_CORE regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All Status: NEW

Re: [Mesa-dev] [PATCH 2/2] anv/i965: drop libdrm_intel dependency completely

On Wed, Jun 14, 2017 at 5:22 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > With Ken's work to drop the library dependency on libdrm_intel, we now > only depend on libdrm for the kernel uapi headers it provides. It > seems like we're better off just embeddeding those headers

[Mesa-dev] [PATCH 10.5/24] st/mesa: don't set sampler states for TBOs

From: Marek Olšák --- This prevents a crash later in the series, and it's generally a good thing to do. src/mesa/state_tracker/st_atom_sampler.c | 11 +-- src/mesa/state_tracker/st_texture.c | 5 +++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH 06/10] i965: perf: keep on reading reports until delimiting timestamp

Due to an underlying hardware race condition, we have no guarantee that all the reports coming from the OA buffer related to the workload we're trying to measure have landed to memory by the time all the work submitted has completed. That means we need to keep on reading the OA stream until we

[Mesa-dev] [PATCH 07/10] i965: ensure isolated timer reports while idle don't confuse filtering

From: Robert Bragg From experimentation in IGT, we found that the OA unit might label some report as "idle" (using an invalid context ID), right after a report for a given context. Deltas generated by those reports actually belong to the previous context, even though

[Mesa-dev] [PATCH 08/10] i965: use gen_device_info rather then brw_context

Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_performance_query.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_performance_query.c

[Mesa-dev] [PATCH 05/10] i965: Add Gen8+ INTEL_performance_query support

From: Robert Bragg Enables access to OA unit metrics on Gen8+ via INTEL_performance_query. Signed-off-by: Robert Bragg --- src/mesa/drivers/dri/i965/Makefile.am | 8 +- src/mesa/drivers/dri/i965/brw_defines.h | 6 +

[Mesa-dev] [PATCH 03/10] i965: perf: fix codegen with single operand equation

We did support single value operand equations, but not single variable operand ones. In particular we were failing on "$Sampler0Bottleneck". Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_oa.py | 4 +++- 1 file changed, 3 insertions(+), 1

[Mesa-dev] [PATCH 02/10] i965: Add Gen8+ sys_vars for generated OA code

From: Robert Bragg In preparation for adding XML OA metric set descriptions for Gen 8 and 9 which will result in auto generated code that depends on a number of new system variables ($EuSubslicesTotalCount, $EuThreadsCount and $SliceMask) this adds corresponding members to

[Mesa-dev] [PATCH 00/10] i965: Add performance query OA support on Gen 8 & 9

Hi, This series has been used by a few people for some time already. Now that the kernel patches are making their way to upstream, here are the userspace side ones. This series depends on [1] which includes kernel header files to the tree, so we don't have to depend on a specific version of

[Mesa-dev] [PATCH 01/10] intel: common: add flag to identify platforms by name

The perf infrastructure needs to identify specific platforms, not just generations. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_device_info.c | 23 +-- src/intel/common/gen_device_info.h | 3 +++ 2 files changed, 20

[Mesa-dev] [PATCH 1/2] aubinator: import intel_aub.h from libdrm

This enables us to compile aubinator without the libdrm dependency. Signed-off-by: Lionel Landwerlin --- src/intel/tools/intel_aub.h | 153 1 file changed, 153 insertions(+) create mode 100644

[Mesa-dev] [PATCH 0/2] Anv/i965: Drop dependency on libdrm's kernel headers

Hi, While working with changes that span from kernel to user space, I've been wondering whether we need to depend on libdrm's header files at all for the anv & i965 drivers. Indeed with Ken's recent changes, we depend on libdrm for 1 or 2 functions wrapping an ioctl (with drmGetDevices2 being the

Re: [Mesa-dev] [PATCH 7/9] i965: Use snoop bo for accessing query results on !llc

On 06/09/2017 06:01 AM, Chris Wilson wrote: > Ony non-llc architectures where we are primarily reading back the On > results of the GPU queries, then we can improve performance by using a > cacheable mapping of the results. Unfortunately, enabling snooping makes > the writes from the GPU

Re: [Mesa-dev] [PATCH 5/9] i965: Replace open-coded gen6 queryobj offsets with simple helpers

On 06/09/2017 06:01 AM, Chris Wilson wrote: > Lots of places open-coded the assumed layout of the predicate/results > within the query object, replace those with simple helpers. > > Signed-off-by: Chris Wilson > Cc: Kenneth Graunke > Cc: Matt

Re: [Mesa-dev] [PATCH] anv: FORMAT_FEATURE_TRANSFER_SRC/DST_BIT_KHR not used with VkFormatProperties.bufferFeatures

Out of curiosity, does this fix a test (maybe upcoming one)? Otherwise sounds fair : Reviewed-by: Lionel Landwerlin Thanks! On 14/06/17 17:55, Andres Gomez wrote: VK_FORMAT_FEATURE_TRANSFER_[SRC|DST]_BIT_KHR is a flag value of the VkFormatFeatureFlagBits enum

Re: [Mesa-dev] [PATCH 9/9] i965: Pack simple pipelined query objects into the same buffer

On Friday, June 9, 2017 6:01:40 AM PDT Chris Wilson wrote: > Reuse the same query object buffer for multiple queries within the same > batch. > > A task for the future is propagating the GL_NO_MEMORY errors. > > Signed-off-by: Chris Wilson > Cc: Kenneth Graunke

Re: [Mesa-dev] [PATCH 7/9] i965: Use snoop bo for accessing query results on !llc

On Friday, June 9, 2017 6:01:38 AM PDT Chris Wilson wrote: > Ony non-llc architectures where we are primarily reading back the > results of the GPU queries, then we can improve performance by using a > cacheable mapping of the results. Unfortunately, enabling snooping makes > the writes from the

Re: [Mesa-dev] [PATCH 8/9] i965: Use 'available' fence for polling query results

On Friday, June 9, 2017 6:01:39 AM PDT Chris Wilson wrote: > If we always write the 'available' flag after writing the final result > of the query, we can probe that predicate to quickly query whether the > result is ready from userspace. The primary advantage of checking the > predicate is that

Re: [Mesa-dev] [PATCH 04/15] i965: Prepare up/downsampling for isl based miptrees

On Tue, Jun 13, 2017 at 05:50:02PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 46 > ++- > 1 file changed, 38 insertions(+), 8 deletions(-) > Patches 2-4 are

Re: [Mesa-dev] [PATCH 6/9] i965: Map the query results for the life of the bo

On Wednesday, June 14, 2017 3:50:12 PM PDT Kenneth Graunke wrote: > On Friday, June 9, 2017 6:01:37 AM PDT Chris Wilson wrote: > > If we map the bo upon creation, we can avoid the latency of mmapping it > > when querying, and later use the asynchronous, persistent map of the > > predicate to do a

Re: [Mesa-dev] [PATCH 03/11] intel/genxml: Combine DataDWord{0, 1} fields in to ImmediateData field

Reviewed-by: Rafael Antognolli On Tue, Jun 13, 2017 at 11:28:22AM -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/genxml/gen10.xml | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 05/11] intel/genxml: Rename StartInstanceLocation to StartingInstanceLocation

Hi Anuj, On Tue, Jun 13, 2017 at 11:28:24AM -0700, Anuj Phogat wrote: > This is required because we already have a macro defined with > the name StartInstanceLocation. > > Signed-off-by: Anuj Phogat > --- > src/intel/genxml/gen10.xml | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH] mesa: fix 'make check' by moving bindless functions at the right place

On 06/14/2017 09:30 AM, Aaron Watry wrote: > Looks like Mark beat me to reporting this one (was still bisecting > when this patch was sent). > > Tested-by: Aaron Watry If dispatch_sanity breaks, it's almost always the most recent commit in src/mapi/glapi/gen. That may save

Re: [Mesa-dev] [PATCH] mesa: fix 'make check' by moving bindless functions at the right place

Reviewed-by: Ian Romanick On 06/14/2017 09:08 AM, Samuel Pitoiset wrote: > Fixes: 5f249b9f05e ("mapi: add GL_ARB_bindless_texture entry points") > Reported-by: Mark Janes > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH 6/9] i965: Map the query results for the life of the bo

On Friday, June 9, 2017 6:01:37 AM PDT Chris Wilson wrote: > If we map the bo upon creation, we can avoid the latency of mmapping it > when querying, and later use the asynchronous, persistent map of the > predicate to do a quick query. > > Signed-off-by: Chris Wilson >

Re: [Mesa-dev] [PATCH 06/15] i965: Prepare slice validator for isl based miptrees

On Tue, Jun 13, 2017 at 05:50:04PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 01/15] i965/miptree: Refactor mapping table alloc

On Wed, Jun 14, 2017 at 09:45:46PM +0300, Pohjolainen, Topi wrote: > On Tue, Jun 13, 2017 at 04:31:26PM -0700, Nanley Chery wrote: > > On Tue, Jun 13, 2017 at 05:49:59PM +0300, Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen > > > --- > > >

Re: [Mesa-dev] [PATCH] ac: Use mov_dpp for derivatives.

I was looking into WQM stuff today, and I realized that LLVM will no longer mark this instruction as needing WQM, which seems like a problem. Seems like we need a patch to LLVM. Other uses of DPP (e.g. for the subgroup reduction stuff) won't want WQM, so I'm not sure what's the best approach

Re: [Mesa-dev] [PATCH 2/5] st/mesa: remove redundant sample_mask checking

On 06/14/2017 11:41 PM, Marek Olšák wrote: From: Marek Olšák cso does that too --- src/mesa/state_tracker/st_atom_msaa.c | 7 +-- src/mesa/state_tracker/st_context.h | 1 - 2 files changed, 1 insertion(+), 7 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 11/11] i965: Use blorp for depth/stencil clears on gen6+

On Wed, Jun 14, 2017 at 12:00 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Tue, Jun 06, 2017 at 10:00:06PM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/brw_blorp.c | 106 > ++ > > src/mesa/drivers/dri/i965/brw_blorp.h | 4

[Mesa-dev] [PATCH] radeonsi: remove useless check in si_set_min_samples()

CSO already takes care of this. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_state.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index

Re: [Mesa-dev] [PATCH 5/9] i965: Replace open-coded gen6 queryobj offsets with simple helpers

On Friday, June 9, 2017 6:01:36 AM PDT Chris Wilson wrote: > Lots of places open-coded the assumed layout of the predicate/results > within the query object, replace those with simple helpers. > > Signed-off-by: Chris Wilson > Cc: Kenneth Graunke

Re: [Mesa-dev] [PATCH 07/13] anv/blorp: Remove 3D subresource transition workaround

On Wed, Jun 14, 2017 at 09:32:22AM +0200, Iago Toral wrote: > On Tue, 2017-06-13 at 11:41 -0700, Nanley Chery wrote: > > For 3D image subresources undergoing a layout transition via > > PipelineBarrier, we increase the number of fast-cleared layers to > > match > > the intended behaviour of

Re: [Mesa-dev] [PATCH 1/7] gallium: add pipe_blend_state::srgb_enable and the CAP

On 14/06/17 22:16, Brian Paul wrote: On 06/14/2017 02:38 PM, Jose Fonseca wrote: On 14/06/17 21:21, Marek Olšák wrote: On Wed, Jun 14, 2017 at 10:13 PM, Jose Fonseca wrote: On 14/06/17 21:07, Marek Olšák wrote: On Wed, Jun 14, 2017 at 9:45 PM, Jose Fonseca

Re: [Mesa-dev] [PATCH 2/9] i965: Check last known busy status on bo before asking the kernel

On Friday, June 9, 2017 6:01:33 AM PDT Chris Wilson wrote: > If we know the bo is idle (that is we have no submitted a command buffer > referencing this bo since the last query) we can skip asking the kernel. > Note this may report a false negative if the target is being shared > between processes

Re: [Mesa-dev] [PATCH 3/5] st/mesa: simplify st_update_viewport

Also adding this: diff --git a/src/mesa/state_tracker/st_atom_viewport.c b/src/mesa/state_tracker/st_atom_viewport.c index b434f0d..d01836f 100644 --- a/src/mesa/state_tracker/st_atom_viewport.c +++ b/src/mesa/state_tracker/st_atom_viewport.c @@ -54,9 +54,10 @@ st_update_viewport( struct

Re: [Mesa-dev] [PATCH] mesa: don't call _mesa_update_clip_plane in the GL core profile

Reviewed-by: Ilia Mirkin On Wed, Jun 14, 2017 at 5:37 PM, Marek Olšák wrote: > From: Marek Olšák > > It uses the projection matrix to transform the clip plane. > --- > src/mesa/main/enable.c | 3 ++- > 1 file changed, 2

[Mesa-dev] [PATCH 1/5] st/mesa: use precomputed st_fb_orientation

From: Marek Olšák --- src/mesa/state_tracker/st_atom_list.h | 6 +++--- src/mesa/state_tracker/st_atom_rasterizer.c | 6 +++--- src/mesa/state_tracker/st_atom_scissor.c| 2 +- src/mesa/state_tracker/st_atom_viewport.c | 2 +- 4 files changed, 8 insertions(+), 8

[Mesa-dev] [PATCH 2/5] st/mesa: remove redundant sample_mask checking

From: Marek Olšák cso does that too --- src/mesa/state_tracker/st_atom_msaa.c | 7 +-- src/mesa/state_tracker/st_context.h | 1 - 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_msaa.c

[Mesa-dev] [PATCH 4/5] st/mesa: fix pipe_rasterizer_state::scissor with multiple viewports

From: Marek Olšák Cc: 17.1 --- src/mesa/state_tracker/st_atom_rasterizer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_rasterizer.c b/src/mesa/state_tracker/st_atom_rasterizer.c

[Mesa-dev] [PATCH 5/5] st/mesa: don't set 16 scissors and 16 viewports if they're unused

From: Marek Olšák Only do so if there is a shader writing gl_ViewportIndex. This removes a lot of CPU overhead for the most common case. --- src/mesa/state_tracker/st_atom.c | 18 ++ src/mesa/state_tracker/st_atom_scissor.c | 10 +++---

[Mesa-dev] [PATCH 3/5] st/mesa: simplify st_update_viewport

From: Marek Olšák --- src/mesa/state_tracker/st_atom_viewport.c | 34 --- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_viewport.c b/src/mesa/state_tracker/st_atom_viewport.c index 1fc8908..9a9d570

Re: [Mesa-dev] [PATCH 1/9] i965: Mark freshly allocate bo as idle

On Friday, June 9, 2017 6:01:32 AM PDT Chris Wilson wrote: > When created, buffers are idle, so mark them as such to save an early > ioctl or mistaken assuming the fresh buffer is busy. > > Signed-off-by: Chris Wilson > Cc: Kenneth Graunke > Cc:

[Mesa-dev] [PATCH] mesa: don't call _mesa_update_clip_plane in the GL core profile

From: Marek Olšák It uses the projection matrix to transform the clip plane. --- src/mesa/main/enable.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c index 0324170..0f7cdcd 100644 ---

Re: [Mesa-dev] [PATCH 09/24] st/mesa: sink code needed for apply_texture_swizzle_to_border_color

On Wed, Jun 14, 2017 at 11:23 PM, Timothy Arceri wrote: > > > On 15/06/17 04:10, Marek Olšák wrote: >> >> On Wed, Jun 14, 2017 at 7:27 PM, Marek Olšák wrote: >>> >>> On Tue, Jun 13, 2017 at 8:10 AM, Timothy Arceri >>> wrote:

Re: [Mesa-dev] [PATCH 06/24] st/mesa: don't unbind sampler states if none are used

On 15/06/17 03:17, Marek Olšák wrote: On Tue, Jun 13, 2017 at 7:46 AM, Timothy Arceri wrote: On 13/06/17 15:32, Timothy Arceri wrote: On 13/06/17 04:23, Ilia Mirkin wrote: On Mon, Jun 12, 2017 at 2:18 PM, Marek Olšák wrote: From: Marek Olšák

Re: [Mesa-dev] [PATCH 09/24] st/mesa: sink code needed for apply_texture_swizzle_to_border_color

On 15/06/17 04:10, Marek Olšák wrote: On Wed, Jun 14, 2017 at 7:27 PM, Marek Olšák wrote: On Tue, Jun 13, 2017 at 8:10 AM, Timothy Arceri wrote: On 13/06/17 04:18, Marek Olšák wrote: From: Marek Olšák AMD SI-VI use this.

Re: [Mesa-dev] [PATCH 2/3] mesa/main: Missing NULL pointer check.

This and the following patch are in no error paths. The result cannot be NULL unless the function is being used incorrectly. I would rather this be left as to segfault than to fail silently. On 15/06/17 02:33, Plamena Manolova wrote: In prepare_target it's plausible that the parameters of

Re: [Mesa-dev] [PATCH 1/7] gallium: add pipe_blend_state::srgb_enable and the CAP

On 06/14/2017 02:38 PM, Jose Fonseca wrote: On 14/06/17 21:21, Marek Olšák wrote: On Wed, Jun 14, 2017 at 10:13 PM, Jose Fonseca wrote: On 14/06/17 21:07, Marek Olšák wrote: On Wed, Jun 14, 2017 at 9:45 PM, Jose Fonseca wrote: On 14/06/17 17:12,

Re: [Mesa-dev] [PATCH 04/11] intel/genxml: Rename IndirectStatePointer to BorderColorPointer

Reviewed-by: Rafael Antognolli On Tue, Jun 13, 2017 at 11:28:23AM -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/genxml/gen10.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 0/7] i965: Stop hanging on Haswell

On Tuesday, June 13, 2017 2:53:20 PM PDT Jason Ekstrand wrote: > As I've been working on converting more things in the GL driver over to > blorp, I've been highly annoyed by all of the hangs on Haswell. About one > in 3-5 Jenkins runs would hang somewhere. After looking at about a > half-dozen

Re: [Mesa-dev] [PATCH 4/7] i965: Add an end-of-pipe sync helper

On Tuesday, June 13, 2017 2:53:24 PM PDT Jason Ekstrand wrote: > From: Topi Pohjolainen > > v2 (Jason Ekstrand): > - Take a flags parameter to control the flushes > - Refactoring > > Signed-off-by: Topi Pohjolainen > --- >

Re: [Mesa-dev] [PATCH 1/7] gallium: add pipe_blend_state::srgb_enable and the CAP

On 14/06/17 21:21, Marek Olšák wrote: On Wed, Jun 14, 2017 at 10:13 PM, Jose Fonseca wrote: On 14/06/17 21:07, Marek Olšák wrote: On Wed, Jun 14, 2017 at 9:45 PM, Jose Fonseca wrote: On 14/06/17 17:12, Marek Olšák wrote: On Tue, Jun 13, 2017 at

Re: [Mesa-dev] [PATCH 1/7] gallium: add pipe_blend_state::srgb_enable and the CAP

On Wed, Jun 14, 2017 at 10:13 PM, Jose Fonseca wrote: > On 14/06/17 21:07, Marek Olšák wrote: >> >> On Wed, Jun 14, 2017 at 9:45 PM, Jose Fonseca wrote: >>> >>> On 14/06/17 17:12, Marek Olšák wrote: On Tue, Jun 13, 2017 at 3:43 PM, Marek

Re: [Mesa-dev] [PATCH] gallium/radeon: fix initialization of new resource bindless fields

Reviewed-by: Marek Olšák Marek On Wed, Jun 14, 2017 at 9:11 PM, Samuel Pitoiset wrote: > r600_resource objects are not calloc'd. > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH 1/7] gallium: add pipe_blend_state::srgb_enable and the CAP

On 14/06/17 21:07, Marek Olšák wrote: On Wed, Jun 14, 2017 at 9:45 PM, Jose Fonseca wrote: On 14/06/17 17:12, Marek Olšák wrote: On Tue, Jun 13, 2017 at 3:43 PM, Marek Olšák wrote: On Tue, Jun 13, 2017 at 1:40 PM, Jose Fonseca

Re: [Mesa-dev] [PATCH 1/3] i965/bufmgr: Rename bo_alloc_tiled to bo_alloc_tiled_2d

On Tuesday, June 13, 2017 4:19:00 PM PDT Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_bufmgr.c| 6 ++-- > src/mesa/drivers/dri/i965/brw_bufmgr.h| 12 +++ > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 46 > +-- >

Re: [Mesa-dev] [PATCH 1/7] gallium: add pipe_blend_state::srgb_enable and the CAP

On 06/14/2017 10:07 PM, Marek Olšák wrote: On Wed, Jun 14, 2017 at 9:45 PM, Jose Fonseca wrote: On 14/06/17 17:12, Marek Olšák wrote: On Tue, Jun 13, 2017 at 3:43 PM, Marek Olšák wrote: On Tue, Jun 13, 2017 at 1:40 PM, Jose Fonseca

Re: [Mesa-dev] [PATCH 1/7] gallium: add pipe_blend_state::srgb_enable and the CAP

On Wed, Jun 14, 2017 at 9:45 PM, Jose Fonseca wrote: > On 14/06/17 17:12, Marek Olšák wrote: >> >> On Tue, Jun 13, 2017 at 3:43 PM, Marek Olšák wrote: >>> >>> On Tue, Jun 13, 2017 at 1:40 PM, Jose Fonseca >>> wrote: On

Re: [Mesa-dev] [Mesa-stable] [v2 1/7] i965/gen4: Set depth offset when there is stencil attachment only

On Wed, Jun 14, 2017 at 11:18:40AM +0100, Emil Velikov wrote: > Hi Topi, > > On 22 May 2017 at 20:12, Topi Pohjolainen wrote: > > Current version fails to set depthstencil.depth_offset when there > > is only stencil attachment (it does set the intra tile offsets > >

Re: [Mesa-dev] [PATCH 3/3] i965/gen4: Add support for single layer in alignment workaround

On Wed, Jun 14, 2017 at 10:48:09AM -0700, Ian Romanick wrote: > On 06/09/2017 07:04 AM, Topi Pohjolainen wrote: > > On gen < 6 one doesn't have level or layer specifiers available > > for render and depth targets. In order to support rendering to > > specific level/layer, driver needs to manually

Re: [Mesa-dev] [PATCH 1/7] gallium: add pipe_blend_state::srgb_enable and the CAP

On 14/06/17 17:12, Marek Olšák wrote: On Tue, Jun 13, 2017 at 3:43 PM, Marek Olšák wrote: On Tue, Jun 13, 2017 at 1:40 PM, Jose Fonseca wrote: On 12/06/17 22:56, Marek Olšák wrote: On Mon, Jun 12, 2017 at 10:43 PM, Jose Fonseca

Re: [Mesa-dev] [PATCH 4/4] radeonsi: reduce overhead for resident textures which need color decompression

On Wed, Jun 14, 2017 at 1:55 PM, Samuel Pitoiset wrote: > This is done by introducing a separate list. > > si_decompress_textures() is now 5x faster. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeonsi/si_blit.c|

Re: [Mesa-dev] [PATCH 2/8] i965/gen6: Use isl for hiz

On Wed, Jun 14, 2017 at 10:18:18AM +0300, Pohjolainen, Topi wrote: > On Tue, Jun 13, 2017 at 04:20:02PM -0700, Jason Ekstrand wrote: > > On Tue, Jun 13, 2017 at 4:14 PM, Jason Ekstrand > > wrote: > > > > > On Tue, Jun 13, 2017 at 7:53 AM, Topi Pohjolainen < > > >

Re: [Mesa-dev] [Mesa-stable] [PATCH 08/11] i965/blorp: Do a depth flush/stall prior to HiZ operations

On 14 June 2017 at 18:15, Jason Ekstrand wrote: > On Wed, Jun 14, 2017 at 10:12 AM, Jason Ekstrand > wrote >> >> On Wed, Jun 14, 2017 at 3:51 AM, Emil Velikov >> wrote: >>> >>> Hi Jason, >>> >>> On 7 June 2017 at 06:00, Jason

Re: [Mesa-dev] [PATCH] mesa/tests: add GL_ARB_bindless_texture entry points

See https://lists.freedesktop.org/archives/mesa-dev/2017-June/159273.html. Thanks. On 06/14/2017 09:33 PM, Ian Romanick wrote: From: Ian Romanick Should have been part of commit 5f249b9 "mapi: add GL_ARB_bindless_texture entry points" Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH] mesa/tests: add GL_ARB_bindless_texture entry points

From: Ian Romanick Should have been part of commit 5f249b9 "mapi: add GL_ARB_bindless_texture entry points" Signed-off-by: Ian Romanick Cc: Samuel Pitoiset Cc: Nicolai Hähnle Cc: Mark

Re: [Mesa-dev] [PATCH 1/4] mesa/util: add util_dynarray_clear() helper

On Wed, Jun 14, 2017 at 9:08 PM, Samuel Pitoiset wrote: > > > On 06/14/2017 08:24 PM, Marek Olšák wrote: >> >> On Wed, Jun 14, 2017 at 1:55 PM, Samuel Pitoiset >> wrote: >>> >>> Signed-off-by: Samuel Pitoiset >>>

[Mesa-dev] [PATCH] gallium/radeon: fix initialization of new resource bindless fields

r600_resource objects are not calloc'd. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeon/r600_buffer_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c

Re: [Mesa-dev] [PATCH 1/4] mesa/util: add util_dynarray_clear() helper

On 06/14/2017 08:24 PM, Marek Olšák wrote: On Wed, Jun 14, 2017 at 1:55 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/util/u_dynarray.h | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 11/11] i965: Use blorp for depth/stencil clears on gen6+

On Tue, Jun 06, 2017 at 10:00:06PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 106 > ++ > src/mesa/drivers/dri/i965/brw_blorp.h | 4 ++ > src/mesa/drivers/dri/i965/brw_clear.c | 6 ++ > 3 files changed, 116 insertions(+) > >

Re: [Mesa-dev] [PATCH 01/15] i965/miptree: Refactor mapping table alloc

On Tue, Jun 13, 2017 at 04:31:26PM -0700, Nanley Chery wrote: > On Tue, Jun 13, 2017 at 05:49:59PM +0300, Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 29 > > +-- > > 1

Re: [Mesa-dev] [PATCH 1/4] mesa/util: add util_dynarray_clear() helper

2017-06-14 13:55 GMT+02:00 Samuel Pitoiset : > Signed-off-by: Samuel Pitoiset > --- > src/util/u_dynarray.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/util/u_dynarray.h b/src/util/u_dynarray.h > index

Re: [Mesa-dev] [PATCH 06/15] i965: Prepare slice validator for isl based miptrees

On Wed, Jun 14, 2017 at 11:28:39AM -0700, Nanley Chery wrote: > On Wed, Jun 14, 2017 at 10:36:16AM +0300, Pohjolainen, Topi wrote: > > On Tue, Jun 13, 2017 at 05:26:52PM -0700, Nanley Chery wrote: > > > On Tue, Jun 13, 2017 at 05:50:04PM +0300, Topi Pohjolainen wrote: > > > > Signed-off-by: Topi

Re: [Mesa-dev] [PATCH 06/15] i965: Prepare slice validator for isl based miptrees

On Wed, Jun 14, 2017 at 10:36:16AM +0300, Pohjolainen, Topi wrote: > On Tue, Jun 13, 2017 at 05:26:52PM -0700, Nanley Chery wrote: > > On Tue, Jun 13, 2017 at 05:50:04PM +0300, Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen > > > --- > > >

Re: [Mesa-dev] [PATCH 1/4] mesa/util: add util_dynarray_clear() helper

On Wed, Jun 14, 2017 at 1:55 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/util/u_dynarray.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/util/u_dynarray.h b/src/util/u_dynarray.h > index

Re: [Mesa-dev] [PATCH] gallium/radeon: add a new HUD query for the number of resident handles

Reviewed-by: Marek Olšák Marek On Wed, Jun 14, 2017 at 11:40 AM, Samuel Pitoiset wrote: > Useful for debugging performance issues when ARB_bindless_texture > is enabled. This query doesn't make a distinction between texture > and image handles. >

Re: [Mesa-dev] [PATCH 09/24] st/mesa: sink code needed for apply_texture_swizzle_to_border_color

On Wed, Jun 14, 2017 at 7:27 PM, Marek Olšák wrote: > On Tue, Jun 13, 2017 at 8:10 AM, Timothy Arceri wrote: >> >> >> On 13/06/17 04:18, Marek Olšák wrote: >>> >>> From: Marek Olšák >>> >>> AMD SI-VI use this. GFX9 doesn't. We can

Re: [Mesa-dev] [PATCH 12/24] cso: don't track the number of sampler states bound

On Wed, Jun 14, 2017 at 8:03 PM, Marek Olšák wrote: > On Wed, Jun 14, 2017 at 9:23 AM, Nicolai Hähnle wrote: >> On 12.06.2017 20:18, Marek Olšák wrote: >>> >>> From: Marek Olšák >>> >>> This removes 2 loops from hot codepaths and adds 1

Re: [Mesa-dev] [PATCH 12/24] cso: don't track the number of sampler states bound

On Wed, Jun 14, 2017 at 9:23 AM, Nicolai Hähnle wrote: > On 12.06.2017 20:18, Marek Olšák wrote: >> >> From: Marek Olšák >> >> This removes 2 loops from hot codepaths and adds 1 loop to a rare codepath >> (restore_sampler_states), and makes

Re: [Mesa-dev] [PATCH 3/3] i965/gen4: Add support for single layer in alignment workaround

On 06/09/2017 07:04 AM, Topi Pohjolainen wrote: > On gen < 6 one doesn't have level or layer specifiers available > for render and depth targets. In order to support rendering to > specific level/layer, driver needs to manually offset the surface > to the desired slice. > There are, however,

Re: [Mesa-dev] [PATCH 2/6] i965: When gl_PointSize is unwritten, default to 1.0 on Gen4-5.

Reviewed-by: Rafael Antognolli On Wed, May 10, 2017 at 11:47:26AM -0700, Kenneth Graunke wrote: > Modern GL specifications say that the point size should be 1.0 when > gl_PointSize is unwritten and the last enabled stage is a geometry > or tessellation shader. If

Re: [Mesa-dev] [PATCH 10/24] st/mesa: optimize sampler state translation code

On Wed, Jun 14, 2017 at 9:15 AM, Nicolai Hähnle wrote: > On 12.06.2017 20:18, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/mesa/state_tracker/st_atom_sampler.c | 79 >> +--- >> 1 file changed, 31

Re: [Mesa-dev] [PATCH 09/24] st/mesa: sink code needed for apply_texture_swizzle_to_border_color

On Tue, Jun 13, 2017 at 8:10 AM, Timothy Arceri wrote: > > > On 13/06/17 04:18, Marek Olšák wrote: >> >> From: Marek Olšák >> >> AMD SI-VI use this. GFX9 doesn't. We can stop doing this for SI-VI since >> border color swizzling is broken there anyway.

Re: [Mesa-dev] [PATCH] i965: gen4_blorp_exec.h to the sources list

On Wed, 2017-06-14 at 17:02 +0100, Emil Velikov wrote: > From: Emil Velikov > > We tend to use the sources, as opposed to EXTRA_DIST to include the > headers. > Reviewed-by: Juan A. Suarez Romero > Cc: Juan A. Suarez Romero

  1   2   >