[Mesa-dev] [PATCH] radv/meta: don't need vertex info for resolve shader.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_resolve_fs.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/src/amd/vulkan/radv_meta_resolve_fs.c

Re: [Mesa-dev] [PATCH 2/8] mesa: add KHR_no_error support for glClipControl()

On 23/06/17 00:36, Samuel Pitoiset wrote: --- src/mapi/glapi/gen/ARB_clip_control.xml | 2 +- src/mesa/main/viewport.c| 9 + src/mesa/main/viewport.h| 3 +++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] st/dri: Add support for PIPE_FORMAT_RGBX8888_UNORM

Hi All, So it turns out someone else have a much complete fix for this issue and I think I can wait that CL to land in mesa. Feel free to drop this CL. Thanks all for your review. On Tue, Jun 20, 2017 at 2:06 AM, Emil Velikov wrote: > Hi Lepton, > > On 19 June 2017

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] amd/common: fix off-by-one in sid_tables.py

On Mon, 2017-06-19 at 12:36 +0100, Emil Velikov wrote: > Hi Nicolai, > > On 12 June 2017 at 20:33, Nicolai Hähnle wrote: > > From: Nicolai Hähnle > > > > The very last entry in the sid_strings_offsets table ended up missing, > > leading to

Re: [Mesa-dev] [PATCH 1/2] i965/cnl: Don't write to Cache Mode Register 1 on gen10+

On Thursday, June 22, 2017 10:54:43 AM PDT Anuj Phogat wrote: > With below optimizations gone in gen10+ we have nothing left out to > write to CACHE_MODE_1: > Float Blend Optimization Enable: This bit have been removed in gen10+ > Partial Resolve Disable in VC: Recommendation is to always set this

Re: [Mesa-dev] [PATCH] i965: Drop index buffer re-alignment code.

On Thursday, June 22, 2017 4:10:39 PM PDT Ian Romanick wrote: > That's weird... I wonder why this code was ever added. Regardless, > > Reviewed-by: Ian Romanick https://bugs.freedesktop.org/show_bug.cgi?id=11910 signature.asc Description: This is a digitally signed

Re: [Mesa-dev] [PATCH 0/6] i965/vec4: Implement partial DF register spilling

Samuel Iglesias Gonsálvez writes: > Hello, > > As mentioned in the patch series that implemented Ivybridge support > ARB_gpu_shader_fp64 [0], the only missing feature in that series was > register spilling of 64-bit data and, because of that, about ~39 fp64 > piglit tests

Re: [Mesa-dev] [PATCH 2/6] i965/vec4/generator: use 1-Oword Block Read/Write messages for DF scratch writes/reads

Samuel Iglesias Gonsálvez writes: > Signed-off-by: Samuel Iglesias Gonsálvez > --- > src/intel/compiler/brw_eu_defines.h | 2 + > src/intel/compiler/brw_shader.cpp| 5 + > src/intel/compiler/brw_vec4.cpp | 7 ++

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/glsl_to_tgsi: use correct writemask when converting generic intrinsics

Nicolai, this depends on: https://cgit.freedesktop.org/mesa/mesa/commit/src/mesa?id=944455217b67cb524efef9e628baf09416db5524 Which didn't make it for -stable. Should we cherry-pick that too? On Mon, 2017-06-12 at 21:45 +0200, Nicolai Hähnle wrote: > From: Nicolai Hähnle

Re: [Mesa-dev] glmark2 segfault on imx6

Hi Eric, On Thu, Jun 22, 2017 at 8:08 PM, Eric Anholt wrote: > I asked afrantzis today, and hopefully I'll get added as a co-maintainer > so we can get maintenance patches like this in. Also, apparently > something has been broken with his mail filters, so PRs weren't being >

Re: [Mesa-dev] [PATCH] i965: Drop index buffer re-alignment code.

That's weird... I wonder why this code was ever added. Regardless, Reviewed-by: Ian Romanick On 06/22/2017 11:16 AM, Kenneth Graunke wrote: > This shouldn't ever happen - GL requires it to be aligned: > >"Clients must align data elements consistent with the

Re: [Mesa-dev] glmark2 segfault on imx6

Fabio Estevam writes: > Hi Lucas, > > On Tue, Jun 13, 2017 at 7:10 PM, Lucas Stach wrote: >> Hi Fabio, >> >> the attached patch should fix the issue. I should really try to get >> this upstream, as some people complained about this already... > > It seems

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] amd/common: fix off-by-one in sid_tables.py

On Mon, 2017-06-19 at 12:36 +0100, Emil Velikov wrote: > Hi Nicolai, > > On 12 June 2017 at 20:33, Nicolai Hähnle wrote: > > From: Nicolai Hähnle > > > > The very last entry in the sid_strings_offsets table ended up missing, > > leading to

[Mesa-dev] [PATCH] mesa: skip FLUSH_VERTICES() if no samplers were changed

--- src/mesa/main/uniform_query.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 1570770..9683fa8 100644 --- a/src/mesa/main/uniform_query.cpp +++ b/src/mesa/main/uniform_query.cpp @@ -1071,21

Re: [Mesa-dev] [PATCH] wgl: Add wglUseFontOutlines sample.

Reviewed-by: Brian Paul On 06/22/2017 04:35 PM, Jose Fonseca wrote: From: Jose Fonseca --- src/wgl/CMakeLists.txt | 6 +- src/wgl/{wglfont.c => wglfontbitmaps.c} | 0 src/wgl/wglfontoutlines.c | 147

[Mesa-dev] [PATCH] mesa: don't set _NEW_PROGRAM_CONSTANTS for non-bindless opaque uniforms

v2: rebase on new _mesa_flush_vertices_for_uniforms() helper --- src/mesa/main/uniform_query.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 5eb0efc..5fe63e0 100644 --- a/src/mesa/main/uniform_query.cpp +++

[Mesa-dev] [PATCH] wgl: Add wglUseFontOutlines sample.

From: Jose Fonseca --- src/wgl/CMakeLists.txt | 6 +- src/wgl/{wglfont.c => wglfontbitmaps.c} | 0 src/wgl/wglfontoutlines.c | 147 3 files changed, 151 insertions(+), 2 deletions(-) rename

Re: [Mesa-dev] [PATCH] anv: Fix -Wswitch in anv_layout_to_aux_usage()

On Thu 22 Jun 2017, Jason Ekstrand wrote: > ACK Pushed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3] glsl: do not call link_xfb_stride_layout_qualifiers() for fragment shaders

Thanks! Reviewed-by: Timothy Arceri On 23/06/17 01:13, Juan A. Suarez Romero wrote: xfb only applies to the latest stage before the fragment shader, so there is no need to invoke it in the fragment shader. Fixes: KHR-GL45.enhanced_layouts.xfb_stride_of_empty_list

[Mesa-dev] [PATCH] glapi: Fix -Wduplicate-decl-specifier due to double-const

Fix all lines in src/mesa/main/marshal_generated.c that declare double-const variables. Below is all such lines, with duplicates removed: $ grep 'const const' marshal_generated.c | sort -u const const GLboolean * pointer = cmd->pointer; const const GLvoid * indices = cmd->indices;

Re: [Mesa-dev] [PATCH] anv: Fix -Wswitch in anv_layout_to_aux_usage()

ACK On Thu, Jun 22, 2017 at 2:46 PM, Chad Versace wrote: > anv_layout_to_aux_usage() lacked a case for > VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR. Add an unreachable case, because we > don't support the extension. > --- > src/intel/vulkan/anv_image.c | 3 +++ > 1 file

[Mesa-dev] [PATCH] anv: Fix -Wswitch in anv_layout_to_aux_usage()

anv_layout_to_aux_usage() lacked a case for VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR. Add an unreachable case, because we don't support the extension. --- src/intel/vulkan/anv_image.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH 6/8] swr/rast: Fix missing setup of psContext.pColorBuffer

Fixes render target read access from pixel shaders. --- .../drivers/swr/rasterizer/core/backend_sample.cpp| 15 +++ .../drivers/swr/rasterizer/core/backend_singlesample.cpp | 15 +++ 2 files changed, 14 insertions(+), 16 deletions(-) diff --git

[Mesa-dev] [PATCH 8/8] swr/rast: increase number of possible draws in flight

Increases performance of some large workloads on KNL by ~30%. --- src/gallium/drivers/swr/rasterizer/codegen/knob_defs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/knob_defs.py

[Mesa-dev] [PATCH 7/8] swr/rast: move default split size from driver to rasterizer

--- src/gallium/drivers/swr/rasterizer/codegen/knob_defs.py | 2 +- src/gallium/drivers/swr/swr_screen.cpp | 4 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/knob_defs.py

[Mesa-dev] [PATCH 2/8] swr/rast: Support dynamically sized vertex layout

Each shader stage state (VS, TS, GS, SO, BE/CLIP) now has a vertexAttribOffset to specify the offset to the start of the general attribute section of the incoming verts for that stage. It is up to the driver to set this up correctly based on the active stages. All the shader stages use this value

[Mesa-dev] [PATCH 0/8] swr: update rasterizer

Highlights include splitting the heavily templated files into multiple chunks to speed compile (2x for a large machine), and switching the simd intrinsic usage from a macro-based header to a more c++ feeling library. No regressions on piglit or vtk tests, passes "make dist"/compile. Tim Rowley

[Mesa-dev] [PATCH 4/8] swr/rast: Fix unused variable warnings

--- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/binner.cpp b/src/gallium/drivers/swr/rasterizer/core/binner.cpp index 19eef9b..29d2f1c 100644 ---

Re: [Mesa-dev] [PATCH 2/2] nv50/ir: improve POW lowering

On Thu, Jun 22, 2017 at 9:44 PM, Roland Scheidegger wrote: > Am 22.06.2017 um 21:28 schrieb Karol Herbst: >> If the exponent is a small integer immediate value, we can lower POW to >> MULs instead to save a few instructions. Also MUL instructions execute >> faster than what we

Re: [Mesa-dev] [PATCH shader-db] Drop Orbital Explorer shader.

On Thu 22 Jun 2017, Chad Versace wrote: > On Thu 22 Jun 2017, Kenneth Graunke wrote: > > The author eventually emailed me and said that he considers it a > > "finished experiment" and said the rendering method (geometry shader > > based approach) is inefficient, and he intends to fully rewrite it

Re: [Mesa-dev] [PATCH shader-db] Drop Orbital Explorer shader.

On Thu 22 Jun 2017, Kenneth Graunke wrote: > The author eventually emailed me and said that he considers it a > "finished experiment" and said the rendering method (geometry shader > based approach) is inefficient, and he intends to fully rewrite it > someday. A total tangent... The author and I

Re: [Mesa-dev] [PATCH 11/30] i965/miptree: Add a return for updating of winsys

On Wed 21 Jun 2017, Pohjolainen, Topi wrote: > On Fri, Jun 16, 2017 at 03:41:33PM -0700, Jason Ekstrand wrote: > > From: Ben Widawsky > > > > There is nothing particularly useful to do currently if the update > > fails, but there is no point carrying on either. As a result,

Re: [Mesa-dev] [PATCH 2/2] nv50/ir: improve POW lowering

Am 22.06.2017 um 21:28 schrieb Karol Herbst: > If the exponent is a small integer immediate value, we can lower POW to > MULs instead to save a few instructions. Also MUL instructions execute > faster than what we lower POW in the default case to. > > score change for GpuTest /test=pixmark_piano

Re: [Mesa-dev] [PATCH] egl_dri2: swrastGetDrawableInfo: set *x, *y

Hi Emil et al., - Original Message - > From: "Emil Velikov" > To: "Ben Crocker" > Cc: "ML mesa-dev" , "Eric Engestrom" > > Sent: Thursday, June 22, 2017 11:11:32 AM > Subject: Re: [PATCH]

Re: [Mesa-dev] [PATCH 00/10] egl: Little cleanups

On Thu 22 Jun 2017, Eric Engestrom wrote: > On 22 June 2017 19:10:46 BST, Chad Versace wrote: > > No behavioral change. > > > > Chad Versace (10): > > egl/android: Declare loop vars inside their loops (v2) > > egl/drm: Move loop vars inside the loop > > egl/x11:

Re: [Mesa-dev] [PATCH 08/10] egl/drm: Declare EGLConfig attrib array inside loop

On Thu 22 Jun 2017, Eric Engestrom wrote: > On 22 June 2017 19:10:54 BST, Chad Versace wrote: > > No behavioral change. Just a readability cleanup. > > > > Instead of modifying this small array on each loop iteration, we now > > initialize it in-place with the values it

[Mesa-dev] [PATCH shader-db] Drop Orbital Explorer shader.

The upstream version of Orbital Explorer doesn't run on Mesa drivers, as it (unnecessarily) requests a compatibility profile on non-Apple OSes, and suffers from GLEW bugs. I sent a pull request two years ago to port it to libepoxy and get it running on Mesa drivers, but it was never accepted.

Re: [Mesa-dev] [PATCH 09/10] egl/drm: Declare EGLConfig attrib array inside loop

On Thu 22 Jun 2017, Eric Engestrom wrote: > On 22 June 2017 19:10:55 BST, Chad Versace wrote: > > No behavioral change. Just a readability cleanup. > > > > Instead of modifying this small array on each loop iteration, we now > > initialize it in-place with the values it

Re: [Mesa-dev] [PATCH 10/30] i965: Use miptree_create_for_dri_image in image_target_renderbuffer_storage

On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_fbo.c | 23 +-- > 1 file changed, 1 insertion(+), 22 deletions(-) Please note in the commit message that this does introduce a functional change. intel_image_target_renderbuffer_storage() now

[Mesa-dev] [PATCH 2/2] nv50/ir: improve POW lowering

If the exponent is a small integer immediate value, we can lower POW to MULs instead to save a few instructions. Also MUL instructions execute faster than what we lower POW in the default case to. score change for GpuTest /test=pixmark_piano /benchmark /no_scorebox /msaa=0

[Mesa-dev] [PATCH] egl_dri2: swrastGetDrawableInfo: set *x, *y [v2]

In swrastGetDrawableInfo, set *x and *y, not just *w and *h; this fixes a crash later in drisw_update_tex_buffer when the (formerly) uninitialized x and y values are used to construct an address in a call to llvmpipe_transfer_map. Fixes crash in Piglit test "spec@egl 1.4@eglcreatepbuffersurface

[Mesa-dev] [PATCH 1/2] nv50/ir: move POW lowering into BuildUtil

It's the same for all supported chipsets. Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_build_util.cpp| 16 .../drivers/nouveau/codegen/nv50_ir_build_util.h | 2 ++ .../drivers/nouveau/codegen/nv50_ir_lowering_nv50.cpp | 19

Re: [Mesa-dev] [PATCH 09/30] i965/miptree: Set level_x/h in create_for_dri_image

On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

On Thu, Jun 22, 2017 at 2:53 PM, Roland Scheidegger wrote: > Am 22.06.2017 um 19:35 schrieb Ilia Mirkin: >> On Wed, Jun 21, 2017 at 9:58 AM, Ilia Mirkin wrote: >>> On Tue, Jun 20, 2017 at 6:54 PM, Marek Olšák wrote: The first

Re: [Mesa-dev] [PATCH 08/30] i965/miptree: Add tile_x/y to total_width/height

On Fri 16 Jun 2017, Jason Ekstrand wrote: > This is what we do in intel_image_target_renderbuffer_storage and it > makes more sense than stomping them. Because the image gets created as > a 2D image with one miplevel, they should already be equal to the > provided width/height. Adding the tile

[Mesa-dev] [PATCH 2/2] SQUASH: intel/fs/bank_conflicts: Roll back to the nineties.

--- src/intel/compiler/brw_fs_bank_conflicts.cpp | 274 ++- 1 file changed, 188 insertions(+), 86 deletions(-) diff --git a/src/intel/compiler/brw_fs_bank_conflicts.cpp b/src/intel/compiler/brw_fs_bank_conflicts.cpp index 0225c70..dc88cac 100644 ---

[Mesa-dev] [PATCH 1/2] intel/fs: Implement GRF bank conflict mitigation pass.

Unnecessary GRF bank conflicts increase the issue time of ternary instructions (the overwhelmingly most common of which is MAD) by roughly 50%, leading to reduced ALU throughput. This pass attempts to minimize the number of bank conflicts by rearranging the layout of the GRF space post-register

Re: [Mesa-dev] [PATCH 1/6] i965/eu: add support for 1-OWord Block Read/Write messages

Samuel Iglesias Gonsálvez writes: > Signed-off-by: Samuel Iglesias Gonsálvez > --- > src/intel/compiler/brw_eu.h | 18 ++-- > src/intel/compiler/brw_eu_emit.c| 38 > + >

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

Am 22.06.2017 um 19:35 schrieb Ilia Mirkin: > On Wed, Jun 21, 2017 at 9:58 AM, Ilia Mirkin wrote: >> On Tue, Jun 20, 2017 at 6:54 PM, Marek Olšák wrote: >>> The first pipe_screen flag is a drirc option to fix incorrect grass >>> rendering in Rocket League

Re: [Mesa-dev] [PATCH 2/2] mesa: do not trigger _NEW_TEXTURE_STATE in glActiveTexture()

On 06/22/2017 04:57 PM, Samuel Pitoiset wrote: On 06/22/2017 04:48 PM, Brian Paul wrote: On 06/22/2017 06:49 AM, Samuel Pitoiset wrote: This looks like useless because gl_context::Texture::CurrentUnit is not used by _mesa_update_texture_state() and friends. Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH 00/10] egl: Little cleanups

On 22 June 2017 19:10:46 BST, Chad Versace wrote: > No behavioral change. > > Chad Versace (10): > egl/android: Declare loop vars inside their loops (v2) > egl/drm: Move loop vars inside the loop > egl/x11: Declare loop vars inside the loop > egl/surfaceless:

Re: [Mesa-dev] [PATCH] i965/CFL: Add PCI Ids for Coffee Lake.

>-Original Message- >From: Anuj Phogat [mailto:anuj.pho...@gmail.com] >Sent: Thursday, June 22, 2017 10:54 AM >To: Srivatsa, Anusha >Cc: mesa-dev@lists.freedesktop.org; Vivi, Rodrigo ; >Phogat, Anuj ; Widawsky,

Re: [Mesa-dev] [PATCH 09/10] egl/drm: Declare EGLConfig attrib array inside loop

On 22 June 2017 19:10:55 BST, Chad Versace wrote: > No behavioral change. Just a readability cleanup. > > Instead of modifying this small array on each loop iteration, we now > initialize it in-place with the values it needs. > > Cc: Eric Engestrom

Re: [Mesa-dev] [PATCH 07/30] i965/miptree: Pass the offset into create_for_bo in create_for_dri_image

On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Chad Versace ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 06/30] i965: Move the DRIimage -> miptree code to intel_mipmap_tree.c

On Fri 16 Jun 2017, Jason Ekstrand wrote: > This is mostly a direct port. The only bit of refactoring that was done > was to make creating a planar miptree be an early return from the > non-planar case. Alternatively, we could have three functions: two > helpers and a main function to just call

Re: [Mesa-dev] [PATCH 08/10] egl/drm: Declare EGLConfig attrib array inside loop

On 22 June 2017 19:10:54 BST, Chad Versace wrote: > No behavioral change. Just a readability cleanup. > > Instead of modifying this small array on each loop iteration, we now > initialize it in-place with the values it needs. > > Cc: Eric Engestrom

[Mesa-dev] [PATCH] i965: Drop index buffer re-alignment code.

This shouldn't ever happen - GL requires it to be aligned: "Clients must align data elements consistent with the requirements of the client platform, with an additional base-level requirement that an offset within a buffer to a datum comprising N basic machine units be a multiple

Re: [Mesa-dev] [RFC mesa] travis: add couple missing proto+lib

On Thursday, 2017-06-22 16:47:29 +0100, Emil Velikov wrote: > On 22 June 2017 at 00:29, Eric Engestrom wrote: > >> configure: error: Package requirements (x11 xext xdamage >= 1.1 xfixes > >> x11-xcb xcb xcb-glx >= 1.8.1 xcb-dri2 >= 1.8) were not met: > >> No package 'xdamage'

[Mesa-dev] [PATCH 02/10] egl/drm: Move loop vars inside the loop

That is, consistently do this: for (int i = 0; ...) No behavioral change. Cc: Eric Engestrom Cc: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 37 +++-- 1 file changed, 15 insertions(+), 22

[Mesa-dev] [PATCH 08/10] egl/drm: Declare EGLConfig attrib array inside loop

No behavioral change. Just a readability cleanup. Instead of modifying this small array on each loop iteration, we now initialize it in-place with the values it needs. Cc: Eric Engestrom Cc: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c |

[Mesa-dev] [PATCH 07/10] egl/android: Declare EGLConfig attrib array inside loop (v2)

No behavioral change. Just a readability cleanup. Instead of modifying this small array on each loop iteration, we now initialize it in-place with the values it needs. v2: Rebase. Reviewed-by: Eric Engestrom (v1) Cc: Emil Velikov ---

[Mesa-dev] [PATCH 09/10] egl/drm: Declare EGLConfig attrib array inside loop

No behavioral change. Just a readability cleanup. Instead of modifying this small array on each loop iteration, we now initialize it in-place with the values it needs. Cc: Eric Engestrom Cc: Emil Velikov --- src/egl/drivers/dri2/platform_x11.c |

[Mesa-dev] [PATCH 10/10] egl: Rename 'count' in ${platform}_add_configs_for_visuals (v2)

Rename 'count' to 'config_count'. I didn't understand what the variable did until I untangled the for-loops. Now the next person won't have that problem. v2: Rebase. Fix typo. Apply to all platforms (for emil). Reviewed-by: Eric Engestrom (v1) Cc: Emil Velikov

[Mesa-dev] [PATCH 06/10] egl/dri2: Declare loop vars inside the loop

That is, consistently do this: for (int i = 0; ...) No behavioral change. This patch touches only egl_dri2.c. Cc: Eric Engestrom Cc: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 43 ++--- 1 file

[Mesa-dev] [PATCH 05/10] egl/wayland: Declare loop vars inside the loop

That is, consistently do this: for (int i = 0; ...) No behavioral change. Cc: Eric Engestrom Cc: Emil Velikov --- src/egl/drivers/dri2/platform_wayland.c | 44 + 1 file changed, 17 insertions(+), 27

[Mesa-dev] [PATCH 01/10] egl/android: Declare loop vars inside their loops (v2)

That is, consistently do this: for (int i = 0; ...) No behavioral change. v2: Rebase. Reviewed-by: Eric Engestrom (v1) Cc: Emil Velikov --- src/egl/drivers/dri2/platform_android.c | 34 +++-- 1 file changed, 15

[Mesa-dev] [PATCH 03/10] egl/x11: Declare loop vars inside the loop

That is, consistently do this: for (int i = 0; ...) No behavioral change. Cc: Eric Engestrom Cc: Emil Velikov --- src/egl/drivers/dri2/platform_x11.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 04/10] egl/surfaceless: Move loop vars inside the loop

That is, consistently do this: for (int i = 0; ...) No behavioral change. Cc: Eric Engestrom Cc: Emil Velikov --- src/egl/drivers/dri2/platform_surfaceless.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH 00/10] egl: Little cleanups

No behavioral change. Chad Versace (10): egl/android: Declare loop vars inside their loops (v2) egl/drm: Move loop vars inside the loop egl/x11: Declare loop vars inside the loop egl/surfaceless: Move loop vars inside the loop egl/wayland: Declare loop vars inside the loop egl/dri2:

[Mesa-dev] [PATCH 2/2] anv/cnl: Don't write to Cache Mode Register 1 on gen10+

For PartialResolveDisableInVC field recommendation is to always set this to 0 and that's the default value of the bit. So, we have nothing left to write to CACHE_MODE_1. Signed-off-by: Anuj Phogat --- src/intel/vulkan/genX_state.c | 4 +--- 1 file changed, 1 insertion(+),

[Mesa-dev] [PATCH 1/2] i965/cnl: Don't write to Cache Mode Register 1 on gen10+

With below optimizations gone in gen10+ we have nothing left out to write to CACHE_MODE_1: Float Blend Optimization Enable: This bit have been removed in gen10+ Partial Resolve Disable in VC: Recommendation is to always set this field to 0 in gen10+ and that's the default value of the bit.

Re: [Mesa-dev] [PATCH] i965/CFL: Add PCI Ids for Coffee Lake.

On Thu, Jun 22, 2017 at 10:42 AM, Anusha Srivatsa wrote: > Coffee Lake has a gen9 graphics following KBL. > From 3D perspective, CFL is a clone of KBL/SKL features. > > v2: Change commit message, correct alignment > v3: Update IDs. > v4: Initialize l3_banks, correct

[Mesa-dev] [PATCH] i965/CFL: Add PCI Ids for Coffee Lake.

Coffee Lake has a gen9 graphics following KBL. From 3D perspective, CFL is a clone of KBL/SKL features. v2: Change commit message, correct alignment v3: Update IDs. v4: Initialize l3_banks, correct nomenclature Cc: Benjamin Widawsky Cc: Anuj Phogat

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

On Wed, Jun 21, 2017 at 9:58 AM, Ilia Mirkin wrote: > On Tue, Jun 20, 2017 at 6:54 PM, Marek Olšák wrote: >> The first pipe_screen flag is a drirc option to fix incorrect grass >> rendering in Rocket League for radeonsi. Rocket League expects DirectX >>

Re: [Mesa-dev] [PATCH v2 01/13] intel/blorp: Assert levels and layers are in range

On Thu, Jun 22, 2017 at 10:02 AM, Nanley Chery wrote: > On Thu, Jun 22, 2017 at 09:59:44AM -0700, Nanley Chery wrote: > > On Thu, Jun 22, 2017 at 09:55:50AM -0700, Nanley Chery wrote: > > > On Wed, Jun 21, 2017 at 06:07:29PM -0700, Jason Ekstrand wrote: > > > > On Wed, Jun

Re: [Mesa-dev] [PATCH] egl/android: Change order of EGLConfig generation (v2)

On Thu 22 Jun 2017, Rob Herring wrote: > On Tue, Jun 20, 2017 at 5:03 PM, Chad Versace > wrote: > > Many Android apps (such as Google's official NDK GLES2 example app), and > > even portions the core framework code (such as SystemServiceManager in > > Nougat),

Re: [Mesa-dev] [PATCH 06/11] intel/genxml: Add Gen10 CACHE_MODE_1 definitions

On Thu, Jun 22, 2017 at 9:18 AM, Rafael Antognolli wrote: > On Tue, Jun 13, 2017 at 11:28:25AM -0700, Anuj Phogat wrote: >> Few of the fields in this register are changed as compared >> to gen9.xml. >> >> Signed-off-by: Anuj Phogat >> --- >>

Re: [Mesa-dev] [PATCH v2 13/13] anv/gpu_memcpy: Rename the gpu_memcpy function

On Wed, Jun 21, 2017 at 06:21:54PM -0700, Jason Ekstrand wrote: > I never liked the gpu_memcpy name anyway because I knew something like this > would come up. I left you one trivial comment on patch 1. Other than > that, the series is > > Reviewied-by: Jason Ekstrand > >

Re: [Mesa-dev] [PATCH v2 01/13] intel/blorp: Assert levels and layers are in range

On Thu, Jun 22, 2017 at 09:59:44AM -0700, Nanley Chery wrote: > On Thu, Jun 22, 2017 at 09:55:50AM -0700, Nanley Chery wrote: > > On Wed, Jun 21, 2017 at 06:07:29PM -0700, Jason Ekstrand wrote: > > > On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery > > > wrote: > > > > > > >

Re: [Mesa-dev] [PATCH v2 01/13] intel/blorp: Assert levels and layers are in range

On Thu, Jun 22, 2017 at 09:55:50AM -0700, Nanley Chery wrote: > On Wed, Jun 21, 2017 at 06:07:29PM -0700, Jason Ekstrand wrote: > > On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery wrote: > > > > > v2 (Jason Ekstrand): > > > - Update commit title > > > - Check aux level and

Re: [Mesa-dev] [PATCH] egl/android: Change order of EGLConfig generation (v2)

On Tue, Jun 20, 2017 at 5:03 PM, Chad Versace wrote: > Many Android apps (such as Google's official NDK GLES2 example app), and > even portions the core framework code (such as SystemServiceManager in > Nougat), incorrectly choose their EGLConfig. They neglect to match

Re: [Mesa-dev] [PATCH v2 01/13] intel/blorp: Assert levels and layers are in range

On Wed, Jun 21, 2017 at 06:07:29PM -0700, Jason Ekstrand wrote: > On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery wrote: > > > v2 (Jason Ekstrand): > > - Update commit title > > - Check aux level and layer as well > > > > Signed-off-by: Nanley Chery

Re: [Mesa-dev] [PATCH 11/11] egl/wayland: Use linux-dmabuf interface for buffers

Am Freitag, den 16.06.2017, 18:14 +0100 schrieb Daniel Stone: > When available, use the zwp_linux_dambuf_v1 interface to create buffers, > which allows multiple planes and buffer modifiers to be used. > > Signed-off-by: Daniel Stone > --- > configure.ac

Re: [Mesa-dev] [PATCH v2 12/13] anv/blorp: Provide surface states for CCS resolves

On Wed, Jun 21, 2017 at 06:19:57PM -0700, Jason Ekstrand wrote: > On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery wrote: > > > In the future, we plan on using this method to resolve images whose > > surface state fast-clear value is dynamically updated during command > >

Re: [Mesa-dev] glmark2 segfault on imx6

Hi Lucas, On Tue, Jun 13, 2017 at 7:10 PM, Lucas Stach wrote: > Hi Fabio, > > the attached patch should fix the issue. I should really try to get > this upstream, as some people complained about this already... It seems that Eric has already sent a fix for this segfault issue

Re: [Mesa-dev] [PATCH v3] Revert "getteximage: Return correct error value when texure object is not found"

Yeah, looks better. Reviewed-by: Samuel Pitoiset On 06/22/2017 06:19 PM, Juan A. Suarez Romero wrote: From OpenGL 4.5 spec PDF, section '8.11. Texture Queries', page 236: "An INVALID_VALUE error is generated if texture is not the name of an existing texture

Re: [Mesa-dev] [PATCH v4 2/6] mesa/st: glsl_to_tgsi: implement new temporary register lifetime tracker

Thanks for the comments, I've fixed these little issues locally, but I think in order to not to spam the list, I'll send the changes later. I kind of suspect that Nicolai might have one or the other additional comment :) best, Gert ___ mesa-dev

Re: [Mesa-dev] [PATCH 3/5] st/dri: add a drirc workaround for Rocket League

On 22 June 2017 at 16:14, Marek Olšák wrote: > On Thu, Jun 22, 2017 at 3:46 PM, Emil Velikov > wrote: >> Hi Marek, >> >> Adding Timothee Besset, who I believe did the Linux port. >> >> Is this something that can be addressed within the game itself? >>

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

Am 22.06.2017 um 18:22 schrieb Marek Olšák: > On Thu, Jun 22, 2017 at 6:13 PM, Alex Smith > wrote: >> On 22 June 2017 at 15:52, Roland Scheidegger wrote: >>> Am 22.06.2017 um 13:09 schrieb Nicolai Hähnle: On 22.06.2017 10:14, Michel Dänzer

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

On Thu, Jun 22, 2017 at 6:13 PM, Alex Smith wrote: > On 22 June 2017 at 15:52, Roland Scheidegger wrote: >> Am 22.06.2017 um 13:09 schrieb Nicolai Hähnle: >>> On 22.06.2017 10:14, Michel Dänzer wrote: On 22/06/17 04:34 PM, Nicolai Hähnle

[Mesa-dev] [PATCH v3] Revert "getteximage: Return correct error value when texure object is not found"

From OpenGL 4.5 spec PDF, section '8.11. Texture Queries', page 236: "An INVALID_VALUE error is generated if texture is not the name of an existing texture object." Same wording applies to the compressed version. But turns out this is a spec bug, and Khronos is fixing it for the next

Re: [Mesa-dev] [PATCH v2] getteximage: fix returned error value when texture object is not found

On Thu, 2017-06-22 at 18:13 +0200, Juan A. Suarez Romero wrote: > On Thu, 2017-06-22 at 17:48 +0200, Samuel Pitoiset wrote: > > > > On 06/22/2017 05:46 PM, Juan A. Suarez Romero wrote: > > > From OpenGL 4.5 spec PDF, section '8.11. Texture Queries', page 236: > > >"An INVALID_VALUE error is

Re: [Mesa-dev] [PATCH 06/11] intel/genxml: Add Gen10 CACHE_MODE_1 definitions

On Tue, Jun 13, 2017 at 11:28:25AM -0700, Anuj Phogat wrote: > Few of the fields in this register are changed as compared > to gen9.xml. > > Signed-off-by: Anuj Phogat > --- > src/intel/genxml/gen10.xml | 22 ++ > 1 file changed, 22 insertions(+) > >

Re: [Mesa-dev] [st/va] Fix leak in VAAPI subpictures

On 22 June 2017 at 10:25, Namburu, Chandu-babu wrote: > From: Chandu Babu N > Subject: [PATCH] [st/va] Fix leak in VAAPI subpictures > > sampler view allocated in vaAssociateSubpicture is not cleared > in vaiDeassociateSubpicture. > > Reviewed-by: Christian König

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

On 22 June 2017 at 15:52, Roland Scheidegger wrote: > Am 22.06.2017 um 13:09 schrieb Nicolai Hähnle: >> On 22.06.2017 10:14, Michel Dänzer wrote: >>> On 22/06/17 04:34 PM, Nicolai Hähnle wrote: On 22.06.2017 03:38, Rob Clark wrote: > On Wed, Jun 21, 2017 at 8:15 PM,

Re: [Mesa-dev] [PATCH v2] getteximage: fix returned error value when texture object is not found

On Thu, 2017-06-22 at 17:48 +0200, Samuel Pitoiset wrote: > > On 06/22/2017 05:46 PM, Juan A. Suarez Romero wrote: > > From OpenGL 4.5 spec PDF, section '8.11. Texture Queries', page 236: > >"An INVALID_VALUE error is generated if texture is not the name of > > an existing texture

[Mesa-dev] [Bug 100259] [EGL] [GBM] undefined reference to `gbm_bo_create_with_modifiers'

https://bugs.freedesktop.org/show_bug.cgi?id=100259 --- Comment #20 from Eric Engestrom --- kusayu: You're having a different issue, with different symptoms. Can you please open a new ticket? When doing so, please indicate the libdrm version used. Your error is weird

Re: [Mesa-dev] [PATCH 02/11] intel/genxml: Add INSTDONE registers in gen10

There are a few fields missing but they don't seem to be used anyway, so: Reviewed-by: Rafael Antognolli On Tue, Jun 13, 2017 at 11:28:21AM -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/genxml/gen10.xml | 115 >

Re: [Mesa-dev] [PATCH 3/3] radeonsi: use #pragma pack to pack si_shader_key

Hi Marek, On 20 June 2017 at 19:00, Marek Olšák wrote: > From: Marek Olšák > > sizeof(struct si_shader_key): > Before reverting the 2 commits: 120 bytes > After reverting the 2 commits: 128 bytes > With #pragma pack: 107 bytes > > I'm not sure if

Re: [Mesa-dev] [PATCH v2] getteximage: fix returned error value when texture object is not found

On 06/22/2017 05:46 PM, Juan A. Suarez Romero wrote: From OpenGL 4.5 spec PDF, section '8.11. Texture Queries', page 236: "An INVALID_VALUE error is generated if texture is not the name of an existing texture object." Same wording applies to the compressed version. But turns out this

  1   2   >