Re: [Mesa-dev] [PATCH 02/12] i965/urb: Trigger upload_urb on NEW_BLORP

On Sat, Jul 1, 2017 at 8:13 PM, Kenneth Graunke wrote: > On Monday, June 26, 2017 4:22:35 PM PDT Ian Romanick wrote: > > From: Jason Ekstrand > > > > It's a bit rare, but blorp can trigger a urb reconfiguration. When that > > happens, we need to re-upload the URB config. Fortunately, this isn'

Re: [Mesa-dev] [PATCH v3 1/3] util: Add util_strncpy

On Sun, 2017-07-02 at 21:06 -0700, Matt Turner wrote: > Otherwise known as strlcpy()? I didn't realize this, a wrapper would be needed for all platformsou that don't support it natively. Do you know which platforms support strlcpy? Rob. ___ mesa-dev

Re: [Mesa-dev] [PATCH v3 1/3] util: Add util_strncpy

On Sun, Jul 2, 2017 at 8:49 PM, Robert Foss wrote: > Add strncpy wrapper that makes sure that the string is always ends > with a null byte. Otherwise known as strlcpy()? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.

Re: [Mesa-dev] Why are we using server-side GLX fbconfigs?

On 01/07/17 02:16 AM, Kristian Høgsberg wrote: > On Fri, Jun 30, 2017 at 2:49 AM, Thomas Hellstrom > wrote: >> On 06/29/2017 07:30 PM, Kristian Høgsberg wrote: >>> On Thu, Jun 29, 2017 at 7:36 AM, Thomas Hellstrom >>> wrote: Hi! I was spending some time going through the GLX

[Mesa-dev] [PATCH v3 2/3] gallium/hud: Prevent buffer overflow in hud_thread_counter_install

Switch to using util_strncpy to avoid potential overflow of name array in struct hud_graph. Also extract the name element length into a define so that it can be used for strncpy et al. Coverity-id: 1413761 Signed-off-by: Robert Foss --- Changes since v2: Brian Paul - Combined patch with

[Mesa-dev] [PATCH v3 3/3] gallium/hud: Prevent buffer overflow in hud_thread_busy_install

Switch to using util_strncat to avoid potential overflow of name array in struct hud_graph. Coverity-id: 1413760 Signed-off-by: Robert Foss --- Changes since v2: Brian Paul - Switch to using new util_strncpy function Changes since v1: Gustaw Smolarczyk - Fix strcpy -> strncpy typo

[Mesa-dev] [PATCH v3 1/3] util: Add util_strncpy

Add strncpy wrapper that makes sure that the string is always ends with a null byte. Signed-off-by: Robert Foss --- Changes since v2: Brian Paul - Patch added src/util/u_string.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/util/u_string.h b/src/util/u_string.h index

Re: [Mesa-dev] [PATCH 06/92] nir/lower_system_values: add support for the FRAG_COORD system value

On 03/07/17 10:46, Timothy Arceri wrote: This and the previous patch seem a bit hacky to me. It seems it would be better to either plum the system value all the way through NIR for all drivers or simply disable GLSLFragCoordIsSysVal when radeonsi is going to be using the NIR path. Well maybe

Re: [Mesa-dev] [PATCH 06/92] nir/lower_system_values: add support for the FRAG_COORD system value

This and the previous patch seem a bit hacky to me. It seems it would be better to either plum the system value all the way through NIR for all drivers or simply disable GLSLFragCoordIsSysVal when radeonsi is going to be using the NIR path. On 27/06/17 00:09, Nicolai Hähnle wrote: From: Nicol

Re: [Mesa-dev] [PATCH 02/92] glsl_to_nir: zero-initialize var->data.descriptor_set

I wonder if we should just change to using: nir_variable *var = rzalloc(shader, nir_variable) Either way: Reviewed-by: Timothy Arceri On 27/06/17 00:09, Nicolai Hähnle wrote: From: Nicolai Hähnle This is convenient for backends that support both Vulkan and OpenGL while lowering samplers

[Mesa-dev] [PATCH v2 3/3] glsl: disable array splitting for AoA

While it produces functioning code the pass creates worse code for arrays of arrays. See the comment added in this patch for more detail. V2: skip splitting of AoA of matrices too. --- src/compiler/glsl/opt_array_splitting.cpp | 23 +++ 1 file changed, 23 insertions(+) diff -

[Mesa-dev] [PATCH v2 2/3] nir: fix nir_opt_copy_prop_vars() for arrays of arrays

Previous we only incremented the guide for a single dimension/wildcard. V2: rework logic to avoid code duplication --- src/compiler/nir/nir_opt_copy_prop_vars.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/compiler/nir/nir_opt_copy_prop_vars.c b/src/compil

[Mesa-dev] [PATCH v2 1/3] nir: NULL check lower_copies_to_load_store()

Allows us to disable array spliting for arrays of arrays without regressing tests such as: ES31-CTS.functional.shaders.arrays_of_arrays.return.explicit.struct_3x1x3_fragment --- src/compiler/nir/nir_lower_vars_to_ssa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compil

Re: [Mesa-dev] [Bug 101666] bitfieldExtract is marked as a built-in function on OpenGL ES 3.0, but was added in OpenGL ES 3.1

To be clear, I'm saying this is broken in Mesa for *any* situation that involves redefining a function that appears in a future GL version or ext. There are some limitations to this, based on when the error is triggered, I don't have the code in front of me. At least it happens for es 3.0. On Jul

[Mesa-dev] [Bug 101666] bitfieldExtract is marked as a built-in function on OpenGL ES 3.0, but was added in OpenGL ES 3.1

https://bugs.freedesktop.org/show_bug.cgi?id=101666 --- Comment #5 from Ilia Mirkin --- To be clear, I'm saying this is broken in Mesa for *any* situation that involves redefining a function that appears in a future GL version or ext. There are some limitations to this, based on when the error is

[Mesa-dev] [Bug 101666] bitfieldExtract is marked as a built-in function on OpenGL ES 3.0, but was added in OpenGL ES 3.1

https://bugs.freedesktop.org/show_bug.cgi?id=101666 --- Comment #4 from Ilia Mirkin --- The predicate is correct, just never checked. On Jul 2, 2017 15:08, wrote: > *Comment # 3 on > bug 101666

Re: [Mesa-dev] [Bug 101666] bitfieldExtract is marked as a built-in function on OpenGL ES 3.0, but was added in OpenGL ES 3.1

The predicate is correct, just never checked. On Jul 2, 2017 15:08, wrote: > *Comment # 3 on > bug 101666 from > Kenneth Graunke * > > I don't think you need to change any infrastructu

[Mesa-dev] [Bug 101666] bitfieldExtract is marked as a built-in function on OpenGL ES 3.0, but was added in OpenGL ES 3.1

https://bugs.freedesktop.org/show_bug.cgi?id=101666 --- Comment #3 from Kenneth Graunke --- I don't think you need to change any infrastructure, we just didn't add the proper built-in availability predicate to the bitfieldExtract functions in builtin_functions.cpp. it should be trivial to fix -

[Mesa-dev] [PATCH 2/4] svga: move assertion in draw_vgpu10()

The buffer binding flags aren't ensured until after the svga_buffer_handle() call, so move the assertion after it. --- src/gallium/drivers/svga/svga_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_draw.c b/src/gallium/drivers/svga/svga_draw

[Mesa-dev] [PATCH 3/4] svga: fix texture buffer object regression

With change 8aba778fa2cd98a0b5a7429d3c5057778a0c808c we stopped binding sampler objects for texture buffers. That broke our texture sample / sampler view setup code. Now, we loop over the max(num samplers, num sampler views) and handle the sampler and view information separately. For texture buf

[Mesa-dev] [PATCH 1/4] svga: fix buffer binding flags initialization

If a buffer is created/initialized with glNamedBufferData we will have no target (GL_ARRAY_BUFFER, GL_UNIFORM_BUFFER, etc) so the svga_buffer::bind_flags will be zero until we try to get the buffer handle. This patch initializes the svga_buffer::bind_flags field when it's zero. This fixes the Pig

[Mesa-dev] [PATCH 4/4] svga: don't call svga_texture_device_format_has_alpha() for PIPE_BUFFER

svga_texture_device_format_has_alpha() is only intended to work for texture resources, not buffer resources. This fixes a failed assertion in the svga_texture() cast function when running texture buffer tests. Also, add an assertion in svga_texture_device_format_has_alpha() to catch the issue soo

[Mesa-dev] [PATCH] wglcontext: assorted updates

Print context flags, vendor, renderer strings. Default to not setting the WGL_CONTEXT_PROFILE_MASK_ARB attribute so we can test that scenario. Fix profile_mask_to_string() to use GL_*_BIT instead of WGL_*_BIT flags. Try calling glGenLists() to see if it generates an error. This helps to check if c

Re: [Mesa-dev] [PATCH v2 2/3] gallium/hud: Prevent buffer overflow in hud_thread_counter_install

On 06/30/2017 05:59 PM, Robert Foss wrote: On Thu, 2017-06-29 at 07:28 -0600, Brian Paul wrote: On 06/29/2017 07:21 AM, Robert Foss wrote: Switch to using strncopy to avoid potential overflow of name array in struct hud_graph. Coverity-id: 1413761 Signed-off-by: Robert Foss --- src/galliu

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix texture image resource selection in st_render_texture()

On 07/01/2017 04:56 AM, Nicolai Hähnle wrote: On 29.06.2017 00:12, Brian Paul wrote: If we're rendering to an incomplete/inconsistent (cube) texture, the different faces/levels of the texture may be stored in different resources. Before, we always used the texture object resource. Now, we use

[Mesa-dev] [PATCH] docs: update bug reporting guidelines

Suggest attaching output of glxinfo/wglinfo. Suggest providing an apitrace. --- docs/bugs.html | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/bugs.html b/docs/bugs.html index 445d9ca..44955d3 100644 --- a/docs/bugs.html +++ b/docs/bugs.html @@ -37,11 +37,14 @@ Please

Re: [Mesa-dev] Mesa (master): build systems: uniformize git_sha1.h generation

On 07/01/2017 03:44 AM, Eric Engestrom wrote: On 1 July 2017 00:18:31 BST, Brian Paul wrote: Hi Eric, Shouldn't the new script file be put in the bin/ directory with the other helper scripts? I guess you're right, not sure why I didn't do that. Feel free to move it (just make sure to ../ the

[Mesa-dev] [Bug 101666] bitfieldExtract is marked as a built-in function on OpenGL ES 3.0, but was added in OpenGL ES 3.1

https://bugs.freedesktop.org/show_bug.cgi?id=101666 --- Comment #2 from Ilia Mirkin --- Aha. I see. _mesa_glsl_has_builtin_function() needs to take a state, and only return true if sig->is_builtin_available(state). Unclear if _mesa_glsl_find_builtin_function needs to do the same. Should be easy

[Mesa-dev] [Bug 101666] bitfieldExtract is marked as a built-in function on OpenGL ES 3.0, but was added in OpenGL ES 3.1

https://bugs.freedesktop.org/show_bug.cgi?id=101666 --- Comment #1 from Ilia Mirkin --- Despite the code looking just fine, I can repro this with a shader_test: [require] GL ES >= 3.0 GLSL ES >= 3.00 [vertex shader] #version 300 es uint bitfieldExtract(uint val, int off, int size) { uint m

Re: [Mesa-dev] [PATCH 30/92] ac/nir: start using ac_shader_abi

Hi Nicolai, Can we use LLVMValueRef instead of int for the shader_abi? That way we don't force the values to be function parameters. I don't think the shared code should have to know about that, and it is more flexible when we want to pass those slightly differently between the two drivers, as we

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 99762, which changed state. Bug 99762 Summary: "Black Mesa" not launching https://bugs.freedesktop.org/show_bug.cgi?id=99762 What|Removed |Added -

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #78 from Robert Orzanna --- Sorry, I shared the wrong link to the video in my previous comment: https://youtu.be/3mXXnlwrXm0 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the b

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #77 from Robert Orzanna --- Thank you, omerfarukdoga...@hotmail.com. I could reproduce this problem in Chrome and tried to capture it in this video: https://www.useloom.com/share/14090a28f6d64fb6a4ba74056aac14f5 Does the problem ha