Re: [Mesa-dev] [PATCH] egl/dri: link directly to libglapi.so

On Wed, Sep 20, 2017 at 2:19 AM, Emil Velikov wrote: > From: Emil Velikov > > In order to build EGL, one has to use shared glapi - libglapi.so. > > Thus the dlopen/dlsym dance is no longer needed and we can link to the > library directly. > >

Re: [Mesa-dev] [PATCH] egl/dri: link directly to libglapi.so

On Wed, Sep 20, 2017 at 7:47 PM, Eric Engestrom wrote: > On Tuesday, 2017-09-19 17:19:59 +, Emil Velikov wrote: >> From: Emil Velikov >> >> In order to build EGL, one has to use shared glapi - libglapi.so. >> >> Thus the dlopen/dlsym

Re: [Mesa-dev] [PATCH 2/8] glsl: mark xfb varyings as always active

On 23/09/17 02:59, Kenneth Graunke wrote: On Tuesday, September 12, 2017 4:37:29 PM PDT Timothy Arceri wrote: This will be used by the nir linking pass so that we don't remove otherwise unused varyings. --- src/compiler/glsl/link_varyings.cpp | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [Mesa-dev] [PATCH 2/2] glx: Implement GLX_EXT_no_config_context

On Thursday, September 21, 2017 12:59:55 PM PDT Adam Jackson wrote: > This more or less ports EGL_KHR_no_config_context to GLX. > > This is currently a draft extension, under review at: > > https://github.com/KhronosGroup/OpenGL-Registry/pull/102 > > Signed-off-by: Adam Jackson

Re: [Mesa-dev] [PATCH 1/2] glx: Sort the GLX extension bit enum and table

On Thursday, September 21, 2017 12:59:54 PM PDT Adam Jackson wrote: > Not quite asciibetical: ARB, then EXT, then vendor, just like the GL > extension enum just below. No functional change, but it bothered me. > > Signed-off-by: Adam Jackson > --- > src/glx/glxextensions.c | 22

Re: [Mesa-dev] [PATCH] vulkan/wsi/wayland: Stop printing out the DRM device

On 22 September 2017 at 12:45, Jason Ekstrand wrote: > Cc: mesa-sta...@lists.freedesktop.org Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH] vulkan/wsi/wayland: Stop printing out the DRM device

Cc: mesa-sta...@lists.freedesktop.org --- src/vulkan/wsi/wsi_common_wayland.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/vulkan/wsi/wsi_common_wayland.c b/src/vulkan/wsi/wsi_common_wayland.c index dd283a1..b726d98 100644 --- a/src/vulkan/wsi/wsi_common_wayland.c +++

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

Quoting Jose Fonseca (2017-09-22 11:58:17) > On 22/09/17 19:38, Dylan Baker wrote: > > Quoting Jose Fonseca (2017-09-22 11:10:34) > >> On 22/09/17 18:47, Nirbheek Chauhan wrote: > >>> On Fri, Sep 22, 2017 at 10:19 PM, Jose Fonseca > >>> wrote: > cmake provides a generic

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

On 22/09/17 19:38, Dylan Baker wrote: Quoting Jose Fonseca (2017-09-22 11:10:34) On 22/09/17 18:47, Nirbheek Chauhan wrote: On Fri, Sep 22, 2017 at 10:19 PM, Jose Fonseca wrote: cmake provides a generic mechanism to set any variable, either from a command line -DFOO=boo,

Re: [Mesa-dev] [PATCH] etnaviv: Add missing includes after 6ace0b8

The build is successful again after this patch. This is: Tested-by: Andres Gomez On Fri, 2017-09-22 at 15:52 +0200, Wladimir J. van der Laan wrote: > Add missing includes after 6ace0b8 (etnaviv: don't enable RT > full-overwrite when logicop is enabled), otherwise the etnaviv

Re: [Mesa-dev] [PATCH] etnaviv: Add missing includes after 6ace0b8

2017-09-22 15:52 GMT+02:00 Wladimir J. van der Laan : > Add missing includes after 6ace0b8 (etnaviv: don't enable RT > full-overwrite when logicop is enabled), otherwise the etnaviv driver > won't build because of missing macros. > > Signed-off-by: Wladimir J. van der Laan

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

Quoting Jose Fonseca (2017-09-22 11:10:34) > On 22/09/17 18:47, Nirbheek Chauhan wrote: > > On Fri, Sep 22, 2017 at 10:19 PM, Jose Fonseca wrote: > >> cmake provides a generic mechanism to set any variable, either from a > >> command line -DFOO=boo, or via cache files. But

Re: [Mesa-dev] [PATCH 3/8] nir: add a helper for getting the bitmask for a variable's location

On Tuesday, September 12, 2017 4:37:30 PM PDT Timothy Arceri wrote: > --- > src/compiler/nir/nir.h | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h > index fab2110f619..e52a1006896 100644 > ---

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

On 22/09/17 18:47, Nirbheek Chauhan wrote: On Fri, Sep 22, 2017 at 10:19 PM, Jose Fonseca wrote: cmake provides a generic mechanism to set any variable, either from a command line -DFOO=boo, or via cache files. But meson didn't provide such standard mechanism AFAICT.

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

Quoting Nirbheek Chauhan (2017-09-22 10:47:51) > So it seems to me that wrapping binaries is the only major feature > that is being an obstacle for you to port mesademos? I will publish an > example for doing that via subprojects, that should help! > > Cheers, > Nirbheek That would be very

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

On Fri, Sep 22, 2017 at 10:19 PM, Jose Fonseca wrote: > cmake provides a generic mechanism to set any variable, either from a > command line -DFOO=boo, or via cache files. But meson didn't provide such > standard mechanism AFAICT. > In Meson you must define an option to

Re: [Mesa-dev] [PATCH 07/22] glsl: Fix coding standards issues in lower_variable_index_to_cond_assign

2017-09-21 16:34 GMT+02:00 Ian Romanick : > From: "\"Ian Romanick\"" > ^ Something weird going on here? Apart from that, patches 1 - 7 are: Reviewed-by: Thomas Helland The regression from patch six I have no comments on.

Re: [Mesa-dev] [PATCH 2/8] glsl: mark xfb varyings as always active

On Tuesday, September 12, 2017 4:37:29 PM PDT Timothy Arceri wrote: > This will be used by the nir linking pass so that we don't remove > otherwise unused varyings. > --- > src/compiler/glsl/link_varyings.cpp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

On 21/09/17 09:56, Nirbheek Chauhan wrote: On Thu, Sep 21, 2017 at 1:53 PM, Jose Fonseca wrote: On 12/04/17 18:57, Nirbheek Chauhan wrote: Hi Jose, On Wed, Apr 12, 2017 at 11:08 PM, Jose Fonseca wrote: One newbie question: what's your workflow to

Re: [Mesa-dev] [PATCH 03/22] glsl: Fix coding standards issues in lower_vec_index_to_cond_assign

On Friday, September 22, 2017 7:00:14 AM PDT Ian Romanick wrote: > On 09/22/2017 05:52 AM, Alejandro Piñeiro wrote: > > > > > > On 21/09/17 16:34, Ian Romanick wrote: > >> From: "\"Ian Romanick\"" > >> > >> From: Ian Romanick > >> > >> Mostly

Re: [Mesa-dev] [PATCH 1/3] radv: make use of ATI_VENDOR_ID everywhere

Reviewed-by: Bas Nieuwenhuizen for the series. On Fri, Sep 22, 2017 at 9:21 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_device.c | 4 ++-- >

[Mesa-dev] [PATCH 3/3] radv: make radv_pipeline_init() static

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 2 +- src/amd/vulkan/radv_private.h | 7 --- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index

[Mesa-dev] [PATCH 1/3] radv: make use of ATI_VENDOR_ID everywhere

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 4 ++-- src/amd/vulkan/radv_image.c | 2 +- src/amd/vulkan/radv_pipeline_cache.c | 4 ++-- src/amd/vulkan/radv_private.h| 2 ++ 4 files changed, 7 insertions(+), 5 deletions(-)

[Mesa-dev] [PATCH 2/3] radv: remove unused variable in radv_dump_annotated_shader()

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/amd/vulkan/radv_debug.c b/src/amd/vulkan/radv_debug.c index 9fedab4e26..97ccfac694 100644 --- a/src/amd/vulkan/radv_debug.c +++

[Mesa-dev] [PATCH 1/2] radv: dump NIR when a GPU hang is detected

This looks a bit ugly to me, but the existing codepath is not terribly elegant as well. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.c| 10 -- src/amd/vulkan/radv_pipeline.c | 12 ++-- src/amd/vulkan/radv_shader.c | 10 --

[Mesa-dev] [PATCH 2/2] radv: dump SPIRV when a GPU hang is detected

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.c | 9 +++-- src/amd/vulkan/radv_debug.h | 2 +- src/amd/vulkan/radv_shader.c | 4 +++- src/amd/vulkan/radv_shader.h | 2 ++ 4 files changed, 13 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] initial meson port

On 21/09/17 01:20, Eric Anholt wrote: Dylan Baker writes: Results autotools : sh -c 535.34s user 30.33s system 310% cpu 3:02.05 total meson : sh -c 136.58s user 11.98s system 372% cpu 39.895 total I just want to point at these numbers again. meson is so

Re: [Mesa-dev] [PATCH] radv: init the trace BO before compiling meta shaders

r-b On Fri, Sep 22, 2017 at 6:16 AM, Samuel Pitoiset wrote: > Otherwise, the disasm string is NULL for meta shaders. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_device.c | 10 +- > 1 file changed, 5 insertions(+),

Re: [Mesa-dev] [PATCH] anv: fix viewport transformation for z component

Reviewed-by: Jason Ekstrand Cc: mesa-sta...@lists.freedesktop.org On Fri, Sep 22, 2017 at 3:22 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > Kindly reminder that this patch is still unreviewed. > > Sam > > On Friday, September 15, 2017 11:50:46 AM CEST you

[Mesa-dev] [PATCH 2/2] intel/compiler: Use emit_emplace in the builders

Replaces all calls of the form emit(instruction(…)) with emit_emplace(…). This should avoid a redundant copy of the stack-allocated temporary instruction. Although the temporary would have been stack-allocated so it might not seem like a big deal, the instructions do also have an internal

[Mesa-dev] [PATCH 1/2] intel/compiler: Add a placement version of emit to the builders

Adds “emit_emplace” to emit an instruction that is constructed inplace with the parameters given. This will be used instead of the pattern of doing emit(instruction(…)) because that ends up calling emit(const instruction&) which implies doing a copy. The “emplace” terminology comes from

Re: [Mesa-dev] [PATCH v3 1/6] vulkan: enum generator: align function declarations/prototypes

I went ahead and pushed v2 of the series with some of chad's comments addressed. Thanks for reviewing! On Thu, Sep 21, 2017 at 5:14 PM, Chad Versace wrote: > On Thu 21 Sep 2017, Jason Ekstrand wrote: > > From: Lionel Landwerlin > > > >

Re: [Mesa-dev] [PATCH 3/8] compiler/blob: Rework blob_reserve_bytes

On Fri, Sep 22, 2017 at 7:18 AM, Connor Abbott wrote: > I like the version I wrote a little better. The main difference is > that instead of the alignment parameter, I added a > blob_reserve_intptr() function to match blob_read_intptr() and > blob_write_intptr(). I also

Re: [Mesa-dev] [PATCH 3/8] compiler/blob: Rework blob_reserve_bytes

I like the version I wrote a little better. The main difference is that instead of the alignment parameter, I added a blob_reserve_intptr() function to match blob_read_intptr() and blob_write_intptr(). I also updated the doxygen comment for the function, and had a little more descriptive commit

Re: [Mesa-dev] [PATCH] glcpp: Avoid unnecessary call to strlen

This patch is Reviewed-by: Ian Romanick I have a couple patches that go on top of this particular patch, and I'd rather rebase before I send them out for review. :) On 09/14/2017 03:39 PM, Thomas Helland wrote: > Length of the token was already calculated by flex and

Re: [Mesa-dev] [PATCH 03/22] glsl: Fix coding standards issues in lower_vec_index_to_cond_assign

On 22/09/17 16:00, Ian Romanick wrote: > On 09/22/2017 05:52 AM, Alejandro Piñeiro wrote: >> >> On 21/09/17 16:34, Ian Romanick wrote: >>> From: "\"Ian Romanick\"" >>> >>> From: Ian Romanick >>> >>> Mostly tabs-before-spaces, but there was some

Re: [Mesa-dev] [PATCH 03/22] glsl: Fix coding standards issues in lower_vec_index_to_cond_assign

On 09/22/2017 05:52 AM, Alejandro Piñeiro wrote: > > > On 21/09/17 16:34, Ian Romanick wrote: >> From: "\"Ian Romanick\"" >> >> From: Ian Romanick >> >> Mostly tabs-before-spaces, but there was some other trivium too. >> >> Signed-off-by: Ian

[Mesa-dev] [PATCH] etnaviv: Add missing includes after 6ace0b8

Add missing includes after 6ace0b8 (etnaviv: don't enable RT full-overwrite when logicop is enabled), otherwise the etnaviv driver won't build because of missing macros. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_blend.c | 2 ++ 1 file

Re: [Mesa-dev] [PATCH] osdemos: support building via cmake

On Friday, 2017-09-22 11:37:43 +, Tommy wrote: > Uses pkg-config to find osmesa, and builds only if found. Thanks! Reviewed-by: Eric Engestrom Tested-by: Eric Engestrom Do you want me to push this for you? > --- > CMakeLists.txt

Re: [Mesa-dev] [PATCH] etnaviv: fix 16bpp clears

2017-09-22 11:24 GMT+02:00 Lucas Stach : > util_pack_color may leave undefined values in the upper half of the packed > integer. As our hardware needs the upper 16 bits to mirror the lower 16bits, > this breaks clears of those formats if the undefined values aren't masked

[Mesa-dev] [PATCH] radv: init the trace BO before compiling meta shaders

Otherwise, the disasm string is NULL for meta shaders. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index

[Mesa-dev] [PATCH] osdemos: support building via cmake

Uses pkg-config to find osmesa, and builds only if found. --- CMakeLists.txt | 1 + src/CMakeLists.txt | 4 src/osdemos/CMakeLists.txt | 31 +++ 3 files changed, 36 insertions(+) create mode 100644 src/osdemos/CMakeLists.txt diff --git

Re: [Mesa-dev] [PATCH 00/22] Send ir_assignment::condition to the Upside Down

Took a look to the series, and although it is not the part of the code base Im more used too, it looks good to me (except some nitpicks pointed on specific patches). Having said so, I don't have too much to say on the two bits you mention about patches 6 and patches 18, so probably you want

Re: [Mesa-dev] [PATCH 18/22] glsl: Move 'foo = foo; ' optimization to opt_dead_code_local

On 21/09/17 16:34, Ian Romanick wrote: > From: "\"Ian Romanick\"" > > From: Ian Romanick > > The optimization as done in opt_copy_propagation would have to be > removed in the next patch, and doing so would lead to some substantial > regressions.

Re: [Mesa-dev] [PATCH 14/22] glsl/ast: Generate a more compact expression to disable execution of default case

On 21/09/17 16:34, Ian Romanick wrote: > From: "\"Ian Romanick\"" > > From: Ian Romanick > > Instead of generating a sequence like: > > run_default = true; > if (i == 3) // some label that appears after default > run_default =

Re: [Mesa-dev] [PATCH 03/22] glsl: Fix coding standards issues in lower_vec_index_to_cond_assign

On 21/09/17 16:34, Ian Romanick wrote: > From: "\"Ian Romanick\"" > > From: Ian Romanick > > Mostly tabs-before-spaces, but there was some other trivium too. > > Signed-off-by: Ian Romanick > --- >

Re: [Mesa-dev] [PATCH 2/2] st/va: Implement vaExportSurfaceHandle()

Am 21.09.2017 um 21:00 schrieb Mark Thompson: On 20/09/17 09:14, Christian König wrote: Am 20.09.2017 um 00:01 schrieb Mark Thompson: This is a new interface in libva2 to support wider use-cases of passing surfaces to external APIs. In particular, this allows export of NV12 and P010 surfaces.

Re: [Mesa-dev] [PATCH] etnaviv: fix 16bpp clears

On Fri, Sep 22, 2017 at 11:24:08AM +0200, Lucas Stach wrote: > util_pack_color may leave undefined values in the upper half of the packed > integer. As our hardware needs the upper 16 bits to mirror the lower 16bits, > this breaks clears of those formats if the undefined values aren't masked off.

Re: [Mesa-dev] [PATCH] anv: fix viewport transformation for z component

Kindly reminder that this patch is still unreviewed. Sam On Friday, September 15, 2017 11:50:46 AM CEST you wrote: > In Vulkan, for 'z' (depth) component, the scale and translate values > for the viewport transformation are: > > pz = maxDepth - minDepth > oz = minDepth > > zf = pz × zd + oz >

Re: [Mesa-dev] [Mesa-announce] Mesa 17.1.10 release candidate

On Fri, 2017-09-22 at 16:38 +1000, Timothy Arceri wrote: > On 22/09/17 05:10, Juan A. Suarez Romero wrote: > > Hello list, > > > > The candidate for the Mesa 17.1.10 is now available. Currently we have: > > - 41 queued > > - 0 nominated (outstanding) > > - and 5 rejected patches > > > >

[Mesa-dev] [PATCH v2 2/3] etnaviv: add resource subregion copy

This is useful if we only need to copy part of a larger resource, mostly when using the RS engine to de-/tile on pipe transfers. Signed-off-by: Lucas Stach Reviewed-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 27

[Mesa-dev] [PATCH v2 1/3] etnaviv: support tile aligned RS blits

The RS can blit abitrary tile aligned subregions of a resource by adjusting the buffer offset. Signed-off-by: Lucas Stach --- v2: - add asserts, so we catch any invalid use of the RS - split out tile mask computation, to make it easier to read the code ---

[Mesa-dev] [PATCH v2 3/3] etnaviv: optimize RS transfers

Currently we are blitting the whole resource when the RS is used to de-/tile a resource. This can be very inefficient for large resources where the transfer is only changing a small part of the resource (happens a lot with glTexSubImage2D). Optimize this by only blitting the tile aligned

[Mesa-dev] [PATCH v3 2/2] etnaviv: remove flat shading workaround

It turned out not to be a hardware bug, but the shader compiler emitting wrong varying component use information. With that fixed we can turn flat shading back on. Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel Reviewed-by: Wladimir J. van

[Mesa-dev] [PATCH v3 1/2] etnaviv: fix varying interpolation

It seems that newer cores don't use the PA_ATTRIBUTES to decide if the varying should bypass the flat shading, but derive this from the component use. This fixes flat shading on GC880+. VARYING_COMPONENT_USE_POINTCOORD is a bit of a misnomer now, as it isn't only used for pointcoords, but missing

[Mesa-dev] [PATCH] etnaviv: fix 16bpp clears

util_pack_color may leave undefined values in the upper half of the packed integer. As our hardware needs the upper 16 bits to mirror the lower 16bits, this breaks clears of those formats if the undefined values aren't masked off. I've only observed the issue with R5G6B5_UNORM surfaces, other

Re: [Mesa-dev] [PATCH 2/2] radeonsi: remove useless check in si_blit_decompress_color()

Am Freitag, den 22.09.2017, 09:22 +0200 schrieb Samuel Pitoiset: > That's unnecessary to double-check that dcc_offset is not 0 > because all callers already check that. In that case I would suggest to add an assert(rtex->dcc_offset) to ensure this. Best, Gert > > Signed-off-by: Samuel

[Mesa-dev] [PATCH 2/2] radeonsi: remove useless check in si_blit_decompress_color()

That's unnecessary to double-check that dcc_offset is not 0 because all callers already check that. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/2] gallium/radeon: more use of vi_dcc_formats_are_incompatible()

Found by inspection. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeon/r600_texture.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index

Re: [Mesa-dev] [Mesa-announce] Mesa 17.1.10 release candidate

On 22/09/17 05:10, Juan A. Suarez Romero wrote: Hello list, The candidate for the Mesa 17.1.10 is now available. Currently we have: - 41 queued - 0 nominated (outstanding) - and 5 rejected patches This is the last release for the 17.1 series. In the current queue we have: In build and